GNU bug report logs - #64283
29.0.91; js-mode's mark-defun does not work correctly when functions have a comment on top

Previous Next

Full log

Message #14 received at 64283 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Martín <mardani29 <at> yahoo.es>, Yuan Fu
 <casouri <at> gmail.com>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 64283 <at> debbugs.gnu.org
Subject: Re: bug#64283: 29.0.91;
 js-mode's mark-defun does not work correctly when functions have a
 comment on top
Date: Sun, 25 Jun 2023 18:05:07 +0300

> Date: Sun, 25 Jun 2023 15:38:12 +0200
> From:  Daniel Martín via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Daniel Martín via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs <at> gnu.org> writes:
> 
> > This is a regression from Emacs 28.2.
> >
> 
> This is the first commit where this bug happens:
> 
> commit 4489450f37deafb013b1f0fc00c89f0973fda14a
> Author: Yuan Fu <casouri <at> gmail.com>
> Date:   Thu Nov 10 15:00:29 2022 -0800
> 
>     In end-of-defun, terminate early if no further defun exists
>     
>     Before this change, end-of-defun calls end-of-defun-function even if
>     point is not necessarily at the beginning of a defun (contrary to what
>     end-of-defun-function's docstring claims).  Now it terminates early
>     and doesn't call end-of-defun-function.
>     
>     * lisp/emacs-lisp/lisp.el (beginning-of-defun-raw): Update docstring
>     clarifying the return value.
>     (end-of-defun): Terminate early if beginning-of-defun-raw returns nil.

Yuan, could you please look into this?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.