GNU bug report logs - #64275
30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode

Previous Next

Package: emacs;

Reported by: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>

Date: Sat, 24 Jun 2023 20:18:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Dmitry Gutov <dmitry <at> gutov.dev>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>, Basil Contovounesios <contovob <at> tcd.ie>
Cc: 64275 <at> debbugs.gnu.org
Subject: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode
Date: Sun, 30 Jul 2023 05:06:37 +0300
On 25/06/2023 12:00, Wilhelm Kirschbaum wrote:
>         "~" @font-lock-string-face
>         (sigil_name) @elixir-ts-font-sigil-name-face
>         (:match "^[rR]$" @elixir-ts-font-sigil-name-face))
>        @font-lock-regexp-face
> -     (sigil
> -      "~" @font-lock-string-face
> -      (sigil_name) @elixir-ts-font-sigil-name-face
> -      quoted_start: _ @font-lock-string-face
> -      quoted_end: _ @font-lock-string-face
> -      (:match "^[HF]$" @elixir-ts-font-sigil-name-face)))
> -
> +     (sigil) @font-lock-string-face)

Hi Wilhelm!

Should we continue to use elixir-ts-font-sigil-name-face, though?

With the new patch, it will continue highlight the sigil name ("r") in 
regexps, but no in other sigil types (s/c/w).

What's your opinion on that?




This bug report was last modified 1 year and 261 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.