From unknown Fri Jun 20 07:21:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64275 <64275@debbugs.gnu.org> To: bug#64275 <64275@debbugs.gnu.org> Subject: Status: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Reply-To: bug#64275 <64275@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:21:43 +0000 retitle 64275 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-= mode reassign 64275 emacs submitter 64275 Wilhelm Kirschbaum severity 64275 normal tag 64275 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 16:17:28 2023 Received: (at submit) by debbugs.gnu.org; 24 Jun 2023 20:17:28 +0000 Received: from localhost ([127.0.0.1]:41574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD9hI-0004Ji-0L for submit@debbugs.gnu.org; Sat, 24 Jun 2023 16:17:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:38290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD9hF-0004JY-MV for submit@debbugs.gnu.org; Sat, 24 Jun 2023 16:17:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD9hF-0000g1-A4 for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 16:17:25 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qD9hD-0000fC-P7 for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 16:17:25 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-31272fcedf6so1688674f8f.2 for ; Sat, 24 Jun 2023 13:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687637842; x=1690229842; h=mime-version:message-id:date:subject:to:from:user-agent:from:to:cc :subject:date:message-id:reply-to; bh=wpStVPHDWRE0K5q6L7gTsvEeegn0umXwEOnXBowKP0o=; b=hd6KRfTeKJJwQrmxMH8mE6tBCZg/QiqtumqDtkjXiDmuFIb6ZNF5GoWJXbMidpZjpM MkDTuBOhBQ4HVZdRiXCeg61lqJJePEHH9+fTomCCjBbkffXLL2D45qIJX4kf+E0VrUYM y8O4s6rICrVdARk61zl/TSsyTZlP6pLtcDFrtd6QKaUYd2xoPskrv7xq8yMxVmn4733B i+nVJ8Kj7JLcgKZF+li3viNabzNlx4aDwILUUK1G1JB7IaT+a6ij4ZN1pIP+2i02QhSO IQuMCoNu/lpPoxbpMB1AS9dvkkLsgx7TUQB2Z1QpQVQiP8tSBOk7oFmFgBWx6ddxY91d A/UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687637842; x=1690229842; h=mime-version:message-id:date:subject:to:from:user-agent :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wpStVPHDWRE0K5q6L7gTsvEeegn0umXwEOnXBowKP0o=; b=NLQMiySGruhIroyPHGKfWSMtV7bvcRt86TM0yiG5c+nZ+qIoNUzsxFAQ7PucI9Plua 0Z0I9ZCYWF8qQScwec8wbNIwrMQwR0qONuLNw2qxo8RHS0z2TVkREzkEcA+uS/V2tsel ZzM3zUKX5QozLjwPogKptwe+mUTuUx7uaMN79hDu4Seie+8CHHPVSJhSOQmCAkgP8VmG zl5GQgZMVamnXzOIqe7EfuiBkVde6+84Cpd7ZjhHOi/87llw9erui8c2tSwDm3htkIsY mHqk6wmnXUqYrj8E+nOfeSYYnaEqbOWFe2DyAH7O7V1DsnOZfyMJCqOT/fUS98KWzjsc kLag== X-Gm-Message-State: AC+VfDwDL2w5RF9QD8etlqXtmGtw54BjdJLSo8KG8P8mOhzM/tEthanu unJH7z/z8TGwItoDpsAyjreE8FMzWTo= X-Google-Smtp-Source: ACHHUZ6Wz6X2UQ6E5vaVROmVaWox4moUcgSPm5NVrt/RRVV9y9FBzjoeVPoYLpa/GY11RRh+GqG6UQ== X-Received: by 2002:a5d:6a4b:0:b0:313:e971:53a8 with SMTP id t11-20020a5d6a4b000000b00313e97153a8mr434118wrw.18.1687637842056; Sat, 24 Jun 2023 13:17:22 -0700 (PDT) Received: from melissa.local (ec2-13-245-180-173.af-south-1.compute.amazonaws.com. [13.245.180.173]) by smtp.gmail.com with ESMTPSA id l13-20020a5d674d000000b003113513f491sm2836869wrw.114.2023.06.24.13.17.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jun 2023 13:17:21 -0700 (PDT) User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Sat, 24 Jun 2023 22:14:17 +0200 Message-ID: <87zg4od38w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=wkirschbaum@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; format=flowed This patch updates the sigil matching for Elixir. We don't need to know what the sigil is to be able to set the font. The one exception is regex via a sigil. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-eglot-imenu-when-the-server-does-not-support-it.patch >From 9a1389305d92f0e08d39d2ff5540cb494c012f12 Mon Sep 17 00:00:00 2001 From: Wilhelm H Kirschbaum Date: Sat, 24 Jun 2023 21:54:30 +0200 Subject: [PATCH 1/1] Fix eglot-imenu when the server does not support it A language server might not support textDocument/documentSymbol, so we need to check first. * lisp/progmodes/eglot.el (eglot-imenu): Check for the textDocument/documentSymbol capability before requesting. --- lisp/progmodes/eglot.el | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index e2478f2dde3..265cfc88579 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -3351,16 +3351,17 @@ eglot--imenu-DocumentSymbol (defun eglot-imenu () "Eglot's `imenu-create-index-function'. Returns a list as described in docstring of `imenu--index-alist'." - (let* ((res (eglot--request (eglot--current-server-or-lose) - :textDocument/documentSymbol - `(:textDocument - ,(eglot--TextDocumentIdentifier)) - :cancel-on-input non-essential)) - (head (and (cl-plusp (length res)) (elt res 0)))) - (when head - (eglot--dcase head - (((SymbolInformation)) (eglot--imenu-SymbolInformation res)) - (((DocumentSymbol)) (eglot--imenu-DocumentSymbol res)))))) + (when (eglot--server-capable :textDocument/documentSymbol) + (let* ((res (eglot--request (eglot--current-server-or-lose) + :textDocument/documentSymbol + `(:textDocument + ,(eglot--TextDocumentIdentifier)) + :cancel-on-input non-essential)) + (head (and (cl-plusp (length res)) (elt res 0)))) + (when head + (eglot--dcase head + (((SymbolInformation)) (eglot--imenu-SymbolInformation res)) + (((DocumentSymbol)) (eglot--imenu-DocumentSymbol res))))))) (cl-defun eglot--apply-text-edits (edits &optional version) "Apply EDITS for current buffer if at VERSION, or if it's nil." -- 2.41.0 --=-=-= Content-Type: text/plain; format=flowed Wilhelm --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 25 04:54:10 2023 Received: (at 64275) by debbugs.gnu.org; 25 Jun 2023 08:54:10 +0000 Received: from localhost ([127.0.0.1]:42009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDLVa-0006ks-C6 for submit@debbugs.gnu.org; Sun, 25 Jun 2023 04:54:10 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:54723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDLVT-0006k9-7R for 64275@debbugs.gnu.org; Sun, 25 Jun 2023 04:54:08 -0400 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-31129591288so1854251f8f.1 for <64275@debbugs.gnu.org>; Sun, 25 Jun 2023 01:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1687683237; x=1690275237; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZxmtsZon5sHJWZD9Z7U2ORONMmSI+jDOkJTMSt2hJ9E=; b=dIKky2e85yDiKoQCBk9ji04Ic4TD7yxDms019NnYgm7oEWKvkjFpXNMGHpFsl0hAyD WYxO9RukEjr7sJvy1BZyEqJOaBB6J83Ih+uoiY5anmUjjRRbv5YspwdS0HBQHES4XDeQ YRmeAYt/EhQTfLq+dbg3cGnlrUi0m8vVBfGdxvqMu3p3dMUduHA5FZadc2qiF3g/e3hQ M7LGfa0TfoUeKpDj3ZybtLB72KF45wyQHHsRyAG1kUF7p6CXDvIRaL3JfhcZsfuLfMKo w/zt096NlaxwCH8+lt/SbNjRu+Q48iHjMQBxIhjWxVVrV9VhkCY0BUFOpZ/W17+PR8en xlBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687683237; x=1690275237; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZxmtsZon5sHJWZD9Z7U2ORONMmSI+jDOkJTMSt2hJ9E=; b=iuv62MTmZvvwInxeDUscqtmvF2A9eVnlV6KwAKvFmfX1H0V3f4dGaKCv5Ji8d5l7E6 L1jJycZN6EK9P/GxCOkrNYVhMZn9BLYnB9XTyFtB5gWyAajjWIn0Z2p3qxnZOArFfJqx kMD5NErtNSFFow3poIa+AuzHtghNK/EEaQQhcxHdy1yLcbvX5W0zi8xIwzv5eKA9S08Y k5N2rwO5W8BG98WFpLqZD50/s5Ak9orJ049e0F0Gs7ArPgMLlAtbvFvTrhyqo41v5tna 7L1v1i4GVOPJmlbki52KaLeavNHdEUes5pGvjhpTqvJZr+gz2b1QLhcWV/xgXx9sCERz YrgA== X-Gm-Message-State: AC+VfDznIKihk7T6bOVqUDe3U9JuUxPqqhZER+k9OIGE5yWU+tocKzi4 eoS0xIpshx+jncV0QGg2nM2UrA== X-Google-Smtp-Source: ACHHUZ4b6LvVQo3MF4hME4Y8WbiL+q+Ig07pCTZxZ8gJa7w/df37aL5Pz/uCQey0ZXOXb82qZpHg7Q== X-Received: by 2002:adf:dcc2:0:b0:306:2d15:fc35 with SMTP id x2-20020adfdcc2000000b003062d15fc35mr19731721wrm.37.1687683237305; Sun, 25 Jun 2023 01:53:57 -0700 (PDT) Received: from localhost ([78.152.249.199]) by smtp.gmail.com with ESMTPSA id e1-20020a5d5941000000b00313e59cb371sm2901883wri.12.2023.06.25.01.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jun 2023 01:53:56 -0700 (PDT) From: Basil Contovounesios To: Wilhelm Kirschbaum Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode In-Reply-To: <87zg4od38w.fsf@gmail.com> (Wilhelm Kirschbaum's message of "Sat, 24 Jun 2023 22:14:17 +0200") References: <87zg4od38w.fsf@gmail.com> Date: Sun, 25 Jun 2023 09:53:55 +0100 Message-ID: <87ttuvorbw.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64275 Cc: 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Wilhelm Kirschbaum [2023-06-24 22:14 +0200] wrote: > This patch updates the sigil matching for Elixir. We don't need to know > what the sigil is to be able to set the font. The one exception is > regex via a sigil. > > From 9a1389305d92f0e08d39d2ff5540cb494c012f12 Mon Sep 17 00:00:00 2001 > From: Wilhelm H Kirschbaum > Date: Sat, 24 Jun 2023 21:54:30 +0200 > Subject: [PATCH 1/1] Fix eglot-imenu when the server does not support it Looks like the patch from bug#64274 was attached instead. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 25 05:02:07 2023 Received: (at 64275) by debbugs.gnu.org; 25 Jun 2023 09:02:07 +0000 Received: from localhost ([127.0.0.1]:42013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDLdH-00075Q-AO for submit@debbugs.gnu.org; Sun, 25 Jun 2023 05:02:07 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:52492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDLdC-00074d-1g for 64275@debbugs.gnu.org; Sun, 25 Jun 2023 05:02:05 -0400 Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3128fcd58f3so2655399f8f.1 for <64275@debbugs.gnu.org>; Sun, 25 Jun 2023 02:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687683716; x=1690275716; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=7oVJWTWgFsBRZk2Dkwt6rlOlesTvgEYAXR1C/BAqWI0=; b=i341RMjZ1fbADX48DOIc88HNKGU8zP9gIbacWjehd0+VDcXIvSH+8wqbpXQEXLOlYx 3HdMV5D4pEDlAeXjkpM5z0FggTj810wWjbKMriGjM9i4RMEoki1PqivJ+liP1RzNe9Yi /OyM8F6JrQ+uTFN/W+1zWID5XEV105aMK04cJlHOWfeYQWlz7A5bzLtqHUp68DssV65b ljCpGGO1lZnDWlSGGiU8AQyIVXkAklRLibB7RZshgKj/KekZXzphzUGe8c+IEcaOaB6Z 3Lw/NGh2zXw+UXO6Tdr0M2Vo5qxHSh7JK07iLXWDUTB8ok0ipVdgWxxUXwsWU2vR7kiJ XTtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687683716; x=1690275716; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7oVJWTWgFsBRZk2Dkwt6rlOlesTvgEYAXR1C/BAqWI0=; b=i90Qq8f1BKclhmuA6VCUu2aWW9actotB7fCSGVtEtXlAHwTRjdFPjt8CURXsUs3xIX xpy6wjMsruLvWW4NHolncZpg/BaZIES+csV5WHbYToENUVi1hLl5Jip5rSV26ELsYIvh TIqy9RnbzrTEMW2RVURJcOKCGt0D+TaiW2q7enLK6HdUEnDCbtS4p5EM8CSZOZQhB6Um ZOn1s1FTEW0PaQyJ+a9z1921gokjOMOmKAr5Dtf1VoGMykDdKcuYULx15kSBiXbCPmki BDDPFDnsXRvpurbePrs4ZYcZcK8dzMc9XJGv4IB1Nm4YS/mqDyfPagGZouC4aPDP/3/k tuKQ== X-Gm-Message-State: AC+VfDyyfWewPskzoieSUyAu9QtDg+E0E+6DhjidpiswJE1niKds3HQT aPohyCuggzg5xYNxMcoRaeZ+l5Zh9z2V1w== X-Google-Smtp-Source: ACHHUZ4Q6zHtTN1j1tmf60uvjcskjjWITLSlLFeu3HYHmFKhrQWYgRTG2Tfh9hd9QDAoj5ygSLHTXg== X-Received: by 2002:adf:e910:0:b0:30a:d8f3:3e41 with SMTP id f16-20020adfe910000000b0030ad8f33e41mr20232534wrm.7.1687683715815; Sun, 25 Jun 2023 02:01:55 -0700 (PDT) Received: from melissa.local (ec2-13-245-180-173.af-south-1.compute.amazonaws.com. [13.245.180.173]) by smtp.gmail.com with ESMTPSA id v1-20020adfe281000000b00311299df211sm4058159wri.77.2023.06.25.02.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jun 2023 02:01:55 -0700 (PDT) References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: Basil Contovounesios Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Sun, 25 Jun 2023 11:00:44 +0200 In-reply-to: <87ttuvorbw.fsf@epfl.ch> Message-ID: <87y1k7j4ov.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64275 Cc: 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed > Looks like the patch from bug#64274 was attached instead. Ah, sorry. Here is the correct patch. Wilhelm --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Update-sigil-font-lock-match-for-elixir-ts-mode.patch >From 20dd06d1cac05e775ce9f143550483cd2ad1a9ee Mon Sep 17 00:00:00 2001 From: Wilhelm H Kirschbaum Date: Mon, 22 May 2023 08:53:24 +0200 Subject: [PATCH 1/3] Update sigil font-lock match for elixir-ts-mode There is no need to match on specific sigils, except for regex. * lisp/progmodes/elixir-ts-mode.el (elixir-ts--font-lock-settings): Update sigil match. --- lisp/progmodes/elixir-ts-mode.el | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/lisp/progmodes/elixir-ts-mode.el b/lisp/progmodes/elixir-ts-mode.el index 7175fe4bff8..54b9740858f 100644 --- a/lisp/progmodes/elixir-ts-mode.el +++ b/lisp/progmodes/elixir-ts-mode.el @@ -458,21 +458,11 @@ elixir-ts--font-lock-settings :feature 'elixir-sigil :override t `((sigil - (sigil_name) @elixir-ts-font-sigil-name-face - (:match "^[sSwWpPUD]$" @elixir-ts-font-sigil-name-face)) - @font-lock-string-face - (sigil "~" @font-lock-string-face (sigil_name) @elixir-ts-font-sigil-name-face (:match "^[rR]$" @elixir-ts-font-sigil-name-face)) @font-lock-regexp-face - (sigil - "~" @font-lock-string-face - (sigil_name) @elixir-ts-font-sigil-name-face - quoted_start: _ @font-lock-string-face - quoted_end: _ @font-lock-string-face - (:match "^[HF]$" @elixir-ts-font-sigil-name-face))) - + (sigil) @font-lock-string-face) :language 'elixir :feature 'elixir-string-escape :override t -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 14:36:36 2023 Received: (at 64275) by debbugs.gnu.org; 29 Jul 2023 18:36:36 +0000 Received: from localhost ([127.0.0.1]:48984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPonr-0007xn-Ow for submit@debbugs.gnu.org; Sat, 29 Jul 2023 14:36:35 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:49536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPonq-0007xa-Fe for 64275@debbugs.gnu.org; Sat, 29 Jul 2023 14:36:35 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3176a439606so3077620f8f.3 for <64275@debbugs.gnu.org>; Sat, 29 Jul 2023 11:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690655788; x=1691260588; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=2DCmZVTtC55gznFHW3YQaTRMjJtHQTTaO6m0u52sqsE=; b=LmfLJapQfdeCL11n/17dCFyH22mWtVxUDwpOC1HlDGUw+iXacb23oEuULMuIg/t/o7 p95CXFoY1c9K98w9Ks7+Sv4aSiFMUh2y0yWhwQ6g5YJ7bpNFgG+dEsst1U0bgSnHge8B hWNC+z8Q2weqNYA2xt8+m/ThOPViQ3YvDR9a1h/Dd1K5UiPCxoeGd4RgFs3BuD6FavGw lSjPzEXAZgyTi+RJk6GxwRQBXHsYPpjm3nBE5ON9KT0bPKSgfP5tYz0VmHAfOhxXOyT6 eCZDGr1WWToL7hLjSlnMUJxsTsD/VeQvAAKMH+Gj1wwnmGhHXtC/R1OPU+3nBYMISkFt Qxiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690655788; x=1691260588; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2DCmZVTtC55gznFHW3YQaTRMjJtHQTTaO6m0u52sqsE=; b=baDLf449oAIGu1PMmQ99uFIows4i138ydSkkksSuov2bd+K6XgkUUWCr4Edp0uygJh wStHq0ZtkGuLrN/xXLK6WSEd5kiHyH0eiPAPt4zoab9edY/AnYBFCVGHCLmAQNLqVa8r oJL2+5DcU8s+IslhzXEm+zfXKN21wGNnyKEbGT1GCW1CQItJo9qLqoxbvITWzujpIEXa ROsA/JzLNRrSPJdoQfJ4eXie+DwN7PGulX2b7wjRx3K42RCeSQXUlJKdOe5ArkwJ7sTj YTIofpRqykjiGFv9FSGRaXTASzFFvho8oOESbuVsGvOvUcaRDR7A3wqyiY0jjmFXoH8l 6Uqg== X-Gm-Message-State: ABy/qLZqmBoHjJKk9As5Oi/J1ta3+6zxZfu/iuNvW1XbZpzhM1ecRI8M otNpRW0tOxCDSMQPCXupybjJHdCMKjo= X-Google-Smtp-Source: APBJJlEgPzGi/ymBh9zHtshvzX4AMHLxBFJUgjVBVdobVUgsOYSvvqC1C+xlA7otWsGlcwaa66ljdw== X-Received: by 2002:a5d:4d90:0:b0:314:2b0a:dabe with SMTP id b16-20020a5d4d90000000b003142b0adabemr3899548wru.30.1690655787581; Sat, 29 Jul 2023 11:36:27 -0700 (PDT) Received: from melissa.local ([2c0f:ef18:1431:0:b09:9616:db04:c248]) by smtp.gmail.com with ESMTPSA id y18-20020a5d6212000000b003143c6e09ccsm8139343wru.16.2023.07.29.11.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jul 2023 11:36:26 -0700 (PDT) References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: Basil Contovounesios Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Sat, 29 Jul 2023 20:31:05 +0200 In-reply-to: <87y1k7j4ov.fsf@gmail.com> Message-ID: <87edkqimzc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64275 Cc: 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Wilhelm Kirschbaum writes: >> Looks like the patch from bug#64274 was attached instead. > > Ah, sorry. Here is the correct patch. > > Wilhelm > > [2. text/x-patch; > 0001-Update-sigil-font-lock-match-for-elixir-ts-mode.patch]... Can this patch still be installed please? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 22:06:48 2023 Received: (at 64275) by debbugs.gnu.org; 30 Jul 2023 02:06:48 +0000 Received: from localhost ([127.0.0.1]:49116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPvpX-00021g-Pf for submit@debbugs.gnu.org; Sat, 29 Jul 2023 22:06:48 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPvpV-00021J-1K for 64275@debbugs.gnu.org; Sat, 29 Jul 2023 22:06:45 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 940F25C008C; Sat, 29 Jul 2023 22:06:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 29 Jul 2023 22:06:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690682799; x=1690769199; bh=isqnNNidy2AjoSBARl5sla5Fp5KsDbaskm1 wcCE1LAY=; b=IRKnJPWaugdPRQLLw4jbsB1D7B4evPipkq0qsdPhbCPCmNkh6Aj MnRtJSmWJvQaEXWeqELurvomr0DEqXqbF4A6be0CO/8mh3GXrhjHZ4O/jPc6bZL/ RK5OAf5eN129F+NOM9g7qT65k0Nnkxp6BWgxFhm4h+SQF9BNhzbETYhaHu5aRNb9 iy89iAQUpa4PrSSHKhWFGTBcBUxa+eeWQsamM8h8LOCrcOnvssaD/ImX4rETxt0c kdGmgp19MXgdyVobI+E22m45eUfcQvG0OUBtHTVxOxpo70VuqNba+F6tjj/3pZYn wciUst1AukX2iJrRW9hHhOVLARuekamG4tA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690682799; x=1690769199; bh=isqnNNidy2AjoSBARl5sla5Fp5KsDbaskm1 wcCE1LAY=; b=WiH61AzhoRfM9GKnGu+JIaaLzjwuVWbNCrlz8E2WmtiPwDjyE6N kFOs6Iz+oMlVAKsIeVWJ9o7SM5G4ZvgB9zT2MdD0n1m6YCxIgVb1CKgLUc5ZxBi4 WWYLqzvdFCp374BE48syDSBCb2iMG9wYZsxp19nSGjyKhrRk+T6arhZWNZDtuxb8 JRhTy8PCrTFjhufMe6IBNXDxoUmiM33coPrz/jYshvtcETRrAgE19KIi5prNdonI wAXA1Krq2a2/4Nsw0n3I/EzcOglnvf5Vcwp53AxM5sS2SPbZRzjgSp2JKwT2wkIt dyYpT7QMfhM7b5BdjRH+0ws9yAP1WpEptJA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieelgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 Jul 2023 22:06:38 -0400 (EDT) Message-ID: <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> Date: Sun, 30 Jul 2023 05:06:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Content-Language: en-US To: Wilhelm Kirschbaum , Basil Contovounesios References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87y1k7j4ov.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 64275 Cc: 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 25/06/2023 12:00, Wilhelm Kirschbaum wrote: > "~" @font-lock-string-face > (sigil_name) @elixir-ts-font-sigil-name-face > (:match "^[rR]$" @elixir-ts-font-sigil-name-face)) > @font-lock-regexp-face > - (sigil > - "~" @font-lock-string-face > - (sigil_name) @elixir-ts-font-sigil-name-face > - quoted_start: _ @font-lock-string-face > - quoted_end: _ @font-lock-string-face > - (:match "^[HF]$" @elixir-ts-font-sigil-name-face))) > - > + (sigil) @font-lock-string-face) Hi Wilhelm! Should we continue to use elixir-ts-font-sigil-name-face, though? With the new patch, it will continue highlight the sigil name ("r") in regexps, but no in other sigil types (s/c/w). What's your opinion on that? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 30 04:20:59 2023 Received: (at 64275) by debbugs.gnu.org; 30 Jul 2023 08:20:59 +0000 Received: from localhost ([127.0.0.1]:49304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQ1fe-00028D-Kp for submit@debbugs.gnu.org; Sun, 30 Jul 2023 04:20:58 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:52405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQ1fb-00027z-Pp for 64275@debbugs.gnu.org; Sun, 30 Jul 2023 04:20:56 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3fe167d4a18so12047765e9.0 for <64275@debbugs.gnu.org>; Sun, 30 Jul 2023 01:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690705250; x=1691310050; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=KVUJCTz9WSxTpqCNPQMj4qfIf6VQWRqmdOv0MZFoNz8=; b=JPRo8sB6t1OcUwMVJRPEnGwNrCyl29+y9VpseZjvkSnoniP6PCPN0JUZBk27koYp8z xH20DzfAuB5iGgTDH2nEQVul7eFKDWiOqFXLyBmaFVYOKii2eY246qV4D5csKrqQl/Rv nJK1Khb97LIhSyU2R4noffj7HPgybin3u8xqhd88kLKcjwAOE9f8sg+QaACeqjfWZ3JW Ad9VPm2AG8VjYPs9LKa3Y3YldtDT487UuVXu7G5AV6RZiv+yETEV5UkYjGcvWWYThzoM Inmv58vejGQ0eEdmgbfmP/uIeYj+iXlfBajoE6iYIQbw97KIoUtRjVr7yds06kp48G42 gSZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690705250; x=1691310050; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KVUJCTz9WSxTpqCNPQMj4qfIf6VQWRqmdOv0MZFoNz8=; b=i1TTfJi6BC0GIy++1OFVHiNOy6gjiIxbAHj2enPWN7sWvBur7+dqXTNe5ora8MV1vZ Vyjbd7scC9l8ZpLMdEiaetYhRGIMjrb5PoYfYlslXZGotxhTQ83OHaP3PIHMx8MViHD+ 9gjJAu5t4Z9AOjIf/9RIGtWeFvMGkghmgBp0oNIU4ccSjaHsjHwZ1IUjVyJVAqj1GZg7 ixJzAuyVRhN+rMNU0R4JX2WrvbakexE58ZjFcxLR57mWBkI0csCR7mPAbZ0WcUAnk0x7 jo+yUJhpw0NySc/RJXdOkO1ELxv7GQkZWX9WvMDsHRYdObk02OL3KdNgu+P4Ne2chtZk e/gw== X-Gm-Message-State: ABy/qLadT7mEpcBwZKwuZUk0TG2JQmVJXiM5ruGbcTkltC5ercgVDKqZ JPI7KfldEby7jYbbJEQN74vk3hdQjI0= X-Google-Smtp-Source: APBJJlFdIjy1+1nVqZ+WKknx/uR9twAn4g7fY6M9+vgyVl62AyFHO3govFj3aSE4+VakLkZjsp9NxQ== X-Received: by 2002:a7b:c450:0:b0:3fb:c990:3b2 with SMTP id l16-20020a7bc450000000b003fbc99003b2mr5332820wmi.34.1690705249442; Sun, 30 Jul 2023 01:20:49 -0700 (PDT) Received: from melissa.local ([2c0f:ef18:1431:0:b09:9616:db04:c248]) by smtp.gmail.com with ESMTPSA id p1-20020a7bcc81000000b003fa96fe2bebsm8271019wma.41.2023.07.30.01.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 01:20:49 -0700 (PDT) References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: Dmitry Gutov Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Sun, 30 Jul 2023 09:53:15 +0200 In-reply-to: <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> Message-ID: <87cz0995eq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64275 Cc: Basil Contovounesios , 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 25/06/2023 12:00, Wilhelm Kirschbaum wrote: >> "~" @font-lock-string-face >> (sigil_name) @elixir-ts-font-sigil-name-face >> (:match "^[rR]$" @elixir-ts-font-sigil-name-face)) >> @font-lock-regexp-face >> - (sigil >> - "~" @font-lock-string-face >> - (sigil_name) @elixir-ts-font-sigil-name-face >> - quoted_start: _ @font-lock-string-face >> - quoted_end: _ @font-lock-string-face >> - (:match "^[HF]$" @elixir-ts-font-sigil-name-face))) >> - >> + (sigil) @font-lock-string-face) > > Hi Wilhelm! > > Should we continue to use elixir-ts-font-sigil-name-face, > though? > Hi :) We still need to match only the sigil_name part, so can't use the @font-lock-string-face as it will exclude the '~', therefore we need a custom font for the match. This is only true for ~r/regex content here/ and ~R/regex content here/, or variance ~r(regex content here) etc. where the font for the regex part is different than the font for the sigil prefix. Perhaps there is another way to both apply a font with @font-lock-string-face and exclude it from the :match, but last time I checked this was not possible. > With the new patch, it will continue highlight the sigil name > ("r") in > regexps, but no in other sigil types (s/c/w). > Incorrect, just below there is a: (sigil) @font-lock-string-face) without a match, so they will be highlighted, but just more generically as we don't know which sigils the user might have assigned. > What's your opinion on that? As a baseline it makes sense to me to apply font-lock-string-face to all sigils, as they can be user defined. Some are language core sigils, like the ~r and ~R sigils and then there are common library accepted sigils like ~H and ~F which can effectively be seen as part of the language, these can be added over time as we improve this mode. The initial ideas was to try and match a complete list, but won't work. Users can also define sigils in their projects, so its better to rely on the grammar to tell us its a sigil. I ran the current patch for over a month and feels correct. Wilhelm From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 30 08:10:08 2023 Received: (at 64275) by debbugs.gnu.org; 30 Jul 2023 12:10:08 +0000 Received: from localhost ([127.0.0.1]:49476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQ5FO-0002DD-GE for submit@debbugs.gnu.org; Sun, 30 Jul 2023 08:10:08 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:60761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQ5FJ-0002CY-3G for 64275@debbugs.gnu.org; Sun, 30 Jul 2023 08:10:05 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 96F2D5C00E6; Sun, 30 Jul 2023 08:09:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 30 Jul 2023 08:09:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690718995; x=1690805395; bh=e4K57ZXPzmLcwYPkFI+PZGqz4CFEq24Fl98 K1gRrY6g=; b=d270cusUAchCl9G/r+0o5CHfxeKDl2HFMOdqqLcCeR3c1/RarwF r8wm29E/1pzEPNpDJZZXwlQ49mHGJ0zLuoidSPWtM+lY3U0n/igmQWe48BPzV4dY Bb8F4RqydGttM8KH67SOkNjLa94dUpk4bYce0pqQb/Q4bYBLbVVBLXitb7L9htJb K6Ovhb+wVQP7H2EwGyqGBYpY2syWWAjPqsTI59AKckFcpshn1Dwo7xEBIVvh3/t2 9XaZN2yZzM+7b2FtGZVnntxNy98ynfvoE3Gn+0+EQrOM06UpqtBOOu63K91XNqH5 EhlKgvts3REcKzdI0AMKHYKp71SFj5Y34NA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690718995; x=1690805395; bh=e4K57ZXPzmLcwYPkFI+PZGqz4CFEq24Fl98 K1gRrY6g=; b=qY5quYNhC/5aOeFDvpdq9zstAqhRdQfvSpeytoKjwTV8E/h1Vga EO8lUT7dQ16h1xMARZgMNmvi3qtFZY0xCsutrVbCxYF7sUAwG5dkQ321E8lzzPzI Ui//8AdqOANy3Fx0/ag8pj10srycuxp2UgukOCcQvTpcROmvIdurmIr0Ha5aoSOa b3kRCx0+1Gx2ytQaNJPqzagLKCEhDzl9aNjdXJ2CFS+wRJIcjvCpTD4GDlsWqVun qI35q8d0wrqniBMrlXlSCjTctWGpXp6iSbdTCTMUM3GqtMIIBgQv6uYj/Oza+HMD vKarv7ypqyDQ3GPRQU/MjBoN8/PJv2WDQAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjedugdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpefhffehleejffegffeugefhkeektdffgfehjedvgeejtedtudehueffgffgfeej heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Jul 2023 08:09:53 -0400 (EDT) Message-ID: <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> Date: Sun, 30 Jul 2023 15:09:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Content-Language: en-US To: Wilhelm Kirschbaum References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87cz0995eq.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 64275 Cc: Basil Contovounesios , 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 30/07/2023 10:53, Wilhelm Kirschbaum wrote: >> With the new patch, it will continue highlight the sigil name ("r") in >> regexps, but no in other sigil types (s/c/w). >> > > Incorrect, just below there is a: > >           (sigil) @font-lock-string-face) > > without a match, so they will be highlighted, but just more generically > as we don't know which sigils the user might have assigned. Why not add elixir-ts-font-sigil-name-face in that matcher as well? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 31 03:27:30 2023 Received: (at 64275) by debbugs.gnu.org; 31 Jul 2023 07:27:30 +0000 Received: from localhost ([127.0.0.1]:51712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQNJR-00021S-Tf for submit@debbugs.gnu.org; Mon, 31 Jul 2023 03:27:30 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:57779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQNJP-00021E-DG for 64275@debbugs.gnu.org; Mon, 31 Jul 2023 03:27:27 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3fbc1218262so45882515e9.3 for <64275@debbugs.gnu.org>; Mon, 31 Jul 2023 00:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690788441; x=1691393241; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=Wjma3nducrJ4qGRMN/CAFg47+t6o1St7m4U0Du4tVpw=; b=Nve+kT60xuW0c5vwOraJUL4J9Qa6c7FgwHGPzU89ibCoCBmDP1YCTM6Peb7XGZPr0N 92FxrcGgV8m6DYATLAvy5Af6AYBUFKh9jkMGc/0O9dcA01nSy1SPVF76+38OPRw+wwYf +XUGFBB+R3RWneCBfnumauiGjjFdXk/rM41bCztl5imlapdDjXESRIWGsUZpaqz3RDoJ 1V60prz2HHV3xAtg2u1dng57/hVbDaD2MMtkUlbQ9UM0eJEaGLQoUKjc89fVB9EZzki1 d3pirwehRSwh+utTAn+axcMVnThzTfsDnoMJGvrOcf0fASQW+BNBZfngcePB/CagTrrU X8Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690788441; x=1691393241; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Wjma3nducrJ4qGRMN/CAFg47+t6o1St7m4U0Du4tVpw=; b=DOJAdZTYTKI42v0LhjOvlIsYKb3BYagJ4QhJ7Ue+5ynq4ceNmHx4nu7wb3vEFk0YLL j9YRmCsQWt5a1vv4uALG308dJ/vhDUagQsZ+DKwfloKy5MqZLTQbv754IjdRcMhagZNn aeGQemYefu6F+M3kHfKZO9rVw5BeToO5OAcq3XYHVgEYYYwvDHWhWJ+7H+1iUED4PofT 69SBMiInUWRML9WNatRtBDKLMMgFR+rA0eaWO1rDelf/pJVXgnWPgwcUdiFJqG3xdZF7 +kzGHFV+8eXRYgkHWKKQp3mlgBhZcFfm9mex9jFPHc2tc4BGSwRd9+6xxlInRnTVgtgY Jv5A== X-Gm-Message-State: ABy/qLYI7yIWYP6/X39wlsOxP6miXK0/TAXQa+pT/fQjdx3SMB3HDsdQ 8l+JhkuzP6EsTETQfWJLLFANpeThCYCTzA== X-Google-Smtp-Source: APBJJlE8CK37CVfzBSYuGE4GOGs3rXjQ1JrNzsT7rz16mC8ec468JPwXlkotOqX86syenn69YAB66Q== X-Received: by 2002:a05:600c:2182:b0:3fe:90f:8496 with SMTP id e2-20020a05600c218200b003fe090f8496mr6907835wme.1.1690788441307; Mon, 31 Jul 2023 00:27:21 -0700 (PDT) Received: from melissa.local ([2c0f:ef18:1431:0:b09:9616:db04:c248]) by smtp.gmail.com with ESMTPSA id m9-20020a7bce09000000b003fe1ddd6ac0sm3248199wmc.35.2023.07.31.00.27.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 00:27:21 -0700 (PDT) References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: Dmitry Gutov Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Mon, 31 Jul 2023 09:22:40 +0200 In-reply-to: <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> Message-ID: <87leew7d7u.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64275 Cc: Basil Contovounesios , 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 30/07/2023 10:53, Wilhelm Kirschbaum wrote: >>> With the new patch, it will continue highlight the sigil name=20 >>> ("r") in >>> regexps, but no in other sigil types (s/c/w). >>> >> Incorrect, just below there is a: >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sigil) @font-lo= ck-string-face) >> without a match, so they will be highlighted, but just more >> generically >> as we don't know which sigils the user might have assigned. > > Why not add elixir-ts-font-sigil-name-face in that matcher as=20 > well? I think it is worth keeping the default/fallback case as simple as possible and if there is a need to add special font to more=20 specific cases. In this case it would have no impact if the font is not customized. Is there a reason you believe it would be better? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 07:59:32 2023 Received: (at 64275) by debbugs.gnu.org; 1 Aug 2023 11:59:32 +0000 Received: from localhost ([127.0.0.1]:47338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQo2F-00084w-Tv for submit@debbugs.gnu.org; Tue, 01 Aug 2023 07:59:32 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:44191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQo2C-00084g-Hv for 64275@debbugs.gnu.org; Tue, 01 Aug 2023 07:59:29 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 154A95C0199; Tue, 1 Aug 2023 07:59:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 01 Aug 2023 07:59:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690891162; x=1690977562; bh=0uI6EJ6lNfOZzP+U2w/uAMm8CCnFauNjkEf dy/iQy5s=; b=XjbFXQu3WvQmFkuDyqVj/oMVgKFa1mDgOrm0CiQMMzHmI9rGTxe IPeGx6p/qq3uWyFINVW7gI84geMOTxcZQoMNAIh+eVCnDa6bUvJY3RUcF0iHRqkY aja070H2wioMTj8tgBQL1HucmUe+EApa/Kf9fJVwZnkn0lLHiqgi6zIk0t32DmxK IW/4Tr+7OGbL6Voq9v07s+2ZFLbS/StP3bDcGGIosQyrtDpE3BGqvI3YQWCT/+h7 v6vAbX3ZBetghMXFB231ahJDJnTkNaeunPBm+skNdCcX6DPKrlpTAg3oVUdkve0R XKa5Lw51v2WBe3Sda+YzdNZ/a40d7J56v8w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690891162; x=1690977562; bh=0uI6EJ6lNfOZzP+U2w/uAMm8CCnFauNjkEf dy/iQy5s=; b=QK2qL+I2cRnoYJp9duJ4g+DOLe8B30RXUK8g1QDsbly9WDAWz0I Bmtj15fyvEJoIUxgmf6Q5QvKjAAorMeNonE6CGUCQS7zNm9GE6vAkX9xnkw+54Wk eBqMRhazXaA0MNdfY+4E2e3g6t+Nsmhx01rvkAunvLutOUfh4wx9GV9Jf9l3TaJA osIJjrOYFTtMvupG8p+V0I5JyLOoTIAutPoPABJbhiDoJ/nRAT1cEeODShNxLt8r 6PqlkKYB2AG3m0bCzVNh1zLM3qwULKddcZIpYavbkUEEzWL5YY2Q+Kgbbs8HUVTh /TMD68CYinDh2ov7O0GwW3bxGsRH0y6AVsQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjeeigdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Aug 2023 07:59:20 -0400 (EDT) Message-ID: <9c5eb888-f2df-5243-53d4-95d1d1b2e2f4@gutov.dev> Date: Tue, 1 Aug 2023 14:59:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Content-Language: en-US To: Wilhelm Kirschbaum References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> <87leew7d7u.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87leew7d7u.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 64275 Cc: Basil Contovounesios , 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 31/07/2023 10:22, Wilhelm Kirschbaum wrote: > I think it is worth keeping the default/fallback case as simple as > possible and if there is a need to add special font to more specific > cases. But the font is called elixir-ts-font-sigil-name-face. It should apply to all sigils, shouldn't it? At least if we just go by the name. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 02 02:40:03 2023 Received: (at 64275) by debbugs.gnu.org; 2 Aug 2023 06:40:03 +0000 Received: from localhost ([127.0.0.1]:48733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qR5Wc-0000Sw-JV for submit@debbugs.gnu.org; Wed, 02 Aug 2023 02:40:03 -0400 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:60615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qR5Wb-0000SO-EB for 64275@debbugs.gnu.org; Wed, 02 Aug 2023 02:40:02 -0400 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2b9ab1725bbso99756871fa.0 for <64275@debbugs.gnu.org>; Tue, 01 Aug 2023 23:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690958395; x=1691563195; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=JnIYDF9ewID6DbW+Jw5bQj51L2BOnbSoJNCLx1p1cd4=; b=objjoV5hmmuYzk/ELkTkptjmEM3gbpcF1A2MjrPrxuaAO1U8okAGxpUOb7Zn6B87qi wis1yVFalfbuanU5CM6v9FU0hpeXoF0JGRRP63XCV5g2Sv1SxMOZQF2YJGkD0DUmoFQY 2j5ZfGFDKs6B47MSOVViE6V4lTyuXsY0bn1ZsSmTVFa5oWLX1sJIGuUJpw6OcdoAcg99 0k30SW5Pd7zj00H05qXeLeNNvhGYzUgssk9swFZgsFIZaDfz39kbIqaRpHMtQaIcadE+ 5F3g6bEYUiO93H7p1GmfR8G8MJSiEG8+IJ/Z3EvtL8qnpTeRzDsAKvNFpbbZ7GIi29uq Oodw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690958395; x=1691563195; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JnIYDF9ewID6DbW+Jw5bQj51L2BOnbSoJNCLx1p1cd4=; b=jW1DnSPEVLXeCID2mU9Ltjs4qZG88IOaw5Mel+4V0QY2S/bQ4xN7bAEXH5BzG5Ydl4 1DrnUPmDtUeesfnxZt538w91GYdqVtUkbye4p+e2/y5yeyreUx7SljNofyvWkRWiRx5b nJs5m+tDm43BTlKnSJPh7LXf8GCf0jJIrkn9XE4NqdV+ZoFv5WQmWrkfnhA54yB8r5fA e0fVcWAez/1sBAmqN7b4llpvs4jrHxnTtzZ9jP1WdCuhRU28raxqn42G0sxYt0Z+RWw5 G34y7kw/+nr1Csiuey2YdNHSNlsxwRKjYljmBsI/2euHEfMqhc2ayxxip1+YPu/szLYw GdcQ== X-Gm-Message-State: ABy/qLYYwp9di+M3lPo1A6kfs8pYLP6KgP2gEqGSQogEIM6iV1LSm8rw OmqDz8x+O0Lzrhx2HeFfremXXS1efgs= X-Google-Smtp-Source: APBJJlGeHADtGR6AmQlRYtpq0/cPeTvoONebfNqiCE8/ZdDJ/koxRt1n2Xg8kzBzxk9tgn60nBXtSw== X-Received: by 2002:a2e:9cc5:0:b0:2b9:bd23:947e with SMTP id g5-20020a2e9cc5000000b002b9bd23947emr4405989ljj.27.1690958394790; Tue, 01 Aug 2023 23:39:54 -0700 (PDT) Received: from melissa.local (ec2-13-245-180-173.af-south-1.compute.amazonaws.com. [13.245.180.173]) by smtp.gmail.com with ESMTPSA id e22-20020a05600c219600b003fc080acf68sm818106wme.34.2023.08.01.23.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 23:39:54 -0700 (PDT) References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> <87leew7d7u.fsf@gmail.com> <9c5eb888-f2df-5243-53d4-95d1d1b2e2f4@gutov.dev> User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: Dmitry Gutov Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Wed, 02 Aug 2023 08:38:39 +0200 In-reply-to: <9c5eb888-f2df-5243-53d4-95d1d1b2e2f4@gutov.dev> Message-ID: <87leeuvtft.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64275 Cc: Basil Contovounesios , 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 31/07/2023 10:22, Wilhelm Kirschbaum wrote: >> I think it is worth keeping the default/fallback case as simple >> as >> possible and if there is a need to add special font to more >> specific >> cases. > > But the font is called elixir-ts-font-sigil-name-face. It should > apply > to all sigils, shouldn't it? > > At least if we just go by the name. Sure, but need to tweak it a bit when I have time. Maybe there is a way to match in the query without applying a font, then it will look a bit more sensible. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 22:11:54 2023 Received: (at 64275) by debbugs.gnu.org; 16 Aug 2023 02:11:55 +0000 Received: from localhost ([127.0.0.1]:38464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qW60o-0002lU-Iv for submit@debbugs.gnu.org; Tue, 15 Aug 2023 22:11:54 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:52331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qW60m-0002lG-M9 for 64275@debbugs.gnu.org; Tue, 15 Aug 2023 22:11:53 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9DCE95C006D; Tue, 15 Aug 2023 22:11:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 15 Aug 2023 22:11:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1692151907; x=1692238307; bh=q/UIi5bWPd/zrFHdQO2lrA54b8rMkSDg67y c34KyWMk=; b=Gs7xXZTYVqCx8qRbUgRbDkj7Gd5QirpcbDE3l+TGAFzPVyebX6a RksDfPssm84QGw3PlSL0JzRvNYb0Km7Y7sjXgpuCQpiffBUH4yHnw3mvOfhs4Dt6 66FJx3qr1JvDvhz4dUxvbgHgTtgWk3RezKBrLAXrgOffDBj+yMcOLKDFNAS8S08P GHcHG6riaGWLVlkLmYMF4/mO8IuyY+JMt+cPi8FGQ/tNzW80xVls52Dv9kRLAB6o kzMnItp63MQz2zeQFkkMI5FWNAOu5TaxDkkp8iKlmfk+TNXYWXYGhxK51veuEseM TAUObQSp1VDmRpnJhqBKQnrOuPeXbogDB6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692151907; x=1692238307; bh=q/UIi5bWPd/zrFHdQO2lrA54b8rMkSDg67y c34KyWMk=; b=XYvtkBgt9qeZ0JNmbwkZJeNm7P5AGidncAkyAu5SPOVEmb/9XIc lKrnSOEz/6TQmz/dt6n29WYC7L5+qqvTa1SPmk/6USO9ATw9LJ0K1Ng6mwZWBCNn C4nGtdOS60EpJkX5QSLTUaEXAM9xCEIZZxVtGLWVnZh8gve9THZheBOm8Tees0L1 7Jo8ltybu8YinSESY2Zw2+Y9gUSecHuBTs7dNFxBRQanlMWHg6kRGWFn0/+h9kME 6ezzTTsaoxWFYVPWrq0Hp+XWsBdhhLUdvWoT17VQFeTKMl79g40QKQYLk6PsfvdU 3PReJ7USSM+Fs9ycShUpxcaKIYFLgzP/KcA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddtkedgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Aug 2023 22:11:46 -0400 (EDT) Message-ID: Date: Wed, 16 Aug 2023 05:11:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Content-Language: en-US To: Wilhelm Kirschbaum References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> <87leew7d7u.fsf@gmail.com> <9c5eb888-f2df-5243-53d4-95d1d1b2e2f4@gutov.dev> <87leeuvtft.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: <87leeuvtft.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 64275 Cc: Basil Contovounesios , 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 02/08/2023 09:38, Wilhelm Kirschbaum wrote: > > Dmitry Gutov writes: > >> On 31/07/2023 10:22, Wilhelm Kirschbaum wrote: >>> I think it is worth keeping the default/fallback case as simple as >>> possible and if there is a need to add special font to more specific >>> cases. >> >> But the font is called elixir-ts-font-sigil-name-face. It should apply >> to all sigils, shouldn't it? >> >> At least if we just go by the name. > > Sure, but need to tweak it a bit when I have time.  Maybe there is a way > to match in the query without applying a font, then it will look a bit > more sensible. I'm not sure what you meant by the last sentence, sorry. What do you think about the below? (sigil (sigil_name) @elixir-ts-font-sigil-name-face) @font-lock-string-face) From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 07 04:53:59 2023 Received: (at 64275) by debbugs.gnu.org; 7 Oct 2023 08:53:59 +0000 Received: from localhost ([127.0.0.1]:53300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp34R-0006VV-26 for submit@debbugs.gnu.org; Sat, 07 Oct 2023 04:53:59 -0400 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:55323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp34Q-0006VH-0V for 64275@debbugs.gnu.org; Sat, 07 Oct 2023 04:53:58 -0400 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2b9338e4695so36151381fa.2 for <64275@debbugs.gnu.org>; Sat, 07 Oct 2023 01:53:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696668812; x=1697273612; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=eawcmST76VC+GEiuRHhVS7JUB+/KEiBRhk8SQMh7Ib8=; b=fZMHcDKRdBo0zMLpygIChvcZQr9X+ZSgkd4WdibL0tOz9nqRWNCsWcuV+iURlji5bx WI/PL8bo8Njodw91stVOoy9wJTwmD0SsyMHBUgRS6umR36NQ6dn+AbuvOP9RVxBv+wx9 aGqemnMdBdEIjipLvIPHDfSX2PNy5/qLxufD1Kw5JOvAVo+EpAIbfIOs/i6a5At5JtSL uwideCgD4baQOgwxGbZWhht0FIM1871guVMoR8vymR3zQcfawlPLnCUcXEtAPp/v91/M Av+z21H0LY2QOp30Vz4Mz3RYqkFi8pcYNz7B4TxBb1FLw5JSyn1W4mVNYPtkXZG0ap+F v6iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696668812; x=1697273612; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eawcmST76VC+GEiuRHhVS7JUB+/KEiBRhk8SQMh7Ib8=; b=LCv67dP76H8iqgKkBpaLjNQJUoAqtBfe6WwlcMbmtLeaqSFB4z5Ps2+xo/p6lTvNPo IqZP/c3sI+3TpSQFRDbuhDS9GMNEZWqzdLlBKX4G++FrfiezvNJh4a7FWPS/+Z4Viud1 RyPytYSacuV6UEt0LKiGGa2g0Tlo6fBhkyMnwe3QyG8ecHA9NGO3hdyM/scGEZYjq+c2 lmiQhbATkOmzu+w1Bv9CJQ2HrXzPEpAAn1j8A0LcnnNFEpuxNvToS1MxP5fa8mpxKud6 22rp6f6tAthwq6EjiAkzVwbkN05XBEXcQvtTxwFRc9cZyLLGY64AFiWhYfsZ01ssextC QHfg== X-Gm-Message-State: AOJu0YyQ8+Slr6irTLZEaznckil3Hj4tIScuhx8PmEiK8X8DoW52EDsK HCZ49vDrUv46XuFZa8bd9zntXR3wxvWVSbYG X-Google-Smtp-Source: AGHT+IFBC8tcwPUxXGw/awu4cyzJ89mv9IyodEI+PZxeaNqWe4oeG4zNk6QYEbCyb/NKpDciBPDaPg== X-Received: by 2002:ac2:446b:0:b0:4fe:3724:fdae with SMTP id y11-20020ac2446b000000b004fe3724fdaemr8212427lfl.66.1696668812036; Sat, 07 Oct 2023 01:53:32 -0700 (PDT) Received: from melissa.local ([2c0f:ef18:1431:0:b09:9616:db04:c248]) by smtp.gmail.com with ESMTPSA id w14-20020a05600c474e00b003fd2d3462fcsm2142809wmo.1.2023.10.07.01.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 01:53:31 -0700 (PDT) References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> <87leew7d7u.fsf@gmail.com> <9c5eb888-f2df-5243-53d4-95d1d1b2e2f4@gutov.dev> <87leeuvtft.fsf@gmail.com> User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: Dmitry Gutov Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Sat, 07 Oct 2023 10:46:57 +0200 In-reply-to: Message-ID: <87edi6reyf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64275 Cc: Basil Contovounesios , 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Dmitry Gutov writes: > On 02/08/2023 09:38, Wilhelm Kirschbaum wrote: >> Dmitry Gutov writes: >>=20 >>> On 31/07/2023 10:22, Wilhelm Kirschbaum wrote: >>>> I think it is worth keeping the default/fallback case as=20 >>>> simple as >>>> possible and if there is a need to add special font to more=20 >>>> specific >>>> cases. >>> >>> But the font is called elixir-ts-font-sigil-name-face. It=20 >>> should apply >>> to all sigils, shouldn't it? >>> >>> At least if we just go by the name. >> Sure, but need to tweak it a bit when I have time.=C2=A0 Maybe there=20 >> is a >> way >> to match in the query without applying a font, then it will=20 >> look a bit >> more sensible. > > I'm not sure what you meant by the last sentence, sorry. What do=20 > you > think about the below? > > (sigil (sigil_name) @elixir-ts-font-sigil-name-face) > @font-lock-string-face) Sorry for the late reply. I believe the following patch is more appropriate as it will apply the sigil font to the entire sigil,=20 but also respect the regex face. We can add string specific matches=20 later, but happy just to simplify what we have and fix apply appropriate=20 font to previously unmatched sigils. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode.patch >From 9f6e5f143c2d247541172851ac9f09dcc6add010 Mon Sep 17 00:00:00 2001 From: Wilhelm H Kirschbaum Date: Sat, 7 Oct 2023 10:37:49 +0200 Subject: [PATCH] Simplify sigil font-lock match for elixir-ts-mode There is no need to match on specific sigils, except for regex. * lisp/progmodes/elixir-ts-mode.el (elixir-ts--font-lock-settings): Update sigil match. --- lisp/progmodes/elixir-ts-mode.el | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/lisp/progmodes/elixir-ts-mode.el b/lisp/progmodes/elixir-ts-mode.el index 2ddce3de105..8a678b110e2 100644 --- a/lisp/progmodes/elixir-ts-mode.el +++ b/lisp/progmodes/elixir-ts-mode.el @@ -468,21 +468,10 @@ elixir-ts--font-lock-settings :feature 'elixir-sigil :override t `((sigil - (sigil_name) @elixir-ts-font-sigil-name-face - (:match "^[sSwWpPUD]$" @elixir-ts-font-sigil-name-face)) - @font-lock-string-face - (sigil - "~" @font-lock-string-face - (sigil_name) @elixir-ts-font-sigil-name-face - (:match "^[rR]$" @elixir-ts-font-sigil-name-face)) + (sigil_name) @font-lock-regexp-face + (:match "^[rR]$" @font-lock-regexp-face)) @font-lock-regexp-face - (sigil - "~" @font-lock-string-face - (sigil_name) @elixir-ts-font-sigil-name-face - quoted_start: _ @font-lock-string-face - quoted_end: _ @font-lock-string-face - (:match "^[HF]$" @elixir-ts-font-sigil-name-face))) - + (sigil) @elixir-ts-font-sigil-name-face) :language 'elixir :feature 'elixir-string-escape :override t -- 2.42.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 07 06:03:33 2023 Received: (at 64275) by debbugs.gnu.org; 7 Oct 2023 10:03:33 +0000 Received: from localhost ([127.0.0.1]:53344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp49l-0008JA-9h for submit@debbugs.gnu.org; Sat, 07 Oct 2023 06:03:33 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:56602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp49j-0008Iw-1d for 64275@debbugs.gnu.org; Sat, 07 Oct 2023 06:03:31 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3248e90f032so2861925f8f.1 for <64275@debbugs.gnu.org>; Sat, 07 Oct 2023 03:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696672985; x=1697277785; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=LyYSngtl3C8EONmocC/Aho8lDxq1iP1yQRqt4tcLEbs=; b=WnJuLtzLtHIFVHQA9rrg8d3sIMA9VhnyGDjsuNfAv4SEAq9DxDiVRTnKE+0TOLHAcL 1HLBSA9BLMWNhSxvnA7HfWG7KWtJ/z53ppsL5YqsKWSzoLwu/UrvHOs8UmgTmwiYxWku IjtL1E1873IVr77oXlKF3eU2fBnGXp/5G8lXmiJ0VwB8wGFVqWlHIY8CLu900uJ1z7Dv HHcRvUR79Z20ogXixkf7JhJSZQMmRIYsK1xOk+cjMuxhWPtAwY0dCQQf00L37PMjzuDo Yp8yPRm4RAMK91gIaob2PBbWTmuY550gxDCdvb2Xzkc1Ir/FEcM/smpboNEM4p4OQztU w82g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696672985; x=1697277785; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LyYSngtl3C8EONmocC/Aho8lDxq1iP1yQRqt4tcLEbs=; b=ml3DxqfwpGNe2nGI9jH5J6NCc0AxQK8dpQaM3rrBWY3OWcsaQJHn8uUBNMk4JqBCei aQdj0IesBvRgknFjnLePSnRuD8Eg+gWegY9A+sgwZ+/8C8Ovd2d3/95mcUX7WC6Nezon Px8t34JWl7XQueS985lV5TXXP63GnT6NhJfsTReKf2wRy48wkEx4+jGh6tHMAePfT3jq 8h0d22e0PKkyN7xcrALb6EaUDCd7sM5194w+5N3TmFZDOqmmoLySjcUr6Omu7ODdu1/I Kq6WDUTk1trIYx1en3706TRaJ9tKYRMPZfsCTO963WwI7fmBLyihGFpApwOjgJPZjYqr SqvA== X-Gm-Message-State: AOJu0YyjTut8ujNcgNFTX59dCyiA5MkAwxguvmIvVxPIxbVf4kwHuypb /VbwcuOYWNkImWyu/yrtgu+BGvz6JbdaorPc X-Google-Smtp-Source: AGHT+IES354Q7Y+cUZY+bIBz+TZV9xFoM+REiXwVzswkbZMh3qd9k83tvOjwwT5nbIF+cslOinEDJw== X-Received: by 2002:adf:e9d0:0:b0:313:e8b6:1699 with SMTP id l16-20020adfe9d0000000b00313e8b61699mr8815099wrn.55.1696672984824; Sat, 07 Oct 2023 03:03:04 -0700 (PDT) Received: from melissa.local ([2c0f:ef18:1431:0:b09:9616:db04:c248]) by smtp.gmail.com with ESMTPSA id e18-20020adffd12000000b0031980783d78sm3824284wrr.54.2023.10.07.03.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 03:03:03 -0700 (PDT) References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> <87leew7d7u.fsf@gmail.com> <9c5eb888-f2df-5243-53d4-95d1d1b2e2f4@gutov.dev> <87leeuvtft.fsf@gmail.com> <87edi6reyf.fsf@gmail.com> User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: Dmitry Gutov Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Sat, 07 Oct 2023 11:59:36 +0200 In-reply-to: <87edi6reyf.fsf@gmail.com> Message-ID: <87jzryg370.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64275 Cc: Basil Contovounesios , 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed >> >> I'm not sure what you meant by the last sentence, sorry. What >> do you >> think about the below? >> >> (sigil (sigil_name) @elixir-ts-font-sigil-name-face) >> @font-lock-string-face) > > Sorry for the late reply. I believe the following patch is more > appropriate as it will apply the sigil font to the entire sigil, > but > also respect the regex face. We can add string specific matches > later, > but happy just to simplify what we have and fix apply > appropriate font > to previously unmatched sigils. > > [2. text/x-patch; > 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode.patch]... Actually, the above patch breaks the embedded HEEx sigils' font. We have to exclude it when doing a general match. Attached works with ~H sigils as well. Please ignore the previous patch and install this one. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename="0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode(1).patch" >From 12b7227185e22923d1e67e3f5a47af97879e2ad2 Mon Sep 17 00:00:00 2001 From: Wilhelm H Kirschbaum Date: Sat, 7 Oct 2023 10:37:49 +0200 Subject: [PATCH] Simplify sigil font-lock match for elixir-ts-mode There is no need to match on specific sigils, except for regex. * lisp/progmodes/elixir-ts-mode.el (elixir-ts--font-lock-settings): Update sigil match. --- lisp/progmodes/elixir-ts-mode.el | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/lisp/progmodes/elixir-ts-mode.el b/lisp/progmodes/elixir-ts-mode.el index 2ddce3de105..de078454463 100644 --- a/lisp/progmodes/elixir-ts-mode.el +++ b/lisp/progmodes/elixir-ts-mode.el @@ -466,23 +466,19 @@ elixir-ts--font-lock-settings :language 'elixir :feature 'elixir-sigil - :override t `((sigil - (sigil_name) @elixir-ts-font-sigil-name-face - (:match "^[sSwWpPUD]$" @elixir-ts-font-sigil-name-face)) - @font-lock-string-face + (sigil_name) @font-lock-regexp-face + (:match "^[rR]$" @font-lock-regexp-face)) + @font-lock-regexp-face (sigil - "~" @font-lock-string-face (sigil_name) @elixir-ts-font-sigil-name-face - (:match "^[rR]$" @elixir-ts-font-sigil-name-face)) - @font-lock-regexp-face + (:match "^[^HF]$" @elixir-ts-font-sigil-name-face)) + @elixir-ts-font-sigil-name-face (sigil "~" @font-lock-string-face (sigil_name) @elixir-ts-font-sigil-name-face quoted_start: _ @font-lock-string-face - quoted_end: _ @font-lock-string-face - (:match "^[HF]$" @elixir-ts-font-sigil-name-face))) - + quoted_end: _ @font-lock-string-face)) :language 'elixir :feature 'elixir-string-escape :override t -- 2.42.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 07 06:12:29 2023 Received: (at 64275) by debbugs.gnu.org; 7 Oct 2023 10:12:29 +0000 Received: from localhost ([127.0.0.1]:53363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp4IP-0008WN-EU for submit@debbugs.gnu.org; Sat, 07 Oct 2023 06:12:29 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:60619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp4IN-0008W8-Cs for 64275@debbugs.gnu.org; Sat, 07 Oct 2023 06:12:28 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3231df054c4so2733832f8f.0 for <64275@debbugs.gnu.org>; Sat, 07 Oct 2023 03:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696673522; x=1697278322; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=v3zg8f/UqR8BO+vf3B0MCdh4ZkB6atw4CwbuY0xU2tk=; b=Pd+p1f9i+W46cdspVit4Q/gY6jjcZrh7lxRSU85CPDzyISddv35yQgrOaUG8xrdhZu BVJmzetTAEwSl/ZiYR7w7Nqs1J5CS7vEwvP2eYcmIxUS11C7HruLR4oa9JHE4MJ2FLEm IKZv5M5N0Q+XAumd97zeUORzhT2B/Xdf75VXjIL647QifGVskEEm00nnafNo0rSz7QdU 53qOuUg2lkvABGzB6Xs6rdj9B44K8rp28xQL2mtmzd96aAcqwVVzgIBJE2+2Jp9wUpOX ASQ9o1CUpZm28Pqx19Be4ugdUHLQZ1lUFk3Hk9VP2yNumccxIirwOWDbbVRusmiRq5KU dEzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696673522; x=1697278322; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v3zg8f/UqR8BO+vf3B0MCdh4ZkB6atw4CwbuY0xU2tk=; b=ai/7s/1bGamxVDpSnfaN8U26DAcQzdgCy+HC4cVpHI0jAWJGr7B9K0fUbt6SOY9Iuf aqMB7cLZGFJ6Igy0/V3hR2YbB5G6vFniNmHMe02ek5oYstdHzebzwkDlbpk/Ppe/I6sT dPJyTlB/5hl7ipCpC1Hqz+IJUgmc0HzCNVCENZtc0dU1vhilj+b9rMOUCHbdM0IvdnAb SFUDCd8d0XJlDz7EzXH/bU6IdlvfltAhZ+Ezg/IPe1F4IkgZSzLDq9CrEv84UP8Hj923 Fhc689+dZt45SirtvNkURu8YcKjzI6H2n86+dzS9aZFfAzmKxFpDv2yV3vq+AHu/i6Mq I1rQ== X-Gm-Message-State: AOJu0YxqiV1DR+aT0UF/l8ekTy0V/x6ejAf7ITGgBpVdEOOQsDVdU00F Hz9t7wtblWBp07FFGV11YMDkrhtOjXCq7oKx X-Google-Smtp-Source: AGHT+IEVeorGD14aI2NpVNzv+tkNNLuIea59DVknTpoWOdlPGTC9fMrIu/yoRikb4ebkFszrK2+vsQ== X-Received: by 2002:a5d:4cc3:0:b0:31f:e761:d47c with SMTP id c3-20020a5d4cc3000000b0031fe761d47cmr9019895wrt.32.1696673521911; Sat, 07 Oct 2023 03:12:01 -0700 (PDT) Received: from melissa.local ([2c0f:ef18:1431:0:b09:9616:db04:c248]) by smtp.gmail.com with ESMTPSA id h11-20020a056000000b00b00325a59b2080sm3852395wrx.97.2023.10.07.03.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 03:12:01 -0700 (PDT) References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> <87leew7d7u.fsf@gmail.com> <9c5eb888-f2df-5243-53d4-95d1d1b2e2f4@gutov.dev> <87leeuvtft.fsf@gmail.com> <87edi6reyf.fsf@gmail.com> <87jzryg370.fsf@gmail.com> User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: Dmitry Gutov Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Sat, 07 Oct 2023 12:10:43 +0200 In-reply-to: <87jzryg370.fsf@gmail.com> Message-ID: <871qe6wxle.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64275 Cc: Basil Contovounesios , 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Wilhelm Kirschbaum writes: >>> >>> I'm not sure what you meant by the last sentence, sorry. What >>> do >>> you >>> think about the below? >>> >>> (sigil (sigil_name) @elixir-ts-font-sigil-name-face) >>> @font-lock-string-face) >> >> Sorry for the late reply. I believe the following patch is >> more >> appropriate as it will apply the sigil font to the entire >> sigil, but >> also respect the regex face. We can add string specific >> matches >> later, >> but happy just to simplify what we have and fix apply >> appropriate >> font >> to previously unmatched sigils. >> >> [2. text/x-patch; >> 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode.patch]... > > Actually, the above patch breaks the embedded HEEx sigils' > font. We > have to exclude it when doing a general match. Attached works > with ~H > sigils as well. Please ignore the previous patch and install > this > one. > > [2. text/x-patch; > 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode(1).patch]... Sorry :(. I am finding more edge cases. Maybe let me test it this properly this week before we make any changes. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 03:40:25 2023 Received: (at 64275) by debbugs.gnu.org; 21 Oct 2023 07:40:25 +0000 Received: from localhost ([127.0.0.1]:42123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu6av-0006sB-02 for submit@debbugs.gnu.org; Sat, 21 Oct 2023 03:40:25 -0400 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]:59753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu6as-0006rv-UQ for 64275@debbugs.gnu.org; Sat, 21 Oct 2023 03:40:23 -0400 Received: by mail-qk1-x72a.google.com with SMTP id af79cd13be357-778a6c440faso87988185a.3 for <64275@debbugs.gnu.org>; Sat, 21 Oct 2023 00:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697873989; x=1698478789; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ysYqvY1pT8rKU/SmOYjtjFBK/7hU6hZeTnV+KVf/I5o=; b=DTUaowwqD2GgI7qf4kfJ+e78jrW4IlHdQrfCPYgTr1Bh5DRpb9qYGs80+7uf6kuuTO +50Wfh6NL+5ixHRCtB/aYT7c5HbFXI/ZKvHMteFGP/LLjx8lSdf7DtqfGdcuYR/LqAaL af4s2rea3SaOsp/aEZQiICGMhwHQAi0zq+kJ4isbKJ7BNJfbaqQHeGOSviEHb7l0OgJ1 3IPVXaNH075dLwOP+0qmpso0SysO5bXf2h9crP3vJHMNkHA17vvogXAadYyZM5itTPRg W/61VQG2doHTk0/7OvimY0VcL7gyHnw7AxP6u+JKLSMGIM/aDN5YLwF6PigDE6j5W285 TTvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697873989; x=1698478789; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ysYqvY1pT8rKU/SmOYjtjFBK/7hU6hZeTnV+KVf/I5o=; b=lF9YIS6d6Zc8tVgUxUEJS4fTFtY3ImFIQg/GUFXzF5PUG1+8b4rVlUTN2MJ/m3KL9O IRn+aCM6MDxehDEt3V0jiqtSazZIdv/DavMJKN7CIEdwbB28F9RU6uHEC/MAmnCTO4v4 FtZycV1c9OqH5MOQpMY6UnCnGRA566TDWlvs8KZY345qLkKFH94uONmLKyl6bc++NQf1 YdLmiw/JZ6GRG6jQNhFqQQeiEbQiatWKQWE4bLri8QhZkdKlX/ZZtVXE8afQqruQEPJ/ pDm01s3SsarN3CJq1/tGFNA1TZWGtMijUogKp4ndVgwJnkA7pJwxkD72Avrpn0TkbDZ4 TMxg== X-Gm-Message-State: AOJu0YxUxF4hArLpHFa5Mf/dmbGv72xXzAfS58I1OCfjyLESP2JwT1fY hwm2yF5CTAm5eYeCqJaoFqcanl2e31OaqXdtrKM= X-Google-Smtp-Source: AGHT+IF90YAmTnMUtfBa/l6FOG6r+H1PQohlE6jNaOWMTeelNOqDzY4WM2LogX5mVfpk8Js20HWClwzug12mYe9OYy0= X-Received: by 2002:a0c:dd89:0:b0:66d:a22a:464f with SMTP id v9-20020a0cdd89000000b0066da22a464fmr680640qvk.16.1697873989507; Sat, 21 Oct 2023 00:39:49 -0700 (PDT) MIME-Version: 1.0 References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> <87leew7d7u.fsf@gmail.com> <9c5eb888-f2df-5243-53d4-95d1d1b2e2f4@gutov.dev> <87leeuvtft.fsf@gmail.com> <87edi6reyf.fsf@gmail.com> <87jzryg370.fsf@gmail.com> <871qe6wxle.fsf@gmail.com> In-Reply-To: <871qe6wxle.fsf@gmail.com> From: Wilhelm Kirschbaum Date: Sat, 21 Oct 2023 09:39:38 +0200 Message-ID: Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode To: Dmitry Gutov Content-Type: multipart/mixed; boundary="00000000000004cf1806083518f6" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64275 Cc: Basil Contovounesios , 64275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000004cf1806083518f6 Content-Type: multipart/alternative; boundary="00000000000004cf1406083518f4" --00000000000004cf1406083518f4 Content-Type: text/plain; charset="UTF-8" > >>> > >>> I'm not sure what you meant by the last sentence, sorry. What > >>> do > >>> you > >>> think about the below? > >>> > >>> (sigil (sigil_name) @elixir-ts-font-sigil-name-face) > >>> @font-lock-string-face) > >> > >> Sorry for the late reply. I believe the following patch is > >> more > >> appropriate as it will apply the sigil font to the entire > >> sigil, but > >> also respect the regex face. We can add string specific > >> matches > >> later, > >> but happy just to simplify what we have and fix apply > >> appropriate > >> font > >> to previously unmatched sigils. > >> > >> [2. text/x-patch; > >> 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode.patch]... > > > > Actually, the above patch breaks the embedded HEEx sigils' > > font. We > > have to exclude it when doing a general match. Attached works > > with ~H > > sigils as well. Please ignore the previous patch and install > > this > > one. > > > > [2. text/x-patch; > > 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode(1).patch]... > > > Sorry :(. I am finding more edge cases. Maybe let me test it this > properly this week before we make any changes. > I tested this patch for a while now and it looks like the best approach for handling regex sigils, but with an appropriate fallback. If this can be installed, it will be appreciated. --00000000000004cf1406083518f4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=C2=A0
>>>
>>> I'm not sure what you meant by the last sentence, sorry. W= hat
>>> do
>>> you
>>> think about the below?
>>>
>>>=C2=A0 =C2=A0(sigil (sigil_name) @elixir-ts-font-sigil-name-fac= e)
>>>=C2=A0 =C2=A0@font-lock-string-face)
>>
>> Sorry for the late reply.=C2=A0 I believe the following patch is <= br> >> more
>> appropriate as it will apply the sigil font to the entire
>> sigil, but
>> also respect the regex face.=C2=A0 We can add string specific
>> matches
>> later,
>> but happy just to simplify what we have and fix apply
>> appropriate
>> font
>> to previously unmatched sigils.
>>
>> [2. text/x-patch;
>> 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode.patch]... >
> Actually, the above patch breaks the embedded HEEx sigils'
> font. We
> have to exclude it when doing a general match.=C2=A0 Attached works > with ~H
> sigils as well.=C2=A0 Please ignore the previous patch and install > this
> one.
>
> [2. text/x-patch;
> 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode(1).patch]...

Sorry :(. I am finding more edge cases.=C2=A0 Maybe let me test it this
properly this week before we make any changes.

I tested this patch for a while now and it looks like the best appr= oach
for handling regex sigils, but with an appropriate fallback.
If this can be installed, it will be appreciated.
=C2=A0
--00000000000004cf1406083518f4-- --00000000000004cf1806083518f6 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode.patch" Content-Disposition: attachment; filename="0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lnzqasxb0 RnJvbSBhZTQzMjY1MDI2MWU2MGUyYjA0NWM0NmFkZDJhODgyN2U5OTY1Y2U0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBXaWxoZWxtIEggS2lyc2NoYmF1bSA8d2tpcnNjaGJhdW1AZ21h aWwuY29tPgpEYXRlOiBTYXQsIDcgT2N0IDIwMjMgMTA6Mzc6NDkgKzAyMDAKU3ViamVjdDogW1BB VENIXSBTaW1wbGlmeSBzaWdpbCBmb250LWxvY2sgbWF0Y2ggZm9yIGVsaXhpci10cy1tb2RlCgpU aGVyZSBpcyBubyBuZWVkIHRvIG1hdGNoIG9uIHNwZWNpZmljIHNpZ2lscywgZXhjZXB0IGZvciBy ZWdleC4KCiogbGlzcC9wcm9nbW9kZXMvZWxpeGlyLXRzLW1vZGUuZWwKKGVsaXhpci10cy0tZm9u dC1sb2NrLXNldHRpbmdzKTogVXBkYXRlIHNpZ2lsIG1hdGNoLgotLS0KIGxpc3AvcHJvZ21vZGVz L2VsaXhpci10cy1tb2RlLmVsIHwgNyArKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRp b25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2VsaXhp ci10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvZWxpeGlyLXRzLW1vZGUuZWwKaW5kZXggMmRk Y2UzZGUxMDUuLjA1ZWRiNDE1OWExIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9lbGl4aXIt dHMtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9lbGl4aXItdHMtbW9kZS5lbApAQCAtNDY5 LDEyICs0NjksMTEgQEAgZWxpeGlyLXRzLS1mb250LWxvY2stc2V0dGluZ3MKICAgIDpvdmVycmlk ZSB0CiAgICBgKChzaWdpbAogICAgICAgKHNpZ2lsX25hbWUpIEBlbGl4aXItdHMtZm9udC1zaWdp bC1uYW1lLWZhY2UKLSAgICAgICg6bWF0Y2ggIl5bc1N3V3BQVURdJCIgQGVsaXhpci10cy1mb250 LXNpZ2lsLW5hbWUtZmFjZSkpCisgICAgICAoOm1hdGNoICJeW15IRl0kIiBAZWxpeGlyLXRzLWZv bnQtc2lnaWwtbmFtZS1mYWNlKSkKICAgICAgQGZvbnQtbG9jay1zdHJpbmctZmFjZQogICAgICAo c2lnaWwKLSAgICAgICJ+IiBAZm9udC1sb2NrLXN0cmluZy1mYWNlCi0gICAgICAoc2lnaWxfbmFt ZSkgQGVsaXhpci10cy1mb250LXNpZ2lsLW5hbWUtZmFjZQotICAgICAgKDptYXRjaCAiXltyUl0k IiBAZWxpeGlyLXRzLWZvbnQtc2lnaWwtbmFtZS1mYWNlKSkKKyAgICAgIChzaWdpbF9uYW1lKSBA Zm9udC1sb2NrLXJlZ2V4cC1mYWNlCisgICAgICAoOm1hdGNoICJeW3JSXSQiIEBmb250LWxvY2st cmVnZXhwLWZhY2UpKQogICAgICBAZm9udC1sb2NrLXJlZ2V4cC1mYWNlCiAgICAgIChzaWdpbAog ICAgICAgIn4iIEBmb250LWxvY2stc3RyaW5nLWZhY2UKLS0gCjIuNDIuMAoK --00000000000004cf1806083518f6-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 25 20:27:57 2023 Received: (at 64275-done) by debbugs.gnu.org; 26 Oct 2023 00:27:57 +0000 Received: from localhost ([127.0.0.1]:60272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvoE9-0003Y1-C5 for submit@debbugs.gnu.org; Wed, 25 Oct 2023 20:27:57 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvoE4-0003Xl-Hv for 64275-done@debbugs.gnu.org; Wed, 25 Oct 2023 20:27:55 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8CC075C01EC; Wed, 25 Oct 2023 20:27:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 25 Oct 2023 20:27:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1698280036; x=1698366436; bh=w9V0uSx78ggdKO0bL0LDPehxPcS8pA6vC78 vAR/4xec=; b=SqsJb0hFsKwgfo8TMW4z1K8pUotq4l9JmkrfGcYQj2HDtzYc25q iaOLNw8qMPKa0KMBp/YNzsGw+D9ne8BoMq4hZ0g6lvpAIpx14s6D6FoPgkBANGgW ouI1lP85JnIL5p6pWSMWORdGcvOlX8E8xQxwqKhF1329/Y9RWQU7UzF6FqZz9rno oPk+ZrZYdfkaIRA5j7GZMohJNJrZIm01dHHGjljW1RVg+8wMwJzl9Ylx/PHglI3S dCsp7zswesDcAKJ7SpC4pTUaKNBwCiMdLdB0aeVJiVk6K3FppFk9cT10g//NDL3l GocL0Cbl5wN7EygNC5c0jc5zLmO0OVVSosw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698280036; x=1698366436; bh=w9V0uSx78ggdKO0bL0LDPehxPcS8pA6vC78 vAR/4xec=; b=ckEqNP4ICqz1uIjROhRZfdYkxMkw38x3cBVoRMFycPYPOWZPqz6 me2I0iCXWkDYf3jCCVi2RJSaU54ycHeozsn2ddBpk8qu+luho+PMby5R6GdNEeyd CeHI60Q0V/HuL0tQwAz3dYXnUC26HgL4LmVwFobI/83yhbWICvAf90KxD+fam3j0 NyF6AM1c+SAgzs5FpEf/J+s2PUzI2uaocCrNmBYKQd7MzaIQqz5/LGSuvJouG/Q1 g6+9KhQoYh71qbv1r2zldTRF6qnDioMu41mZ6cHSNCo1DdKIfBPyxTfznuvFYUwq g9pGSd8cRCD315x6P7gO7mgr4Z4+hbzXSdA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrledugdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpefhffehleejffegffeugefhkeektdffgfehjedvgeejtedtudehueffgffgfeej heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Oct 2023 20:27:15 -0400 (EDT) Message-ID: Date: Thu, 26 Oct 2023 03:27:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Content-Language: en-US To: Wilhelm Kirschbaum References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> <87leew7d7u.fsf@gmail.com> <9c5eb888-f2df-5243-53d4-95d1d1b2e2f4@gutov.dev> <87leeuvtft.fsf@gmail.com> <87edi6reyf.fsf@gmail.com> <87jzryg370.fsf@gmail.com> <871qe6wxle.fsf@gmail.com> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 64275-done Cc: Basil Contovounesios , 64275-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) On 21/10/2023 10:39, Wilhelm Kirschbaum wrote: > > >>> > >>> I'm not sure what you meant by the last sentence, sorry. What > >>> do > >>> you > >>> think about the below? > >>> > >>>   (sigil (sigil_name) @elixir-ts-font-sigil-name-face) > >>>   @font-lock-string-face) > >> > >> Sorry for the late reply.  I believe the following patch is > >> more > >> appropriate as it will apply the sigil font to the entire > >> sigil, but > >> also respect the regex face.  We can add string specific > >> matches > >> later, > >> but happy just to simplify what we have and fix apply > >> appropriate > >> font > >> to previously unmatched sigils. > >> > >> [2. text/x-patch; > >> 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode.patch]... > > > > Actually, the above patch breaks the embedded HEEx sigils' > > font. We > > have to exclude it when doing a general match.  Attached works > > with ~H > > sigils as well.  Please ignore the previous patch and install > > this > > one. > > > > [2. text/x-patch; > > 0001-Simplify-sigil-font-lock-match-for-elixir-ts-mode(1).patch]... > > > Sorry :(. I am finding more edge cases.  Maybe let me test it this > properly this week before we make any changes. > > > I tested this patch for a while now and it looks like the best approach > for handling regex sigils, but with an appropriate fallback. > > If this can be installed, it will be appreciated. Thanks! Installed, and closing. From unknown Fri Jun 20 07:21:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 Nov 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator