From unknown Sat Aug 09 13:14:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64274 <64274@debbugs.gnu.org> To: bug#64274 <64274@debbugs.gnu.org> Subject: Status: 30.0.50; Eglot requests textDocument/documentSymbol if its not declared in the server capabilities Reply-To: bug#64274 <64274@debbugs.gnu.org> Date: Sat, 09 Aug 2025 20:14:28 +0000 retitle 64274 30.0.50; Eglot requests textDocument/documentSymbol if its no= t declared in the server capabilities reassign 64274 emacs submitter 64274 Wilhelm Kirschbaum severity 64274 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 15:47:40 2023 Received: (at submit) by debbugs.gnu.org; 24 Jun 2023 19:47:40 +0000 Received: from localhost ([127.0.0.1]:41560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD9ER-0003TA-QP for submit@debbugs.gnu.org; Sat, 24 Jun 2023 15:47:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:43492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD9EO-0003Sl-W5 for submit@debbugs.gnu.org; Sat, 24 Jun 2023 15:47:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD9EO-00048k-PT for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 15:47:36 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qD9EM-000778-HM for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 15:47:36 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3fa79605a3bso16353015e9.0 for ; Sat, 24 Jun 2023 12:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687636052; x=1690228052; h=mime-version:message-id:date:subject:to:from:user-agent:from:to:cc :subject:date:message-id:reply-to; bh=y0MB+hnHILo4S/q5w9dclhqDyEDTpEKERUPd/JGvJR0=; b=X/gVr8EvOoEO/AvVsIiCZxHD7GzBuSW1FMvle27fPVfbjB1Ocp+s2rFjctfWc7uzP5 soXBI6pLrfTvgT57duM+QeUnb+nacNbY/XGpq5tqn6CaRQ31nx6Tg8qR3aoMu6hCl2oI kXelz9rrA8I3EjHArx3zrTXrwot1MIajErts6lAS9rYV+VMANzoSF+Pscbhb7pDH+YlV SOrTBD/h/VJpZKn7bJkChqHeMJhYlZHhQQgP1dURgds46vR8EbT6z14vwJbIEB8v9vwq u0pikyw7O1MS4MyRzrVCD71ur8uYrUWAy/0VPHkow1sJhYjks4gUQY9GcGhP+32UCmP4 RTPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687636052; x=1690228052; h=mime-version:message-id:date:subject:to:from:user-agent :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y0MB+hnHILo4S/q5w9dclhqDyEDTpEKERUPd/JGvJR0=; b=Hj5G2PEOEBumWy7stLjT/EnF6Yr1qaW9bWCwRjNzUwIDo5/adZGAL47PF0CPHr3rdo 7fl73MZZAsowyZEuRKR0K+mEJNZuyKhiiQbOHP1+mg6mZCLtb2Td7zS7xkpKjy8LJmYY axNHtpU0Wwq56EL7Pp6Ig7nEEPylJxZSZPlgz/3qAgbgE2TiMPN8Lsgp3V3ZrqC1eUBT 72VcvWcXkt2RqXNMiz8RveXSDttW5QJxxvSZw2c6K9evqsu7KPKd+5yCM7o74n+e6DwO t1U8t5n5C/ZF8J2yvHpE4u03M09NrCyaMNMd/o2RrplmUAdzNPUTCerLTdTScQMWvAFN k4kw== X-Gm-Message-State: AC+VfDzshGTYEAWLxAM83zq0DH234rwlbifQGIVMHFzbR2QI3I9xK1sS vGKq8vZmbZdv9XSpOZxmDq1uNRGdm7o= X-Google-Smtp-Source: ACHHUZ4zLGRsl0Y5nkbolJi/OnpEWn4nhzHmGORQFasuTpQ8zDBtzfrPeGKjCQpgqCdihyPTvdj0jg== X-Received: by 2002:a1c:cc07:0:b0:3f7:c92:57a0 with SMTP id h7-20020a1ccc07000000b003f70c9257a0mr22562061wmb.14.1687636051950; Sat, 24 Jun 2023 12:47:31 -0700 (PDT) Received: from melissa.local (ec2-13-245-180-173.af-south-1.compute.amazonaws.com. [13.245.180.173]) by smtp.gmail.com with ESMTPSA id d11-20020a05600c3acb00b003f7f475c3bcsm7342929wms.1.2023.06.24.12.47.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jun 2023 12:47:31 -0700 (PDT) User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Eglot requests textDocument/documentSymbol if its not declared in the server capabilities Date: Sat, 24 Jun 2023 21:40:16 +0200 Message-ID: <878rc8ej73.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=wkirschbaum@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Calling imenu when eglot is enabled it will request textDocument/documentSymbol even if the server has not declared it as a capability. I believe this issue is with `eglot-imenu'. The client will recover if the server replies with an error, but outputs an ugly error. In GNU Emacs 30.0.50 (build 11, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-06-24 built on melissa.local Repository revision: a3df33f1c2f8beb08ea9fc4b91eaeae78db79489 Repository branch: master System Description: Arch Linux Configured using: 'configure --with-pgtk --with-tree-sitter --with-json --with-native-compilation=aot' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB Important settings: value of $LANG: en_ZA.UTF-8 locale-coding-system: utf-8-unix Major mode: mu4e:main Minor modes in effect: mu4e-search-minor-mode: t mu4e-update-minor-mode: t mu4e-context-minor-mode: t global-floatpays-mode: t marginalia-mode: t savehist-mode: t vertico-mode: t global-corfu-mode: t electric-pair-mode: t yas-global-mode: t global-flycheck-mode: t global-treesit-auto-mode: t global-diff-hl-mode: t global-git-commit-mode: t shell-dirtrack-mode: t server-mode: t global-jinx-mode: t which-key-mode: t override-global-mode: t pixel-scroll-precision-mode: t repeat-mode: t winner-mode: t save-place-mode: t which-function-mode: t global-auto-revert-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t overwrite-mode: overwrite-mode-binary Load-path shadows: /home/wilhelm/.config/emacs/elpa/transient-20230602.2121/transient hides /usr/local/share/emacs/30.0.50/lisp/transient Features: (shadow mm-archive sort smiley gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check qp view emacsbug goto-addr tramp-cmds magit-extras consult-imenu misearch multi-isearch shortdoc completion help-fns radix-tree pulse bug-reference tramp-cache time-stamp tramp-sh tramp tramp-loaddefs trampver tramp-integration tramp-compat face-remap files-x sgml-mode dired-aux vc-hg vc-bzr vc-src vc-sccs vc-cvs vc-rcs gnus-dired diff-hl-dired cape display-line-numbers disp-table whitespace init.el mu4e-alert advice time ht alert log4e notifications gntp mu4e mu4e-org mu4e-main mu4e-view gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time iso8601 gnus-spec gnus-int gnus-range gnus-win gnus nnheader range mu4e-headers mu4e-compose mu4e-draft mu4e-actions smtpmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message flow-fill mule-util hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-server mu4e-context mu4e-obsolete mu4e-vars mu4e-helpers mu4e-config ido srht plz git-related verb js c-ts-common denote mastodon mastodon-search mastodon-toot facemenu mastodon-iso persist mastodon-http request flycheck-package package-build package-build-badges package-recipe package-lint let-alist finder lisp-mnt eat elfeed-show elfeed-search shr pixel-fill kinsoku elfeed-csv elfeed elfeed-curl elfeed-log elfeed-db elfeed-lib url-queue url-file xml-query fontaine modus-vivendi-theme modus-themes embark-consult consult magit-bookmark bookmark embark-org org-element org-persist xdg org-id org-refile avl-tree embark ffap marginalia savehist orderless vertico kind-icon svg-lib svg dom xml corfu-terminal popon corfu elec-pair posframe yasnippet-snippets yasnippet flycheck treesit-auto avy org-toc org-contrib org-clock ob-shell ob-elixir async ob-async org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs cal-menu calendar cal-loaddefs org-version org-compat org-macs yaml-mode terraform-mode hcl-mode php-mode mode-local speedbar ezimage dframe cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align php-face php php-project cc-engine cc-vars cc-defs markdown-mode color noutline outline erlang-start erlang etags fileloop generator tempo align mix elixir-ts-mode heex-ts-mode eglot external-completion jsonrpc xref flymake-proc flymake project ert debug backtrace find-func dockerfile-mode sh-script smie treesit executable pcmpl-args pcmpl-linux pcmpl-unix git-modes gitignore-mode gitconfig-mode conf-mode gitattributes-mode diff-hl log-view vc-dir ewoc vc git-timemachine vc-git vc-dispatcher magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode diff diff-mode git-commit log-edit message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor comp comp-cstr warnings rx shell pcomplete server magit-mode transient magit-git magit-base magit-section format-spec cursor-sensor crm functions jinx compat use-package-bind-key which-key ripgrep thingatpt grep ag vc-svn compile text-property-search comint ansi-osc ansi-color find-dired s dired-rainbow dired-subtree dired-hacks-utils dash dired dired-loaddefs all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons exec-path-from-shell edmacro kmacro bind-key easy-mmode use-package-ensure use-package-core finder-inf ag-autoloads all-the-icons-autoloads avy-autoloads cape-autoloads consult-dir-autoloads corfu-terminal-autoloads corfu-autoloads deft-autoloads denote-autoloads diff-hl-autoloads dired-rainbow-autoloads dired-subtree-autoloads dired-hacks-utils-autoloads dockerfile-mode-autoloads dumb-jump-autoloads eat-autoloads elfeed-autoloads elpher-autoloads embark-consult-autoloads consult-autoloads embark-autoloads emmet-mode-autoloads erc-hl-nicks-autoloads erc-image-autoloads erlang-autoloads exec-path-from-shell-autoloads exunit-autoloads fireplace-autoloads flycheck-package-autoloads flycheck-autoloads fontaine-autoloads git-modes-autoloads git-timemachine-autoloads jinx-autoloads kind-icon-autoloads lsp-mode-autoloads f-autoloads lv-autoloads magit-autoloads pcase git-commit-autoloads marginalia-autoloads markdown-mode-autoloads mastodon-autoloads mix-autoloads mu4e-alert-autoloads ht-autoloads alert-autoloads log4e-autoloads gntp-autoloads ob-async-autoloads async-autoloads ob-elixir-autoloads orderless-autoloads org-contrib-autoloads org-roam-autoloads magit-section-autoloads emacsql-autoloads ox-hugo-autoloads package-build-autoloads derived package-lint-autoloads pcmpl-args-autoloads persist-autoloads php-mode-autoloads pkg-info-autoloads epl-autoloads popon-autoloads popup-autoloads posframe-autoloads request-autoloads ripgrep-autoloads spinner-autoloads srht-autoloads plz-autoloads svg-lib-autoloads terraform-mode-autoloads hcl-mode-autoloads tomelr-autoloads transient-autoloads treesit-auto-autoloads ts-autoloads s-autoloads dash-autoloads verb-autoloads vertico-autoloads web-mode-autoloads which-key-autoloads with-editor-autoloads info compat-autoloads yaml-mode-autoloads yasnippet-snippets-autoloads yasnippet-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source eieio eieio-core cl-macs password-cache json map byte-opt gv bytecomp byte-compile url-vars native cl-extra help-mode pixel-scroll cua-base subr-x repeat winner ring saveplace cl-seq which-func imenu autorevert filenotify cus-edit pp cus-load icons wid-edit cl-loaddefs cl-lib early-init rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 1274429 1936458) (symbols 48 80205 135) (strings 32 316832 86354) (string-bytes 1 10274587) (vectors 16 143778) (vector-slots 8 3608027 4190577) (floats 8 1424 3487) (intervals 56 17512 19707) (buffers 984 69)) From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 16:11:31 2023 Received: (at submit) by debbugs.gnu.org; 24 Jun 2023 20:11:31 +0000 Received: from localhost ([127.0.0.1]:41568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD9bX-00046D-2L for submit@debbugs.gnu.org; Sat, 24 Jun 2023 16:11:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:58140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD9bR-00045r-GO for submit@debbugs.gnu.org; Sat, 24 Jun 2023 16:11:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD9bR-0007sW-6d for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 16:11:25 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qD9bN-00081x-GZ for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 16:11:24 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3113dabc549so2651735f8f.1 for ; Sat, 24 Jun 2023 13:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687637480; x=1690229480; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=oD5Tqj4Rf1g1J/Xez+FVYpcm26AY3R+dTxP8Sey/EI0=; b=DaQ7+mxRkABHUQ58O2wDC1Bz8Yt1dWESXC8dwxomiK22Teaq7U15yoIaYCQuI1qIg0 ZfyzAFl8Pq4vHxtuoc9wQ3MsGqDJADN1oy48/NsJRPGtwpDtzrZuyQx++tPC3D5wh8F0 9GzGKIVAunwMfOCRtzC7fudv/Qc+djqZGHoba82bwSUE58a8ya64a6U7+bhlYAq7m9OP QJB7/YPFr9LnLegxm6aKqUW/MvPGNvtWNeh06aA0IMHPbecxmDrOfR4GIz7i3BlcmfQi pAHCM23NYv5suAlb9SAxtVMaaKtMUpgv2+RJqCbasc6JcF6clBm/h3wjM2S2u6lTqa9r DWwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687637480; x=1690229480; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oD5Tqj4Rf1g1J/Xez+FVYpcm26AY3R+dTxP8Sey/EI0=; b=aYCT/jsYek/vsdYyWO8DayFBjRdsnqnVqTTqPHutiIjyqDXzOS4UZXsK3/f5tiIrAU sNPY+VAd/r6PzMOLsd76nGZKiHucj/wiO2lRtqvcXpTXRwWS+s//yqKGlmfbWV96dHC6 OWZHpxXLrwBcVOpwiEz0WLI4gT6rEs4yRWHmE1cgxHm7j3GM/QhZb3R5sLmRrTPEoStY 2CjERnLBOfrHtP+WxjU9kKKRaRR6ci3ZY2XviE8gdqZp/G49XzNxIpHZMhSdYf5SUnuq wjOizQutSzqwkbGILOH65sk7sFSZVm+zacfEJusKDUvoTnJ8lpcZ0eK5nRcarZyUI7KX oMhw== X-Gm-Message-State: AC+VfDxTBD76Mtus80zdvhKJS0IzayYANJhEKzrpGUXtnMpU/tkM0eVv jlUWZ7eIZymFopjBwdMHacNaqAoV4FI= X-Google-Smtp-Source: ACHHUZ7/wpabuSzgM3iISUmA/mnuEBpx4+ZNB0KggcZJfMJ3JeU6ozQc+oaOeVKUmm+/P2NqKROXDw== X-Received: by 2002:a5d:6aca:0:b0:313:df08:7b82 with SMTP id u10-20020a5d6aca000000b00313df087b82mr3275060wrw.12.1687637479443; Sat, 24 Jun 2023 13:11:19 -0700 (PDT) Received: from melissa.local (ec2-13-245-180-173.af-south-1.compute.amazonaws.com. [13.245.180.173]) by smtp.gmail.com with ESMTPSA id i6-20020adffc06000000b00313e421c620sm2088654wrr.54.2023.06.24.13.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jun 2023 13:11:18 -0700 (PDT) References: <878rc8ej73.fsf@gmail.com> User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: Wilhelm Kirschbaum Subject: Re: bug#64274: 30.0.50; Eglot requests textDocument/documentSymbol if its not declared in the server capabilities Date: Sat, 24 Jun 2023 22:07:59 +0200 In-reply-to: <878rc8ej73.fsf@gmail.com> Message-ID: <874jmwei3g.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=wkirschbaum@gmail.com; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, 64274@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; format=flowed Here is a naive patch which fixes it for me. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-eglot-imenu-when-the-server-does-not-support-it.patch >From 9a1389305d92f0e08d39d2ff5540cb494c012f12 Mon Sep 17 00:00:00 2001 From: Wilhelm H Kirschbaum Date: Sat, 24 Jun 2023 21:54:30 +0200 Subject: [PATCH 1/1] Fix eglot-imenu when the server does not support it A language server might not support textDocument/documentSymbol, so we need to check first. * lisp/progmodes/eglot.el (eglot-imenu): Check for the textDocument/documentSymbol capability before requesting. --- lisp/progmodes/eglot.el | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index e2478f2dde3..265cfc88579 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -3351,16 +3351,17 @@ eglot--imenu-DocumentSymbol (defun eglot-imenu () "Eglot's `imenu-create-index-function'. Returns a list as described in docstring of `imenu--index-alist'." - (let* ((res (eglot--request (eglot--current-server-or-lose) - :textDocument/documentSymbol - `(:textDocument - ,(eglot--TextDocumentIdentifier)) - :cancel-on-input non-essential)) - (head (and (cl-plusp (length res)) (elt res 0)))) - (when head - (eglot--dcase head - (((SymbolInformation)) (eglot--imenu-SymbolInformation res)) - (((DocumentSymbol)) (eglot--imenu-DocumentSymbol res)))))) + (when (eglot--server-capable :textDocument/documentSymbol) + (let* ((res (eglot--request (eglot--current-server-or-lose) + :textDocument/documentSymbol + `(:textDocument + ,(eglot--TextDocumentIdentifier)) + :cancel-on-input non-essential)) + (head (and (cl-plusp (length res)) (elt res 0)))) + (when head + (eglot--dcase head + (((SymbolInformation)) (eglot--imenu-SymbolInformation res)) + (((DocumentSymbol)) (eglot--imenu-DocumentSymbol res))))))) (cl-defun eglot--apply-text-edits (edits &optional version) "Apply EDITS for current buffer if at VERSION, or if it's nil." -- 2.41.0 --=-=-= Content-Type: text/plain; format=flowed Wilhelm --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 17:56:51 2023 Received: (at 64274) by debbugs.gnu.org; 24 Jun 2023 21:56:51 +0000 Received: from localhost ([127.0.0.1]:41611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDBFT-00088E-DV for submit@debbugs.gnu.org; Sat, 24 Jun 2023 17:56:51 -0400 Received: from mail-oa1-f54.google.com ([209.85.160.54]:57553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDBFP-00087q-QW for 64274@debbugs.gnu.org; Sat, 24 Jun 2023 17:56:50 -0400 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-1a991886254so1888153fac.2 for <64274@debbugs.gnu.org>; Sat, 24 Jun 2023 14:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687643802; x=1690235802; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2wGuymi8pdGn1DjSHE+5uQ8iWqqB/1BH7suiGpTc5/Y=; b=P3VGL0D+CfqrecdTLPJ6DSgKoAPFCT/Fn+Ge52QcSucqyvFbl73hFdIO3Lq4pZ5h6A Tg+7gZAtI8ItcrJp3+r9SL4HbTd+Lcf+W/Mjs7oXwcVRqQr3MHmS3WosgSJoXB7yushc 6VW77S+9iBd+5x8miOJc6HU7V7IywnPKiEYvOwJ+xGzLR2sYIXh3dmYkyu92Hm5xOqc4 E4JvVDVNZe0tRkMzm0usowbem2Fpru4VwWZls0MaL3V6nECHroAe0NczCZja7rdgkYlC +P4DecgNLbVclS9NzyWQHWEK6fHbyfnSf6+SksUf4dk0CfGxWnqjlYkXhkj86POhUxlf 5xtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687643802; x=1690235802; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2wGuymi8pdGn1DjSHE+5uQ8iWqqB/1BH7suiGpTc5/Y=; b=IAeCbkqDCf0Dgmkulw8l8pM1FEHZhasJE6ch3bR47gT2SdtHUgS08tfb1XSq6GSWYg 9J7gH9aoQNrba+NO+00RMct6ObQfiHfBfmsWfryKW7S7TsacRNaWAsyCta0oWgBmGzjy OJGInTVPfodU4Q/AO/jFg4evMfUkZfWr8/jEzjuT/s7VyJ5h8bsWsMp25oj6xDvnb5y5 tU+kXDfg5uukl1KyYpNd0hmOuLJY/hx8PX62HXIoaKwK8LmD592JVrMK5k9ZKvX82jd3 qqFGQXl1geuMozWa8yatFdioJw2A2nrYItGjqNc8rnj12PEeKMAOF6YoBuYDxP6cKgRT Mvcw== X-Gm-Message-State: AC+VfDzJ3iO9IDiYBBk0Rzitixu6gCqk6SpgUiL5xGTKA6uBNfQZhjg7 aLllw8Ejyw8QogGIOf3ZvsujkV68/m8G2PL6CHM= X-Google-Smtp-Source: ACHHUZ7c1KUv6rEM/HVX4i6zahqFyYkoRDZkjF0Vr58hYnHV9QzsyyQQYo0BzIte1gee4wqxhe15x93F7KEray+qJEI= X-Received: by 2002:a05:6870:8c02:b0:1ac:ec29:6eaf with SMTP id ec2-20020a0568708c0200b001acec296eafmr12005676oab.19.1687643802065; Sat, 24 Jun 2023 14:56:42 -0700 (PDT) MIME-Version: 1.0 References: <878rc8ej73.fsf@gmail.com> <874jmwei3g.fsf@gmail.com> In-Reply-To: <874jmwei3g.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 24 Jun 2023 22:56:27 +0100 Message-ID: Subject: Re: bug#64274: 30.0.50; Eglot requests textDocument/documentSymbol if its not declared in the server capabilities To: Wilhelm Kirschbaum Content-Type: multipart/alternative; boundary="00000000000054631e05fee731da" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64274 Cc: 64274@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000054631e05fee731da Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, i think the patch is in the right direction, but you could use eglot--server-capable-or-lose. Can you test it? Jo=C3=A3o On Sat, Jun 24, 2023, 21:12 Wilhelm Kirschbaum wrote: > > Here is a naive patch which fixes it for me. > > > Wilhelm > --00000000000054631e05fee731da Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, i think the patch is in the right direction, but = you could use eglot--server-capable-or-lose.

Can you test it?

=
Jo=C3=A3o

On Sat, Jun 24, 2023, 21= :12 Wilhelm Kirschbaum <wkirsch= baum@gmail.com> wrote:

Here is a naive patch which fixes it for me.


Wilhelm
--00000000000054631e05fee731da-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 18:42:25 2023 Received: (at 64274) by debbugs.gnu.org; 24 Jun 2023 22:42:25 +0000 Received: from localhost ([127.0.0.1]:41674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDBxK-0003Xi-9D for submit@debbugs.gnu.org; Sat, 24 Jun 2023 18:42:25 -0400 Received: from mail-lj1-f177.google.com ([209.85.208.177]:59620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDBxF-0003XA-Jv for 64274@debbugs.gnu.org; Sat, 24 Jun 2023 18:42:07 -0400 Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2b699284ff4so5312411fa.2 for <64274@debbugs.gnu.org>; Sat, 24 Jun 2023 15:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687646519; x=1690238519; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=H1tHjgWCWsdrBzRgNm8MROn0CpQ4StrZxt5/q4qSYaw=; b=IabIYfpNdMRwdo1BH6b65UDcnP1thmo+AROndfBsvWbPmVi4nJ7NbdaBui9l+voPzf o7hdIwx05oYVwTs+Dr3apueFW5ZnLBpxlHPbvtweRUBw0G6+DKSn3scO7zzir8EJHata eK+AODaMkcAmeQwZCwQE1vrcIwSw1IQcoFejRfMRwBykgfYKs/48VWimKHrqcIYuzWy6 +sSHO/7g1o4Z70XZa6GXwh2lhlbH/4IKnHTr+VhFwzJMc1n1sBmvhPR8wDprcnlQS0of hZ/WRSPYLDR3NnNVLqIq2N8D4YRmxPY61mTalS1kS2waQUsiyfZqnq73euFheSDW9zav XrSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687646519; x=1690238519; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=H1tHjgWCWsdrBzRgNm8MROn0CpQ4StrZxt5/q4qSYaw=; b=jZg1gL7xFVLKQBJu/UQ5rLCXdgHERuuBbcLQETkvSIliIZINkcwIko5sU9E2Ft3kWI 8sAlXc7ERxyedi7NjKffdC40/61VZv7S9rmO4UCqDkoqitar6FZc/dnHeicDskHPgG3S haOmi/uZNGDzh9c+zIIJcF5UpioUEAcogKwVpTdTRaJKH18dfGkG9jpfmhoelSvvsDDi p24vz4xSZSZaLW5POWfct7kYzWODD5NMt4E7+aqU5t6FzR/r+9j9abfgqI0D7BaL+90U O6PSVCc2YdZ1y1e71lV14+9BzoYrTkZ8h8Pm+JosFl7ILTsP8JJ0MbpAJlMSVKHGm7Fi P59w== X-Gm-Message-State: AC+VfDzR6ZeRkeDX7Nvp6ktqMSgf+WqFi4gnqCv2kjvw84GyfAuxuPK8 P77zCu1EDKu05+xnSgiYic1/ZO66pTI= X-Google-Smtp-Source: ACHHUZ5VpdD62rWOfDP2byL/Mr5EVYdmVvZ70hSh+H+p2KR26CMXAXU7dk3Loaao+9QTH0n67XlG3w== X-Received: by 2002:a2e:86cd:0:b0:2b6:9bf3:27ab with SMTP id n13-20020a2e86cd000000b002b69bf327abmr213039ljj.48.1687646519010; Sat, 24 Jun 2023 15:41:59 -0700 (PDT) Received: from melissa.local (ec2-13-245-180-173.af-south-1.compute.amazonaws.com. [13.245.180.173]) by smtp.gmail.com with ESMTPSA id y15-20020a7bcd8f000000b003f8f9ab6f30sm3216789wmj.20.2023.06.24.15.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jun 2023 15:41:58 -0700 (PDT) References: <878rc8ej73.fsf@gmail.com> <874jmwei3g.fsf@gmail.com> User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#64274: 30.0.50; Eglot requests textDocument/documentSymbol if its not declared in the server capabilities Date: Sun, 25 Jun 2023 00:35:22 +0200 In-reply-to: Message-ID: <875y7c8ouk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64274 Cc: 64274@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Thanks, i think the patch is in the right direction, but you=20 > could use eglot--server-capable-or-lose. > The idea is to transparently just fall back to the non-eglot imenu=20 and not sure if I want to see a warning for this every time imenu gets called.=20 > Can you test it? I tested eglot--server-capable-or-lose and it is not ideal,=20 because not only does it not fall back, it spams the warning and if the=20 languages. > > Jo=C3=A3o > > On Sat, Jun 24, 2023, 21:12 Wilhelm Kirschbaum=20 > wrote: > > Here is a naive patch which fixes it for me. > > Wilhelm From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 19:03:42 2023 Received: (at 64274) by debbugs.gnu.org; 24 Jun 2023 23:03:42 +0000 Received: from localhost ([127.0.0.1]:41684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDCIA-00048P-Cr for submit@debbugs.gnu.org; Sat, 24 Jun 2023 19:03:42 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:51473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDCI5-000486-GA for 64274@debbugs.gnu.org; Sat, 24 Jun 2023 19:03:41 -0400 Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3112d202363so2239873f8f.3 for <64274@debbugs.gnu.org>; Sat, 24 Jun 2023 16:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687647811; x=1690239811; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XYrXlnYhMdY/lailMshbENuzu7K1zFAtz3/QBE+PO+I=; b=Rv+ckX1llNNCnNh1F96pYYt9rcz2uvaeU4AmQikHzNfqJjhruDNovq8GjpXWfjs0fm uD8+eGGvXHJ8icbVOVjJoTX9kXOBBVranVoHFNZc9+mr7MosK+fdQNdAFWO0KFn0KXlw otMNSO1kYQy3OUIvsCQg8SxHWK1BoB5hshvM4uU5M7BrK4MUjfFg6b1Xm0T0ZrkhPfad NOZatuz96iWIP7Pm2r6EluY5WIrBSXd7O1fi8mosonbvEix/70GAB2koddcFnZ2X8gWZ LChAWYpU+11dEPq26n7rTnoGK1wPyPCNpQWPRXA3VkBj2FCQjhC/mIDqt7QUQ4I7g4D9 DntA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687647811; x=1690239811; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XYrXlnYhMdY/lailMshbENuzu7K1zFAtz3/QBE+PO+I=; b=JTkZfL4oQahMZGr0rn/aRhBtqSqIM3P9Ah7RtIUBVz2WPo2Sim3LpIloP7WwuWSL3n aD3I2vyzeLCjfFyVAoVsO9Mi+zaF+36Dm4Ki9yhn1DKF9pApkV4OIN9kwXFOLDynsKy/ WaUIw//FSlTtD1nQr6T1M0Q8POaoLraSro8RiowjuT3w4ol43LD5i8dGt/oCpNO9IHXd JgqX1mnNccCKKuqfaW9jmKfeApUS5w6+lkfSEcf+hr6fGOxlgUl+jEKmrx5K8+neDzeY 2P6+JiIWF5/eiuX1LLuTxSYA2pz569Z6DoOjKC0jrA2ANVZRvgEAfqNOCDj1QGBHIKjC gb0g== X-Gm-Message-State: AC+VfDx35WnedE6UtDCx4oioVpt9Ag2d5MF65sq2svoG1ipx7s1/WTg3 ZvRT8GULpwVHCNjA8hWR03Qz+XDsVrw= X-Google-Smtp-Source: ACHHUZ4/hlHhT+MCQLKYsb2EMYWprWEx2qxDu6fYClVfKJRGMLpVWq8MxhNS2OqzVgJXy5bl7IDAdA== X-Received: by 2002:a5d:60c8:0:b0:30f:af19:81f3 with SMTP id x8-20020a5d60c8000000b0030faf1981f3mr18583057wrt.41.1687647811206; Sat, 24 Jun 2023 16:03:31 -0700 (PDT) Received: from krug (87-196-72-155.net.novis.pt. [87.196.72.155]) by smtp.gmail.com with ESMTPSA id j9-20020a5d4649000000b0030aefa3a957sm3136795wrs.28.2023.06.24.16.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jun 2023 16:03:30 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Wilhelm Kirschbaum Subject: Re: bug#64274: 30.0.50; Eglot requests textDocument/documentSymbol if its not declared in the server capabilities In-Reply-To: <875y7c8ouk.fsf@gmail.com> (Wilhelm Kirschbaum's message of "Sun, 25 Jun 2023 00:35:22 +0200") References: <878rc8ej73.fsf@gmail.com> <874jmwei3g.fsf@gmail.com> <875y7c8ouk.fsf@gmail.com> Date: Sun, 25 Jun 2023 00:06:00 +0100 Message-ID: <871qi0795z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64274 Cc: 64274@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Wilhelm Kirschbaum writes: >> Thanks, i think the patch is in the right direction, but you could >> use eglot--server-capable-or-lose. >> > > The idea is to transparently just fall back to the non-eglot imenu and > not sure if I want to see a warning for this every time imenu gets > called. > Can you test it? OK, this makes sense. Then please test this instead. Jo=C3=A3o diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index e2478f2dde3..c353ab6fce0 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -3348,9 +3348,11 @@ eglot--imenu-DocumentSymbol (mapcar (lambda (c) (apply #'dfs c)) children)= ))))) (mapcar (lambda (s) (apply #'dfs s)) res))) =20 -(defun eglot-imenu () +(cl-defun eglot-imenu () "Eglot's `imenu-create-index-function'. Returns a list as described in docstring of `imenu--index-alist'." + (unless (eglot--server-capable :textDocument/documentSymbol) + (cl-return-from eglot-imenu)) (let* ((res (eglot--request (eglot--current-server-or-lose) :textDocument/documentSymbol `(:textDocument From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 19:22:16 2023 Received: (at 64274) by debbugs.gnu.org; 24 Jun 2023 23:22:16 +0000 Received: from localhost ([127.0.0.1]:41698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDCa7-0004ZD-V6 for submit@debbugs.gnu.org; Sat, 24 Jun 2023 19:22:16 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:59480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDCa3-0004Yx-Vc for 64274@debbugs.gnu.org; Sat, 24 Jun 2023 19:22:14 -0400 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-3f9002a1a39so18429135e9.2 for <64274@debbugs.gnu.org>; Sat, 24 Jun 2023 16:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687648926; x=1690240926; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=dyd1maTMYxTp9tOqkSy1CRz+Aqacm7atuiUdURrBeG8=; b=CyqmKl0onO3AaYZOD9ER+7taqMjZrpHy0U26CErJkrar7LE/k7fsgqr5u4O/utk/nj gfwqnl6QNSp7l+GOOCJudQ/XXQv0p7UcvHvMYR90MCbqHUdgVR7xqmlga/nYo/5wAbej ANyc8MHa737Sor/8x8YwlEy7lqnHPCbBgmxEBGlew0DPg674i7ZRznWr94E1jH9/Asmw YVJAjYo5AQ7DR3/7mKhuqBs+UJ6gRgrALV4FGUwLSCuqakPBbJQ9mXMBUfT9aZIYx3JH o0nZnro7y4oEH0MdCRVzPKL+10pkvZaDWB+NbwLH/z5ZlE9XJKQXWYbwbvOODaZligwa McfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687648926; x=1690240926; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dyd1maTMYxTp9tOqkSy1CRz+Aqacm7atuiUdURrBeG8=; b=KAI099FW2TXgCmgKAwHRB4MkMjG3phB12gzhmmq7JZ8XV4bKohg3C0HUXV2ryJLZ/u F61mrO3j1E6OMwhYJkFbhdJIHiLkdGjq8RIv1W0TpD0wRZ1vU+Kjc6mjCf7z7MkYReCq rfuotDbQjXz9vrUCeAzLPMu/B78ndbh/oSbYeczWoyuibMrysZ9RjxNeJu4Pc4CTVfD0 A9DK5lV5B+NPsXfZFlLBIqyo2QTKS6KhFrR6TFYXyKw5z78VwPGdh98qj4JDQlRIdSZn E1RSkgZkt5XbUwrw+2OfvejnTpGDFgz4R6w5JphsuCw2E9JgbQVcgzQ7anrcLA1W86Oo aY4Q== X-Gm-Message-State: AC+VfDwH3WkcqbtzTXn0V9nJxyFU4h9jkJecpMUj5moJeXz0MpBBKqdk PJCBymgTDlr0alyOkacRxZCbJdELywo= X-Google-Smtp-Source: ACHHUZ7eeJkhREok646cCOMzyseSN2r17/UJWLLRzRwNiK6u4pwlJAqsEH78lF+2oGFjt8kFAUS4rw== X-Received: by 2002:a05:600c:3797:b0:3fa:838a:1dcf with SMTP id o23-20020a05600c379700b003fa838a1dcfmr1522400wmr.6.1687648925743; Sat, 24 Jun 2023 16:22:05 -0700 (PDT) Received: from melissa.local (ec2-13-245-180-173.af-south-1.compute.amazonaws.com. [13.245.180.173]) by smtp.gmail.com with ESMTPSA id n23-20020a7bcbd7000000b003f9b19caabesm3246895wmi.37.2023.06.24.16.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jun 2023 16:22:05 -0700 (PDT) References: <878rc8ej73.fsf@gmail.com> <874jmwei3g.fsf@gmail.com> <875y7c8ouk.fsf@gmail.com> <871qi0795z.fsf@gmail.com> User-agent: mu4e 1.9.3; emacs 30.0.50 From: Wilhelm Kirschbaum To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#64274: 30.0.50; Eglot requests textDocument/documentSymbol if its not declared in the server capabilities Date: Sun, 25 Jun 2023 01:21:16 +0200 In-reply-to: <871qi0795z.fsf@gmail.com> Message-ID: <87wmzsqwdh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64274 Cc: 64274@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > OK, this makes sense. Then please test this instead. > > Jo=C3=A3o > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index e2478f2dde3..c353ab6fce0 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -3348,9 +3348,11 @@ eglot--imenu-DocumentSymbol > (mapcar (lambda (c) (apply #'dfs=20 > c)) children)))))) > (mapcar (lambda (s) (apply #'dfs s)) res))) >=20=20 > -(defun eglot-imenu () > +(cl-defun eglot-imenu () > "Eglot's `imenu-create-index-function'. > Returns a list as described in docstring of=20 > `imenu--index-alist'." > + (unless (eglot--server-capable :textDocument/documentSymbol) > + (cl-return-from eglot-imenu)) > (let* ((res (eglot--request (eglot--current-server-or-lose) > :textDocument/documentSymbol > `(:textDocument Yes, this works. Thank you. :) Wilhelm From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 01 18:05:40 2023 Received: (at 64274-done) by debbugs.gnu.org; 1 Jul 2023 22:05:40 +0000 Received: from localhost ([127.0.0.1]:58846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFiin-0001ht-8d for submit@debbugs.gnu.org; Sat, 01 Jul 2023 18:05:40 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:61781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFiih-0001hb-JU for 64274-done@debbugs.gnu.org; Sat, 01 Jul 2023 18:05:36 -0400 Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3a36b309524so2550556b6e.3 for <64274-done@debbugs.gnu.org>; Sat, 01 Jul 2023 15:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688249126; x=1690841126; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9B527IMmAIX6QzbuoNvmuEAK+xH7uGWn84R6bbydtXs=; b=RnvhULGat0fM5vYFwyIwHm0aue+zuz8VIkg8p+NoSBs38uJj67G2rlzakkLOJXRG/I ITIAbaitw+RHh4jrIbnQE6bbgk6xKDBlDPWuV+4WJBPEHNccstxspZ/nYV1n9mjDEcOF 1Z46C5olnkvMe87vagrPFV4IbMIisoCuzQvTGyl/pP3sr9FUT7IWKAh+v5jMqYUrEbX0 fRj6VrVnZb7bLNqID26hcrnoVZfrStR+h5cLAmDC/Rm6wi5DmYQ6TwLWpA2dOEruNVCB UFUpWF9k59bhrXVuy47dy4nkqwE6yA8lxxIdF1TRhUcD5uAsSeyUpN3OK1v/WPaDA5Vh FZ+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688249126; x=1690841126; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9B527IMmAIX6QzbuoNvmuEAK+xH7uGWn84R6bbydtXs=; b=jdKAMex3z2RPxuUL02M0diNcgN0hE3niENm3HgT+f0qv7J3j4wcjPNH1s5XUr1G8yj AYshjg9fMEOX9jMeY+dO9WJ0LOLVyekbZ4LylwGXUONeosiMMGX94RZiXG6PBEWLwf7S zaYDxV06JoynvSHgxPmlrfAoyVpqy2dy+cpTBEeDVLnHO4qAnWRxzU6h/RsmVtAFhfTx H3V5wZwDk6fFvDbE/7siNDAeRf6euZP6f6esvSjlWha05vvW69DqPSD5k0xK+ke4icnl 5oYq3C4kQlrbcpdejyA8S7loiuQ8V7LE90jSqxhQz73agjFweN2l7PTysuSyXbbFF/5R SmYQ== X-Gm-Message-State: AC+VfDzSBEe1lSLPJVkEt4ZrWypzH1qTngjBkY5H0hP5Tfrgb6tHM79A RmtecpD9gentXe/syjTag9TDF6SryGIEMhxzVnE= X-Google-Smtp-Source: ACHHUZ5osR33QVeQt/xR3p9dwMOrSpnfgkoVORVOkxCZg/vOLoRi93+/ZfyUyLg7aqI1UWxHJvE3KtnQLRuVI3QJ/WM= X-Received: by 2002:a05:6808:917:b0:3a1:a57d:fa71 with SMTP id w23-20020a056808091700b003a1a57dfa71mr6590842oih.32.1688249125958; Sat, 01 Jul 2023 15:05:25 -0700 (PDT) MIME-Version: 1.0 References: <878rc8ej73.fsf@gmail.com> <874jmwei3g.fsf@gmail.com> <875y7c8ouk.fsf@gmail.com> <871qi0795z.fsf@gmail.com> <87wmzsqwdh.fsf@gmail.com> In-Reply-To: <87wmzsqwdh.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 1 Jul 2023 23:07:46 +0100 Message-ID: Subject: Re: bug#64274: 30.0.50; Eglot requests textDocument/documentSymbol if its not declared in the server capabilities To: Wilhelm Kirschbaum , 64274-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64274-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pushed this patch to master and marking this done. Jo=C3=A3o On Sun, Jun 25, 2023 at 12:22=E2=80=AFAM Wilhelm Kirschbaum wrote: > > > > > OK, this makes sense. Then please test this instead. > > > > Jo=C3=A3o > > > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > > index e2478f2dde3..c353ab6fce0 100644 > > --- a/lisp/progmodes/eglot.el > > +++ b/lisp/progmodes/eglot.el > > @@ -3348,9 +3348,11 @@ eglot--imenu-DocumentSymbol > > (mapcar (lambda (c) (apply #'dfs > > c)) children)))))) > > (mapcar (lambda (s) (apply #'dfs s)) res))) > > > > -(defun eglot-imenu () > > +(cl-defun eglot-imenu () > > "Eglot's `imenu-create-index-function'. > > Returns a list as described in docstring of > > `imenu--index-alist'." > > + (unless (eglot--server-capable :textDocument/documentSymbol) > > + (cl-return-from eglot-imenu)) > > (let* ((res (eglot--request (eglot--current-server-or-lose) > > :textDocument/documentSymbol > > `(:textDocument > > Yes, this works. Thank you. :) > > Wilhelm --=20 Jo=C3=A3o T=C3=A1vora From unknown Sat Aug 09 13:14:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 30 Jul 2023 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator