From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 02:23:42 2023 Received: (at submit) by debbugs.gnu.org; 24 Jun 2023 06:23:42 +0000 Received: from localhost ([127.0.0.1]:39862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCwgM-0001mB-G0 for submit@debbugs.gnu.org; Sat, 24 Jun 2023 02:23:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:56710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCtgq-0004YU-Pm for submit@debbugs.gnu.org; Fri, 23 Jun 2023 23:11:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCtgq-0006Gm-Ju for guix-patches@gnu.org; Fri, 23 Jun 2023 23:11:56 -0400 Received: from mail-40136.proton.ch ([185.70.40.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCtgg-0008IT-At for guix-patches@gnu.org; Fri, 23 Jun 2023 23:11:56 -0400 Date: Sat, 24 Jun 2023 03:11:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samlockart.com; s=protonmail2; t=1687576301; x=1687835501; bh=Xo9TqYBC9v5ulYBeHZi5qgUqOj2eJZz0ZpKU8OOMmJQ=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=QwMznNE9YYowPl2xVRfGAv+8RPpIciDm+o2HCYzhFsv/voT6HHHf4HX+n+hD6VLtH RsBvQwh6IK6JOxiaK3ugHZIhzdLKIQXjEu5g2USJd0zITk3Cfa8E/zssoWvWFOfHNq ct9Fi/Gs4Vq7/aeSQFl+m4eW/Ti6E69bJ8HpqVN/GYIwRo9O/hTGIQigkaXkzMawq1 Z6yuvjWiB9VUtuZVgAerSy5KapQ1YjAwrmLi7fiaD2dmWqTmY3451q5J/G5diJPMby uaiYPfU4OwXqorI38UtgzwgrbmYQAoJofDEGm5LmRjyN4McFKDPiTxLQuXmUlsE9+7 bJf5oDu8ReZGA== To: "guix-patches@gnu.org" From: Sam Lockart Subject: [PATCH] Use cgroups v2 file system Message-ID: Feedback-ID: 30567524:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.136; envelope-from=sam@samlockart.com; helo=mail-40136.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 24 Jun 2023 02:23:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) cgroup v2 is the next generation of the control groups API. This patch replaces the cgroup v1 file system with the unified cgroup v2 file system. cgroup v2 allows for things like containerd/podman to run rootless containe= rs and opens guix system up to running things like Kubernetes. * gnu/system/file-systems.scm: Use cgroups v2 file system --- gnu/system/file-systems.scm | 27 +++++++-------------------- 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 0ff5a0dcf6..59e04bcecf 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -445,26 +445,13 @@ (define %immutable-store (flags '(read-only bind-mount no-atime)))) =20 (define %control-groups - (let ((parent (file-system - (device "cgroup") - (mount-point "/sys/fs/cgroup") - (type "tmpfs") - (check? #f)))) - (cons parent - (map (lambda (subsystem) - (file-system - (device "cgroup") - (mount-point (string-append "/sys/fs/cgroup/" subsystem= )) - (type "cgroup") - (check? #f) - (options subsystem) - (create-mount-point? #t) - - ;; This must be mounted after, and unmounted before the - ;; parent directory. - (dependencies (list parent)))) - '("cpuset" "cpu" "cpuacct" "memory" "devices" "freezer" - "blkio" "perf_event" "pids"))))) + ;; The cgroup2 file system. + (list (file-system + (device "none") +=09 (mount-point "/sys/fs/cgroup") +=09 (type "cgroup2") +=09 (check? #f) +=09 (create-mount-point? #f)))) =20 (define %elogind-file-systems ;; We don't use systemd, but these file systems are needed for elogind, --=20 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 05 16:52:47 2023 Received: (at 64260) by debbugs.gnu.org; 5 Jul 2023 20:52:47 +0000 Received: from localhost ([127.0.0.1]:39044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH9UV-0004Aj-6o for submit@debbugs.gnu.org; Wed, 05 Jul 2023 16:52:47 -0400 Received: from coleridge.kublai.com ([166.84.7.167]:61967 helo=mail.spork.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH9UT-0004AZ-6V for 64260@debbugs.gnu.org; Wed, 05 Jul 2023 16:52:46 -0400 Received: from psyduck (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id C2A0B1AC9; Wed, 5 Jul 2023 16:52:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1688590364; bh=J+n1e48vrDa6T2TeSGhI1qGGA0nO+hpmNWhpuPsywZg=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=w4GJmmou9QxDJOEWiUgarEF+HtvO+zSp8w/SxpYJW+5UV9qc661aG8ac5Q/e7ni6f I5C+TlaWOH6yiiRGjeedYZQmyCZUlgGZKp1XButz8mMTYoXsGU9HmrQaKvPzBUZujV VDNV+MOLb7CyssHQhg4e2mjF8VszQyWtwi2+oJCI= From: Brian Cully To: Sam Lockart Subject: Re: bug#64260: [PATCH] Use cgroups v2 file system In-Reply-To: (Sam Lockart's message of "Sat, 24 Jun 2023 03:11:26 +0000") References: Date: Wed, 05 Jul 2023 16:52:34 -0400 Message-ID: <87cz16gjxp.fsf@psyduck.jhoto.kublai.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64260 Cc: 64260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I've been running this patch for a few days with an elogind-based system and haven't had any issues. This patch also fixes rootless podman with elogind, which is very nice. -bjc From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 02 00:40:29 2023 Received: (at 64260) by debbugs.gnu.org; 2 Aug 2023 04:40:29 +0000 Received: from localhost ([127.0.0.1]:48578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qR3ev-0005Sj-12 for submit@debbugs.gnu.org; Wed, 02 Aug 2023 00:40:29 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:59862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qR3et-0005Sb-Fm for 64260@debbugs.gnu.org; Wed, 02 Aug 2023 00:40:28 -0400 Date: Wed, 02 Aug 2023 12:39:35 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1690950940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9J+8BdM13woHpAGbO+5t7eDOjJlNGClYUkSdTIHqfPU=; b=r1/7NfwMz/vyKd1uCBnAoeDMUM28EuV0rWEp14Em+Rv2ivskCbmWa7xY1WqbcjtRjasXVr M69qus5kKaW0r8r3/OClREcuH1bIUeGMtdbDIodNXmMY0tCpmFkEwyiSCXxEdIO2NiTnsB i1hfE/uUzOutYS5jjJ2zOyPIBJ/VBtqwpunQqvVnmeEN5WlnxxKnLjI4T3NHxLgQh0rxS8 SxDgRnh2+Ls6XyDHga42343vpBpNtr/f9+48JmAm1oFvkTi+cxK+AvXn9l7eZ4dTb/WYgu sPAiovFQ/ll/NbHvWFMYlOcD2CJanQLmZ1d5/NOlzvFIJIfYNX96HU69vABIww== Message-ID: <87r0omoy60.wl-hako@ultrarare.space> From: Hilton Chain To: Brian Cully Subject: Re: [bug#64260] [PATCH] Use cgroups v2 file system In-Reply-To: <87cz16gjxp.fsf@psyduck.jhoto.kublai.com> References: <87cz16gjxp.fsf@psyduck.jhoto.kublai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: / Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64260 Cc: Sam Lockart , 64260@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Thu, 06 Jul 2023 04:52:34 +0800, Brian Cully via Guix-patches via wrote: > > I've been running this patch for a few days with an elogind-based system > and haven't had any issues. This patch also fixes rootless podman with > elogind, which is very nice. > > -bjc I'm not familiar with cgroup, but the current %control-groups is a requirement for docker-shepherd-service: --8<---------------cut here---------------start------------->8--- (shepherd-service (documentation "Docker daemon.") (provision '(dockerd)) (requirement '(containerd dbus-system elogind file-system-/sys/fs/cgroup/blkio file-system-/sys/fs/cgroup/cpu file-system-/sys/fs/cgroup/cpuset file-system-/sys/fs/cgroup/devices file-system-/sys/fs/cgroup/memory file-system-/sys/fs/cgroup/pids networking udev)) --8<---------------cut here---------------end--------------->8--- Thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 08 11:08:37 2023 Received: (at 64260-done) by debbugs.gnu.org; 8 Aug 2023 15:08:37 +0000 Received: from localhost ([127.0.0.1]:37483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTOK5-0006Ho-FQ for submit@debbugs.gnu.org; Tue, 08 Aug 2023 11:08:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTOK3-0006HV-OA for 64260-done@debbugs.gnu.org; Tue, 08 Aug 2023 11:08:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTOJy-0006rY-Cj; Tue, 08 Aug 2023 11:08:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=0UizTIR/XvgWUkRYpDF8usM2MyjmPWCQa2r60crqkS4=; b=ffNbVNV3dJaFoCnctNwa FBabnJv1WO9vCEeDnTQTf5oIjhRGwxgU9uFr/vmTW2Zy2VJyp36+t4a9YIBCsz53aaCFcjWnG+jPy 0FlB9FVMgNZCcff0q1Zo/LkIh2ahQwLv7QV0FyRx2yc2pMDo84Lo2fTixS1WuOSiBwM5VDGcdndqJ 5Rjy4OlIRDKKK/pWZckbbQvayiaflRvxfORuTakEu0PHj6Eqex2n7o8zSKqyeLjijoiMkMnTDMnka ShWmzZlQvtaQWfKXDf9sd15f8L54Zm/ssd6dCYlOffGP/fbbIZE99LoCkkmbpBSWY40yqmldFg1jG fq21Qtex/dSffQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Sam Lockart Subject: Re: bug#64260: [PATCH] Use cgroups v2 file system References: Date: Tue, 08 Aug 2023 17:08:26 +0200 In-Reply-To: (Sam Lockart's message of "Sat, 24 Jun 2023 03:11:26 +0000") Message-ID: <87leelr2qd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64260-done Cc: 64260-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Sam, Sam Lockart skribis: > cgroup v2 is the next generation of the control groups API. > This patch replaces the cgroup v1 file system with the unified > cgroup v2 file system. > > cgroup v2 allows for things like containerd/podman to run rootless contai= ners and opens guix system up to running things like Kubernetes. > > * gnu/system/file-systems.scm: Use cgroups v2 file system [...] Hilton Chain skribis: > I'm not familiar with cgroup, but the current %control-groups is > a requirement for docker-shepherd-service: Good point! Finally applied, with the change Hilton suggested. This passes just fine: make check-system TESTS=3D"docker basic elogind" Thanks, Ludo=E2=80=99. From unknown Thu Sep 11 11:26:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 06 Sep 2023 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator