From unknown Tue Jun 24 22:40:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64235: patch: Ensure that makeinfo =?UTF-8?Q?=E2=89=A5?= 6.8 checks the @menu structure Resent-From: Bruno Haible Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Thu, 22 Jun 2023 22:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64235 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: 64235@debbugs.gnu.org X-Debbugs-Original-To: bug-grep@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168747430211200 (code B ref -1); Thu, 22 Jun 2023 22:52:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jun 2023 22:51:42 +0000 Received: from localhost ([127.0.0.1]:36952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCT9R-0002ua-Gu for submit@debbugs.gnu.org; Thu, 22 Jun 2023 18:51:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:48686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCT9P-0002uQ-Jd for submit@debbugs.gnu.org; Thu, 22 Jun 2023 18:51:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCT9P-0001sw-AE for bug-grep@gnu.org; Thu, 22 Jun 2023 18:51:39 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCT9M-0001mp-UR for bug-grep@gnu.org; Thu, 22 Jun 2023 18:51:39 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1687474293; cv=none; d=strato.com; s=strato-dkim-0002; b=mCaBjKl3AvPcxP1GnfDHG12mAvPemoUsENXtBq0207eeUMy3HDjKDG/0/IJopBbF1f 3LY/QEElGOviK4JvAuisKA270jeiTBqb3aX1V4JSgrXT+af8/C4dER0lJ/4xX0GEiUtd ucj5psAO0vae7nAk3HzpgPHAXQKrwXCgYlAE+0+Qq/KKalMIxTfN/fDpJ9DOJRpzww3S T+/jsbu5vUz1zfug5gO3AQTPIB7MiQRVkIZtor760KDiQAQ/C/LucO1RIxNJC5t4hMnO aAK1OoPMJdxMvCoa7qI4KFwRoLeborPBtd1IeHeAudPasrH98Gzi6+rvhqgydZUIM7h9 2S6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1687474293; s=strato-dkim-0002; d=strato.com; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=NwZbxsj0udF4t/P+O5zun6tguLEfBWyYWHPmVMCjpFg=; b=r0b75eRTy6xXrNVUNNa9Q+HbbVyX/SujY3s0eZVkOQDOVJRIvDPHqVM9gFqeLZ/yo0 wAB6RyWhQsm7dY6TQ7odn/hUZbNqYBal8KZPP/YhKypUh7TxyiJABwYXum0bsEojfbes Y/D1QMUKJOTbak3ZqXU7wWSc/0q6RG9irzGjQ73NzqT3soP6+wpKJYo3AeFr11Phg18V lxyxY6w0HnCg0U0CrCs9Cf50QeiU10j14mNTgxILe25PVI8W9Gv4eRtuUblnnZJDVdYk bMw9frJjoyo+3VpFm4YaXZheiuqsbR9iIZ9ZMboukxGCgR/PNP5UNaLtbS/WCI2ccM6g GC6w== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1687474293; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=NwZbxsj0udF4t/P+O5zun6tguLEfBWyYWHPmVMCjpFg=; b=UOu8QQGSIWNclwEp4KgJyLeR01dOsMTFViRoMUmimFP241fF3R+J4WdrDf2oMJcTue Ulr3z0UkLYj+OC/HPA0d53GmIlYOMB9yIYMjpVfIbT9tZ9hAkikQ4qzAou8jYs8OESlu HbpGN9KavfFSPzYusyb5ivLp2aJXRx/qTvRdOK5385Vya8syVh3A7AoRlQ9yMHV9OHJ1 fa44oKosS3o8iVW4+7fFNI88FzyHemFYOFr6zuFShWF3O1feCYIspqewHoSqUfLAg2QY if0OtgCCffiy8OdhfeUp5TGkobGkVRrmTE0fG7W8PCmocU2wfEWgt/ALq9ERCqE7e0qw fcYw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1687474293; s=strato-dkim-0003; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=NwZbxsj0udF4t/P+O5zun6tguLEfBWyYWHPmVMCjpFg=; b=F9AHk0+2yErW1EgQE87/G+rTjed+lMbB+WZA5fqE05uqebHDm2A/Mat3Wa3GJvYZ/K wgJBzSoNlQ5KNOuoY/CA== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOe3vKnz4NASJkKNkZR9T7ssjto" Received: from nimes.localnet by smtp.strato.de (RZmta 49.6.0 AUTH) with ESMTPSA id 6b0accz5MMpXUBo (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 23 Jun 2023 00:51:33 +0200 (CEST) From: Bruno Haible Date: Fri, 23 Jun 2023 00:51:33 +0200 Message-ID: <5087752.22IY78Rhhi@nimes> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart11139438.5OynTdThKG" Content-Transfer-Encoding: 7Bit Received-SPF: none client-ip=81.169.146.221; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --nextPart11139438.5OynTdThKG Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Makeinfo versions < 6.7 detected mistakes in the @menu structure of TeXinfo input. Makeinfo versions =E2=89=A5 6.8 don't do this any more by default. T= hey need an extra option, for this validation to happen. See . Since doc/grep.texi has a hand-written @menu, it should use this extra option. Here's a patch to that effect. There are two possibilities for adding the extra option: - in the MAKEINFO variable, where it has an effect on both "makeinfo" and "makeinfo --html", - in the AM_MAKEINFOFLAGS variable, where it has an effect on "makeinfo" only. Since some maintainers may check their documentation edits only by regenera= ting the HTML-formatted documentation, the first choice is preferrable. Tested by running touch doc/grep.texi ; (cd doc && make grep.info V=3D1) and make sc_makefile_at_at_check --nextPart11139438.5OynTdThKG Content-Disposition: attachment; filename="0001-build-Ensure-that-makeinfo-6.8-checks-the-menu-struc.patch" Content-Transfer-Encoding: quoted-printable Content-Type: text/x-patch; charset="UTF-8"; name="0001-build-Ensure-that-makeinfo-6.8-checks-the-menu-struc.patch" =46rom 394ad4fb9b1c9f565e3f07b187950be13758df7a Mon Sep 17 00:00:00 2001 =46rom: Bruno Haible Date: Fri, 23 Jun 2023 00:48:13 +0200 Subject: [PATCH] =3D?UTF-8?q?build:=3D20Ensure=3D20that=3D20makeinfo=3D20= =3DE2=3D89=3DA5?=3D =3D?UTF-8?q?=3D206.8=3D20checks=3D20the=3D20@menu=3D20structure.?=3D MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit See . * doc/Makefile.am (MAKEINFO): New variable. * cfg.mk (_makefile_at_at_check_exceptions): New variable. =2D-- cfg.mk | 3 +++ doc/Makefile.am | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/cfg.mk b/cfg.mk index 1000d4f..8eec613 100644 =2D-- a/cfg.mk +++ b/cfg.mk @@ -45,6 +45,9 @@ announcement_Cc_ =3D $(translation_project_), $(PACKAGE)-= devel@gnu.org _gl_TS_unmarked_extern_functions =3D \ main usage mb_clen to_uchar dfaerror dfawarn imbrlen =20 +# Add an exemption for sc_makefile_at_at_check. +_makefile_at_at_check_exceptions =3D ' && !/MAKEINFO/' + # Now that we have better tests, make this the default. export VERBOSE =3D yes =20 diff --git a/doc/Makefile.am b/doc/Makefile.am index 4237af6..4bc2476 100644 =2D-- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -16,6 +16,10 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . =20 +# The customization variable CHECK_NORMAL_MENU_STRUCTURE is necessary with +# makeinfo versions =E2=89=A5 6.8. +MAKEINFO =3D @MAKEINFO@ -c CHECK_NORMAL_MENU_STRUCTURE=3D1 + info_TEXINFOS =3D grep.texi grep_TEXINFOS =3D fdl.texi =20 =2D-=20 2.34.1 --nextPart11139438.5OynTdThKG-- From unknown Tue Jun 24 22:40:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Bruno Haible Subject: bug#64235: closed (Re: bug#64235: patch: Ensure that makeinfo =?UTF-8?Q?=E2=89=A5?= 6.8 checks the @menu structure) Message-ID: References: <5087752.22IY78Rhhi@nimes> X-Gnu-PR-Message: they-closed 64235 X-Gnu-PR-Package: grep Reply-To: 64235@debbugs.gnu.org Date: Sun, 25 Jun 2023 01:47:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1687657622-31541-1" This is a multi-part message in MIME format... ------------=_1687657622-31541-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64235: patch: Ensure that makeinfo =E2=89=A5 6.8 checks the @menu structure which was filed against the grep package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64235@debbugs.gnu.org. --=20 64235: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64235 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1687657622-31541-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64235-done) by debbugs.gnu.org; 25 Jun 2023 01:46:06 +0000 Received: from localhost ([127.0.0.1]:41761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDEpJ-0008BX-Jy for submit@debbugs.gnu.org; Sat, 24 Jun 2023 21:46:05 -0400 Received: from mail-lf1-f50.google.com ([209.85.167.50]:58481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDEpH-0008An-AZ for 64235-done@debbugs.gnu.org; Sat, 24 Jun 2023 21:46:04 -0400 Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-4f87592ecaeso2733799e87.0 for <64235-done@debbugs.gnu.org>; Sat, 24 Jun 2023 18:46:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687657557; x=1690249557; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ej0vlKLOlmrUmEoeTjvFcwFmFDVlP8/iHZZs3NsMMYg=; b=kxEmINf+VsvFwDTwAgBSnXh5fNjPmzxxcInxb7DJrftc/XrIzD8fxzh3yjxMfn7F+f A49J7JtPAn8vuHfxJNm0SgWQiuVgyBVFgVlYdkG57hiWFuFj/hqvaLhKsHB8G38JesG/ dkeAz+q14zeqZhJauM4JKoXAidVzt4qLfvs5+z6rmFVNAHOAlE0FulxK8GtHVi/6Xqen xse8ec2iKKPzm2oI5uUoR4GM31J07/5AYMUhLcpkAaz/lxbt9MIJfw0b3L5CgtuYsitN YZu5nUD1qDkgrwxj6SMH/+Yp4MSbqMtLKha64IRylOu0TdDgrMZTsHZObi2WMp1zSipL YTWQ== X-Gm-Message-State: AC+VfDwM8wA2rrr6OGjzmBtpZ2jy65+LJYbhK76ImCBb/ZW5MPcKsdDK VMkOjxG6trgI7vswRVo2XU/n2b72ns7yvTjyZvA= X-Google-Smtp-Source: ACHHUZ626zwRC2GyLEatWhPLKmXkjeddgincPjOP09EeUQxuG7k2cxhbWFkbko59XpirgblhjYRcseJELGrB4Z/pXgc= X-Received: by 2002:a2e:8e98:0:b0:2b6:9aeb:7ae2 with SMTP id z24-20020a2e8e98000000b002b69aeb7ae2mr484478ljk.33.1687657557282; Sat, 24 Jun 2023 18:45:57 -0700 (PDT) MIME-Version: 1.0 References: <5087752.22IY78Rhhi@nimes> In-Reply-To: <5087752.22IY78Rhhi@nimes> From: Jim Meyering Date: Sat, 24 Jun 2023 18:45:43 -0700 Message-ID: Subject: =?UTF-8?Q?Re=3A_bug=2364235=3A_patch=3A_Ensure_that_makeinfo_=E2=89=A5_6=2E8_c?= =?UTF-8?Q?hecks_the_=40menu_structure?= To: Bruno Haible Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 64235-done Cc: 64235-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Thu, Jun 22, 2023 at 4:28=E2=80=AFPM Bruno Haible wrot= e: > Makeinfo versions < 6.7 detected mistakes in the @menu structure of TeXin= fo > input. Makeinfo versions =E2=89=A5 6.8 don't do this any more by default.= They need > an extra option, for this validation to happen. See > . > > Since doc/grep.texi has a hand-written @menu, it should use this extra > option. > > Here's a patch to that effect. > > There are two possibilities for adding the extra option: > - in the MAKEINFO variable, where it has an effect on both "makeinfo" > and "makeinfo --html", > - in the AM_MAKEINFOFLAGS variable, where it has an effect on "makeinfo= " > only. > Since some maintainers may check their documentation edits only by regene= rating > the HTML-formatted documentation, the first choice is preferrable. > > Tested by running > touch doc/grep.texi ; (cd doc && make grep.info V=3D1) > and > make sc_makefile_at_at_check Thank you. Pushed. ------------=_1687657622-31541-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Jun 2023 22:51:42 +0000 Received: from localhost ([127.0.0.1]:36952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCT9R-0002ua-Gu for submit@debbugs.gnu.org; Thu, 22 Jun 2023 18:51:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:48686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCT9P-0002uQ-Jd for submit@debbugs.gnu.org; Thu, 22 Jun 2023 18:51:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCT9P-0001sw-AE for bug-grep@gnu.org; Thu, 22 Jun 2023 18:51:39 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCT9M-0001mp-UR for bug-grep@gnu.org; Thu, 22 Jun 2023 18:51:39 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1687474293; cv=none; d=strato.com; s=strato-dkim-0002; b=mCaBjKl3AvPcxP1GnfDHG12mAvPemoUsENXtBq0207eeUMy3HDjKDG/0/IJopBbF1f 3LY/QEElGOviK4JvAuisKA270jeiTBqb3aX1V4JSgrXT+af8/C4dER0lJ/4xX0GEiUtd ucj5psAO0vae7nAk3HzpgPHAXQKrwXCgYlAE+0+Qq/KKalMIxTfN/fDpJ9DOJRpzww3S T+/jsbu5vUz1zfug5gO3AQTPIB7MiQRVkIZtor760KDiQAQ/C/LucO1RIxNJC5t4hMnO aAK1OoPMJdxMvCoa7qI4KFwRoLeborPBtd1IeHeAudPasrH98Gzi6+rvhqgydZUIM7h9 2S6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1687474293; s=strato-dkim-0002; d=strato.com; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=NwZbxsj0udF4t/P+O5zun6tguLEfBWyYWHPmVMCjpFg=; b=r0b75eRTy6xXrNVUNNa9Q+HbbVyX/SujY3s0eZVkOQDOVJRIvDPHqVM9gFqeLZ/yo0 wAB6RyWhQsm7dY6TQ7odn/hUZbNqYBal8KZPP/YhKypUh7TxyiJABwYXum0bsEojfbes Y/D1QMUKJOTbak3ZqXU7wWSc/0q6RG9irzGjQ73NzqT3soP6+wpKJYo3AeFr11Phg18V lxyxY6w0HnCg0U0CrCs9Cf50QeiU10j14mNTgxILe25PVI8W9Gv4eRtuUblnnZJDVdYk bMw9frJjoyo+3VpFm4YaXZheiuqsbR9iIZ9ZMboukxGCgR/PNP5UNaLtbS/WCI2ccM6g GC6w== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1687474293; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=NwZbxsj0udF4t/P+O5zun6tguLEfBWyYWHPmVMCjpFg=; b=UOu8QQGSIWNclwEp4KgJyLeR01dOsMTFViRoMUmimFP241fF3R+J4WdrDf2oMJcTue Ulr3z0UkLYj+OC/HPA0d53GmIlYOMB9yIYMjpVfIbT9tZ9hAkikQ4qzAou8jYs8OESlu HbpGN9KavfFSPzYusyb5ivLp2aJXRx/qTvRdOK5385Vya8syVh3A7AoRlQ9yMHV9OHJ1 fa44oKosS3o8iVW4+7fFNI88FzyHemFYOFr6zuFShWF3O1feCYIspqewHoSqUfLAg2QY if0OtgCCffiy8OdhfeUp5TGkobGkVRrmTE0fG7W8PCmocU2wfEWgt/ALq9ERCqE7e0qw fcYw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1687474293; s=strato-dkim-0003; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=NwZbxsj0udF4t/P+O5zun6tguLEfBWyYWHPmVMCjpFg=; b=F9AHk0+2yErW1EgQE87/G+rTjed+lMbB+WZA5fqE05uqebHDm2A/Mat3Wa3GJvYZ/K wgJBzSoNlQ5KNOuoY/CA== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOe3vKnz4NASJkKNkZR9T7ssjto" Received: from nimes.localnet by smtp.strato.de (RZmta 49.6.0 AUTH) with ESMTPSA id 6b0accz5MMpXUBo (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 23 Jun 2023 00:51:33 +0200 (CEST) From: Bruno Haible To: bug-grep@gnu.org Subject: patch: Ensure that makeinfo =?UTF-8?B?4oml?= 6.8 checks the @menu structure Date: Fri, 23 Jun 2023 00:51:33 +0200 Message-ID: <5087752.22IY78Rhhi@nimes> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart11139438.5OynTdThKG" Content-Transfer-Encoding: 7Bit Received-SPF: none client-ip=81.169.146.221; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --nextPart11139438.5OynTdThKG Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Makeinfo versions < 6.7 detected mistakes in the @menu structure of TeXinfo input. Makeinfo versions =E2=89=A5 6.8 don't do this any more by default. T= hey need an extra option, for this validation to happen. See . Since doc/grep.texi has a hand-written @menu, it should use this extra option. Here's a patch to that effect. There are two possibilities for adding the extra option: - in the MAKEINFO variable, where it has an effect on both "makeinfo" and "makeinfo --html", - in the AM_MAKEINFOFLAGS variable, where it has an effect on "makeinfo" only. Since some maintainers may check their documentation edits only by regenera= ting the HTML-formatted documentation, the first choice is preferrable. Tested by running touch doc/grep.texi ; (cd doc && make grep.info V=3D1) and make sc_makefile_at_at_check --nextPart11139438.5OynTdThKG Content-Disposition: attachment; filename="0001-build-Ensure-that-makeinfo-6.8-checks-the-menu-struc.patch" Content-Transfer-Encoding: quoted-printable Content-Type: text/x-patch; charset="UTF-8"; name="0001-build-Ensure-that-makeinfo-6.8-checks-the-menu-struc.patch" =46rom 394ad4fb9b1c9f565e3f07b187950be13758df7a Mon Sep 17 00:00:00 2001 =46rom: Bruno Haible Date: Fri, 23 Jun 2023 00:48:13 +0200 Subject: [PATCH] =3D?UTF-8?q?build:=3D20Ensure=3D20that=3D20makeinfo=3D20= =3DE2=3D89=3DA5?=3D =3D?UTF-8?q?=3D206.8=3D20checks=3D20the=3D20@menu=3D20structure.?=3D MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit See . * doc/Makefile.am (MAKEINFO): New variable. * cfg.mk (_makefile_at_at_check_exceptions): New variable. =2D-- cfg.mk | 3 +++ doc/Makefile.am | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/cfg.mk b/cfg.mk index 1000d4f..8eec613 100644 =2D-- a/cfg.mk +++ b/cfg.mk @@ -45,6 +45,9 @@ announcement_Cc_ =3D $(translation_project_), $(PACKAGE)-= devel@gnu.org _gl_TS_unmarked_extern_functions =3D \ main usage mb_clen to_uchar dfaerror dfawarn imbrlen =20 +# Add an exemption for sc_makefile_at_at_check. +_makefile_at_at_check_exceptions =3D ' && !/MAKEINFO/' + # Now that we have better tests, make this the default. export VERBOSE =3D yes =20 diff --git a/doc/Makefile.am b/doc/Makefile.am index 4237af6..4bc2476 100644 =2D-- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -16,6 +16,10 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . =20 +# The customization variable CHECK_NORMAL_MENU_STRUCTURE is necessary with +# makeinfo versions =E2=89=A5 6.8. +MAKEINFO =3D @MAKEINFO@ -c CHECK_NORMAL_MENU_STRUCTURE=3D1 + info_TEXINFOS =3D grep.texi grep_TEXINFOS =3D fdl.texi =20 =2D-=20 2.34.1 --nextPart11139438.5OynTdThKG-- ------------=_1687657622-31541-1-- From unknown Tue Jun 24 22:40:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64235: patch: Ensure that makeinfo =?UTF-8?Q?=E2=89=A5?= 6.8 checks the @menu structure Resent-From: arnold@skeeve.com Original-Sender: "Debbugs-submit" Resent-CC: bug-grep@gnu.org Resent-Date: Sun, 25 Jun 2023 06:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64235 X-GNU-PR-Package: grep X-GNU-PR-Keywords: To: jim@meyering.net, bruno@clisp.org Cc: 64235-done@debbugs.gnu.org Received: via spool by 64235-done@debbugs.gnu.org id=D64235.16876740226439 (code D ref 64235); Sun, 25 Jun 2023 06:21:02 +0000 Received: (at 64235-done) by debbugs.gnu.org; 25 Jun 2023 06:20:22 +0000 Received: from localhost ([127.0.0.1]:41939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDJ6j-0001fl-QA for submit@debbugs.gnu.org; Sun, 25 Jun 2023 02:20:22 -0400 Received: from frenzy.freefriends.org ([198.99.81.75]:59062 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDJ6h-0001fa-Er for 64235-done@debbugs.gnu.org; Sun, 25 Jun 2023 02:20:20 -0400 X-Envelope-From: arnold@skeeve.com Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.14.7/8.14.7) with ESMTP id 35P6KDVZ009207 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 25 Jun 2023 00:20:13 -0600 Received: (from arnold@localhost) by freefriends.org (8.14.7/8.14.7/Submit) id 35P6KCAe009205; Sun, 25 Jun 2023 00:20:12 -0600 From: arnold@skeeve.com Message-Id: <202306250620.35P6KCAe009205@freefriends.org> X-Authentication-Warning: frenzy.freefriends.org: arnold set sender to arnold@skeeve.com using -f Date: Sun, 25 Jun 2023 00:20:12 -0600 References: <5087752.22IY78Rhhi@nimes> In-Reply-To: User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Thanks also from me, I have made a similar change for gawk. Arnold Jim Meyering wrote: > On Thu, Jun 22, 2023 at 4:28 PM Bruno Haible wrote: > > Makeinfo versions < 6.7 detected mistakes in the @menu structure of TeXinfo > > input. Makeinfo versions ≥ 6.8 don't do this any more by default. They need > > an extra option, for this validation to happen. See > > . > > > > Since doc/grep.texi has a hand-written @menu, it should use this extra > > option. > > > > Here's a patch to that effect. > > > > There are two possibilities for adding the extra option: > > - in the MAKEINFO variable, where it has an effect on both "makeinfo" > > and "makeinfo --html", > > - in the AM_MAKEINFOFLAGS variable, where it has an effect on "makeinfo" > > only. > > Since some maintainers may check their documentation edits only by regenerating > > the HTML-formatted documentation, the first choice is preferrable. > > > > Tested by running > > touch doc/grep.texi ; (cd doc && make grep.info V=1) > > and > > make sc_makefile_at_at_check > > Thank you. Pushed. > > >