From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 22 15:56:34 2023 Received: (at submit) by debbugs.gnu.org; 22 Jun 2023 19:56:34 +0000 Received: from localhost ([127.0.0.1]:36831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCQPy-0006iW-1b for submit@debbugs.gnu.org; Thu, 22 Jun 2023 15:56:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:46024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCQPv-0006iL-GN for submit@debbugs.gnu.org; Thu, 22 Jun 2023 15:56:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCQPt-00013l-GU for bug-gnu-emacs@gnu.org; Thu, 22 Jun 2023 15:56:30 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCQPp-0007ys-NB for bug-gnu-emacs@gnu.org; Thu, 22 Jun 2023 15:56:28 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A04605C019B for ; Thu, 22 Jun 2023 15:56:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 22 Jun 2023 15:56:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owlfolio.org; h= cc:content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to; s=fm1; t=1687463779; x=1687550179; bh=sb ZTjoYsB+s72wSHwJUPLQeIDvOKgNcuRssyGhtr3Jk=; b=UPcQ2Kx8FLF8iQGAPd SQlruq3QgLAW5wrIXqYxWTfQgu8MfEqxIJL904+It2b1T8f3JirUinQ63JJ/TReS ExwgDSplxch8W5+r83bf5v0VmXeAN1Md1zjv+PPBkdFf0rZJAHNcpJUxkAiEqGYY HykRM2UDQ+CVZWiJqiK3R67i/k7uOlWGeNL+5dJAG6AqpfN4Vghd8d0863Bf0U4x gusDEoKDXXz0/AVIFq/tDgzx7K3npHcbj4+SczvIDvDeeSsCRDYTuzeKCF8Xt+Z5 tTdBra0ROFGwTHjdtg98NPmPKe5pICb5OqjGADOwkqmIF7subcUyTphD9qsmj6+u BxVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1687463779; x=1687550179; bh=sbZTjoYsB+s72 wSHwJUPLQeIDvOKgNcuRssyGhtr3Jk=; b=peG2IBGMUx2Mj1QwwJLFTwY5/PriP cDhCrtt68IrO3vmp9C3jsrdODp2+3An7jJ3N2+EeZMAG52Fk4kLz+2jLR2mRt3in AckmVi401R82HJu9odCRDL+cmj8effe8k3Jp/N1v2HiiYUTET3Dc7dIJMUzuQLeI WM3izhinra4BqkfM6y/6QCgS5KrrJ2QlQD5uGjXCAiRYYip9ZxJPDr2F+KQJhfDb tZeMNfAvvpl0AyEbm1VOpUwth3R89U9fVzWvj/lvXtyN9unkifudOqIRW08t+17F FiXxSxl4BmVHH0aHZlWKN8lKOxR1lbJz+DmoKF2GUS30XJFoDgabx8DcQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeeguddgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffkhffvufgfgggtgfesthhqre dttderuhenucfhrhhomhepkggrtghkucghvghinhgsvghrghcuoeiirggtkhesohiflhhf ohhlihhordhorhhgqeenucggtffrrghtthgvrhhnpeffudeljedtkeehhfevieeujeeige eftefhtddujeeluefhffdvfefhfeeuvddvvdenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpeiirggtkhesohiflhhfohhlihhordhorhhg X-ME-Proxy: Feedback-ID: i876146a2:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 22 Jun 2023 15:56:19 -0400 (EDT) Date: Thu, 22 Jun 2023 15:56:18 -0400 Message-ID: <874jmzs23h.wl-zack@owlfolio.org> From: Zack Weinberg To: bug-gnu-emacs@gnu.org Subject: 28.2; Incorrect(?) byte compilation warning about =?ISO-8859-7?Q?=A1ansi-color-apply-on-region=A2?= User-Agent: Wanderlust/2.15.9 (Almost Unreal) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=66.111.4.25; envelope-from=zack@owlfolio.org; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) With Emacs 28.2, this test .el file ``` ;; -*- lexical-binding: t; coding: utf-8 -*- (declare-function ansi-color-apply-on-region "ansi-color" (begin end &optional preserve-sequences)) (autoload 'ansi-color-apply-on-region "ansi-color") (eval-when-compile (check-declare-file byte-compile-current-file)) (defun zw-colorize-compilation-buffer () "Interpret ANSI color escapes in a compilation-mode buffer, which gets them out of the way of the error detector. Intended for use via compilation-filter-hook." (interactive) (let ((inhibit-read-only t)) (ansi-color-apply-on-region (point-min) (point-max)))) ``` provokes a byte compilation warning: ``` $ emacs -Q --batch -f batch-byte-compile test.el uncompressing ansi-color.el.gz... uncompressing ansi-color.el.gz...done In end of data: test.el:16:6: Warning: the function =A1ansi-color-apply-on-region=A2 might = not be defined at runtime. ``` The combination of `declare-function` and `autoload` is intended to ensure both that the byte compiler understands what=A2s going on, and that `ansi-color-apply-on-region` really is guaranteed to be available at runtime. Also, I triple-checked that ansi-color.el really does define this function. Why is the compiler still complaining? Analogous constructs work as expected for other functions that might not yet be loaded when their caller is evaluated, e.g. this very similar test file ``` ;; -*- lexical-binding: t; coding: utf-8 -*- (declare-function dired-get-marked-files "dired" (&optional localp arg filter distinguish-one-marked error= )) (autoload 'dired-get-marked-files "dired") (eval-when-compile (check-declare-file byte-compile-current-file)) (defun zw-dired-find-marked-files (&optional arg) "Open each of the marked files, or the file under the point, or with prefix arg, the next N files." (interactive "P") (mapc 'find-file (dired-get-marked-files nil arg))) ``` byte compiles without complaint. zw --- In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cair= o version 1.16.0) Windowing system distributor 'The X.Org Foundation', version 11.0.12101007 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure CONFIG_SHELL=3D/gnu/store/rib9g2ig1xf3kclyl076w28parmncg4k-bash-minimal-5.= 1.16/bin/bash SHELL=3D/gnu/store/rib9g2ig1xf3kclyl076w28parmncg4k-bash-minimal-5.1.16/bi= n/bash --prefix=3D/gnu/store/gvbp7lp6yl3gsmz89kwajds2mh5179r5-emacs-28.2 --enable-fast-install --with-modules --with-cairo --with-native-compilation --disable-build-details' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $EMACSLOADPATH: /home/zack/.guix-profile/share/emacs/site-lisp:/= gnu/store/gvbp7lp6yl3gsmz89kwajds2mh5179r5-emacs-28.2/share/emacs/28.2/lisp value of $LC_COLLATE: C value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: envrc-global-mode: t envrc-mode: t doom-modeline-mode: t selectrum-prescient-mode: t prescient-persist-mode: t editorconfig-mode: t override-global-mode: t typo-global-mode: t global-whitespace-mode: t global-auto-revert-mode: t selectrum-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/zack/.config/emacs/elpa/transient-20230602.2121/transient hides /gnu/= store/gvbp7lp6yl3gsmz89kwajds2mh5179r5-emacs-28.2/share/emacs/28.2/lisp/tra= nsient /home/zack/.config/emacs/elpa/jsonrpc-1.0.17/jsonrpc hides /gnu/store/gvbp7= lp6yl3gsmz89kwajds2mh5179r5-emacs-28.2/share/emacs/28.2/lisp/jsonrpc /home/zack/.config/emacs/elpa/xref-1.6.3/xref hides /gnu/store/gvbp7lp6yl3g= smz89kwajds2mh5179r5-emacs-28.2/share/emacs/28.2/lisp/progmodes/xref /home/zack/.config/emacs/elpa/project-0.9.8/project hides /gnu/store/gvbp7l= p6yl3gsmz89kwajds2mh5179r5-emacs-28.2/share/emacs/28.2/lisp/progmodes/proje= ct /home/zack/.config/emacs/elpa/flim-20230205.1423/sasl hides /gnu/store/gvbp= 7lp6yl3gsmz89kwajds2mh5179r5-emacs-28.2/share/emacs/28.2/lisp/net/sasl /home/zack/.config/emacs/elpa/eldoc-1.14.0/eldoc hides /gnu/store/gvbp7lp6y= l3gsmz89kwajds2mh5179r5-emacs-28.2/share/emacs/28.2/lisp/emacs-lisp/eldoc Features: (shadow flyspell ispell modb-legacy modb-standard elmo-passwd gnutls network-stream nsm utf-7 elmo-imap4 time-stamp zw-wl-customization wl-fldmgr wl-template wl-demo wl-thread wl-action wl wl-draft wl-folder elmo-nntp elmo-filter wl-summary wl-refile wl-message wl-mime mime-play filename wl-e21 wl-highlight elmo-mime mmelmo-buffer mmelmo-imap mmimap mmbuffer mmgeneric wl-address wl-util pp wl-vars wl-version elmo-net elmo-cache elmo-map elmo-dop modb-generic elmo-flag elmo-localdir elmo elmo-signal elmo-msgdb modb modb-entity elmo-date elmo-util elmo-vars elmo-version mime-edit mime-image mime-view mime-conf calist invisible inv-23 mime-setup mail-mime-setup semi-setup advice semi-def mime-parse mime luna eword-encode eword-decode mel path-util pces pces-e20 pces-20 mime-def alist mcs-e20 mcs-20 wid-edit mcharset std11 pccl pccl-20 broken static apel-ver product timezone emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils face-remap pulse envrc inheritenv ansi-color server all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core shrink-path f f-shortdoc shortdoc text-property-search s dash nerd-icons nerd-icons-faces nerd-icons-data nerd-icons-data-mdicon nerd-icons-data-flicon nerd-icons-data-codicon nerd-icons-data-devicon nerd-icons-data-sucicon nerd-icons-data-wicon nerd-icons-data-faicon nerd-icons-data-powerline nerd-icons-data-octicon nerd-icons-data-pomicon nerd-icons-data-ipsicon compat compat-29 edmacro kmacro selectrum-prescient selectrum minibuf-eldef crm prescient char-fold comp comp-cstr warnings editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch pcase solarized-light-theme solarized-palettes solarized solarized-faces color zw-functions use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars cl-extra help-mode typo whitespace autorevert filenotify cl-loaddefs cl-lib cus-load guix-emacs seq byte-opt gv bytecomp byte-compile cconv info rx iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 326012 10065) (symbols 48 22124 7) (strings 32 100305 5994) (string-bytes 1 2514246) (vectors 16 38478) (vector-slots 8 876336 24689) (floats 8 741 311) (intervals 56 365 0) (buffers 992 10)) From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 07:49:41 2023 Received: (at 64232) by debbugs.gnu.org; 24 Jun 2023 11:49:42 +0000 Received: from localhost ([127.0.0.1]:40003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD1lt-0005bX-G7 for submit@debbugs.gnu.org; Sat, 24 Jun 2023 07:49:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD1lo-0005bI-45 for 64232@debbugs.gnu.org; Sat, 24 Jun 2023 07:49:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD1li-0000sJ-Cz; Sat, 24 Jun 2023 07:49:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=1ebS8DPg/9Yi46zS3eH9Tt6IOWo4hQe23oJb5UTWvC0=; b=ClfxdcJY8T+mWvvabILk gdsZbdgR56IiUk5/TiIQKf+K9dBD0M41hDN1w5rfsygc9CUAvno9gmn2OXCI8lBmRipf/36n2Iwn2 S8QTO/CaDz2A/XbygronYaKm4KGl7isYlF72UCk48+MKsOB6vjpN2b0K6cV7sTX+fhfNOAxDHBHgp Hvieju2okCpU47P8hIQ9hbaUHkOd2vovxSiKCr2jnMUFajrispkpsF8V5wJCSAseHXimRcqmZFSC5 GvH/3flG+62DklVLBuUuGrB52UGPFeNXOhWh+koUTAEvKZXbrcQajYKubwIDy8S4PlNvezJYjUXGT jWYmobX/9usDBA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD1lg-0001a9-08; Sat, 24 Jun 2023 07:49:30 -0400 Date: Sat, 24 Jun 2023 14:49:43 +0300 Message-Id: <83o7l5yt9k.fsf@gnu.org> From: Eli Zaretskii To: Zack Weinberg , Stefan Monnier In-Reply-To: <874jmzs23h.wl-zack@owlfolio.org> (message from Zack Weinberg on Thu, 22 Jun 2023 15:56:18 -0400) Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?iso-8859-7?B?oWFuc2ktY29sb3ItYXBwbHktb24tcmVnaW9uog==?= References: <874jmzs23h.wl-zack@owlfolio.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-7 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64232 Cc: 64232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 22 Jun 2023 15:56:18 -0400 > From: Zack Weinberg > > > With Emacs 28.2, this test .el file > > ``` > ;; -*- lexical-binding: t; coding: utf-8 -*- > > (declare-function ansi-color-apply-on-region "ansi-color" > (begin end &optional preserve-sequences)) > (autoload 'ansi-color-apply-on-region "ansi-color") > > (eval-when-compile > (check-declare-file byte-compile-current-file)) > > (defun zw-colorize-compilation-buffer () > "Interpret ANSI color escapes in a compilation-mode buffer, which > gets them out of the way of the error detector. Intended for use via > compilation-filter-hook." > (interactive) > (let ((inhibit-read-only t)) > (ansi-color-apply-on-region (point-min) (point-max)))) > ``` > > provokes a byte compilation warning: > > ``` > $ emacs -Q --batch -f batch-byte-compile test.el > uncompressing ansi-color.el.gz... > uncompressing ansi-color.el.gz...done > > In end of data: > test.el:16:6: Warning: the function ”ansi-color-apply-on-region¢ might not be > defined at runtime. > ``` > > The combination of `declare-function` and `autoload` is intended to > ensure both that the byte compiler understands what¢s going on, and > that `ansi-color-apply-on-region` really is guaranteed to be available > at runtime. Also, I triple-checked that ansi-color.el really does > define this function. Why is the compiler still complaining? The problem is this part: (eval-when-compile (check-declare-file byte-compile-current-file)) Remove it, and the problem will go away. So there's actually no problem here with 'autoload' and 'declare-function'. I don't understand why you are calling check-declare-file, and moreover don't understand the argument you pass check-declare-file. check-declare-file is a command supposed to be used interactively to verify the 'declare' calls are valid in a given file; it shows the results, if any, as delayed-warnings. Can you explain why you do this in the eval-when-compile form? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 11:16:16 2023 Received: (at 64232) by debbugs.gnu.org; 24 Jun 2023 15:16:16 +0000 Received: from localhost ([127.0.0.1]:41318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD4zn-00085a-TC for submit@debbugs.gnu.org; Sat, 24 Jun 2023 11:16:16 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:55405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD4zi-00085F-Qw for 64232@debbugs.gnu.org; Sat, 24 Jun 2023 11:16:14 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 619715C00E4; Sat, 24 Jun 2023 11:16:05 -0400 (EDT) Received: from imap45 ([10.202.2.95]) by compute1.internal (MEProxy); Sat, 24 Jun 2023 11:16:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owlfolio.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1687619765; x=1687706165; bh=jUw8W/E5ZKTxIQRkRL8s1tyTfElBQNogCQV 4YwdS8E0=; b=Nt4lm6S9M9L4ZjMXYknIBLzkktcB6bO7b7+FhxvN6mJ9yz1WWe7 P7Cc2i3XpP65OCHRfSCL46mDsh/WUXiVJzUVkzCmDyR4ocO9oxYsbkMAp/gSlHtt IdpDE0RQIVkhqERMc6ZAsnOAM/yLOkC8VUOJrFmu/cv7oy7kH6bY8nGTcs9oMM0f k9DUlr3E90NRhpbynr6OEVkkgdzNcasxzKkMplVzShfCXikaXi6fkgPelwEljEhX 4VXcnsN1dJHrZUtPktlkFFXoBnxCvfbHKy0DIwrCIvB45yPGyikyKY9KZ9sOfZ3G c6HNqPEEO6TXoTk9rzMoE1vAploC7RLdfaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687619765; x=1687706165; bh=jUw8W/E5ZKTxIQRkRL8s1tyTfElBQNogCQV 4YwdS8E0=; b=fMBg6bpFKcmgWBXI7OG3OZWEsQMeNJTG4a/zQEDpmonmKuFOmI2 LVtoKw1Tob7pdVds2nq09P7pAHR0emqlenhlkkTP0Zh0btbmhwGaBmTJ7+zQTbnn xWYGQB70iG99U2z2O/HjcwUVbF67bcSdpNrjurxic6ZA1WbkNsHfFVUJ2f919rGR fRX5CqeR2ncxtmhqm9x0PD2HXTzSy4dp5qTrnaLnPVSFCuBkj89f5JWbFjL/RIZ1 WasdSmfFMD2kN/1MA87I2sy3MXHoAUuxu3B1MH6JDjnumzxOhHXR+XhauIxMNII4 ky15wpDk7YqFolxZElGRj+8CEpRrqelyB/w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeegjedgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdgk rggtkhcuhggvihhnsggvrhhgfdcuoeiirggtkhesohiflhhfohhlihhordhorhhgqeenuc ggtffrrghtthgvrhhnpeduueeigeehffekiefhtdehiedvueffteevtefhudfguedtueei tdetgfetieeiieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpeiirggtkhesohiflhhfohhlihhordhorhhg X-ME-Proxy: Feedback-ID: i876146a2:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id C641A272007A; Sat, 24 Jun 2023 11:16:04 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-499-gf27bbf33e2-fm-20230619.001-gf27bbf33 Mime-Version: 1.0 Message-Id: <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> In-Reply-To: <83o7l5yt9k.fsf@gnu.org> References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> Date: Sat, 24 Jun 2023 11:15:42 -0400 From: "Zack Weinberg" To: "Eli Zaretskii" , "Stefan Monnier" Subject: =?UTF-8?Q?Re:_bug#64232:_28.2; _Incorrect(=3F)_byte_compilation_warning_a?= =?UTF-8?Q?bout_=E2=80=98ansi-color-apply-on-region=E2=80=99?= Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64232 Cc: 64232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Jun 24, 2023, at 7:49 AM, Eli Zaretskii wrote: >> Date: Thu, 22 Jun 2023 15:56:18 -0400 From: Zack Weinberg >> The combination of `declare-function` and >> `autoload` is intended to ensure both that the byte compiler >> understands what=E2=80=99s going on, and that `ansi-color-apply-on-re= gion` >> really is guaranteed to be available at runtime. Also, I triple- >> checked that ansi-color.el really does define this function. Why is >> the compiler still complaining? > > The problem is this part: > > (eval-when-compile > (check-declare-file byte-compile-current-file)) > > I don't understand why you are calling check-declare-file, and > moreover don't understand the argument you pass check-declare-file. > check-declare-file is a command supposed to be used interactively to > verify the 'declare' calls are valid in a given file; it shows the > results, if any, as delayed-warnings. Can you explain why you do this > in the eval-when-compile form? Because I want the declarations to be checked every time this file is byte compiled?? Maybe it makes more sense if I say it like this: I've written manual autoload forms for a bunch of functions that I *expect* to be defined in various libraries. If the guts of Emacs change and some of these functions are now defined somewhere else, I want to be notified immediately when I regenerate the .elc files for the new Emacs, not later when I try to use the commands that depend on those autoloads. Pairing each autoload with a declare-function form would achieve that ... if the byte compiler could be bothered to validate the declare- function forms. It doesn't, but check-declare does. So I kludge an invocation of check-declare into the compilation. > Remove it, and the problem will go away. So there's actually no > problem here with 'autoload' and 'declare-function'. No, there is still a problem. Let me restate the actual bug I was trying to report, so you can see it more clearly. Save the following file as test.el. ``` (declare-function ansi-color-apply-on-region "ansi-color" (begin end &optional preserve-sequences)) (declare-function dired-get-marked-files "dired" (&optional localp arg filter distinguish-one-marked er= ror)) (eval-when-compile (check-declare-file byte-compile-current-file)) (defun colorize-buffer () (interactive) (ansi-color-apply-on-region (point-min) (point-max))) (defun find-marked-files () (interactive) (mapc 'find-file (dired-get-marked-files))) ``` If you visit this file in emacs -Q and then invoke check-declare-file on it interactively, check-declare-file generates no warnings, which is correct. However, if you invoke `emacs -Q --batch -f batch-byte-compile test.el` from the shell, you will get this output: ``` uncompressing ansi-color.el.gz... uncompressing ansi-color.el.gz...done uncompressing dired.el.gz... uncompressing dired.el.gz...done In end of data: test.el:13:4: Warning: the function =E2=80=98ansi-color-apply-on-region=E2= =80=99 might not be defined at runtime. ``` "The function =E2=80=98...=E2=80=99 might not be defined" is the phrase = used by byte-compile-warn-about-unresolved-functions. It's not a check-declare diagnostic. This *must* be some form of bug, because the behavior is inconsistent: it complains about ansi-color-apply-on-region but not about dired-get-ma= rked-files. zw From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 27 22:10:47 2023 Received: (at 64232) by debbugs.gnu.org; 28 Jun 2023 02:10:47 +0000 Received: from localhost ([127.0.0.1]:49761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEKdr-00034z-7K for submit@debbugs.gnu.org; Tue, 27 Jun 2023 22:10:47 -0400 Received: from mout.web.de ([212.227.15.4]:43829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEKdk-00034f-Ux for 64232@debbugs.gnu.org; Tue, 27 Jun 2023 22:10:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1687918229; x=1688523029; i=michael_heerdegen@web.de; bh=iStLkts7EcnwAsDncLMMTKOT4sHzweGBGP8HZ8uMMgA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=bEz3zYjOePc7NkeF70QOzUyInVExH9Odw0gkRQ9sDoo2npUNqxCVIiGOFxyyOy4rQtzbj3u fGjvHEjp0S2V1a1+KeW7o+u6B+3fI5XpWbJUB2kPPQg2UzXHIQ661ThdVstlSpYbuiol33TIA CTcXYArp6UpZjqdDgm/qO7v3sZCk9j40shqUuV8d9pHf8zDqkusg4AbhttUvavomvYnrLl9Ax ISK3AgY4PFx3XzN2EQfCijUjebKLNooX89tRhUhvz+rOgMNroKp+Ql/BajdLpB/2GBYoVDwuT Ar5e6Bs4QiPBfqXYEZPzEVoXfe99JqAAQGGdElSzdRsoezhfb9mw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([217.247.69.86]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MSqXS-1qdBal1la2-00UTHy; Wed, 28 Jun 2023 04:10:29 +0200 From: Michael Heerdegen To: Zack Weinberg Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?utf-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= In-Reply-To: <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> (Zack Weinberg's message of "Sat, 24 Jun 2023 11:15:42 -0400") References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> Date: Wed, 28 Jun 2023 04:10:27 +0200 Message-ID: <87jzvoe3qk.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:V8/3UvqfA3w2O681RXwpDWh7vFWvmGCpBXlWwpFb+U2LlJaxw/7 g2BHnUio+94kKAoGjUBaJ2XdQKyFCUtdvGQ4cmoXIbHXT1Q6meprG9p46DULebNferdyqcx rTZTXpDsWMVG2usJZ8jVxQhXuo+2l0MqGKPxJOOTGAWC5NmkuCFSg3rdn6oH9Bg5H+JcXz6 RjLn6HBRFhRZb6gkQW75g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:vK2iwM0sz2I=;hll0728+C0uswZyw7r2m1LGORg7 GwFPV6WbAwqJGhJSrVXnsBYhJRDySOxk1bkLdecEmigHWNtP58Ar+gTlgSbxkrMxyQK8pFKQy OJbyyWpZKyyalFa8iHDMRLed8K1urwghKRdde9cw660dQFkDvRPwlcJDSOU7xVT6ogs9Vxfne FruzTFvAlX+Rhf0WpbbhGBnJmht+Xs7NK0Acbj/6BhqH+WxEGhFahPIsdp2SKWYVICCOaCSj9 GBA9DHXK/cyb/dCVMepfYT9Y/PQYH2BwtrIHikk/0F4r6k76R2X7Baike9MCDXL9DFJ3yBvS8 rCAxPvmbf/f3uoaanRxARKiq8fc8pSvfYEScOcS1swGAJGm9wtqoEG9EqStxeMJ68rMJPXOCt U991PJ/4vaY5Ah3jdN8R4nmVq5Uh9/v/DfFEOsvnRP8uDsGz0c44ULzV6EvBjsFiRPX2NQgps XknsHPgM/mzQ1W+P2sIT0WY2Tplz8Sr7loUgaFfv4KSTqVyH2zV14HgFJ7BnRbbh56RPYjOb2 P01tIG7cQ3TfK2DO38HPFjPjrvVqkpOygHYLRdopu0TE3ev3Hp7XRWKZ0d43E+Vx39e+20zKH N+Vqa+E7gTK/cjEXNCj37iroR2R0RrV2oEoPcJDrfCzbym8XwyVQAIa9a6ex6KU4ewsZ1Xa5u BVdAFgzqgaFb5JlONHvGH61256I636SrcCAmaMb8yRzERSp+Y7XOcj0yK/zGTCXbuyO1xMPxX +8EoytNy0hu6HzWCPdVhGXHrvTt8lw8prAly9R+4sampiiUVbyD+vI6/StLJN0Nqcv86LHI41 Z8XHD1blptF+hsV5tdioSpiAd2ex3P1p/ZBAEz+u2cZf8Hd+pux9113x5jEWDtffUgtBRkFbG FdbJzaRVWeT7FdPaC7j2ovcyk19y3q3HW6xluvosBMNdO9CC4Y9RpP7lU4Gf39gmHPuSjc+tt E3jF4g== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64232 Cc: Eli Zaretskii , 64232@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Zack Weinberg" writes: > ``` > (declare-function ansi-color-apply-on-region "ansi-color" > (begin end &optional preserve-sequences)) > > (declare-function dired-get-marked-files "dired" > (&optional localp arg filter distinguish-one-marked err= or)) > > (eval-when-compile > (check-declare-file byte-compile-current-file)) > > (defun colorize-buffer () > (interactive) > (ansi-color-apply-on-region (point-min) (point-max))) > > (defun find-marked-files () > (interactive) > (mapc 'find-file (dired-get-marked-files))) > ``` > > If you visit this file in emacs -Q and then invoke check-declare-file on > it interactively, check-declare-file generates no warnings, which is > correct. However, if you invoke `emacs -Q --batch -f batch-byte-compile > test.el` from the shell, you will get this output: > > ``` > uncompressing ansi-color.el.gz... > uncompressing ansi-color.el.gz...done > uncompressing dired.el.gz... > uncompressing dired.el.gz...done > > In end of data: > test.el:13:4: Warning: the function =E2=80=98ansi-color-apply-on-region= =E2=80=99 might > not be > defined at runtime. > ``` > > "The function =E2=80=98...=E2=80=99 might not be defined" is the phrase u= sed by > byte-compile-warn-about-unresolved-functions. It's not a check-declare > diagnostic. Indeed - so we have an interference between byte compilation, `eval-when-compile' and `check-declare-file'. This seems to help and might (?) be a good thing to do anyway: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-WIP-Try-to-fix-Bug-64232.patch Content-Transfer-Encoding: quoted-printable =46rom e972af2cd4d27b42cad7cf697bcfa32127cb0591 Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Wed, 28 Jun 2023 04:02:44 +0200 Subject: [PATCH] WIP: Try to fix Bug#64232 =2D-- lisp/emacs-lisp/bytecomp.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 99202185d8d..f468e34bb42 100644 =2D-- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -554,7 +554,9 @@ byte-compile-initial-macro-environment (let ((byte-compile-unresolved-functions byte-compile-unresolved-functions= ) (byte-compile-new-defuns - byte-compile-new-defuns)) + byte-compile-new-defuns) + (byte-compile-noruntime-functions + byte-compile-noruntime-functions)= ) (setf result (byte-compile-eval (byte-run-strip-symbol-position= s =2D- 2.30.2 --=-=-= Content-Type: text/plain Would be nice if someone like Stefan or Mattias could tell whether this is an appropriate addition (independently from this obscure issue). Michael. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 28 09:41:41 2023 Received: (at 64232) by debbugs.gnu.org; 28 Jun 2023 13:41:42 +0000 Received: from localhost ([127.0.0.1]:50312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEVQT-0007M3-Iy for submit@debbugs.gnu.org; Wed, 28 Jun 2023 09:41:41 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEVQR-0007Lo-Pb for 64232@debbugs.gnu.org; Wed, 28 Jun 2023 09:41:40 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 75B8E80776; Wed, 28 Jun 2023 09:41:34 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 262B4805BA; Wed, 28 Jun 2023 09:41:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687959693; bh=DxJG3Zuyid9qHnWkHYnc34XPSFZEnlcfQPaidyXTwgQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pUe8BhAGaJvrfV6USogz5wowlVYVWtC7vVYl6Q9ZR6HkiQvkIylBCUTD07IRH8Ntf qNSQsHsK1FXgs9CbejwXM9IQfbQIjXcBzoRUEeck6eWu2N/qZNvvTZqNwbH3yJ522/ 10ZNMbErgbmoMpZL5QPM6KkJQNcVRmnyyZlcGGaOGM+jog0tJbEYs3HsTkkcUlJoOz Yx1K1THXN0endNs4JKAD/FW072JQVuoqRHC68jVcITpa1PMwgtudkfWE+cabbqhxjH 7bjgUgnl4r4rMKx0iHw7g5Za4H5Czvu2JTwRy2zvVxiVmnhzN/4HOk9K6GCBNpsUAQ NMkU3b+XdzuaA== Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F25CB120306; Wed, 28 Jun 2023 09:41:32 -0400 (EDT) From: Stefan Monnier To: Michael Heerdegen Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?utf-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= In-Reply-To: <87jzvoe3qk.fsf@web.de> (Michael Heerdegen's message of "Wed, 28 Jun 2023 04:10:27 +0200") Message-ID: References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> Date: Wed, 28 Jun 2023 09:41:32 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64232 Cc: Eli Zaretskii , Zack Weinberg , 64232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index 99202185d8d..f468e34bb42 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -554,7 +554,9 @@ byte-compile-initial-macro-environment > (let ((byte-compile-unresolved-functions > byte-compile-unresolved-functions) > (byte-compile-new-defuns > - byte-compile-new-defuns)) > + byte-compile-new-defuns) > + (byte-compile-noruntime-functions > + byte-compile-noruntime-functions)) > (setf result > (byte-compile-eval > (byte-run-strip-symbol-positions Hmm... this doesn't look right: one of the main purpose of `byte-compile-eval` is (beside calling `eval`) to populate `byte-compile-noruntime-functions`, so if you let-bind it around the call, it's like calling `eval` and we can just get rid of `byte-compile-noruntime-functions` altogether. The "natural" place to put the let-binding would be in `byte-compile-close-variables` (assuming it still fixes the bug). Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 28 23:43:40 2023 Received: (at submit) by debbugs.gnu.org; 29 Jun 2023 03:43:41 +0000 Received: from localhost ([127.0.0.1]:51930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEiZI-0006og-8q for submit@debbugs.gnu.org; Wed, 28 Jun 2023 23:43:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:34926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEiZD-0006oW-3M for submit@debbugs.gnu.org; Wed, 28 Jun 2023 23:43:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEiZC-000187-Sj for bug-gnu-emacs@gnu.org; Wed, 28 Jun 2023 23:43:34 -0400 Received: from mout.web.de ([212.227.17.11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEiZB-0001zf-4q; Wed, 28 Jun 2023 23:43:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1688010195; x=1688614995; i=michael_heerdegen@web.de; bh=4AtcxjBwZismi8EDOmvPWvii+QztFuHO/bCyl1ZcHKc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=XZR5Z9MK1HpwU5Gl/9UbRkYIUiTy8/78tBWaUM/9XuNCG1J/PtySS+CGiuyz8i3Kv+7Nu4P 7sYt4NiQ6uaGagPl2L+iCOLduAOjROUNgVT7kWIOimmPk4QaOcXXk/mSCuQ9ZQBapcrAQO+NH fzDmeLXlJNfjios/S4zhpWkr8jfmDmwV723UAVwti5vS4YdfvOHRWXa4UNh1Z+N3OuC6Y6BZw 9Zy/eKjLosWg2dwqTVikL8HDOFlujq6vfuWUYwN1c8wUWYrB4u8TzOOnj07PSMPgMiIdGV+5Y hb9aDq7YMQ2mAMSuoqaXsDk/FWpWscQ0GORcvB5UDkSSIlleufMw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([217.247.69.86]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N8Vop-1q1XAQ2Rpx-0143Vg; Thu, 29 Jun 2023 05:43:15 +0200 From: Michael Heerdegen To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?utf-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= In-Reply-To: (Stefan Monnier via's message of "Wed, 28 Jun 2023 09:41:32 -0400") References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> Date: Thu, 29 Jun 2023 05:43:13 +0200 Message-ID: <87wmznhr1q.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:tH2G9K7S6rt61bluau//YEFl7Wv4Bj4CdkQ+rb0D8Rzs1jdydIv J7H8Uo16L6jfKQ2EU5zMDY/Tq8mRLK6D/Mg2P2dMrqv6bDPzk221fEdL4o4qmxpq3A6QRPo Xf5uHAyOaGN7wm/43tWBh82LU+tNFlWDTj3m1SZcX2TEWOaEfAY2CDRhPQ7XpN1Si+z1Bfc TutHP6fc3Qs4DGANA0s+w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:8H+gyDyF+R8=;DL2hsJ6xSoiGieW5TFyJOM54Vov o1Q+n+N0rvF5whEBNOBc1qfPji5MaPYGdlMqCOcloS0Z8741MmjagvSDieDmLxDsLRbn13q2+ kjBgdQeCZ+x3rEXijgzJTek+atgsXpkYHE8j5dM4fYGVsgK5RZHEYNao8T5BXhDMi/S1T/SOa cOcwfADNo4FuO4F2LTL8YutYk4/xCLdxgSEdp0R+1J/GARk/+eY7N8fr8B/LVOKAQZm8Fdq7+ xZZLfsHl4p6wWA/xJFr5pxD1sO3yWT0w3d3B8doOdxpFKxJCKfLtPBliWNdKC58jBq5pEyvsY J4meQKD9PCgz+eM34E527eB4mgM3JYXxo+VS34FcV099gorVcEXWb3FIRglzWCmrsmAZsCCkl e8xrSE1sGsRLXvHNMIcrOc7e0C5tkhA9yL4c5aXWWVDHuGt8+XwFx6+BGb76jBNpX8g+WFI7m FsVVfxU3STmyttqY9sFX/8eW3X5eWRgHN7aS7jjrA7RS3s4ZPGDcB1KNf3Bq3s9FvjfxvLvOr B9/3yxhZQogPKrahwt/yZXyUodtV6kpvLG+/ucO/zl/CO4Bj7BozxoDROWGff7MuSz4fp0QoR r/1f3dHYi9RGAyYBwGzPGJFtWGF5qERVw0Y4KeCF8Bx+shZ5IYDlE7tmuLhLWyzBSNtXex7pl utSAT+ErNsMSHGA6+CfOn4pjgPUagaYiGJA/7N+g0p/JbVvxmBaTul9ei05Nc1XbsCdmCEzxS VjRyYfX/nImNgUtFhLSg6d79K/nBHQo3RaAf5UN5jPbNfsxLsJc98IoxHS8rUCpXGVrVmee/3 hCe6D65wfPgd5kNiyeZZEZV7+jr1bNpaoZQcKOD5brjhlezJRNCMMd1GSajh0XDc+7cQQTFJd Wq48+UKwKWzIpnRnzlHjjf6Ikh7VVEuEbBIzx/Y9FnBksr+QjwXfU77tOJtvi0rvptjRsCV3L K8z7nw== Received-SPF: pass client-ip=212.227.17.11; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Eli Zaretskii , Zack Weinberg , 64232@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > > --- a/lisp/emacs-lisp/bytecomp.el > > +++ b/lisp/emacs-lisp/bytecomp.el > > @@ -554,7 +554,9 @@ byte-compile-initial-macro-environment > > (let ((byte-compile-unresolved-functions > > byte-compile-unresolved-functions) > > (byte-compile-new-defuns > > - byte-compile-new-defuns)) > > + byte-compile-new-defuns) > > + (byte-compile-noruntime-functions > > + byte-compile-noruntime-functions)) > > (setf result > > (byte-compile-eval > > (byte-run-strip-symbol-positions > > Hmm... this doesn't look right: one of the main purpose of > `byte-compile-eval` is (beside calling `eval`) to populate > `byte-compile-noruntime-functions`, so if you let-bind it around the > call, it's like calling `eval` and we can just get rid of > `byte-compile-noruntime-functions` altogether. Hmm - ok. > The "natural" place to put the let-binding would be in > `byte-compile-close-variables` (assuming it still fixes the bug). Seems it does not. Maybe we should try to understand what is happening first. Part of the problem is the dependency check-declare -> compile -> comint -> ansi-color so the compiler might think we are `requiring' ansi-color (which the compiled file uses) inside our `eval-when-compile' by purpose. The warning is the same as when one did just #+begin_src emacs-lisp (eval-when-compile (require 'ansi-color)) #+end_src When removing that `eval-when-compile' the warning message goes away. So the compiler warns stricter when something is required inside `eval-when-compile', even if there would be no warning at all without it. Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 29 00:17:57 2023 Received: (at 64232) by debbugs.gnu.org; 29 Jun 2023 04:17:57 +0000 Received: from localhost ([127.0.0.1]:51942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEj6T-0007nA-Ia for submit@debbugs.gnu.org; Thu, 29 Jun 2023 00:17:57 -0400 Received: from mout.web.de ([212.227.17.11]:38545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEj6Q-0007mu-5L for 64232@debbugs.gnu.org; Thu, 29 Jun 2023 00:17:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1688012265; x=1688617065; i=michael_heerdegen@web.de; bh=fyHvKVCiyYalgLA9OD9ACB4KV2Gk3EqsfyDw5onfMS8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=WS/Vv3KzWJp3m6XZmbIDmrqbI9qrb/kSEK6XbH2CGQ4DudAlTM5uJ14bkWver6TZibCaHpa gc0Tci6tacM7gVXDwmFgoFvmQq3heZa+3RpPcxm387Tjc5+0JBOEuUxbqQrsXwTRokK3p4Ct9 DgzEt0xS0oeGzEKDj1DmxRWrhTZIrNNf3ZEexKEqvJsx74JHajPNI30FBxIkvtBEqRuFFv+C9 nw48X/V9UQWViv0zxOAx5Lu4+NG9whSQeFoqOHkc21CMAcZOr5TbpYhquGgdNSqqqrCsxPp9Z 4HfJGHt2euybbnM6gkD0atbYn4nJcFMJS6B4GF69BwEv3oFf8sIQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([217.247.69.86]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MxHYA-1pql8K3fHk-00xgmh; Thu, 29 Jun 2023 06:17:44 +0200 From: Michael Heerdegen To: Zack Weinberg Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?utf-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= In-Reply-To: <874jmzs23h.wl-zack@owlfolio.org> (Zack Weinberg's message of "Thu, 22 Jun 2023 15:56:18 -0400") References: <874jmzs23h.wl-zack@owlfolio.org> Date: Thu, 29 Jun 2023 06:17:43 +0200 Message-ID: <87sfaaj40o.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:3+O3TXYQ4YMt6oMqzjgk/CyubHzgnKDzrFexMK/OIv7vrHVKddK YB+yIdq7EaHAWcjtqJc7tyPgUcnstzg/NVwy62+IhAKRdhPS5fKxClHKN3pxB7+Pt6BOzbb Hijxhz6l5nZj1wz5bz48+m5RCEW6yK6U0iODxJf7KOuhvMNseBglYe9lAfZDVHDi4GVyL5U kTYGSz+U6IZvj4k8b3NGg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:fuUGiTkdScU=;aroAay5bxPjY1Nhhd1LfKGdRZqD GFTG1WiLlj1xchCkPPpjQaT7kitKUSBF+M1UMMwUHEeiCGcNA5e87tThtOrRWDFo+V/TpRakZ TphKXQSKXezMRI3zaKa9QyYBbptJ7bIREe1dR7pW8odd16Xg7AfcCr7BO1NbOBXjP5+LzBVWT auaADvOUct8KcNu4viqG4iEWYZ3qO+0UeyTj544NHdzwtCD4qmC89sJOh1uWs7YfN3eWHEknI M4XFr2YQenwKmxCXLfLe2WM4f4SRcdrCWHa8Ns0jRn23Sx0EdHmMHieJqlMZvyP42xIcgdeyw ZIRZkcCtHlnRLA7GKDzP3INk5xVagvRLtxiS1ubyvs9ubneOtVIBp7pmtYKkMQe+HlhWlKO0s UzBLY0qS8NPoXe2nA7BuvPWzj+4LmsZ4lU3CkuTXzBRAxHeTWVtoUJifWlYYZAws8KW3PVpiY +0odyTILbd8uNZo1wSAm7FiMrVGsRRRa9vE6S06x+Yfisg29mnL1g0DPR8C/xf89uarpILwAe 2MEj3H8pdquJKn4IKDT5bhumhmKoZpk9lfl0+ldw6PZuuE1K+yfXX5JvrkWdhcDkvVVUE0AqA 6NhDXcxCFSlgkhneLpRMfH82AKsj13SonZN/mMKnpWYFm7QkNBhlO1K8wg8UhPxWLKpjMsfGs tZ5bmJf2Axyf8Td7Ytk6+PEWaFfpolMDjFgnHrJTLwKj9U8fUkvHakONPveIlj+6BEYcWJHVN oA6HNE8zcJgv0k32UgiPuxRswLta5s33xFJMZqsrex2Gcfk4i13pv9aLCyQD457oN6/RSKn2C vyrY3XGuK/irRtaBiZyfQD3jQySwMjjDZ5Bf5R051yCSEm++eyX9yQNfRTz+59PxRhgaSHtd1 yG4FpJuMpCCnJHqW02QBNWV5dAmxEjjGwyyIT1pfu0FBjwzqGUOdVPlqWEOlga/HJgDMYrNOM 3eKGh3F+PzaMnj2SWa0vEBHaW90= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64232 Cc: 64232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Zack Weinberg writes: > (eval-when-compile > (check-declare-file byte-compile-current-file)) BTW, I think a better alternative might be #+begin_src emacs-lisp (require 'cl-lib) (cl-eval-when (compile) (check-declare-file byte-compile-current-file)) #+end_src which behaves like you want and also doesn't break loading the source of your file like your version does. If you don't want to load cl-lib, I guess adding something like #+begin_src emacs-lisp (defmacro check-declarations () (check-declare-file byte-compile-current-file) t) (check-declarations) #+end_src could also work. Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 29 00:51:31 2023 Received: (at 64232) by debbugs.gnu.org; 29 Jun 2023 04:51:31 +0000 Received: from localhost ([127.0.0.1]:52009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEjcx-0002oo-DM for submit@debbugs.gnu.org; Thu, 29 Jun 2023 00:51:31 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEjct-0002oZ-4x for 64232@debbugs.gnu.org; Thu, 29 Jun 2023 00:51:30 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7B38E1000DA; Thu, 29 Jun 2023 00:51:21 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 35F42100097; Thu, 29 Jun 2023 00:51:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688014276; bh=7jx7VJ5NYPs0q0RNBBUiVPRIlTdIt5Je/38LqJqh/ic=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GrLeQLY00hF05V7L9P9qFo4lcCk6FGaMx7g0yUeyYgYXeLxRqOp+YJTC8N9tDxN1z 0RRPVYIWq3XBj+Bk/XsOSdtUJlU/fFkIB7JFzSl0pxUUxwFb1FXZhZgWjviDUbzQuN rZADaiTVN5kfJ9QxOX9DKX1HPIUZctQvLdBmXJDi4cWSPy2OIoKOSPe9o+DJOEgOq6 oiUJgfzugRYN6HazjnykUf8iRbb7CEK8P9pCZSQy2jmooS4YgL4nkNIdF458JrOEMV Rld+6p6U7QpmxLUdl3JrlqGFwIWmJPNe3Bs4uT+LOelmJDqIL7EVbImnkf1U89iBtI ubpfr2Q5srPXA== Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 059351203E4; Thu, 29 Jun 2023 00:51:15 -0400 (EDT) From: Stefan Monnier To: Michael Heerdegen Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?utf-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= In-Reply-To: <87wmznhr1q.fsf@web.de> (Michael Heerdegen's message of "Thu, 29 Jun 2023 05:43:13 +0200") Message-ID: References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> <87wmznhr1q.fsf@web.de> Date: Thu, 29 Jun 2023 00:51:08 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.243 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64232 Cc: eliz@gnu.org, zack@owlfolio.org, 64232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The warning is the same as when one did just > > #+begin_src emacs-lisp > (eval-when-compile > (require 'ansi-color)) > #+end_src > > When removing that `eval-when-compile' the warning message goes away. > So the compiler warns stricter when something is required inside > `eval-when-compile', even if there would be no warning at all without > it. Indeed, it's a vaguely known problem which we haven't tried to fix seriously. The usual workaround is to shuffle things around (e.g. move the (eval-when-compile (check-declare-file byte-compile-current-file)) earlier or later in the file) ... until the warnings disappear :-( Someone=E2=84=A2 should sit down and figure out how to make `bytecomp.el` k= eep track of those things more reliably/predictably. In the mean time, maybe we can simply tweak `byte-compile-eval` so it never adds to `byte-compile-noruntime-functions` functions which have already been seen/declared during the current compilation? Stefan diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 99202185d8d..cfec4b3be06 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -1128,7 +1128,8 @@ byte-compile-eval ;; we arguably should add it to b-c-noruntime-functions, ;; but it's not clear it's worth the trouble ;; trying to recognize that case. - (unless (get f 'function-history) + (unless (or (get f 'function-history) + (assq f byte-compile-function-environment= )) (push f byte-compile-noruntime-functions)))))))))))= )) =20 (defun byte-compile-eval-before-compile (form) From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 30 00:03:57 2023 Received: (at 64232) by debbugs.gnu.org; 30 Jun 2023 04:03:57 +0000 Received: from localhost ([127.0.0.1]:54342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qF5MT-0003Yj-9V for submit@debbugs.gnu.org; Fri, 30 Jun 2023 00:03:57 -0400 Received: from mout.web.de ([212.227.15.14]:33989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qF5MO-0003YK-Rt for 64232@debbugs.gnu.org; Fri, 30 Jun 2023 00:03:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1688097758; x=1688702558; i=michael_heerdegen@web.de; bh=SgA8xzqo//5SIchlYZg60oqSWrjg5esI9uRfB7o4gFc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=k6RDpgKPb95ERJ1MtEF8lJ7dU94d/9W5A0Dq3STkwy3txy8oIiT2SmOooMQUHzwMrUBm5Py mP101seGruKeu8Z+ppDP19dLLEI3uUj7F8LWjRpif7brs9mwcJoRhU2HAzwTzqGiPBT+et5IC reOYvTltyUNJ77Cr2FwfnnVdyosZNmvP9dr6kdo6Trr/lGGgz14tfg4HBqXB+wRibXlgenUQT KM7j4qrSWIAFAiWYpPb6K9oma75p9V9iyAG9Sc+KkrO+pUHPBbsNVLAjLsw1LddmC2eEIrUms p8Kq1KJ361YUJOC2TprmilUF5qFgIbZk7+FQNggnUzKQiLoAeaSg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([217.247.69.86]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MJnvp-1qUhJX1wpF-00K7nu; Fri, 30 Jun 2023 06:02:38 +0200 From: Michael Heerdegen To: Stefan Monnier Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?utf-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= In-Reply-To: (Stefan Monnier's message of "Thu, 29 Jun 2023 00:51:08 -0400") References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> <87wmznhr1q.fsf@web.de> Date: Fri, 30 Jun 2023 06:02:36 +0200 Message-ID: <875y751tsz.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:HOfpC9Iv3yPXY3HNaS3Ha1M9p2q9PxslfRoWWuxujX+e1mvVtHC 1UFI6ITAxWeumWz7UTg4LrRwV5R/z2xLXSSuLcJI8AEx4Mylg8uWm2YkicUOCnLsqUf42uD /cm4Zpl7VCsqK9J6Zrbx2V373OHKJHnJK1mSw7HDpweLTsE/GuWVY44twEDyjytGb0zpbAD KT1Tr7PH7peGsApOruDNg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:NkEn8VfAOJ8=;rBi67L7IgtuEQK954lCMPDWZwZw cKKqbSTi2+7rABRVH574nsJTNu36aM7nV7Jvfq86rYQzmnN9y0UTfyvEO8KzXYAKGvKzoB39r b4fSLoQRNmr7w7ZGkkljfofBi2/fNtjPSo3CS3II0C5KTHgCz6o7t9gC42TFMlF4+MlVTi40L 2+Z1kbPX5kxhbz0/2E8KMxJoEby7jiRx+ejtihuNtVS+sSGHg0EZ1bPH4KAsmGskjJFOOrFqj +y4YbMat3aNib4DTqU1TOS/dkgAfwVPh5GFKqKNn94oacgxoE34jYzVqaGs4NOwgnGEJrGybc zeVcXnJwsYv8nysrrtA+B5J97aD2oKXdomJCUgzME6tcrw6YnZ3pmR7LVZwth37RNuthqhgb5 admTi6WreEc2xipiVC3AL/q/wiwLQBNYVcV4m9ZBdo/LH2Tgl5m08juGnXwpqLqyrNOIOevxf E4yaEEjqpQCRW9Yv9gDVFVzIrUEwdm9sMiMN4gbBI7HzEqSh1iaE68dDnUGNpzGQaSUioqOTA eOcd3fxMQTvTheEW8MdISntkJk1J7lKSAkG/NF3Sw+i3tS4hW5TUl/NNJpFm7UTnClgSILssF KOg/ddj928zoH7YeGdhKt2dP+BO/FTcmDjlkAx1Q+pWW+/MRNJGKIHzlNo4qv1/lDRvyTQsAM ww/ajv3wowMsVI0PUvWIoPuaX4T6GiphWcQ1ctff239z1Q04paXth+22kZe6n3l7Fyw3OhP4N IfnV99P/MOLtfAKyYhpyljq9I6j3neyzdbmpLVx5VOpnK9lcDfd/WDhzzJRFoXCoUn3p0XoqD 6EHfCNrafn1NqjyZSDY7y18QxM/0sxYKYU0RxRFPsUJQQbe4/FAoPmOHNtlDxUF5PorVJ/0mN BgSmjSFjqw64brnR/YASm8VLYWxxZIBO5fvFlH2jo/O5KtDbsraxjDsl32B38GHSs1SXXCOWF V833M8Be6fbJPsDaPyiLxRGZgzI= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64232 Cc: eliz@gnu.org, zack@owlfolio.org, 64232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: > Someone=E2=84=A2 should sit down and figure out how to make `bytecomp.el`= keep > track of those things more reliably/predictably. > In the mean time, maybe we can simply tweak `byte-compile-eval` so it > never adds to `byte-compile-noruntime-functions` functions which have > already been seen/declared during the current compilation? > > > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index 99202185d8d..cfec4b3be06 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -1128,7 +1128,8 @@ byte-compile-eval > ;; we arguably should add it to b-c-noruntime-functions, > ;; but it's not clear it's worth the trouble > ;; trying to recognize that case. > - (unless (get f 'function-history) > + (unless (or (get f 'function-history) > + (assq f byte-compile-function-environme= nt)) > (push f byte-compile-noruntime-functions)))))))))= )))) Seems appropriate (and fixes this bug). Actually with that patch the situation looks already quite ok'ish to me. Thx, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 30 02:00:14 2023 Received: (at 64232) by debbugs.gnu.org; 30 Jun 2023 06:00:14 +0000 Received: from localhost ([127.0.0.1]:54379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qF7B0-0007FB-Fa for submit@debbugs.gnu.org; Fri, 30 Jun 2023 02:00:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qF7Aw-0007Ds-S6 for 64232@debbugs.gnu.org; Fri, 30 Jun 2023 02:00:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF7Aq-00061R-F2; Fri, 30 Jun 2023 02:00:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=txaziBQM/nIipVYDJHzMwsL4MtrYUL6iemhZRcKb0zM=; b=L0knh3TOcB2XBKztaQMG 4pI51CpGr48sWx+Suis5aRB7SdrRaIyXrSSAVkRqZdwVrK9TCFERpcRHCQpXDaDP3cDkuA01OZmAv scu0D2XrODCndVXhuudolNeIrjvP39NhaAV9ZGILbaG7VdIoMhBvWQ7o7VkacO7n6ghc2VwgHRB+z ZbBkx35SfbosS2B00ncgULxgoVCxilqfrYm15f4u78ffEsCDADLrxUmpsM8FSeyGu1URjQUmuPb9k BtAZdMY6CllHkyG4cdETSiBm1bs8/CNjzhnp3QLFXW7S0O9oLWWhxVNV1Nlhut1mO3IFYk1VtwDlZ UiHt2n9AAbhjaQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF7Ap-0005Yl-FK; Fri, 30 Jun 2023 02:00:03 -0400 Date: Fri, 30 Jun 2023 09:00:33 +0300 Message-Id: <83wmzlsd4u.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <875y751tsz.fsf@web.de> (message from Michael Heerdegen on Fri, 30 Jun 2023 06:02:36 +0200) Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?utf-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> <87wmznhr1q.fsf@web.de> <875y751tsz.fsf@web.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64232 Cc: zack@owlfolio.org, 64232@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Cc: 64232@debbugs.gnu.org, eliz@gnu.org, zack@owlfolio.org > Date: Fri, 30 Jun 2023 06:02:36 +0200 > > Stefan Monnier writes: > > > Someoneā„¢ should sit down and figure out how to make `bytecomp.el` keep > > track of those things more reliably/predictably. > > In the mean time, maybe we can simply tweak `byte-compile-eval` so it > > never adds to `byte-compile-noruntime-functions` functions which have > > already been seen/declared during the current compilation? > > > > > > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > > index 99202185d8d..cfec4b3be06 100644 > > --- a/lisp/emacs-lisp/bytecomp.el > > +++ b/lisp/emacs-lisp/bytecomp.el > > @@ -1128,7 +1128,8 @@ byte-compile-eval > > ;; we arguably should add it to b-c-noruntime-functions, > > ;; but it's not clear it's worth the trouble > > ;; trying to recognize that case. > > - (unless (get f 'function-history) > > + (unless (or (get f 'function-history) > > + (assq f byte-compile-function-environment)) > > (push f byte-compile-noruntime-functions))))))))))))) > > Seems appropriate (and fixes this bug). > > Actually with that patch the situation looks already quite ok'ish to me. Please install this on master, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 06 02:43:53 2023 Received: (at 64232) by debbugs.gnu.org; 6 Jul 2023 06:43:53 +0000 Received: from localhost ([127.0.0.1]:39371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHIiW-0002pc-TM for submit@debbugs.gnu.org; Thu, 06 Jul 2023 02:43:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHIiU-0002p4-Hg for 64232@debbugs.gnu.org; Thu, 06 Jul 2023 02:43:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHIiO-0004Fa-P6; Thu, 06 Jul 2023 02:43:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=L6+mwFQ2ajVXvYe+CMyz5F3Sau7fUOdg6xxM1fKXFlU=; b=Q1l2H4Pvgs2b/zLkhyxr +gtHSapZmfhrDYajoHVUzzlAzWB8M5G1AR0h0Gst/aMUHxymQ26gDFcCp+WYA72d+yEbT56Ev6DHP NzUI/bVEyWhqHxoKgGjO2IXzKhodr/6FV7B7sn2NQDlRPNQ2lCwAEzytEC8ydvn7DOGwKXxpxquCs c3kX6BtWrxz1sOBZxi/NixXSa/RSsmR847j9sZ/8/mxg3GAq0NAySEWCFQOqoOL4JshcIXBVh4pz2 rrCJCApClvQ+jJvdSuUJOJH7lQg5BbPInV96L2o4LJgaHEOJ+rXSV5S3bVJDyMBUZ5WGpn/QWXNzX aaBOW9SqVWjAqA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHIiN-0007dQ-Pf; Thu, 06 Jul 2023 02:43:44 -0400 Date: Thu, 06 Jul 2023 09:43:44 +0300 Message-Id: <83ttuhilpb.fsf@gnu.org> From: Eli Zaretskii To: michael_heerdegen@web.de, zack@owlfolio.org, monnier@iro.umontreal.ca In-Reply-To: <83wmzlsd4u.fsf@gnu.org> (message from Eli Zaretskii on Fri, 30 Jun 2023 09:00:33 +0300) Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?utf-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> <87wmznhr1q.fsf@web.de> <875y751tsz.fsf@web.de> <83wmzlsd4u.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64232 Cc: 64232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Any reasons this was not yet installed on master? > Cc: zack@owlfolio.org, 64232@debbugs.gnu.org, monnier@iro.umontreal.ca > Date: Fri, 30 Jun 2023 09:00:33 +0300 > From: Eli Zaretskii > > > From: Michael Heerdegen > > Cc: 64232@debbugs.gnu.org, eliz@gnu.org, zack@owlfolio.org > > Date: Fri, 30 Jun 2023 06:02:36 +0200 > > > > Stefan Monnier writes: > > > > > Someoneā„¢ should sit down and figure out how to make `bytecomp.el` keep > > > track of those things more reliably/predictably. > > > In the mean time, maybe we can simply tweak `byte-compile-eval` so it > > > never adds to `byte-compile-noruntime-functions` functions which have > > > already been seen/declared during the current compilation? > > > > > > > > > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > > > index 99202185d8d..cfec4b3be06 100644 > > > --- a/lisp/emacs-lisp/bytecomp.el > > > +++ b/lisp/emacs-lisp/bytecomp.el > > > @@ -1128,7 +1128,8 @@ byte-compile-eval > > > ;; we arguably should add it to b-c-noruntime-functions, > > > ;; but it's not clear it's worth the trouble > > > ;; trying to recognize that case. > > > - (unless (get f 'function-history) > > > + (unless (or (get f 'function-history) > > > + (assq f byte-compile-function-environment)) > > > (push f byte-compile-noruntime-functions))))))))))))) > > > > Seems appropriate (and fixes this bug). > > > > Actually with that patch the situation looks already quite ok'ish to me. > > Please install this on master, and thanks. > > > > From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 07 12:10:52 2023 Received: (at 64232-done) by debbugs.gnu.org; 7 Jul 2023 16:10:52 +0000 Received: from localhost ([127.0.0.1]:43663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHo2m-0002wV-9L for submit@debbugs.gnu.org; Fri, 07 Jul 2023 12:10:52 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHo2j-0002wG-4D for 64232-done@debbugs.gnu.org; Fri, 07 Jul 2023 12:10:50 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A7DF1802B3; Fri, 7 Jul 2023 12:10:43 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 59177805BA; Fri, 7 Jul 2023 12:10:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688746242; bh=YWHfkmcleS6uB6dQpW+KLS3ngBfxGohVJFWYzhQY+6A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Wa/rTeiv5WvToveHxZOKmqLa9Bn5WOKxpgSVwKht9kJ+dZFnokIX2RRoOL4mLRXhN czwsqiHUzpP8IkzyeyYd0MDaXl7wVeCy7nTcnCEyGwysRuMSRiXVQNv0ojpYw9lUJu ldsTiMUg+CITaX+muyMls749Q89RsEi+KZjBYO6L7HvPqsvX1zeeFaPqlT5Gcl6089 2v5NrLu9y+Eq1KS0QvCWGaUWfQwaOR975vOfjdyNt5JWgmslYrfPaZ48VQ4XxR79oy D++WkFWDf/2YV+BzENJaE1OVL5sZhZai2xslVL68m+bbv47CdtX2wiyNPwrr2asQRi jhmxIrcT5wJaA== Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2C1BE1202DB; Fri, 7 Jul 2023 12:10:42 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?utf-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= In-Reply-To: <83ttuhilpb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Jul 2023 09:43:44 +0300") Message-ID: References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> <87wmznhr1q.fsf@web.de> <875y751tsz.fsf@web.de> <83wmzlsd4u.fsf@gnu.org> <83ttuhilpb.fsf@gnu.org> Date: Fri, 07 Jul 2023 12:10:41 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64232-done Cc: michael_heerdegen@web.de, zack@owlfolio.org, 64232-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > > --- a/lisp/emacs-lisp/bytecomp.el >> > > +++ b/lisp/emacs-lisp/bytecomp.el >> > > @@ -1128,7 +1128,8 @@ byte-compile-eval >> > > ;; we arguably should add it to b-c-noruntime-functions, >> > > ;; but it's not clear it's worth the trouble >> > > ;; trying to recognize that case. >> > > - (unless (get f 'function-history) >> > > + (unless (or (get f 'function-history) >> > > + (assq f byte-compile-function-environment)) >> > > (push f byte-compile-noruntime-functions))))))))))))) >> > >> > Seems appropriate (and fixes this bug). >> > Actually with that patch the situation looks already quite ok'ish to me. >> Please install this on master, and thanks. > Ping! Any reasons this was not yet installed on master? Oops, sorry. Pushed, Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 07 14:15:46 2023 Received: (at 64232-done) by debbugs.gnu.org; 7 Jul 2023 18:15:46 +0000 Received: from localhost ([127.0.0.1]:43716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHpzd-0008A6-Ry for submit@debbugs.gnu.org; Fri, 07 Jul 2023 14:15:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHpza-0007qL-V0 for 64232-done@debbugs.gnu.org; Fri, 07 Jul 2023 14:15:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHpzV-0002Av-9G; Fri, 07 Jul 2023 14:15:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=mWiXBZnmNtGIKgpRaoyGKPhmHnDEgGtSP6QpJdlfirA=; b=Xoh+SPAYyaZkun8SJ10w lEXfG6HU620NmTBF/8CGRroAiyrmfRwcIrdF0eRP2HOljd7wfpgAwXOrMK7IiSoPSSLQbEX+Etm12 a5LynV6WowoasxrHyEkCaMiZVWoYa5onM1T/LIVCbA+3PoN9La3z3otiPgfDFEpqdapxjLXk2J5Yr CDn0EAGJWRc+TRNmgmauD0NVVx7seRtDeOpzmt2irpGAgNzIENUjzntkYDlkyeGVuoL2xzWmLvq4d ds+Rx3+Y2+rllgxHxIO6Ywu3wtGro/DSponhKuTpXYfKTQY7p47nLMLmp2vLeVmQ2RjukUis3ESY8 XxL7WnGCTUgXmg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHpzU-0005g5-5P; Fri, 07 Jul 2023 14:15:37 -0400 Date: Fri, 07 Jul 2023 21:15:39 +0300 Message-Id: <83wmzbegfo.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Fri, 07 Jul 2023 12:10:41 -0400) Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?utf-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> <87wmznhr1q.fsf@web.de> <875y751tsz.fsf@web.de> <83wmzlsd4u.fsf@gnu.org> <83ttuhilpb.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64232-done Cc: michael_heerdegen@web.de, zack@owlfolio.org, 64232-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: michael_heerdegen@web.de, zack@owlfolio.org, 64232-done@debbugs.gnu.org > Date: Fri, 07 Jul 2023 12:10:41 -0400 > > >> > > --- a/lisp/emacs-lisp/bytecomp.el > >> > > +++ b/lisp/emacs-lisp/bytecomp.el > >> > > @@ -1128,7 +1128,8 @@ byte-compile-eval > >> > > ;; we arguably should add it to b-c-noruntime-functions, > >> > > ;; but it's not clear it's worth the trouble > >> > > ;; trying to recognize that case. > >> > > - (unless (get f 'function-history) > >> > > + (unless (or (get f 'function-history) > >> > > + (assq f byte-compile-function-environment)) > >> > > (push f byte-compile-noruntime-functions))))))))))))) > >> > > >> > Seems appropriate (and fixes this bug). > >> > Actually with that patch the situation looks already quite ok'ish to me. > >> Please install this on master, and thanks. > > Ping! Any reasons this was not yet installed on master? > > Oops, sorry. Pushed, Thanks. From unknown Tue Jun 24 01:40:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 05 Aug 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator