GNU bug report logs - #64224
[PATCH] gnu: Add python-cloup.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64224 in the body.
You can then email your comments to 64224 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Meißner <daniel.meissner-i4k <at> rub.de>
To: guix-patches <at> gnu.org
Cc: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
Subject: [PATCH] gnu: Add python-cloup.
Date: Thu, 22 Jun 2023 13:36:05 +0200

From: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>

* gnu/packages/python-xyz.scm (python-cloup): New variable.
---
 gnu/packages/python-xyz.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index af9dd45d6e..151f608adf 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -106,7 +106,7 @@
 ;;; Copyright © 2021 Franck Pérignon <franck.perignon <at> univ-grenoble-alpes.fr>
 ;;; Copyright © 2021, 2022 Petr Hodina <phodina <at> protonmail.com>
 ;;; Copyright © 2021 Simon Streit <simon <at> netpanic.org>
-;;; Copyright © 2021 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
+;;; Copyright © 2021, 2022, 2023 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
 ;;; Copyright © 2021, 2022 Pradana Aumars <paumars <at> courrier.dev>
 ;;; Copyright © 2021, 2022 Felix Gruber <felgru <at> posteo.net>
 ;;; Copyright © 2021 Sébastien Lerique <sl <at> eauchat.org>
@@ -4578,6 +4578,28 @@ (define-public python-cligj
 well-tested and interoperable CLIs for handling GeoJSON.")
     (license license:bsd-3)))
 
+(define-public python-cloup
+  (package
+    (name "python-cloup")
+    (version "2.1.1")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "cloup" version))
+              (sha256
+               (base32
+                "05c6cjpnf9s72gyn5dckxbmd8rf2kgdzfsl7pqzrnc1lcdl13zmv"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-click))
+    (native-inputs (list python-setuptools python-pytest))
+    (home-page "https://github.com/janLuke/cloup")
+    (synopsis "Extension library for python-click")
+    (description
+     "Cloup — originally from ``Click + option groups'' — enriches Click with
+several features that make it more expressive and configurable: option groups,
+constraints, subcommand aliases, subcommands sections and a themeable
+HelpFormatter.")
+    (license license:bsd-3)))
+
 (define-public python-vcversioner
   (package
     (name "python-vcversioner")

base-commit: bb09f3ac002a4f34177d42fd3ea0332f4b7fe7a6
-- 
2.39.1

Message #8 received at 64224 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 64224 <at> debbugs.gnu.org
Cc: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>,
 jgart <jgart <at> dismail.de>
Subject: [PATCH v2] gnu: Add python-cloup.
Date: Thu, 22 Jun 2023 09:24:48 -0500

From: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>

* gnu/packages/python-xyz.scm (python-cloup): New variable.

Co-authored-by: jgart <jgart <at> dismail.de>
---

Hi,

Thanks for the patch. Here is a v2 that simplifies the home-page
description a bit and removes the native-input of setuptools, since it
is not needed.

Lars,

Do you happen to know why pytest is still required here even though we
are using pyproject-build-system? Is there a thread you can point me to
that explains that? Not sure I understand why this is the case yet from
reading the code for that build-system.

all best,

jgart

 gnu/packages/python-xyz.scm | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index b650b71f3b..5dcd6b9138 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -106,7 +106,7 @@
 ;;; Copyright © 2021 Franck Pérignon <franck.perignon <at> univ-grenoble-alpes.fr>
 ;;; Copyright © 2021, 2022 Petr Hodina <phodina <at> protonmail.com>
 ;;; Copyright © 2021 Simon Streit <simon <at> netpanic.org>
-;;; Copyright © 2021 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
+;;; Copyright © 2021, 2022, 2023 Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
 ;;; Copyright © 2021, 2022 Pradana Aumars <paumars <at> courrier.dev>
 ;;; Copyright © 2021, 2022 Felix Gruber <felgru <at> posteo.net>
 ;;; Copyright © 2021 Sébastien Lerique <sl <at> eauchat.org>
@@ -4578,6 +4578,27 @@ (define-public python-cligj
 well-tested and interoperable CLIs for handling GeoJSON.")
     (license license:bsd-3)))
 
+(define-public python-cloup
+  (package
+    (name "python-cloup")
+    (version "2.1.1")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "cloup" version))
+              (sha256
+               (base32
+                "05c6cjpnf9s72gyn5dckxbmd8rf2kgdzfsl7pqzrnc1lcdl13zmv"))))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-click))
+    (native-inputs (list python-pytest))
+    (home-page "https://github.com/janLuke/cloup")
+    (synopsis "Extension library for python-click")
+    (description
+     "Cloup enriches Click with several features that make it more expressive
+and configurable such as option groups, constraints, subcommand aliases,
+subcommands sections and a themeable HelpFormatter.")
+    (license license:bsd-3)))
+
 (define-public python-vcversioner
   (package
     (name "python-vcversioner")

base-commit: 8b6bc4b2aa579193306cdc7a28f788c9afb4e039
prerequisite-patch-id: b40ddb3f1c2f780c18f34b826b1229bb10358ec7
prerequisite-patch-id: 35ea140df746960cf9b020cb8abb74e6889b056c
-- 
2.40.1

Message #11 received at 64224 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: jgart <jgart <at> dismail.de>
Cc: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>,
 64224 <at> debbugs.gnu.org
Subject: Re: [bug#64224] [PATCH v2] gnu: Add python-cloup.
Date: Thu, 22 Jun 2023 21:32:19 +0200

Hi jgart,

> Do you happen to know why pytest is still required here even though we
> are using pyproject-build-system? Is there a thread you can point me to
> that explains that? Not sure I understand why this is the case yet from
> reading the code for that build-system.

pytest is always required as an input when used for testing. It is never
pulled in automatically, but its presence decides which testing framework
will be used (i.e. pytest is present → use pytest).

Lars

Message #14 received at 64224 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Meißner <daniel.meissner-i4k <at> rub.de>
To: jgart <jgart <at> dismail.de>, 64224 <at> debbugs.gnu.org
Cc: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>,
 jgart <jgart <at> dismail.de>
Subject: Re: [PATCH v2] gnu: Add python-cloup.
Date: Fri, 23 Jun 2023 09:41:24 +0200

Hi jgart,

jgart <jgart <at> dismail.de> writes:

> From: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
>
> * gnu/packages/python-xyz.scm (python-cloup): New variable.
>
> Co-authored-by: jgart <jgart <at> dismail.de>
> ---
>
> Hi,
>
> Thanks for the patch. Here is a v2 that simplifies the home-page
> description a bit and removes the native-input of setuptools, since it
> is not needed.

Thanks for your v2.  Weirdly enough, I thought I had tested it without
setuptools and it did not work.  However, I tested it again and now it
works for me also.  Thanks for your improvements.  LGTM.

Best

-- 
Daniel

Message #17 received at 64224 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Daniel Meißner" <daniel.meissner-i4k <at> rub.de>,
 64224 <at> debbugs.gnu.org
Cc: Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
Subject: Re: [PATCH v2] gnu: Add python-cloup.
Date: Fri, 23 Jun 2023 14:20:02 +0000

Cool, I'll push this later today after I finish work. I'd like to review it one more time.

all best,

jgart

Message #22 received at 64224-done <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Daniel Meißner"
 <daniel.meissner-i4k <at> ruhr-uni-bochum.de>, 64224-done <at> debbugs.gnu.org
Cc: control <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-cloup.
Date: Wed, 12 Jul 2023 06:28:53 +0000

Hi Daniel,

Thanks for the patch. APPLIED.

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.