GNU bug report logs - #6422
[describe-char PATCH 1/2] describe-char: add missing space in Unicode "Decomposition" line

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#6422: closed ([describe-char PATCH 1/2] describe-char: add
 missing space in Unicode "Decomposition" line)
Date: Sat, 19 Jun 2010 02:33:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 18 Jun 2010 22:32:52 -0400
with message-id <mm7hlviwff.fsf <at> fencepost.gnu.org>
and subject line Re: bug#6422: [describe-char PATCH 1/2] describe-char: add missing space in Unicode "Decomposition" line
has caused the GNU bug report #6422,
regarding [describe-char PATCH 1/2] describe-char: add missing space in Unicode "Decomposition" line
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
6422: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6422
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Gustav Hållberg <gustav <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [describe-char PATCH 1/2] describe-char: add missing space in
	Unicode "Decomposition" line
Date: Mon, 14 Jun 2010 14:23:43 +0200

If there is an "info" field, make sure to add a space after it.
---
 lisp/descr-text.el |   28 ++++++++++++++--------------
 1 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/lisp/descr-text.el b/lisp/descr-text.el
index 36ee08d..51f7a77 100644
--- a/lisp/descr-text.el
+++ b/lisp/descr-text.el
@@ -288,20 +288,20 @@ This function is semi-obsolete.  Use `get-char-code-property'."
 		       (or (char-code-property-description
 			    'bidi-class (intern val))
 			   val)))
-	       (list
-		"Decomposition"
-		(if (nth 4 fields)
-		    (let* ((parts (split-string (nth 4 fields)))
-			   (info (car parts)))
-		      (if (string-match "\\`<\\(.+\\)>\\'" info)
-			  (setq info (match-string 1 info))
-			(setq info nil))
-		      (if info (setq parts (cdr parts)))
-		      (setq parts (mapconcat
-				   (lambda (arg)
-				     (string (string-to-number arg 16)))
-				   parts " "))
-		      (concat info parts))))
+	       (list "Decomposition"
+                     (let ((field (nth 4 fields)))
+                       (when field
+                         (let* ((parts (split-string field))
+                                (info  (car parts)))
+                           (if (string-match "\\`<\\(.+\\)>\\'" info)
+                               (setq info  (match-string 1 info)
+                                     parts (cdr parts))
+                             (setq info nil))
+                           (concat info (when info " ")
+                                   (mapconcat
+                                    (lambda (arg)
+                                      (string (string-to-number arg 16)))
+                                    parts " "))))))
 	       (list "Decimal digit value"
 		     (nth 5 fields))
 	       (list "Digit value"

[Message part 3 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 6422-done <at> debbugs.gnu.org
Subject: Re: bug#6422: [describe-char PATCH 1/2] describe-char: add missing
	space in Unicode "Decomposition" line
Date: Fri, 18 Jun 2010 22:32:52 -0400

Gustav Hållberg wrote:

> If there is an "info" field, make sure to add a space after it.


I believe the minimum version of this change is just


--- lisp/descr-text.el	2010-06-03 15:34:35 +0000
+++ lisp/descr-text.el	2010-06-18 19:48:07 +0000
@@ -301,7 +301,7 @@
 				   (lambda (arg)
 				     (string (string-to-number arg 16)))
 				   parts " "))
-		      (concat info parts))))
+		      (concat info (if info " ") parts))))
 	       (list "Decimal digit value"
 		     (nth 5 fields))
 	       (list "Digit value"


so that's what I installed.

I would have found an example very helpful, eg

emacs -Q --eval \
  '(setq describe-char-unicodedata-file "admin/unidata/UnicodeData.txt")'

M-x ucs-insert RET 0132 RET
C-u C-x =

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.