GNU bug report logs - #6422
[describe-char PATCH 1/2] describe-char: add missing space in Unicode "Decomposition" line

Previous Next

Package: emacs;

Reported by: Gustav Hållberg <gustav <at> gmail.com>

Date: Mon, 14 Jun 2010 12:49:03 UTC

Severity: minor

Tags: patch

Merged with 6424

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#6424: closed ([describe-char PATCH 0/2] Minor output
 beautifications)
Date: Sat, 19 Jun 2010 02:33:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 18 Jun 2010 22:32:52 -0400
with message-id <mm7hlviwff.fsf <at> fencepost.gnu.org>
and subject line Re: bug#6422: [describe-char PATCH 1/2] describe-char: add missing space in Unicode "Decomposition" line
has caused the GNU bug report #6422,
regarding [describe-char PATCH 0/2] Minor output beautifications
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
6422: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6422
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Gustav Hållberg <gustav <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [describe-char PATCH 0/2] Minor output beautifications
Date: Mon, 14 Jun 2010 14:23:34 +0200
These two patches repair minor whitespace errors in describe-char
(C-u C-x =) when describe-char-unicodedata-file has been set.

The patches are against Emacs 23.2.

- Gustav

---

Gustav Hållberg (2):
      describe-char: add missing space in Unicode "Decomposition" line
      describe-char: remove superfluous space at end of "Unicode data" line


 lisp/descr-text.el |   33 +++++++++++++++++----------------
 1 files changed, 17 insertions(+), 16 deletions(-)

-- 


[Message part 3 (message/rfc822, inline)]
From: Glenn Morris <rgm <at> gnu.org>
To: 6422-done <at> debbugs.gnu.org
Subject: Re: bug#6422: [describe-char PATCH 1/2] describe-char: add missing
	space in Unicode "Decomposition" line
Date: Fri, 18 Jun 2010 22:32:52 -0400
Gustav Hållberg wrote:

> If there is an "info" field, make sure to add a space after it.


I believe the minimum version of this change is just


--- lisp/descr-text.el	2010-06-03 15:34:35 +0000
+++ lisp/descr-text.el	2010-06-18 19:48:07 +0000
@@ -301,7 +301,7 @@
 				   (lambda (arg)
 				     (string (string-to-number arg 16)))
 				   parts " "))
-		      (concat info parts))))
+		      (concat info (if info " ") parts))))
 	       (list "Decimal digit value"
 		     (nth 5 fields))
 	       (list "Digit value"


so that's what I installed.

I would have found an example very helpful, eg

emacs -Q --eval \
  '(setq describe-char-unicodedata-file "admin/unidata/UnicodeData.txt")'

M-x ucs-insert RET 0132 RET
C-u C-x =


This bug report was last modified 14 years and 341 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.