Subject: bug#64203: closed (Re: [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 22 Jun 2023 11:05:02 +0000

Your bug report

#64203: [PATCH] guix: node-build-system: Delete from peerDependencies too.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
64203: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64203
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too.
From: Lars-Dominik Braun <[email-masked]>
To: Jelle Licht <[email-masked]>
Cc: [email-masked]
Date: Thu, 22 Jun 2023 13:04:28 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

> The previous version of node we had packaged guix was v14, which came
> with npm v6. The most recent version of node we have packaged in guix is
> v18, which comes with npm v9.
> 
> From [1]: "In npm versions 3 through 6, peerDependencies were not
> automatically installed, and would raise a warning if an invalid version
> of the peer dependency was found in the tree. As of npm v7,
> peerDependencies are installed by default."

thanks! Pushed to master as 37c2e94cec6cb8b5e0e93e7b6c712c3b187ca5db.

Cheers,
Lars

Subject: [PATCH] guix: node-build-system: Delete from peerDependencies too.
From: Lars-Dominik Braun <[email-masked]>
To: [email-masked]
Date: Wed, 21 Jun 2023 10:38:17 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* guix/build/node-build-system.scm (delete-dependencies): Remove supplied
dependencies from peerDependencies field too.
---

Hi,

this is required to build a new RStudio. I’m also validating it does
not break anything here: https://ci.guix.gnu.org/jobset/node-peerdeps

Cheers,
Lars

 guix/build/node-build-system.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/build/node-build-system.scm b/guix/build/node-build-system.scm
index 93f7efbb2b..fb23894bc1 100644
--- a/guix/build/node-build-system.scm
+++ b/guix/build/node-build-system.scm
@@ -208,7 +208,8 @@ (define (delete-dependencies absent)
       (jsobject-update*
        pkg-meta
        `("devDependencies" ,delete-from-jsobject (@))
-       `("dependencies" ,delete-from-jsobject (@))))))
+       `("dependencies" ,delete-from-jsobject (@))
+       `("peerDependencies" ,delete-from-jsobject (@))))))
 
 (define* (delete-lockfiles #:key inputs #:allow-other-keys)
   "Delete 'package-lock.json', 'yarn.lock', and 'npm-shrinkwrap.json', if they

base-commit: 1a0ff5cd83d3257efcab64740a1322de51fbc4a1
-- 
2.39.3