From unknown Sun Jun 22 07:59:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too. Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: jlicht@fsfe.org, guix-patches@gnu.org Resent-Date: Wed, 21 Jun 2023 08:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64203 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64203@debbugs.gnu.org Cc: jlicht@fsfe.org X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: jlicht@fsfe.org Received: via spool by submit@debbugs.gnu.org id=B.168733671810180 (code B ref -1); Wed, 21 Jun 2023 08:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Jun 2023 08:38:38 +0000 Received: from localhost ([127.0.0.1]:60619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBtMM-0002e7-2O for submit@debbugs.gnu.org; Wed, 21 Jun 2023 04:38:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:49260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBtMJ-0002dz-WF for submit@debbugs.gnu.org; Wed, 21 Jun 2023 04:38:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBtMJ-0007Aj-Mv for guix-patches@gnu.org; Wed, 21 Jun 2023 04:38:35 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1qBtMH-0005G6-9A for guix-patches@gnu.org; Wed, 21 Jun 2023 04:38:35 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4QmH2f74qYz9srN for ; Wed, 21 Jun 2023 10:38:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1687336699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zLRdKR/bDvWUymQhk4ActkEJynjy9IUH1Oqb1smyY3E=; b=LB1uOYw5UKHyTDosYHX6VcSYderJvHi+saOCxaPnSUB4DejSqHkJ1fML2jj4pgiDJgu9NU DUv/2597TS70r7JPY3PdYBn1Vx/cRNIQYzkyRo9akT5UVs2gZCi2tBXbB3pqo0aXHUhclp U69tFAM9HWxiX4zmYxHGG1Ov8Gs8VLS8iZ2cs3aSi+iO5eQ+f59vX1l28KB5UQyEhvtN8h ZZuHOJSrmX6B6Up2VTojywf8I6Eov2pMMvzm9FKL63xANT36alhgKbA819DPQimRS8RUeL QFAkeXYvsRiyxFxybaC070OTfwzcxRxONs+1y+Spp8/7REZ/TTnNoUEqbbNnGg== Date: Wed, 21 Jun 2023 10:38:17 +0200 From: Lars-Dominik Braun Message-ID: <6bc6fc29681881be3ce767c51a7dd8886b97c169.1687336553.git.lars@6xq.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=80.241.56.172; envelope-from=lars@6xq.net; helo=mout-p-202.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * guix/build/node-build-system.scm (delete-dependencies): Remove supplied dependencies from peerDependencies field too. --- Hi, this is required to build a new RStudio. I’m also validating it does not break anything here: https://ci.guix.gnu.org/jobset/node-peerdeps Cheers, Lars guix/build/node-build-system.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guix/build/node-build-system.scm b/guix/build/node-build-system.scm index 93f7efbb2b..fb23894bc1 100644 --- a/guix/build/node-build-system.scm +++ b/guix/build/node-build-system.scm @@ -208,7 +208,8 @@ (define (delete-dependencies absent) (jsobject-update* pkg-meta `("devDependencies" ,delete-from-jsobject (@)) - `("dependencies" ,delete-from-jsobject (@)))))) + `("dependencies" ,delete-from-jsobject (@)) + `("peerDependencies" ,delete-from-jsobject (@)))))) (define* (delete-lockfiles #:key inputs #:allow-other-keys) "Delete 'package-lock.json', 'yarn.lock', and 'npm-shrinkwrap.json', if they base-commit: 1a0ff5cd83d3257efcab64740a1322de51fbc4a1 -- 2.39.3 From unknown Sun Jun 22 07:59:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Jun 2023 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64203 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun , 64203@debbugs.gnu.org Received: via spool by 64203-submit@debbugs.gnu.org id=B64203.16874261926699 (code B ref 64203); Thu, 22 Jun 2023 09:30:02 +0000 Received: (at 64203) by debbugs.gnu.org; 22 Jun 2023 09:29:52 +0000 Received: from localhost ([127.0.0.1]:34838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCGdU-0001jz-9W for submit@debbugs.gnu.org; Thu, 22 Jun 2023 05:29:52 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:58462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCGdR-0001jn-3i for 64203@debbugs.gnu.org; Thu, 22 Jun 2023 05:29:51 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1687426187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PypBYzwCMq5UYos4ZsG0kCxCfNgcPe0nn52Ax8Kb71Y=; b=n1fNViWRnhNgSznCv66d4MZ9t1H9AbvpohtXPdj+87I/+7l2U4xfC8Ayk3I45Zv45ssrMs jJuWUBnIY3Lo9SenVN+rU5AfU3GNAp+1V+V67rxpsvV0uNE+35jTF9n2Z1DD5I5mmpEZqJ NG9sq7fPpLX7TBkjq4jQWMPz/lO3vZQ= In-Reply-To: <6bc6fc29681881be3ce767c51a7dd8886b97c169.1687336553.git.lars@6xq.net> References: <6bc6fc29681881be3ce767c51a7dd8886b97c169.1687336553.git.lars@6xq.net> Date: Thu, 22 Jun 2023 11:29:46 +0200 Message-ID: <875y7f7sl1.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars-Dominik Braun writes: > * guix/build/node-build-system.scm (delete-dependencies): Remove supplied > dependencies from peerDependencies field too. > --- > > Hi, > > this is required to build a new RStudio. I=E2=80=99m also validating it d= oes > not break anything here: https://ci.guix.gnu.org/jobset/node-peerdeps LGTM. You can consider adding a note to the commit message that thix needed due to a change in how more recent npm versions deal with peerDependencies. Cheers, - Jelle From unknown Sun Jun 22 07:59:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too. Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Jun 2023 10:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64203 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jelle Licht Cc: 64203@debbugs.gnu.org Received: via spool by 64203-submit@debbugs.gnu.org id=B64203.168742835710781 (code B ref 64203); Thu, 22 Jun 2023 10:06:01 +0000 Received: (at 64203) by debbugs.gnu.org; 22 Jun 2023 10:05:57 +0000 Received: from localhost ([127.0.0.1]:34901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCHCP-0002no-FT for submit@debbugs.gnu.org; Thu, 22 Jun 2023 06:05:57 -0400 Received: from mout-p-103.mailbox.org ([80.241.56.161]:58780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCHCM-0002nZ-V0 for 64203@debbugs.gnu.org; Thu, 22 Jun 2023 06:05:56 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4Qmwx71WDqz9sSP; Thu, 22 Jun 2023 12:05:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1687428347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YCEbbO9ZwMqVUrWGZgnnk1O8n+c/0X4uMT/zc8WuoxM=; b=h5x4TmXXaSEZEUpJlpa4V8dxxfmNKSABamOPLwMtAQlspirkDyMHlrDRD/VvUsM7zeDTGQ HFVXi+3J/HkqlstQeCo7OnWcIiHlXYd2m/gSybJVjK2kAYgVGmU9ZPb+3K0bHv6RQCleyA QJD+NE/Yf+ccTozHX0RIK0TrUBAvBmxYuRysTs6z4yniLbaf4gHPeqFM0yKBPQheogdfLa h15Bxzvy+lhxMrVcXNuN4lpkIxz8rfulM4U+G+K+A0loOCJgoD+DWvVBG682I7pPk+GbEO 97HX//O/mMXNWPu3ipoDo/eqqydy9yRF62mEnxG2kKs4keXd1G+yTyI+IKB+3Q== Date: Thu, 22 Jun 2023 12:05:45 +0200 From: Lars-Dominik Braun Message-ID: References: <6bc6fc29681881be3ce767c51a7dd8886b97c169.1687336553.git.lars@6xq.net> <875y7f7sl1.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <875y7f7sl1.fsf@fsfe.org> X-Rspamd-Queue-Id: 4Qmwx71WDqz9sSP X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, > LGTM. You can consider adding a note to the commit message that thix > needed due to a change in how more recent npm versions deal with > peerDependencies. I don’t know anything about that change in npm unfortunately – this is purely based on observations of failed builds. Do you have further information on this? Thanks, Lars From unknown Sun Jun 22 07:59:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Jun 2023 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64203 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 64203@debbugs.gnu.org Received: via spool by 64203-submit@debbugs.gnu.org id=B64203.168742943512602 (code B ref 64203); Thu, 22 Jun 2023 10:24:02 +0000 Received: (at 64203) by debbugs.gnu.org; 22 Jun 2023 10:23:55 +0000 Received: from localhost ([127.0.0.1]:34942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCHTn-0003HB-IH for submit@debbugs.gnu.org; Thu, 22 Jun 2023 06:23:55 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:39614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCHTk-0003H1-Ka for 64203@debbugs.gnu.org; Thu, 22 Jun 2023 06:23:53 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1687429430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ggvc9tJwTDZ/wsIrAHOhVjQunLYb9habD8oAH0kA0ro=; b=fUc+ZCfynGUwHBwPYnu7QSM6uj9XGZc/P2s9G7+phF3C4gF1/h0G+CAt7XHFw6aNJvdUSB gWyjP/K+3XUuRCUEWFYrVTCvx0gDIpVPAvdYC6SRqY0L1brp7pQGxeLmoXinOLMdQKXt/F JtLJkX0d6g/cGueuAkTp4pcLd3zhGJk= In-Reply-To: References: <6bc6fc29681881be3ce767c51a7dd8886b97c169.1687336553.git.lars@6xq.net> <875y7f7sl1.fsf@fsfe.org> Date: Thu, 22 Jun 2023 12:23:49 +0200 Message-ID: <87zg4r6bii.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars-Dominik Braun writes: > Hi, > >> LGTM. You can consider adding a note to the commit message that thix >> needed due to a change in how more recent npm versions deal with >> peerDependencies. > > I don=E2=80=99t know anything about that change in npm unfortunately =E2= =80=93 this > is purely based on observations of failed builds. Do you have further > information on this? The previous version of node we had packaged guix was v14, which came with npm v6. The most recent version of node we have packaged in guix is v18, which comes with npm v9. >From [1]: "In npm versions 3 through 6, peerDependencies were not automatically installed, and would raise a warning if an invalid version of the peer dependency was found in the tree. As of npm v7, peerDependencies are installed by default." HTH! - Jelle [1]: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#peerdepende= ncies: From unknown Sun Jun 22 07:59:42 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Lars-Dominik Braun Subject: bug#64203: closed (Re: [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too.) Message-ID: References: <6bc6fc29681881be3ce767c51a7dd8886b97c169.1687336553.git.lars@6xq.net> X-Gnu-PR-Message: they-closed 64203 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 64203@debbugs.gnu.org Date: Thu, 22 Jun 2023 11:05:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1687431902-17670-1" This is a multi-part message in MIME format... ------------=_1687431902-17670-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64203: [PATCH] guix: node-build-system: Delete from peerDependencies too. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64203@debbugs.gnu.org. --=20 64203: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64203 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1687431902-17670-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64203-done) by debbugs.gnu.org; 22 Jun 2023 11:04:40 +0000 Received: from localhost ([127.0.0.1]:34975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCI7E-0004aN-F1 for submit@debbugs.gnu.org; Thu, 22 Jun 2023 07:04:40 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:45344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCI7B-0004a8-Qh for 64203-done@debbugs.gnu.org; Thu, 22 Jun 2023 07:04:39 -0400 Received: from smtp102.mailbox.org (unknown [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4QmyDs6pDLz9smf; Thu, 22 Jun 2023 13:04:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1687431869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DXQj/oQNdLKWLqcwBrOiIAfvOfwOfO4hh+0+IqDHPA8=; b=NaMNEIf8SrpFYQ82OT4OAndvOye2l0T5rWkox7/iGfLqg2lIgZiuUt0B1HtnoUxZJPwFLy xQAapH99gYtf0OBct54zAoKj12krOyjSsaZNZjNrSFBA+Q2PVctikZsPCCO0JOsdVShuYy Ttk3FYGYjFeQ9AI06GqBXcmLfB+IYjLGu1Pe1xIbo4G/PtfHpyRH0y6/WvaMp+3b8QdG+U xuG62eNZENzRllB6Igau4tH6ORsJOu+wh5TsGHAUiEZgUWEtjqrvMW9HnxyEN10t5SVoWd pmZ81MUk9oxl9wLOHXX508rTkH6OmKEi4Pb8gW1jD2A4+poiLLoYRy8rMBxn+Q== Date: Thu, 22 Jun 2023 13:04:28 +0200 From: Lars-Dominik Braun To: Jelle Licht Subject: Re: [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too. Message-ID: References: <6bc6fc29681881be3ce767c51a7dd8886b97c169.1687336553.git.lars@6xq.net> <875y7f7sl1.fsf@fsfe.org> <87zg4r6bii.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zg4r6bii.fsf@fsfe.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64203-done Cc: 64203-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, > The previous version of node we had packaged guix was v14, which came > with npm v6. The most recent version of node we have packaged in guix is > v18, which comes with npm v9. > > From [1]: "In npm versions 3 through 6, peerDependencies were not > automatically installed, and would raise a warning if an invalid version > of the peer dependency was found in the tree. As of npm v7, > peerDependencies are installed by default." thanks! Pushed to master as 37c2e94cec6cb8b5e0e93e7b6c712c3b187ca5db. Cheers, Lars ------------=_1687431902-17670-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Jun 2023 08:38:38 +0000 Received: from localhost ([127.0.0.1]:60619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBtMM-0002e7-2O for submit@debbugs.gnu.org; Wed, 21 Jun 2023 04:38:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:49260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBtMJ-0002dz-WF for submit@debbugs.gnu.org; Wed, 21 Jun 2023 04:38:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBtMJ-0007Aj-Mv for guix-patches@gnu.org; Wed, 21 Jun 2023 04:38:35 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1qBtMH-0005G6-9A for guix-patches@gnu.org; Wed, 21 Jun 2023 04:38:35 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4QmH2f74qYz9srN for ; Wed, 21 Jun 2023 10:38:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1687336699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zLRdKR/bDvWUymQhk4ActkEJynjy9IUH1Oqb1smyY3E=; b=LB1uOYw5UKHyTDosYHX6VcSYderJvHi+saOCxaPnSUB4DejSqHkJ1fML2jj4pgiDJgu9NU DUv/2597TS70r7JPY3PdYBn1Vx/cRNIQYzkyRo9akT5UVs2gZCi2tBXbB3pqo0aXHUhclp U69tFAM9HWxiX4zmYxHGG1Ov8Gs8VLS8iZ2cs3aSi+iO5eQ+f59vX1l28KB5UQyEhvtN8h ZZuHOJSrmX6B6Up2VTojywf8I6Eov2pMMvzm9FKL63xANT36alhgKbA819DPQimRS8RUeL QFAkeXYvsRiyxFxybaC070OTfwzcxRxONs+1y+Spp8/7REZ/TTnNoUEqbbNnGg== Date: Wed, 21 Jun 2023 10:38:17 +0200 From: Lars-Dominik Braun To: guix-patches@gnu.org Subject: [PATCH] guix: node-build-system: Delete from peerDependencies too. Message-ID: <6bc6fc29681881be3ce767c51a7dd8886b97c169.1687336553.git.lars@6xq.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Debbugs-CC: jlicht@fsfe.org Received-SPF: pass client-ip=80.241.56.172; envelope-from=lars@6xq.net; helo=mout-p-202.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * guix/build/node-build-system.scm (delete-dependencies): Remove supplied dependencies from peerDependencies field too. --- Hi, this is required to build a new RStudio. I’m also validating it does not break anything here: https://ci.guix.gnu.org/jobset/node-peerdeps Cheers, Lars guix/build/node-build-system.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guix/build/node-build-system.scm b/guix/build/node-build-system.scm index 93f7efbb2b..fb23894bc1 100644 --- a/guix/build/node-build-system.scm +++ b/guix/build/node-build-system.scm @@ -208,7 +208,8 @@ (define (delete-dependencies absent) (jsobject-update* pkg-meta `("devDependencies" ,delete-from-jsobject (@)) - `("dependencies" ,delete-from-jsobject (@)))))) + `("dependencies" ,delete-from-jsobject (@)) + `("peerDependencies" ,delete-from-jsobject (@)))))) (define* (delete-lockfiles #:key inputs #:allow-other-keys) "Delete 'package-lock.json', 'yarn.lock', and 'npm-shrinkwrap.json', if they base-commit: 1a0ff5cd83d3257efcab64740a1322de51fbc4a1 -- 2.39.3 ------------=_1687431902-17670-1--