Subject: [bug#64188] [PATCH 0/8] More package tuning

From: Ludovic Courtès <[email-masked]>
Date: Sun, 25 Jun 2023 22:52:14 +0200

Efraim Flashner <[email-masked]> skribis:

> * guix/transformations.scm (tuned-package)[build-system]: Don't replace
> the build-system if inheriting from the go-build-system.
> [arguments]: If using the go-build-system add a phase to set the
> micro-architecture for Go.

[...]

> @@ -570,14 +571,42 @@ (define (tuned-package p micro-architecture)
>    (package
>      (inherit p)
>      (build-system
> -      (build-system-with-tuning-compiler (package-build-system p)
> -                                         micro-architecture))
> +      ;; The go compiler doesn't need to be wrapped.
> +      ;; XXX: This is where we check for supported micro-architectures.
> +      (if (eq? (build-system-name (package-build-system p))
> +               'go)
> +        (package-build-system p)
> +        (build-system-with-tuning-compiler (package-build-system p)
> +                                           micro-architecture)))
>      (arguments
>       ;; The machine building this package may or may not be able to run code
>       ;; for MICRO-ARCHITECTURE.  Because of that, skip tests; they are run for
>       ;; the "baseline" variant anyway.
>       (substitute-keyword-arguments (package-arguments p)
> -       ((#:tests? _ #f) #f)))
> +       ((#:tests? _ #f) #f)
> +       ;; We add the tuning parameter after the default GO flags are set.
> +       ((#:phases phases '%standard-phases)
> +        (if (eq? (build-system-name (package-build-system p))
> +                 'go)
> +          #~(modify-phases #$phases
> +              (add-after 'setup-go-environment 'set-microarchitecture

Can we use the same approach as before with
‘build-system-with-tuning-compiler’?  That seems more robust to me and
it’d be more consistent.

Ludo’.