GNU bug report logs - #64186
Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64186: closed (Patch: Suppress deprecated '-gdb-set
 target-async' warning message in gdb-mi.el)
Date: Thu, 06 Jul 2023 07:11:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 06 Jul 2023 10:10:07 +0300
with message-id <83sfa1ikhc.fsf <at> gnu.org>
and subject line Re: bug#64186: Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el
has caused the debbugs.gnu.org bug report #64186,
regarding Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64186: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64186
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Wang Diancheng <dianchengwang <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Patch: Suppress deprecated '-gdb-set target-async' warning message in
 gdb-mi.el
Date: Tue, 20 Jun 2023 10:21:48 +0800

[Message part 3 (text/plain, inline)]

Hi,

The command "-gdb-set target-async" is deprecated since gdb 7.7, It is
annoyed that there is a message "Warning: 'set target-async', an alias for
the command 'set mi-async', is deprecated. Use 'set mi-async'." when gdb
buffer is ready for command. Following is a patch to suppress that
warning.

Thanks.

[gdb-mi-suppress-target-async-warning.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Wang Diancheng <dianchengwang <at> gmail.com>
Cc: luangruo <at> yahoo.com, 64186-done <at> debbugs.gnu.org
Subject: Re: bug#64186: Patch: Suppress deprecated '-gdb-set target-async'
 warning message in gdb-mi.el
Date: Thu, 06 Jul 2023 10:10:07 +0300

> From: Wang Diancheng <dianchengwang <at> gmail.com>
> Date: Fri, 30 Jun 2023 15:08:18 +0800
> Cc: luangruo <at> yahoo.com, 64186 <at> debbugs.gnu.org
> 
> Thanks for your comments.I think what exactly the value of
> `gdb-last-command’ is not essential for us.
> We just need to know  whether `gdb-last-command' is a CLI command in
> the background or a MI command,
> since here we have already got its "running" status.  We must check
> the target "async" feature after stopping
> the debuggee at the first time in function `gdb-stopped' if
> `gdb-last-command' is not a background CLI command or a MI command.
> 
> > > +  ;; Set `gdb-non-stop` when `gdb-last-command` is a CLI background
> > > +  ;; `run` command e.g. r& or MI command `-exec-run`
> > > +  (when (or (string-match "&\s*$" gdb-last-command)
> > > +            (string-match "-exec-run" gdb-last-command))
> > > +    (gdb-try-check-target-async-support))
> >
> > And I'm not sure I understand the idea behind this part:
> >
> > > @@ -2722,6 +2744,9 @@ gdb-stopped
> > >
> > >      ;; Print "(gdb)" to GUD console
> > >      (when gdb-first-done-or-error
> > > +      ;; If run target with CLI foreground command `run`, `target
> > > +      ;; async` can only be checked when target is stopped
> > > +      (gdb-try-check-target-async-support)
> > >        (setq gdb-filter-output (concat gdb-filter-output gdb-prompt-name)))
> >
> > Can you elaborate?
> 
> Thanks for your questions, according to my comments above, If the
> debuggee has been started by
> a non-background CLI command e.g. “run" or "attach" (no trailing "&")
> commands, we can only
> check the target "async" feature at the code stack.
> 
> >
> > Finally, please don't quote symbols `like this` in comments.  Our
> > conventions are to quote symbols 'like this' or `like this'.
> 
> I updated the patch, see the attachment.

Thanks, installed on the master branch, and closing the bug.

Note that, with this patch you have exhausted the amount of changes we
can accept from you without copyright assignment to the FSF.  Would
you like to start the copyright assignment paperwork at this time, so
that we could accept more changes from you in the future?  If you are
willing to start the assignment process, I will send you the form to
fill and the instructions to go with it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.