From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 19 16:13:48 2023 Received: (at submit) by debbugs.gnu.org; 19 Jun 2023 20:13:48 +0000 Received: from localhost ([127.0.0.1]:57366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBLFz-0002RE-ND for submit@debbugs.gnu.org; Mon, 19 Jun 2023 16:13:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:56830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBLFy-0002R5-4C for submit@debbugs.gnu.org; Mon, 19 Jun 2023 16:13:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBLFx-0008AR-Rs for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2023 16:13:45 -0400 Received: from mail-40130.protonmail.ch ([185.70.40.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBLFu-0003cB-CZ for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2023 16:13:45 -0400 Date: Mon, 19 Jun 2023 20:13:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1687205619; x=1687464819; bh=TCUOKo6nZ5egDrjtAwk+VZUBbvJsikr3YBN4BSa3GII=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=Ary3aJ3M+5UIwHX5jJ5KzwsHYF2Q3zdJswM+z4xiwREZAuU+b+8N/ICOf+4y2tKBS 13xSsiiQaLq1j3j6Uv+Ym7EQL9wASLtByDQW+DHc6VdQn8uMu1kI1D+PtHS/p7VAxc 1XFVSAp+eexTXt+bupbSU6CArAOf9tPse0QirVmXKvnfxy2bUAMc5i4OKrWVgmUM+R 30ZnmAymTwF7eJ74r5ZllrCJn09Iia6dJK6ZI1snEiJeFQWZgJv6JmHqVsKbMibvda yngQsYGYD0Qg4IqrPVoumz8xZKEIBirnZj2taTSxpuLTcIMidFo7f4QyfMdDg00Ocm INX5LL13V93ag== To: "bug-gnu-emacs@gnu.org" From: uzibalqa Subject: outline-minor-mode-highlight fails to activate for custom headings Message-ID: Feedback-ID: 52887082:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.130; envelope-from=uzibalqa@proton.me; helo=mail-40130.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I have made custom headings for outline-minor-mode=20 But (setq outline-minor-mode-highlight 'override) does not succeed in displaying the foreground colours at the defined levels when using (set-face-foreground "outline-1" "#ff62d4") (set-face-foreground "outline-2" "#9f80ff") (set-face-foreground "outline-3" "#fe6060") Yet, the colours get properly displayed for the default headings for the specific major mode From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 20 03:01:13 2023 Received: (at 64177) by debbugs.gnu.org; 20 Jun 2023 07:01:13 +0000 Received: from localhost ([127.0.0.1]:57869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBVMX-0003iH-0N for submit@debbugs.gnu.org; Tue, 20 Jun 2023 03:01:13 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:47471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBVMQ-0003hM-1K for 64177@debbugs.gnu.org; Tue, 20 Jun 2023 03:01:09 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Received: by mail.gandi.net (Postfix) with ESMTPSA id 0E715C000D; Tue, 20 Jun 2023 07:00:58 +0000 (UTC) From: Juri Linkov To: uzibalqa Subject: Re: bug#64177: outline-minor-mode-highlight fails to activate for custom headings In-Reply-To: (uzibalqa via's message of "Mon, 19 Jun 2023 20:13:32 +0000") Organization: LINKOV.NET References: Date: Tue, 20 Jun 2023 09:50:06 +0300 Message-ID: <867crytzr9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64177 Cc: 64177@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I have made custom headings for outline-minor-mode > > But > > (setq outline-minor-mode-highlight 'override) > > does not succeed in displaying the foreground colours at the > defined levels when using > > (set-face-foreground "outline-1" "#ff62d4") > (set-face-foreground "outline-2" "#9f80ff") > (set-face-foreground "outline-3" "#fe6060") > > Yet, the colours get properly displayed for the default headings > for the specific major mode Thanks for the bug report. It's still not clear how to test it. When tried to evaluate (set-face-foreground "outline-1" "#ff62d4") it failed with Lisp error: (wrong-type-argument symbolp "outline-1") because the right syntax is (set-face-foreground 'outline-1 "#ff62d4"). Does it work with this fix? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 20 06:56:10 2023 Received: (at 64177) by debbugs.gnu.org; 20 Jun 2023 10:56:10 +0000 Received: from localhost ([127.0.0.1]:58159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBZ1u-0001nL-7j for submit@debbugs.gnu.org; Tue, 20 Jun 2023 06:56:10 -0400 Received: from mail-40141.protonmail.ch ([185.70.40.141]:28205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBZ1o-0001mm-QA for 64177@debbugs.gnu.org; Tue, 20 Jun 2023 06:56:08 -0400 Date: Tue, 20 Jun 2023 10:55:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1687258557; x=1687517757; bh=G5a7Zg35tiag6MJVrCz5Lh4HBGLR004+SJ7KSiBtL4w=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=d59VOMdaMm5CLRwQjdWpcagrnajgIsDHo9GsWg2FinSmD5BUkDr97KXb2zSSccCcC gd5NiEgzuUxYEQ+CMl5e8MlCzFwkRWAUHeknzxG8IP+kY+6Rvnv17l2PQoL2/bn7xz En7J4dZu78tQqJRqg/ym47ZksRZ1FGse2T0EALIenFArn5TXU9YZIVYWhRuYCHEpor lZdThUB7DtHehLUhw60ImvwSNw8B8zwppMU8GYWg/wx6IX1nVGHx841B6Q52gOJTjL XYNQC3bSV4bt/Sdx5VTGVFj2OBY03EBhwgk75sdMzkQF7lWdXcjjLHxLJgIJVByLSe qNWJC6ZvorxAA== To: Juri Linkov From: uzibalqa Subject: Re: bug#64177: outline-minor-mode-highlight fails to activate for custom headings Message-ID: In-Reply-To: <867crytzr9.fsf@mail.linkov.net> References: <867crytzr9.fsf@mail.linkov.net> Feedback-ID: 52887082:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64177 Cc: 64177@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------- Original Message ------- On Tuesday, June 20th, 2023 at 6:50 PM, Juri Linkov wrote= : > > I have made custom headings for outline-minor-mode > >=20 > > But > >=20 > > (setq outline-minor-mode-highlight 'override) > >=20 > > does not succeed in displaying the foreground colours at the > > defined levels when using > >=20 > > (set-face-foreground "outline-1" "#ff62d4") > > (set-face-foreground "outline-2" "#9f80ff") > > (set-face-foreground "outline-3" "#fe6060") > >=20 > > Yet, the colours get properly displayed for the default headings > > for the specific major mode >=20 >=20 > Thanks for the bug report. It's still not clear how to test it. > When tried to evaluate (set-face-foreground "outline-1" "#ff62d4") > it failed with Lisp error: (wrong-type-argument symbolp "outline-1") > because the right syntax is (set-face-foreground 'outline-1 "#ff62d4"). > Does it work with this fix? I have done this and still showing failure upon 'override (defvar elisp-hglevels '( (";;; H1" . 1) (";;; H2" . 2) (";;; H3" . 3) (";;; H4" . 4) (";;; H5" . 5) (";;; H6" . 6) (";;; H7" . 7) (";;; H8" . 8) )) ;;------------- (defun outlhg-regexp () (cond ((eq major-mode 'emacs-lisp-mode) (let ( (hrklevels elisp-hrklevels) ) (setq outline-regexp (concat (regexp-opt (mapcar 'car hrklevels)) "\\>")) (setq outline-heading-alist hrklevels))) )) ;; --------- (defun outlhg-tyface () (interactive) (let* ( (pigment-darkbg '("#ff62d4" "#9f80ff" "#fe6060" "#fba849" "#4fe42f" "#4fafff" "#f0dd60" "#FFFFFF")) (pigment-lightbg '("#1f1fce" "#006800" "#b60000" "#605b00" "#a8007f" "#005f88" "#904200" "#7f10d0")) (pigment (if (eq (frame-parameter nil 'background-mode) 'dark) pigment-darkbg pigment-lightbg)) ) (dotimes (i 8) (let ((hkfc (intern (format "outline-%d" (1+ i)))) (colr (nth i pigment))) (set-face-foreground hkfc colr))))) =20 ;;-------------=20 (outline-minor-mode 0) (setq outline-minor-mode-highlight 'override) (outlhg-regexp) (outlhg-tyface) (outline-minor-mode 1) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 20 12:52:17 2023 Received: (at 64177) by debbugs.gnu.org; 20 Jun 2023 16:52:17 +0000 Received: from localhost ([127.0.0.1]:59679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBeaX-0002HH-1h for submit@debbugs.gnu.org; Tue, 20 Jun 2023 12:52:17 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBeaV-0002Gr-8t for 64177@debbugs.gnu.org; Tue, 20 Jun 2023 12:52:15 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Received: by mail.gandi.net (Postfix) with ESMTPSA id 5532960009; Tue, 20 Jun 2023 16:52:08 +0000 (UTC) From: Juri Linkov To: uzibalqa Subject: Re: bug#64177: outline-minor-mode-highlight fails to activate for custom headings In-Reply-To: (uzibalqa@proton.me's message of "Tue, 20 Jun 2023 10:55:44 +0000") Organization: LINKOV.NET References: <867crytzr9.fsf@mail.linkov.net> Date: Tue, 20 Jun 2023 19:50:27 +0300 Message-ID: <86jzvyqdrg.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64177 Cc: 64177@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I have done this and still showing failure upon 'override > > (defvar elisp-hglevels > '( (";;; H1" . 1) (";;; H2" . 2) (";;; H3" . 3) (";;; H4" . 4) > (";;; H5" . 5) (";;; H6" . 6) (";;; H7" . 7) (";;; H8" . 8) )) > ... > ((eq major-mode 'emacs-lisp-mode) > ... > (outline-minor-mode 0) > (setq outline-minor-mode-highlight 'override) > (outlhg-regexp) > (outlhg-tyface) > (outline-minor-mode 1) Please also try: (setq-local outline-level 'outline-level) because 'emacs-lisp-mode' overrides the default value with own 'lisp-outline-level'. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 20 16:06:52 2023 Received: (at 64177) by debbugs.gnu.org; 20 Jun 2023 20:06:53 +0000 Received: from localhost ([127.0.0.1]:59806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBhcq-00057L-DP for submit@debbugs.gnu.org; Tue, 20 Jun 2023 16:06:52 -0400 Received: from mail-4319.protonmail.ch ([185.70.43.19]:27737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBhcl-00056w-Pl for 64177@debbugs.gnu.org; Tue, 20 Jun 2023 16:06:50 -0400 Date: Tue, 20 Jun 2023 20:06:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=xpowlm22izhvte5ftwr6kyub6m.protonmail; t=1687291601; x=1687550801; bh=tpygQ95XAOQwpQ17cbDxEvmDjgILLMkKl3Nagq4yBto=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=lwWOHU5zlPi8R81nr/Or7Dp8wR17NwiLXnC1JKpkTjfj6PAEZ+CF8VJlW7b65QjOq DpFfjeuIxfCxgKG5GBje/y1CBgk9Tekqhg7yZiqA+NKo1iRdxjP3f1Pdf9dTnwaYYn f70DlvMRGHo5KxITvjVKKVfG8WdzexS5oO4yu7ROMKty7P3QMKI/1nqoxf3bG2apjj XQI2/TYQxsVs8IDMkuHdxgzdSJYd/o5YRAgIoX4l3ONgeY5nH6hU1Kqn0FB7DZ9y2A NEy5njgWZc2yNTDUcgyklygq3dTlLG3ySVEY5y53d1cF/DfV5vUbg1UtLve6Z4Dzrq psvvz2xwl5thQ== To: Juri Linkov From: uzibalqa Subject: Re: bug#64177: outline-minor-mode-highlight fails to activate for custom headings Message-ID: In-Reply-To: <86jzvyqdrg.fsf@mail.linkov.net> References: <867crytzr9.fsf@mail.linkov.net> <86jzvyqdrg.fsf@mail.linkov.net> Feedback-ID: 52887082:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64177 Cc: 64177@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------- Original Message ------- On Wednesday, June 21st, 2023 at 4:50 AM, Juri Linkov wro= te: > > I have done this and still showing failure upon 'override > >=20 > > (defvar elisp-hglevels > > '( (";;; H1" . 1) (";;; H2" . 2) (";;; H3" . 3) (";;; H4" . 4) > > (";;; H5" . 5) (";;; H6" . 6) (";;; H7" . 7) (";;; H8" . 8) )) > > ... > > ((eq major-mode 'emacs-lisp-mode) > > ... > > (outline-minor-mode 0) > > (setq outline-minor-mode-highlight 'override) > > (outlhg-regexp) > > (outlhg-tyface) > > (outline-minor-mode 1) >=20 >=20 > Please also try: >=20 > (setq-local outline-level 'outline-level) >=20 > because 'emacs-lisp-mode' overrides the default value > with own 'lisp-outline-level'. Now that I have tried your suggestion, I can the the requested highlighting= . I see that the value of outline-level is lisp-outline-level. Whereas with = your change it is outline-level. In principle, shouldn't outline-level be directly determined by the level s= pecified=20 in outline-heading-alist ? If emacs-lisp-mode sets outline-heading-alist i= tself properly then any level information can be extracted from there. Then the = setup would run more smoothly because it would be consistent with the way one would act= ually customise it. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 21 02:22:28 2023 Received: (at 64177) by debbugs.gnu.org; 21 Jun 2023 06:22:28 +0000 Received: from localhost ([127.0.0.1]:60314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBrEZ-0007Ky-VE for submit@debbugs.gnu.org; Wed, 21 Jun 2023 02:22:28 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:59919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBrEX-0007Kj-JQ for 64177@debbugs.gnu.org; Wed, 21 Jun 2023 02:22:26 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Received: by mail.gandi.net (Postfix) with ESMTPSA id BC20440007; Wed, 21 Jun 2023 06:22:18 +0000 (UTC) From: Juri Linkov To: uzibalqa Subject: Re: bug#64177: outline-minor-mode-highlight fails to activate for custom headings In-Reply-To: (uzibalqa@proton.me's message of "Tue, 20 Jun 2023 20:06:23 +0000") Organization: LINKOV.NET References: <867crytzr9.fsf@mail.linkov.net> <86jzvyqdrg.fsf@mail.linkov.net> Date: Wed, 21 Jun 2023 09:13:30 +0300 Message-ID: <86o7l9wdp9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64177 Cc: 64177@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > (defvar elisp-hglevels >> > '( (";;; H1" . 1) (";;; H2" . 2) (";;; H3" . 3) (";;; H4" . 4) >> > (";;; H5" . 5) (";;; H6" . 6) (";;; H7" . 7) (";;; H8" . 8) )) >> > ... >> > ((eq major-mode 'emacs-lisp-mode) >> > ... >> > (setq outline-regexp >> > (concat (regexp-opt (mapcar 'car hrklevels)) "\\>")) >> > (setq outline-heading-alist hrklevels))) )) >> Please also try: >> >> (setq-local outline-level 'outline-level) >> >> because 'emacs-lisp-mode' overrides the default value >> with own 'lisp-outline-level'. > > Now that I have tried your suggestion, I can the the requested highlighting. > > I see that the value of outline-level is lisp-outline-level. Whereas with your change > it is outline-level. > > In principle, shouldn't outline-level be directly determined by the level specified > in outline-heading-alist ? If emacs-lisp-mode sets outline-heading-alist itself > properly then any level information can be extracted from there. Then the setup would > run more smoothly because it would be consistent with the way one would actually > customise it. This makes sense. OTOH, if we will change the logic, it might break existing code? Current situation: (defun outline-level () (or (cdr (assoc (match-string 0) outline-heading-alist)) (- (match-end 0) (match-beginning 0)))) but many modes override this default with own function that ignores outline-heading-alist: lisp-outline-level, c-outline-level, cperl-outline-level, perl-outline-level, tcl-outline-level, cfengine2-outline-level, conf-outline-level, nroff-outline-level, latex-outline-level - all these ignore outline-heading-alist. To support outline-heading-alist unconditionally the current calls (funcall outline-level) in many places should be replaced with (or (cdr (assoc (match-string 0) outline-heading-alist)) (funcall outline-level)) I don't think this is feasible, so probably we need only to add a warning to the docstring of outline-heading-alist. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 21 06:15:05 2023 Received: (at 64177) by debbugs.gnu.org; 21 Jun 2023 10:15:05 +0000 Received: from localhost ([127.0.0.1]:60695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBurg-0005Ek-M3 for submit@debbugs.gnu.org; Wed, 21 Jun 2023 06:15:04 -0400 Received: from mail-4325.protonmail.ch ([185.70.43.25]:18233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBurc-0005Ds-KS for 64177@debbugs.gnu.org; Wed, 21 Jun 2023 06:15:03 -0400 Date: Wed, 21 Jun 2023 10:14:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1687342494; x=1687601694; bh=1nkDZEnaGZ2KM206OYCWwvTFMn19sbjBM4HxLDo5ki0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=TXq2/Zx9jq/Lf88oHvHulu7S/abCpUYDfk6ANEY6UH6E3okw9VdR2paJAD66IgnOT 4xjE7uF5pI08niC1o/uC25GhzY1mU5k0QJ2C1wwE48kGhskHFDes61iQpz33FpaQsm r8eBS8NDdObdnp88YsTC5Ar0S8bJuwQlaTSqzOgwN/S2oZ3Og9VqnAEx+ZKTffmOrj BT/uwJCq1pfSNmY9aVVe0z8BbOpUg9BYtsnfizGbBfFrYMY6VTBINFQJyKFnvfa2DE YqyYF0NXwcfvjCkWd97wQ2EiQ0izC0gMYH/udbkZEymFWCRVNzavIno0IW0Z++qBNi edB9tQqiYk0DA== To: Juri Linkov From: uzibalqa Subject: Re: bug#64177: outline-minor-mode-highlight fails to activate for custom headings Message-ID: In-Reply-To: <86o7l9wdp9.fsf@mail.linkov.net> References: <867crytzr9.fsf@mail.linkov.net> <86jzvyqdrg.fsf@mail.linkov.net> <86o7l9wdp9.fsf@mail.linkov.net> Feedback-ID: 52887082:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64177 Cc: 64177@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------- Original Message ------- On Wednesday, June 21st, 2023 at 6:13 PM, Juri Linkov wro= te: > > > > (defvar elisp-hglevels > > > > '( (";;; H1" . 1) (";;; H2" . 2) (";;; H3" . 3) (";;; H4" . 4) > > > > (";;; H5" . 5) (";;; H6" . 6) (";;; H7" . 7) (";;; H8" . 8) )) > > > > ... > > > > ((eq major-mode 'emacs-lisp-mode) > > > > ... > > > > (setq outline-regexp > > > > (concat (regexp-opt (mapcar 'car hrklevels)) "\\>")) > > > > (setq outline-heading-alist hrklevels))) )) > > > > Please also try: > > >=20 > > > (setq-local outline-level 'outline-level) > > >=20 > > > because 'emacs-lisp-mode' overrides the default value > > > with own 'lisp-outline-level'. > >=20 > > Now that I have tried your suggestion, I can the the requested highligh= ting. > >=20 > > I see that the value of outline-level is lisp-outline-level. Whereas wi= th your change > > it is outline-level. > >=20 > > In principle, shouldn't outline-level be directly determined by the lev= el specified > > in outline-heading-alist ? If emacs-lisp-mode sets outline-heading-alis= t itself > > properly then any level information can be extracted from there. Then t= he setup would > > run more smoothly because it would be consistent with the way one would= actually > > customise it. >=20 >=20 > This makes sense. OTOH, if we will change the logic, it might break exist= ing code? >=20 > Current situation: >=20 > (defun outline-level () > (or (cdr (assoc (match-string 0) outline-heading-alist)) > (- (match-end 0) (match-beginning 0)))) >=20 > but many modes override this default with own function that ignores > outline-heading-alist: >=20 > lisp-outline-level, c-outline-level, cperl-outline-level, perl-outline-le= vel, > tcl-outline-level, cfengine2-outline-level, conf-outline-level, > nroff-outline-level, latex-outline-level >=20 > - all these ignore outline-heading-alist. >=20 > To support outline-heading-alist unconditionally the current calls >=20 > (funcall outline-level) >=20 > in many places should be replaced with >=20 > (or (cdr (assoc (match-string 0) outline-heading-alist)) > (funcall outline-level)) >=20 > I don't think this is feasible, so probably we need only > to add a warning to the docstring of outline-heading-alist. In the modes that override the default, outline-level could be set up to use outline-heading-alist, avoiding the conditional. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 21 11:58:33 2023 Received: (at 64177) by debbugs.gnu.org; 21 Jun 2023 15:58:33 +0000 Received: from localhost ([127.0.0.1]:34116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qC0E4-0002cI-OQ for submit@debbugs.gnu.org; Wed, 21 Jun 2023 11:58:32 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:37493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qC0E1-0002bb-Iu for 64177@debbugs.gnu.org; Wed, 21 Jun 2023 11:58:30 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Received: by mail.gandi.net (Postfix) with ESMTPSA id C3F2FC000E; Wed, 21 Jun 2023 15:58:22 +0000 (UTC) From: Juri Linkov To: uzibalqa Subject: Re: bug#64177: outline-minor-mode-highlight fails to activate for custom headings In-Reply-To: (uzibalqa@proton.me's message of "Wed, 21 Jun 2023 10:14:51 +0000") Organization: LINKOV.NET References: <867crytzr9.fsf@mail.linkov.net> <86jzvyqdrg.fsf@mail.linkov.net> <86o7l9wdp9.fsf@mail.linkov.net> Date: Wed, 21 Jun 2023 18:58:04 +0300 Message-ID: <86ttv0n82b.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64177 Cc: 64177@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> but many modes override this default with own function that ignores >> outline-heading-alist: >> >> lisp-outline-level, c-outline-level, cperl-outline-level, perl-outline-level, >> tcl-outline-level, cfengine2-outline-level, conf-outline-level, >> nroff-outline-level, latex-outline-level >> >> - all these ignore outline-heading-alist. > > In the modes that override the default, outline-level could be > set up to use outline-heading-alist, avoiding the conditional. Patches are welcome to support outline-heading-alist in the aforementioned functions. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 22 14:58:17 2023 Received: (at control) by debbugs.gnu.org; 22 Jun 2023 18:58:17 +0000 Received: from localhost ([127.0.0.1]:36748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCPVZ-00007I-EC for submit@debbugs.gnu.org; Thu, 22 Jun 2023 14:58:17 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:54817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCPVW-00006u-At; Thu, 22 Jun 2023 14:58:16 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Received: by mail.gandi.net (Postfix) with ESMTPSA id EB3FB1BF204; Thu, 22 Jun 2023 18:58:06 +0000 (UTC) From: Juri Linkov To: uzibalqa Subject: Re: bug#64227: Setting of outline levels for custom headings In-Reply-To: (uzibalqa via's message of "Thu, 22 Jun 2023 16:18:59 +0000") Organization: LINKOV.NET References: Date: Thu, 22 Jun 2023 21:56:41 +0300 Message-ID: <86zg4ruxzq.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control Cc: 64227@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) forcemerge 64177 64227 stop > I am using outline-minor-mode and have changed outline-regexp, outline-heading-alist. > > Have seen that for some major modes (e.g. emacs-lisp-mode), with outline-minor-mode-highlight > set to 'override nil), one has to call (setq-local outline-level 'outline-level) for the > heading faces to take effect. > > But without the call to outline-minor-mode-highlight, the headings defined by outline-regexp > still get recognised, but not the outline levels. > > It is not evident at this point, which major modes require a call to (setq-local outline-level 'outline-level). > There is not enough information in the documentation to get a custom headings setup operational. > > Furthermore, although a call to (setq-local outline-level 'outline-level) solved the problem, > a better approach would be for outline-minor-mode to automatically detect whether a custom heading > was specified, and thus act accordingly. It would be quite a struggle for people to perceive the > need to call (setq-local outline-level 'outline-level), as the change is only needed for certain > major modes only. Why are you creating a new bug report instead of replying to the existing? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 08:22:06 2023 Received: (at 64177) by debbugs.gnu.org; 24 Jun 2023 12:22:06 +0000 Received: from localhost ([127.0.0.1]:40052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD2HG-0006RF-6R for submit@debbugs.gnu.org; Sat, 24 Jun 2023 08:22:06 -0400 Received: from mail-4319.protonmail.ch ([185.70.43.19]:27063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD2HC-0006QT-Kn for 64177@debbugs.gnu.org; Sat, 24 Jun 2023 08:22:04 -0400 Date: Sat, 24 Jun 2023 12:21:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1687609316; x=1687868516; bh=otvFqNT1lKDGwVuMjmYPm7m/Z8PPHBfcsbYO75EUeho=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=QouNMlBE//+d7U4cu43kMSWO5um5ONtJH3i92KiSEw6916zq40igXUmNBC0ApoF0b ybE1qmLO2S2x9N+U5FdGMExx2TxouWmSjaxZO6seeaMbkxcfG7tCp8hKU+2nTsAOi9 aMoxJDrNPWlfyIJ4oUXrxfPF8k6HoOII2h+IaQD4iEZ8j4jSSom/6pA897eziD0ByC DVPiY54EZ1BbJDirAfXOSSgfQTpfllBWbPVlilU6ExQv3bmdcAFFKP1l73L/4ZEaKq 3tjSfQTg899xy9QItKU9qOXYbBmGerMOiKTsGGyLsUp+TCW3k3JSDrngHkgQW2SKJz AzhzLEM7q3eTQ== To: Juri Linkov From: uzibalqa Subject: Re: bug#64177: outline-minor-mode-highlight fails to activate for custom headings Message-ID: In-Reply-To: <86ttv0n82b.fsf@mail.linkov.net> References: <867crytzr9.fsf@mail.linkov.net> <86jzvyqdrg.fsf@mail.linkov.net> <86o7l9wdp9.fsf@mail.linkov.net> <86ttv0n82b.fsf@mail.linkov.net> Feedback-ID: 52887082:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64177 Cc: 64177@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------- Original Message ------- On Thursday, June 22nd, 2023 at 3:58 AM, Juri Linkov wrot= e: > > > but many modes override this default with own function that ignores > > > outline-heading-alist: > > >=20 > > > lisp-outline-level, c-outline-level, cperl-outline-level, perl-outlin= e-level, > > > tcl-outline-level, cfengine2-outline-level, conf-outline-level, > > > nroff-outline-level, latex-outline-level > > >=20 > > > - all these ignore outline-heading-alist. > >=20 > > In the modes that override the default, outline-level could be > > set up to use outline-heading-alist, avoiding the conditional. >=20 >=20 > Patches are welcome to support outline-heading-alist in the > aforementioned functions. How does emacs-lisp-mode handle outline headings ? Always setting the defaults first, then the user can reset the variables outline-regexp,=20 outline-heading-alist, and outline-level before enabling outline-minor-mode= ? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 25 13:27:47 2023 Received: (at 64177-done) by debbugs.gnu.org; 25 Jun 2023 17:27:47 +0000 Received: from localhost ([127.0.0.1]:43628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDTWd-0006xV-Go for submit@debbugs.gnu.org; Sun, 25 Jun 2023 13:27:47 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:48659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDTWa-0006x6-1P for 64177-done@debbugs.gnu.org; Sun, 25 Jun 2023 13:27:45 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Received: by mail.gandi.net (Postfix) with ESMTPSA id B7DAA40003; Sun, 25 Jun 2023 17:27:36 +0000 (UTC) From: Juri Linkov To: uzibalqa Subject: Re: bug#64177: outline-minor-mode-highlight fails to activate for custom headings In-Reply-To: (uzibalqa@proton.me's message of "Sat, 24 Jun 2023 12:21:47 +0000") Organization: LINKOV.NET References: <867crytzr9.fsf@mail.linkov.net> <86jzvyqdrg.fsf@mail.linkov.net> <86o7l9wdp9.fsf@mail.linkov.net> <86ttv0n82b.fsf@mail.linkov.net> Date: Sun, 25 Jun 2023 20:13:31 +0300 Message-ID: <86y1k7pqn0.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64177-done Cc: 64177-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > How does emacs-lisp-mode handle outline headings ? Always setting the > defaults first, then the user can reset the variables outline-regexp, > outline-heading-alist, and outline-level before enabling outline-minor-mode ? Yes, you need to set the variables outline-regexp, outline-heading-alist, and outline-level before enabling outline-minor-mode. Since you have a working solution now, I'm closing this request. From unknown Sun Jun 22 19:07:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 24 Jul 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator