GNU bug report logs - #64173
[PATCH 0/1] guix: pack: add --entry-point-argument option

Previous Next

Full log

View this message in rfc822 format

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Graham James Addis <graham <at> addis.org.uk>, Josselin Poiret <dev <at> jpoiret.xyz>, Christopher Baines <mail <at> cbaines.net>, 64173 <at> debbugs.gnu.org, Mathieu Othacehe <othacehe <at> gnu.org>, Graham James Addis <grahamjamesaddis <at> gmail.com>, Tobias Geerinckx-Rice <me <at> tobias.gr>, 64171 <at> debbugs.gnu.org, Ricardo Wurmus <rekado <at> elephly.net>
Subject: [bug#64173] [PATCH 0/1] guix: pack: add --entry-point-argument option
Date: Fri, 18 Aug 2023 16:15:08 +0200

Hi,

On Fri, 18 Aug 2023 at 16:00, Ludovic Courtès <ludo <at> gnu.org> wrote:

> > Well, since the order of the various command-line arguments might
> > matter, and since a ’reverse’ is suggested, and since all the Guix
> > command-lines do not behave the same way – for instance “guix package”
> > processes command-line argument from right to left; see #43585 or #50473
> > [1,2]; anyway :-) – I would suggest to add a sentence in the
> > documentation (manual) that the command-line arguments are parsed from
> > left to right.
>
> No: the ‘reverse’ puts them back in the right order (because
> ‘args-fold*’ traverses the option list from left to right and thus
> conses the result in reverse order.)

Is "no" for not adding a sentence in the documentation? :-)

BTW, what means the "right order"? :-)
I point that "guix package" and "guix show" process the command-line
option in different order -- from right to left vs from left to right
respectively.  Thus, this "right order" you are assuming can be
confusing, IMHO.

Therefore, applying POLA, it appears to me worth to add under the
option description of this new "--entry-point-argument" in the manual:
"The @code{--entry-point-arguement} option is applied from left to
right."  Or something along this line.

My 2 cents.

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.