GNU bug report logs - #64160
master; Implement various enhancements in ldap.el and EUDC

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64160 in the body.
You can then email your comments to 64160 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: bug-gnu-emacs <at> gnu.org
Subject: master; Implement various enhancements in ldap.el and EUDC
Date: Sun, 18 Jun 2023 23:52:37 +0200

This is a tracking bug for various enhancements in ldap.el and EUDC,
please do not close until further notice.

Some of my intentions:

- Add an additional front-end to EUDC, more user-friendly and dwimmy
  than `eudc-query-form'.

- Add commands in EUDC to traverse the management hierarchy of
  some organization.

- Extensions in particular to ldap.el to support above:

  + extension of the WITHDN parameter, since that is often (?) used
    to establish manager <=> reports relations

  + modernization of the code in `ldap-search-internal' to
    read LDAP attributes with less temporary files being created

  + option to return attributes in some specified order

This is also related to bug#64089, which I thought to be the starting
point of these enhancements.

Message #8 received at 64160 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: Filipp Gunbin <fgunbin <at> fastmail.fm>
Cc: 64160 <at> debbugs.gnu.org
Subject: Re: bug#64089: 30.0.50; `ldap-search' errors out with
 `wrong-type-argument listp' when called WITHDN == t
Date: Mon, 19 Jun 2023 00:14:34 +0200

Hi Filipp,

On 2023-06-18  09:43, Jens Schmidt wrote:

> [...]  In any case, I'll open a new bug for that to continue this 
> discussion.

here is the bug I've opened as master tracking bug: bug#64160 (CCed as
well).

I'd appreciate contributing together with you, and your hint on the role 
of `ldap-ignore-attribute-codings' was really helpful, thanks.  But some 
others of the changes you have been proposing were not very helpful for 
what I have in mind.  For example:

> 3) (unrelated, just noticed and fixed) Match data clobbering in this
> piece:
>
> -            ;; Need to handle file:///D:/... as generated by OpenLDAP
> -            ;; on DOS/Windows as local files.
> -            (if (and (memq system-type '(windows-nt ms-dos))
> -                     (eq (string-match "/\\(.:.*\\)$" value) 0))
> -                (setq value (match-string 1 value)))

This piece of code handling temp files on DOS/Windows should in my 
opinion be moved into the following `(if (match-string 3) ...' clause, 
which handles temp files in general.  (In that case the 
`save-match-data' would no longer be required, BTW.)

On 2023-06-17  00:13, Filipp Gunbin wrote:

> Please give it a try, if it's OK and others have no objections, I'll
> install it on Monday (on master, I guess).

So could you please wait with your commit until we have something worked 
out that works for all?

Thanks!

Message #11 received at 64160 <at> debbugs.gnu.org (full text, mbox):

From: Filipp Gunbin <fgunbin <at> fastmail.fm>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 64160 <at> debbugs.gnu.org
Subject: Re: bug#64089: 30.0.50; `ldap-search' errors out with
 `wrong-type-argument listp' when called WITHDN == t
Date: Mon, 19 Jun 2023 17:11:55 +0300

Hi Jens,

On 19/06/2023 00:14 +0200, Jens Schmidt wrote:

> Hi Filipp,
>
> On 2023-06-18  09:43, Jens Schmidt wrote:
>
>> [...]  In any case, I'll open a new bug for that to continue this
>> discussion.
>
> here is the bug I've opened as master tracking bug: bug#64160 (CCed as
> well).

I think I'll merge that into this bug - no need for two bugs, the issue
is the same.

Regarding your proposal from the other message:

> I think we should account (in emacs-master) for these various options
> and make WITHDN take various values:
> 
>   `cons'   - return my interpretation
>   `string' - return yours
>   t        - return Gerd's

This is overkill in my eyes, as we don't have enough user feedback to
request for those options.

> I'd appreciate contributing together with you, and your hint on the
> role of `ldap-ignore-attribute-codings' was really helpful, thanks.
> But some others of the changes you have been proposing were not very
> helpful for what I have in mind.  For example:
>
>> 3) (unrelated, just noticed and fixed) Match data clobbering in this
>> piece:
>>
>> -            ;; Need to handle file:///D:/... as generated by OpenLDAP
>> -            ;; on DOS/Windows as local files.
>> -            (if (and (memq system-type '(windows-nt ms-dos))
>> -                     (eq (string-match "/\\(.:.*\\)$" value) 0))
>> -                (setq value (match-string 1 value)))
>
> This piece of code handling temp files on DOS/Windows should in my
> opinion be moved into the following `(if (match-string 3) ...' clause,
> which handles temp files in general.  (In that case the
> `save-match-data' would no longer be required, BTW.)

Yes, it could, I just rather avoid moving code where it's not very
necessary.

> On 2023-06-17  00:13, Filipp Gunbin wrote:
>
>> Please give it a try, if it's OK and others have no objections, I'll
>> install it on Monday (on master, I guess).
>
> So could you please wait with your commit until we have something
> worked out that works for all?

So what problem is left now for you?

I think we should leave emacs-29 out, so, after you write back, I'm
intending to:

- Fix what else you report (if anything)

- Revert what was installed on emacs-29.  It seems that the correct fix
  would not be trivial enough.

- Install full fix on master - we can discuss which version, however I
  don't see strong benefits of one vs. the other, so let's save time.

Thanks.

Message #14 received at 64160 <at> debbugs.gnu.org (full text, mbox):

From: Filipp Gunbin <fgunbin <at> fastmail.fm>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 64160 <at> debbugs.gnu.org
Subject: Re: bug#64160: master; Implement various enhancements in ldap.el
 and EUDC
Date: Mon, 19 Jun 2023 18:13:23 +0300

>> here is the bug I've opened as master tracking bug: bug#64160 (CCed as
>> well).
>
> I think I'll merge that into this bug - no need for two bugs, the issue
> is the same.

Ok, I now see that it's about different things, let's move back this
discussion to 64089.

Message #17 received at 64160 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: Filipp Gunbin <fgunbin <at> fastmail.fm>
Cc: 64160 <at> debbugs.gnu.org
Subject: Re: bug#64160: master; Implement various enhancements in ldap.el and
 EUDC
Date: Mon, 19 Jun 2023 23:16:58 +0200

On 2023-06-19  17:13, Filipp Gunbin wrote:

> Ok, I now see that it's about different things, let's move back this 
> discussion to 64089.

Problem is that the result of my plans in bug#64160 would be more or
less a complete rewrite of `ldap-search-internal'.  For example, our
LDAP server returns underscores in its attribute names, which I would
have accounted for ... in a clean and configurable way and strictly
backward compatible, of course.  I'd like to optionally have the record
attributes sorted in the order they came in from EUDC.  I'd like to
optionally get rid of temporary files, since Emacs should be more than
capable to parse the base64-encoded attributes instead.  And so on and 
so forth ... there is really much room for improvement in that function.

Now from your previous comments I got the impression that we have a
different approach on coding and that you are somewhat opposed to changes.

So I'd rather leave the changes in my private repository and save us
both time and energy.

Feel free to close this bug.

Message #20 received at 64160 <at> debbugs.gnu.org (full text, mbox):

From: Filipp Gunbin <fgunbin <at> fastmail.fm>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 64160 <at> debbugs.gnu.org
Subject: Re: bug#64160: master; Implement various enhancements in ldap.el
 and EUDC
Date: Tue, 20 Jun 2023 17:11:59 +0300

Hi Jens,

On 19/06/2023 23:16 +0200, Jens Schmidt wrote:

> On 2023-06-19  17:13, Filipp Gunbin wrote:
>
>> Ok, I now see that it's about different things, let's move back this
>> discussion to 64089.
>
> Problem is that the result of my plans in bug#64160 would be more or
> less a complete rewrite of `ldap-search-internal'.  For example, our
> LDAP server returns underscores in its attribute names, which I would
> have accounted for ... in a clean and configurable way and strictly
> backward compatible, of course.  I'd like to optionally have the record
> attributes sorted in the order they came in from EUDC.  I'd like to
> optionally get rid of temporary files, since Emacs should be more than
> capable to parse the base64-encoded attributes instead.  And so on and
> so forth ... there is really much room for improvement in that
> function.
>
> Now from your previous comments I got the impression that we have a
> different approach on coding and that you are somewhat opposed to changes.
>
> So I'd rather leave the changes in my private repository and save us
> both time and energy.
>
> Feel free to close this bug.

No, that's not my position to be opposed to changes.  Patches are always
welcome.  I just keep in mind that who knows which ldap servers are
deployed out there (and clients, but I guess OpenLDAP is de facto
standart now), and we should be careful when changing things.  Also,
it's worth noting that seemingly few people use ldap.el, so we won't
notice the break immediately, but rather when Emacs release comes out.

Let's discuss each issue separately, as they arise, and see what comes
out.  From what you described - that certainly doesn't look like a
"complete rewrite".

I'd just like to note that perhaps I will be opposed to getting rid of
temporary files.  process-connection-type is not forced to pipe, so you
may have tty sometimes, and receiving binary data over it is not
reliable.

Thanks,
Filipp

Message #27 received at 64160-done <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: 64160-done <at> debbugs.gnu.org
Subject: Re: bug#64160: master; Implement various enhancements in ldap.el and
 EUDC
Date: Wed, 21 Jun 2023 00:23:03 +0200

Closing this bug since I don't have the time to follow up on it myself 
as needed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.