GNU bug report logs - #6415
23.1.50; edebug-eval-defun errors on dotted pair in some macros

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Gemini Lasswell <gazally <at> runbox.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#15587: closed ([PATCH] Edebug `destructuring-bind' dotted spec)
Date: Sun, 26 Nov 2017 23:03:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 26 Nov 2017 15:02:27 -0800
with message-id <871skkr6d8.fsf <at> runbox.com>
and subject line Re: bug#6415: [PATCH] fix edebug instrumentation of dotted pairs in macros
has caused the debbugs.gnu.org bug report #6415,
regarding [PATCH] Edebug `destructuring-bind' dotted spec
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
6415: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6415
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Oleh <oleh.krehel <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Edebug `destructuring-bind' dotted spec
Date: Fri, 11 Oct 2013 12:39:37 +0200

[Message part 3 (text/plain, inline)]

Hi,

Currently it's not possible to edebug

(defun foo (z)
  (destructuring-bind (x . y) z (+ x y)))

I attach a small patch to fix this.

[0001-emacs-lisp-cl-macs.el-cl-destructuring-bind-added-do.patch (text/x-diff, inline)]

From 51a191c06f210eecf594be384e9b835afb9a818f Mon Sep 17 00:00:00 2001
From: Oleh Krehel <ohwoeowho <at> gmail.com>
Date: Fri, 11 Oct 2013 12:34:03 +0200
Subject: [PATCH] * emacs-lisp/cl-macs.el: (cl-destructuring-bind): added
 dotted form as an option for edebug.

Edebug will now work for:

(defun foo (z)
  (destructuring-bind (x . y) z (+ x y)))
---
 emacs-lisp/cl-macs.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs-lisp/cl-macs.el b/emacs-lisp/cl-macs.el
index 60fdc09..a84e677 100644
--- a/emacs-lisp/cl-macs.el
+++ b/emacs-lisp/cl-macs.el
@@ -565,7 +565,7 @@ its argument list allows full Common Lisp conventions."
 (defmacro cl-destructuring-bind (args expr &rest body)
   "Bind the variables in ARGS to the result of EXPR and execute BODY."
   (declare (indent 2)
-           (debug (&define cl-macro-list def-form cl-declarations def-body)))
+           (debug (&define [&or cl-macro-list (sexp . sexp)] def-form cl-declarations def-body)))
   (let* ((cl--bind-lets nil) (cl--bind-forms nil) (cl--bind-inits nil)
 	 (cl--bind-defs nil) (cl--bind-block 'cl-none) (cl--bind-enquote nil))
     (cl--do-arglist (or args '(&aux)) expr)
-- 
1.8.4

[Message part 5 (text/plain, inline)]

regards,
Oleh

[Message part 6 (message/rfc822, inline)]

From: Gemini Lasswell <gazally <at> runbox.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 6415-done <at> debbugs.gnu.org, Steve Yegge <stevey <at> google.com>
Subject: Re: bug#6415: [PATCH] fix edebug instrumentation of dotted pairs in
 macros
Date: Sun, 26 Nov 2017 15:02:27 -0800

Gemini Lasswell <gazally <at> runbox.com> writes:

> Here's a new patch for this bug, based on the ideas in Steve's patch.

I've pushed this patch to emacs-26.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.