Subject: Re: bug#64147: 30.0.50; Crash when deleting fullscreen frame on macOS

From: Eli Zaretskii <[email-masked]>
Date: Mon, 19 Jun 2023 19:21:35 +0300

> Cc: [email-masked]
> Date: Mon, 19 Jun 2023 07:15:53 +0300
> From:  Eshel Yaron via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <[email-masked]>
> 
> Daniel Martín <[email-masked]> writes:
> 
> > In ns_free_frame_resources, the frame's window is closed, but the view
> > is not removed from the hierarchy, meaning that it could be called by
> > AppKit.  That is problematic, because the frame's output_data is
> > nullified just a few lines later.
> >
> > Does the following patch (on top of master) solve the problem?
> >
> > diff --git a/src/nsterm.m b/src/nsterm.m
> > index 3e089cc1ff1..2c0c90e70e1 100644
> > --- a/src/nsterm.m
> > +++ b/src/nsterm.m
> > @@ -1624,7 +1624,7 @@ Hide the window (X11 semantics)
> >      [f->output_data.ns->miniimage release];
> >  
> >    [[view window] close];
> > -  [view release];
> > +  [view removeFromSuperview];
> >  
> >    xfree (f->output_data.ns);
> >    f->output_data.ns = NULL;
> 
> Yes, this seems to solve it, thanks!

Great, so please install it (on the emacs-29 branch, if the problem
happens there as well).

Thanks.