GNU bug report logs - #64143
29.0.60; find-function-search-for-symbol truncates library path

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64143: closed (29.0.60; find-function-search-for-symbol
 truncates library path)
Date: Tue, 20 Jun 2023 13:37:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 20 Jun 2023 16:36:52 +0300
with message-id <83wmzy5k7f.fsf <at> gnu.org>
and subject line Re: bug#64143: 29.0.60; find-function-search-for-symbol truncates library path
has caused the debbugs.gnu.org bug report #64143,
regarding 29.0.60; find-function-search-for-symbol truncates library path
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64143: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64143
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Troy Brown <brownts <at> troybrown.dev>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; find-function-search-for-symbol truncates library path
Date: Sun, 18 Jun 2023 00:45:12 -0400

When user-emacs-directory contains "emacs.el" in it's path (e.g.,
"~/.emacs.elpa"), which is much easier these days with the availability
of --init-directory, the find-function-search-for-symbol truncates the
library path after "emacs".

I was experimenting with a different user directory (i.e.,
"--init-directory=~/.emacs.elpa") and was surprised to find out that the
Help system was breaking when using this path.  When looking up a symbol
in the Help system (e.g., "C-h f company-mode RET") and then attempting
to visit the source file from the help window (i.e., help-view-source),
if the symbol belongs to an installed package (where the source is
under the "elpa" directory beneath user-emacs-directory), it will
generate the following error message:

  Can't find library: /home/troy/.emacs

Toggling "debug-on-error" and repeating the above, I can generate a
backtrace for this as follows:

Debugger entered--Lisp error: (file-error "Can't find library"
"/home/troy/.emacs")
  find-library-name("/home/troy/.emacs")
  #<subr find-function-search-for-symbol>(company-mode nil
"/home/troy/.emacs.elpa/elpa/company-20230416.2034/company.el")
  ad-Advice-find-function-search-for-symbol(#<subr
find-function-search-for-symbol> company-mode nil
"/home/troy/.emacs.elpa/elpa/company-20230416.2034/company.el")
  apply(ad-Advice-find-function-search-for-symbol #<subr
find-function-search-for-symbol> (company-mode nil
"/home/troy/.emacs.elpa/elpa/company-20230416.2034/company.el"))
  find-function-search-for-symbol(company-mode nil
"/home/troy/.emacs.elpa/elpa/company-20230416.2034/company.el")
  help-function-def--button-function(company-mode
"/home/troy/.emacs.elpa/elpa/company-20230416.2034/company.el" nil)
  help-view-source()
  funcall-interactively(help-view-source)
  call-interactively(help-view-source nil nil)
  command-execute(help-view-source)

I believe the following snippet of code in
find-function-search-for-symbol is to blame for this:

    (when (string-match "\\.emacs\\(.el\\)" library)
      (setq library (substring library 0 (match-beginning 1))))

The regex likely should be improved to only match .emacs or .emacs.el at
the end of the path, not in the middle of it.

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Troy Brown <brownts <at> troybrown.dev>
Cc: 64143-done <at> debbugs.gnu.org
Subject: Re: bug#64143: 29.0.60; find-function-search-for-symbol truncates
 library path
Date: Tue, 20 Jun 2023 16:36:52 +0300

> From: Troy Brown <brownts <at> troybrown.dev>
> Date: Sun, 18 Jun 2023 13:39:05 -0400
> Cc: 64143 <at> debbugs.gnu.org
> 
> > Does the patch below fix this problem?
> >
> 
> Indeed, it does.

Thanks, installed on the emacs-29 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.