From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Jun 2010 18:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6414 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6414@debbugs.gnu.org X-Debbugs-Original-To: Emacs Bugs Received: via spool by submit@debbugs.gnu.org id=B.127645212725435 (code B ref -1); Sun, 13 Jun 2010 18:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jun 2010 18:02:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONrVX-0006cC-6K for submit@debbugs.gnu.org; Sun, 13 Jun 2010 14:02:07 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONrVV-0006bo-Po for submit@debbugs.gnu.org; Sun, 13 Jun 2010 14:02:06 -0400 Received: from lists.gnu.org ([199.232.76.165]:39047) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ONrVR-0006am-A6 for submit@debbugs.gnu.org; Sun, 13 Jun 2010 14:02:01 -0400 Received: from [140.186.70.92] (port=40155 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONrVQ-0005M4-0S for bug-gnu-emacs@gnu.org; Sun, 13 Jun 2010 14:02:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ONrVO-0008T2-4X for bug-gnu-emacs@gnu.org; Sun, 13 Jun 2010 14:01:58 -0400 Received: from mail-gw0-f41.google.com ([74.125.83.41]:55693) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONrVO-0008Sr-2I for bug-gnu-emacs@gnu.org; Sun, 13 Jun 2010 14:01:58 -0400 Received: by gwaa18 with SMTP id a18so1735045gwa.0 for ; Sun, 13 Jun 2010 11:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=bx1I08DXGkZLJULe/JePthdJgDMJSzNxLp3tar89Vow=; b=sjF/vTeuY2q9w3BOUlfwI2ljhZ0PnAbV8GvjKxHRlaP1Jt/AIlA8Of7vTOslflxlYu t5VRqWrcbo8FU8JmpmFShEX+nEbdBVdbfpCwf18gNXywOtuhHrhwWOBnXV55zHBBH8fm mzrgNFux1kRhcqmMBbJFvkkV5+rG2KGmxT094= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=lfxkF5y11uh6GeB6ed0ndPevX30KjVJlhTLAKkOGeyVnsK6gGRtjwkt8/aGzoLQ4hV RTD+pSc+1Lx+c8wApLbYIxM8Q5zmJwfRpbTk99VNdb3EMDfyG7tnfSLC+KV0C9Q84ohW WNSlrLK4bFjdoIIfOgAIXW0FrnPRhAm90/N9A= Received: by 10.101.191.4 with SMTP id t4mr3925705anp.214.1276452117190; Sun, 13 Jun 2010 11:01:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.15 with HTTP; Sun, 13 Jun 2010 11:01:37 -0700 (PDT) From: Lennart Borgman Date: Sun, 13 Jun 2010 20:01:37 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) I noticed some system call errors in free_frame_menu_bar so I tried to nail it down: void free_frame_menubar (f) FRAME_PTR f; { BLOCK_INPUT; { HMENU old = GetMenu (FRAME_W32_WINDOW (f)); DebPrint (("free_frame_menubar.GetMenu.old=%d, f=%d, menubar_widget=%d", old, (FRAME_W32_WINDOW (f)), f->output_data.w32->menubar_widget )); if (old) { if (!SetMenu (FRAME_W32_WINDOW (f), NULL)) W32ASSERT (0, "free_frame_menubar.SetMenu"); f->output_data.w32->menubar_widget = NULL; if (!DestroyMenu (old)) W32ASSERT (0, "free_frame_menubar.DestroyMenu"); } } UNBLOCK_INPUT; } This gave me the output below which seems to indicate that menubar_widget is uninitialized: warning: free_frame_menubar.GetMenu.old=0, f=3146106, menubar_widget=329385 Where should it be initialized? From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Jun 2010 18:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.127645394726414 (code B ref 6414); Sun, 13 Jun 2010 18:33:01 +0000 Received: (at 6414) by debbugs.gnu.org; 13 Jun 2010 18:32:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONryt-0006rz-0z for submit@debbugs.gnu.org; Sun, 13 Jun 2010 14:32:27 -0400 Received: from mail-gw0-f44.google.com ([74.125.83.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONryq-0006rs-V3 for 6414@debbugs.gnu.org; Sun, 13 Jun 2010 14:32:25 -0400 Received: by gwj16 with SMTP id 16so2090270gwj.3 for <6414@debbugs.gnu.org>; Sun, 13 Jun 2010 11:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=Wy7jBzoAOgDp6R2Q3NlJg3XmGJRno+1nLE3ah2otxxg=; b=lzKR31TnH55J1ySGYv3XxRHpM3C9zg+JQyH5u928i1+5BTE0JojY2fzOcNrpUe504U jD4LJqwGc7ijVAvwDbuvQHPf5YiJzGgDE+G9jxNN+sSbwKSHmhY/X+UgfcoSXL2OVzDd GKG8P36kEC0eOKL8HOcbO4oL1lvmHRHwG5i7k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=kioSCQEZ6KRejJ4cJlWLc2SrH8iDdfxXoD8a34a9m3T4/kAF56UIDeZLHriP5L15yZ K2VM1l/6xSg5lcFSDwPmlS4Vm1LGxG30EFzLM4LVdjLt1hSPE/F1lcivXBYFJgJu4LDc NzV4FTzoHXuHaf2WjaWe+R1DMKA/8ertYbvjw= Received: by 10.100.245.35 with SMTP id s35mr3909335anh.71.1276453940218; Sun, 13 Jun 2010 11:32:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.15 with HTTP; Sun, 13 Jun 2010 11:32:00 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Sun, 13 Jun 2010 20:32:00 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On Sun, Jun 13, 2010 at 8:01 PM, Lennart Borgman wrote: > > This gave me the output below which seems to indicate that > menubar_widget is uninitialized: > > =C2=A0warning: free_frame_menubar.GetMenu.old=3D0, f=3D3146106, menubar_w= idget=3D329385 > > Where should it be initialized? Looks like it is initialized at line 4928 in Fx_create_frame in w32fns.c so the problem must come in later. From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Jun 2010 18:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.127645489826979 (code B ref 6414); Sun, 13 Jun 2010 18:49:02 +0000 Received: (at 6414) by debbugs.gnu.org; 13 Jun 2010 18:48:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONsEE-000716-01 for submit@debbugs.gnu.org; Sun, 13 Jun 2010 14:48:18 -0400 Received: from mail-gw0-f44.google.com ([74.125.83.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONsEB-000711-QD for 6414@debbugs.gnu.org; Sun, 13 Jun 2010 14:48:16 -0400 Received: by gwj16 with SMTP id 16so2094851gwj.3 for <6414@debbugs.gnu.org>; Sun, 13 Jun 2010 11:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=Yfb6U0MAm3k6HsMY243WWiAu72pEseR1iURUi+n1010=; b=DYe3ZVP4onoK40VkoTimMwG3+xpB4fzPT9ve5EYJE6nCW1C5hCjkQqzeZ2vT/RTp43 SXiRYTtjai9jDou2ffTc15nsgwKLYdapN/M9qxUKkr/RKUvv9KZcXIhU57mRNEgfJuzN rVKSZJfHCY8u0fxQWGpTMTTMafH8vsLc+hFQo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=SejE5lRgDaTcwv57wa0gF+ENThwPj4pSHeM09KLHKNIFWy8zBCzRK3BfP2W39fLpoY T5aEI156lMyUx099xoLN8Y59cbepNUBQBbYiGEn94tDCMQdh6IYsige8Md3POCZe6KZS jLokr5ih7szCWSEWWp0UbqHWPz1MbZUU/qYdA= Received: by 10.101.170.33 with SMTP id x33mr1515895ano.265.1276454891096; Sun, 13 Jun 2010 11:48:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.15 with HTTP; Sun, 13 Jun 2010 11:47:51 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Sun, 13 Jun 2010 20:47:51 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On Sun, Jun 13, 2010 at 8:32 PM, Lennart Borgman wrote: > On Sun, Jun 13, 2010 at 8:01 PM, Lennart Borgman > wrote: >> >> This gave me the output below which seems to indicate that >> menubar_widget is uninitialized: >> >> =C2=A0warning: free_frame_menubar.GetMenu.old=3D0, f=3D3146106, menubar_= widget=3D329385 >> >> Where should it be initialized? > > > Looks like it is initialized at line 4928 in Fx_create_frame in > w32fns.c so the problem must come in later. The problem seems to be in x_free_frame_resources. Should not free_frame_menubar be called before my_destroy_window there? From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2011 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lennart Borgman Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130971931315242 (code B ref 6414); Sun, 03 Jul 2011 18:56:02 +0000 Received: (at 6414) by debbugs.gnu.org; 3 Jul 2011 18:55:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdRp2-0003xl-Ia for submit@debbugs.gnu.org; Sun, 03 Jul 2011 14:55:12 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdRp1-0003xX-1Q for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 14:55:12 -0400 Received: by pzk5 with SMTP id 5so27108pzk.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 11:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=/c6CnOAFBtdxs00YaG7xH3zC1EyzGsEEv9hp34+LCRk=; b=U8CoepJbSo6nKBqkjOrNEcADDifcmwl9NeAZrvnYXHR+BhwwN3U5NrPYhwbjFhwqYU W69LdSIPJxTkGVZjRBqyEaHKLNBiHrFXlSuKmoo3iz0p1IDQ4dUdOu9J3qOMLK6yqdVQ ZRikyvs2ZlyHJ7eqptO3olbFaGwfkWRtCCYCk= Received: by 10.143.12.16 with SMTP id p16mr2466182wfi.50.1309719305158; Sun, 03 Jul 2011 11:55:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.48.6 with HTTP; Sun, 3 Jul 2011 11:54:25 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Sun, 3 Jul 2011 20:54:25 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Sun, Jun 13, 2010 at 20:47, Lennart Borgman wrote: > The problem seems to be in x_free_frame_resources. Should not > free_frame_menubar be called before my_destroy_window there? You reported seeing some system call errors, presumably under a debugger or with DebPrint statements. Did you see any bug? If so, can you please send a recipe to reproduce it starting with emacs -Q? =C2=A0 =C2=A0 Juanma From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2011 22:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130973162713319 (code B ref 6414); Sun, 03 Jul 2011 22:21:01 +0000 Received: (at 6414) by debbugs.gnu.org; 3 Jul 2011 22:20:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdV1e-0003Sk-L4 for submit@debbugs.gnu.org; Sun, 03 Jul 2011 18:20:26 -0400 Received: from mail-ew0-f44.google.com ([209.85.215.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdV1d-0003SY-3s for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 18:20:25 -0400 Received: by ewy19 with SMTP id 19so1925479ewy.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 15:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=8jb0Mq7SWFroztqZeU0b49E/D6BjSUfAtkFtcUn7pHI=; b=jUXtFbljJO7UnEY4zlBaeQ8kzfM+iONBuf5LetTRQiRPy6S3iXU1d4VfK2+f58zjjt cxXlfwcPkYckfZ12056W4+feDJoFmjqS7i+w0MJTJtR6PwKxjMCajxrED+bDesEbMFZE 7CXWAcKC6Q5awNgexgwA8JQtaurhZhrlXIzvY= Received: by 10.213.35.202 with SMTP id q10mr1212906ebd.64.1309731619122; Sun, 03 Jul 2011 15:20:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.7.84 with HTTP; Sun, 3 Jul 2011 15:19:59 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Mon, 4 Jul 2011 00:19:59 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Sun, Jul 3, 2011 at 20:54, Juanma Barranquero wrote: > On Sun, Jun 13, 2010 at 20:47, Lennart Borgman > wrote: > >> The problem seems to be in x_free_frame_resources. Should not >> free_frame_menubar be called before my_destroy_window there? > > You reported seeing some system call errors, presumably under a > debugger or with DebPrint statements. Did you see any bug? If so, can > you please send a recipe to reproduce it starting with emacs -Q? I can't do much to check it now. I do not have time to setup the required environment on my new pc now. However I think it is also very difficult to catch such errors. They are likely to be race conditions (since w32 messages from different sources are involved). So I think it is better to check the logic. (As I have tried to above.) And I also still think it is a good idea to add check for error conditions after all system calls. (For the same reason as above.) From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2011 22:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lennart Borgman Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130973226717381 (code B ref 6414); Sun, 03 Jul 2011 22:32:01 +0000 Received: (at 6414) by debbugs.gnu.org; 3 Jul 2011 22:31:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVBy-0004WI-Sp for submit@debbugs.gnu.org; Sun, 03 Jul 2011 18:31:07 -0400 Received: from mail-pv0-f172.google.com ([74.125.83.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVBw-0004Vp-Eu for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 18:31:05 -0400 Received: by pvh18 with SMTP id 18so4366788pvh.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 15:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=foxssJj1Px96Rkrq5czznC9KbJujnWqttEebhAx6mbk=; b=sAhck3eHJb7LYaKMVjAGE4mf//8AhLlz+QTWJof1cqN0DmpgkyYVRZ4TYF0gObgk0n 4l36dEYbOU+uaHkBDn7YUSVG8OUzBSrr9KcaZSBDEz8eQKsRzd3ILqM9LzNCI0L/l56t yHPGCJCUY3jZLoSwBH6wFsRnH2E160pchy8/I= Received: by 10.142.144.11 with SMTP id r11mr2633458wfd.335.1309732258275; Sun, 03 Jul 2011 15:30:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.48.6 with HTTP; Sun, 3 Jul 2011 15:30:18 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Mon, 4 Jul 2011 00:30:18 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Mon, Jul 4, 2011 at 00:19, Lennart Borgman w= rote: > However I think it is also very difficult to catch such errors. They > are likely to be race conditions (since w32 messages from different > sources are involved). But you're talking of presumed errors, i.e., you read the code, see some error messages from system calls, but there's no error, is there? > So I think it is better to check the logic. (As I have tried to above.) Which is fine, but it is not IMO a bug report. In this specific case, the title refers to an uninitialized struct component, but you yourself say latter that it is initialized. > And I also still think it is a good idea to add check for error > conditions after all system calls. (For the same reason as above.) As you know, this has been discussed and there's some difference of opinion, but again, even if you're right, that's not a bug report, other than perhaps a wishlist, but frankly, this seems more like something to discuss (again) on emacs-devel than to file as a bug. So, to summarize: is this bug report about a bug? Is there something to do about it? Or can we close it? =C2=A0 =C2=A0 Juanma From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2011 22:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130973265218017 (code B ref 6414); Sun, 03 Jul 2011 22:38:02 +0000 Received: (at 6414) by debbugs.gnu.org; 3 Jul 2011 22:37:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVIB-0004gY-MO for submit@debbugs.gnu.org; Sun, 03 Jul 2011 18:37:31 -0400 Received: from mail-ew0-f44.google.com ([209.85.215.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVIA-0004gN-35 for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 18:37:30 -0400 Received: by ewy19 with SMTP id 19so1927896ewy.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 15:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=MLavZ+V+THRNkVlIP+Gm76XWYGwafj/xe4uho1xrTJQ=; b=euiGoPyfp3f7ul4HxnvG7HZPiUJNETWZbrqGz88iuJHYQfz4+cLGpMVKWqf36EODYm ptp4spfhPxdF8ge77ZtlS9vQyU7XT6lemjKJsMCqxve2JJZ7T0nQKISXjgfyNlLQxF45 2XzDbAA73sfjYFItpXxTbsO5dDgmfAaAF1ldc= Received: by 10.213.35.202 with SMTP id q10mr1215417ebd.64.1309732644283; Sun, 03 Jul 2011 15:37:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.7.84 with HTTP; Sun, 3 Jul 2011 15:37:04 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Mon, 4 Jul 2011 00:37:04 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Mon, Jul 4, 2011 at 00:30, Juanma Barranquero wrote: > On Mon, Jul 4, 2011 at 00:19, Lennart Borgman wrote: > >> However I think it is also very difficult to catch such errors. They >> are likely to be race conditions (since w32 messages from different >> sources are involved). > > But you're talking of presumed errors, i.e., you read the code, see > some error messages from system calls, but there's no error, is there? It has been some time since I suggested this, but as far as I remember I looked into this because I had quite a few crashes. They seemed to be related to menus. >> So I think it is better to check the logic. (As I have tried to above.) > > Which is fine, but it is not IMO a bug report. In this specific case, > the title refers to an uninitialized struct component, but you > yourself say latter that it is initialized. Yes, correct. And I pointed to another place where I thought the problem was instead. >> And I also still think it is a good idea to add check for error >> conditions after all system calls. (For the same reason as above.) > > As you know, this has been discussed and there's some difference of > opinion, but again, even if you're right, that's not a bug report, > other than perhaps a wishlist, but frankly, this seems more like > something to discuss (again) on emacs-devel than to file as a bug. Since you asked for a recipe I thought I had to mention this again. It looked to me that you overlooked this problem again. > So, to summarize: is this bug report about a bug? Is there something > to do about it? Or can we close it? Did you look at the logic as I suggested? If you are sure my suggestion is wrong then feel free to close the bug. From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2011 22:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lennart Borgman Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130973338619169 (code B ref 6414); Sun, 03 Jul 2011 22:50:03 +0000 Received: (at 6414) by debbugs.gnu.org; 3 Jul 2011 22:49:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVU2-0004z8-FL for submit@debbugs.gnu.org; Sun, 03 Jul 2011 18:49:46 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVU1-0004yv-9K for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 18:49:46 -0400 Received: by pzk5 with SMTP id 5so120880pzk.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 15:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=6AxLnWWcm3oVGjRV7FdQRXrsvwmv7QNADjBxtbCV9GA=; b=gGm8zREaY2RbrffGpajCye3HhCBya6J34z9vR9EJDf3mm/oJ8D/5GtnLEn36cxcstd GCtqnYXheyzOIEIjyl5jWDG7uMjkuJHzhhZWo7o26KDhQKXmgpZodKxQnje4Ab/AUVtV hWN7VAta6MhyVGOnpclFd8uTj3mntHzyCSKdo= Received: by 10.143.29.13 with SMTP id g13mr2271576wfj.221.1309733379128; Sun, 03 Jul 2011 15:49:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.48.6 with HTTP; Sun, 3 Jul 2011 15:48:59 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Mon, 4 Jul 2011 00:48:59 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Mon, Jul 4, 2011 at 00:37, Lennart Borgman w= rote: > It has been some time since I suggested this, but as far as I remember > I looked into this because I had quite a few crashes. They seemed to > be related to menus. Yes, I've seen these bug reports, but they usually don't have enough information to follow through (for what I've seen, Eli tried to get you to add more information, with mixed results). > Yes, correct. And I pointed to another place where I thought the > problem was instead. Yes, but still not saying what the problem is. You had crashes in menus, and you filed other bug reports for them. I'm talking about this "bug" report. > Since you asked for a recipe I thought I had to mention this again. It > looked to me that you overlooked this problem again. "Overlooked [...] again"? > Did you look at the logic as I suggested? If the logic is flawed and there's an unitialized struct, it will likely cause bugs and crashes. We only have a few such reports, by you, but they are not very informative, often it is not clear whether it happens with stock Emacs or you patched one (which includes changes in menu functions), and I don't even know if you've had more such crashes recently or they were a year or two ago. Lots of things have changed in between. > If you are sure my > suggestion is wrong then feel free to close the bug. If your suggestion is anything other than "all system calls should be checked", which has already been discussed in emacs-devel, I fail to see what it is. Care to clarify? =C2=A0 =C2=A0 Juanma From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2011 23:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130973469724257 (code B ref 6414); Sun, 03 Jul 2011 23:12:01 +0000 Received: (at 6414) by debbugs.gnu.org; 3 Jul 2011 23:11:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVpA-0006JC-PS for submit@debbugs.gnu.org; Sun, 03 Jul 2011 19:11:37 -0400 Received: from mail-ew0-f44.google.com ([209.85.215.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVp9-0006J0-6s for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 19:11:35 -0400 Received: by ewy19 with SMTP id 19so1932544ewy.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 16:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=cpPr/6tB8q77EjLmECxYUJTxmEQ/zw0SIpUvfm9nVt4=; b=UjS1AdQmuNUI7/qhax5yGP0n1+cFRbRyoLOoHZfPTNNF7xdFYKm4BRmrVELn+Hf7JJ rkaZXDD4KzbC79miI9qij63clE0JcqruoCwT0g7A2CZNOk2ckDde+NsBM3/UAEMrBVQF YJbEXjJseNiYpsgII2LCywaCYzpwxSGStCqsI= Received: by 10.213.20.200 with SMTP id g8mr1650696ebb.140.1309734689158; Sun, 03 Jul 2011 16:11:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.7.84 with HTTP; Sun, 3 Jul 2011 16:11:09 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Mon, 4 Jul 2011 01:11:09 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Mon, Jul 4, 2011 at 00:48, Juanma Barranquero wrote: > On Mon, Jul 4, 2011 at 00:37, Lennart Borgman wrote: > >> It has been some time since I suggested this, but as far as I remember >> I looked into this because I had quite a few crashes. They seemed to >> be related to menus. > > Yes, I've seen these bug reports, but they usually don't have enough > information to follow through (for what I've seen, Eli tried to get > you to add more information, with mixed results). I tried to do that, but as I said in another thread I do not see the same problem in my patched build any more. (But I see new problems on 64-bit windows.) >> Yes, correct. And I pointed to another place where I thought the >> problem was instead. > > Yes, but still not saying what the problem is. You had crashes in > menus, and you filed other bug reports for them. I'm talking about > this "bug" report. This is a complement to them. We agreed to file bug report for code changes we should not forget. This is one of those. Do you agree that this report is a reasonable way to tell you what I have done to try to fix the problem and get your thoughts on it? Otherwise suggest something else. (I can't do much now, but perhaps later.) >> Since you asked for a recipe I thought I had to mention this again. It >> looked to me that you overlooked this problem again. > > "Overlooked [...] again"? Yes. The problem with race conditions was one of the main reasons for my suggestion to add error checking to all system calls. I thought that you might have overlooked this since you suggested that I should send a clear recipe for how to reproduce the bug. But maybe you did not do that? Please explain if I am misunderstanding you. >> Did you look at the logic as I suggested? > > If the logic is flawed and there's an unitialized struct, it will > likely cause bugs and crashes. We only have a few such reports, by > you, but they are not very informative, often it is not clear whether > it happens with stock Emacs or you patched one (which includes changes > in menu functions), and I don't even know if you've had more such > crashes recently or they were a year or two ago. Lots of things have > changed in between. I think I was wrong about the initialization. As I said later I think the structure was initialized. Yes, I have a lot of changes in that area. Complicated, unfortunately. I think I have lost control of the details there now. And I never felt I had complete control of it. The code is complex and I am not even sure that we are always doing things in the right thread etc. However after fixing the things I suggested I have not seen those crashes any more as far as I remember. But it might be that I have changed my usage pattern of Emacs. Nowadays I am mostly using org-mode with my bibhlp.el extensions. >> If you are sure my >> suggestion is wrong then feel free to close the bug. > > If your suggestion is anything other than "all system calls should be > checked", which has already been discussed in emacs-devel, I fail to > see what it is. Care to clarify? Yes, it is this that I wrote earlier: "The problem seems to be in x_free_frame_resources. Should not free_frame_menubar be called before my_destroy_window there?" We might disagree, but be sure I am glad for your efforts! From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2011 23:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lennart Borgman Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130973534025219 (code B ref 6414); Sun, 03 Jul 2011 23:23:01 +0000 Received: (at 6414) by debbugs.gnu.org; 3 Jul 2011 23:22:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVzX-0006Yi-QO for submit@debbugs.gnu.org; Sun, 03 Jul 2011 19:22:20 -0400 Received: from mail-pv0-f172.google.com ([74.125.83.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdVzV-0006YV-64 for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 19:22:17 -0400 Received: by pvh18 with SMTP id 18so4387835pvh.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 16:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=iAdUZPtlZ7FlvGPPYeXsRYVnnHvAh7al4XgbZcFT+Gk=; b=VuSq7OKDmKa1y3YjZub5O2KJ7wOV8azcKvXJSNY6G5FOCn1I8xWaOaX3JPhhKyIohI pgzDwR33pQ27MEcluBpC27hqdhwr3JVBMdMMA2nzwXSyoBrF4kEFNkh1fgKbre6D3N8n uQqaNjl6L92SvoggJslIvyEQwhBL3vaRGNa1U= Received: by 10.142.215.15 with SMTP id n15mr201126wfg.107.1309735331091; Sun, 03 Jul 2011 16:22:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.48.6 with HTTP; Sun, 3 Jul 2011 16:21:31 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Mon, 4 Jul 2011 01:21:31 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Mon, Jul 4, 2011 at 01:11, Lennart Borgman w= rote: > This is a complement to them. We agreed to file bug report for code > changes we should not forget. This is one of those. A bug report called " f->output_data.w32->menubar_widget uninitialized?" and suggesting to check some system calls return values as part of some non-very-specific hypothetical bug is not a "code change we should not forget", IMHO. As I've said in the previous message, I think you're talking about your suggestion of checking every system call. If so, please create a wishlist bug report called "All system calls' return values should be checked", or somesuch, so at the very least people perusing bug reports can know at a glance that it is a wishlist and what it is about. I promise I won't close that bug (though I won't likely do much about it, either). > Do you agree that this report is a reasonable way to tell you what I > have done to try to fix the problem and get your thoughts on it? No, because I still don't know what the problem is. > Yes. The problem with race conditions was one of the main reasons for > my suggestion to add error checking to all system calls. I thought > that you might have overlooked this since you suggested that I should > send a clear recipe for how to reproduce the bug. But maybe you did > not do that? Please explain if I am misunderstanding you. Your "problems with race conditions" do only happen to *you*, on *your* patched Emacs. So, if you want to help tracking them, you shouldn't "suggest" anything (IMO, I hasten to add). Patch your Emacs with debug macros to you heart's content, and when you do find something wrong, reproduce it with the stock Emacs and file a (detailed, step-by-step recipe'd) bug report about it. > Yes, I have a lot of changes in that area. Complicated, unfortunately. > I think I have lost control of the details there now. And I never felt > I had complete control of it. The code is complex and I am not even > sure that we are always doing things in the right thread etc. "We"? You're talking about code that you've changed in non-trivial ways! > However after fixing the things I suggested I have not seen those > crashes any more as far as I remember. Then, what are we discussing about? > =C2=A0"The problem seems to be in x_free_frame_resources. Should not > =C2=A0free_frame_menubar be called before my_destroy_window there?" It is perhaps a fine suggestion, if you care to explain what is "the proble= m". =C2=A0 =C2=A0 Juanma From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2011 23:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130973659830410 (code B ref 6414); Sun, 03 Jul 2011 23:44:01 +0000 Received: (at 6414) by debbugs.gnu.org; 3 Jul 2011 23:43:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdWJq-0007uR-F6 for submit@debbugs.gnu.org; Sun, 03 Jul 2011 19:43:18 -0400 Received: from mail-ey0-f172.google.com ([209.85.215.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdWJo-0007uE-IK for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 19:43:17 -0400 Received: by eye13 with SMTP id 13so1928195eye.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 16:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=gltwCGMtRngw3Ueru5GenFyscbNGeBMEs7ca1clp+dI=; b=YcuHilnvCzpPkm8M5tq+Q2qqmuH5wF1wVbpy7dodkY+yFBg9Ztum4FZ2YPj8D+hWzx dWjOlzOhXYhkGFjBsX6VgmeJavpbUxMNBZi4IAAiz5n6dP7J6hwu80KTcX0XBYP97+km VGKfWuP8lFAw5NNLXYDy1YdPpJOLmMooRt//g= Received: by 10.213.20.200 with SMTP id g8mr1655135ebb.140.1309736590510; Sun, 03 Jul 2011 16:43:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.7.84 with HTTP; Sun, 3 Jul 2011 16:42:50 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Mon, 4 Jul 2011 01:42:50 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Mon, Jul 4, 2011 at 01:21, Juanma Barranquero wrote: > On Mon, Jul 4, 2011 at 01:11, Lennart Borgman = wrote: > >> This is a complement to them. We agreed to file bug report for code >> changes we should not forget. This is one of those. > > A bug report called " f->output_data.w32->menubar_widget > uninitialized?" and suggesting to check some system calls return > values as part of some non-very-specific hypothetical bug is not a > "code change we should not forget", IMHO. That there is (was) a bug in the menus is not hypothetical. The reason I am seeing those bugs and not so many other people is probably that I am using the menus. (Since I do not use Alt as META I can use them more easily. And I do.) > As I've said in the previous > message, I think you're talking about your suggestion of checking > every system call. If so, please create a wishlist bug report called > "All system calls' return values should be checked", or somesuch, so > at the very least people perusing bug reports can know at a glance > that it is a wishlist and what it is about. I promise I won't close > that bug (though I won't likely do much about it, either). OK. >> Yes. The problem with race conditions was one of the main reasons for >> my suggestion to add error checking to all system calls. I thought >> that you might have overlooked this since you suggested that I should >> send a clear recipe for how to reproduce the bug. But maybe you did >> not do that? Please explain if I am misunderstanding you. > > Your "problems with race conditions" do only happen to *you*, on > *your* patched Emacs. So, if you want to help tracking them, you > shouldn't "suggest" anything (IMO, I hasten to add). Patch your Emacs > with debug macros to you heart's content, and when you do find > something wrong, reproduce it with the stock Emacs and file a > (detailed, step-by-step recipe'd) bug report about it. I think you misunderstand the logic here. The race condition shows up because of system messages. In your case you probably see much, much less of those since (I believe) you use menus much less often. This has nothing to do with my patched build. In fact I started to patch Emacs because of those problems. And I have had much less problems in this area with my patched version. As I have explained quite a few times the refusal to add things like error checking puts a lot of burden on me. I therefore do not have time any more to work with Emacs (except for some libraries I use myself). >> Yes, I have a lot of changes in that area. Complicated, unfortunately. >> I think I have lost control of the details there now. And I never felt >> I had complete control of it. The code is complex and I am not even >> sure that we are always doing things in the right thread etc. > > "We"? You're talking about code that you've changed in non-trivial ways! No. I am talking about the core Emacs here. >> However after fixing the things I suggested I have not seen those >> crashes any more as far as I remember. > > Then, what are we discussing about? You might want to fix the core Emacs. >> =C2=A0"The problem seems to be in x_free_frame_resources. Should not >> =C2=A0free_frame_menubar be called before my_destroy_window there?" > > It is perhaps a fine suggestion, if you care to explain what is "the prob= lem". Now I am a bit lost. I thought I had done that change, but I have not. (Or it has been reverted by some merge, that happens.) I think the suggestion was just because that is what the MS docs suggest. However I see another small change that I have made to w32term.c that might have fixed some crashes (but this is unrelated to the problem we are discussing) : *** c:/emacs-lp/bld/emacs/trunk/src/w32term.c 2011-03-19 12:38:38.000000000 +0100 --- c:/emacs-lp/bld/emacs/emacsw32/src/w32term.c 2011-07-04 01:37:24.883981800 +0200 *************** *** 4491,4497 **** else { f =3D x_window_to_frame (dpyinfo, msg.msg.hwnd); ! f->async_visible =3D msg.msg.wParam; } #endif --- 4491,4498 ---- else { f =3D x_window_to_frame (dpyinfo, msg.msg.hwnd); ! if (f) ! f->async_visible =3D msg.msg.wParam; } #endif *************** From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2011 00:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lennart Borgman Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.13097396882243 (code B ref 6414); Mon, 04 Jul 2011 00:35:02 +0000 Received: (at 6414) by debbugs.gnu.org; 4 Jul 2011 00:34:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdX7g-0000a8-19 for submit@debbugs.gnu.org; Sun, 03 Jul 2011 20:34:48 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdX7e-0000Zv-8A for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 20:34:46 -0400 Received: by pzk5 with SMTP id 5so164576pzk.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 17:34:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=7xSvJZsnZKj/bTZdTJyETXSIcqeNQfD4oll4Rp03NZs=; b=vEXLDrQqzPlZ6trjJkjKLZhLxkw5BqdoAxqSaaXAIJdLsr+wDcY5wd8Iax/VxcFTBJ pc+5Bv2Elj28ItpHc2qRrW1cjz2F69uR3xtwYIddphLVT36WpmUDd4/4Zdk79iMo17c3 Iy3c/IcV2yVhRtqwFxnHDjzPUojUFtQOyQIT0= Received: by 10.143.43.15 with SMTP id v15mr2554722wfj.164.1309739680140; Sun, 03 Jul 2011 17:34:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.48.6 with HTTP; Sun, 3 Jul 2011 17:34:00 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Mon, 4 Jul 2011 02:34:00 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Mon, Jul 4, 2011 at 01:42, Lennart Borgman w= rote: > That there is (was) a bug in the menus is not hypothetical. That you have stumbled upon some bugs in the menus I don't deny. But this report was not about any bug report, just a system call return value that did not cause any bug (or at least, such bug was not reported). > The reason > I am seeing those bugs and not so many other people is probably that I > am using the menus. (Since I do not use Alt as META I can use them > more easily. And I do.) Perhaps you're right, but I don't believe you're the only heavy user of menus. And still there aren't many menu-related bug reports. That does not mean that there are no bugs, of course; just that they aren't very frequent. > I think you misunderstand the logic here. The race condition shows up > because of system messages. In your case you probably see much, much > less of those since (I believe) you use menus much less often. I can believe that the messages help in making a race condition more visible, but it should still happen every now and then without them. > As I have explained quite a few times the refusal to add things like > error checking puts a lot of burden on me. There's no refusal to add error checking. There has been, several times, a refusal to indiscriminately put such tests in places where they don't seem necessary. But if you point out places where a system call is likely to return an error code that we should check, nobody is going to say "no, don't check that". > You might want to fix the core Emacs. I think that's a bit too vague to be of any help. > Now I am a bit lost. I thought I had done that change, but I have not. > (Or it has been reverted by some merge, that happens.) What change? > However I see another small change that I have made to w32term.c that > might have fixed some crashes (but this is unrelated to the problem we > are discussing) : > > *** 4491,4497 **** > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0f =3D x_window_to_frame (= dpyinfo, msg.msg.hwnd); > > ! =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 f->async_visible =3D msg.msg.= wParam; > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} > > =C2=A0#endif This patch is against your patched version, and in the trunk sources the equivalent code is /* If window has been obscured or exposed by another window being maximised or minimised/restored, then recheck visibility of all frames. Direct changes to our own windows get handled by WM_SIZE. */ #if 0 if (msg.msg.lParam !=3D 0) check_visibility =3D 1; else { f =3D x_window_to_frame (dpyinfo, msg.msg.hwnd); f->async_visible =3D msg.msg.wParam; } #endif which is obviously not executed. =C2=A0 =C2=A0 Juanma From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2011 01:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.13097417325269 (code B ref 6414); Mon, 04 Jul 2011 01:09:01 +0000 Received: (at 6414) by debbugs.gnu.org; 4 Jul 2011 01:08:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdXed-0001Mw-8o for submit@debbugs.gnu.org; Sun, 03 Jul 2011 21:08:51 -0400 Received: from mail-ey0-f172.google.com ([209.85.215.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdXeb-0001Mk-F0 for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 21:08:50 -0400 Received: by eye13 with SMTP id 13so1940663eye.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 18:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=UgXy9+XaFFfkqLQPQOyOcXKRI64hivRfHoZANLosbp8=; b=skUxSuBqkAO1lVQpzn7S5GFtbFEvVBDKR+iCYT5eQ3A2h1iaAmx46aKZcQq4m7Rygm 5Y7Pjq8cVzI0rk/E0mTx1AtKGL2ALEm//o5pQCCqUJw5Q7MVvsxEFuIChefANDc6rnyl nYLhldGIRwEfh/h7qAq99g/DU9Eb+/EgQOvPg= Received: by 10.213.20.200 with SMTP id g8mr1668895ebb.140.1309741723445; Sun, 03 Jul 2011 18:08:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.7.84 with HTTP; Sun, 3 Jul 2011 18:08:22 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Mon, 4 Jul 2011 03:08:22 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Mon, Jul 4, 2011 at 02:34, Juanma Barranquero wrote: > On Mon, Jul 4, 2011 at 01:42, Lennart Borgman = wrote: > >> That there is (was) a bug in the menus is not hypothetical. > > That you have stumbled upon some bugs in the menus I don't deny. But > this report was not about any bug report, just a system call return > value that did not cause any bug (or at least, such bug was not > reported). This call was related to the menus. >> The reason >> I am seeing those bugs and not so many other people is probably that I >> am using the menus. (Since I do not use Alt as META I can use them >> more easily. And I do.) > > Perhaps you're right, but I don't believe you're the only heavy user > of menus. And still there aren't many menu-related bug reports. That > does not mean that there are no bugs, of course; just that they aren't > very frequent. I believe many of the heavy menu users might be using my patched version (since this allows them to use the windows-key as META). That might be the reason you do not see the bug reports. >> I think you misunderstand the logic here. The race condition shows up >> because of system messages. In your case you probably see much, much >> less of those since (I believe) you use menus much less often. > > I can believe that the messages help in making a race condition more > visible, but it should still happen every now and then without them. Of course, but you just do not know it was a race condition. You have no clue at all, since such a condition with a system call can give very strange results. (I have seen such cases.) >> As I have explained quite a few times the refusal to add things like >> error checking puts a lot of burden on me. > > There's no refusal to add error checking. There has been, several > times, a refusal to indiscriminately put such tests in places where > they don't seem necessary. But if you point out places where a system > call is likely to return an error code that we should check, nobody is > going to say "no, don't check that". I would say every system call. Why do you think some of them should be excluded from error checking? >> You might want to fix the core Emacs. > > I think that's a bit too vague to be of any help. Hm. My mistake. ;-) As I said I thought I had changed the code at that point I suggested, in x_free_frame_resources. It was a simple change (and I still believe it should be done). >> Now I am a bit lost. I thought I had done that change, but I have not. >> (Or it has been reverted by some merge, that happens.) > > What change? That one in x_free_frame_resources (that I told about 2010-06-13). >> However I see another small change that I have made to w32term.c that >> might have fixed some crashes (but this is unrelated to the problem we >> are discussing) : >> >> *** 4491,4497 **** >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0f =3D x_window_to_frame = (dpyinfo, msg.msg.hwnd); >> >> ! =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 f->async_visible =3D msg.msg= .wParam; >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} >> >> =C2=A0#endif > > This patch is against your patched version, and in the trunk sources > the equivalent code is > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* If window has been obscured or expos= ed by another window > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 being maximised or minimised/re= stored, then recheck > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 visibility of all frames. =C2= =A0Direct changes to our own > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 windows get handled by WM_SIZE.= =C2=A0*/ > #if 0 > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (msg.msg.lParam !=3D 0) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0check_visibility =3D 1; > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0f =3D x_window_to_frame (= dpyinfo, msg.msg.hwnd); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0f->async_visible =3D msg.= msg.wParam; > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} > #endif > > which is obviously not executed. :-) I wonder why I cared to add that check then. Perhaps was it executed before, I have no idea now. From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2011 01:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lennart Borgman Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.13097425156367 (code B ref 6414); Mon, 04 Jul 2011 01:22:02 +0000 Received: (at 6414) by debbugs.gnu.org; 4 Jul 2011 01:21:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdXrH-0001ee-21 for submit@debbugs.gnu.org; Sun, 03 Jul 2011 21:21:55 -0400 Received: from mail-pv0-f172.google.com ([74.125.83.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdXrE-0001eS-Nn for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 21:21:53 -0400 Received: by pvh18 with SMTP id 18so4438678pvh.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 18:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=kelmPXhwRD7ZCpRjgAnwml1SqeKB5X3nycFU+W+4K9Y=; b=MOawgFJe8wJxq2H2MFk7GTebHdCCt8igekKl7e18hzYmvxh+7anljImlB9ijE0VpCl z8IJN8S7wpI5KdXaUHCMGQUl1UADTQ5z4oIvl+1p9/N+ul38ndWADEWHx4ycT6M+LQuI W7h+z1bV8xlK1+PGk8KF9sKK2uQAoPZ8LDQFU= Received: by 10.143.29.13 with SMTP id g13mr2323629wfj.221.1309742506532; Sun, 03 Jul 2011 18:21:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.48.6 with HTTP; Sun, 3 Jul 2011 18:21:06 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Mon, 4 Jul 2011 03:21:06 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Mon, Jul 4, 2011 at 03:08, Lennart Borgman w= rote: > This call was related to the menus. This bug report was supposedly about menus, but was in fact about system calls returning errors, and no menu bug in sight... > I believe many of the heavy menu users might be using my patched > version (since this allows them to use the windows-key as META). That > might be the reason you do not see the bug reports. Perhaps. It is hard to say. > Of course, but you just do not know it was a race condition. You have > no clue at all, since such a condition with a system call can give > very strange results. (I have seen such cases.) It's irrelevant whether the user knows that it was a race condition. Either s/he sees a bug, or s/hee does not. > I would say every system call. Why do you think some of them should be > excluded from error checking? There are many reasons. In some cases, an error means something could not be done, but reporting it does not help and the fact that it was not done does not cause any harm. In other cases, a system call can return an error, but it just never happens (or if it happens, the reason is serious enough that Emacs failing will not be the biggest problem). Adding error checking to all system calls adds unneeded complexity in these cases where there's nothing to do if the system call fails, and it failing is not going to cause data loss or the World War III. > That one in x_free_frame_resources (that I told about 2010-06-13). Again: what change? Adding error checking? > I wonder why I cared to add that check then. Perhaps was it executed > before, I have no idea now. Then, why did you comment it? =C2=A0 =C2=A0 Juanma From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2011 01:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.13097438958325 (code B ref 6414); Mon, 04 Jul 2011 01:45:02 +0000 Received: (at 6414) by debbugs.gnu.org; 4 Jul 2011 01:44:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdYDX-0002AE-1m for submit@debbugs.gnu.org; Sun, 03 Jul 2011 21:44:55 -0400 Received: from mail-ey0-f172.google.com ([209.85.215.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdYDV-00029y-8X for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 21:44:53 -0400 Received: by eye13 with SMTP id 13so1946208eye.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 18:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=6hk4aD+RA6LdYT2aB9TpvM28aSbZDran9iS2N4n4O4c=; b=ty25/JqLn/epZfBVC7oIes8geKI5m/Sk8oTEs7JZxCtaDaYDX0wHdqUNzV+ZaQJavj JgvxvtGEnkK+6T7AywwZTbbB++5LtoIsKMlAEXXfbx18IFynqH1Lf5FMix9oQtzFsHG3 aGoyl5w0XhivYpnGozWpLVhh/BrvuLKaauYcI= Received: by 10.213.114.66 with SMTP id d2mr1601179ebq.102.1309743887184; Sun, 03 Jul 2011 18:44:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.7.84 with HTTP; Sun, 3 Jul 2011 18:44:27 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Mon, 4 Jul 2011 03:44:27 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Mon, Jul 4, 2011 at 03:21, Juanma Barranquero wrote: > >> Of course, but you just do not know it was a race condition. You have >> no clue at all, since such a condition with a system call can give >> very strange results. (I have seen such cases.) > > It's irrelevant whether the user knows that it was a race condition. > Either s/he sees a bug, or s/hee does not. A debug message could still help. >> I would say every system call. Why do you think some of them should be >> excluded from error checking? > > There are many reasons. In some cases, an error means something could > not be done, but reporting it does not help and the fact that it was > not done does not cause any harm. If that is taken care of I agree of course. > In other cases, a system call can > return an error, but it just never happens (or if it happens, the > reason is serious enough that Emacs failing will not be the biggest > problem). A bad assumption in my book. > Adding error checking to all system calls adds unneeded complexity in > these cases where there's nothing to do if the system call fails, and > it failing is not going to cause data loss or the World War III. Yes, it is extra complexity. But I think the extra complexity that is the result of not doing this error checking is much, much worse. There might be very serious troubles and you have no idea what it is. Note that not only errors in Emacs code can cause problems here, but compiler bugs etc. >> That one in x_free_frame_resources (that I told about 2010-06-13). > > Again: what change? Adding error checking? Just switching the order: The problem seems to be in x_free_frame_resources. Should not free_frame_menubar be called before my_destroy_window there? Hm. I am not quite sure now. Something in my memory is waving a flag and saying something about it. Can't see it now ;-) Could you please check the MS doc and see if these calls should be switched? When I read them I came to that conclusion, but it might be wrong (and the MS doc might also be wrong). >> I wonder why I cared to add that check then. Perhaps was it executed >> before, I have no idea now. > > Then, why did you comment it? I did not notice now. Sorry. From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2011 02:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lennart Borgman Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130974566012937 (code B ref 6414); Mon, 04 Jul 2011 02:15:02 +0000 Received: (at 6414) by debbugs.gnu.org; 4 Jul 2011 02:14:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdYfz-0003Mb-NN for submit@debbugs.gnu.org; Sun, 03 Jul 2011 22:14:20 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdYfy-0003MP-DI for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 22:14:19 -0400 Received: by pzk5 with SMTP id 5so210121pzk.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 19:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=lfDwvh21EwTMjpELKpvxofSoUFtZskR3WX5WY7pkuaE=; b=g0QsK9ASkZdHuIMUDxTTiy9nnJqfuI6YkYYG1Do9EaubOxPPiOz74zBQdl/t7LvkeI ebhDr0cD9eD64QH5lBFkgch9RfZds49AYqFZEAef1L9M+N/Um5+WTbVutqBXFdBkPVcs r7EJPGScIoS6AZf+6/UP87N8ybyCzGyRqZzOw= Received: by 10.142.144.11 with SMTP id r11mr2716748wfd.335.1309745652121; Sun, 03 Jul 2011 19:14:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.48.6 with HTTP; Sun, 3 Jul 2011 19:13:32 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Mon, 4 Jul 2011 04:13:32 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Mon, Jul 4, 2011 at 03:44, Lennart Borgman w= rote: > A debug message could still help. Yes. Or difficult debugging of other issues. Depends on the debug message, its frequency and relevancy. > A bad assumption in my book. Well, we can disagree. > Yes, it is extra complexity. But I think the extra complexity that is > the result of not doing this error checking is much, much worse. There > might be very serious troubles and you have no idea what it is. If there are "serious troubles" and nobody ever notices them, then they are not "serious troubles". We're talking about Emacs, not real time avionics or nuclear plant control software. > Could you please check the MS doc and see if these calls should be > switched? No. You're the one who's spent time looking at the menu code. You're the one who should know whether that is really a bug and propose a patch. =C2=A0 =C2=A0 Juanma From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2011 02:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130974594216506 (code B ref 6414); Mon, 04 Jul 2011 02:20:02 +0000 Received: (at 6414) by debbugs.gnu.org; 4 Jul 2011 02:19:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdYkY-0004IB-2c for submit@debbugs.gnu.org; Sun, 03 Jul 2011 22:19:02 -0400 Received: from mail-ey0-f172.google.com ([209.85.215.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdYkW-0004Hs-0s for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 22:19:00 -0400 Received: by eye13 with SMTP id 13so1951549eye.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 19:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=4oHtKVw+nnjpkiTNPUgZ+A9Pn5QAhXre/QBeHv+HnCk=; b=Uo7f4NwD+nQLR6YX79XdkuBeBWJxBeaM1lfhCLxdBZJU/zkjgds9dtKKmdCsuReiGL rj6musYGb5fNQNVKBTdIbw5iNGKz2k5iSIbyjAhvHHrkInQazU3tswrNDkzUKW2nKVoC O9ZpcMdf7oABx8xnnpkkZkteH1uaPHzMndSEo= Received: by 10.213.114.66 with SMTP id d2mr1606952ebq.102.1309745934159; Sun, 03 Jul 2011 19:18:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.7.84 with HTTP; Sun, 3 Jul 2011 19:18:34 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Mon, 4 Jul 2011 04:18:34 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Mon, Jul 4, 2011 at 04:13, Juanma Barranquero wrote: > On Mon, Jul 4, 2011 at 03:44, Lennart Borgman wrote: > >> Yes, it is extra complexity. But I think the extra complexity that is >> the result of not doing this error checking is much, much worse. There >> might be very serious troubles and you have no idea what it is. > > If there are "serious troubles" and nobody ever notices them, then > they are not "serious troubles". We're talking about Emacs, not real > time avionics or nuclear plant control software. There is serious trouble in this area. And if we are going to expand the frame handling (for inline completion etc) then I think it will be very good to have checks in all places. However do as you want. I do not want to spent too much time on these discussions. I think I have told my reasons for the checks. >> Could you please check the MS doc and see if these calls should be >> switched? > > No. You're the one who's spent time looking at the menu code. You're > the one who should know whether that is really a bug and propose a > patch. OK. And what will happen when I have done that? (Which I have already done.) From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2011 02:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lennart Borgman Cc: 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.130974695817996 (code B ref 6414); Mon, 04 Jul 2011 02:36:01 +0000 Received: (at 6414) by debbugs.gnu.org; 4 Jul 2011 02:35:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdZ0v-0004gD-7p for submit@debbugs.gnu.org; Sun, 03 Jul 2011 22:35:57 -0400 Received: from mail-pv0-f172.google.com ([74.125.83.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdZ0t-0004g0-7Q for 6414@debbugs.gnu.org; Sun, 03 Jul 2011 22:35:55 -0400 Received: by pvh18 with SMTP id 18so4473727pvh.3 for <6414@debbugs.gnu.org>; Sun, 03 Jul 2011 19:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=WfK9LIxB/jvbQ1uaYRInbiX6etdxYTQcJe34eW0LBgQ=; b=vg+tEQtsoaG5NfJ4cYimy8Ccc9+vThOnApa9io/d393vH3hXKm0L6/1A+l6q+JP3gB blM+fZdky0NaPitNNFhnvWuzaliGIQsUDLCs0OoXZlXBC1jX5WxzsTmTs+tZ/wHfgdao fMPQoMyoTxXM3dYOq7NpcLdjrwWXnJKSbXYxA= Received: by 10.142.118.24 with SMTP id q24mr2550298wfc.392.1309746949115; Sun, 03 Jul 2011 19:35:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.48.6 with HTTP; Sun, 3 Jul 2011 19:35:09 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Mon, 4 Jul 2011 04:35:09 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Mon, Jul 4, 2011 at 04:18, Lennart Borgman w= rote: > OK. And what will happen when I have done that? (Which I have already don= e.) The same as with any other patch by anyone else: you have to show that the change is right and it's relly fixing a bug. And be willing to rework the patch a few times if so requested by the people who understands that part of Emacs. What you cannot do (or, better, "what you should not do and expect to get any sympathy") is to throw a patch here or to emacs-devel, reject comments by knowledgeable people, and leave without following through when some aspects of the patch are challenged with the argument that you have much work and no time for this. And then say that your patches are never accepted. =C2=A0 =C2=A0 Juanma From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2011 20:37:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 6414@debbugs.gnu.org, Lennart Borgman Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.131663740125789 (code B ref 6414); Wed, 21 Sep 2011 20:37:03 +0000 Received: (at 6414) by debbugs.gnu.org; 21 Sep 2011 20:36:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TX6-0006hn-6l for submit@debbugs.gnu.org; Wed, 21 Sep 2011 16:36:41 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TWt-0006gy-Gk for 6414@debbugs.gnu.org; Wed, 21 Sep 2011 16:36:31 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R6TWW-00069X-7G; Wed, 21 Sep 2011 22:36:04 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: (Juanma Barranquero's message of "Mon, 4 Jul 2011 04:35:09 +0200") Date: Wed, 21 Sep 2011 22:32:21 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Oneohtrix Point Never's _Returnal_: "Describing Bodies" MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1R6TWW-00069X-7G X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1317242164.54815@xsRp84OKq1wffQLCFaZY2g X-Spam-Status: No X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Juanma Barranquero writes: > The same as with any other patch by anyone else: you have to show that > the change is right and it's relly fixing a bug. And be willing to > rework the patch a few times if so requested by the people who > understands that part of Emacs. More information was requested more than a year ago, but was apparently not given, so I'm closing this bug report. If this still is a problem, please reopen. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 21 16:36:16 2011 Received: (at control) by debbugs.gnu.org; 21 Sep 2011 20:36:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TWh-0006gJ-Tn for submit@debbugs.gnu.org; Wed, 21 Sep 2011 16:36:16 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TWf-0006gB-Ge for control@debbugs.gnu.org; Wed, 21 Sep 2011 16:36:14 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R6TWJ-00068a-0e for control@debbugs.gnu.org; Wed, 21 Sep 2011 22:35:51 +0200 Date: Wed, 21 Sep 2011 22:32:24 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #6414 X-MailScanner-ID: 1R6TWJ-00068a-0e X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1317242151.11868@yZfzO09d0myo4hv/BRnNRg X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) close 6414 From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2011 20:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lars Magne Ingebrigtsen Cc: Juanma Barranquero , 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.131663765126395 (code B ref 6414); Wed, 21 Sep 2011 20:41:02 +0000 Received: (at 6414) by debbugs.gnu.org; 21 Sep 2011 20:40:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6Tb1-0006rY-5d for submit@debbugs.gnu.org; Wed, 21 Sep 2011 16:40:49 -0400 Received: from mail-fx0-f44.google.com ([209.85.161.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6Tav-0006rL-LJ for 6414@debbugs.gnu.org; Wed, 21 Sep 2011 16:40:40 -0400 Received: by fxd18 with SMTP id 18so1915993fxd.3 for <6414@debbugs.gnu.org>; Wed, 21 Sep 2011 13:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=xnhODQnNv9fd6kxVN3XRyMf1JjjgVGbPzuwahCE4nZs=; b=StBsqoQCSalDSMQ40E/MuK+i2Uw0A9Efk73GBcTTnuNNKnJiVN9e5Hk+SutCUemNi6 +YFTI6hp6LoFjSn2CrFRY7PjSwbEkE0N/z67XUaxCVV3of1zO3IAj6FCg5knwVbdhUTz il3zi/FfsALRlbkANQ3YzmZH+x5cpvzzTCcaE= Received: by 10.223.28.72 with SMTP id l8mr1610246fac.137.1316637620273; Wed, 21 Sep 2011 13:40:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.152.20.229 with HTTP; Wed, 21 Sep 2011 13:40:00 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Wed, 21 Sep 2011 22:40:00 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Wed, Sep 21, 2011 at 22:32, Lars Magne Ingebrigtsen wro= te: > Juanma Barranquero writes: > >> The same as with any other patch by anyone else: you have to show that >> the change is right and it's relly fixing a bug. And be willing to >> rework the patch a few times if so requested by the people who >> understands that part of Emacs. > > More information was requested more than a year ago, but was apparently > not given, so I'm closing this bug report. =C2=A0If this still is a probl= em, > please reopen. Closing this will not help. I think it should be left open! From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2011 20:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lennart Borgman Cc: Lars Magne Ingebrigtsen , 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.131663794528275 (code B ref 6414); Wed, 21 Sep 2011 20:46:01 +0000 Received: (at 6414) by debbugs.gnu.org; 21 Sep 2011 20:45:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6Tfq-0007Lh-TL for submit@debbugs.gnu.org; Wed, 21 Sep 2011 16:45:44 -0400 Received: from mail-pz0-f50.google.com ([209.85.210.50]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6Tfn-0007KO-4h for 6414@debbugs.gnu.org; Wed, 21 Sep 2011 16:45:40 -0400 Received: by pzk37 with SMTP id 37so3065300pzk.9 for <6414@debbugs.gnu.org>; Wed, 21 Sep 2011 13:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=EpSMeUFwANJ765faGUFe1Y8uEsMtvcvhoSrVLTVh4z0=; b=jcu6rDSuqlcZhXzs+BKY9aSCmbYyougZS+0IIRpraXcgMHdr7fYc0GXh2uSbHuCC8u R6UVLKzy3fdpDaUaxX2A7b038Dk6nCYtVpHxtLuDLglhOEDQKjqjswMiP0M/ErspPd/m hqvoDHH0VE7j/a91fR9d0YLguceekRBX+3zO8= Received: by 10.68.12.161 with SMTP id z1mr2156732pbb.57.1316637921232; Wed, 21 Sep 2011 13:45:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.223.13 with HTTP; Wed, 21 Sep 2011 13:44:40 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Wed, 21 Sep 2011 22:44:40 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) On Wed, Sep 21, 2011 at 22:40, Lennart Borgman wrote: > Closing this will not help. I think it should be left open! Obviously, having it open has not helped either. =C2=A0 =C2=A0 Juanma From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2011 20:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Juanma Barranquero Cc: Lars Magne Ingebrigtsen , 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.131663804030030 (code B ref 6414); Wed, 21 Sep 2011 20:48:01 +0000 Received: (at 6414) by debbugs.gnu.org; 21 Sep 2011 20:47:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6ThP-0007oG-1m for submit@debbugs.gnu.org; Wed, 21 Sep 2011 16:47:20 -0400 Received: from mail-fx0-f44.google.com ([209.85.161.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6ThK-0007o7-Mt for 6414@debbugs.gnu.org; Wed, 21 Sep 2011 16:47:16 -0400 Received: by fxd18 with SMTP id 18so1921005fxd.3 for <6414@debbugs.gnu.org>; Wed, 21 Sep 2011 13:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=on3Wwd+eP61M6fDTc6fe57ESp8eMijMWW9/r1MTRqq4=; b=U0VNUoy4rp+vfMg6shF3OVx22FEsllQk2aIVVrUNCcYxNnic4Nn9ntUZEYDOFfs5Lw LMEoAX4E5HCQWEEU5KSidb9iAa95NVKZYMr1kIRlmOBCcz3Z4qbCVT0bxzCwX0ocDmoi ARVdzH0uRZBOY4yYMEcyEFQwPfqORycu/JhXI= Received: by 10.223.28.72 with SMTP id l8mr1619107fac.137.1316638017265; Wed, 21 Sep 2011 13:46:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.152.20.229 with HTTP; Wed, 21 Sep 2011 13:46:37 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Wed, 21 Sep 2011 22:46:37 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Wed, Sep 21, 2011 at 22:44, Juanma Barranquero wrote: > On Wed, Sep 21, 2011 at 22:40, Lennart Borgman > wrote: > >> Closing this will not help. I think it should be left open! > > Obviously, having it open has not helped either. Yes. It is not totally forgotten. From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2011 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lennart Borgman Cc: Juanma Barranquero , 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.131663903231605 (code B ref 6414); Wed, 21 Sep 2011 21:04:02 +0000 Received: (at 6414) by debbugs.gnu.org; 21 Sep 2011 21:03:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TxP-0008Dh-Nw for submit@debbugs.gnu.org; Wed, 21 Sep 2011 17:03:52 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TxL-0008DN-Kn for 6414@debbugs.gnu.org; Wed, 21 Sep 2011 17:03:48 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R6Twy-0006hG-Ks; Wed, 21 Sep 2011 23:03:24 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: (Lennart Borgman's message of "Wed, 21 Sep 2011 22:46:37 +0200") Date: Wed, 21 Sep 2011 22:59:54 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWQk40dHBsiIiMRDhIW FRZOT08aGBc2UqMtAAACVElEQVQ4jV2UTZObMAyG3Z3xvSYJ50Vg7olZ7sFezo4b5VxY0P//CZVt YNtqMhnjh1d6hT+EAkWklCppGYlo4uECpVIiThH/aHHjQjTGAUAbAVGaJhdjiX9KvE0MNrKMjgUM yBgzTAJAqR3uYUdikOZLRfw+1+gzmkpRJDDRYt1o+y8zu0RKobZMznbOWWNuTQKKa1SRnHnSXRkY SKl2ULJJ25nOOntro0CJoiiSwHXGOBaYvsoKlQQVK8wW5QaSqUq5gQtcI+hS9Qw0nBsuYTIav0EI TcHFE5pNf/RxQVWNztpUojv1hwIxnJ+dOaJfMriIgG/Atu4n4+7R9Qa8lCj0ua8/8RThLVYRUcDh Q30y5g72WpkPdhwXykcgf9i7MwMEh/aT3+BPokUCz1ujg9XYDC2DnsF7yoQNF8VQA3QwsDFewSxA OAHcdPPx4IQM7iJnEhoABTZo1xe7MoZTZYFujNY+6NDhF4Mrg2hKSijUoC9eyyfUDKbsSiICgBeS JVh33GAEyiN/qwKiNEjQob51cTNw5zJEAXifbA8PBnkFMfCOCIhcDDU3/jlmhboEBaBlBCLoXx2O +5pX3ARK4ZM9NIeinIazxtyorLFZj10y3Z3226dBaL+BKgA34PFFa9q7abfPsCnY12PNiiIdzF0h ENt1PlIRzTuQgX5f/gKEG8H2P7BuJd54+A+gDbwSKDMoaSJ651QokQ6gY+f8OEv8Kf0jgnUH+QSX NHsss4LTRBBvE5YAvQfaUkVQZkE8LXO7gejqQule4eCLgW8gxzUc7/Y/7M7vaG7dqwMAAAAASUVO RK5CYII= X-Now-Playing: Oneohtrix Point Never's _Returnal_: "Where Does Time Go" MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1R6Twy-0006hG-Ks X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1317243804.80587@ogRw3+TD/o3HGjyDpDG+4A X-Spam-Status: No X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Lennart Borgman writes: > Yes. It is not totally forgotten. I don't think anybody understood what the bug report was even about. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Mon Jun 23 18:33:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6414: f->output_data.w32->menubar_widget uninitialized? Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2011 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6414 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: To: Lars Magne Ingebrigtsen Cc: Juanma Barranquero , 6414@debbugs.gnu.org Received: via spool by 6414-submit@debbugs.gnu.org id=B6414.131663929832017 (code B ref 6414); Wed, 21 Sep 2011 21:09:01 +0000 Received: (at 6414) by debbugs.gnu.org; 21 Sep 2011 21:08:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6U1h-0008KM-R9 for submit@debbugs.gnu.org; Wed, 21 Sep 2011 17:08:18 -0400 Received: from mail-fx0-f44.google.com ([209.85.161.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6U1g-0008KF-0s for 6414@debbugs.gnu.org; Wed, 21 Sep 2011 17:08:16 -0400 Received: by fxd18 with SMTP id 18so1937117fxd.3 for <6414@debbugs.gnu.org>; Wed, 21 Sep 2011 14:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=ysxJwwhSn98yXMBxN7/e04C0bno0cLe8ik293JleNwQ=; b=gnjB6DCADMiqHFW/lpwZWu+E3Yp9rlJmI4z88rN6eDhNr9w1qnNrwLATj09H4ugDa7 WR4ye/PUFFxS+XegKJIVMW1Ryd1i8R4XskdSkSri+cb5JS4S50nb2Swfp4Epm/HSvHfP O0LXuVhygD/YJCJQYw+jKeDy8S6NRjPn6eTz0= Received: by 10.223.44.89 with SMTP id z25mr1716791fae.42.1316639278256; Wed, 21 Sep 2011 14:07:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.152.20.229 with HTTP; Wed, 21 Sep 2011 14:07:38 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Wed, 21 Sep 2011 23:07:38 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Wed, Sep 21, 2011 at 22:59, Lars Magne Ingebrigtsen wro= te: > Lennart Borgman writes: > >> Yes. It is not totally forgotten. > > I don't think anybody understood what the bug report was even about. =C2= =A0:-) It is true that we do not understand where the problems are. If we did we would have solved it ... ;-) But that we do not understand is probably no good reason to close this one.