From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 12 13:58:13 2010 Received: (at submit) by debbugs.gnu.org; 12 Jun 2010 17:58:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONUyD-0004Cz-27 for submit@debbugs.gnu.org; Sat, 12 Jun 2010 13:58:13 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONUyB-0004Ct-HJ for submit@debbugs.gnu.org; Sat, 12 Jun 2010 13:58:12 -0400 Received: from lists.gnu.org ([199.232.76.165]:50792) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ONUy6-0005tx-SI for submit@debbugs.gnu.org; Sat, 12 Jun 2010 13:58:06 -0400 Received: from [140.186.70.92] (port=52172 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ONUy5-0005YN-HA for bug-gnu-emacs@gnu.org; Sat, 12 Jun 2010 13:58:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ONUy4-0008CS-0D for bug-gnu-emacs@gnu.org; Sat, 12 Jun 2010 13:58:05 -0400 Received: from mail-yx0-f169.google.com ([209.85.213.169]:38112) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ONUy3-0008CE-UB for bug-gnu-emacs@gnu.org; Sat, 12 Jun 2010 13:58:03 -0400 Received: by yxf34 with SMTP id 34so179155yxf.0 for ; Sat, 12 Jun 2010 10:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=8DE85/mWqS6TvoLnJv9Z9oGoCtMZyb+oPCSgPRr3ioU=; b=A07+iSyZUXJ8qXHLM7QFc+ORTBddHLVH12GkSXP7EfA7nGwcicKv0DJ2cs/+r5ttW1 jcg2nys++jhcSxkxsQ0EV4A3PVgy3BI7TZ3K4So7MumY/0bu59evzZOHxaa5gOD37Y0w 78r3kLz8mjwzDwI3B8Zi80eR2g9n9QnjuOLi4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=RZp/5EWKpZzHBaU++0TxrI3zCwxEgOcCyqWLjYIvZUjKYWUbMzFu6c9ZB/M/pWlfWp Cb7cJjtfsYjEUlAFKl3Nl8yrlvxQsbLRQCDjZYRBjuhlRAgbxWx61oFHcW7iPA39xUwA 1QllZe5KmPlvpwXmMEmVshGvzgOm5XX9ExAZE= Received: by 10.101.143.19 with SMTP id v19mr2948256ann.125.1276365483319; Sat, 12 Jun 2010 10:58:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.15 with HTTP; Sat, 12 Jun 2010 10:57:43 -0700 (PDT) From: Lennart Borgman Date: Sat, 12 Jun 2010 19:57:43 +0200 Message-ID: Subject: Ispell string or comment To: Emacs Bugs Content-Type: multipart/mixed; boundary=0016e68deb903ca2340488d8ffb7 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) --0016e68deb903ca2340488d8ffb7 Content-Type: text/plain; charset=UTF-8 Here is a suggestion for a function ispell-comment-or-string for spell checking of current comment or string, see attachement. --0016e68deb903ca2340488d8ffb7 Content-Type: text/x-patch; charset=US-ASCII; name="ispell-comment-0.diff" Content-Disposition: attachment; filename="ispell-comment-0.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gacr0fxd0 PT09IG1vZGlmaWVkIGZpbGUgJ2xpc3AvdGV4dG1vZGVzL2lzcGVsbC5lbCcNCi0tLSB0cnVuay9s aXNwL3RleHRtb2Rlcy9pc3BlbGwuZWwJMjAxMC0wNS0xMyAxMDozNjowMyArMDAwMA0KKysrIHBh dGNoZWQvbGlzcC90ZXh0bW9kZXMvaXNwZWxsLmVsCTIwMTAtMDYtMTIgMTc6NTM6MzggKzAwMDAN CkBAIC0zMjY2LDExICszMjY2LDIxIEBADQogDQogDQogOzs7IyMjYXV0b2xvYWQNCi0oZGVmdW4g aXNwZWxsLWNvbW1lbnRzLWFuZC1zdHJpbmdzICgpDQorKGRlZnVuIGlzcGVsbC1jb21tZW50cy1h bmQtc3RyaW5ncyAob25seS1jdXJyZW50KQ0KICAgIkNoZWNrIGNvbW1lbnRzIGFuZCBzdHJpbmdz IGluIHRoZSBjdXJyZW50IGJ1ZmZlciBmb3Igc3BlbGxpbmcgZXJyb3JzLiINCi0gIChpbnRlcmFj dGl2ZSkNCisgIChpbnRlcmFjdGl2ZSAobGlzdCBuaWwpKQ0KKyAgKGxldCAoc3RhdGUgZG9uZSkN CisgICAgKGlmIChub3Qgb25seS1jdXJyZW50KQ0KICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkN Ci0gIChsZXQgKHN0YXRlIGRvbmUpDQorICAgICAgKGxldCogKChoZXJlIChwb2ludCkpDQorICAg ICAgICAgICAgIChzdGF0ZSAocGFyc2UtcGFydGlhbC1zZXhwIChwb2ludC1taW4pIChwb2ludCkp KQ0KKyAgICAgICAgICAgICAoaW5zaWRlIChvciAobnRoIDMgc3RhdGUpIChudGggNCBzdGF0ZSkp KQ0KKyAgICAgICAgICAgICAoc3RhcnQgKHdoZW4gaW5zaWRlIChudGggOCBzdGF0ZSkpKSkNCisg ICAgICAgIChpZiBzdGFydA0KKyAgICAgICAgICAgIChnb3RvLWNoYXIgc3RhcnQpDQorICAgICAg ICAgIChzZXRxIGRvbmUgdCkNCisgICAgICAgICAgKGdvdG8tY2hhciBoZXJlKQ0KKyAgICAgICAg ICAobWVzc2FnZSAiTm90IGluc2lkZSBhIHN0cmluZyBvciBjb21tZW50IikpKSkNCiAgICAgKHdo aWxlIChub3QgZG9uZSkNCiAgICAgICAoc2V0cSBkb25lIHQpDQogICAgICAgKHNldHEgc3RhdGUg KHBhcnNlLXBhcnRpYWwtc2V4cCAocG9pbnQpIChwb2ludC1tYXgpDQpAQCAtMzI4Miw4ICszMjky LDE0IEBADQogCSAgICAoaWYgKG9yIChudGggMyBzdGF0ZSkgKG50aCA0IHN0YXRlKSkNCiAJCShl cnJvciAiVW50ZXJtaW5hdGVkIHN0cmluZyBvciBjb21tZW50IikpDQogCSAgICAoc2F2ZS1leGN1 cnNpb24NCi0JICAgICAgKHNldHEgZG9uZSAobm90IChpc3BlbGwtcmVnaW9uIHN0YXJ0IChwb2lu dCkpKSkpKSkpKSkNCisJICAgICAgKHNldHEgZG9uZSAobm90IChpc3BlbGwtcmVnaW9uIHN0YXJ0 IChwb2ludCkpKSkpKSkNCisgICAgICAod2hlbiBvbmx5LWN1cnJlbnQgKHNldHEgZG9uZSB0KSkp KSkNCiANCis7OzsjIyNhdXRvbG9hZA0KKyhkZWZ1biBpc3BlbGwtY29tbWVudC1vci1zdHJpbmcg KCkNCisgICJDaGVjayBjb21tZW50cyBvciBzdHJpbmdzIGF0IHBvaW50IGZvciBzcGVsbGluZyBl cnJvcnMuIg0KKyAgKGludGVyYWN0aXZlKQ0KKyAgKGlzcGVsbC1jb21tZW50cy1hbmQtc3RyaW5n cyB0KSkNCiANCiA7OzsjIyNhdXRvbG9hZA0KIChkZWZ1biBpc3BlbGwtYnVmZmVyICgpDQoNCg== --0016e68deb903ca2340488d8ffb7-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 22 11:55:48 2010 Received: (at 6411) by debbugs.gnu.org; 22 Jun 2010 15:55:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OR5pD-0000fd-Im for submit@debbugs.gnu.org; Tue, 22 Jun 2010 11:55:48 -0400 Received: from edison.ccupm.upm.es ([138.100.4.49]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OR4y6-0000JI-Hs for 6411@debbugs.gnu.org; Tue, 22 Jun 2010 11:00:55 -0400 Received: from agmartin.aq.upm.es (Agmartin.aq.upm.es [138.100.41.131]) by edison.ccupm.upm.es (8.13.8/8.13.8) with ESMTP id o5MF0mvU002659; Tue, 22 Jun 2010 17:00:48 +0200 Received: by agmartin.aq.upm.es (Postfix, from userid 1000) id 9612046201; Tue, 22 Jun 2010 17:00:48 +0200 (CEST) Date: Tue, 22 Jun 2010 17:00:48 +0200 From: Agustin Martin To: 6411@debbugs.gnu.org, Lennart Borgman Subject: Re: bug#6411: Ispell string or comment Message-ID: <20100622150048.GA13614@agmartin.aq.upm.es> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 6411 X-Mailman-Approved-At: Tue, 22 Jun 2010 11:55:46 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) On Sat, Jun 12, 2010 at 07:57:43PM +0200, Lennart Borgman wrote: > Here is a suggestion for a function ispell-comment-or-string for spell > checking of current comment or string, see attachement. Seems OK to me, specially for people using keyboard more than mouse. -- Agustin From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 21 10:08:14 2019 Received: (at 6411) by debbugs.gnu.org; 21 Aug 2019 14:08:14 +0000 Received: from localhost ([127.0.0.1]:36230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0RHZ-0008GC-QA for submit@debbugs.gnu.org; Wed, 21 Aug 2019 10:08:13 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:40708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0RHX-0008Ft-DG for 6411@debbugs.gnu.org; Wed, 21 Aug 2019 10:08:12 -0400 Received: by mail-pl1-f181.google.com with SMTP id h3so1400955pls.7 for <6411@debbugs.gnu.org>; Wed, 21 Aug 2019 07:08:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=qNBw2gcwGPXOzH+WjqoXtikY4Wtm4HsaaDJLxh+OgeQ=; b=GqNlYstqEQxFVesWoabU3G7CqDu3K+fsc6dG4dT0VWPGug5qT8z8CyZGCqsQFGMOMk z7KmIBlEed9negf+/gjckx0M8FdKaRYYzTnyhUUvbWVQxrt5bm3u/6d//PP64fwkeDDE 86Lj/vdbDp4VURs+Ooq0oGCkaBdw5JUR/c1jzaPQB8p2TKcXDdXr9663ShdfYZNyTAXd wqs4Y9RI1D6AArGtLy69PyvuiduNKU3VnU1sCM2DIeiLh86HDfC7m303cjvlQjzO0LPV cNkjod6TLOhoc8+l9ozqsKI1JJcLnauYDggy+AU5f8jsPbuW5VeI3ggQHbHUMg2R1maF C3Ng== X-Gm-Message-State: APjAAAV9FPO82Q9ioq4c5ScyqhVNJRJWspp3ITjcCK0zUxOhruKL5Xbo tk+T2+ai99OUE44iEe3YAHZBLKoQ386AnRW+gI4= X-Google-Smtp-Source: APXvYqyTyM0yWqWXZPuLw8PNlk+AwrrD+ocL4Lb9AQnwIwpebkm1wiCYR8tJMzwfjwRvs5D/C5mNPirLEnyZwaes4N0= X-Received: by 2002:a17:902:d70a:: with SMTP id w10mr32053938ply.251.1566396484535; Wed, 21 Aug 2019 07:08:04 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Wed, 21 Aug 2019 16:07:53 +0200 Message-ID: Subject: Re: bug#6411: Ispell string or comment To: Lennart Borgman Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 6411 Cc: 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 6411 + patch quit Lennart Borgman writes: > Here is a suggestion for a function ispell-comment-or-string for spell > checking of current comment or string, see attachement. This patch from 2010 still applies on current master, and it seems to work as advertised from my minimal testing. I think it would be a good addition. Does anyone object to installing it? Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 21 13:08:34 2019 Received: (at 6411) by debbugs.gnu.org; 21 Aug 2019 17:08:34 +0000 Received: from localhost ([127.0.0.1]:36433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0U66-0002hZ-Iz for submit@debbugs.gnu.org; Wed, 21 Aug 2019 13:08:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0U64-0002hJ-5b for 6411@debbugs.gnu.org; Wed, 21 Aug 2019 13:08:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i0U5y-0004RQ-TT; Wed, 21 Aug 2019 13:08:26 -0400 Received: from [176.228.60.248] (port=3104 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i0U5x-00009H-6R; Wed, 21 Aug 2019 13:08:26 -0400 Date: Wed, 21 Aug 2019 20:08:29 +0300 Message-Id: <83r25ejvjm.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Wed, 21 Aug 2019 16:07:53 +0200) Subject: Re: bug#6411: Ispell string or comment References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 6411 Cc: lennart.borgman@gmail.com, 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Wed, 21 Aug 2019 16:07:53 +0200 > Cc: 6411@debbugs.gnu.org > > Lennart Borgman writes: > > > Here is a suggestion for a function ispell-comment-or-string for spell > > checking of current comment or string, see attachement. > > This patch from 2010 still applies on current master, and it seems to > work as advertised from my minimal testing. I think it would be a > good addition. Does anyone object to installing it? Sorry, but I happen to think the proposed implementation is somewhat inelegant: . what's with the "(interactive (list nil))" part? . why not just make ispell-comments-and-strings accept a prefix argument to modify its behavior? . alternatively, why not make ispell-comments-and-strings be sensitive to the active region? . as yet another alternative, make the new ispell-comment-or-string narrow to the comment/string at point and then call ispell-comments-and-strings with no code changes whatsoever; then make the new command be sensitive to active region, and fall back on the string/comment at point if no active region From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 21 16:58:14 2019 Received: (at 6411) by debbugs.gnu.org; 21 Aug 2019 20:58:14 +0000 Received: from localhost ([127.0.0.1]:36621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0Xg7-0000vd-0d for submit@debbugs.gnu.org; Wed, 21 Aug 2019 16:58:14 -0400 Received: from mail-pl1-f175.google.com ([209.85.214.175]:33267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0Xfq-0000ug-46 for 6411@debbugs.gnu.org; Wed, 21 Aug 2019 16:57:57 -0400 Received: by mail-pl1-f175.google.com with SMTP id go14so2005638plb.0 for <6411@debbugs.gnu.org>; Wed, 21 Aug 2019 13:57:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m7D+cTwnHBmdyHvfhi6Q1eBcVifwO8KM2sGXc5aMduA=; b=lqGkOGjzmr8TeU0eu79qgZpSepYmJMJ+C5XZnujrwPDYhrPMb0bxuMJ3JfX5wbTtgK 9Jq13TtLa5LbjZi2tEo91WNo4YxwzESj6W+TFW3OrXu8U0yE0oKW3i2AuT2puEaA7KdN nfoDr3KsSWz2uf0VAbf/oM7JNfT8yd8SoOxagwXacAE4Drqr/i6ROYMpujSt3AcVT7+y lh1ucd9xOg+HW6x/sssjD6oRQIL2v8ReQE0eo8jfsKbkx+iElpU7x/DcCiifK0p+ANKe qALLuZ28dCijeBDDWg2x7w1SLRdO0ygqBUYp4YOB3CLq+0afef1Pm7Uu/OBJEbp5imUa xiKA== X-Gm-Message-State: APjAAAUprJOabygCj/Pg2G55Tx2Gl1gdvDx8x0CBXEX5Z1ZHEDDNMp0o wjFQsQ/GHItnRBYC0oGAjQD4VlC7fRQGfS0l2g8= X-Google-Smtp-Source: APXvYqzt7kzRQA6DzoGdnyVaFk4ZIjVbiiXfZ5Yrf8Pm56I5Rlcax6uoOEPvRn/9FPB+Sj0aznyS3y8miXHN95VaYy8= X-Received: by 2002:a17:902:d70a:: with SMTP id w10mr33732502ply.251.1566421054480; Wed, 21 Aug 2019 13:57:34 -0700 (PDT) MIME-Version: 1.0 References: <83r25ejvjm.fsf@gnu.org> In-Reply-To: <83r25ejvjm.fsf@gnu.org> From: Stefan Kangas Date: Wed, 21 Aug 2019 22:57:21 +0200 Message-ID: Subject: Re: bug#6411: Ispell string or comment To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 6411 Cc: Lennart Borgman , 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 6411 - patch quit Eli Zaretskii writes: > > > Here is a suggestion for a function ispell-comment-or-string for spell > > > checking of current comment or string, see attachement. > > > > This patch from 2010 still applies on current master, and it seems to > > work as advertised from my minimal testing. I think it would be a > > good addition. Does anyone object to installing it? > > Sorry, but I happen to think the proposed implementation is somewhat > inelegant: Thanks, many good points that I agree with. I will review the proposed patch more carefully next time beyond just testing that it works. Let's hope someone picks up the ball and provides us with a revised or new patch. If Lennart Borgman doesn't feel up to it after all these years, maybe someone else? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 08 15:23:00 2020 Received: (at 6411) by debbugs.gnu.org; 8 Apr 2020 19:23:00 +0000 Received: from localhost ([127.0.0.1]:52919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMGHs-0006x9-1m for submit@debbugs.gnu.org; Wed, 08 Apr 2020 15:23:00 -0400 Received: from mail-lj1-f173.google.com ([209.85.208.173]:39684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMGHp-0006ww-Jp for 6411@debbugs.gnu.org; Wed, 08 Apr 2020 15:22:58 -0400 Received: by mail-lj1-f173.google.com with SMTP id i20so8897412ljn.6 for <6411@debbugs.gnu.org>; Wed, 08 Apr 2020 12:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=cHJ0vpL81n6ixFue4hLHb+QljVcdhOOxnN0i+bGSSbY=; b=Kjgkohguje0XRaRCmN/wCW6a1MoK5j6ga7404cp+K4Swmxz3fD7Uapr6IUsyyXPA1j IDdLYiQ563hn162y2DQFGQ625H4PFD39kVkdUNacEXBv06W0hAZl613NkNi2LMxNrqWc rXI5MtuCM8/bfJY55dMhA3JEK1AmG6TyJlLxtAdeeWo1nJrnlJ5zNMCMdU2nefcHNbCt p3tUsMLbfd6LyUeva9383Gm/ZIlR+Gnaw8fKY/Ewz/gWlP2oRIldazoWXFT1aGrihDma p4Fh5pSh9QXWj95K/hgpfFTVVkXmBS7wZG/njU+PBgH3F/0hicMphNc8AyN0dfvP3a68 4HAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=cHJ0vpL81n6ixFue4hLHb+QljVcdhOOxnN0i+bGSSbY=; b=gHLv2MvoTS6CufOevxkY7UQ4I70fhrmkMdakdvGxdbTlEVWy9HZPRFF8M2iEpkUPUD wyFTdbn3hxHHuqegymAu4p1OpgjLGcov5GSvRd+e9/UWvdxCydGGzbupIBjWa7V1VeNM O+iAEMWIRSAWLnM+MJhVhcosvIBTDOUwonOzDUP5Xzer/68UbviK3ga/rcwgYt6Bo+Bs 1rmJyXEOYb/uSMEhGioGee24n0OSKmPUjHr5skKZyCc7Ng4Xtv5mL7NWehmfDHoY2B56 3PZcDYvxVbVeL6rKkLbKUfgBlJFn4W1ETRLjbuTdIxHs77P0MAcaQjkb70RyvLMNxNhf MiHA== X-Gm-Message-State: AGi0PuZc9mjGuqmE0QAPlKZXyL1w22o4Cnzg5lYIJ4fuvfnZvicANEK3 2/AQxuFem4/oORjLiE8Vx14= X-Google-Smtp-Source: APiQypItPdLPKNXah8FEzQZj1VjRLER8kFh8ojzdhAHrJGpFMiiCoAoU6bxWXKpsl1pC0SEKJ+W9jg== X-Received: by 2002:a2e:9798:: with SMTP id y24mr6087504lji.267.1586373771330; Wed, 08 Apr 2020 12:22:51 -0700 (PDT) Received: from localhost ([185.112.167.47]) by smtp.gmail.com with ESMTPSA id m17sm14105724ljb.61.2020.04.08.12.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2020 12:22:48 -0700 (PDT) From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: Eli Zaretskii Subject: Re: bug#6411: Ispell string or comment, bug#6411: Ispell string or comment In-Reply-To: <83r25ejvjm.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 21 Aug 2019 20:08:29 +0300, Wed, 21 Aug 2019 22:57:21 +0200") References: <83r25ejvjm.fsf@gnu.org> <83r25ejvjm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Wed, 08 Apr 2020 21:23:20 +0200 Message-ID: <87k12pkcif.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 6411 Cc: lennart.borgman@gmail.com, Stefan Kangas , 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable tags 6411 + patch thanks On Wed, 21 Aug 2019 20:08:29 +0300 Eli Zaretskii wrote: > Sorry, but I happen to think the proposed implementation is somewhat > inelegant: > > . what's with the "(interactive (list nil))" part? > . why not just make ispell-comments-and-strings accept a prefix > argument to modify its behavior? > . alternatively, why not make ispell-comments-and-strings be > sensitive to the active region? > . as yet another alternative, make the new ispell-comment-or-string > narrow to the comment/string at point and then call > ispell-comments-and-strings with no code changes whatsoever; then > make the new command be sensitive to active region, and fall back > on the string/comment at point if no active region On Wed, 21 Aug 2019 22:57:21 +0200 Stefan Kangas wrote: > Let's hope someone picks up the ball and provides us with a revised or > new patch. If Lennart Borgman doesn't feel up to it after all these > years, maybe someone else? Here's my take on it. I didn't go the narrowing route, as I think it is useful to have full context during spelling corrections (recursive edit etc.). I also didn't see an obvious way to reuse one function/command from the other, as in order to get bounds of a comment/string, we have to parse the (part of the) buffer, by which point we can just pass the bounds straight to `ispell-region'. I did update `ispell-comments-and-strings' to honour active region and take optional bounds, anyway, as it seems useful in itself. One other possibility I see would be to merge the two commands and condition the "at-point" functionality on a prefix argument, but then the name ('ispell-comments-and-strings') would probably have to be changed, anyway (and to what?), and perhaps the command would already become too much of a kitchen sink. --=20 =C5=A0t=C4=9Bp=C3=A1n --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-ispell-Commands-to-check-comments-or-strings-at-poin.patch >From 9ea826c09e848f18b9c09e23c00d525da26d280b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0t=C4=9Bp=C3=A1n=20N=C4=9Bmec?= Date: Wed, 8 Apr 2020 20:32:51 +0200 Subject: [PATCH] ispell: Commands to check comments or strings at point or in region * lisp/textmodes/ispell.el (ispell-comments-and-strings): Accept START and END arguments, defaulting to active region in interactive calls. (ispell-comment-or-string-at-point): New command. (bug#6411) --- etc/NEWS | 7 +++++++ lisp/textmodes/ispell.el | 30 +++++++++++++++++++++++------- 2 files changed, 30 insertions(+), 7 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index fa5478679f..f7f18d12b9 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -144,6 +144,13 @@ this user option. +++ *** New command 'describe-keymap' describes keybindings in a keymap. +** Ispell +--- +*** 'ispell-comments-and-strings' now accepts START and END arguments, +defaulting to active region when used interactively. +--- +*** New command 'ispell-comment-or-string-at-point' is provided. + --- ** The old non-SMIE indentation of 'sh-mode' has been removed. diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el index a9fbd2f04c..e1642a8d87 100644 --- a/lisp/textmodes/ispell.el +++ b/lisp/textmodes/ispell.el @@ -3591,24 +3591,40 @@ ispell-process-line ;;;###autoload -(defun ispell-comments-and-strings () - "Check comments and strings in the current buffer for spelling errors." - (interactive) - (goto-char (point-min)) +(defun ispell-comments-and-strings (&optional start end) + "Check comments and strings in the current buffer for spelling errors. +If called interactively with an active region, check only comments and +strings in the region. +When called from Lisp, START and END buffer positions can be provided +to limit the check." + (interactive (when (use-region-p) (list (region-beginning) (region-end)))) + (unless end (setq end (point-max))) + (goto-char (or start (point-min))) (let (state done) (while (not done) (setq done t) - (setq state (parse-partial-sexp (point) (point-max) - nil nil state 'syntax-table)) + (setq state (parse-partial-sexp (point) end nil nil state 'syntax-table)) (if (or (nth 3 state) (nth 4 state)) (let ((start (point))) - (setq state (parse-partial-sexp start (point-max) + (setq state (parse-partial-sexp start end nil nil state 'syntax-table)) (if (or (nth 3 state) (nth 4 state)) (error "Unterminated string or comment")) (save-excursion (setq done (not (ispell-region start (point)))))))))) +;;;###autoload +(defun ispell-comment-or-string-at-point () + "Check the comment or string containing point for spelling errors." + (interactive) + (save-excursion + (let ((state (syntax-ppss))) + (if (or (nth 3 state) (nth 4 state)) + (ispell-region (nth 8 state) + (progn (parse-partial-sexp (point) (point-max) + nil nil state 'syntax-table) + (point))) + (user-error "Not inside a string or comment"))))) ;;;###autoload (defun ispell-buffer () -- 2.26.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 02:22:03 2020 Received: (at 6411) by debbugs.gnu.org; 9 Apr 2020 06:22:03 +0000 Received: from localhost ([127.0.0.1]:53150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMQZf-0000oo-4u for submit@debbugs.gnu.org; Thu, 09 Apr 2020 02:22:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMQZe-0000oB-3k for 6411@debbugs.gnu.org; Thu, 09 Apr 2020 02:22:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jMQZY-0001Tb-O9; Thu, 09 Apr 2020 02:21:56 -0400 Received: from [176.228.60.248] (port=4611 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jMQZY-00081O-2l; Thu, 09 Apr 2020 02:21:56 -0400 Date: Thu, 09 Apr 2020 09:21:34 +0300 Message-Id: <834kttp4b5.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= In-Reply-To: <87k12pkcif.fsf@gmail.com> (message from =?utf-8?B?xaB0xJtw?= =?utf-8?B?w6FuIE7Em21lYw==?= on Wed, 08 Apr 2020 21:23:20 +0200) Subject: Re: bug#6411: Ispell string or comment, bug#6411: Ispell string or comment References: <83r25ejvjm.fsf@gnu.org> <83r25ejvjm.fsf@gnu.org> <87k12pkcif.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 6411 Cc: lennart.borgman@gmail.com, stefan@marxist.se, 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Štěpán Němec > Cc: Stefan Kangas , lennart.borgman@gmail.com, > 6411@debbugs.gnu.org > Date: Wed, 08 Apr 2020 21:23:20 +0200 > > > Let's hope someone picks up the ball and provides us with a revised or > > new patch. If Lennart Borgman doesn't feel up to it after all these > > years, maybe someone else? > > Here's my take on it. LGTM, thanks. Let's wait for a few days for comments, before pushing this. I also wonder whether it's time to document ispell-comments-and-strings in the user manual. Any opinions? From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 10:48:06 2020 Received: (at 6411) by debbugs.gnu.org; 9 Apr 2020 14:48:06 +0000 Received: from localhost ([127.0.0.1]:54295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMYTO-0002y1-7S for submit@debbugs.gnu.org; Thu, 09 Apr 2020 10:48:06 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:43720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMYTM-0002xU-4N for 6411@debbugs.gnu.org; Thu, 09 Apr 2020 10:48:04 -0400 Received: by mail-lj1-f196.google.com with SMTP id h25so1815217lja.10 for <6411@debbugs.gnu.org>; Thu, 09 Apr 2020 07:48:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=Tyr9jayDcHgEfaDtzsS9Jpn3sunanVuBb22tI4iT+sU=; b=ACzL/zx90GmTwbaAHIUTsqkaHUsSmYCUbFXeKcN0u4lvF682/xc/I+0A+j7ww7XX1B VWzIHFF6N0/BtBLREztsjD+H4haSvK2PXKbKgpCtkgvXFWZlnmqh8wZlSSYKO5jR3K1r ohjD2R+xZizkuBpdFejTg82dTWMbanXsLblunzy67mmtSscPAjvG6mZ5Wg6JtCxQqxLJ zH6I+WkpmZuKQMpZC/yVoes43nHyGexapVLLBI+PU38aPY9mEkdADcuMrpTzEDFdidrA OnkLbGx3e5A9IdO4aT4Y8meXVbdJgShVhOn6EpAcndFmLgR6pkA2O19JZTB3TIcj/wlS 4aZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=Tyr9jayDcHgEfaDtzsS9Jpn3sunanVuBb22tI4iT+sU=; b=FQR7GfPYeyhDCVK7hTeWbOXb7A8SlEAkb8Vry9K/1OWTuadEoSkA9jK0dKe3XTpP/X Ho4o4GsSvYNRw8WtQZG7zxjsr+v4OhoUp1DR+4VmJKpzjYvlxCgJqBqqR3qqgTwGJj2p E1PxdG9KTDw/+BUKl1lgbFlgsPY07JnPF2Tn+cNG2E8qYXCCNi/aB5Qy4QMoT78w0mgX GTij6/xYx0liAHvJQMTxEtXf8op4wSR/ymO52MsphzInYLCk0G/UW0+09hRLyhkmC0ZI oGtyRhGfxYKGWa6pYe99SHhu+8aWcr6QVzWFcfRe6dfZPZKbQsYiCaTynMQsac2c24bG Oitg== X-Gm-Message-State: AGi0PuZOVbQTvTuANI6g4WNG0fXNR6lZpnCe30gzZfYndFTwiSvX4/85 kyj/7p3iCSmLXV90fiE6k4w= X-Google-Smtp-Source: APiQypJgs//QWxNwZ1KHMWoiY6VqDJx2aDc9IOfgkiJsB63YwgPk/yVTHsdrEYZaGsvp1EIt0nNPrQ== X-Received: by 2002:a2e:9f43:: with SMTP id v3mr72153ljk.129.1586443678010; Thu, 09 Apr 2020 07:47:58 -0700 (PDT) Received: from localhost ([185.112.167.47]) by smtp.gmail.com with ESMTPSA id m18sm1293939lfj.10.2020.04.09.07.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 07:47:57 -0700 (PDT) From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: Eli Zaretskii Subject: Re: bug#6411: Ispell string or comment, bug#6411: Ispell string or comment In-Reply-To: <834kttp4b5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Apr 2020 09:21:34 +0300") References: <83r25ejvjm.fsf@gnu.org> <83r25ejvjm.fsf@gnu.org> <87k12pkcif.fsf@gmail.com> <834kttp4b5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Thu, 09 Apr 2020 16:48:30 +0200 Message-ID: <87ftdck94x.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 6411 Cc: lennart.borgman@gmail.com, stefan@marxist.se, 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On Thu, 09 Apr 2020 09:21:34 +0300 Eli Zaretskii wrote: > I also wonder whether it's time to document > ispell-comments-and-strings in the user manual. Any opinions? I considered it, but from a skim through (info "(emacs) Spelling") it seemed that some other commands were missing, too, and the new commands should be easily discoverable anyway. But on second look I see that the only one really missing is `ispell-buffer-with-debug', which probably shouldn't be documented, and `ispell-continue', which _is_ actually documented in the UI explanation, only not by its name (as it is normally invoked as C-u M-$). So I now think it would be better to mention the comment/string commands, too, perhaps as follows: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Document-ispell-comment-string-checking-commands-in-.patch >From 5b1abf142d090d35d1b62ce45b1716c47fc0c667 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0t=C4=9Bp=C3=A1n=20N=C4=9Bmec?= Date: Thu, 9 Apr 2020 16:17:57 +0200 Subject: [PATCH] Document ispell comment/string checking commands in the user manual * doc/emacs/fixit.texi (Spelling): Mention ispell-comments-and-strings and ispell-comment-or-string-at-point. --- doc/emacs/fixit.texi | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/emacs/fixit.texi b/doc/emacs/fixit.texi index 2c268f14fb..c6a14c99c0 100644 --- a/doc/emacs/fixit.texi +++ b/doc/emacs/fixit.texi @@ -277,6 +277,10 @@ Spelling @item M-x ispell-message Check and correct spelling in a draft mail message, excluding cited material. +@item M-x ispell-comments-and-strings +Check and correct spelling of comments and strings in the buffer or region. +@item M-x ispell-comment-or-string-at-point +Check the comment or string at point. @item M-x ispell-change-dictionary @key{RET} @var{dict} @key{RET} Restart the spell-checker process, using @var{dict} as the dictionary. @item M-x ispell-kill-ispell @@ -304,6 +308,8 @@ Spelling @findex ispell @findex ispell-buffer @findex ispell-region +@findex ispell-comments-and-strings +@findex ispell-comment-or-string-at-point @cindex spell-checking the active region Similarly, the command @kbd{M-x ispell} performs spell-checking in the region if one is active, or in the entire buffer otherwise. The @@ -312,7 +318,10 @@ Spelling respectively. To check spelling in an email message you are writing, use @kbd{M-x ispell-message}; that command checks the whole buffer, except for material that is indented or appears to be cited from other -messages. @xref{Sending Mail}. +messages. @xref{Sending Mail}. When dealing with source code, you +can use @kbd{M-x ispell-comments-and-strings} or @kbd{M-x +ispell-comment-or-string-at-point} to check only comments or string +literals. When one of these commands encounters what appears to be an incorrect word, it asks you what to do. It usually displays a list of -- 2.26.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 13:06:44 2020 Received: (at 6411) by debbugs.gnu.org; 9 Apr 2020 17:06:44 +0000 Received: from localhost ([127.0.0.1]:54382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMadY-0006U5-C5 for submit@debbugs.gnu.org; Thu, 09 Apr 2020 13:06:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMadV-0006Tr-Qv for 6411@debbugs.gnu.org; Thu, 09 Apr 2020 13:06:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jMadQ-0002rR-Gg; Thu, 09 Apr 2020 13:06:36 -0400 Received: from [176.228.60.248] (port=4694 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jMadP-0000mL-E8; Thu, 09 Apr 2020 13:06:36 -0400 Date: Thu, 09 Apr 2020 20:06:04 +0300 Message-Id: <83a73koagz.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= In-Reply-To: <87ftdck94x.fsf@gmail.com> (message from =?utf-8?B?xaB0xJtw?= =?utf-8?B?w6FuIE7Em21lYw==?= on Thu, 09 Apr 2020 16:48:30 +0200) Subject: Re: bug#6411: Ispell string or comment, bug#6411: Ispell string or comment References: <83r25ejvjm.fsf@gnu.org> <83r25ejvjm.fsf@gnu.org> <87k12pkcif.fsf@gmail.com> <834kttp4b5.fsf@gnu.org> <87ftdck94x.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 6411 Cc: lennart.borgman@gmail.com, stefan@marxist.se, 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Štěpán Němec > Cc: stefan@marxist.se, lennart.borgman@gmail.com, 6411@debbugs.gnu.org > Date: Thu, 09 Apr 2020 16:48:30 +0200 > > So I now think it would be better to mention the comment/string > commands, too, perhaps as follows: Thanks. A few minor nits below: > * doc/emacs/fixit.texi (Spelling): Mention > ispell-comments-and-strings and ispell-comment-or-string-at-point. Please quote symbols in log messages 'like this'. Please also mention the bug number there. > -messages. @xref{Sending Mail}. > +messages. @xref{Sending Mail}. When dealing with source code, you > +can use @kbd{M-x ispell-comments-and-strings} or @kbd{M-x > +ispell-comment-or-string-at-point} to check only comments or string When a long "M-x SOMETHING" command is close to a line's end, please enclose it in @w{..}, so that it doesn't get split between two lines. Other than these two minor issues, this LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 13:11:39 2020 Received: (at 6411) by debbugs.gnu.org; 9 Apr 2020 17:11:39 +0000 Received: from localhost ([127.0.0.1]:54386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMaiJ-0006bH-1G for submit@debbugs.gnu.org; Thu, 09 Apr 2020 13:11:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMaiH-0006b4-B8 for 6411@debbugs.gnu.org; Thu, 09 Apr 2020 13:11:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jMaiB-0004aW-Nx; Thu, 09 Apr 2020 13:11:31 -0400 Received: from [176.228.60.248] (port=1034 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jMaiA-0006oS-6d; Thu, 09 Apr 2020 13:11:31 -0400 Date: Thu, 09 Apr 2020 20:11:06 +0300 Message-Id: <837dyooa8l.fsf@gnu.org> From: Eli Zaretskii To: stepnem@gmail.com In-Reply-To: <83a73koagz.fsf@gnu.org> (message from Eli Zaretskii on Thu, 09 Apr 2020 20:06:04 +0300) Subject: Re: bug#6411: Ispell string or comment, bug#6411: Ispell string or comment References: <83r25ejvjm.fsf@gnu.org> <83r25ejvjm.fsf@gnu.org> <87k12pkcif.fsf@gmail.com> <834kttp4b5.fsf@gnu.org> <87ftdck94x.fsf@gmail.com> <83a73koagz.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 6411 Cc: lennart.borgman@gmail.com, stefan@marxist.se, 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Date: Thu, 09 Apr 2020 20:06:04 +0300 > From: Eli Zaretskii > Cc: stefan@marxist.se, lennart.borgman@gmail.com, 6411@debbugs.gnu.org > > > From: Štěpán Němec > > Cc: stefan@marxist.se, lennart.borgman@gmail.com, 6411@debbugs.gnu.org > > Date: Thu, 09 Apr 2020 16:48:30 +0200 > > > > So I now think it would be better to mention the comment/string > > commands, too, perhaps as follows: > > Thanks. A few minor nits below: And one other thing: since these changes are now described in the manual, the NEWS entry should be marked with "+++". From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 14:44:34 2020 Received: (at 6411) by debbugs.gnu.org; 9 Apr 2020 18:44:34 +0000 Received: from localhost ([127.0.0.1]:54416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMcAE-0000S0-4w for submit@debbugs.gnu.org; Thu, 09 Apr 2020 14:44:34 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:43169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMcAD-0000Ro-1s for 6411@debbugs.gnu.org; Thu, 09 Apr 2020 14:44:33 -0400 Received: by mail-lf1-f66.google.com with SMTP id k28so415210lfe.10 for <6411@debbugs.gnu.org>; Thu, 09 Apr 2020 11:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=/L9BDmwM9gfxarpbL/ig9R69EbBr1sjKiFPsAvtrznI=; b=UXAqHjH9Dnk3v9hOTxwABC+9GireN+5sSGxlJ9lOPKIfMCXAduq1PfuDiD5Th1AdVr za5FnX8CoGF9dE4Sy+evViQ0iOu11w0IVpX5oBCu/vMCbK2qTtqo+5a1qq9fFf9fwhfr eFOGNFTNMtQYU+G0/wAtk82QUWtF2rEPghw4pIJ08ng/mGBxelnEoqDok7I9cuLCcRyX h4d1bqhfcdeZ2aWDtPh6Mym8KQQeMfU2tpSjclgJZWMps2oMzWWiTFvm7jNhJm/8127d B02dqHT22rH8Z8CbjiOI/da0wbHFZoKFtcpakRQ3wkr7MiezETRDAO83c84ZD82Ev7AJ vGEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=/L9BDmwM9gfxarpbL/ig9R69EbBr1sjKiFPsAvtrznI=; b=cv0TQFxjvs2qGJfBiqQy0Qm4gBMByxofSSXUnAHVapblGlG2ptQA+xJ04UZuoobtIN GISL77lByHeU4hk0VzepPvCmBQ4rOxl1tngxq5l8UuTlZTzevJye80Ok5aBPfrbYnTH8 YLP3T2r6aPULaEPR9UYnmOfrrYKQKQdh3XBgOYfngVJzgZ0cmJBvxut8gZpNfJ4vrnWK XPFspdR38lVihYN/CEvsVY34rpoteJYYI/mSB7/rNSR/AVZnCogXQ3k8oQUwCN7iowv7 AX+EDVBOM9307Qp2/C0Zx+dcSq7XD/b2MXsnsq9sIUQ5VJrfJVXl/RYITPXukeCSQEMJ Iv+g== X-Gm-Message-State: AGi0PuayVeqSsy1oE+S8KMuGhGf2GO/9NPyd5VrdJJgIooanTx7W8xQ4 F6EXJfhuS5Lyk9f6V3vvxr4= X-Google-Smtp-Source: APiQypJURD6HDsClotr7+eAfr0I11aqSB7Bb3cbcOkHAPwxY9iL+xbL0YQgc+anaGbIeC+4gfSjg7w== X-Received: by 2002:ac2:560e:: with SMTP id v14mr408442lfd.104.1586457866858; Thu, 09 Apr 2020 11:44:26 -0700 (PDT) Received: from localhost ([185.112.167.47]) by smtp.gmail.com with ESMTPSA id w72sm17283558lff.56.2020.04.09.11.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 11:44:26 -0700 (PDT) From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: Eli Zaretskii Subject: Re: bug#6411: Ispell string or comment, bug#6411: Ispell string or comment In-Reply-To: <83a73koagz.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Apr 2020 20:06:04 +0300") References: <83r25ejvjm.fsf@gnu.org> <83r25ejvjm.fsf@gnu.org> <87k12pkcif.fsf@gmail.com> <834kttp4b5.fsf@gnu.org> <87ftdck94x.fsf@gmail.com> <83a73koagz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Thu, 09 Apr 2020 20:44:59 +0200 Message-ID: <87o8s0ebx0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 6411 Cc: lennart.borgman@gmail.com, stefan@marxist.se, 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 09 Apr 2020 20:06:04 +0300 Eli Zaretskii wrote: >> From: =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec >> Cc: stefan@marxist.se, lennart.borgman@gmail.com, 6411@debbugs.gnu.org >> Date: Thu, 09 Apr 2020 16:48:30 +0200 >>=20 >> So I now think it would be better to mention the comment/string >> commands, too, perhaps as follows: > > Thanks. A few minor nits below: > >> * doc/emacs/fixit.texi (Spelling): Mention >> ispell-comments-and-strings and ispell-comment-or-string-at-point. > > Please quote symbols in log messages 'like this'. Please also mention > the bug number there. Will fix, thank you. (Funnily enough I did double check this when making the patch, and found recent commit messages quite diverse in that regard.) >> -messages. @xref{Sending Mail}. >> +messages. @xref{Sending Mail}. When dealing with source code, you >> +can use @kbd{M-x ispell-comments-and-strings} or @kbd{M-x >> +ispell-comment-or-string-at-point} to check only comments or string > > When a long "M-x SOMETHING" command is close to a line's end, please > enclose it in @w{..}, so that it doesn't get split between two lines. By "close to a line's end" I assume you mean to check the rendered info file, as IIUC there is no strict correspondence between the texi source and the final document WRT end of line? --=20 =C5=A0t=C4=9Bp=C3=A1n From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 15:02:31 2020 Received: (at 6411) by debbugs.gnu.org; 9 Apr 2020 19:02:31 +0000 Received: from localhost ([127.0.0.1]:54439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMcRa-0000v3-SP for submit@debbugs.gnu.org; Thu, 09 Apr 2020 15:02:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMcRZ-0000us-RC for 6411@debbugs.gnu.org; Thu, 09 Apr 2020 15:02:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jMcRU-0003MV-3M; Thu, 09 Apr 2020 15:02:24 -0400 Received: from [176.228.60.248] (port=3920 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jMcRS-0005LN-Gw; Thu, 09 Apr 2020 15:02:23 -0400 Date: Thu, 09 Apr 2020 22:01:58 +0300 Message-Id: <835ze8o53t.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= In-Reply-To: <87o8s0ebx0.fsf@gmail.com> (message from =?utf-8?B?xaB0xJtw?= =?utf-8?B?w6FuIE7Em21lYw==?= on Thu, 09 Apr 2020 20:44:59 +0200) Subject: Re: bug#6411: Ispell string or comment, bug#6411: Ispell string or comment References: <83r25ejvjm.fsf@gnu.org> <83r25ejvjm.fsf@gnu.org> <87k12pkcif.fsf@gmail.com> <834kttp4b5.fsf@gnu.org> <87ftdck94x.fsf@gmail.com> <83a73koagz.fsf@gnu.org> <87o8s0ebx0.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 6411 Cc: lennart.borgman@gmail.com, stefan@marxist.se, 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Štěpán Němec > Cc: stefan@marxist.se, lennart.borgman@gmail.com, 6411@debbugs.gnu.org > Date: Thu, 09 Apr 2020 20:44:59 +0200 > > > Please quote symbols in log messages 'like this'. Please also mention > > the bug number there. > > Will fix, thank you. (Funnily enough I did double check this when making > the patch, and found recent commit messages quite diverse in that > regard.) Yes, not everybody follows the policy (and I'm ashamed to sometimes forget doing that as well...) > >> +can use @kbd{M-x ispell-comments-and-strings} or @kbd{M-x > >> +ispell-comment-or-string-at-point} to check only comments or string > > > > When a long "M-x SOMETHING" command is close to a line's end, please > > enclose it in @w{..}, so that it doesn't get split between two lines. > > By "close to a line's end" I assume you mean to check the rendered info > file, as IIUC there is no strict correspondence between the texi source > and the final document WRT end of line? The correspondence is quite close, even though not 100%, and there's the Info output, where it's even closer. So you could just use @w{@kbd{..}} when it's close in Texinfo, because @w{..} is harmless if it isn't needed. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 09 15:56:26 2020 Received: (at 6411) by debbugs.gnu.org; 9 Apr 2020 19:56:26 +0000 Received: from localhost ([127.0.0.1]:54458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMdHm-0002Aq-6o for submit@debbugs.gnu.org; Thu, 09 Apr 2020 15:56:26 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:40748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMdHl-0002Ad-7Y for 6411@debbugs.gnu.org; Thu, 09 Apr 2020 15:56:25 -0400 Received: by mail-lj1-f196.google.com with SMTP id 142so1014116ljj.7 for <6411@debbugs.gnu.org>; Thu, 09 Apr 2020 12:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=NFgIeUnuqBuX1F/Sbs4nvrzL7Rh8QwzvyhfU5NvEfOo=; b=M/oFZaoVv66Sy6yGPp8g/bDtuxQQOm5WtsU8ZwR7dvo46Rwi7zfDLm4ieRGhEsKvND a8O/Awcs68Tr34RuE3SRdxQF/VhHv7wnJ3rHjjjX8/6jF5dNxufhDiU1AW83urvnbdcM DeJ41CCxjK76v+Jdp7VA/p6ZCiklvaCqmFl5ggvKbAtXyMGoJW4cJwYBrbndVdr0uywl vGbfsTv7fM08shyCuPqvZ3SIiVnj/5GmqApkciCucNpJF4polLX7osnEc+k1ul1CtNWf 1rMPHi8F2YqU83UCQafoT1bhjrjPwiwxIw3IIWLxy2Ca2g1HUhzFXzNUJMWMmNWOkyDJ v+lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=NFgIeUnuqBuX1F/Sbs4nvrzL7Rh8QwzvyhfU5NvEfOo=; b=FmI1uyTDZZpRnkK0TnKFhk97Rpz7FZCf+dgNaCLfXxA/01EPzrbln4rCsdb4hdNUGw jX8VBl9QYOjt5pcqy0Mj9Zv36NwBYI3RDNJAtopk1cRrULje0083yHVeKzMkG3fDHbXg H8kUceOseA21aiRqEp706pngajvPg5AcWNkkfAxDkmfAaxB6bF3w4GN1ODKQVA2Jb67C N67wGG/yH+bjky0HZRfsa4RemDM3MsQTa+MSRYxI3PJYTv78KOuEXuNoOzUktx5CvCJ+ bZXRp/Cukuqh5cMHkF+vYRrRXO9EQl9fHLPtSquY5MnYxkmXhLWP2NAbygldZ/DcKO7J lArQ== X-Gm-Message-State: AGi0PuYhavT0F24MoHHITL5J/98iXEXU2+Kb8NBo3P3rsVKgW4h1Iaqb M9jXsIIoOxa8dQL4Mo8xQe4= X-Google-Smtp-Source: APiQypIMKw38zi9pxW/le3gbWZCT4G9JJ1ucAWsDy5oHI9yhHp5aIngwGt/gJQpJ7819RWDffdZi2A== X-Received: by 2002:a2e:a549:: with SMTP id e9mr934457ljn.28.1586462178962; Thu, 09 Apr 2020 12:56:18 -0700 (PDT) Received: from localhost ([185.112.167.47]) by smtp.gmail.com with ESMTPSA id s6sm16195665ljm.58.2020.04.09.12.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 12:56:18 -0700 (PDT) From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: Eli Zaretskii Subject: Re: bug#6411: Ispell string or comment, bug#6411: Ispell string or comment In-Reply-To: <835ze8o53t.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Apr 2020 22:01:58 +0300") References: <83r25ejvjm.fsf@gnu.org> <83r25ejvjm.fsf@gnu.org> <87k12pkcif.fsf@gmail.com> <834kttp4b5.fsf@gnu.org> <87ftdck94x.fsf@gmail.com> <83a73koagz.fsf@gnu.org> <87o8s0ebx0.fsf@gmail.com> <835ze8o53t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Thu, 09 Apr 2020 21:56:51 +0200 Message-ID: <87h7xse8l8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 6411 Cc: lennart.borgman@gmail.com, stefan@marxist.se, 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 09 Apr 2020 22:01:58 +0300 Eli Zaretskii wrote: >> > When a long "M-x SOMETHING" command is close to a line's end, please >> > enclose it in @w{..}, so that it doesn't get split between two lines. >>=20 >> By "close to a line's end" I assume you mean to check the rendered info >> file, as IIUC there is no strict correspondence between the texi source >> and the final document WRT end of line? > > The correspondence is quite close, even though not 100%, and there's > the Info output, where it's even closer. So you could just use > @w{@kbd{..}} when it's close in Texinfo, because @w{..} is harmless if > it isn't needed. But the intent is not to have "M-x" on one line and "some-command" on the next in the rendered output, right? Because that's exactly what happens e.g. in (info "(emacs) Spelling") with "M-x ispell-message" ("To check spelling in an email message you are writing, use =E2=80=98M-x ispell-message=E2=80=99"), even though in fixit.texi "M-x ispell-message" is nowhere near end of line, so it still seems to me that "close to a line's end in Texinfo" as a rule isn't all that helpful. I guess one had better always check the Info output, or just use @w{} for M-x commands always, unless clearly unnecessary (e.g. a sole line). --=20 =C5=A0t=C4=9Bp=C3=A1n From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 10 02:22:30 2020 Received: (at 6411) by debbugs.gnu.org; 10 Apr 2020 06:22:30 +0000 Received: from localhost ([127.0.0.1]:54730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMn3e-0000VJ-7P for submit@debbugs.gnu.org; Fri, 10 Apr 2020 02:22:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMn3b-0000V6-TM for 6411@debbugs.gnu.org; Fri, 10 Apr 2020 02:22:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jMn3W-0008VJ-7s; Fri, 10 Apr 2020 02:22:22 -0400 Received: from [176.228.60.248] (port=1551 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jMn3V-0007Ck-Kd; Fri, 10 Apr 2020 02:22:22 -0400 Date: Fri, 10 Apr 2020 09:22:05 +0300 Message-Id: <83wo6nn9ma.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= In-Reply-To: <87h7xse8l8.fsf@gmail.com> (message from =?utf-8?B?xaB0xJtw?= =?utf-8?B?w6FuIE7Em21lYw==?= on Thu, 09 Apr 2020 21:56:51 +0200) Subject: Re: bug#6411: Ispell string or comment, bug#6411: Ispell string or comment References: <83r25ejvjm.fsf@gnu.org> <83r25ejvjm.fsf@gnu.org> <87k12pkcif.fsf@gmail.com> <834kttp4b5.fsf@gnu.org> <87ftdck94x.fsf@gmail.com> <83a73koagz.fsf@gnu.org> <87o8s0ebx0.fsf@gmail.com> <835ze8o53t.fsf@gnu.org> <87h7xse8l8.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 6411 Cc: lennart.borgman@gmail.com, stefan@marxist.se, 6411@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Štěpán Němec > Cc: stefan@marxist.se, lennart.borgman@gmail.com, 6411@debbugs.gnu.org > Date: Thu, 09 Apr 2020 21:56:51 +0200 > > But the intent is not to have "M-x" on one line and "some-command" on > the next in the rendered output, right? Yes. > I guess one had better always check the Info output, or just use > @w{} for M-x commands always Yes. It's a good idea to do that anyway, because many times you will see in the Info output something you missed in Texinfo. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 26 07:26:10 2020 Received: (at 6411-done) by debbugs.gnu.org; 26 Aug 2020 11:26:10 +0000 Received: from localhost ([127.0.0.1]:37568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAtZB-0006VO-RL for submit@debbugs.gnu.org; Wed, 26 Aug 2020 07:26:10 -0400 Received: from mail-ed1-f48.google.com ([209.85.208.48]:46393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAtZA-0006VC-ET for 6411-done@debbugs.gnu.org; Wed, 26 Aug 2020 07:26:09 -0400 Received: by mail-ed1-f48.google.com with SMTP id k25so1386176edj.13 for <6411-done@debbugs.gnu.org>; Wed, 26 Aug 2020 04:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=nk4RgU5jz8RJnbE3CSqpTPCXHOUAifOiWri9Pe2jGu4=; b=aKZknRduaIURybDwtV39hVL1YqjWVs20/ydYGLMDw1LWArlYA6/NCd/SlSkYkRV8CW 4RCJCTzVGxHyU03zrgdgz/2xCQovETnWwj4edYjPubAbSXNRmVch2tJwa5Da8CkQ5gZ7 nEgFPwwiTjfmEL1LFuiV5J2PaYe8tPyNF5d0J1WvpJdR1seuH/OyqRxKjHvh89p+PFTq hz+WNP/CFS/gAuYFMePiVsTDQyEFTI/Q2ZKgzNaXOMnlUgr4bdWMVlZFEMlu0mpSCqpq LGB4oof7hqkZh9hM8bFZXlYdUZRTp4ocuLYSpIMt8cDAbKXjVqoRFIRPk2a4fSwuq6hk Xe9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=nk4RgU5jz8RJnbE3CSqpTPCXHOUAifOiWri9Pe2jGu4=; b=o7SPjSL8jZWn3lcwOCwGntvktDnTmyYmkeXZvz1Auy1kkQmW8ai2UxssBNunER7VLl T8B0Luem9jlyxK7on0LrC28PpVMX0s/ZTSLkX58oKhtVhfVb1skQATC+HN7T+nGa1l2r nif9KbmypC3ve03Ogo17xqLvD8OmIaDdnVWzr41N9ayQwO0/2JWn209ga1LDbePV8Cnd hpuE0VzBSHZe2+cN8ElQDZKBKkvx6wEcpU+xfxMzC8KDOaCyXxvBy34dNb0qOF+4FLfq HsJmfi3WfTzPOLb4wCOspYdOLxu5ZH+/c0e8Sc160ugDVvN4B35xI4gjaJzfPQhCt7ki YCyw== X-Gm-Message-State: AOAM531m3l0sZtEFzshzuZNH0e2zfLQQO/1l+vgF7OLDl5aT9C/OL8Bs cMWlppZWy+Zq0Gsbe4+HhRs= X-Google-Smtp-Source: ABdhPJyUzKdGEQNCqfO3SRkL5QmFTIRd5pWHtb3jhaa6HwQDsxbj3OqSun65GFO/wQQ0uMUIidTjBw== X-Received: by 2002:a05:6402:2:: with SMTP id d2mr14570713edu.221.1598441162527; Wed, 26 Aug 2020 04:26:02 -0700 (PDT) Received: from localhost ([185.112.167.35]) by smtp.gmail.com with ESMTPSA id x10sm1801585eds.21.2020.08.26.04.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 04:26:01 -0700 (PDT) From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: Eli Zaretskii Subject: Re: bug#6411: Ispell string or comment, bug#6411: Ispell string or comment In-Reply-To: <834kttp4b5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Apr 2020 09:21:34 +0300") References: <83r25ejvjm.fsf@gnu.org> <83r25ejvjm.fsf@gnu.org> <87k12pkcif.fsf@gmail.com> <834kttp4b5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Wed, 26 Aug 2020 13:27:47 +0200 Message-ID: <871rjtve8c.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 6411-done Cc: lennart.borgman@gmail.com, 6411-done@debbugs.gnu.org, stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 09 Apr 2020 09:21:34 +0300 Eli Zaretskii wrote: >> Here's my take on it. > > LGTM, thanks. > > Let's wait for a few days for comments, before pushing this. Many a week has passed without further comments, so I have now pushed the changes to master, having addressed the points raised: 2020-04-08T20:32:51+02:00!stepnem@gmail.com 2aefd55904 (ispell: Commands to check comments or strings at point or in re= gion) https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3D2aefd55904 2020-04-09T16:17:57+02:00!stepnem@gmail.com e48c60e7c9 (Document ispell comment/string checking commands in the user ma= nual) https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3De48c60e7c9 I am closing this bug report. Thank you and sorry for the delay, =C5=A0t=C4=9Bp=C3=A1n From unknown Tue Jun 24 15:41:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 Sep 2020 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator