GNU bug report logs - #64109
[PATCH 1/2] gnu: dpf-plugins: Update to 1.7.

Previous Next

Package: guix-patches;

Reported by: Sughosha <Sughosha <at> proton.me>

Date: Fri, 16 Jun 2023 14:45:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 64109-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sughosha <Sughosha <at> proton.me>
Cc: "64109 <at> debbugs.gnu.org" <64109-done <at> debbugs.gnu.org>
Subject: Re: bug#64109: [PATCH 1/2] gnu: dpf-plugins: Update to 1.7.
Date: Thu, 14 Sep 2023 23:05:40 +0200
Hi,

I applied the first patch (upgrade).

Sughosha <Sughosha <at> proton.me> skribis:

>>From a74eb4c58d45d30450ba8b70e4faddee52b37f13 Mon Sep 17 00:00:00 2001
> Message-Id: <a74eb4c58d45d30450ba8b70e4faddee52b37f13.1686926462.git.sughosha <at> proton.me>
> In-Reply-To: <23da89c3cbf2358ac70d387ebd714abe03b6758e.1686926462.git.sughosha <at> proton.me>
> References: <23da89c3cbf2358ac70d387ebd714abe03b6758e.1686926462.git.sughosha <at> proton.me>
> From: Sughosha <sughosha <at> proton.me>
> Date: Fri, 16 Jun 2023 16:39:21 +0200
> Subject: [PATCH 2/2] gnu: dpf-plugins: Add native-search-paths.
>
> * gnu/packages/music.scm (dpf-plugins): Add native-search-paths.

[...]

> @@ -6372,6 +6372,25 @@ (define-public dpf-plugins
>             liblo ; for dssi plugins
>             jack-1 ; for standalone applications
>             mesa))
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "CLAP_PATH")
> +            (files '("lib/clap")))
> +           (search-path-specification
> +            (variable "DSSI_PATH")
> +            (files '("lib/dssi")))
> +           (search-path-specification
> +            (variable "LADSPA_PATH")
> +            (files '("lib/ladspa")))
> +           (search-path-specification
> +            (variable "LV2_PATH")
> +            (files '("lib/lv2")))
> +           (search-path-specification
> +            (variable "VST2_PATH")
> +            (files '("lib/vst")))
> +           (search-path-specification
> +            (variable "VST3_PATH")
> +            (files '("lib/vst3")))))

At first sight I think this is incorrect: search paths should be
specified in the patch that honors them.  See
<https://guix.gnu.org/manual/devel/en/html_node/Search-Paths.html>.

Am I right that ‘dnf-plugins’ does not honor them, but instead ‘ladspa’
(maybe?) does?  (I’m no expert here.)

Ludo’.




This bug report was last modified 1 year and 247 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.