GNU bug report logs - #64106
`modify-services` no longer affects multiple instances of the same service

Previous Next

Package: guix;

Reported by: "David Wilson" <david <at> daviwil.com>

Date: Fri, 16 Jun 2023 13:02:02 UTC

Severity: important

Merged with 65184

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: David Wilson <david <at> daviwil.com>, 64106 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>, control <at> debbugs.gnu.org
Subject: bug#64106: `modify-services` no longer affects multiple instances of the same service
Date: Sat, 17 Jun 2023 17:51:13 +0200
[Message part 1 (text/plain, inline)]
merge 64106 63921
thankyou

Hi David,

"David Wilson" <david <at> daviwil.com> writes:

> Hi Guix!
>
> Recently there was a change to the behavior of `modify-services` that adds logic to check for any unused clauses so that an exception can be raised to alert the user of this case.
>
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=181951207339508789b28ba7cb914f983319920f
>
> It seems that the new logic has a bug that prevents a used clause from being executed on more than one instance of a compatible service in a single execution of `modify-services`.  Here's a new test case for `gnu/tests/services.scm` that exhibits the issue:

This was intended, but was probably not a good idea.  I'll look into how
we could revert this while keeping the main idea of the change.

Best,
-- 
Josselin Poiret
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 1 year and 321 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.