From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Krzysztof Klimonda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Jun 2023 05:57:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 64101@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168689501226124 (code B ref -1); Fri, 16 Jun 2023 05:57:04 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jun 2023 05:56:52 +0000 Received: from localhost ([127.0.0.1]:48477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA2S3-0006nD-GN for submit@debbugs.gnu.org; Fri, 16 Jun 2023 01:56:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:60024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9uRo-0008Cg-OU for submit@debbugs.gnu.org; Thu, 15 Jun 2023 17:24:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9uRo-0004kK-El for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 17:24:04 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9uRm-0000WW-55 for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 17:24:04 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E4CF55C00FB for ; Thu, 15 Jun 2023 17:23:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 15 Jun 2023 17:23:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= syntaxhighlighted.com; h=cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t=1686864239; x=1686950639; bh=Iur6SmZ6ghf5+GO9vDdJ4mBvu qJ3uAZG+/2tldsos18=; b=geeeF27ZRIcXDERrLxDxeT9vY9uvQDa9acAc+ofRX uxKWSKlYTpPxYXhvL+WgnsDxiHo/WK0rHvH4+851GBPlhsVrFdh4+ngfHt1i1XBN pFQk95jVVp+2wZv53htTKaGA7iwpWbD2gIJ5k4lbTuT3ds9D6HKYqpzwAbIRXNP+ GXOLdRpfs2LeSelJPW+rY91Novbj7wwjjwmKWJIgT0RDlPIlzmtqcy5NIOlxebf5 ZnLxdNaQ2NAkc5gLRWFumxp5MWUdY5VoNiIESFMp2h1NMu9wiIIge0VEqO2h9EQg 3EfFqncWuhTRGW3QqyahLgGCBEITIyfKyNdJeV8ug047Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1686864239; x=1686950639; bh=Iur6SmZ6ghf5+ GO9vDdJ4mBvuqJ3uAZG+/2tldsos18=; b=jQLWbr2T9sr7OwG5yujIw5jW4fo7E clJXdRnCcSQNKgKeYQwwakTsgekjgE/jzmgSVy6eobHVH/AvkDnAjnREhoL9e+Bg vSLI84W8U7dN03sUEYUrYGgTGnYgdmo6MnndFLD0Wi+4I5vtizD0FNnOLPR96NBx ZVzg8J+Dn4sehVwo3RBEmZyKa2TPcG1AH0sgSDMpyp0XNAAs3XccIEuOBLZ6lgXH DA67+bNDFfM+hY9WcIx/XlCoBDPQHTX3gufPIj2/xVaxtvsv74/9+E8NUmi81ktY 9+46YVxP0BpLA3RZ+wANyOQWfLLgaQkchGz7MxgdLbMNWZi7RUibgJC9g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvvddgudehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephfgtgfgguffkfffvofesthejmh dthhdtvdenucfhrhhomhepmfhriiihshiithhofhcumfhlihhmohhnuggruceokhhklhhi mhhonhgurgesshihnhhtrgighhhighhhlhhighhhthgvugdrtghomheqnecuggftrfgrth htvghrnhepjeeufeffgedtkedtteffffeijeeguefffeehhedtheeuudfhiefhjefhieek uefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepkh hklhhimhhonhgurgesshihnhhtrgighhhighhhlhhighhhthgvugdrtghomh X-ME-Proxy: Feedback-ID: i3888429f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 15 Jun 2023 17:23:59 -0400 (EDT) From: Krzysztof Klimonda Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Message-Id: Date: Thu, 15 Jun 2023 23:23:45 +0200 X-Mailer: Apple Mail (2.3731.400.51.1.1) Received-SPF: pass client-ip=66.111.4.26; envelope-from=kklimonda@syntaxhighlighted.com; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Mailman-Approved-At: Fri, 16 Jun 2023 01:56:47 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) When using eglot with rust-analyzer some inlay hints are not rendered correctly. For example, in the following code snippet, inlay hint for the `let vec =` is rendered as such: > >>>Vec : >> It works fine for simple hints (like `let x` in my example). Looking at what's happening, it seems eglot is creating separate overlays for each element of the returned `InlayHintLabelPart` with the same beginning in the buffer. From poking around I've noticed that overlays have been rewritten recently, and the order of overlays for the given position no longer seems to be fixed. Code example below: ---8<---8<---8<--- use std::sync::{Arc, Mutex}; mod static_uninit; struct Item; fn test() { let vec = vec![Arc::new(Mutex::new(Item))]; let x = 1; } ---8<---8<---8<--- In GNU Emacs 29.0.91 (build 1, x86_64-apple-darwin22.3.0, NS appkit-2299.40 Version 13.2.1 (Build 22D68)) of 2023-06-11 built on sapphire.local Windowing system distributor 'Apple', version 10.3.2299 System Description: macOS 13.2.1 Configured using: 'configure --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs-plus@29/29.0.90/share/info/emacs --prefix=/usr/local/Cellar/emacs-plus@29/29.0.90 --with-xml2 --with-gnutls --with-native-compilation --without-compress-install --without-dbus --without-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained 'CFLAGS=-Os -w -pipe -march=nehalem -mmacosx-version-min=13 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT' 'CPPFLAGS=-I/usr/local/opt/zlib/include -I/usr/local/opt/jpeg/include -I/usr/local/opt/icu4c/include -I/usr/local/opt/openssl@1.1/include -F/usr/local/Frameworks -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk' 'LDFLAGS=-L/usr/local/opt/zlib/lib -L/usr/local/opt/jpeg/lib -L/usr/local/opt/icu4c/lib -L/usr/local/opt/openssl@1.1/lib -L/usr/local/lib -F/usr/local/Frameworks -Wl,-headerpad_max_install_names -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -L/usr/local/opt/libgccjit/lib'' Configured features: ACL GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM ZLIB Important settings: value of $LC_CTYPE: UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Rust Minor modes in effect: shell-dirtrack-mode: t eglot-inlay-hints-mode: t eglot--managed-mode: t flymake-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils misearch multi-isearch pulse color rust-ts-mode c-ts-common treesit etags fileloop generator time-date shell pcomplete eglot external-completion array filenotify jsonrpc ert pp ewoc debug backtrace find-func xref flymake-proc flymake thingatpt compile text-property-search comint ansi-osc ansi-color ring pcase url-util url-parse auth-source eieio eieio-core password-cache json map url-vars project byte-opt imenu vc-git diff-mode easy-mmode vc-dispatcher cl-loaddefs comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 161413 14006) (symbols 48 12244 0) (strings 32 41810 3481) (string-bytes 1 1383853) (vectors 16 31896) (vector-slots 8 582797 14839) (floats 8 140 71) (intervals 56 375 0) (buffers 984 22)) From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 07:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Krzysztof Klimonda , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168698860031269 (code B ref 64101); Sat, 17 Jun 2023 07:57:02 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 07:56:40 +0000 Received: from localhost ([127.0.0.1]:50807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAQnY-00088H-2Q for submit@debbugs.gnu.org; Sat, 17 Jun 2023 03:56:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAQnW-00087y-21 for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 03:56:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAQnQ-0003J4-QL; Sat, 17 Jun 2023 03:56:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=KQ6rse8R+NISxZa7ppFNyj0I9Uu8Z0MlLENDZFBCDGk=; b=N5fLjUG/dsSEJG3fPztp cJQkSxfWVLMhjNPwnFBGqXBSj3phIplJhw+Ae9Zb9KCEqN4Q+IRk5ayMXIlIUN8I2gu5aikjNK8Se D95vY5gh0XBWnQP0pi0rxyyGTn6MX/VMBDnZep+d59ScDT+wqqfkMocOCjMixVFt2G6rC6Mj6Xs8z XRmsCMxhONur40NhsliPZCMXOXfN/DL7ExcFte5R1CPsT5xXBjCjT9znkeYPHdgclgGhzj6qpUhLv 8MCcZlgGIb6ddbcAP1wRKTWCwnFtkK44x9dnVGRSAV+yMvXQwq6/c2pJ+q/Hhucc1bmSyJr8gg7LX iqhw+7jcH+Z4PA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAQnP-0006v3-0V; Sat, 17 Jun 2023 03:56:32 -0400 Date: Sat, 17 Jun 2023 10:56:30 +0300 Message-Id: <83r0qar07l.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Krzysztof Klimonda on Thu, 15 Jun 2023 23:23:45 +0200) References: MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Krzysztof Klimonda > Date: Thu, 15 Jun 2023 23:23:45 +0200 > > > When using eglot with rust-analyzer some inlay hints are not rendered > correctly. For example, in the following code snippet, inlay hint for > the `let vec =` is rendered as such: > > > >>>Vec > and not > > > : >> > > It works fine for simple hints (like `let x` in my example). > > Looking at what's happening, it seems eglot is creating separate > overlays for each element of the returned `InlayHintLabelPart` with > the same beginning in the buffer. From poking around I've noticed > that overlays have been rewritten recently, and the order of overlays > for the given position no longer seems to be fixed. > > Code example below: > ---8<---8<---8<--- > use std::sync::{Arc, Mutex}; > > mod static_uninit; > > struct Item; > > fn test() { > let vec = vec![Arc::new(Mutex::new(Item))]; > let x = 1; > } > ---8<---8<---8<--- João, are you looking into this? Should the overlays created for the inlay hints be forced to be sorted in some particular order? From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 09:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Krzysztof Klimonda , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.16869946348982 (code B ref 64101); Sat, 17 Jun 2023 09:38:02 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 09:37:14 +0000 Received: from localhost ([127.0.0.1]:50889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qASMs-0002Kn-CZ for submit@debbugs.gnu.org; Sat, 17 Jun 2023 05:37:14 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:57419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qASMq-0002Ka-2p for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 05:37:13 -0400 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-3f8fcaa3155so10132725e9.2 for <64101@debbugs.gnu.org>; Sat, 17 Jun 2023 02:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686994626; x=1689586626; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RJSgJy3S9vv/RvtDXppB2uC/p/BJwbEnqf9BVilsRu0=; b=ELJDSE3cRYs9+ET+jV1XSwnaXaxhZluQpmfbHbwe2+GwKNQGHAAvgbSO4h1cFNPVtL iI8y2FnpZtyo6luhohBk48M8vhr6iz2Fr5MXU1e9SMrDF6LH25f60qKuo5KTnmqJBGyL P7DbiqCZRwRrTfWs8vwD53f06kdDC22WJXEp9TVdh8AprYlj+IatQHDfaxry8xsGrvHG 41B4E91eykkk8oqRDpLZVvProFUi/clkptxsJdV9qmcjrvg/2kh4vEzctprUgVN950KK cRxnnJgSDuwRhnG04t79igymidIkDM+gUHQv6zd1+6y+GXIuYOuVGITZRxb9D3QT/4Pb KKNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686994626; x=1689586626; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RJSgJy3S9vv/RvtDXppB2uC/p/BJwbEnqf9BVilsRu0=; b=hoSyIquCBTe7RfgkSpNopOR4QHmBJaVpjYg1I1eQZ+ZbpsAGZqg/brVe1Gty+73F0m OyQgUXJ1krbtgOtQxiL8cabGQ7/Sl7BD28To/fZXfy6i87Ap8p8FN7dICl4wfGvNPQkr /uFJT0y8J6srw2719IHvbBYJBV2iOjschsvtF9cTxTtbtWSGIutOCZh5GfkrVMLTNdYb IDtWOsHcVDEFToVzJVv/NRU3xAL29ePRyAT0XMfbjwO3TkLMpRmHlx1YX2T/lK3/8DOg 09Pixoa5uaAKe33YduaHN2gikwlF33PbMAORVxnAfbQi9eBYSbMIS9YJQosfAfDjm6z1 XZ1g== X-Gm-Message-State: AC+VfDz6JRhYfWAMnyYE9eZhSu0LEQ1bAfBx5ZOZjN/uKYhxSKDLFxrT N4fj+vudawzkzkUk3iA6O7fjdk4uPPk= X-Google-Smtp-Source: ACHHUZ4gVGRWc0kWJpW36eygb+qObDZ9B6xU0j2skIDOrTBjb44Es5sanFQ8xDTOa52vVrCwYxli1Q== X-Received: by 2002:a05:600c:2241:b0:3f9:7fa:62fb with SMTP id a1-20020a05600c224100b003f907fa62fbmr622301wmm.25.1686994625635; Sat, 17 Jun 2023 02:37:05 -0700 (PDT) Received: from krug ([87.196.73.15]) by smtp.gmail.com with ESMTPSA id o1-20020a05600c378100b003f50d6ee334sm4443068wmr.47.2023.06.17.02.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jun 2023 02:37:05 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= In-Reply-To: <83r0qar07l.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Jun 2023 10:56:30 +0300") References: <83r0qar07l.fsf@gnu.org> Date: Sat, 17 Jun 2023 10:39:32 +0100 Message-ID: <877cs28m23.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Jo=C3=A3o, are you looking into this?=20=20 I looked at a very similar issue: https://github.com/joaotavora/eglot/discu= ssions/1239 There, Milan Jovanovic , reports something very similar, if not completely identical, for Emacs 29. I asked Milan to send mail here. Maybe Krzystof and Milan are related, or this is just a coincidence? Anyway, I tried to reproduce the problem on both Emacs 29 and 30 and couldn't. The problem also doesn't happen on Emacs 28. So I don't know what is up and the "recent overlay rewrite" (when?) doesn't seem to have an effect. I don't have a Mac OS machine to test. > Should the overlays created for the > inlay hints be forced to be sorted in some particular order? Maybe, and there is definitely an order they should be sorted. But as far as I can personally observe, there is no problem yet, so it would be best to first understand the problem. But maybe Milan/Krzystof can try this patch: diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index a65795f1dfc..0c000f72ec7 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -3755,8 +3755,9 @@ eglot--update-hints-1 (if peg-after-p (make-overlay (point) (1+ (point)) nil t) (make-overlay (1- (point)) (point) nil nil nil))) - (do-it (label lpad rpad firstp) - (let* ((tweak-cursor-p (and firstp peg-after-p)) + (do-it (label lpad rpad i) + (let* ((firstp (zerop i)) + (tweak-cursor-p (and firstp peg-after-p)) (ov (make-ov)) (text (concat lpad label rpad))) (when tweak-cursor-p (put-text-property 0 1 'cursor= 1 text)) @@ -3767,17 +3768,18 @@ eglot--update-hints-1 (1 'eglot-type-hint-face) (2 'eglot-parameter-hint-face) (_ 'eglot-inlay-hint-face)))) + (overlay-put ov 'priority i) (overlay-put ov 'eglot--inlay-hint t) (overlay-put ov 'evaporate t) (overlay-put ov 'eglot--overlay t)))) - (if (stringp label) (do-it label left-pad right-pad t) + (if (stringp label) (do-it label left-pad right-pad 0) (cl-loop for i from 0 for ldetail across label do (eglot--dbind ((InlayHintLabelPart) value) ldetail (do-it value (and (zerop i) left-pad) (and (=3D i (1- (length label))) right-pad) - (zerop i)))))))))) + i))))))))) (jsonrpc-async-request (eglot--current-server-or-lose) :textDocument/inlayHint From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 10:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168699850816241 (code B ref 64101); Sat, 17 Jun 2023 10:42:01 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 10:41:48 +0000 Received: from localhost ([127.0.0.1]:50917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qATNL-0004Dt-Uz for submit@debbugs.gnu.org; Sat, 17 Jun 2023 06:41:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qATNJ-0004Dh-Jy for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 06:41:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qATN7-0006fW-I2; Sat, 17 Jun 2023 06:41:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=1l0/W63K1dJYm+sDikAomSzoo9wlO0X9E1GHYJEEQ78=; b=B/yTfd/Qh9Pztkni1aM7 QiBIdQZhL63Mqf2OYTZ5lUWGJ+H0bsO2IWGifw05eqYDdgeqccD0MhvZZq+IN9BUeI5XB3A/etUaE S40BdDRPdn8b/azGEwsYd//HRWwr35kLLwDsmuIbz1XyAznr40lEGYvgXt0RVi204yjM0ByDJHU/9 FWVYZADarFK2tuxW/S6Yvs9q8BczB/1OPuAxopJsq/hu3L9eXFkaIGU0BM1+ylfpX4PSdZqvHivVx A+On/WcO0TgpWKNXwuvLxMJfTVxY2duhw9g9OHQ9Q1PSDHSET9kHBB0pwRt10xtF+glkbnWrH5Dx0 4j54yojc6FuICw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qATN3-0008VD-Jc; Sat, 17 Jun 2023 06:41:33 -0400 Date: Sat, 17 Jun 2023 13:41:28 +0300 Message-Id: <83edmaqskn.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <877cs28m23.fsf@gmail.com> (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sat, 17 Jun 2023 10:39:32 +0100) References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Cc: Krzysztof Klimonda , > 64101@debbugs.gnu.org > Date: Sat, 17 Jun 2023 10:39:32 +0100 > > Anyway, I tried to reproduce the problem on both Emacs 29 > and 30 and couldn't. > > The problem also doesn't happen on Emacs 28. So I don't know what is up > and the "recent overlay rewrite" (when?) doesn't seem to have an effect. > I don't have a Mac OS machine to test. Emacs 29 comes with a completely different implementation of overlays than previous versions. I don't think this is specific to macOS, but perhaps the order in which overlays are arranged is arbitrary to some extent, in which case different systems can have different orders. From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.16870042223824 (code B ref 64101); Sat, 17 Jun 2023 12:18:02 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 12:17:02 +0000 Received: from localhost ([127.0.0.1]:50988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAUrV-0000zT-IC for submit@debbugs.gnu.org; Sat, 17 Jun 2023 08:17:02 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:53554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAUrS-0000zB-1p for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 08:17:00 -0400 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-3f8fd8b603aso10803875e9.3 for <64101@debbugs.gnu.org>; Sat, 17 Jun 2023 05:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687004212; x=1689596212; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cRHNRkzsfAc6Nxmt7dFL3woDm+kWdxPkT2FL5GuhaMM=; b=Aae+wDny/MtlfoAXnTNxJF+Vf4qr0eBz91N7zj0J5lxap3tAnNV9NDkdmnFEcDsdeF HdR9fVM4YZ7D1Id+o3CQwmkgxq0HUJ30x81q4F+9moDUHe7UID830laP/poEiW1Dusx0 D8Xbp3/iyobxffXDd/3mR8YRhyRnz5tiYMaFnZBSLVmqTST7auyC0xWOtorvv9UhJmAB yMdVDDhwFiC3Z8OQF8v5nYtTxLywTBPwm8xpMib5GFgTqmxFEjuq+t3Hc8BeS+RQn+0H h/mXneX3dJPsrAZy7lWHtHDVcY2TBgbg/Dt4PgTn/Fb5w9p1bD46n7xbnP6+sY2bkatI ViiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687004212; x=1689596212; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cRHNRkzsfAc6Nxmt7dFL3woDm+kWdxPkT2FL5GuhaMM=; b=FISGviUWMUQtdFuA52pHY8Q4EM2Y+A+z4K4UwaKmTb7VOhN6n/A126FxiHsWNmzBjX sc/5EHhRzT7jQXod/+O3zXKuOjo0lHAvLIcEtCl4du6YPQiL/MOTOYX4BlqDMvY0Zd+i 7J2USL9BuLr8F823jCsKAOI3SHKT+8PbVgachqIrL4N3IXxcob/FAE/t7QQazs9+wonb 7q9/v1rIoWv1R0yfSLR6HgWV/LGcxoL6GBNU2BYPmWFjNjqL7Vqq+yeMXiceNsuO6ZRQ nPKB2JiVDoPHktvg0BCQ5bLJJ6iHf32cks6iXDJi/41McpW/gpId4SAWnkk4B7FfRqsZ efVw== X-Gm-Message-State: AC+VfDyfu9VP2HdpUYAh8I6xXYTbuSoKc0VUqACDS7DGI6ds1qMAODKK M9TdcqpEpRwMIv9e29oRGKE= X-Google-Smtp-Source: ACHHUZ5jbkm+brMh7BN6IjrpPWXJ/6XXJNhi1eMH6PjRaTjERDrZtmC6YXxPMUs0eSLZManlZAVGTg== X-Received: by 2002:a05:600c:28d2:b0:3f7:e809:f41d with SMTP id h18-20020a05600c28d200b003f7e809f41dmr4233161wmd.4.1687004211746; Sat, 17 Jun 2023 05:16:51 -0700 (PDT) Received: from krug ([87.196.73.15]) by smtp.gmail.com with ESMTPSA id f13-20020a7bcd0d000000b003f7ba52eeccsm4874015wmj.7.2023.06.17.05.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jun 2023 05:16:51 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= In-Reply-To: <83edmaqskn.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Jun 2023 13:41:28 +0300") References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <83edmaqskn.fsf@gnu.org> Date: Sat, 17 Jun 2023 13:19:18 +0100 Message-ID: <87352q8ent.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Jo=C3=A3o T=C3=A1vora >> Cc: Krzysztof Klimonda , >> 64101@debbugs.gnu.org >> Date: Sat, 17 Jun 2023 10:39:32 +0100 >>=20 >> Anyway, I tried to reproduce the problem on both Emacs 29 >> and 30 and couldn't. >>=20 >> The problem also doesn't happen on Emacs 28. So I don't know what is up >> and the "recent overlay rewrite" (when?) doesn't seem to have an effect. >> I don't have a Mac OS machine to test. > > Emacs 29 comes with a completely different implementation of overlays > than previous versions. > > I don't think this is specific to macOS, but perhaps the order in > which overlays are arranged is arbitrary to some extent, in which case > different systems can have different orders. I would find this "undefined order" strange, and perhaps a bug in itself. Maybe whoever rewrote the overlay code (Stefan?) could chime in. In any case, one defensive option is to push the patch I showed to Emacs 29. Subject, of course, to testing on at least some machine where the problem does indeed happen. Jo=C3=A3o From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: "Krzysztof Klimonda" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 12:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , "Eli Zaretskii" Cc: 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.16870048394990 (code B ref 64101); Sat, 17 Jun 2023 12:28:02 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 12:27:19 +0000 Received: from localhost ([127.0.0.1]:51005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAV1S-0001IQ-MK for submit@debbugs.gnu.org; Sat, 17 Jun 2023 08:27:19 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:56483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAV1Q-0001IA-5z for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 08:27:17 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 23C385C0186; Sat, 17 Jun 2023 08:27:11 -0400 (EDT) Received: from imap44 ([10.202.2.94]) by compute1.internal (MEProxy); Sat, 17 Jun 2023 08:27:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= syntaxhighlighted.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1687004831; x=1687091231; bh=jK sHJVRQQBgtbzJShyLrMta5laXyvHpPw7lL9CVNIAw=; b=Qks/EUKtk9Ck87b2gS L67wi+egSMGMS0hLpMIEi80RESMD7BdqlmcokHyqpJq6ylIE8HMAai50pjP/htfb eAXyREn14uljugqEu+1DgsF/bVKhfCmpOjnb8DUKMx2SCyjVTfozCM/gx2/0ALik eKyV4gol1Rq/hRHdhbzg60KfTCBaeSi+BYdjHc4tWXpiWE0v/MYaTmQb7e4qIHlG R9Pnjn1wra/2yrxorZfNJF1L2Lo6CW/KhSNE0A/wwK/tPD4clEVXph7Qe8uqVCzn Ezj4BlaOtCeMkTdY1H77sWpMyt2MAI9h8TuhxPc8YJuMagzxJD3qmbSrtaKtxon8 rsYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687004831; x=1687091231; bh=jKsHJVRQQBgtbzJShyLrMta5laXyvHpPw7l L9CVNIAw=; b=h5/jCr/NOONrna0oG2FVJiMF5JPSW0QoLWn9an1fHROiOI0rNMO gM6Sh5MG02hNRd+TvJ9B7IScCotq8LmrlhxJx6hQxPV7wa5tcAO5f4AQ8kdVLVdn pQ9pu+07OrgJ++7nmfTvXV4re3M8TzpYks5k9C423nHKxkKKvkCQhLhDwIqcBnVi PR4KjhsxUWOZqg3tnY8ZRykdJF7nKVlsQEvEY6ypttQf1S0au7xBH9FHruSnWhZw gwkVOEuLZbgjoug2aKMzWRCT9CMmKhVFcyKTEsAVeQbA/6bzOYLtYD0JiFBdkekl JQel2UNfxQPrhNY7mMQACrCxZnTVsvP4xzA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvjedgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdfm rhiihihsiihtohhfucfmlhhimhhonhgurgdfuceokhhklhhimhhonhgurgesshihnhhtrg ighhhighhhlhhighhhthgvugdrtghomheqnecuggftrfgrthhtvghrnhepvdeiteeiuedv uedthedtgfdvffehheejvdeuvdfhtdeguedvtdffffegleethfffnecuffhomhgrihhnpe hgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehkkhhlihhmohhnuggrsehshihnthgrgihhihhghhhlihhghhhtvggurd gtohhm X-ME-Proxy: Feedback-ID: i3888429f:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id AD91336A0075; Sat, 17 Jun 2023 08:27:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-496-g8c46984af0-fm-20230615.001-g8c46984a Mime-Version: 1.0 Message-Id: In-Reply-To: <877cs28m23.fsf@gmail.com> References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> Date: Sat, 17 Jun 2023 14:26:49 +0200 From: "Krzysztof Klimonda" Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Joao, The attached patch has indeed fixed the issue. Additionally, I've tested the behaviour on emacs 28.2 and the bug persis= ts, so it seems to be unrelated to any overlay changes. On Sat, Jun 17, 2023, at 11:39, Jo=C3=A3o T=C3=A1vora wrote: > Eli Zaretskii writes: > >> Jo=C3=A3o, are you looking into this? =20 > > I looked at a very similar issue:=20 > https://github.com/joaotavora/eglot/discussions/1239 > > There, Milan Jovanovic , reports something very similar, > if not completely identical, for Emacs 29. I asked > Milan to send mail here. Maybe Krzystof and Milan are > related, or this is just a coincidence? > > Anyway, I tried to reproduce the problem on both Emacs 29 > and 30 and couldn't. > > The problem also doesn't happen on Emacs 28. So I don't know what is = up > and the "recent overlay rewrite" (when?) doesn't seem to have an effec= t. > I don't have a Mac OS machine to test. > >> Should the overlays created for the >> inlay hints be forced to be sorted in some particular order? > > Maybe, and there is definitely an order they should be sorted. > But as far as I can personally observe, there is no problem yet, > so it would be best to first understand the problem. > > But maybe Milan/Krzystof can try this patch: > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index a65795f1dfc..0c000f72ec7 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -3755,8 +3755,9 @@ eglot--update-hints-1 > (if peg-after-p > (make-overlay (point) (1+ (point)) nil t) > (make-overlay (1- (point)) (point) nil nil=20 > nil))) > - (do-it (label lpad rpad firstp) > - (let* ((tweak-cursor-p (and firstp peg-after-p)) > + (do-it (label lpad rpad i) > + (let* ((firstp (zerop i)) > + (tweak-cursor-p (and firstp peg-after-p)) > (ov (make-ov)) > (text (concat lpad label rpad))) > (when tweak-cursor-p (put-text-property 0 1=20 > 'cursor 1 text)) > @@ -3767,17 +3768,18 @@ eglot--update-hints-1 > (1 'eglot-type-hint-face) > (2=20 > 'eglot-parameter-hint-face) > (_=20 > 'eglot-inlay-hint-face)))) > + (overlay-put ov 'priority i) > (overlay-put ov 'eglot--inlay-hint t) > (overlay-put ov 'evaporate t) > (overlay-put ov 'eglot--overlay t)))) > - (if (stringp label) (do-it label left-pad right-pad t) > + (if (stringp label) (do-it label left-pad right-pad 0) > (cl-loop > for i from 0 for ldetail across label > do (eglot--dbind ((InlayHintLabelPart) value)=20 > ldetail > (do-it value > (and (zerop i) left-pad) > (and (=3D i (1- (length label)))=20 > right-pad) > - (zerop i)))))))))) > + i))))))))) > (jsonrpc-async-request > (eglot--current-server-or-lose) > :textDocument/inlayHint --=20 Krzysztof Klimonda kklimonda@syntaxhighlighted.com From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168700785310150 (code B ref 64101); Sat, 17 Jun 2023 13:18:02 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 13:17:33 +0000 Received: from localhost ([127.0.0.1]:51032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAVo4-0002dc-UX for submit@debbugs.gnu.org; Sat, 17 Jun 2023 09:17:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAVnz-0002dN-HS for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 09:17:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAVnt-0001lL-UG; Sat, 17 Jun 2023 09:17:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GeMuZi3YC4zcW4ZYThfwzxiA5odWLSSvoUKcTiTHu7U=; b=PVc0vr7o/LmNNUiGOGu1 UOKTUfZvrVr02HlkU2a7qb+lu0nZzsLVonocgh0owE9HplZixqzCHCuHQ7uLVcuplYI/TtQ0ZKh0X D2upteBq9KyHwkHu3AOgGE/xTXCiaW/+eA1kJkIUIJarGr8fb/ebZ4FpbGCnd15Nrq/JBu2bIFMNw YBPuZPe4B4QQS8KQThk8SHiUcd+vnhCfAHkHbdH6P2BUYOPYljh4vZFdHsbKAq/26KEBQ7GZ2k9z9 iKUuPTGv+eIncbP4f3Y2VokiPRYW5WE8ew1o8D3sLHQ539rMuDaRYQu27zknJTHgUdhd2+YVInW+a oKps0Xe1gTRhvg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAVnt-0003qy-J1; Sat, 17 Jun 2023 09:17:21 -0400 Date: Sat, 17 Jun 2023 16:17:21 +0300 Message-Id: <835y7mqlcu.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87352q8ent.fsf@gmail.com> (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sat, 17 Jun 2023 13:19:18 +0100) References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <83edmaqskn.fsf@gnu.org> <87352q8ent.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Cc: kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org, > monnier@iro.umontreal.ca > Date: Sat, 17 Jun 2023 13:19:18 +0100 > > Eli Zaretskii writes: > > > Emacs 29 comes with a completely different implementation of overlays > > than previous versions. > > > > I don't think this is specific to macOS, but perhaps the order in > > which overlays are arranged is arbitrary to some extent, in which case > > different systems can have different orders. > > I would find this "undefined order" strange, and perhaps a bug in > itself. Maybe whoever rewrote the overlay code (Stefan?) could chime > in. It wasn't Stefan, he just merged the branch to master and fixed bugs. But why do you say this is a bug? Does any documentation promise any particular order of overlays? > In any case, one defensive option is to push the patch I showed to Emacs > 29. Subject, of course, to testing on at least some machine where the > problem does indeed happen. Yes, let's wait for the confirmation that it fixes the problem. Thanks. From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 13:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168700827810922 (code B ref 64101); Sat, 17 Jun 2023 13:25:02 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 13:24:38 +0000 Received: from localhost ([127.0.0.1]:51053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAVuw-0002q4-AN for submit@debbugs.gnu.org; Sat, 17 Jun 2023 09:24:38 -0400 Received: from mail-oo1-f44.google.com ([209.85.161.44]:47398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAVut-0002pb-Nn for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 09:24:36 -0400 Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-558a79941c6so1165181eaf.3 for <64101@debbugs.gnu.org>; Sat, 17 Jun 2023 06:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687008270; x=1689600270; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7Te8f2houp4+bKLRGE3QnegWXq6zYpDDqv44A0Gyc/I=; b=msj4omhRXmWJihwrGPogYxKAJKT8D/RedzfsHAtjSpmhT2FknDFgnjXbFRUOQ8KUU3 J6c/uaGPYHNzUqNvlk7fk4JZ8U2SYdNcjSPXf7cVCTfGxZ8XYn8IDqv9eaRV4w5qOKtl JvMKHvmPkfr04Otfydww8jWa+ivyE0I1RtbOgTfa+/kgH+GiOhfasMhrzdjSD7gSGjZ5 n1h6g0v/ZKwvxWgJ8wl7DKVh/Rv0Anly/x02D0Htl33HhkCor4hL0CLCwGF8K7tHb3dR ZlljiF1emNjg16qoWymINwFLGA52sZY3pMMityP0OAjI8P4JkFFlCgnM+rSCW9gCgy/J VJUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687008270; x=1689600270; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7Te8f2houp4+bKLRGE3QnegWXq6zYpDDqv44A0Gyc/I=; b=gWsJxtm4gPKNSjpnhzDjSeOD2JIuQltDa0AyxwxiMFEdJF0HLh9kycNwemRrDywVXj dGzl374HvMH6sIAzp7q0Exf8IKEEOhlJxQ/oa62R0PQ5+W9SSkWwJIL7QLlZDqIsJbgy VpuoFG288f2zFkkdzONB3BhvYqxONwE2HnDK+wrSiZq4SdBqAYPibzlAJGyzi0fN8snP Ig8TU7t8fFsUVIW4yR+82j0hWOYr1S3mBryB9N34XgVCPN9kg9/0EXtxbDx3i2NohG3N VZsac8OkgDKbchZjw+CG8AbOwqrxrKhdk1Fw0MkgaUpCVwAqlVf7zIWHZ4vKVwFiL4/8 L39g== X-Gm-Message-State: AC+VfDwc29aOwd7HrOV1g1a7dU4WmYRwK3AaFFrLZ/L6/1PbcbcNdxmK HK3lBLvtPzgntp+m2vg4MtFNnTXye1pAFzxIKrk= X-Google-Smtp-Source: ACHHUZ658UEvrCMuv0euqlhmolqEsq4+GZfg0p1yP0RhaLrVB6lCbvM9/de3CdgJAIf3dENKDZ46tT3tMEwOYG6SLnE= X-Received: by 2002:a4a:b502:0:b0:555:7682:7644 with SMTP id r2-20020a4ab502000000b0055576827644mr2025668ooo.2.1687008269637; Sat, 17 Jun 2023 06:24:29 -0700 (PDT) MIME-Version: 1.0 References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <83edmaqskn.fsf@gnu.org> <87352q8ent.fsf@gmail.com> <835y7mqlcu.fsf@gnu.org> In-Reply-To: <835y7mqlcu.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 17 Jun 2023 14:26:48 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Jun 17, 2023 at 2:17=E2=80=AFPM Eli Zaretskii wrote: > > I would find this "undefined order" strange, and perhaps a bug in > > itself. Maybe whoever rewrote the overlay code (Stefan?) could chime > > in. > > It wasn't Stefan, he just merged the branch to master and fixed bugs. > > But why do you say this is a bug? I didn't: I suggested it _might_ be and asked for an expert opinion to weigh in. It's quite different. > Does any documentation promise any particular order of overlays? No, not that I know of, but it's just the behaviour I've always observed. This seemingly MacOS-specific undefinition is the first time I hear of this behaviour. IMO, unexpected behaviour doesn't have to go against actual documented behaviour to be considered a bug. However if you know that this indefinition exists and you want it to enshrine it (say, for some performan= ce reason) then I believe this should be documented. > > In any case, one defensive option is to push the patch I showed to Emac= s > > 29. Subject, of course, to testing on at least some machine where the > > problem does indeed happen. > > Yes, let's wait for the confirmation that it fixes the problem. I think it has already been tested successfully. Jo=C3=A3o From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 14:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168701118217223 (code B ref 64101); Sat, 17 Jun 2023 14:14:01 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 14:13:02 +0000 Received: from localhost ([127.0.0.1]:52230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAWfl-0004Tj-Si for submit@debbugs.gnu.org; Sat, 17 Jun 2023 10:13:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAWfj-0004TF-OL for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 10:13:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAWfd-0003du-IF; Sat, 17 Jun 2023 10:12:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ITLfoPx6VtkQNvdL2pekrbpWFh39fAGnsH5TumBqBjY=; b=jHa/EgLMBPA9r2a2UJCw sXm48+5wRDRfO+uLJ7RccwNBm9dA1cWJGnOMhD5rJlCFi79DF16+gL6PHygTxDf6ukOVKEV09P2+z e3vIhlTwPIObnbi7Z0u/GqQ9kIFz4wGpE0eY4khqOnFdB/v8pulJC9D7BBbQh1O4FbQ4tZbLbpbIF BwEdwq+y3HnNeOFzkA/6zj3+3XjGALISEIOaNTvSjd0/+O9f0JLnOIkA5rmv+Pj+1M4SJGUoZmYyF 5F6Zssci7eWPz5vDqcp1MBj6aS7dwIuTEAQOBovrE8UGDO+0d4XE7tJS1QWgdfpvRDPSViP2oIfRb T2zvgv4Bo4kdhA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAWfa-0004Tn-R7; Sat, 17 Jun 2023 10:12:53 -0400 Date: Sat, 17 Jun 2023 17:12:50 +0300 Message-Id: <834jn6qisd.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sat, 17 Jun 2023 14:26:48 +0100) References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <83edmaqskn.fsf@gnu.org> <87352q8ent.fsf@gmail.com> <835y7mqlcu.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Sat, 17 Jun 2023 14:26:48 +0100 > Cc: kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org, > monnier@iro.umontreal.ca > > > Does any documentation promise any particular order of overlays? > > No, not that I know of, but it's just the behaviour I've always observed. > This seemingly MacOS-specific undefinition is the first time I hear of this > behaviour. > > IMO, unexpected behaviour doesn't have to go against actual documented > behaviour to be considered a bug. However if you know that this > indefinition exists and you want it to enshrine it (say, for some performance > reason) then I believe this should be documented. What order did your code expect in that case? > > > In any case, one defensive option is to push the patch I showed to Emacs > > > 29. Subject, of course, to testing on at least some machine where the > > > problem does indeed happen. > > > > Yes, let's wait for the confirmation that it fixes the problem. > > I think it has already been tested successfully. Yes, so I think the fix should be installed. From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168701205128205 (code B ref 64101); Sat, 17 Jun 2023 14:28:02 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 14:27:31 +0000 Received: from localhost ([127.0.0.1]:52240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAWtm-0007Kr-Uf for submit@debbugs.gnu.org; Sat, 17 Jun 2023 10:27:31 -0400 Received: from mail-oo1-f52.google.com ([209.85.161.52]:45475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAWth-0007KU-Gs for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 10:27:29 -0400 Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-55e04a83465so1219138eaf.3 for <64101@debbugs.gnu.org>; Sat, 17 Jun 2023 07:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687012039; x=1689604039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=I4mRPewMH7zRYMwOUY7sCCBLy/lIFAv+krFKX3W/uQ0=; b=XTzoQl4iQNAf5MrniKDDbqKtdVXa24KjB/aWuC5TuJGGofqbpp6P2oWYiGG8TcAVx6 a6+XqbKaJHFYwluxrRPfx56NbwQiX7Vn5s4lHQ6/JEtIpBUl2c2vMRrFK6tpT30MbFwt /FuE7FMuv9ChOyRiAM9Ficu0+dHfGQb2mhPUlOBo/s0s1+1uNMz5oRjoKZrd1agDdoA2 Q3XGb7ZOBio7XaWsTZSP8y0gnJeUC+q9zkBj9JQYp26w1e+/f5yr9XSHKNKqbBfDSrOv gGE7Fdgl2BaSRRcgnA2KEU+6Ov60hYPsZPkKk4z7YwGMob1UUKYUOnKPR95Ih2e2xYwo 6VqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687012039; x=1689604039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I4mRPewMH7zRYMwOUY7sCCBLy/lIFAv+krFKX3W/uQ0=; b=Yr7LYLNmMt4hHEL+lUUtDjQunCDTtvRLoI6rkuHV8cWY7x89A+SFA0LgRRgnocO/id L5+5w29yAxBeJuefh065ztqZoJagn3YEjzAUq//4sVHp38rqpr4RF6NXgjQgFuQBIqZV 4+vWmkwhyprCfYhsCiqtGH4/LGmFcIh6cgOUZ8g7EGy10VTZfpRCm7CThYRHfEFlWO6/ KjRSdGcVpznLzz985e+WOvjvxVX7Cpd7eFmT4jkItt6jOnI4mCfGN0/SVQmyOYCATHSh a1v3PddHnhpSptGP0RKV92pZeZSvKHWbDT91pP3G71x4PttilxGp6oI+jQgtD38gDwvF HTKQ== X-Gm-Message-State: AC+VfDwqZ/fFheU+SLiO6gEauZVGaZTaEACpVjy2BB0lFNJx+4NQ4VKt Gvvqnjgbp5z+mt7gVXBbIwggZfCHqZ/ZTEw0cAI= X-Google-Smtp-Source: ACHHUZ7LJ6DLdRNv+KEHJ8/GFjwM9Wm8vvvI7MD3Sli06Hq2BLSjN0LbFr+9LMdoMdv9A7BGFKTW66knRgPF7Du1zYc= X-Received: by 2002:a4a:bd8f:0:b0:558:b5c7:4832 with SMTP id k15-20020a4abd8f000000b00558b5c74832mr2593811oop.3.1687012039685; Sat, 17 Jun 2023 07:27:19 -0700 (PDT) MIME-Version: 1.0 References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <83edmaqskn.fsf@gnu.org> <87352q8ent.fsf@gmail.com> <835y7mqlcu.fsf@gnu.org> <834jn6qisd.fsf@gnu.org> In-Reply-To: <834jn6qisd.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 17 Jun 2023 15:29:38 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Jun 17, 2023 at 3:12=E2=80=AFPM Eli Zaretskii wrote: > > IMO, unexpected behaviour doesn't have to go against actual documented > > behaviour to be considered a bug. However if you know that this > > indefinition exists and you want it to enshrine it (say, for some perfo= rmance > > reason) then I believe this should be documented. > > What order did your code expect in that case? The current order that I see on all my GNU Linux builds of Emacs (and also my Windows builds, I'm fairly certain). The after-string and before-string of a a more recently created overlay is displayed after the least recently created overlay, all other overlay things being equal, of course. > > > > In any case, one defensive option is to push the patch I showed to = Emacs > > > > 29. Subject, of course, to testing on at least some machine where = the > > > > problem does indeed happen. > > > > > > Yes, let's wait for the confirmation that it fixes the problem. > > > > I think it has already been tested successfully. > > Yes, so I think the fix should be installed. Done. Jo=C3=A3o From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , monnier@iro.umontreal.ca Cc: kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168701705314762 (code B ref 64101); Sat, 17 Jun 2023 15:51:02 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 15:50:53 +0000 Received: from localhost ([127.0.0.1]:52444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAYCT-0003q2-Bs for submit@debbugs.gnu.org; Sat, 17 Jun 2023 11:50:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAYCO-0003pm-Fv for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 11:50:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAYCI-000593-Ew; Sat, 17 Jun 2023 11:50:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=O2+9Ux5+rGl22oHJs+rBI461/6qQMeEhy9W4rA/uvlY=; b=GGXfNPCY27zO2IwNugyw V5lBdhJglVD459CW4WBN1P98vb5iCQo9vnyB0IHKhx1e7FohKAV9noGZKT9coGE6Qox84542+Xj64 786XTizhr0MK0qk5MnhUO+PxzkQMKqBIF4kB95tGArVvvcb9tnOhoiUJQpxQ7I91GdLSZJ5zMHnr6 IAY4l9/4f4dsum1eU8PDoZKyNFr3OoFm4GRmkCGysw76qtjnN28rq5/t9UGoLmSbZoN8+7L3hv16j 4KlnU3qXnT9ntY/92/biCFv1wcYlK6brtAJ2DWf6Qc5ioVLApBLTzMpQ6LDE0M6QnzJ4ohS/zkJPs L/5U39r4EEAuLQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAYCH-0001G7-Qi; Sat, 17 Jun 2023 11:50:42 -0400 Date: Sat, 17 Jun 2023 18:50:40 +0300 Message-Id: <83zg4yozov.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Sat, 17 Jun 2023 15:29:38 +0100) References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <83edmaqskn.fsf@gnu.org> <87352q8ent.fsf@gmail.com> <835y7mqlcu.fsf@gnu.org> <834jn6qisd.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Sat, 17 Jun 2023 15:29:38 +0100 > Cc: kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org, > monnier@iro.umontreal.ca > > > What order did your code expect in that case? > > The current order that I see on all my GNU Linux builds of Emacs (and also > my Windows builds, I'm fairly certain). The after-string and before-string > of a a more recently created overlay is displayed after the least > recently created overlay, all other overlay things being equal, > of course. That was never the case. The creation order has no direct relevance to the display order of overlays that cover the same text and have the same priority. What can affect the order is the address of each overlay in memory, but I don't think you can rely on memory-allocation routines to always allocate memory in the increasing order of addresses. So I don't think the code should rely on this assumption. Stefan, am I missing something? From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 16:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: kklimonda@syntaxhighlighted.com, monnier@iro.umontreal.ca, 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.16870202267194 (code B ref 64101); Sat, 17 Jun 2023 16:44:02 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 16:43:46 +0000 Received: from localhost ([127.0.0.1]:52543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAZ1d-0001ry-Hr for submit@debbugs.gnu.org; Sat, 17 Jun 2023 12:43:45 -0400 Received: from mail-oa1-f54.google.com ([209.85.160.54]:55395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAZ1b-0001rh-8s for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 12:43:44 -0400 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-19a427d7b57so1324585fac.2 for <64101@debbugs.gnu.org>; Sat, 17 Jun 2023 09:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687020217; x=1689612217; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=syEtt0XojFIi33ym/GEem+rlJcyttqAkIU83Y4pq7Sc=; b=ssupjhzt2igZzEm84T6LGvnw5cVQBDT2YxfFrhkZ526cqBoD2E+FgJjRjWWEVh/hyr zGRdorcmynk711iaKtX9piQmEO7z4ClxZIOu+lxGoq5sWQmRWIN3EqLFF4QKPQh2zleF juusAE9eBzlV27T4JGbN3QvgXoWollTrfo3VPWV8HtqvgQJ7t0XZrJhUK5cYK3L2aiJg UnLtke31do9evu3cg0/IX7ncm0c1PQ1XLBzQgGEDqkoXxr9u6lSZ12ehfIXqEznzAYeE djLnVuxS5AktYB5cJOZ0fiWgyH2zFhlWL8/euG39MZYgMfaxDNoXZ0aXHNg32CRu+nmN 6lkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687020217; x=1689612217; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=syEtt0XojFIi33ym/GEem+rlJcyttqAkIU83Y4pq7Sc=; b=IKT01ZeKo44C/dAlmAXFKF5MQyi+rFn3fLwW3H78xPkZBUq5e4ofBd8yx8NVa4++xb PvX472JJDEPDaWSvYfyVpFYAFNolXDURvhGAtLffLZ9J4B9NdU8Kh7LbeGleQw6Q/l2V /ob/f9Led07Pup4AmXkgVMBHLZ0nptPN20Nkv052R8hDaQM/xm/Ki7eG/e2uZegRChn4 FS32HgAanNgl22RPSpfDyNn2tIfNSfVqQd1QzpqUVMpDvwlExbKb4k3ECxb45jyTEp3C NOwMYDrbGQRST9Ofula7vunFRns4Ix0Vyt+TvxevsOFwXIS+GC7/1skZilXj0YLkS82I 6amQ== X-Gm-Message-State: AC+VfDx/bZUbsE0N0HGHg3zphWLzM3KJW7Ly8sVGKzPOWMv5SjO35al6 BFzzRBT/dczcfRagk4SiSbrEeUJ2LUL2Il8Pbw4= X-Google-Smtp-Source: ACHHUZ4yPDhcgy6lfheJpIlcz+LHBkWxKkfU5cvcyfObjCIEKQvlXwa5ouH/TcgiMTSixX3Au/RwwgePB4uLxhqNmfA= X-Received: by 2002:a05:6870:9712:b0:1a6:9a34:9acb with SMTP id n18-20020a056870971200b001a69a349acbmr1991671oaq.55.1687020217212; Sat, 17 Jun 2023 09:43:37 -0700 (PDT) MIME-Version: 1.0 References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <83edmaqskn.fsf@gnu.org> <87352q8ent.fsf@gmail.com> <835y7mqlcu.fsf@gnu.org> <834jn6qisd.fsf@gnu.org> <83zg4yozov.fsf@gnu.org> In-Reply-To: <83zg4yozov.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 17 Jun 2023 17:45:55 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Jun 17, 2023 at 4:50=E2=80=AFPM Eli Zaretskii wrote: > > > From: Jo=C3=A3o T=C3=A1vora > > Date: Sat, 17 Jun 2023 15:29:38 +0100 > > Cc: kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org, > > monnier@iro.umontreal.ca > > > > > What order did your code expect in that case? > > > > The current order that I see on all my GNU Linux builds of Emacs (and a= lso > > my Windows builds, I'm fairly certain). The after-string and before-st= ring > > of a a more recently created overlay is displayed after the least > > recently created overlay, all other overlay things being equal, > > of course. > > That was never the case. The creation order has no direct relevance > to the display order of overlays that cover the same text and have the > same priority. What can affect the order is the address of each > overlay in memory, but I don't think you can rely on memory-allocation > routines to always allocate memory in the increasing order of > addresses. It's not true that it "was never the case". Experimentally, it _is_ the case on all the Linux and (and Windows) builds I've ever used to test Eglot on. So instead of "never", I would say "most often, though not necessarily always" and document this, else people like me may assume that the behaviour they observe is guaranteed by the system. > So I don't think the code should rely on this assumption. That's perfectly fair. AFAICT, it doesn't anymore. Jo=C3=A3o From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 19:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , Krzysztof Klimonda , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168702855721827 (code B ref 64101); Sat, 17 Jun 2023 19:03:02 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 19:02:37 +0000 Received: from localhost ([127.0.0.1]:52647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAbC0-0005fy-QV for submit@debbugs.gnu.org; Sat, 17 Jun 2023 15:02:37 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAbBz-0005fl-9l for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 15:02:35 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 136A080686; Sat, 17 Jun 2023 15:02:30 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EC615805BF; Sat, 17 Jun 2023 15:02:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687028549; bh=EwJCbvxK1wFeDXm5vQ9N7hZvpZ2l81n8TtnirTYtu+E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=F2LDas71U+DY6V/Xh1/C0iZOGc1Dd2/0fBKVsdr00vzN0F00CS1Xgu33x2ES1vIpH PPlDhBHK4fHquKLoFCIHyfABD2bm+J5zKpp1qb53Yao61AMQjpQrz9CnFx4q58W0i8 PgX229vy2kHxa7EjQwtN/JyeEX1SfjDNmP7EF/b9Py1FJiJGNE2P0wcJlblANn3UfU P7+duRt0Esp5tzZ4272aX48TkuMYxySAjozUW+Wo/tBo2F/0NG87hp89A/2E8Ub08C +0uZHMgh5k7BcSui2wES5gydmZWT+X9r91D8F1yev1njPDoPfEtyqGRbtPpcT6UPaO kaFVwFdmuy/4Q== Received: from pastel (unknown [45.72.207.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C1191120A09; Sat, 17 Jun 2023 15:02:28 -0400 (EDT) From: Stefan Monnier In-Reply-To: <877cs28m23.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 17 Jun 2023 10:39:32 +0100") Message-ID: References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> Date: Sat, 17 Jun 2023 15:02:27 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Should the overlays created for the >> inlay hints be forced to be sorted in some particular order? > Maybe, and there is definitely an order they should be sorted. If they start and end at the exact same place, then the ordering by default is arbitrary (IIRC it's sorted by memory address, simply because we needed some cheap way to make the ordering total). If you need a particular ordering between such overlays, then you definitely need to use the `priority` property. > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -3755,8 +3755,9 @@ eglot--update-hints-1 > (if peg-after-p > (make-overlay (point) (1+ (point)) nil t) > (make-overlay (1- (point)) (point) nil nil nil))) > - (do-it (label lpad rpad firstp) > - (let* ((tweak-cursor-p (and firstp peg-after-p)) > + (do-it (label lpad rpad i) > + (let* ((firstp (zerop i)) > + (tweak-cursor-p (and firstp peg-after-p)) > (ov (make-ov)) > (text (concat lpad label rpad))) > (when tweak-cursor-p (put-text-property 0 1 'cursor 1 text)) > @@ -3767,17 +3768,18 @@ eglot--update-hints-1 > (1 'eglot-type-hint-face) > (2 'eglot-parameter-hint-face) > (_ 'eglot-inlay-hint-face)))) > + (overlay-put ov 'priority i) > (overlay-put ov 'eglot--inlay-hint t) > (overlay-put ov 'evaporate t) > (overlay-put ov 'eglot--overlay t)))) The `priority` property is a source of problem in itself so I'd recommend to use its weaker version where the value is a cons cell `(nil . SECONDARY)`. This way the SECONDARY priority will only be used as a last recourse (before using pointer addresses). The doc discourages this use because when I introduced it (for use by the Lisp reimplementation of the region highlighting, some time around Emacs-24) I wasn't too sure how it would play out. But I suspect we should change the doc to let people use it without a bad conscience (or maybe even encourage its use). Stefan From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order References: In-Reply-To: Resent-From: Milan Jovanovic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 64101@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1687035285903 (code B ref -1); Sat, 17 Jun 2023 20:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Jun 2023 20:54:45 +0000 Received: from localhost ([127.0.0.1]:52720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAcwV-0000ER-9O for submit@debbugs.gnu.org; Sat, 17 Jun 2023 16:54:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:42054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAcwQ-0000E9-PT for submit@debbugs.gnu.org; Sat, 17 Jun 2023 16:54:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAcwQ-0007Mx-Gt for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2023 16:54:38 -0400 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAcwO-0006wx-Ur for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2023 16:54:38 -0400 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-514ab6cb529so6209960a12.1 for ; Sat, 17 Jun 2023 13:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687035275; x=1689627275; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=z31Zxi/2dOBe+Cng3gwkhtwnqF7LsDhRBNkIqYXd1E8=; b=X3l3tgEfkpWNzuNFCuzfeh9Uxkysrbtrtpsj2BhF59jARhePbNC1+7gbjh4xghAkvB 5H9T4wRndXD33qzC/7e3dRyPaOeDYzNlOrzFz/DgIg/2L8vEccex85TtOxZOZ3iB/I1e QKKXaL8fokSdVKBDK059OgPzvs6ujVG/PkfcUGzfcUbs9fOpHtKEXwI5z8bZM5T4NKse /9+Um0FTYNoGSRZiAzJEAATMgWcD0IYY6qEUtm5VFEnUvCjn+Nl5JeD2mHeU4Vim7EBD 0UuODKqJQ8gqutafSyc2nAkHvoVmsJgOadfm4AIMHD+YHDzfVJJsntO4ihJoi5BUuciu P05w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687035275; x=1689627275; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z31Zxi/2dOBe+Cng3gwkhtwnqF7LsDhRBNkIqYXd1E8=; b=ks21LbHqt/JDMZCDWonHnQ2FNKWJfXasRnQ8L5fYgxBVjRDuk8dbFefBViM7vQ730q VlZwtqVue46EUMir2rayXr02dsh5bifqAPNPXtcIsUjcASPxgzyAqIh8uBIF8Smj74mI 1iXMYipNrnqhLhLz35ZvvNA9Wjd4Pt773WReIY3JRosBBwaHkkByl4d3X/jt8qcq0rlL n2IS50pT7WpetY/tRtdnAG18sQbcsrhFjmPbf106+Hn79AtGLMkV0P/F1cdai2V2QcBF hlnAwf416q9588Ao5oCer/2CMWssVTG0krQKRU5V+WmS3d36NfkK5+08ACkzCG5n/DUN RbxA== X-Gm-Message-State: AC+VfDwaSNruIna792poRXSbtHjmX0tBPIpHWnpKn6N3B6OTv7ixF0MO urhSkrkvwnksQI6gRhigWyyie8OJHRY= X-Google-Smtp-Source: ACHHUZ5kAE76aTpommXs5EIveM5fUptzyDyhlvOloNUZOhpK34MEl9SIHXHMZP7+GZmcvNUjfaxwkg== X-Received: by 2002:a17:907:72ce:b0:96f:a412:8b03 with SMTP id du14-20020a17090772ce00b0096fa4128b03mr5343020ejc.5.1687035274620; Sat, 17 Jun 2023 13:54:34 -0700 (PDT) Received: from smtpclient.apple ([87.116.166.45]) by smtp.gmail.com with ESMTPSA id bl5-20020a170906c24500b00982b8cd7a44sm3534551ejb.139.2023.06.17.13.54.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Jun 2023 13:54:33 -0700 (PDT) From: Milan Jovanovic Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Message-Id: <4A010D80-5F52-4FEF-A8E8-0250A7F3DA6F@gmail.com> Date: Sat, 17 Jun 2023 22:54:32 +0200 X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=milanj@gmail.com; helo=mail-ed1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, This fixes more complicated types that I had issue with but I=E2=80=99ve = noticed that it now breaks this example: let mut x =3D vec![1,2,3]; x.insert(1, 1)=20 with type hints inserted =3D> x.insert(: index0, : element1) > But maybe Milan/Krzystof can try this patch: > > diff =E2=80=94git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index a65795f1dfc..0c000f72ec7 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -3755,8 +3755,9 @@ eglot--update-hints-1 > (if peg-after-p > (make-overlay (point) (1+ (point)) nil t) > (make-overlay (1- (point)) (point) nil nil = nil))) > - (do-it (label lpad rpad firstp) > - (let* ((tweak-cursor-p (and firstp peg-after-p)) > + (do-it (label lpad rpad i) > + (let* ((firstp (zerop i)) > + (tweak-cursor-p (and firstp peg-after-p)) > (ov (make-ov)) > (text (concat lpad label rpad))) > (when tweak-cursor-p (put-text-property 0 1 = 'cursor 1=20 > text)) > @@ -3767,17 +3768,18 @@ eglot--update-hints-1 > (1 'eglot-type-hint-face) > (2 = 'eglot-parameter-hint-face) > (_ = 'eglot-inlay-hint-face)))) > + (overlay-put ov 'priority i) > (overlay-put ov 'eglot--inlay-hint t) > (overlay-put ov 'evaporate t) > (overlay-put ov 'eglot--overlay t)))) > - (if (stringp label) (do-it label left-pad right-pad = t) > + (if (stringp label) (do-it label left-pad right-pad = 0) > (cl-loop > for i from 0 for ldetail across label > do (eglot--dbind ((InlayHintLabelPart) value) = ldetail > (do-it value > (and (zerop i) left-pad) > (and (=3D i (1- (length label))) = right-pad) > - (zerop i)))))))))) > + i))))))))) > (jsonrpc-async-request > (eglot--current-server-or-lose) > :textDocument/inlayHint From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 22:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , Krzysztof Klimonda , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168704062020461 (code B ref 64101); Sat, 17 Jun 2023 22:24:01 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 22:23:40 +0000 Received: from localhost ([127.0.0.1]:52776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAeKa-0005Jw-8n for submit@debbugs.gnu.org; Sat, 17 Jun 2023 18:23:40 -0400 Received: from mail-ej1-f52.google.com ([209.85.218.52]:59623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAeKX-0005Jg-P9 for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 18:23:38 -0400 Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-9829a5ae978so326499466b.2 for <64101@debbugs.gnu.org>; Sat, 17 Jun 2023 15:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687040611; x=1689632611; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Cvm5IbdwKdS4yYIdOYxx8dGx+N76SY/o62DZ6mX5p88=; b=oCWWj2m5XP5mI+Kl/VDNm4nI8tCmiQDV7e6aq303dFPFRtG3C83XZMo0He1Ylzfjse Y0r8Jn5kpxlNfkk5xIAwLrZPfZkm6eqag4tpOKxCi8YXv1Blham/cLbVGyyR/XL0x/0A aXm2hSsk1quXX/A6sy79mOMZt8Jw2MzuW5NXhLtacQ6jfx8QJfB6wJbyrOjkdtSz7Xcn i3wiP1UBZKvMRapRvIBVsK0MnCHT84f3saKnGAfjUIYK1pOvTpBjGPhl5JEqVqg9tsTW q60tDkGhx81qMx5akXEoIWt4B+upib36vv5/Cw+mevYuxDCOWtFill0wVR+EKgzXTB8e sqVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687040611; x=1689632611; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Cvm5IbdwKdS4yYIdOYxx8dGx+N76SY/o62DZ6mX5p88=; b=JGEizffqdT/3kc63n74Ppvy4hLq56t6QGEvmUvESWjnQcOCQCtVGl++tAWTGVX7+II IKIb84L3/u0bfRyLjQ7QSV+p1ppxQTUvwBl6smsCJnqQdu/UGzqUS8pqyy96/0AzQ74D yn13JVvEFPg34QAPdflNV9IiN7D+EgJCpi1gl3ttu3N8gwEZr1H6ro9gisPaLBnSvqez hmUr05cD4+Uj1py3BgfGHzriqEmGvDCj1DJC2YWZEqk0iAvWC7yuS8dD7c6s1BHN+ZVe ARx1CGv1GMPLD3MmaVbdRtaitOm6ExzJiZtEm11KVZKVH37Ptvih1GUkFTxMKM1Tz5ia BCzQ== X-Gm-Message-State: AC+VfDzgCrFExpRk1ynUXSk27j8VPNx35RstO5Ph4/+5zuCQWqt/Q71Q jCj+GNi9QBmhO+BjqFgHy4FLoHOA3Oc= X-Google-Smtp-Source: ACHHUZ70F+k5AAz+BOP0EGy83Yw5c5CUqBeUeLGquXYcakjoUJuwY32pzMGhwh5+10YHU5jKDDCv7Q== X-Received: by 2002:a17:907:944a:b0:974:1e85:6a69 with SMTP id dl10-20020a170907944a00b009741e856a69mr6360299ejc.16.1687040611359; Sat, 17 Jun 2023 15:23:31 -0700 (PDT) Received: from krug ([87.196.73.15]) by smtp.gmail.com with ESMTPSA id e40-20020a5d5968000000b002fda1b12a0bsm27405209wri.2.2023.06.17.15.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jun 2023 15:23:30 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= In-Reply-To: (Stefan Monnier's message of "Sat, 17 Jun 2023 15:02:27 -0400") References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> Date: Sat, 17 Jun 2023 23:25:59 +0100 Message-ID: <87v8fl7mko.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >>> Should the overlays created for the >>> inlay hints be forced to be sorted in some particular order? >> Maybe, and there is definitely an order they should be sorted. > > If they start and end at the exact same place, then the ordering by > default is arbitrary (IIRC it's sorted by memory address, simply > because we needed some cheap way to make the ordering total). Understood. >> --- a/lisp/progmodes/eglot.el >> +++ b/lisp/progmodes/eglot.el >> @@ -3755,8 +3755,9 @@ eglot--update-hints-1 >> (if peg-after-p >> (make-overlay (point) (1+ (point)) nil t) >> (make-overlay (1- (point)) (point) nil nil nil))) >> - (do-it (label lpad rpad firstp) >> - (let* ((tweak-cursor-p (and firstp peg-after-p)) >> + (do-it (label lpad rpad i) >> + (let* ((firstp (zerop i)) >> + (tweak-cursor-p (and firstp peg-after-p)) >> (ov (make-ov)) >> (text (concat lpad label rpad))) >> (when tweak-cursor-p (put-text-property 0 1 'cur= sor 1 text)) >> @@ -3767,17 +3768,18 @@ eglot--update-hints-1 >> (1 'eglot-type-hint-face) >> (2 'eglot-parameter-hint-f= ace) >> (_ 'eglot-inlay-hint-face)= ))) >> + (overlay-put ov 'priority i) >> (overlay-put ov 'eglot--inlay-hint t) >> (overlay-put ov 'evaporate t) >> (overlay-put ov 'eglot--overlay t)))) > > The `priority` property is a source of problem in itself How so? What problem are you talking about. > so I'd recommend to use its weaker version where the value is a cons > cell `(nil . SECONDARY)`. This way the SECONDARY priority will only > be used as a last recourse (before using pointer addresses). This would make some sense, but I'm not sure I'm doing it correctly. If I replace the above line with (overlay-put ov 'priority `(nil . i)) Everything still works ... on my Linux builds. But then so does (overlay-put ov 'priority `(nil . (- 100 i))) Which I certainly _didn't_ expect to work! For sanity, I can verify that: (overlay-put ov 'priority `(- 100 i)) really does give me the inverse ordering, so at least I know that PRIMARY priorities are working. Jo=C3=A3o From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 22:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Milan Jovanovic Cc: 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168704117121346 (code B ref 64101); Sat, 17 Jun 2023 22:33:01 +0000 Received: (at 64101) by debbugs.gnu.org; 17 Jun 2023 22:32:51 +0000 Received: from localhost ([127.0.0.1]:52781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAeTT-0005YE-BW for submit@debbugs.gnu.org; Sat, 17 Jun 2023 18:32:51 -0400 Received: from mail-oi1-f169.google.com ([209.85.167.169]:42382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAeTR-0005Y1-0m for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 18:32:49 -0400 Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-39ca2539200so1458418b6e.1 for <64101@debbugs.gnu.org>; Sat, 17 Jun 2023 15:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687041163; x=1689633163; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vZ7WEfu4oGYi9pCF7VSZ0gFJjZZeUb631x0+79n/+yY=; b=a2lUabFYtC6pIAOI2RE4yBEdkuddN/UtyVkLRDB8i87y82KWiv2fhFtvANcqvHPONo kFoHeeVcJJit6VPmnCmvkmNwy1//e3uMlucM42DlmnEaDCdL6P16JZq7mRvHvBmqmGV1 aHd+pHx9JY8D7BR/+GXYW/Zk/l1n6UJAiagDbqX6qYu1XHYtvARcau3AcbKi0rBncdvM 5tRcK+3NJzlXG5qseuYg3dUzgWpV6LTwYUabHh/82wGA4ZVUzvZEJOfPgIn+5DkpKn2g yMkRcbCYJoyFFNwAVAVQMo51u/tOi0+ZoVZhM2TRTB4Qao+TPnOQTievNBS0g9GdIJJq ragw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687041163; x=1689633163; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vZ7WEfu4oGYi9pCF7VSZ0gFJjZZeUb631x0+79n/+yY=; b=lDKNa0AcDwqZNfNVDp5FQ4C4+N3PJnqck5EkIq01+b6pS6h/2CxhjU1JJIVf9MYetu S7AAIdA8fnn4KsYkm8xEIxVq3Gcnuleb/ML23r1dtORu0Py5M0IYUTqhWMj6qRkofuOA xmyAwjSbvDiIrMdsPewfQjlwZewDhIpIuMKV3rDmWnTvaVUQy1d4mo+sH2Pfl75sPIkV IkemyNWoHdPoxsFblUhUtoEvfqHKgdK7OuGmD1c81acK/kbaqdzYz0P0hsS8za5YCIv1 YmKoNXzFhogerYIZzsBCeI99wSc+k7P0QwMVw4273x030lAsKgtaXmcOQFkWEPUFs3we 79vg== X-Gm-Message-State: AC+VfDyjmzTxgi4X2+lLc3nwfUlKhb6e6N2CW1N1pq28bcmViAoaLjC3 cEmrIosVLNlhteZUuoOv5Yp2tcCkAq4DeTDhtic= X-Google-Smtp-Source: ACHHUZ7dDKz4lzljaZdMNe+QiNP4SGl15ten8XhjlgVGfkeMN0guX1l56oQZ9ljXkL91/ck+jstQO89MOQBUZ/aP3qM= X-Received: by 2002:aca:f184:0:b0:39e:b81d:b61d with SMTP id p126-20020acaf184000000b0039eb81db61dmr1752245oih.0.1687041163221; Sat, 17 Jun 2023 15:32:43 -0700 (PDT) MIME-Version: 1.0 References: <4A010D80-5F52-4FEF-A8E8-0250A7F3DA6F@gmail.com> In-Reply-To: <4A010D80-5F52-4FEF-A8E8-0250A7F3DA6F@gmail.com> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 17 Jun 2023 23:35:02 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Jun 17, 2023 at 9:55=E2=80=AFPM Milan Jovanovic = wrote: > Hi, > This fixes more complicated types that I had issue with but I=E2=80=99ve = noticed that it now breaks this example: > let mut x =3D vec![1,2,3]; > x.insert(1, 1) > with type hints inserted =3D> x.insert(: index0, : element1) I can't reproduce this either. In fact, in this case there are no coinciding overlays so I can't understand how this might have affected anything. To be clear, I don't have the Mac OS hardware triggers this problem (or the specific memory allocation libraries presumed to be the source of the different behaviour). This makes fixing the problem quite hard. Also, Milan, please next time it's fine to CC everybody in the thread ("reply to all"). Or at least just me, as it helps my workflow. Finally please try to provide complete error reproduction recipes starting from Emacs -Q so that there is a low chance of of interference from externa= l factors like your configuration and a higher chance that others try to investigate this problem. Jo=C3=A3o From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 00:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , Krzysztof Klimonda , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.16870491291562 (code B ref 64101); Sun, 18 Jun 2023 00:46:02 +0000 Received: (at 64101) by debbugs.gnu.org; 18 Jun 2023 00:45:29 +0000 Received: from localhost ([127.0.0.1]:52836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAgXo-0000P8-Vs for submit@debbugs.gnu.org; Sat, 17 Jun 2023 20:45:29 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:5086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAgXm-0000Oq-Fs for 64101@debbugs.gnu.org; Sat, 17 Jun 2023 20:45:27 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EC95144139C; Sat, 17 Jun 2023 20:45:20 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B4E6144137E; Sat, 17 Jun 2023 20:45:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687049119; bh=HgI1hdNJ582qCGRICiOk0V4wIGs/SKOYaQHTicHfdq0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jcRdb5rUts8zriSrwEXdu1Uf9edAC6hsE3YkpQJpIinMjuxTCA/wiLROFaqdKwb4e nGB85dbPjGWdZeS+fy1fh5SPcHheOgTGe2KughQLezAN664jteDzh+WOug476nzddJ 8lJ9RR+HYYCQ9O/KwFHsUF6KqdsY3apmHRwkrQY0oyxKg1dl2dyU9LMVQq3s+NCLe0 Vjme1IhsWyzR8UACnbZuk0ioeRHWAwtAIK6h6whoE0XU7cFjdg+2PsBvtJ7IPMavwD U4tc+Tuor6vNO36wWnSKNLMCnJWYJryRPtjBVzIl49Po0Qau3QZfz1se031dbSt0cn vYFs/4fdXgGMA== Received: from pastel (unknown [45.72.207.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 874DF1208FE; Sat, 17 Jun 2023 20:45:19 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87v8fl7mko.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 17 Jun 2023 23:25:59 +0100") Message-ID: References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> Date: Sat, 17 Jun 2023 20:45:18 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The `priority` property is a source of problem in itself > How so? What problem are you talking about. Most overlays don't have a `priority` property, so any overlay with a `priority` property set to a number greater than 0 will have priority over basically everything else, which is rarely what you want. Often, the resulting problems take a while to appear and when they do, it's in relation with some other package elsewhere, so that package's authors end up working around the problem by adding another `priority` property on their overlays, thus spreading the problem further. >> so I'd recommend to use its weaker version where the value is a cons >> cell `(nil . SECONDARY)`. This way the SECONDARY priority will only >> be used as a last recourse (before using pointer addresses). > > This would make some sense, but I'm not sure I'm doing it correctly. If > I replace the above line with > > (overlay-put ov 'priority `(nil . i)) Did you forget the comma? (overlay-put ov 'priority `(nil . ,i)) -- Stefan From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 08:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , Krzysztof Klimonda , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168707790519200 (code B ref 64101); Sun, 18 Jun 2023 08:46:02 +0000 Received: (at 64101) by debbugs.gnu.org; 18 Jun 2023 08:45:05 +0000 Received: from localhost ([127.0.0.1]:53141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAo1x-0004zc-Bb for submit@debbugs.gnu.org; Sun, 18 Jun 2023 04:45:05 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:59857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAo1u-0004yp-Vp for 64101@debbugs.gnu.org; Sun, 18 Jun 2023 04:45:04 -0400 Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-39ed35dfa91so108791b6e.3 for <64101@debbugs.gnu.org>; Sun, 18 Jun 2023 01:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687077897; x=1689669897; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K8MQVLYvaptqbpBVuSMY5/7i7rtU8bBaAcIR4gxVKK0=; b=RuX93lPHGgAQdOn8Co/i+vxP56Gz804S5p8nzRrn5VcNRov8QEWpEfQsBiRcwIwv+C 7bwLcvaW6zIdqtjBawL4VQ9Ri8aMkzAvhEI4lnw57gVqfb0ohBRR6B51XA0/rtQGl8P5 sCMMvZuE9yyxUzc/kP3e8nBe7jUlrMrygKSSCH0JTCtdI+BJMTkLCC04jXs9YCerfbro 8q4yCtJWU2+733XWtg7CP8eMsb0wNn0FljS+Kgeiqp9nM7wuUW4ryMaNbmC8twH+bBLW E7mNTtzQkO0MFSN7WvU/ytDEllukuNDgGhrTACaAtUB49FKSNBqesHbBEtXpepWD/bxo jU7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687077897; x=1689669897; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K8MQVLYvaptqbpBVuSMY5/7i7rtU8bBaAcIR4gxVKK0=; b=mG06JaQtskqIXozI/HT/wsTsycGQ13QosvCgQVFkFL7ymk50YnQKbVvKQdHi3Z/2G9 tvURuI4D4UhUlgRwnkxZ836Asj4IPoMv22HFFHtu1ItwhLhtSSf1qEOUbt0vhUo4ceJV eIp406zUINcHtzT0TWDQr6drUm9eDqXqsyY/mzLT5fORxlEUYg89xwiCO9u7MQB9PsZc Eb7zEcutxFJNrwdGpxCyYi29Z/g+goR0qcNqRqxlEmJL+SYU+YcIpvwznOQIzKy37Xuk Lx1EW+ZK7/+YzuN9A50NX/qXDYUCmNV+ILPN6RQpxJRVSWBlVmpin11X510QUeeI8irb rOlQ== X-Gm-Message-State: AC+VfDzwN2xYsu6ygSNrqhEJ759G6omb/b1Gs1TL05e26wmqFwB58fiz upOrGc1t0XD4k+zJUVeg8GskryCoHqFZR/pF5UI= X-Google-Smtp-Source: ACHHUZ5YxJA43mhroXCdEkKVYCs9oUzXqq3T3oIproiaHXT5bgRXiX+6XtQ3O2QE4it4M+L7cR+YD56y5B5j70N2yzo= X-Received: by 2002:a05:6808:408e:b0:394:2868:d51f with SMTP id db14-20020a056808408e00b003942868d51fmr5539213oib.4.1687077897214; Sun, 18 Jun 2023 01:44:57 -0700 (PDT) MIME-Version: 1.0 References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sun, 18 Jun 2023 09:47:16 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 18, 2023 at 1:45=E2=80=AFAM Stefan Monnier wrote: > > This would make some sense, but I'm not sure I'm doing it correctly. I= f > > I replace the above line with > > > > (overlay-put ov 'priority `(nil . i)) > > Did you forget the comma? > > (overlay-put ov 'priority `(nil . ,i)) Hehe, no, not in real life, only in the examples in my email, which are all messed up. Let me try again... Yep, SECONDARY doesn't seem to do anything =3D> correctly sorted overlays (overlay-put ov 'priority i) =3D> correctly sorted overlays (overlay-put ov 'priority (- 10 i) =3D> reverse sorted overlays (overlay-put ov 'priority `(nil . ,i) =3D> correctly sorted overlays (overlay-put ov 'priority `(nil . ,(- 10 i) =3D> correctly sorted overlays= (!) Also confirmed with M-x describe text properties that the priority property values are sane and look like (nil . 3). Jo=C3=A3o From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 14:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , Krzysztof Klimonda , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.16870979409793 (code B ref 64101); Sun, 18 Jun 2023 14:19:01 +0000 Received: (at 64101) by debbugs.gnu.org; 18 Jun 2023 14:19:00 +0000 Received: from localhost ([127.0.0.1]:54792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAtF5-0002Xs-QN for submit@debbugs.gnu.org; Sun, 18 Jun 2023 10:19:00 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAtF4-0002Xh-SF for 64101@debbugs.gnu.org; Sun, 18 Jun 2023 10:18:59 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9305B440955; Sun, 18 Jun 2023 10:18:53 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 232144408F1; Sun, 18 Jun 2023 10:18:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687097932; bh=35TtU/w7HDMZf9gFRFLA6IvwWnJtIzS4BI9Hb6OPUfw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=m7GQvsdAMjUoEHHokht1Ho9BBhRH61xHFX8s+/wFvJPDXopYSxZRbcdjviPNdKtk2 jpjqBUne0I8of+RaALTAhiP18jCrwVXp1Ney3Los6LkaSaJdkq06Yjmn8i5X0liVPO twaRIIA8A3fhH3aqsmNwXgKEkhQtJ6JJWF1ffJyyB3YqJ4G0BwDj7wuBgr/+YzEDFT OjW94pTHJh5JcdizXRRJO5ue4liMe129zJcf5zjlV3wijIrV/q0AGOm55YmUb9Eua4 DLzeW2BhIvsmSvwh0JnWEQNF9PyQSoPytUFviPDMaVbxsJjzq03+Fva8mSLVzhiDE6 CH4jlSmAvYwGw== Received: from pastel (unknown [45.72.207.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A9EB2120138; Sun, 18 Jun 2023 10:18:51 -0400 (EDT) From: Stefan Monnier In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 18 Jun 2023 09:47:16 +0100") Message-ID: References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> Date: Sun, 18 Jun 2023 10:18:50 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > This would make some sense, but I'm not sure I'm doing it correctly. If >> > I replace the above line with >> > >> > (overlay-put ov 'priority `(nil . i)) >> >> Did you forget the comma? >> >> (overlay-put ov 'priority `(nil . ,i)) > > Hehe, no, not in real life, only in the examples in my email, which > are all messed up. Let me try again... > > Yep, SECONDARY doesn't seem to do anything > > => correctly sorted overlays > (overlay-put ov 'priority i) => correctly sorted overlays > (overlay-put ov 'priority (- 10 i) => reverse sorted overlays > (overlay-put ov 'priority `(nil . ,i) => correctly sorted overlays > (overlay-put ov 'priority `(nil . ,(- 10 i) => correctly sorted overlays (!) Hmm... do you have a simple recipe that I could try? Do those overlays all really share the same start and end? IOW, can you check/show (mapcar (lambda (ol) `(,(overlay-start ol) ,(overlay-end ol) . ,(overlay-get ol 'priority))) (overlays-at t)) ? Stefan From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , Krzysztof Klimonda , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.16870980079945 (code B ref 64101); Sun, 18 Jun 2023 14:21:02 +0000 Received: (at 64101) by debbugs.gnu.org; 18 Jun 2023 14:20:07 +0000 Received: from localhost ([127.0.0.1]:54796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAtGB-0002aL-8J for submit@debbugs.gnu.org; Sun, 18 Jun 2023 10:20:07 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:52479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAtG9-0002Zg-6A for 64101@debbugs.gnu.org; Sun, 18 Jun 2023 10:20:05 -0400 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-3f8d0d68530so26570575e9.0 for <64101@debbugs.gnu.org>; Sun, 18 Jun 2023 07:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687097999; x=1689689999; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vM2of6mMlBTcurNef00maLeNLAx1wzrPB9UKCyqat44=; b=rHZBNJWH8oxKvL+ylesWclf+pJ8lkuOET949gC9zRV/qCsi/caUzoZ6t79vbVvOio8 p27glx/0KgbdrFDdjwPRg618K0QZ39ay7SB5fEeCRgVerdiHGlexOICczIU1k6cM+y8b fAYfV6YKzGaizfwe05ykVGIEWXmO/B3Sm/2jxvS3kNLSBc+gCNXPWgaWILf035sYdV58 /fAlJIjUzJs7f+frWecWDGsoZg72IaCtE2kuDUWOTvDWgyCVREKzjwv1oaffvsGMU/Cg 7wM+H4jseU/qJgPCOp3Gpfm+3h3X/CCAqYgIfVAJZGuXTy7/oRUUPnWQsnzOOMojzZWG NjuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687097999; x=1689689999; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vM2of6mMlBTcurNef00maLeNLAx1wzrPB9UKCyqat44=; b=N7/Xtpd+qqlZrre0HROInhtQNN6aPAXcmzMfGuSdNm2Q/P5axc6kfQWXvT4PNcxxPK 8jVl6xufaYItJmTRNTSn+69OWAbpBeInYLkCSCtP/IH6KmowYCwe3gjACTtXpL9XIHto moXOIej7fedaILkO62wb1OpY6gQrxdFVHhsolvfins+UCcUTPV58iIO+c4onqvKVronV EE+dR37xuLYcjr/mfqV3x6MtKx7JpTcChGh9X/5rRg1vp/3b/ccf2WGhelqlfA99bnkP V4/u5051TmJJjeZyrVGZzTDDEsZAfl15u/b1EmRy+/NXTv6dds2x7KILQNryyu4CzrMz m5hA== X-Gm-Message-State: AC+VfDyK4emHnR0HKx0I55hU1ydLmSGX4rg9QdrrZd8K/WzJBf6zb9vc kjuNxOfZ94WApTPRhWYda+Ei6BytG3o= X-Google-Smtp-Source: ACHHUZ52y7PCZJpmFBQh2788lHirFxMxk9bEml5iEHSClbFfeZMeRvn/Jf3l0YbYVjyyPhk4t+ealA== X-Received: by 2002:a7b:cb8b:0:b0:3f8:f5d:52ee with SMTP id m11-20020a7bcb8b000000b003f80f5d52eemr5782419wmi.23.1687097998923; Sun, 18 Jun 2023 07:19:58 -0700 (PDT) Received: from krug ([87.196.73.15]) by smtp.gmail.com with ESMTPSA id l5-20020a1ced05000000b003f70a7b4537sm7845445wmh.36.2023.06.18.07.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jun 2023 07:19:58 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= In-Reply-To: (Stefan Monnier's message of "Sat, 17 Jun 2023 20:45:18 -0400") References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> Date: Sun, 18 Jun 2023 15:22:25 +0100 Message-ID: <87mt0w7sv2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >>> The `priority` property is a source of problem in itself >> How so? What problem are you talking about. > > Most overlays don't have a `priority` property, so any overlay with > a `priority` property set to a number greater than 0 will have priority > over basically everything else, which is rarely what you want. > > Often, the resulting problems take a while to appear and when they do, > it's in relation with some other package elsewhere, so that package's > authors end up working around the problem by adding another `priority` > property on their overlays, thus spreading the problem further. Right, that makes sense. It's more or less what I feared too, though this is all speculative at this point. Anyway, can you explain this? Take this scratch buffer ;; This buffer is for text that is not saved, and for Lisp evaluation. ;; To create a file, visit it with C-x C-f and enter text in its buffer. =20=20=20=20 (progn (mapc #'delete-overlay (overlays-in (point-min) (point-max))) (let ((a (make-overlay 10 20)) (b (make-overlay 10 20))) (overlay-put a 'after-string (propertize "aaaa" 'face 'highlight)) (overlay-put b 'after-string (propertize "bbbb" 'face 'speedbar-high= light-face)) ;; (overlay-put a 'priority 1) ;; (overlay-put b 'priority 2) (overlay-put a 'priority `(nil . 1)) (overlay-put b 'priority `(nil . 2)) )) This displays AAAABBBB eventually, but I would expect it to show BBBBAAAA, which is what I get if I use "primary" priorities. Jo=C3=A3o =20 From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 14:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , Krzysztof Klimonda , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168709857510892 (code B ref 64101); Sun, 18 Jun 2023 14:30:01 +0000 Received: (at 64101) by debbugs.gnu.org; 18 Jun 2023 14:29:35 +0000 Received: from localhost ([127.0.0.1]:54807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAtPL-0002pc-0Y for submit@debbugs.gnu.org; Sun, 18 Jun 2023 10:29:35 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAtPJ-0002pN-SB for 64101@debbugs.gnu.org; Sun, 18 Jun 2023 10:29:34 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9F97E1000C4; Sun, 18 Jun 2023 10:29:28 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8F2D0100083; Sun, 18 Jun 2023 10:29:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687098567; bh=4ncqFy1rxHL90yeHPd74r96Klr1q+7GeDQBabxJRlOw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bLBLd4LBaObjvmjKEXcURfWZVyk+UHMcKZcIqgvVJZnD9vEloIZA1XgNorczgsyTY bF8Ipriq0rHT8rCYwhmHlvc500RD/fSHM5+IFFP6jNdr3xxx1Miich5dO3BotBRnN2 IwHiPyyAqi51ZJXSgfGmRR+E0IwRS9MhpbUwFjchNNGofR3sRFYQBOH9p0mKm9S10y oi393DOXNo/k/VC3xVGbvC3rKi1CECQQARuz2cnCbSJ/D88KMTfspnMpMwqo7eBtV5 0wk2rjcmlKPtMWeTXXYsi+XL3cuZOi4JywgOADQ2X5YU8+MfFipyAENGkER/sMjiwv PkwEkOFpAm9fg== Received: from pastel (unknown [45.72.207.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5FE8D1205D9; Sun, 18 Jun 2023 10:29:27 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87mt0w7sv2.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 18 Jun 2023 15:22:25 +0100") Message-ID: References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> Date: Sun, 18 Jun 2023 10:29:26 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.168 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Right, that makes sense. It's more or less what I feared too, though > this is all speculative at this point. Anyway, can you explain this? Nope :-( > Take this scratch buffer > > ;; This buffer is for text that is not saved, and for Lisp evaluation. > ;; To create a file, visit it with C-x C-f and enter text in its buffer. > > (progn > (mapc #'delete-overlay (overlays-in (point-min) (point-max))) > (let ((a (make-overlay 10 20)) > (b (make-overlay 10 20))) > (overlay-put a 'after-string (propertize "aaaa" 'face 'highlight)) > (overlay-put b 'after-string (propertize "bbbb" 'face 'speedbar-highlight-face)) > ;; (overlay-put a 'priority 1) > ;; (overlay-put b 'priority 2) > (overlay-put a 'priority `(nil . 1)) > (overlay-put b 'priority `(nil . 2)) > )) > > This displays AAAABBBB eventually, but I would expect it to show > BBBBAAAA, which is what I get if I use "primary" priorities. I can indeed reproduce the different rendering here, yet the sorting done by `overlays-at` is the same in both cases, so it looks like we sort some other way somewhere (presumably somewhere in the C code). Stefan From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 14:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , Krzysztof Klimonda , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168709898311599 (code B ref 64101); Sun, 18 Jun 2023 14:37:02 +0000 Received: (at 64101) by debbugs.gnu.org; 18 Jun 2023 14:36:23 +0000 Received: from localhost ([127.0.0.1]:54812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAtVu-000311-T9 for submit@debbugs.gnu.org; Sun, 18 Jun 2023 10:36:23 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAtVt-00030n-DJ for 64101@debbugs.gnu.org; Sun, 18 Jun 2023 10:36:21 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 24C6C805E3; Sun, 18 Jun 2023 10:36:16 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AEAC98004C; Sun, 18 Jun 2023 10:36:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687098974; bh=syfAa1D+yP3Z86Wqe0aD+fJlhac+8r6lp+uYUFbpnOs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WBOwkoFhnrMf9Suo27b/zDWXWJVQ2Lvxg+h0zFUjwQCzM7ePWi5Ielj+JVUaCSiKT uf14RmDRZLgTN46xpNN6t0Ng7yXb6Bd+1sBSEVo7g5xGspNeJ5zjLU9ULaOxZKSHNU /vD3r3yJTWO6y95qG4JEaRYSWrznEAoUOj69hLFPx/GMLXJsHlixIaud1ILir9YnxM 1LVvX/D5ie5rkxF8nvWn545yuC3v/UsOyk7OqTZfWfPFhJ9QKE1DeEUONoPHZzk1Db +cx82D5MV50Z6fAZl2XQHBjeo+Jz8lpFg9Rs57dC49/0GF+d985FuWSyjOF5tQ5rIJ C0hkwGP1H+8JA== Received: from pastel (unknown [45.72.207.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6BEC0120500; Sun, 18 Jun 2023 10:36:14 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87mt0w7sv2.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 18 Jun 2023 15:22:25 +0100") Message-ID: References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> Date: Sun, 18 Jun 2023 10:36:13 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > ;; This buffer is for text that is not saved, and for Lisp evaluation. > ;; To create a file, visit it with C-x C-f and enter text in its buffer. > > (progn > (mapc #'delete-overlay (overlays-in (point-min) (point-max))) > (let ((a (make-overlay 10 20)) > (b (make-overlay 10 20))) > (overlay-put a 'after-string (propertize "aaaa" 'face 'highlight)) > (overlay-put b 'after-string (propertize "bbbb" 'face 'speedbar-highlight-face)) > ;; (overlay-put a 'priority 1) > ;; (overlay-put b 'priority 2) > (overlay-put a 'priority `(nil . 1)) > (overlay-put b 'priority `(nil . 2)) > )) > > This displays AAAABBBB eventually, but I would expect it to show > BBBBAAAA, which is what I get if I use "primary" priorities. Hmm... I see that the (PRIMARY . SECONDARY) priority format is only understood by `make_sortvec_item`, but not by xdisp.c:RECORD_OVERLAY_STRING nor by buffer.c:record_overlay_string. > Anyway, can you explain this? [ Revised answer: ] Yes. Stefan From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jun 2023 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , Krzysztof Klimonda , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168710161916863 (code B ref 64101); Sun, 18 Jun 2023 15:21:02 +0000 Received: (at 64101) by debbugs.gnu.org; 18 Jun 2023 15:20:19 +0000 Received: from localhost ([127.0.0.1]:54836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAuCR-0004Nv-0p for submit@debbugs.gnu.org; Sun, 18 Jun 2023 11:20:19 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAuCP-0004Ng-B4 for 64101@debbugs.gnu.org; Sun, 18 Jun 2023 11:20:17 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A5E9D44087E; Sun, 18 Jun 2023 11:20:11 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DFEEB44094F; Sun, 18 Jun 2023 11:20:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687101605; bh=7zEAW0N5M7MI+XkF3wiztdz44rvJrTbUvYCtgDAEpQA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=g8/Dx7pEJJR+UlAE88Ueyw8qCS3uhjD6XU4RAiSV/71/2QwqQYMVOctLVOm3mIeOt 6K1ibdSExZma71pcK5uYq7Gn+CCMbMfwMbu+E//MhiqkHlpafDYHjFozoYImQ3Ovo/ kMx93vgNuM+qlacgp+rufa/5+K+TWGMpM+erzrCwHEEkWOCafT6WhkzfMeB1dinM/S LpnsZJCRS28T1WqlV0r7LS9fsE8h9lTag3eHLsq5qpsyWbJk9bcTopvvWDY4NySE5h 3PpRgNW2sk7cLCoLSxeQWzIB6JLLplnvQ1e4Kbj/9Dup5lfRAlIQkTmx0qrpfsW7tL hnt6TuEMQzCRg== Received: from pastel (unknown [45.72.207.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AA8FF1204A2; Sun, 18 Jun 2023 11:20:05 -0400 (EDT) From: Stefan Monnier In-Reply-To: (Stefan Monnier's message of "Sun, 18 Jun 2023 10:36:13 -0400") Message-ID: References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> Date: Sun, 18 Jun 2023 11:20:05 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Anyway, can you explain this? > [ Revised answer: ] Yes. The patch below won't fix it, but maybe it can help someone else write an actual fix? AFAICT the place that needs fixing is the one in xdisp.c Stefan diff --git a/src/buffer.c b/src/buffer.c index 0c46b201586..26938dc5f78 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -3376,6 +3376,10 @@ record_overlay_string (struct sortstrlist *ssl, Lisp_Object str, that string via PSTR, if that variable is non-NULL. The storage of the concatenated strings may be overwritten by subsequent calls. */ +/* AFAICT, this is used only by indent.c:compute_motion, + which does not actually care about the ordering of the strings + but only its total width. */ + ptrdiff_t overlay_strings (ptrdiff_t pos, struct window *w, unsigned char **pstr) { @@ -3416,6 +3420,7 @@ overlay_strings (ptrdiff_t pos, struct window *w, unsigned char **pstr) endpos - startpos); } + /* FIXME: Use `sort_overlays` instead? */ if (overlay_tails.used > 1) qsort (overlay_tails.buf, overlay_tails.used, sizeof (struct sortstr), cmp_for_strings); diff --git a/src/xdisp.c b/src/xdisp.c index 8bcf2acfe04..f487dfbb5ba 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -6794,6 +6794,7 @@ #define RECORD_OVERLAY_STRING(OVERLAY, STRING, AFTER_P) \ /* Sort entries. */ if (n > 1) + /* FIXME: Use `sort_overlays` instead? */ qsort (entries, n, sizeof *entries, compare_overlay_entries); /* Record number of overlay strings, and where we computed it. */ From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Milan Jovanovic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jun 2023 16:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , Krzysztof Klimonda , Stefan Monnier , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168719143616284 (code B ref 64101); Mon, 19 Jun 2023 16:18:01 +0000 Received: (at 64101) by debbugs.gnu.org; 19 Jun 2023 16:17:16 +0000 Received: from localhost ([127.0.0.1]:57104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBHZ5-0004Ea-Up for submit@debbugs.gnu.org; Mon, 19 Jun 2023 12:17:16 -0400 Received: from mail-ej1-f53.google.com ([209.85.218.53]:45295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBHZ4-0004EJ-6y for 64101@debbugs.gnu.org; Mon, 19 Jun 2023 12:17:14 -0400 Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-9887ebe16d0so222285566b.2 for <64101@debbugs.gnu.org>; Mon, 19 Jun 2023 09:17:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687191428; x=1689783428; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=agfxYVlGzrypereYH4QP9pTrGV5bWouodieQur8yLD8=; b=GEq4HmeZt6R9H534b+7YwWGHVX/ZOj6zeK68SkG846OBJ9UL/XRKnqbWwVmwWhR0QH INeGcT6v9CEfL5STVi8+BG/JDRPvQsn6kEWeTJQkXnlCjBOtrbPbZHF6zN3F3TMEVkWD k2b8S97QYiSEyqJ5n/An0cxvzvKfEmk8W0pa6223wf/sUqTzFEHleLVTCIPi+DZl8Var 8sKAtxcI7AcILKnX3bfhaPIxy5e42D5r18BOrGgSN8hO13DEczQKHZNG2/F/MIlB8lvK dFD81mpBcO63HnxQsXgkka+8LtK+lWmjBWPbT5g56w1eqfb2naNp3GXiyV2ElJvVGqRV EsHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687191428; x=1689783428; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=agfxYVlGzrypereYH4QP9pTrGV5bWouodieQur8yLD8=; b=D/xzox7vtN6o5hC1Tf42ao/x/ELptXHUIOF6ZSXYG5Hr1D6YW5mcEUYhi2KKGk4elj 29mkFGdp59D0J2cTL2wFVsUpjXeaPTapWQy2DtU++mYrH+v9KAa+BQySLGtgFdudr+ch yTPIABv6M/MPCsEXDz5mRAVyU6sFlafFOasY2SsF82fEOIVDZ6Vv9e6ry8fx9+mE31u7 UuWozKrl+Xiy+OyHQNxW6q1snbAupHdn7b0KfV5ZOJmSPpMrHfZcZ96Uvh3omqFww4Vp MHMQ27fpY5OgKTi+8Gk+fPh2k81WHbIuvmxbynapaFI0SyRdd3jX98HfhdOY9yeFNito QSMA== X-Gm-Message-State: AC+VfDyGMs2I5QIXG6jr1bZlGSLLFiYM98HrJcUH6bo9PIApMRCoxlqY jzqf2o7k/GWh0e3wvzA6MyU7lcnGKNUhFw== X-Google-Smtp-Source: ACHHUZ5ZSFrjkZzH+ytMRli6bjql4k54FpoWEVm2ysanI5DN89s2n1uLiPGsXF8O6af5E1zojcxpvw== X-Received: by 2002:a17:906:da83:b0:982:ab8d:1e08 with SMTP id xh3-20020a170906da8300b00982ab8d1e08mr9794244ejb.59.1687191428148; Mon, 19 Jun 2023 09:17:08 -0700 (PDT) Received: from smtpclient.apple (109-93-79-245.static.isp.telekom.rs. [109.93.79.245]) by smtp.gmail.com with ESMTPSA id n24-20020a170906165800b00977c7566ccbsm14804436ejd.164.2023.06.19.09.17.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jun 2023 09:17:07 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) From: Milan Jovanovic In-Reply-To: <87mt0w7sv2.fsf@gmail.com> Date: Mon, 19 Jun 2023 18:17:06 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o, is there a reason why (in Eglot) hint parts can=E2=80=99t be = merged and only one overlay created ? I fix it to create one overlay and I haven=E2=80=99t noticed any issues = (I use it only with the rust-analyzer though). Don=E2=80=99t know if this is stupid question, don=E2=80=99t know much = about LSP protocol (or Emacs internals). Milan > On 18. 6. 2023., at 16:22, Jo=C3=A3o T=C3=A1vora = wrote: >=20 > Stefan Monnier writes: >=20 >>>> The `priority` property is a source of problem in itself >>> How so? What problem are you talking about. >>=20 >> Most overlays don't have a `priority` property, so any overlay with >> a `priority` property set to a number greater than 0 will have = priority >> over basically everything else, which is rarely what you want. >>=20 >> Often, the resulting problems take a while to appear and when they = do, >> it's in relation with some other package elsewhere, so that package's >> authors end up working around the problem by adding another = `priority` >> property on their overlays, thus spreading the problem further. >=20 > Right, that makes sense. It's more or less what I feared too, though > this is all speculative at this point. Anyway, can you explain this? > Take this scratch buffer >=20 > ;; This buffer is for text that is not saved, and for Lisp = evaluation. > ;; To create a file, visit it with C-x C-f and enter text in its = buffer. >=20 > (progn > (mapc #'delete-overlay (overlays-in (point-min) (point-max))) > (let ((a (make-overlay 10 20)) > (b (make-overlay 10 20))) > (overlay-put a 'after-string (propertize "aaaa" 'face = 'highlight)) > (overlay-put b 'after-string (propertize "bbbb" 'face = 'speedbar-highlight-face)) > ;; (overlay-put a 'priority 1) > ;; (overlay-put b 'priority 2) > (overlay-put a 'priority `(nil . 1)) > (overlay-put b 'priority `(nil . 2)) > )) >=20 > This displays AAAABBBB eventually, but I would expect it to show > BBBBAAAA, which is what I get if I use "primary" priorities. >=20 > Jo=C3=A3o >=20 >=20 >=20 >=20 >=20 >=20 From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jun 2023 16:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Milan Jovanovic Cc: Eli Zaretskii , Krzysztof Klimonda , Stefan Monnier , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168719246718390 (code B ref 64101); Mon, 19 Jun 2023 16:35:01 +0000 Received: (at 64101) by debbugs.gnu.org; 19 Jun 2023 16:34:27 +0000 Received: from localhost ([127.0.0.1]:57138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBHpi-0004mX-Ol for submit@debbugs.gnu.org; Mon, 19 Jun 2023 12:34:27 -0400 Received: from mail-oa1-f41.google.com ([209.85.160.41]:60647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBHpg-0004mH-Az for 64101@debbugs.gnu.org; Mon, 19 Jun 2023 12:34:25 -0400 Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-1aa291b3fc4so1078682fac.0 for <64101@debbugs.gnu.org>; Mon, 19 Jun 2023 09:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687192458; x=1689784458; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R9oWB5nE0ZkhKndr8TT+bVb+58GF26Ms+pw1W76FTXQ=; b=AvuXt7t5tTw/b9twTETk+4MVtdDouJtJF+qpmS1pwNK9u7UEIxSNxlrZIDgF0VEGYD LGod9hGw0cmvuzGzYWDGe7DGHAezAIjfSFUY7Bmu86HQPBiprVFhU70UYg2RLz1uHx5/ g6ImcJyTj9b9yrGowrORi9+N11C+Ztpdif7vQHv68F6+QE5gIBrNzJ4se/Rimi500jls NZc9NGWjm/hGxgpnY8xi5oQgFEaTdFa35z7ih1NvEEAqR6RSWHHv1N9djy6RPUSHwkkM 95dCO3Xn8XV2a0meO9ydeqotlY7HkBYuSMc0Yi1YOj+iorv/hrYXAqVmqoNZd6/lKzU3 8bnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687192458; x=1689784458; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R9oWB5nE0ZkhKndr8TT+bVb+58GF26Ms+pw1W76FTXQ=; b=kW/nFa+BUaUaQrd50x9lCuk57daBaBLkhq+CUxSilKkdb4/yPEjajYtUR3NrZ8nAAb X/p10+Do+EzP4OKiXpY2xGbZXH+cxsM5VfGr+gAUUqXYn+IogEJ3pk6pTij4Q2ZkCV7I 12yDOcaPSx+Y+8WY/n9lLX1cYGYBI4ugqA9xaAnoV7lOkPdoKTCLqx4APH2CsBW13qat WFwYESKXhVsmiGd7XH8rdheOoLedBfLI4PHYckE3jjZM6E0NulRZ+zfVjSQyhJRhTV8h 6L8GydxYPdS7iq4bUiN/QwI85ftNmQbY9BCP3mv91SjyuvbbvSJoYmcVK0AxvRa2zp7i 4Y3w== X-Gm-Message-State: AC+VfDyZGaZo6Airom5KeJmDekuKNNWmB9pFR9gBiR/O4ngxXa5ysKe+ omuFRfsIT+Y3l/fNVL9v+/689NQ5mpuyptkoGpo= X-Google-Smtp-Source: ACHHUZ7Zrt8Nf3N1ine45Ev04qMUqhSSbfXygjxdgjeZgV4MuUtFraqTLIl3Am0MblKbob2UDRuQqXlu5X95xqMeRmQ= X-Received: by 2002:a05:6870:d2a5:b0:1a0:2fd0:355f with SMTP id d37-20020a056870d2a500b001a02fd0355fmr1332372oae.12.1687192458660; Mon, 19 Jun 2023 09:34:18 -0700 (PDT) MIME-Version: 1.0 References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> In-Reply-To: <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Mon, 19 Jun 2023 17:34:07 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Jun 19, 2023 at 5:17=E2=80=AFPM Milan Jovanovic = wrote: > > Jo=C3=A3o, is there a reason why (in Eglot) hint parts can=E2=80=99t be = merged and only one overlay created ? Yes, in general you want to keep different properties of different labels, such as URL links isolated. > I fix it to create one overlay and I haven=E2=80=99t noticed any issues (= I use it only with the rust-analyzer though). > Don=E2=80=99t know if this is stupid question, don=E2=80=99t know much a= bout LSP protocol (or Emacs internals). It's not a stupid question at all, and it's a possibility, but I have to understand the problem first, and if you haven't yet understood that, I don't have a Mac OS machine to test. Before trying fixes, or at least while you're trying them, please I urge you to provide a reproduction recipe for whatever you're trying to do. Your last follow-up bug report is completely strange to me: in the situation you last described there aren't any multiple coinciding overlays like in the original report of Krzysztof. Jo=C3=A3o From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Milan Jovanovic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jun 2023 18:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , Krzysztof Klimonda , Stefan Monnier , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168719801928078 (code B ref 64101); Mon, 19 Jun 2023 18:07:01 +0000 Received: (at 64101) by debbugs.gnu.org; 19 Jun 2023 18:06:59 +0000 Received: from localhost ([127.0.0.1]:57261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBJHG-0007Io-FA for submit@debbugs.gnu.org; Mon, 19 Jun 2023 14:06:58 -0400 Received: from mail-lf1-f54.google.com ([209.85.167.54]:58792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBJHD-0007IZ-VC for 64101@debbugs.gnu.org; Mon, 19 Jun 2023 14:06:56 -0400 Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4f86bc35f13so2391938e87.1 for <64101@debbugs.gnu.org>; Mon, 19 Jun 2023 11:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687198010; x=1689790010; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R++PpawosrPeU8GGAcheA4mBTi8VbNcokv8QXOXjqeI=; b=mVzomuMRpeJqVNX4FA0FN+WT6Q1yQ6a2JZd8ZDfJSl15sPMam20VRNoCAy8yzXjCkg Qiz8bxp4v2w+x5+aUugVRq+6za3EjuxYzfQFsiFfP0yVT3cHthsELJV9rUe+ycRXyq0P TXVhcW0VEdegnsu5hxW/84g75ige9fUzRbMQWU71C4KAAURXt7W2F69DqwykTS/UqbZx BP5r5lh9I72U5898d8v51Gb+TUD8irewXRxmpKEklroRF8mF6Y6PY5StI/2OsbP3oQRk Qq1osT/g1lpXPulrozMg29s0AlZDV174nGP6h8wnQ7EFAQJTgLpNJ+N+mV9kZs14m4y2 FwfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687198010; x=1689790010; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R++PpawosrPeU8GGAcheA4mBTi8VbNcokv8QXOXjqeI=; b=BTFm2wi5EtUttqnQ16x4nkAUnam5ZebPfhvyANvX6+V/KI/pHS3l5nYvdasQBAPksB FJ5R2SAhZ+MmLnBckzBl0iv4nxtjmAWH9k1bS2yl2YJ9POux22h3zIDO4UPraq1jRwnv RLUN7rego4CUTfQsqFtMlFXzaoyqFvMDzT6ffvYj+VjdgdjWG5pCaO58YKl1ny9Ek9OM yJN+RdTXfnhk+tbbSVylTq4rmvKsSkXTKJg/j2wMj6pYQJ/YZzHPCeIzuAnQwp60SmCt dYR/zjoX1jojRGG1zDtnFK4zzsXowW8HpB3d+rDHCooeoAysep/1MQDvy4pw94GEoVpK Juow== X-Gm-Message-State: AC+VfDyAtq8llXFXsm8wP57S2UzWTRyflVOrzRPdGCBTQkQ+kJoFHRs7 ZeATuDy2v8Pa1M270qxiMXg= X-Google-Smtp-Source: ACHHUZ4QkfS20ltKGYkfxe9/OcDS2U7Ebyoyv0V1DPfFO0C9lj50oOxaxhsQhEUdq67oXd90Jf1cuQ== X-Received: by 2002:ac2:5bca:0:b0:4f8:67e7:8a1c with SMTP id u10-20020ac25bca000000b004f867e78a1cmr3331692lfn.45.1687198009413; Mon, 19 Jun 2023 11:06:49 -0700 (PDT) Received: from smtpclient.apple (109-93-79-245.static.isp.telekom.rs. [109.93.79.245]) by smtp.gmail.com with ESMTPSA id n19-20020a05640206d300b0051a48829a7dsm24787edy.96.2023.06.19.11.06.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jun 2023 11:06:48 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) From: Milan Jovanovic In-Reply-To: Date: Mon, 19 Jun 2023 20:06:47 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On 19. 6. 2023., at 18:34, Jo=C3=A3o T=C3=A1vora = wrote: >=20 > On Mon, Jun 19, 2023 at 5:17=E2=80=AFPM Milan Jovanovic = wrote: >>=20 >> Jo=C3=A3o, is there a reason why (in Eglot) hint parts can=E2=80=99t = be merged and only one overlay created ? >=20 > Yes, in general you want to keep different properties of different > labels, such as URL links isolated. Not sure that I understand, I was talking about merging =E2=80=9Cvalues=E2= =80=9D of one =E2=80=9Clabel=E2=80=9D, I don=E2=80=99t see that inlay = hints code is using any other property from response (other than :value) >> I fix it to create one overlay and I haven=E2=80=99t noticed any = issues (I use it only with the rust-analyzer though). >> Don=E2=80=99t know if this is stupid question, don=E2=80=99t know = much about LSP protocol (or Emacs internals). >=20 > It's not a stupid question at all, and it's a possibility, but > I have to understand the problem first, and if you haven't > yet understood that, I don't have a Mac OS machine to test. >=20 > Before trying fixes, or at least while you're trying them, > please I urge you to provide a reproduction recipe for whatever > you're trying to do. Your last follow-up bug report is completely = strange > to me: in the situation you last described there aren't any > multiple coinciding overlays like in the original report of Krzysztof. >=20 > Jo=C3=A3o So, you fix did solve original Krzysztof report (and my original report) = for more complex type hints but now I have the same issue with argument = hints. Example: fn main () { let mut c =3D vec![1,2,3]; c.insert(0, 0); } Inlay type hint of =E2=80=9Cc=E2=80=9D is ok but argument hints for = insert() are presented in wrong order: Instead of "c.insert(=E2=80=98index:=E2=80=99 0, =E2=80=98element: = =E2=80=98 0)" i=E2=80=99m getting "c.insert(=E2=80=98: index=E2=80=990, =E2=80=98: = element=E2=80=990)=E2=80=9D Trace for this part: 1 -> (make-overlay 384 385 nil nil nil) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # after-string = #("index" 0 5 (face eglot-parameter-hint-face))) 1 <- overlay-put: #("index" 0 5 (face eglot-parameter-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 0) 1 <- overlay-put: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # = eglot--inlay-hint t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay = t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 384 385 nil nil nil) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # after-string = #(": " 0 2 (face eglot-parameter-hint-face))) 1 <- overlay-put: #(": " 0 2 (face eglot-parameter-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 1) 1 <- overlay-put: 1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # = eglot--inlay-hint t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay = t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 387 388 nil nil nil) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # after-string = #("element" 0 7 (face eglot-parameter-hint-face))) 1 <- overlay-put: #("element" 0 7 (face eglot-parameter-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 0) 1 <- overlay-put: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # = eglot--inlay-hint t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay = t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 387 388 nil nil nil) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # after-string = #(": " 0 2 (face eglot-parameter-hint-face))) 1 <- overlay-put: #(": " 0 2 (face eglot-parameter-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 1) 1 <- overlay-put: 1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # = eglot--inlay-hint t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay = t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 517 518 nil t) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # before-string = #(": " 0 1 (face eglot-type-hint-face cursor 1) 1 2 (face = eglot-type-hint-face))) 1 <- overlay-put: #(": " 0 1 (face eglot-type-hint-face cursor 1) 1 2 = (face eglot-type-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 0) 1 <- overlay-put: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # = eglot--inlay-hint t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay = t) 1 <- overlay-put: t From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jun 2023 19:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Milan Jovanovic Cc: Eli Zaretskii , Krzysztof Klimonda , Stefan Monnier , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.16872017052311 (code B ref 64101); Mon, 19 Jun 2023 19:09:01 +0000 Received: (at 64101) by debbugs.gnu.org; 19 Jun 2023 19:08:25 +0000 Received: from localhost ([127.0.0.1]:57310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBKEi-0000bC-Bl for submit@debbugs.gnu.org; Mon, 19 Jun 2023 15:08:24 -0400 Received: from mail-oo1-f53.google.com ([209.85.161.53]:53555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBKEg-0000au-FD for 64101@debbugs.gnu.org; Mon, 19 Jun 2023 15:08:23 -0400 Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-55e1ae72dceso2258433eaf.3 for <64101@debbugs.gnu.org>; Mon, 19 Jun 2023 12:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687201696; x=1689793696; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YUGGiV8aA4p5OgOV7KpctOv98G7SAjVo+PsuvzcGWew=; b=PyL8thjr3cSTBCPjufakXSvcgIG+xHDKY4zBlm+CO1Xo5lQfaJ5TLJ73jV5p5Mjqg+ TRtU/pB0v59n5mNy2vikdrY2INRHrOyJSeXYe7klDCaudK/6xDTte/u8iouP+qZfF1W1 +rl43OcVTVQLeqXY1j6gswHa2BLgGSdVcGecy0arqKDv7ImX6HNIAHG7voaNrW3FV95G PPrJqCAm/Jgy17te67DlgzcIxLN6y7cAQk5tk0C5kF8Zhe4I6F1j7mJLZeMks2UazAOV H3AriLRKAWBM1kgx8pbEfWgewmIBOzQHYDESLXq422dVC56rU1BXMR7h4xTnsDg3ElsC esjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687201696; x=1689793696; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YUGGiV8aA4p5OgOV7KpctOv98G7SAjVo+PsuvzcGWew=; b=Oaup8LUdLv+mwcWDlrEsM3GhgVnQkyWkuuFPbGNW9kWOqoMvPc0e8PlXUYDJMHkcMC 4zunGfsROEh/Oz8xmgQQ33Kdd1pJ1Ca6hrUszyS483jdnGvTOJn9s7w4EfIyO29bSnRc pf7K8/sj113PJZp+lHyEI39SVYjd6QFs1uetCdufO+3+q/paJtwiIrwQyt+TkREYtYjH nSvWI05ja+cyNXsIb7RNABhL+T8BJrAtCFuy0iQ0XoPPvJuoIZbgU3iDePSB5hpGhyVk QHNEtpxf0KBnNufpigY5A3+aT8ZPp56gv08j6h24RjeVaba2rSuF84mjxF3THPu7mkea fgOA== X-Gm-Message-State: AC+VfDybT65xM05F7ZJdzp5lhmZ2wNUwmiuUz8fQfpQ1qAIuUdjxjgtH 5o87z6DX45wpkul+Iux7B796b6jYg3QoYIG/WAU= X-Google-Smtp-Source: ACHHUZ7v0PZSoLwtz/9q7aQNhqKVEyG4dIWcu9mceIk4lnziOQuOApdCSPExwwgkz+dVanpFAa7/WirwQ6gKe8OGB+c= X-Received: by 2002:a4a:c919:0:b0:558:b78d:8d1e with SMTP id v25-20020a4ac919000000b00558b78d8d1emr5963408ooq.7.1687201696534; Mon, 19 Jun 2023 12:08:16 -0700 (PDT) MIME-Version: 1.0 References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> In-Reply-To: <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Mon, 19 Jun 2023 20:08:05 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Jun 19, 2023 at 7:06=E2=80=AFPM Milan Jovanovic = wrote: > So, you fix did solve original Krzysztof report (and my original report) = for more complex type hints but now I have the same issue with argument hin= ts. Yes, and I've already replied to you that I can't reproduce your error. So maybe you should follow the instructions of https://joaotavora.github.io/eglot/#Troubleshooting-Eglot so that you can provide a bullet-proof reproduction recipe. So far, you haven't done that. You just send me snippets of Rust code and I assume I should paste them into my own Emacs. And there, I can't reproduce the problem. IOW, I don't doubt that there's a problem in Eglot, but I need you to patiently craft a mail with the full recipe, i.e. the fullest -- and simplest -- account possible of your problem. > Example: > > fn main () { > let mut c =3D vec![1,2,3]; > c.insert(0, 0); > } > Here, again, I see the correct inlay hints. Here's my recipe. $ cd /tmp $ cargo new bla $ cd bla $ rust-analyzer --version rust-analyzer 1 (cd3bf9fe51 2023-06-18) $ emacs --version ~/Source/Emacs/emacs/src/emacs --version GNU Emacs 30.0.50 Development version 075e77ac4493 on master branch; build date 2023-06-19. ... $ emacs -Q -f package-initialize src/main.rs -f eglot Now I wait a little bit for the connection to stabilize and then type in yo= ur main.rs content. If the inlay hints don't immediately appear, just add and delete a character anywhere in the buffer. When they do appear, they appea= r correctly. My rust-mode.el is version 1.0.5, but I've tried successfully with rust-ts-= mode as well. And by the way, this is the trace of the make-overlay and overlay-put functions =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 53 54 nil nil nil) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # after-string #("index: " 0 7 (face eglot-parameter-hint-face))) 1 <- overlay-put: #("index: " 0 7 (face eglot-parameter-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 0) 1 <- overlay-put: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--inlay-hint t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 56 57 nil nil nil) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # after-string #("element: " 0 9 (face eglot-parameter-hint-face))) 1 <- overlay-put: #("element: " 0 9 (face eglot-parameter-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 0) 1 <- overlay-put: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--inlay-hint t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay t) 1 <- overlay-put: t So, as you can see, the server isn't supplying different hints for "index" and ":". So I can't reproduce your error, you must be using a different version of rust analyzer or something like that. This is the relevant portion of my Eglot events buffer: (:jsonrpc "2.0" :id 39 :result [(:position (:line 1 :character 12) :label [(:value ": ") (:value "Vec" :location (:uri "file:///usr/lib/rustlib/src/rust/library/alloc/src/vec/mod.rs" :range (:start (:line 395 :character 11) :end (:line 395 :character 14)))) (:value "")] :kind 1 :textEdits [(:range (:start (:line 1 :character 12) :end (:line 1 :character 12)) :newText ": Vec")] :paddingLeft :json-false :paddingRight :json-false) (:position (:line 2 :character 12) :label [(:value "index:" :location (:uri "file:///usr/lib/rustlib/src/rust/library/alloc/src/vec/mod.rs" :range (:start (:line 1434 :character 29) :end (:line 1434 :character 34))))] :kind 2 :paddingLeft :json-false :paddingRight t) (:position (:line 2 :character 15) :label [(:value "element:" :location (:uri "file:///usr/lib/rustlib/src/rust/library/alloc/src/vec/mod.rs" :range (:start (:line 1434 :character 43) :end (:line 1434 :character 50))))] :kind 2 :paddingLeft :json-false :paddingRight t)]) Jo=C3=A3o From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Milan Jovanovic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jun 2023 21:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , Krzysztof Klimonda , Stefan Monnier , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168720876215457 (code B ref 64101); Mon, 19 Jun 2023 21:07:01 +0000 Received: (at 64101) by debbugs.gnu.org; 19 Jun 2023 21:06:02 +0000 Received: from localhost ([127.0.0.1]:57407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBM4X-000412-Lj for submit@debbugs.gnu.org; Mon, 19 Jun 2023 17:06:02 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:51514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBM4U-00040e-Dq for 64101@debbugs.gnu.org; Mon, 19 Jun 2023 17:06:00 -0400 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-3f9b4bf99c2so6792365e9.3 for <64101@debbugs.gnu.org>; Mon, 19 Jun 2023 14:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687208752; x=1689800752; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MgcsQQPLLR2EC9Ci9YRga3e4C3x9KykD2hzgdldiW70=; b=mrkHpIb4ks6xbX8fyqjVDfX+AxFgxlF7/N5A33Tcznj/EngsdLBfilldjtYfcnGOEL lTZGX3gbAg3Z13BVJiGo8KiV1LqWL0tR3Gj4cPrteu8eSagC6MdFUhCERsXvZMyJUoRO PlQZQagFw9yJd2qlRIJuNn9h2Hx+g9/oTPBYwDhG0GUHbf+OxNQF6wIqWgeev70MKKcI gshqJ67L3OuXbOkR5N+QPImX5fevkErIiuvGv6Cyu/U2TnhrHxGeeJSZx30ZNPhlb/aD EDukPVIe7Mb5Kfkqd+BoBQ92BXMkjPvoLPzBbR9zEVraEC0nSxYuVE9QBmNaz8HFKMmC xHkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687208752; x=1689800752; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MgcsQQPLLR2EC9Ci9YRga3e4C3x9KykD2hzgdldiW70=; b=hwndD2my4woEzEEY13ShPjVNXiKywpGZ+uL5NJYnxdqBb5CuDIoH0GqSXw7nxvDuYl Kb2f07QOETHKfITIOpQ1CfPU776AWbDtL6nSptjJml3+4Yh1LVvk3ZDl9TWewrOxxXt1 I+q5ro8N9j+HwSeYAb97hUpyjeAX6ZP8MPpqyVkxKCtmnC/dZo/UO9a8omq50I1AMq5v Q44/oHr2K2+vrtnw6Tj/vTHwk8Uwb2otGIgNIkbTwoHwWXHUyb6CGa6KVlavcpwSxjEE FDlrkOo8jbv24iCk/nv1Sos0AtFxWYAUqa3UdvSajzrFjAJ4rQrD+ntooiDqVLtzLxtP 0Tsw== X-Gm-Message-State: AC+VfDx5yP1LKx1UZ2AHSQbF7FwXtKQE+YmD7Qnqx1GyYwEDDWwoAC++ NgTbxQ8E3EVzdcQf8G9/jbA= X-Google-Smtp-Source: ACHHUZ4ufUOSX98xgqhSyu63PqwVraH7Q7fiaQ8lqDnZR/QYPBWORPNneg1vN9EqhgVcHFEF0lSihg== X-Received: by 2002:a05:600c:248:b0:3f9:b3b4:4367 with SMTP id 8-20020a05600c024800b003f9b3b44367mr1712330wmj.15.1687208752200; Mon, 19 Jun 2023 14:05:52 -0700 (PDT) Received: from smtpclient.apple ([87.116.166.45]) by smtp.gmail.com with ESMTPSA id n8-20020a05600c294800b003f90a604885sm659120wmd.34.2023.06.19.14.05.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jun 2023 14:05:51 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) From: Milan Jovanovic In-Reply-To: Date: Mon, 19 Jun 2023 23:05:49 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Looks like overlays render order depends on before-string/after-string = property (beside priority). Type hints overlays are =E2=80=98before-string and function parameter = hints overlays are =E2=80=98after-string (so parameter hint parts are = sorted by overlay descending priority). If you change it to =E2=80=98before-string also (and adjust overlay = start/end to be as in type hints) it will work as it should. Btw. I still don=E2=80=99t understand why parts of one hint can=E2=80=99t = be simply merged. Anyway, my recipe to recreate issue: % rust-analyzer --version rust-analyzer 1.70.0 (90c54180 2023-05-31) =E2=80=94> last rustup = version (`rustup component add rust-analyzer`) % /Applications/Emacs.app/Contents/MacOS/Emacs --version = =20 GNU Emacs 29.0.91 % ls .emacs.d auto-save-list elpa ls .emacs.d/elpa=20 archives eglot-1.15 eglot-1.15.signed eldoc-1.14.0 = eldoc-1.14.0.signed gnupg (eglot.el is patched with diff from Jo=C3=A3o email) % cargo new inlay-hints >>> paste this code into inlay-hints/src/main.rs fn main() { let mut c =3D vec![1,2,3]; c.insert(0, 0); } <<<< % cd inlay-hints % /Applications/Emacs.app/Contents/MacOS/Emacs src/main.rs -f = rust-ts-mode -f eglot Eglot events: (:jsonrpc "2.0" :id 13 :result [(:position (:line 1 :character 11) :label [(:value ": ") (:value "Vec" :location (:uri = "file:///Users/milan/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rus= tlib/src/rust/library/alloc/src/vec/mod.rs" :range (:start (:line 395 :character 11) :end (:line 395 :character 14)))) (:value "")] :kind 1 :paddingLeft :json-false :paddingRight :json-false) (:position (:line 2 :character 11) :label [(:value "index" :location (:uri = "file:///Users/milan/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rus= tlib/src/rust/library/alloc/src/vec/mod.rs" :range (:start (:line 1434 :character 29) :end (:line 1434 :character 34)))) (:value ":")] :kind 2 :paddingLeft :json-false :paddingRight t) (:position (:line 2 :character 13) :label [(:value "element" :location (:uri = "file:///Users/milan/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rus= tlib/src/rust/library/alloc/src/vec/mod.rs" :range (:start (:line 1434 :character 43) :end (:line 1434 :character 50)))) (:value ":")] :kind 2 :paddingLeft :json-false :paddingRight t)]) Trace output: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 25 26 nil t) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # before-string #(": = " 0 1 (face eglot-type-hint-face cursor 1) 1 2 (face = eglot-type-hint-face))) 1 <- overlay-put: #(": " 0 1 (face eglot-type-hint-face cursor 1) 1 2 = (face eglot-type-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 0) 1 <- overlay-put: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--inlay-hint = t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 25 26 nil t) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # before-string = #("Vec" 0 3 (face eglot-type-hint-face))) 1 <- overlay-put: #("Vec" 0 3 (face eglot-type-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 1) 1 <- overlay-put: 1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--inlay-hint = t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 25 26 nil t) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # before-string = #("" 0 5 (face eglot-type-hint-face))) 1 <- overlay-put: #("" 0 5 (face eglot-type-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 2) 1 <- overlay-put: 2 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--inlay-hint = t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 51 52 nil nil nil) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # after-string = #("index" 0 5 (face eglot-parameter-hint-face))) 1 <- overlay-put: #("index" 0 5 (face eglot-parameter-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 0) 1 <- overlay-put: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--inlay-hint = t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 51 52 nil nil nil) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # after-string #(": = " 0 2 (face eglot-parameter-hint-face))) 1 <- overlay-put: #(": " 0 2 (face eglot-parameter-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 1) 1 <- overlay-put: 1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--inlay-hint = t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 53 54 nil nil nil) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # after-string = #("element" 0 7 (face eglot-parameter-hint-face))) 1 <- overlay-put: #("element" 0 7 (face eglot-parameter-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 0) 1 <- overlay-put: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--inlay-hint = t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (make-overlay 53 54 nil nil nil) 1 <- make-overlay: # =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # after-string #(": = " 0 2 (face eglot-parameter-hint-face))) 1 <- overlay-put: #(": " 0 2 (face eglot-parameter-hint-face)) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 1) 1 <- overlay-put: 1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--inlay-hint = t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # evaporate t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # eglot--overlay t) 1 <- overlay-put: t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 1000) 1 <- overlay-put: 1000 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # face = show-paren-match) 1 <- overlay-put: show-paren-match =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # priority 1000) 1 <- overlay-put: 1000 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 1 -> (overlay-put # face = show-paren-match) 1 <- overlay-put: show-paren-match > On 19. 6. 2023., at 21:08, Jo=C3=A3o T=C3=A1vora = wrote: >=20 > On Mon, Jun 19, 2023 at 7:06=E2=80=AFPM Milan Jovanovic = wrote: >=20 >> So, you fix did solve original Krzysztof report (and my original = report) for more complex type hints but now I have the same issue with = argument hints. >=20 > Yes, and I've already replied to you that I can't reproduce > your error. So maybe you should follow the instructions > of >=20 > https://joaotavora.github.io/eglot/#Troubleshooting-Eglot >=20 > so that you can provide a bullet-proof reproduction recipe. >=20 > So far, you haven't done that. You just send me snippets of > Rust code and I assume I should paste them into my own > Emacs. And there, I can't reproduce the problem. >=20 > IOW, I don't doubt that there's a problem in Eglot, but I > need you to patiently craft a mail with the full recipe, i.e. > the fullest -- and simplest -- account possible of your > problem. >=20 >> Example: >>=20 >> fn main () { >> let mut c =3D vec![1,2,3]; >> c.insert(0, 0); >> } >>=20 >=20 > Here, again, I see the correct inlay hints. >=20 > Here's my recipe. >=20 > $ cd /tmp > $ cargo new bla > $ cd bla > $ rust-analyzer --version > rust-analyzer 1 (cd3bf9fe51 2023-06-18) > $ emacs --version > ~/Source/Emacs/emacs/src/emacs --version > GNU Emacs 30.0.50 > Development version 075e77ac4493 on master branch; build date = 2023-06-19. > ... > > $ emacs -Q -f package-initialize src/main.rs -f eglot >=20 > Now I wait a little bit for the connection to stabilize and then type = in your > main.rs content. If the inlay hints don't immediately appear, just = add and > delete a character anywhere in the buffer. When they do appear, they = appear > correctly. >=20 > My rust-mode.el is version 1.0.5, but I've tried successfully with = rust-ts-mode > as well. >=20 > And by the way, this is the trace of the make-overlay and overlay-put > functions >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (make-overlay 53 54 nil nil nil) > 1 <- make-overlay: # > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (overlay-put # after-string > #("index: " 0 7 (face eglot-parameter-hint-face))) > 1 <- overlay-put: #("index: " 0 7 (face eglot-parameter-hint-face)) > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (overlay-put # priority 0) > 1 <- overlay-put: 0 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (overlay-put # = eglot--inlay-hint t) > 1 <- overlay-put: t > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (overlay-put # evaporate t) > 1 <- overlay-put: t > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (overlay-put # eglot--overlay = t) > 1 <- overlay-put: t > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (make-overlay 56 57 nil nil nil) > 1 <- make-overlay: # > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (overlay-put # after-string > #("element: " 0 9 (face eglot-parameter-hint-face))) > 1 <- overlay-put: #("element: " 0 9 (face eglot-parameter-hint-face)) > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (overlay-put # priority 0) > 1 <- overlay-put: 0 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (overlay-put # = eglot--inlay-hint t) > 1 <- overlay-put: t > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (overlay-put # evaporate t) > 1 <- overlay-put: t > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1 -> (overlay-put # eglot--overlay = t) > 1 <- overlay-put: t >=20 > So, as you can see, the server isn't supplying different hints for > "index" and ":". So I can't reproduce your error, you must be > using a different version of rust analyzer or something like that. >=20 > This is the relevant portion of my Eglot events buffer: >=20 > (:jsonrpc "2.0" :id 39 :result > [(:position (:line 1 :character 12) :label > [(:value ": ") > (:value "Vec" :location > (:uri >=20 > "file:///usr/lib/rustlib/src/rust/library/alloc/src/vec/mod.rs" > :range > (:start (:line 395 :character 11) :end > (:line 395 :character 14)))) > (:value "")] > :kind 1 :textEdits > [(:range > (:start (:line 1 :character 12) :end > (:line 1 :character 12)) > :newText ": Vec")] > :paddingLeft :json-false :paddingRight > :json-false) > (:position (:line 2 :character 12) :label > [(:value "index:" :location > (:uri >=20 > "file:///usr/lib/rustlib/src/rust/library/alloc/src/vec/mod.rs" > :range > (:start (:line 1434 :character 29) > :end > (:line 1434 :character 34))))] > :kind 2 :paddingLeft :json-false :paddingRight t) > (:position (:line 2 :character 15) :label > [(:value "element:" :location > (:uri >=20 > "file:///usr/lib/rustlib/src/rust/library/alloc/src/vec/mod.rs" > :range > (:start (:line 1434 :character 43) > :end > (:line 1434 :character 50))))] > :kind 2 :paddingLeft :json-false :paddingRight = t)]) >=20 > Jo=C3=A3o From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jun 2023 22:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Milan Jovanovic Cc: Eli Zaretskii , Krzysztof Klimonda , Stefan Monnier , 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168721417424885 (code B ref 64101); Mon, 19 Jun 2023 22:37:01 +0000 Received: (at 64101) by debbugs.gnu.org; 19 Jun 2023 22:36:14 +0000 Received: from localhost ([127.0.0.1]:57511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBNTp-0006TJ-Ud for submit@debbugs.gnu.org; Mon, 19 Jun 2023 18:36:14 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:49582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBNTp-0006T5-50 for 64101@debbugs.gnu.org; Mon, 19 Jun 2023 18:36:13 -0400 Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-3f909853509so20098075e9.3 for <64101@debbugs.gnu.org>; Mon, 19 Jun 2023 15:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687214167; x=1689806167; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B54eluWxW0YXs+j0qtsR+sgHpAnQkhXHy/iAIrBkYAA=; b=H2l6vM1f1br3KqeKj7nsD2sNZuULzH8lAW7toeud3gmYcVTxKq4ZSh7dm2cqQji18v kY6R8pxuyva+IyM4boMUfkoq7vEXPx36cCZt23/MyIwC1FXwyz+Vl0RIYOZxppb6CcY7 HYa5CTFd24pXVqdT8E9jElu74NjCUiPTs+m9JnuYTK0hRJmwnqD50zu/l2qQS1fitw1o XUXVKmC67DxGxoEqPUKVvocD0pQcEtIov3ov0Tgt2gG9kViIUmDKwt02nTqHPWEvsLRJ peynhTUnkLXhY2BQCAKe69rcog6t+bY70sizrPm4X384iQwuYTlZwlzqrNkXWLg0wtNJ ib4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687214167; x=1689806167; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=B54eluWxW0YXs+j0qtsR+sgHpAnQkhXHy/iAIrBkYAA=; b=AKrxI5GJaSZHkjmjVUz/F4OVzjcnRPGGLs6bIZ/q+HzniDdF2pLBfsQ8b8ZEFx6svv CpiIx+1L5pu7132o5vikzzGc0VDK6z2P9zQbFryB7e6T6BIJmFVeNfAkS70ZhUCfSLlL mC74KTbBcyYV0pzDr6zjrTLs0MRPLtfCO7gLeD0c1MdpQY9wJbhAWH29FJnM+qV1fbNP w1GiB2VwmUFPH37iCM553ZBVGIG9nonRP2U4of+5QmrBVCScsfLnJVkhCpcW1AHWAJTU imTGTweF9i9NTSGH570dzHZJlEXHgYjQ7cKXQtutYN/eRmVlAKLXUiuf+zmQUB1DX8Sw srDw== X-Gm-Message-State: AC+VfDz5ZGsVTZGSOUvZQM0Ta2BowDY0wuy3qjbUQTAqIuiOZuKQ/kfO IgTNaP4Q2YceYlJpvYiux3G9whlCnno= X-Google-Smtp-Source: ACHHUZ6ovC8JsWlJ6IBdDmjY6iaeHSRkTDePm3k25Fps7ndQq1moqMNh6qr9BDgtwviEVgNM+midng== X-Received: by 2002:a7b:cc0c:0:b0:3f8:fb7c:6793 with SMTP id f12-20020a7bcc0c000000b003f8fb7c6793mr6322599wmh.24.1687214166879; Mon, 19 Jun 2023 15:36:06 -0700 (PDT) Received: from krug ([87.196.73.15]) by smtp.gmail.com with ESMTPSA id p21-20020a7bcc95000000b003f739a8bcc8sm819697wma.19.2023.06.19.15.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 15:36:06 -0700 (PDT) From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= In-Reply-To: <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> (Milan Jovanovic's message of "Mon, 19 Jun 2023 23:05:49 +0200") References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> Date: Mon, 19 Jun 2023 23:38:34 +0100 Message-ID: <875y7j6psl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Milan Jovanovic writes: > Btw. I still don=E2=80=99t understand why parts of one hint can=E2=80=99t= be simply > merged. They could be merged but devising logic and heuristics to do it correctly would hardly be "simple". In this particular case, they could be merged, becasue the ':' label part doesn't have any properties clashing with the 'index' name-of-parameter label part. But in general, that isn't necessarily so, and Eglot is a generic Eglot client, not just catering to the rust-analyzer server which provides these very fine grained labels. So the simplest solution is taken and it is complex enough. So here the disadvantages outweigh the benefits. > Anyway, my recipe to recreate issue: > > % rust-analyzer --version > rust-analyzer 1.70.0 (90c54180 2023-05-31) =E2=80=94> last rustup version > (`rustup component add rust-analyzer`) Thanks. This was key. I've reproduced the problem (here, I didn't need Mac OS) and pushed a fix to emacs-29. The fix will appear in master soon and thus also in upcoming Eglot 1.16. Jo=C3=A3o From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jun 2023 11:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Milan Jovanovic Cc: 64101@debbugs.gnu.org, kklimonda@syntaxhighlighted.com, joaotavora@gmail.com, monnier@iro.umontreal.ca Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.16872594128266 (code B ref 64101); Tue, 20 Jun 2023 11:11:01 +0000 Received: (at 64101) by debbugs.gnu.org; 20 Jun 2023 11:10:12 +0000 Received: from localhost ([127.0.0.1]:58187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBZFT-00029E-Eo for submit@debbugs.gnu.org; Tue, 20 Jun 2023 07:10:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBZFR-00028y-Ku for 64101@debbugs.gnu.org; Tue, 20 Jun 2023 07:10:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBZFL-0004uj-MB; Tue, 20 Jun 2023 07:10:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kSU9KRlgw+P7cYjmgvGRz1puQt2bnyn+HwufRUvjmNM=; b=Y25swAVpf6Dp 1P8fe1Lui0ojcOJBgvBNWlx4ESwyU5nWhDk7yHUhQ2sxcHzB5NrkPa4Oyia/dipi/mWBGNR+EFfiU XPbgsr6QaDJjoZ275Dnr5aJEAUdPINiQF8l9FIzdPNbIB5xsVfxXDXO8hJZUAT64l7pfGssRc7tCg 55UpdEmQ3QU89+ckPjkjyTDrWyVK9ROe6G/VfR/yPcJ593CB88Kpn/IB8rHuydMEfohmyYdMXUZol 9u8cFQQ+lEZX+ZN29EdYCZXweUHBxxxNTA7a1Xo4BRCKbzZdASPKztrY3Ie+UelTMdkK70egjUZoM 3eOUYyamTpmU6ggdRHivAg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBZFL-0003Dv-0v; Tue, 20 Jun 2023 07:10:03 -0400 Date: Tue, 20 Jun 2023 14:10:09 +0300 Message-Id: <83edm675ke.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> (message from Milan Jovanovic on Mon, 19 Jun 2023 23:05:49 +0200) References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Milan Jovanovic > Date: Mon, 19 Jun 2023 23:05:49 +0200 > Cc: Stefan Monnier , > Eli Zaretskii , > Krzysztof Klimonda , > 64101@debbugs.gnu.org > > Looks like overlays render order depends on before-string/after-string property (beside priority). Don't you expect that? If some text has both before-string and after-string overlays, which one(s) will you expect to see before the other one? From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Milan Jovanovic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jun 2023 11:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 64101@debbugs.gnu.org, Krzysztof Klimonda , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Stefan Monnier Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168726073519995 (code B ref 64101); Tue, 20 Jun 2023 11:33:01 +0000 Received: (at 64101) by debbugs.gnu.org; 20 Jun 2023 11:32:15 +0000 Received: from localhost ([127.0.0.1]:58203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBZao-0005CQ-Gb for submit@debbugs.gnu.org; Tue, 20 Jun 2023 07:32:14 -0400 Received: from mail-ed1-f45.google.com ([209.85.208.45]:54440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBZam-0005CB-Dk for 64101@debbugs.gnu.org; Tue, 20 Jun 2023 07:32:13 -0400 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-510d6b939bfso6354296a12.0 for <64101@debbugs.gnu.org>; Tue, 20 Jun 2023 04:32:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687260726; x=1689852726; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tNyH1+q8Ylw7dM8IZ163qI8Vn8Jgjzw3sNC2sWBHm1c=; b=HYy5RUZNyiG0YncHneq9g4t4YWIl9R9agHpoShnq+ZVgc/84eX54G7JqQw3nGi7++F 0r8lbjRxRi1pp5wnmEzpMcHLa6vROacbzi4JA/KzO5X0QCpqaLXI1Fv5HenFuJhO4amb Xry7DVWCn43FC0vI4u1KDgPLswcItC3bp1d/eNQS2NzyNG+wX7s1RExstnLb1eIAzhpV /IWovBmRfLE7Yrg2IjIi42zauU1ymqXJH5lpk2uxFG7vPsQAFHoOrMvUYChnBJYiogut oIXUYBEiP0GVkeExQBzo06tPrwnGHgfLjJ0+06YgkYLIB5pbyHyMQOR+nQ2xCX2OZ7Ez KIng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687260726; x=1689852726; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tNyH1+q8Ylw7dM8IZ163qI8Vn8Jgjzw3sNC2sWBHm1c=; b=MCgDJWY8jYQZk8qa/TqmWuuLxsXJylI1t87i2fiFTJz/e2zKeWUtIaQj8dc5CE59TG O7NgrSZBBWNri/NwmnAeDtNy4B6DUd4wGNoEc6iArt6tQXBQPEwA2nlFjrF5N0gXoQ9K MChs0wNsYN4SJ3vEjJcyHeheZSsDrswBT20bJiNJid1+B6V3YOq6aS0ba1dhY/PUif59 4zSjXer2YIrgsJ+60xBWWeh2TATw9yIuuXPlUbiS0KWsrHHk6QaWE8xPtFCLOmKUdXwW facOh8BLhcsHmMBNJAqgxDIXtv7rKJDOgBZ/yBJghAorfEEgLNUBBaHCBGBIfMkHzBFI Zlrw== X-Gm-Message-State: AC+VfDxfLDjYFckmEfxtlwkLZW4J0oiTktJXAGwQe+PY+8X0MPKV/9S4 ZawWjRLmubZcY7r30EEssvk= X-Google-Smtp-Source: ACHHUZ4kSooRUo0z7cPloQJhaMOn4uSi0oiqF3z5089iaIFmruMbQPXQCeBc1sN+E6+8+vGYqKNz9g== X-Received: by 2002:a17:907:a42:b0:985:34b:83b4 with SMTP id be2-20020a1709070a4200b00985034b83b4mr12446640ejc.10.1687260726265; Tue, 20 Jun 2023 04:32:06 -0700 (PDT) Received: from smtpclient.apple (109-93-79-245.static.isp.telekom.rs. [109.93.79.245]) by smtp.gmail.com with ESMTPSA id z14-20020a1709064e0e00b00987ac9cfb8esm1206278eju.67.2023.06.20.04.32.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jun 2023 04:32:05 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) From: Milan Jovanovic In-Reply-To: <83edm675ke.fsf@gnu.org> Date: Tue, 20 Jun 2023 13:32:04 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> <83edm675ke.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I do expect that but I=E2=80=99m talking about order of overlays that = have the same start/end (and all of them have the same = before-or-after-string property). If you have more than one overlay with the same start/end and all of = them have the same before-or-after-string property one order will be = ascending and other descending (in regard to priority). At least that is why I=E2=80=99ve observed while looking at the Eglot = issue. > On 20. 6. 2023., at 13:10, Eli Zaretskii wrote: >=20 >> From: Milan Jovanovic >> Date: Mon, 19 Jun 2023 23:05:49 +0200 >> Cc: Stefan Monnier , >> Eli Zaretskii , >> Krzysztof Klimonda , >> 64101@debbugs.gnu.org >>=20 >> Looks like overlays render order depends on = before-string/after-string property (beside priority). >=20 > Don't you expect that? If some text has both before-string and > after-string overlays, which one(s) will you expect to see before the > other one? From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jun 2023 12:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Milan Jovanovic Cc: 64101@debbugs.gnu.org, kklimonda@syntaxhighlighted.com, joaotavora@gmail.com, monnier@iro.umontreal.ca Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168726248123025 (code B ref 64101); Tue, 20 Jun 2023 12:02:02 +0000 Received: (at 64101) by debbugs.gnu.org; 20 Jun 2023 12:01:21 +0000 Received: from localhost ([127.0.0.1]:58250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBa2y-0005zI-JO for submit@debbugs.gnu.org; Tue, 20 Jun 2023 08:01:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBa2w-0005z5-8W for 64101@debbugs.gnu.org; Tue, 20 Jun 2023 08:01:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBa2q-0008T0-PD; Tue, 20 Jun 2023 08:01:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=YIH8dt9sNQVMFoRO8fkbRYfUDGFaSirY+extwDEMFHk=; b=reERD4zPfcuusQ4d/4Q3 7wESRgmGQL/ivQi6kUE4phQBadLz7hbSWgWZwsUAow3cRqN/uto4pBNNigCwroLofgHBu/Ia3jLKD /0pWlp2oCd4GmHA7yTIptrxvFZ5NBUsi/T34gvIJTAokMpSNteSHaYxEbbChrIkUnubnou0lTmPGk 2ZwfTw/vfyLlQRlThAWDGOW3wDFIs1R+jmMK/n2XJd892HccvsoLET5V/E+C4/F9/DdkVYn7ZXtys ENZ3FVu+l1g7EhALEMdw4W0rDaMNAwgRbDwx80sn5wilYtzZjv3BwHA9OmfiElsunmWnkAwtgqlvS gg6ElkOQB8rC+w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBa2q-0003K5-3c; Tue, 20 Jun 2023 08:01:12 -0400 Date: Tue, 20 Jun 2023 15:01:18 +0300 Message-Id: <831qi67375.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Milan Jovanovic on Tue, 20 Jun 2023 13:32:04 +0200) References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> <83edm675ke.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Milan Jovanovic > Date: Tue, 20 Jun 2023 13:32:04 +0200 > Cc: João Távora , > Stefan Monnier , > Krzysztof Klimonda , > 64101@debbugs.gnu.org > > I do expect that but I’m talking about order of overlays that have the same start/end (and all of them have the same before-or-after-string property). > If you have more than one overlay with the same start/end and all of them have the same before-or-after-string property one order will be ascending and other descending (in regard to priority). And you don't expect that from the Emacs display? From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Milan Jovanovic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jun 2023 13:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 64101@debbugs.gnu.org, kklimonda@syntaxhighlighted.com, joaotavora@gmail.com, monnier@iro.umontreal.ca Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168726810432458 (code B ref 64101); Tue, 20 Jun 2023 13:36:02 +0000 Received: (at 64101) by debbugs.gnu.org; 20 Jun 2023 13:35:04 +0000 Received: from localhost ([127.0.0.1]:58313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBbVf-0008RQ-OY for submit@debbugs.gnu.org; Tue, 20 Jun 2023 09:35:04 -0400 Received: from mail-pg1-f181.google.com ([209.85.215.181]:53611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBbVd-0008R2-2l for 64101@debbugs.gnu.org; Tue, 20 Jun 2023 09:35:02 -0400 Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-54f71fa7e41so2532071a12.3 for <64101@debbugs.gnu.org>; Tue, 20 Jun 2023 06:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687268095; x=1689860095; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uuyUzlGAxdwO6l28+9uLkYii7/jKRNweuDOTDuelT+8=; b=dMhX4G/uICVeSO4eek/zgKZJJ2qOl/etlPYUXv3ZtVAioX5IqRNR/dRHcEsnffCBNK ulXUvvFEQOobQMHz2DKtqAszzIH8sqEQ5kSER0UX4Hm0bV3HDxT+8THL/KVpGwarV2eS BcEVced2uJKSe7FyvhKb8yCbD9inUt9R2B6uZgkB0bbTV28RaMPNvUyXkvreCf5SARli BiBAL4Z1/mj2GiKuHXc2ao8/C5VGdfTLNEr274jfcePJSF2NTw2N6Upu6l6eCRxyEwAa muxj2YFXke5ihxLrpguFePYjtpRCu0fFLo/I4sqjc84Jm6x3PWVZ8sRdpQ93LP4s21RC Hcrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687268095; x=1689860095; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uuyUzlGAxdwO6l28+9uLkYii7/jKRNweuDOTDuelT+8=; b=aysaeqRjdikQWuQc0biW/ixNpMQ4X8rfkUQOqYVpjwTRYPsSiJ2NbVS+kr6BWjxVR5 O2embHX8G5diBvhxtxlBAHm9ncZn/r5mcBmcldVhYsvmR8KTFeiDA0L/D2n4IepDFQBM q73wTonL6Nb9xh+F3SvRlG/jKmgR2zPpZzmKfu+wnhjO21i3ylTRtnGt4LIgcDmgeg/S I4fpfkBKJIHfVmmsfLGHVt/G25lHTlQtxEqDdFutsQSXhiUPz3Qwm2AHO8SHixA5ctqf 5HsT4f3rlxKjtygbZe/x6/2Uj16OOpeGvhwtNeKUjSTf9amHpW2RnnlMgxF5H8as8+1X xgGg== X-Gm-Message-State: AC+VfDytm+2YcEu+vks86iufMaJeoP7DcNsCz8hoZUBsRu/+oa/lZM/G IBUBxXObjgo9HT5XGBHY3tfrl73A6YTd5Vt7geA= X-Google-Smtp-Source: ACHHUZ6KxCsXqxTxDDHO3j+iy8gJV3ljcG25ag2mxTjBZxB+T/CHfrdOFIrU3kVWKJ2vovLId0v6UXtWWnBWb5DdqYk= X-Received: by 2002:a17:902:ecc4:b0:1b5:4679:5699 with SMTP id a4-20020a170902ecc400b001b546795699mr7310493plh.35.1687268094581; Tue, 20 Jun 2023 06:34:54 -0700 (PDT) MIME-Version: 1.0 References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> <83edm675ke.fsf@gnu.org> <831qi67375.fsf@gnu.org> In-Reply-To: <831qi67375.fsf@gnu.org> From: Milan Jovanovic Date: Tue, 20 Jun 2023 15:34:42 +0200 Message-ID: Content-Type: multipart/alternative; boundary="0000000000006b259a05fe8fb7f0" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000006b259a05fe8fb7f0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Well, from reading this thread I expected it to be sorted by priority. On Tue, Jun 20, 2023 at 2:01=E2=80=AFPM Eli Zaretskii wrote: > > From: Milan Jovanovic > > Date: Tue, 20 Jun 2023 13:32:04 +0200 > > Cc: Jo=C3=A3o T=C3=A1vora , > > Stefan Monnier , > > Krzysztof Klimonda , > > 64101@debbugs.gnu.org > > > > I do expect that but I=E2=80=99m talking about order of overlays that h= ave the > same start/end (and all of them have the same before-or-after-string > property). > > If you have more than one overlay with the same start/end and all of > them have the same before-or-after-string property one order will be > ascending and other descending (in regard to priority). > > And you don't expect that from the Emacs display? > --0000000000006b259a05fe8fb7f0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Well, from reading this thread I expected it to be sorted = by priority.

On Tue, Jun 20, 2023 at 2:01=E2=80=AFPM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Milan Jovanovic <milanj@gmail.com>
> Date: Tue, 20 Jun 2023 13:32:04 +0200
> Cc: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>,
>=C2=A0 Stefan Monnier <monnier@iro.umontreal.ca>,
>=C2=A0 Krzysztof Klimonda <kklimonda@syntaxhighlighted.com>,
>=C2=A0 64101= @debbugs.gnu.org
>
> I do expect that but I=E2=80=99m talking about order of overlays that = have the same start/end (and all of them have the same before-or-after-stri= ng property).
> If you have more than one overlay with the same start/end and all of t= hem have the same before-or-after-string property one order will be ascendi= ng and other descending (in regard to priority).

And you don't expect that from the Emacs display?
--0000000000006b259a05fe8fb7f0-- From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jun 2023 13:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Milan Jovanovic Cc: 64101@debbugs.gnu.org, kklimonda@syntaxhighlighted.com, joaotavora@gmail.com, monnier@iro.umontreal.ca Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.16872688121169 (code B ref 64101); Tue, 20 Jun 2023 13:47:01 +0000 Received: (at 64101) by debbugs.gnu.org; 20 Jun 2023 13:46:52 +0000 Received: from localhost ([127.0.0.1]:58333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBbh6-0000Im-H7 for submit@debbugs.gnu.org; Tue, 20 Jun 2023 09:46:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBbh4-0000Ia-6o for 64101@debbugs.gnu.org; Tue, 20 Jun 2023 09:46:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBbgx-0002B6-PA; Tue, 20 Jun 2023 09:46:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ht534AqF+a288XsvXnyoIxolf2jfY9hz3HS4Gx1k8GI=; b=cjV7mulJTKJq jtdwf7Dq8ZAg0NJzJUW5w+d8Je827vn9I9KPaXXQaEpgBxgGcTg7NkZpWHxIUrM3AwgBsgu2W95+s QuLzvQpgMyQ2eng8sLlqtOcRHnb+gBPy6QoilDimud5rvbNrtIZU5IOxbq0H3B6jkMlf0And5cuIc hquXEhNWuSKtdGfcSsnM/qvC+K9hdWuTis8G1bCb3tDMnJeQfse8dMmpFAGsmAklfJkG27Ixwa8Vv gM9JuPyWK53AtbHJU0cFe2ko98bIXLyku15tWoROJ2oZln3OkcOOliibb0Qm7T5voi00PeDbj3bc+ Wedh2f4BPUNs++uBFMfY5w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBbgx-0003nt-6g; Tue, 20 Jun 2023 09:46:43 -0400 Date: Tue, 20 Jun 2023 16:46:50 +0300 Message-Id: <83sfam5jqt.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Milan Jovanovic on Tue, 20 Jun 2023 15:34:42 +0200) References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> <83edm675ke.fsf@gnu.org> <831qi67375.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Milan Jovanovic > Date: Tue, 20 Jun 2023 15:34:42 +0200 > Cc: joaotavora@gmail.com, monnier@iro.umontreal.ca, > kklimonda@syntaxhighlighted.com, 64101@debbugs.gnu.org > > Well, from reading this thread I expected it to be sorted by priority. They are, if they have different priorities and the same overlay properties. The problem was with the SECONDARY priority, since (according to Stefan) the display code doesn't know about that feature. I didn't yet have time to look at that code. From unknown Tue Aug 19 05:14:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jun 2023 13:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Milan Jovanovic Cc: Eli Zaretskii , kklimonda@syntaxhighlighted.com, monnier@iro.umontreal.ca, 64101@debbugs.gnu.org Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.16872689171631 (code B ref 64101); Tue, 20 Jun 2023 13:49:01 +0000 Received: (at 64101) by debbugs.gnu.org; 20 Jun 2023 13:48:37 +0000 Received: from localhost ([127.0.0.1]:58337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBbin-0000QD-0u for submit@debbugs.gnu.org; Tue, 20 Jun 2023 09:48:37 -0400 Received: from mail-oa1-f46.google.com ([209.85.160.46]:55747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBbil-0000Pf-AP for 64101@debbugs.gnu.org; Tue, 20 Jun 2023 09:48:35 -0400 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1a9ae7cc01dso3033566fac.3 for <64101@debbugs.gnu.org>; Tue, 20 Jun 2023 06:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687268909; x=1689860909; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ONRTWhbSqKBR2C9rxsmh26xUiOosaArr9AmbRkrInUU=; b=NEcSJCcedREjrSe0olFwM6BqbP7237ktcTE76ifzMTmq1mejqTWSmCcUgZGivotSxs QxJQoc6hFkhDV5FDulOmPua1o4PsfVULIaqIGqXKI84qO6GkD1sD+C2V6555tlvMt6/t /jqUzN9IgG8Ay3Ik55uxBCtzRnoWu3mCXBfLI8u8J3+br+tzbodGXsFhlVCFVqNnkoaK gmEsjjOCuDFGHoieb4H4zlW/ge/fe9zjBYOK3wJNSsI3Xj3YKPWdJtpbLvNMhPKzLexV ttuY2v5FMleVkehVz4m7a6sZLgqfSahJ8yqP9MC0ctdg6G+l80LckM1mjPWxUGrzaNmD boHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687268909; x=1689860909; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ONRTWhbSqKBR2C9rxsmh26xUiOosaArr9AmbRkrInUU=; b=YvoiZiua5aoJVRjtCumSXxyH28w+sWjxHFIxvGp9xSA8+w2MLdnWli8hwb3t1eEqyK K+mbWUXhzbMoIJYSiDpGgq/ufo6J3YkDk2H59HFTXd/dx4nxVRJYKlpfwqvAJjP7phm5 0bER6gpyGStOb8/Hg0z5c24lW+DBdjSZ2XKKimwJYNKA6MSJ+sNH0w2fRy2b5zConV5J wrB6oDDzGeKBTkGTiJvO9NX/f5SmOxbVnMpZUV1VxQ41j7XnUBgMhuogwmFrSJ8Gh8ji yWhyJjo2OSMsVvGWpWEeFMiXwaG34aslhhChl/jd0zo+RMhCOHxC83lvy3GuF1uPOssu CuAQ== X-Gm-Message-State: AC+VfDx8GL9WYpLdxkernCrbw42lnjITwFbnKCDXOzGVQ7M0UF0Yg8Qi cXBDZlrzHyiiCfuAhiDK4oRgrSiWlMZblK623tE= X-Google-Smtp-Source: ACHHUZ6qTui35iw0Am1HRAdxt0zqI1hWUbvMl4K19ykqO5Ua1ZcatIUiUvhMnzzvY2G86k3aiAijV9GPi3e3EADNa+I= X-Received: by 2002:a05:6870:472a:b0:1a3:365:a8c9 with SMTP id b42-20020a056870472a00b001a30365a8c9mr9511786oaq.44.1687268909346; Tue, 20 Jun 2023 06:48:29 -0700 (PDT) MIME-Version: 1.0 References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> <83edm675ke.fsf@gnu.org> <831qi67375.fsf@gnu.org> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Tue, 20 Jun 2023 14:50:47 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Jun 20, 2023 at 2:34=E2=80=AFPM Milan Jovanovic = wrote: > > Well, from reading this thread I expected it to be sorted by priority. I for one also expected that, though the actual behaviour is defensible too (not to mention the second problem that Milan reported which stemmed from my misplaced expectation is now also fixed in emacs-29, hopefully, I'm just waiting for Milan to confirm). More specifically, I expected setting monotonically increasing priorities as one creates coinciding overlays one after the other to have the exactly the same effect (wrt displaying before-string and after-string) as creating these overlays _without_ setting priorities on a GNU/Linux syst= em with the default memory allocation routines (which as Stefan clarified is a last-resort fallback). IOW: (setq a (make-overlay 10 20)) (setq b (make-overlay 10 20)) (overlay-put a 'after-string "aaa") (overlay-put b 'after-string "bbb") has a half-predictable effect on Linux. In fact it displays exactly the same as doing that with 'before-string'. I would expect that adding (overlay-put a 'priority 1) (overlay-put b 'priority 2) would have now a fully-predictable _same_ effect on every system. The fully-predictable requirement is fullfilled alright, but the display order is reversed if 'after-string' is used. But, again, I guess the behaviour _with_ priorities is defensible too. Though it's not really obvious. Jo=C3=A3o