From unknown Sun Aug 17 00:58:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64082] [PATCH] gnu: dyninst: fix runtime error with new glibc Resent-From: odion@efficios.com Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Jun 2023 16:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64082 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64082@debbugs.gnu.org Cc: Olivier Dion X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16868467655173 (code B ref -1); Thu, 15 Jun 2023 16:33:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Jun 2023 16:32:45 +0000 Received: from localhost ([127.0.0.1]:47674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9ptt-0001LN-B0 for submit@debbugs.gnu.org; Thu, 15 Jun 2023 12:32:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:50148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9ptr-0001LF-79 for submit@debbugs.gnu.org; Thu, 15 Jun 2023 12:32:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9ptp-0003b7-12 for guix-patches@gnu.org; Thu, 15 Jun 2023 12:32:42 -0400 Received: from smtpout.efficios.com ([167.114.26.122]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9ptm-00066B-S8 for guix-patches@gnu.org; Thu, 15 Jun 2023 12:32:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1686846755; bh=uHZ88Xb71ZlmQSgfydFZ+RaH9HxfGxtHB4QR7qXQu6w=; h=From:To:Cc:Subject:Date:From; b=W5zxllsJxt0HgQwHHtFlDI4IizAQr1otA4de2NVhCRFZUXSbAU8JtgUUwonDJm0Hp nkLM3J/uuNdsVqv+goOQSrin4+ooMfq/eRzNMCPIg7TLva8rIZE+r62LmhIM/+Vwza ifk5XbAJJvGS5puIFS0Uf5mb4RWO6/wNDaO3kH9/m3hGA515JdHAwtYgv0nRp/yHts h2onYoVGmPi601DvbqgcFcUGiIf/QNQUlj6eVSr8/t7HWbg1nE+ohlsU7a9n8RTvqq Z+RkoPbij4qGQWGOpM39+on1y/ZotlGe+ZdQ5V4+ZbSLLZvnhVq+uHjwGjrTj9Vrse FUz/jG/+rD1CA== Received: from laura.hitronhub.home (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4Qhnrg5WCKz188n; Thu, 15 Jun 2023 12:32:35 -0400 (EDT) From: odion@efficios.com Date: Thu, 15 Jun 2023 12:32:27 -0400 Message-Id: <0a9c6779a942f280f82839de2900394b6b44dba4.1686846742.git.olivier.dion@polymtl.ca> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=167.114.26.122; envelope-from=odion@efficios.com; helo=smtpout.efficios.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) From: Olivier Dion * gnu/packages/instrumentation.scm (dyninst): fix the error [source]: add patch. * gnu/packages/patches/dyninst-fix-glibc-compatibility.patch: New file. --- gnu/packages/instrumentation.scm | 5 ++- .../dyninst-fix-glibc-compatibility.patch | 33 +++++++++++++++++++ 2 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/dyninst-fix-glibc-compatibility.patch diff --git a/gnu/packages/instrumentation.scm b/gnu/packages/instrumentation.scm index 5d862b5df1..263c2909f3 100644 --- a/gnu/packages/instrumentation.scm +++ b/gnu/packages/instrumentation.scm @@ -18,6 +18,7 @@ ;;; along with GNU Guix. If not, see . (define-module (gnu packages instrumentation) + #:use-module (gnu packages) #:use-module (gnu packages autotools) #:use-module (gnu packages base) #:use-module (gnu packages bash) @@ -178,7 +179,9 @@ (define-public dyninst (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "1m04pg824rqx647wvk9xl33ri8i6mm0vmrz9924li25dxbr4zqd5")))) + (base32 "1m04pg824rqx647wvk9xl33ri8i6mm0vmrz9924li25dxbr4zqd5")) + (patches + (search-patches "dyninst-fix-glibc-compatibility.patch")))) (build-system cmake-build-system) (arguments diff --git a/gnu/packages/patches/dyninst-fix-glibc-compatibility.patch b/gnu/packages/patches/dyninst-fix-glibc-compatibility.patch new file mode 100644 index 0000000000..cd018da6cc --- /dev/null +++ b/gnu/packages/patches/dyninst-fix-glibc-compatibility.patch @@ -0,0 +1,33 @@ +From f233c46ac7b415104d04e4bb74bd7a0fcf24a333 Mon Sep 17 00:00:00 2001 +From: Olivier Dion +Date: Thu, 15 Jun 2023 12:02:08 -0400 +Subject: [PATCH] Fix compatibility with glibc 2.35 + +Something has change with the visibility of the _r_debug structure in +glibc 2.35. See this issue +. + +This patch is essentially the upstream fix + +backported. + +Signed-off-by: Olivier Dion +--- + dyninstAPI_RT/src/RTlinux.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/dyninstAPI_RT/src/RTlinux.c b/dyninstAPI_RT/src/RTlinux.c +index fc231d0a4..2f17ff677 100644 +--- a/dyninstAPI_RT/src/RTlinux.c ++++ b/dyninstAPI_RT/src/RTlinux.c +@@ -406,7 +406,6 @@ void dyninstTrapHandler(int sig, siginfo_t *sg, ucontext_t *context) + #if defined(cap_binary_rewriter) + + extern struct r_debug _r_debug; +-DLLEXPORT struct r_debug _r_debug __attribute__ ((weak)); + + /* Verify that the r_debug variable is visible */ + void r_debugCheck() { assert(_r_debug.r_map); } +-- +2.40.1 + base-commit: f6047c5b716e5d8f3d8a749f389954e4e4c36c16 -- 2.40.1 From unknown Sun Aug 17 00:58:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: odion@efficios.com Subject: bug#64082: closed (Re: bug#64082: [PATCH] gnu: dyninst: fix runtime error with new glibc) Message-ID: References: <878rc829lq.fsf@gnu.org> <0a9c6779a942f280f82839de2900394b6b44dba4.1686846742.git.olivier.dion@polymtl.ca> X-Gnu-PR-Message: they-closed 64082 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 64082@debbugs.gnu.org Date: Sat, 24 Jun 2023 14:56:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1687618562-19112-1" This is a multi-part message in MIME format... ------------=_1687618562-19112-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64082: [PATCH] gnu: dyninst: fix runtime error with new glibc which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64082@debbugs.gnu.org. --=20 64082: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64082 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1687618562-19112-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64082-done) by debbugs.gnu.org; 24 Jun 2023 14:55:47 +0000 Received: from localhost ([127.0.0.1]:41243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD4fy-0004xo-Ox for submit@debbugs.gnu.org; Sat, 24 Jun 2023 10:55:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD4ft-0004xV-Aj for 64082-done@debbugs.gnu.org; Sat, 24 Jun 2023 10:55:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD4fm-0001uP-T2; Sat, 24 Jun 2023 10:55:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=jT6hrWvUCkqoRCKKnjTFKhH/yhAJwKuPixbbHqdlCQk=; b=TUdD99qph3pqNsQT327S 5yqipalm0u0bawP+FcwEUSXo4jgjmicOO7k+m1PULrd+uAuGJUn/51bCwolzVJXJ/a2Q54oTLpK7j zOBc1Uuxwwl6CyePnGGEOGa11ubFwGt600RdzRy8ei1HLv7sJeNOZWEsuGbiOipSzcpxHohxTe3ZO d74DkHqS49bHutqE5PdE3TCm5V1t8RwplCmEwL1Du74Ju0aNQoPj0HwOftwFpqUg1NgNFJd0jdSFE VVYLalxCtYHp92dicLbEvJLRe/q/BNvsILgOjRgP7P9U7+q5GheLRUleciqgoTKshptpvW2nufNGR 5aSNNv4MGou2LQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD4fm-0004Yq-KB; Sat, 24 Jun 2023 10:55:34 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: odion@efficios.com Subject: Re: bug#64082: [PATCH] gnu: dyninst: fix runtime error with new glibc References: <0a9c6779a942f280f82839de2900394b6b44dba4.1686846742.git.olivier.dion@polymtl.ca> Date: Sat, 24 Jun 2023 16:55:29 +0200 In-Reply-To: <0a9c6779a942f280f82839de2900394b6b44dba4.1686846742.git.olivier.dion@polymtl.ca> (odion@efficios.com's message of "Thu, 15 Jun 2023 12:32:27 -0400") Message-ID: <878rc829lq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64082-done Cc: 64082-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Olivier, odion@efficios.com skribis: > From: Olivier Dion > > * gnu/packages/instrumentation.scm (dyninst): fix the error > [source]: add patch. > * gnu/packages/patches/dyninst-fix-glibc-compatibility.patch: New file. qa.guix failed to process it due to obscure reasons (see ): https://qa.guix.gnu.org/issue/64082 I tested it locally on x86_64-linux: it works fine and it fixes a bug, so I applied it (after adding the patch to =E2=80=98gnu/local.mk=E2=80=99 a= nd tweaking the commit log). Thanks, Ludo=E2=80=99. ------------=_1687618562-19112-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Jun 2023 16:32:45 +0000 Received: from localhost ([127.0.0.1]:47674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9ptt-0001LN-B0 for submit@debbugs.gnu.org; Thu, 15 Jun 2023 12:32:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:50148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9ptr-0001LF-79 for submit@debbugs.gnu.org; Thu, 15 Jun 2023 12:32:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9ptp-0003b7-12 for guix-patches@gnu.org; Thu, 15 Jun 2023 12:32:42 -0400 Received: from smtpout.efficios.com ([167.114.26.122]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9ptm-00066B-S8 for guix-patches@gnu.org; Thu, 15 Jun 2023 12:32:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1686846755; bh=uHZ88Xb71ZlmQSgfydFZ+RaH9HxfGxtHB4QR7qXQu6w=; h=From:To:Cc:Subject:Date:From; b=W5zxllsJxt0HgQwHHtFlDI4IizAQr1otA4de2NVhCRFZUXSbAU8JtgUUwonDJm0Hp nkLM3J/uuNdsVqv+goOQSrin4+ooMfq/eRzNMCPIg7TLva8rIZE+r62LmhIM/+Vwza ifk5XbAJJvGS5puIFS0Uf5mb4RWO6/wNDaO3kH9/m3hGA515JdHAwtYgv0nRp/yHts h2onYoVGmPi601DvbqgcFcUGiIf/QNQUlj6eVSr8/t7HWbg1nE+ohlsU7a9n8RTvqq Z+RkoPbij4qGQWGOpM39+on1y/ZotlGe+ZdQ5V4+ZbSLLZvnhVq+uHjwGjrTj9Vrse FUz/jG/+rD1CA== Received: from laura.hitronhub.home (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4Qhnrg5WCKz188n; Thu, 15 Jun 2023 12:32:35 -0400 (EDT) From: odion@efficios.com To: guix-patches@gnu.org Subject: [PATCH] gnu: dyninst: fix runtime error with new glibc Date: Thu, 15 Jun 2023 12:32:27 -0400 Message-Id: <0a9c6779a942f280f82839de2900394b6b44dba4.1686846742.git.olivier.dion@polymtl.ca> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=167.114.26.122; envelope-from=odion@efficios.com; helo=smtpout.efficios.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Olivier Dion X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) From: Olivier Dion * gnu/packages/instrumentation.scm (dyninst): fix the error [source]: add patch. * gnu/packages/patches/dyninst-fix-glibc-compatibility.patch: New file. --- gnu/packages/instrumentation.scm | 5 ++- .../dyninst-fix-glibc-compatibility.patch | 33 +++++++++++++++++++ 2 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/dyninst-fix-glibc-compatibility.patch diff --git a/gnu/packages/instrumentation.scm b/gnu/packages/instrumentation.scm index 5d862b5df1..263c2909f3 100644 --- a/gnu/packages/instrumentation.scm +++ b/gnu/packages/instrumentation.scm @@ -18,6 +18,7 @@ ;;; along with GNU Guix. If not, see . (define-module (gnu packages instrumentation) + #:use-module (gnu packages) #:use-module (gnu packages autotools) #:use-module (gnu packages base) #:use-module (gnu packages bash) @@ -178,7 +179,9 @@ (define-public dyninst (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "1m04pg824rqx647wvk9xl33ri8i6mm0vmrz9924li25dxbr4zqd5")))) + (base32 "1m04pg824rqx647wvk9xl33ri8i6mm0vmrz9924li25dxbr4zqd5")) + (patches + (search-patches "dyninst-fix-glibc-compatibility.patch")))) (build-system cmake-build-system) (arguments diff --git a/gnu/packages/patches/dyninst-fix-glibc-compatibility.patch b/gnu/packages/patches/dyninst-fix-glibc-compatibility.patch new file mode 100644 index 0000000000..cd018da6cc --- /dev/null +++ b/gnu/packages/patches/dyninst-fix-glibc-compatibility.patch @@ -0,0 +1,33 @@ +From f233c46ac7b415104d04e4bb74bd7a0fcf24a333 Mon Sep 17 00:00:00 2001 +From: Olivier Dion +Date: Thu, 15 Jun 2023 12:02:08 -0400 +Subject: [PATCH] Fix compatibility with glibc 2.35 + +Something has change with the visibility of the _r_debug structure in +glibc 2.35. See this issue +. + +This patch is essentially the upstream fix + +backported. + +Signed-off-by: Olivier Dion +--- + dyninstAPI_RT/src/RTlinux.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/dyninstAPI_RT/src/RTlinux.c b/dyninstAPI_RT/src/RTlinux.c +index fc231d0a4..2f17ff677 100644 +--- a/dyninstAPI_RT/src/RTlinux.c ++++ b/dyninstAPI_RT/src/RTlinux.c +@@ -406,7 +406,6 @@ void dyninstTrapHandler(int sig, siginfo_t *sg, ucontext_t *context) + #if defined(cap_binary_rewriter) + + extern struct r_debug _r_debug; +-DLLEXPORT struct r_debug _r_debug __attribute__ ((weak)); + + /* Verify that the r_debug variable is visible */ + void r_debugCheck() { assert(_r_debug.r_map); } +-- +2.40.1 + base-commit: f6047c5b716e5d8f3d8a749f389954e4e4c36c16 -- 2.40.1 ------------=_1687618562-19112-1--