GNU bug report logs - #64071
28.2; smerge-diff creates *vc-diff* without setting it up

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: monnier <at> iro.umontreal.ca, 64071 <at> debbugs.gnu.org
Subject: bug#64071: 28.2; smerge-diff creates *vc-diff* without setting it up
Date: Wed, 28 Jun 2023 14:41:33 +0300

> From: Spencer Baugh <sbaugh <at> janestreet.com>
> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>,  64071 <at> debbugs.gnu.org
> Date: Tue, 27 Jun 2023 16:17:45 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > That command enters diff-mode, and diff-mode doesn't force read-only
> > status on the current buffer.  Why should Smerge force that?
> 
> Buffer named "*vc-diff*" are universally read-only, except if they are
> created through this path.

But users can legitimately make a *vc-diff* buffer modifiable, no?
And your patch silently makes it read-only again, behind the user's
back.  That's hardly nice, is it?

> Stefan likes my simple patch, so what's wrong with it?

See above: we shouldn't change the read-only attribute that was set by
the user.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.