GNU bug report logs - #64069
30.0.50; Mistyped shy group regexps

Previous Next

Full log

Message #11 received at 64069 <at> debbugs.gnu.org (full text, mbox):

From: Basil Contovounesios <contovob <at> tcd.ie>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Alan Mackenzie <acm <at> muc.de>,
 Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 Paul Eggert <eggert <at> cs.ucla.edu>, 64069 <at> debbugs.gnu.org
Subject: Re: bug#64069: 30.0.50; Mistyped shy group regexps
Date: Thu, 15 Jun 2023 08:39:40 +0100

Dmitry Gutov [2023-06-15 04:45 +0300] wrote:

> When you say "encode-time ... is passed ... +0100", what is your testing
> scenario?

Eyeballing the code and git-blame's output.

> IIUC, the change in commit 576fba5f58d removed the complex dates from the output
> (which we parse), replacing them with the simple yyyy-mm-dd format (that's what
> --date=short does). Seems like I tried (8 years ago) to retain the compatibility
> with the previous output in case we'll make the format configurable someday, but
> that still hasn't happened.

Is it not configurable via vc-git-annotate-switches?
When invoking git with multiple --date= options, the last one wins.

> So we could do away with the 'if' condition and simplify the regexp
> accordingly.

You mean ignoring anything other than the YYYY-MM-DD format?

No objections from me, but it's not that hard to fix&keep support for
the default --date=iso output from Git, if desired.

Thanks,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.