From unknown Sun Jun 15 08:53:37 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#64060] [PATCH] gnu: emacs-gptel: Add optional propagated-input. Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: andrew@trop.in, liliana.prikler@gmail.com, guix-patches@gnu.org Resent-Date: Wed, 14 Jun 2023 03:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64060@debbugs.gnu.org Cc: jgart , Nicolas Goaziou , Andrew Tropin , Liliana Marie Prikler X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Andrew Tropin , Liliana Marie Prikler Received: via spool by submit@debbugs.gnu.org id=B.168671409631525 (code B ref -1); Wed, 14 Jun 2023 03:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Jun 2023 03:41:36 +0000 Received: from localhost ([127.0.0.1]:43420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9HO3-0008CP-B5 for submit@debbugs.gnu.org; Tue, 13 Jun 2023 23:41:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:33800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9HO0-0008CE-7d for submit@debbugs.gnu.org; Tue, 13 Jun 2023 23:41:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9HNz-00071g-PN for guix-patches@gnu.org; Tue, 13 Jun 2023 23:41:31 -0400 Received: from mx1.dismail.de ([78.46.223.134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9HNx-0006L0-D0 for guix-patches@gnu.org; Tue, 13 Jun 2023 23:41:31 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id daa4cd45; Wed, 14 Jun 2023 05:41:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=HBLkWwLbI8oGfsch7rDcIdR+9mg/MfvWycNldOqYFz8=; b= Vio2s8gPvXQNUnHVaGqFq0It5ibrEuIKmGmnenGDXTdmoCe2Ja2MLMEyUgWSq8gS XXAHGqgQCkUvslZA51n1qWeOVEgoem9js6kheGsd+BAobCjn1aIu2/gnZlXUcU2o D5nLg3G+LjQoKgyyoOJSVldGCzOYBE8ApRbOQYOtMtK2jmKKI9hIKEj8Ib0Vofcg OxYld8arAfy5DjyHGKrrrBC15lcfD8AWyThXnWpZx9+FmBnAUdZ3EEc8VIQ6beGn qwWtAvuqVvXBj8ks8rm4OMyNOcXkzW7e9v6cb5yJokKoRt580vGWpqr4nPK/C+W9 i6cxdhequ0MUJs5qEx1qZw== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id fd551a60; Wed, 14 Jun 2023 05:41:23 +0200 (CEST) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 20472a3f; Wed, 14 Jun 2023 05:41:23 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id a0cce032 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 14 Jun 2023 05:41:23 +0200 (CEST) From: jgart Date: Tue, 13 Jun 2023 22:41:09 -0500 Message-Id: X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@dismail.de; helo=mx1.dismail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/emacs-xyz.scm (emacs-gptel): Add optional propagated-input. [propagated-inputs]: Add emacs-markdown-mode --- hi guix wdyt what should we do about dependencies like this that are optional according to upstream but might enable important features in a package like markdown rendering. l8terzzz, jgart gnu/packages/emacs-xyz.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f46af73aec..32ab18bd81 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -477,7 +477,8 @@ (define-public emacs-gptel (emacs-substitute-variables "gptel.el" ("gptel-use-curl" 't))))))) (inputs (list curl)) - (propagated-inputs (list emacs-map)) + (propagated-inputs + (list emacs-map emacs-markdown-mode)) (home-page "https://github.com/karthink/gptel") (synopsis "GPTel is a simple ChatGPT client for Emacs") (description base-commit: b94cbbbce70f59b795526a0ed305facf041e6faa prerequisite-patch-id: 955d53943a944fc71068775e0535d85c0f0b71ec prerequisite-patch-id: b40ddb3f1c2f780c18f34b826b1229bb10358ec7 prerequisite-patch-id: 35ea140df746960cf9b020cb8abb74e6889b056c -- 2.40.1 From unknown Sun Jun 15 08:53:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: jgart Subject: bug#64060: closed (Re: [bug#64060] [PATCH] gnu: emacs-gptel: Add optional propagated-input.) Message-ID: References: <87fs6uioj9.fsf@trop.in> X-Gnu-PR-Message: they-closed 64060 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 64060@debbugs.gnu.org Date: Wed, 14 Jun 2023 05:48:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1686721682-13606-1" This is a multi-part message in MIME format... ------------=_1686721682-13606-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64060: [PATCH] gnu: emacs-gptel: Add optional propagated-input. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64060@debbugs.gnu.org. --=20 64060: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64060 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1686721682-13606-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64060-done) by debbugs.gnu.org; 14 Jun 2023 05:47:05 +0000 Received: from localhost ([127.0.0.1]:43476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9JLU-0003Tv-N1 for submit@debbugs.gnu.org; Wed, 14 Jun 2023 01:47:05 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:38661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9JLS-0003TR-I1 for 64060-done@debbugs.gnu.org; Wed, 14 Jun 2023 01:47:03 -0400 X-GND-Sasl: andrew@trop.in DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1686721616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5IGnxJ+fy8vaMVxb0g4Sq/6oRAGXSLop9IpBCd05Bvk=; b=CjV1QNMNvgLy/vocxIf7gOJWHh4GAtcS7g+HkVBtd2mxnqQEghDgrXwAswRnbZJDCgX2fm n4wuyEVi/47yOoY2a2A4FQGCk2VbyHqwmr6pJl057Rr2+qoC3K9hME0+bRbwxAVtkNYTgp Q8b7sZig1N0dJRNrUCV+LNjtrZQ7D7PZYN7kWohOPbVgpD8c8LwNcfkU6DWMcy7zvWS88x SpQ3Fh6+kTo4UBaD5u5yvynbT4zfachNsuNzcKb5lBPptaJkzV3UgE6ewjX8H0lBu2962t DUv/E4Z784k0D0kHHu2uylH42U0FB90NXt2tHIyYZGZK4QA0hAYVD3zavMfLAw== X-GND-Sasl: andrew@trop.in X-GND-Sasl: andrew@trop.in X-GND-Sasl: andrew@trop.in X-GND-Sasl: andrew@trop.in Received: by mail.gandi.net (Postfix) with ESMTPSA id 2310960002; Wed, 14 Jun 2023 05:46:54 +0000 (UTC) From: Andrew Tropin To: jgart , 64060-done@debbugs.gnu.org Subject: Re: [bug#64060] [PATCH] gnu: emacs-gptel: Add optional propagated-input. In-Reply-To: References: Date: Wed, 14 Jun 2023 09:46:50 +0400 Message-ID: <87fs6uioj9.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64060-done Cc: jgart , Liliana Marie Prikler , Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-06-13 22:41, jgart wrote: > * gnu/packages/emacs-xyz.scm (emacs-gptel): Add optional propagated-input. > [propagated-inputs]: Add emacs-markdown-mode > --- > > hi guix wdyt > > what should we do about dependencies like this that are optional > according to upstream but might enable important features in a package > like markdown rendering. > > l8terzzz, > > jgart > > gnu/packages/emacs-xyz.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index f46af73aec..32ab18bd81 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -477,7 +477,8 @@ (define-public emacs-gptel > (emacs-substitute-variables "gptel.el" > ("gptel-use-curl" 't))))))) > (inputs (list curl)) > - (propagated-inputs (list emacs-map)) > + (propagated-inputs > + (list emacs-map emacs-markdown-mode)) > (home-page "https://github.com/karthink/gptel") > (synopsis "GPTel is a simple ChatGPT client for Emacs") > (description > > base-commit: b94cbbbce70f59b795526a0ed305facf041e6faa > prerequisite-patch-id: 955d53943a944fc71068775e0535d85c0f0b71ec > prerequisite-patch-id: b40ddb3f1c2f780c18f34b826b1229bb10358ec7 > prerequisite-patch-id: 35ea140df746960cf9b020cb8abb74e6889b056c IMHO, optional dependencies in most cases should not be propagated by the package, to make it possible to manage them on the user side in a more flexible way. Closing this ticket without merging, let me know if you have other thoughts or opinions on the topic. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmSJVEoACgkQIgjSCVjB 3rB16hAAj6+Pa3dGYpXa17MYpiMsr13zKoLur5RA4Im44K2TCKI9UDHPXssI3C/g QYOqHZahcyNbeWHS9k0mAw0h4/07zpulTcIwHMHEi7KDcJIZv7PVBf4EbHjMD0Nl VRPOjTh9KQoUz8u4hTbSShNUf3qealwsChPYCBwAT2FDlsMMgoPPMYCjhaNBylRL Yh06rM+c+pZfhWtD6LYTgKJip7MXKs5ZaopodAkDNCETvKdXpKEFFe1ahRX4uLmM w1Z5pNeLJlcfsWIHSR99o4ElTN3N+nW4JQxoRD+wV2+vO/ZxoMtxiu1HFsfvjoYO +5h6iS4ECaOUqmSwBs5vmbFo7bEsyFlU39zZLh+55fyOrpVCk3V/UcHMMDEVcoLJ Zl/Rea8GGJ/nm+ytMyFzS75BXGX4YKU2aYyamJ121Osbq/GTyc7S6MbaGzxD6Iz5 a/pmgJkpyXJ+dErbRqtS707gXAQLOCTDTD3nrOj1GnqqVJXcmiFh6xNnRAIwH+x2 cLWU4296Yqn30CuS6RXLWTC0ZtGuB9hElnEMyL2PO7YdOmRQobGP0S3vmau1pwyp e3v78MN9WL+yy4GNtKgbnOS4u8X1zgR73JcUKmEUt683vB4LDiGzVWdzau7xkxft O6PY7X6LanyIcWJxZbVc9GCnOrbhSpz0M5y+KZnn/ilIWwF+xKo= =EVLU -----END PGP SIGNATURE----- --=-=-=-- ------------=_1686721682-13606-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2023 03:41:36 +0000 Received: from localhost ([127.0.0.1]:43420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9HO3-0008CP-B5 for submit@debbugs.gnu.org; Tue, 13 Jun 2023 23:41:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:33800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9HO0-0008CE-7d for submit@debbugs.gnu.org; Tue, 13 Jun 2023 23:41:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9HNz-00071g-PN for guix-patches@gnu.org; Tue, 13 Jun 2023 23:41:31 -0400 Received: from mx1.dismail.de ([78.46.223.134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9HNx-0006L0-D0 for guix-patches@gnu.org; Tue, 13 Jun 2023 23:41:31 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id daa4cd45; Wed, 14 Jun 2023 05:41:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=HBLkWwLbI8oGfsch7rDcIdR+9mg/MfvWycNldOqYFz8=; b= Vio2s8gPvXQNUnHVaGqFq0It5ibrEuIKmGmnenGDXTdmoCe2Ja2MLMEyUgWSq8gS XXAHGqgQCkUvslZA51n1qWeOVEgoem9js6kheGsd+BAobCjn1aIu2/gnZlXUcU2o D5nLg3G+LjQoKgyyoOJSVldGCzOYBE8ApRbOQYOtMtK2jmKKI9hIKEj8Ib0Vofcg OxYld8arAfy5DjyHGKrrrBC15lcfD8AWyThXnWpZx9+FmBnAUdZ3EEc8VIQ6beGn qwWtAvuqVvXBj8ks8rm4OMyNOcXkzW7e9v6cb5yJokKoRt580vGWpqr4nPK/C+W9 i6cxdhequ0MUJs5qEx1qZw== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id fd551a60; Wed, 14 Jun 2023 05:41:23 +0200 (CEST) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 20472a3f; Wed, 14 Jun 2023 05:41:23 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id a0cce032 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 14 Jun 2023 05:41:23 +0200 (CEST) From: jgart To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-gptel: Add optional propagated-input. Date: Tue, 13 Jun 2023 22:41:09 -0500 Message-Id: X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Debbugs-Cc: Andrew Tropin , Liliana Marie Prikler Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@dismail.de; helo=mx1.dismail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: jgart , Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/emacs-xyz.scm (emacs-gptel): Add optional propagated-input. [propagated-inputs]: Add emacs-markdown-mode --- hi guix wdyt what should we do about dependencies like this that are optional according to upstream but might enable important features in a package like markdown rendering. l8terzzz, jgart gnu/packages/emacs-xyz.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f46af73aec..32ab18bd81 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -477,7 +477,8 @@ (define-public emacs-gptel (emacs-substitute-variables "gptel.el" ("gptel-use-curl" 't))))))) (inputs (list curl)) - (propagated-inputs (list emacs-map)) + (propagated-inputs + (list emacs-map emacs-markdown-mode)) (home-page "https://github.com/karthink/gptel") (synopsis "GPTel is a simple ChatGPT client for Emacs") (description base-commit: b94cbbbce70f59b795526a0ed305facf041e6faa prerequisite-patch-id: 955d53943a944fc71068775e0535d85c0f0b71ec prerequisite-patch-id: b40ddb3f1c2f780c18f34b826b1229bb10358ec7 prerequisite-patch-id: 35ea140df746960cf9b020cb8abb74e6889b056c -- 2.40.1 ------------=_1686721682-13606-1--