GNU bug report logs - #64060
[PATCH] gnu: emacs-gptel: Add optional propagated-input.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64060 in the body.
You can then email your comments to 64060 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: [PATCH] gnu: emacs-gptel: Add optional propagated-input.
Date: Tue, 13 Jun 2023 22:41:09 -0500

* gnu/packages/emacs-xyz.scm (emacs-gptel): Add optional propagated-input.
[propagated-inputs]: Add emacs-markdown-mode
---

hi guix wdyt

what should we do about dependencies like this that are optional
according to upstream but might enable important features in a package
like markdown rendering.

l8terzzz,

jgart

 gnu/packages/emacs-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f46af73aec..32ab18bd81 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -477,7 +477,8 @@ (define-public emacs-gptel
               (emacs-substitute-variables "gptel.el"
                 ("gptel-use-curl" 't)))))))
     (inputs (list curl))
-    (propagated-inputs (list emacs-map))
+    (propagated-inputs
+     (list emacs-map emacs-markdown-mode))
     (home-page "https://github.com/karthink/gptel")
     (synopsis "GPTel is a simple ChatGPT client for Emacs")
     (description

base-commit: b94cbbbce70f59b795526a0ed305facf041e6faa
prerequisite-patch-id: 955d53943a944fc71068775e0535d85c0f0b71ec
prerequisite-patch-id: b40ddb3f1c2f780c18f34b826b1229bb10358ec7
prerequisite-patch-id: 35ea140df746960cf9b020cb8abb74e6889b056c
-- 
2.40.1

Message #10 received at 64060-done <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: jgart <jgart <at> dismail.de>, 64060-done <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#64060] [PATCH] gnu: emacs-gptel: Add optional
 propagated-input.
Date: Wed, 14 Jun 2023 09:46:50 +0400

[Message part 1 (text/plain, inline)]

On 2023-06-13 22:41, jgart wrote:

> * gnu/packages/emacs-xyz.scm (emacs-gptel): Add optional propagated-input.
> [propagated-inputs]: Add emacs-markdown-mode
> ---
>
> hi guix wdyt
>
> what should we do about dependencies like this that are optional
> according to upstream but might enable important features in a package
> like markdown rendering.
>
> l8terzzz,
>
> jgart
>
>  gnu/packages/emacs-xyz.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index f46af73aec..32ab18bd81 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -477,7 +477,8 @@ (define-public emacs-gptel
>                (emacs-substitute-variables "gptel.el"
>                  ("gptel-use-curl" 't)))))))
>      (inputs (list curl))
> -    (propagated-inputs (list emacs-map))
> +    (propagated-inputs
> +     (list emacs-map emacs-markdown-mode))
>      (home-page "https://github.com/karthink/gptel")
>      (synopsis "GPTel is a simple ChatGPT client for Emacs")
>      (description
>
> base-commit: b94cbbbce70f59b795526a0ed305facf041e6faa
> prerequisite-patch-id: 955d53943a944fc71068775e0535d85c0f0b71ec
> prerequisite-patch-id: b40ddb3f1c2f780c18f34b826b1229bb10358ec7
> prerequisite-patch-id: 35ea140df746960cf9b020cb8abb74e6889b056c

IMHO, optional dependencies in most cases should not be propagated by
the package, to make it possible to manage them on the user side in a
more flexible way.

Closing this ticket without merging, let me know if you have other
thoughts or opinions on the topic.

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.