GNU bug report logs - #64058
[PATCH] wc: Fix crashes due to incomplete AVX2 enumeration

Previous Next

Full log

Message #11 received at 64058 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>,
 Dave Hansen <dave.hansen <at> linux.intel.com>, Axel Beckert <abe <at> debian.org>
Cc: Kristoffer Brånemyr <ztion1 <at> yahoo.se>,
 64058 <at> debbugs.gnu.org
Subject: Re: bug#64058: [PATCH] wc: Fix crashes due to incomplete AVX2
 enumeration
Date: Wed, 14 Jun 2023 11:46:58 +0100

[Message part 1 (text/plain, inline)]

On 14/06/2023 05:14, Paul Eggert wrote:
> Thanks for the bug report. I installed the attached patch into coreutils
> on Savannah. It builds on your idea with several other changes:
> 
> * There's a similar issue with cksum.c and pclmul.
> 
> * configure.ac can be simplified, since it seems there's no point
> compiling these instructions if __builtin_cpu_supports doesn't work.
> 
> * This lets us simplify the source code a bit more.
> 
> Please let me know if the attached patch works for you.

__builtin_cpu_supports() looks to have sufficient support in
Arch + compiler versions for our needs, so that's good.

Paul you removed the "avx" check from cksum.c. Was that intended?

> PS. Does the attached cksum.c / pclmul change fix any user-visible
> misbehavior? If so, what should we put into the NEWS file?

We have an illegal instruction issue with cksum under Xen DomU
which may be related, as discussed at: https://bugs.debian.org/1037264

Axel does the attached patch change anything for you?

thanks,
Pádraig

[cksum-xsave.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.