From unknown Sat Jun 21 10:36:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64058 <64058@debbugs.gnu.org> To: bug#64058 <64058@debbugs.gnu.org> Subject: Status: [PATCH] wc: Fix crashes due to incomplete AVX2 enumeration Reply-To: bug#64058 <64058@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:36:24 +0000 retitle 64058 [PATCH] wc: Fix crashes due to incomplete AVX2 enumeration reassign 64058 coreutils submitter 64058 Dave Hansen severity 64058 normal tag 64058 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 13 22:39:25 2023 Received: (at submit) by debbugs.gnu.org; 14 Jun 2023 02:39:25 +0000 Received: from localhost ([127.0.0.1]:43374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9GPt-0006Rb-13 for submit@debbugs.gnu.org; Tue, 13 Jun 2023 22:39:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:37600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q97mx-00089j-7b for submit@debbugs.gnu.org; Tue, 13 Jun 2023 13:26:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q97mw-0003Wc-VK for bug-coreutils@gnu.org; Tue, 13 Jun 2023 13:26:38 -0400 Received: from mga17.intel.com ([192.55.52.151]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q97mu-0006sW-Uv for bug-coreutils@gnu.org; Tue, 13 Jun 2023 13:26:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686677196; x=1718213196; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=rPUrOyPVvukcuqEWI7oRWEWSKMGPRGYzjbbXxKp7OH0=; b=dbgOr3qp8OyB6lLx3M/5Gx+GcPYpEhzjg2zjilvJerhEnAWztyB3Wmb4 eNaO13cp4+Ty2+gwfo+YM5zqUsIGbSoIwgwMVRvUQNR0BfcYJbfWylPK1 SyD750EtcTLJvIhtTIO5y2OdJtzDsxzpV3xyH1ftFeQq2Ll4TGC+8YH73 UX4t4++YmLIkasCAzcm4o93ZwWTcK3awnQYc9mBJOf+6PhKjGjwvlszyU 2vSetBFU1mDMe0cc9xi4vKNwBHfOxVkFiRVU8IbJCiXrJWACmVHKM4tPQ /nE4rm1h7OoMJmFdnd3siylrjYpLCFVRpTDg+aBC7AdM8kSTBU9ebqlUu g==; X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="338759195" X-IronPort-AV: E=Sophos;i="6.00,240,1681196400"; d="scan'208";a="338759195" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 10:26:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="662081620" X-IronPort-AV: E=Sophos;i="6.00,240,1681196400"; d="scan'208";a="662081620" Received: from viggo.jf.intel.com (HELO ray2.intel.com) ([10.54.77.144]) by orsmga003.jf.intel.com with ESMTP; 13 Jun 2023 10:26:17 -0700 From: Dave Hansen To: bug-coreutils@gnu.org Subject: [PATCH] wc: Fix crashes due to incomplete AVX2 enumeration Date: Tue, 13 Jun 2023 10:26:10 -0700 Message-Id: <20230613172610.3429200-1-dave.hansen@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=192.55.52.151; envelope-from=dave.hansen@linux.intel.com; helo=mga17.intel.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 13 Jun 2023 22:39:20 -0400 Cc: =?UTF-8?q?Kristoffer=20Br=C3=A5nemyr?= , Dave Hansen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) The AVX2 enumeration for 'wc -l' is incomplete which may cause wc to crash. The Intel SDM documents the whole AVX2 enumeration sequence in its "Detection of Intel AVX2" section. There are three pieces: 1. Ensuring the CPU supports AVX2 instructions 2. Ensuring the OS has enabled XSAVE 3. Ensuring XSAVE is managing the YMM registers (XGETBV) The existing code does #1 and #2 but misses #3. The kernel will enable #3 in almost all situations where AVX2 is supported, but there are situations where the kernel might disable XSAVE YMM support but leave FP and SSE enabled. This is _unusual_ today, but can occur when Linux notices XSAVE enumeration issues or in virtual machines with odd/buggy XSAVE enumeration. If wc is used on one of those systems in '-l' mode, it will crash: # cat foo | ./wc.orig -l Illegal instruction (core dumped) Fortunately, gcc and llvm provide a builtin to check for CPU support and AVX2 is supported. Use the builtin instead of using CPUID directly. This fixes the problem and is also substantially simpler. The result is that wc no longer crashes on systems where XSAVE YMM support is disabled: # cat foo | ./wc.fixed -l 30232 I've reproduced this issue in the current upstream git repo which git describe says is v9.3-53-g378902407. I needed to run a patched version of Linux to expose this issue. We (the upstream Linux x86 maintainers) are considering merging a patch to do this in the upstream kernel. It would be great if a wc fix was available. --- src/wc.c | 36 +----------------------------------- 1 file changed, 1 insertion(+), 35 deletions(-) diff --git a/src/wc.c b/src/wc.c index becceda98..944cfc426 100644 --- a/src/wc.c +++ b/src/wc.c @@ -157,41 +157,7 @@ static enum total_type total_mode = total_auto; static bool avx2_supported (void) { - unsigned int eax = 0; - unsigned int ebx = 0; - unsigned int ecx = 0; - unsigned int edx = 0; - bool getcpuid_ok = false; - bool avx_enabled = false; - - if (__get_cpuid (1, &eax, &ebx, &ecx, &edx)) - { - getcpuid_ok = true; - if (ecx & bit_OSXSAVE) - avx_enabled = true; /* Support is not disabled. */ - } - - - if (avx_enabled) - { - eax = ebx = ecx = edx = 0; - if (! __get_cpuid_count (7, 0, &eax, &ebx, &ecx, &edx)) - getcpuid_ok = false; - else - { - if (! (ebx & bit_AVX2)) - avx_enabled = false; /* Hardware doesn't support it. */ - } - } - - - if (! getcpuid_ok) - { - if (debug) - error (0, 0, "%s", _("failed to get cpuid")); - return false; - } - else if (! avx_enabled) + if (!__builtin_cpu_supports("avx2")) { if (debug) error (0, 0, "%s", _("avx2 support not detected")); -- 2.34.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 14 00:15:07 2023 Received: (at 64058) by debbugs.gnu.org; 14 Jun 2023 04:15:07 +0000 Received: from localhost ([127.0.0.1]:43433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9HuU-0000pH-SI for submit@debbugs.gnu.org; Wed, 14 Jun 2023 00:15:07 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:39070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9HuR-0000oQ-7T for 64058@debbugs.gnu.org; Wed, 14 Jun 2023 00:15:04 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id B7D003C09FA2C; Tue, 13 Jun 2023 21:14:56 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id QLKbokopI0_D; Tue, 13 Jun 2023 21:14:55 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 9EAB63C09FB42; Tue, 13 Jun 2023 21:14:55 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 9EAB63C09FB42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1686716095; bh=LVR+AAWlKfNxdeB4aPwOV3E92rbshrpZf8hmfakxxzY=; h=Message-ID:Date:MIME-Version:To:From; b=TTc0tlo1176yd0l4dpz+4Js3isfKX8d7F0WJxwl2FPvN2kBkRvq+i4H7KLpeY5+62 8Vqohfea0J1HjX9Y5PZ3EkqYmnmQUN5DsPXm0/g+Vx5iHnhONgUb9yzf9wqS5PyXS6 CRrDUcRsV+sLyf7ygQtaQfNt5F5kO7V4HbNYCEBKeDzwT6VXM2ezWa0IA7Wc8ROwVS UpC7PbWlJXSuhtHvgxEsdL3mVioCx5XwJKw9AW7XO8K/xr77MYtaVS2n+SPCYs5gGa vKSzpc85CDNEP+PScXeoOzz2vQ5Q9e/F6HvyV53y5qnh/k+8TSqa3do6pPdUI+cEyA 7wQlusfTz7HRg== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id E7mNgIbwjPHJ; Tue, 13 Jun 2023 21:14:55 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 82A813C09FA2C; Tue, 13 Jun 2023 21:14:55 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------mgoGgl0xV64SKh8FoF90qa27" Message-ID: <878f503d-da58-8f8a-35df-b5288a5cc282@cs.ucla.edu> Date: Tue, 13 Jun 2023 21:14:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: bug#64058: [PATCH] wc: Fix crashes due to incomplete AVX2 enumeration Content-Language: en-US To: Dave Hansen References: <20230613172610.3429200-1-dave.hansen@linux.intel.com> From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <20230613172610.3429200-1-dave.hansen@linux.intel.com> X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 64058 Cc: =?UTF-8?Q?Kristoffer_Br=c3=a5nemyr?= , 64058@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This is a multi-part message in MIME format. --------------mgoGgl0xV64SKh8FoF90qa27 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the bug report. I installed the attached patch into coreutils on Savannah. It builds on your idea with several other changes: * There's a similar issue with cksum.c and pclmul. * configure.ac can be simplified, since it seems there's no point compiling these instructions if __builtin_cpu_supports doesn't work. * This lets us simplify the source code a bit more. Please let me know if the attached patch works for you. PS. Does the attached cksum.c / pclmul change fix any user-visible misbehavior? If so, what should we put into the NEWS file? --------------mgoGgl0xV64SKh8FoF90qa27 Content-Type: text/x-patch; charset=UTF-8; name="0001-wc-port-to-kernels-that-disable-XSAVE-YMM.patch" Content-Disposition: attachment; filename="0001-wc-port-to-kernels-that-disable-XSAVE-YMM.patch" Content-Transfer-Encoding: base64 RnJvbSA5MWE3NGQzNjE0NjE0OTRkZDU0NjQ2N2U4M2JjMzZjMjQxODVkNmU3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDEzIEp1biAyMDIzIDIxOjEwOjI0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gd2M6IHBvcnQgdG8ga2VybmVscyB0aGF0IGRpc2FibGUgWFNBVkUgWU1NCgpQcm9ibGVt IHJlcG9ydGVkIGJ5IERhdmUgSGFuc2VuIDxodHRwczovL2J1Z3MuZ251Lm9yZy82NDA1OD4u CkFwcGx5IHNpbWlsYXIgY2hhbmdlIHRvIGNrc3VtIGFuZCBwY2xtdWwsIHRvby4KKiBORVdT OiBNZW50aW9uIHdjIGZpeC4KKiBjb25maWd1cmUuYWMgKGNwdWlkX2V4aXN0cywgZ2V0X2Nw dWlkX2NvdW50X2V4aXN0cyk6ClJlbW92ZS4gIEFsbCB1c2VzIHJlbW92ZWQsIHNpbmNlIHdl IG5vIGxvbmdlciB1c2UgX19nZXRfY3B1aWQgb3IKX19nZXRfY3B1aWRfY291bnQuCihwY2xt dWxfaW50cmluc2ljX2V4aXN0cywgYXZ4Ml9pbnRyaW5zaWNfZXhpc3RzKTogU2V0IHRvIG5v IGlmCl9fYnVpbHRpbl9jcHVfc3VwcG9ydHMgY2FsbHMgY2Fubm90IGJlIGNvbXBpbGVkLgoo SEFWRV9QQ0xNVUxfSU5UUklOU0lDLCBIQVZFX0FWWDJfSU5UUklOU0lDKTogUmVtb3ZlOyB1 bnVzZWQuClNpbXBsaWZ5IHN1cnJvdW5kaW5nIGNvZGUgYmVjYXVzZSBvZiB0aGlzLgoqIHNy Yy9ja3N1bS5jIChwY2xtdWxfc3VwcG9ydGVkKToKKiBzcmMvd2MuYyAoYXZ4Ml9zdXBwb3J0 ZWQpOgpVc2UgX19idWlsdGluX2NwdV9zdXBwb3J0cyBpbnN0ZWFkIG9mIGRvaW5nIGl0IGJ5 IGhhbmQuClNpbXBsaWZ5IHN1cnJvdW5kaW5nIGNvZGUgYmVjYXVzZSBvZiB0aGlzLgotLS0K IE5FV1MgICAgICAgICB8ICAzICsrKwogY29uZmlndXJlLmFjIHwgNjcgKysrKysrKystLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogc3JjL2Nrc3VtLmMg IHwgMjYgKysrKystLS0tLS0tLS0tLS0tLS0KIHNyYy93Yy5jICAgICB8IDUwICsrKysrLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogNCBmaWxlcyBjaGFuZ2VkLCAyNSBp bnNlcnRpb25zKCspLCAxMjEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTkVXUyBiL05F V1MKaW5kZXggN2RmOWZmNWIwLi4zMzUwZjk4NzEgMTAwNjQ0Ci0tLSBhL05FV1MKKysrIGIv TkVXUwpAQCAtMjksNiArMjksOSBAQCBHTlUgY29yZXV0aWxzIE5FV1MgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAtKi0gb3V0bGluZSAtKi0KICAgJ3ByIC0tbGVuZ3Ro PTEgLS1kb3VibGUtc3BhY2UnIG5vIGxvbmdlciBlbnRlcnMgYW4gaW5maW5pdGUgbG9vcC4K ICAgW1RoaXMgYnVnIHdhcyBwcmVzZW50IGluICJ0aGUgYmVnaW5uaW5nIi5dCiAKKyAgJ3dj IC1sJyBubyBsb25nZXIgY3Jhc2hlcyBvbiB4ODYgTGludXgga2VybmVscyB0aGF0IGRpc2Fi bGUgWFNBVkUgWU1NLgorICBbYnVnIGludHJvZHVjZWQgaW4gY29yZXV0aWxzLTkuMF0KKwog KiogQ2hhbmdlcyBpbiBiZWhhdmlvcgogCiAgICdjcCAtdicgYW5kICdtdiAtdicgd2lsbCBu byBsb25nZXIgb3V0cHV0IGEgbWVzc2FnZSBmb3IgZWFjaCBmaWxlIHNraXBwZWQKZGlmZiAt LWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCA1MjBkZTgxODQuLjQ4 ZGVhOWQwMSAxMDA2NDQKLS0tIGEvY29uZmlndXJlLmFjCisrKyBiL2NvbmZpZ3VyZS5hYwpA QCAtNTQ4LDI3ICs1NDgsNiBAQCBDRkxBR1M9JGFjX3NhdmVfQ0ZMQUdTCiBMREZMQUdTPSRh Y19zYXZlX0xERkxBR1MKIGFjX2Nfd2Vycm9yX2ZsYWc9JGN1X3NhdmVfY193ZXJyb3JfZmxh ZwogCi1BQ19NU0dfQ0hFQ0tJTkcoW2lmIF9fZ2V0X2NwdWlkIGF2YWlsYWJsZV0pCi1BQ19M SU5LX0lGRUxTRSgKLSAgW0FDX0xBTkdfU09VUkNFKFtbCi0gICAgI2luY2x1ZGUgPGNwdWlk Lmg+Ci0KLSAgICBpbnQKLSAgICBtYWluICh2b2lkKQotICAgIHsKLSAgICAgIHVuc2lnbmVk IGludCBlYXgsIGVieCwgZWN4LCBlZHg7Ci0gICAgICBfX2dldF9jcHVpZCAoMSwgJmVheCwg JmVieCwgJmVjeCwgJmVkeCk7Ci0gICAgICByZXR1cm4gMTsKLSAgICB9Ci0gIF1dKQotICBd LFsKLSAgICBBQ19NU0dfUkVTVUxUKFt5ZXNdKQotICAgIEFDX0RFRklORShbSEFWRV9DUFVJ RF0sIFsxXSwgW19fZ2V0X2NwdWlkIGF2YWlsYWJsZV0pCi0gICAgY3B1aWRfZXhpc3RzPXll cwotICBdLFsKLSAgICBBQ19NU0dfUkVTVUxUKFtub10pCi0gIF0pCi0KIGFjX3NhdmVfQ0ZM QUdTPSRDRkxBR1MKIENGTEFHUz0iLW1hdnggLW1wY2xtdWwgJENGTEFHUyIKIEFDX01TR19D SEVDS0lORyhbaWYgcGNsbXVsIGludHJpbnNpYyBleGlzdHNdKQpAQCAtNTgyLDQ2ICs1NjEs MjMgQEAgQUNfQ09NUElMRV9JRkVMU0UoCiAgICAgICBfX20xMjhpIGEsIGI7CiAgICAgICBh ID0gX21tX2NsbXVsZXBpNjRfc2kxMjggKGEsIGIsIDB4MDApOwogICAgICAgYSA9IF9tbV9z aHVmZmxlX2VwaTggKGEsIGIpOwotICAgICAgcmV0dXJuIDE7CisgICAgICByZXR1cm4gX19i dWlsdGluX2NwdV9zdXBwb3J0cyAoInBjbG11bCIpOwogICAgIH0KICAgXV0pCiAgIF0sWwot ICAgIEFDX01TR19SRVNVTFQoW3llc10pCi0gICAgQUNfREVGSU5FKFtIQVZFX1BDTE1VTF9J TlRSSU5TSUNdLCBbMV0sIFtwY2xtdWwgaW50cmluc2ljIGV4aXN0c10pCiAgICAgcGNsbXVs X2ludHJpbnNpY19leGlzdHM9eWVzCiAgIF0sWwotICAgIEFDX01TR19SRVNVTFQoW25vXSkK KyAgICBwY2xtdWxfaW50cmluc2ljX2V4aXN0cz1ubwogICBdKQotaWYgdGVzdCAieCRjcHVp ZF9leGlzdHMiID0gInh5ZXMiICYmCi0gICB0ZXN0ICJ4JHBjbG11bF9pbnRyaW5zaWNfZXhp c3RzIiA9ICJ4eWVzIjsgdGhlbgorQUNfTVNHX1JFU1VMVChbJHBjbG11bF9pbnRyaW5zaWNf ZXhpc3RzXSkKK2lmIHRlc3QgJHBjbG11bF9pbnRyaW5zaWNfZXhpc3RzID0geWVzOyB0aGVu CiAgIEFDX0RFRklORShbVVNFX1BDTE1VTF9DUkMzMl0sIFsxXSwKICAgICAgICAgICAgIFtD UkMzMiBjYWxjdWxhdGlvbiBieSBwY2xtdWwgaGFyZHdhcmUgaW5zdHJ1Y3Rpb24gZW5hYmxl ZF0pCiBmaQogQU1fQ09ORElUSU9OQUwoW1VTRV9QQ0xNVUxfQ1JDMzJdLAotICAgICAgICAg ICAgICAgW3Rlc3QgIngkY3B1aWRfZXhpc3RzIiA9ICJ4eWVzIiAmJgotICAgICAgICAgICAg ICAgIHRlc3QgIngkcGNsbXVsX2ludHJpbnNpY19leGlzdHMiID0gInh5ZXMiXSkKKyAgICAg ICAgICAgICAgIFt0ZXN0ICRwY2xtdWxfaW50cmluc2ljX2V4aXN0cyA9IHllc10pCiBDRkxB R1M9JGFjX3NhdmVfQ0ZMQUdTCiAKLUFDX01TR19DSEVDS0lORyhbaWYgX19nZXRfY3B1aWRf Y291bnQgZXhpc3RzXSkKLUFDX0xJTktfSUZFTFNFKAotICBbQUNfTEFOR19TT1VSQ0UoW1sK LSAgICAjaW5jbHVkZSA8Y3B1aWQuaD4KLQotICAgIGludAotICAgIG1haW4gKHZvaWQpCi0g ICAgewotICAgICAgdW5zaWduZWQgaW50IGVheCA9IDAsIGVieCA9IDAsIGVjeCA9IDAsIGVk eCA9IDA7Ci0gICAgICBfX2dldF9jcHVpZF9jb3VudCAoNywgMCwgJmVheCwgJmVieCwgJmVj eCwgJmVkeCk7Ci0gICAgICByZXR1cm4gMTsKLSAgICB9Ci0gIF1dKQotICBdLFsKLSAgICBB Q19NU0dfUkVTVUxUKFt5ZXNdKQotICAgIGdldF9jcHVpZF9jb3VudF9leGlzdHM9eWVzCi0g IF0sWwotICAgIEFDX01TR19SRVNVTFQoW25vXSkKLSAgXSkKLQogQ0ZMQUdTPSItbWF2eDIg JENGTEFHUyIKIEFDX01TR19DSEVDS0lORyhbaWYgYXZ4MiBpbnRyaW5zdGljcyBleGlzdHNd KQogQUNfQ09NUElMRV9JRkVMU0UoCkBAIC02MzMsMjMgKzU4OSwyMCBAQCBBQ19DT01QSUxF X0lGRUxTRSgKICAgICB7CiAgICAgICBfX20yNTZpIGEsIGI7CiAgICAgICBhID0gX21tMjU2 X3NhZF9lcHU4IChhLCBiKTsKLSAgICAgIHJldHVybiAxOworICAgICAgcmV0dXJuIF9fYnVp bHRpbl9jcHVfc3VwcG9ydHMgKCJhdngyIik7CiAgICAgfQogICBdXSkKICAgXSxbCi0gICAg QUNfTVNHX1JFU1VMVChbeWVzXSkKLSAgICBBQ19ERUZJTkUoW0hBVkVfQVZYMl9JTlRSSU5T SUNdLCBbMV0sIFthdngyIGludHJpbnNpY3MgZXhpc3RzXSkKICAgICBhdngyX2ludHJpbnNp Y19leGlzdHM9eWVzCiAgIF0sWwotICAgIEFDX01TR19SRVNVTFQoW25vXSkKKyAgICBhdngy X2ludHJpbnNpY19leGlzdHM9bm8KICAgXSkKLWlmIHRlc3QgIngkZ2V0X2NwdWlkX2NvdW50 X2V4aXN0cyIgPSAieHllcyIgJiYKLSAgIHRlc3QgIngkYXZ4Ml9pbnRyaW5zaWNfZXhpc3Rz IiA9ICJ4eWVzIjsgdGhlbgorQUNfTVNHX1JFU1VMVChbJGF2eDJfaW50cmluc2ljX2V4aXN0 c10pCitpZiB0ZXN0ICRhdngyX2ludHJpbnNpY19leGlzdHMgPSB5ZXM7IHRoZW4KICAgQUNf REVGSU5FKFtVU0VfQVZYMl9XQ19MSU5FQ09VTlRdLCBbMV0sIFtDb3VudGluZyBsaW5lcyB3 aXRoIEFWWDIgZW5hYmxlZF0pCiBmaQogQU1fQ09ORElUSU9OQUwoW1VTRV9BVlgyX1dDX0xJ TkVDT1VOVF0sCi0gICAgICAgICAgICAgICBbdGVzdCAieCRnZXRfY3B1aWRfY291bnRfZXhp c3RzIiA9ICJ4eWVzIiAmJgotICAgICAgICAgICAgICAgIHRlc3QgIngkYXZ4Ml9pbnRyaW5z aWNfZXhpc3RzIiA9ICJ4eWVzIl0pCisgICAgICAgICAgICAgICBbdGVzdCAkYXZ4Ml9pbnRy aW5zaWNfZXhpc3RzID0geWVzXSkKIAogQ0ZMQUdTPSRhY19zYXZlX0NGTEFHUwogCmRpZmYg LS1naXQgYS9zcmMvY2tzdW0uYyBiL3NyYy9ja3N1bS5jCmluZGV4IDg1YWZhYjBhYy4uNjMx YWMzNDQ5IDEwMDY0NAotLS0gYS9zcmMvY2tzdW0uYworKysgYi9zcmMvY2tzdW0uYwpAQCAt MTYwLDI5ICsxNjAsMTUgQEAgc3RhdGljIGJvb2wKIHBjbG11bF9zdXBwb3J0ZWQgKHZvaWQp CiB7CiAjIGlmIFVTRV9QQ0xNVUxfQ1JDMzIKLSAgdW5zaWduZWQgaW50IGVheCA9IDA7Ci0g IHVuc2lnbmVkIGludCBlYnggPSAwOwotICB1bnNpZ25lZCBpbnQgZWN4ID0gMDsKLSAgdW5z aWduZWQgaW50IGVkeCA9IDA7Ci0KLSAgaWYgKCEgX19nZXRfY3B1aWQgKDEsICZlYXgsICZl YngsICZlY3gsICZlZHgpKQotICAgIHsKLSAgICAgIGlmIChja3N1bV9kZWJ1ZykKLSAgICAg ICAgZXJyb3IgKDAsIDAsICIlcyIsIF8oImZhaWxlZCB0byBnZXQgY3B1aWQiKSk7Ci0gICAg ICByZXR1cm4gZmFsc2U7Ci0gICAgfQotCi0gIGlmICghIChlY3ggJiBiaXRfUENMTVVMKSB8 fCAhIChlY3ggJiBiaXRfQVZYKSkKLSAgICB7Ci0gICAgICBpZiAoY2tzdW1fZGVidWcpCi0g ICAgICAgIGVycm9yICgwLCAwLCAiJXMiLCBfKCJwY2xtdWwgc3VwcG9ydCBub3QgZGV0ZWN0 ZWQiKSk7Ci0gICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQorICBib29sIHBjbG11bF9lbmFi bGVkID0gMCA8IF9fYnVpbHRpbl9jcHVfc3VwcG9ydHMgKCJwY2xtdWwiKTsKIAogICBpZiAo Y2tzdW1fZGVidWcpCi0gICAgZXJyb3IgKDAsIDAsICIlcyIsIF8oInVzaW5nIHBjbG11bCBo YXJkd2FyZSBzdXBwb3J0IikpOworICAgIGVycm9yICgwLCAwLCAiJXMiLAorICAgICAgICAg ICAocGNsbXVsX2VuYWJsZWQKKyAgICAgICAgICAgID8gXygidXNpbmcgcGNsbXVsIGhhcmR3 YXJlIHN1cHBvcnQiKQorICAgICAgICAgICAgOiBfKCJwY2xtdWwgc3VwcG9ydCBub3QgZGV0 ZWN0ZWQiKSkpOwogCi0gIHJldHVybiB0cnVlOworICByZXR1cm4gcGNsbXVsX2VuYWJsZWQ7 CiAjIGVsc2UKICAgaWYgKGNrc3VtX2RlYnVnKQogICAgIGVycm9yICgwLCAwLCAiJXMiLCBf KCJ1c2luZyBnZW5lcmljIGhhcmR3YXJlIHN1cHBvcnQiKSk7CmRpZmYgLS1naXQgYS9zcmMv d2MuYyBiL3NyYy93Yy5jCmluZGV4IGJlY2NlZGE5OC4uMzcwOGQwYjhmIDEwMDY0NAotLS0g YS9zcmMvd2MuYworKysgYi9zcmMvd2MuYwpAQCAtMTU3LDUyICsxNTcsMTQgQEAgc3RhdGlj IGVudW0gdG90YWxfdHlwZSB0b3RhbF9tb2RlID0gdG90YWxfYXV0bzsKIHN0YXRpYyBib29s CiBhdngyX3N1cHBvcnRlZCAodm9pZCkKIHsKLSAgdW5zaWduZWQgaW50IGVheCA9IDA7Ci0g IHVuc2lnbmVkIGludCBlYnggPSAwOwotICB1bnNpZ25lZCBpbnQgZWN4ID0gMDsKLSAgdW5z aWduZWQgaW50IGVkeCA9IDA7Ci0gIGJvb2wgZ2V0Y3B1aWRfb2sgPSBmYWxzZTsKLSAgYm9v bCBhdnhfZW5hYmxlZCA9IGZhbHNlOwotCi0gIGlmIChfX2dldF9jcHVpZCAoMSwgJmVheCwg JmVieCwgJmVjeCwgJmVkeCkpCi0gICAgewotICAgICAgZ2V0Y3B1aWRfb2sgPSB0cnVlOwot ICAgICAgaWYgKGVjeCAmIGJpdF9PU1hTQVZFKQotICAgICAgICBhdnhfZW5hYmxlZCA9IHRy dWU7ICAvKiBTdXBwb3J0IGlzIG5vdCBkaXNhYmxlZC4gICovCi0gICAgfQotCi0KLSAgaWYg KGF2eF9lbmFibGVkKQotICAgIHsKLSAgICAgIGVheCA9IGVieCA9IGVjeCA9IGVkeCA9IDA7 Ci0gICAgICBpZiAoISBfX2dldF9jcHVpZF9jb3VudCAoNywgMCwgJmVheCwgJmVieCwgJmVj eCwgJmVkeCkpCi0gICAgICAgIGdldGNwdWlkX29rID0gZmFsc2U7Ci0gICAgICBlbHNlCi0g ICAgICAgIHsKLSAgICAgICAgICBpZiAoISAoZWJ4ICYgYml0X0FWWDIpKQotICAgICAgICAg ICAgYXZ4X2VuYWJsZWQgPSBmYWxzZTsgIC8qIEhhcmR3YXJlIGRvZXNuJ3Qgc3VwcG9ydCBp dC4gICovCi0gICAgICAgIH0KLSAgICB9CisgIGJvb2wgYXZ4X2VuYWJsZWQgPSAwIDwgX19i dWlsdGluX2NwdV9zdXBwb3J0cyAoImF2eDIiKTsKIAorICBpZiAoZGVidWcpCisgICAgZXJy b3IgKDAsIDAsIChhdnhfZW5hYmxlZAorICAgICAgICAgICAgICAgICAgPyBfKCJ1c2luZyBh dngyIGhhcmR3YXJlIHN1cHBvcnQiKQorICAgICAgICAgICAgICAgICAgOiBfKCJhdngyIHN1 cHBvcnQgbm90IGRldGVjdGVkIikpKTsKIAotICBpZiAoISBnZXRjcHVpZF9vaykKLSAgICB7 Ci0gICAgICBpZiAoZGVidWcpCi0gICAgICAgIGVycm9yICgwLCAwLCAiJXMiLCBfKCJmYWls ZWQgdG8gZ2V0IGNwdWlkIikpOwotICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KLSAgZWxz ZSBpZiAoISBhdnhfZW5hYmxlZCkKLSAgICB7Ci0gICAgICBpZiAoZGVidWcpCi0gICAgICAg IGVycm9yICgwLCAwLCAiJXMiLCBfKCJhdngyIHN1cHBvcnQgbm90IGRldGVjdGVkIikpOwot ICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KLSAgZWxzZQotICAgIHsKLSAgICAgIGlmIChk ZWJ1ZykKLSAgICAgICAgZXJyb3IgKDAsIDAsICIlcyIsIF8oInVzaW5nIGF2eDIgaGFyZHdh cmUgc3VwcG9ydCIpKTsKLSAgICAgIHJldHVybiB0cnVlOwotICAgIH0KKyAgcmV0dXJuIGF2 eF9lbmFibGVkOwogfQogI2VuZGlmCiAKLS0gCjIuNDAuMQoK --------------mgoGgl0xV64SKh8FoF90qa27-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 14 06:47:08 2023 Received: (at 64058) by debbugs.gnu.org; 14 Jun 2023 10:47:09 +0000 Received: from localhost ([127.0.0.1]:43823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9O1s-0005jP-F3 for submit@debbugs.gnu.org; Wed, 14 Jun 2023 06:47:08 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:44475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9O1q-0005iu-CY for 64058@debbugs.gnu.org; Wed, 14 Jun 2023 06:47:07 -0400 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-30fc6b513afso2102515f8f.1 for <64058@debbugs.gnu.org>; Wed, 14 Jun 2023 03:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686739620; x=1689331620; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=xukslxbXUcOKQM6krl/ECjERSgdePHXO3VQHp1bxT8A=; b=fupRZhiMHeKfs2PBw5D0AkLCkrxCwcV2vZknyAj/N/HQoFNiHoKYtKzEifj0nqTPO+ tbhg4VEpreQwZwuA/0TB74HuBf6hxB7vIMVSxTFe3KS5Bxa6jhoaUAgo0dN7h0FKTQt9 QuDawTuuw8jT2+g/06KF0QeHuP9zH2HZEIT74OEBca9LCSDt1NCr8Hpm9crlsJCiBTe2 uyLV/ctGX7WKz+Bc8v2WD5pIZUsqz1ucwqYiVkx0511/LU0j/0jQ26hA8H0R6CKRuMjf kPU9fFVT5fk5Kd1rGVl2rFn/d+CT4vEcyVsiIwDBZgw38wbyDlU9XEfFisSb+SfAdz6H uX+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686739620; x=1689331620; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xukslxbXUcOKQM6krl/ECjERSgdePHXO3VQHp1bxT8A=; b=SOg5JG4/z3cIGEHrN046cCnnKwHxmfhcjVldEIgUQSIK3bsRSr0X2IAP7By2TejHMO Tr0uuD68kSjbcLOt8MQ3TUk/LjtRwZj3+A/3tCWn+qfH7SJKOiwjHJ2xtfSuVGoXE1JN EnRs25WsCMKvCpqATfSg9yic3dANH0C6Tmd5iG0xn6mXcSrZB+Sy73QVkfGnamE0P+Cy ZzCDvgcN6VZnTYeslEGhwKF34UNey4SmfmyJFPw2MCKOYzRKmWbQ1Ip+/1BeEKZkDL5U g/vl5Fr6o1vsXXIJzO9NbgaWQrPNrRD7K04XH8P8xEi8K+1XjkeLKafud+Dr9gHTl91R dzBw== X-Gm-Message-State: AC+VfDyvO4zjHHmNUUr+O2WpqTDj+z3QZJwZ9NSHxpq6nn7873lWKxwL Q3GLI38Vtc8Jasy34lvBVRw= X-Google-Smtp-Source: ACHHUZ687hG7hPWVnHVDTgLe2cahnvRWSJlWh9IROWWvRhy1vz2SdEjZzC+rcHk5kMTI4TO3L0qIoA== X-Received: by 2002:a05:6000:10d1:b0:30f:c703:8be3 with SMTP id b17-20020a05600010d100b0030fc7038be3mr4323504wrx.42.1686739620016; Wed, 14 Jun 2023 03:47:00 -0700 (PDT) Received: from [192.168.1.19] (95-44-90-175-dynamic.agg2.lod.rsl-rtd.eircom.net. [95.44.90.175]) by smtp.googlemail.com with ESMTPSA id y17-20020adfee11000000b0030af05fce4dsm17971633wrn.77.2023.06.14.03.46.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 03:46:59 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------MNLfjbdh00h0nyH3W8j1aseL" Message-ID: Date: Wed, 14 Jun 2023 11:46:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#64058: [PATCH] wc: Fix crashes due to incomplete AVX2 enumeration Content-Language: en-US To: Paul Eggert , Dave Hansen , Axel Beckert References: <20230613172610.3429200-1-dave.hansen@linux.intel.com> <878f503d-da58-8f8a-35df-b5288a5cc282@cs.ucla.edu> From: =?UTF-8?Q?P=C3=A1draig_Brady?= In-Reply-To: <878f503d-da58-8f8a-35df-b5288a5cc282@cs.ucla.edu> X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 64058 Cc: =?UTF-8?Q?Kristoffer_Br=C3=A5nemyr?= , 64058@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) This is a multi-part message in MIME format. --------------MNLfjbdh00h0nyH3W8j1aseL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/06/2023 05:14, Paul Eggert wrote: > Thanks for the bug report. I installed the attached patch into coreutils > on Savannah. It builds on your idea with several other changes: > > * There's a similar issue with cksum.c and pclmul. > > * configure.ac can be simplified, since it seems there's no point > compiling these instructions if __builtin_cpu_supports doesn't work. > > * This lets us simplify the source code a bit more. > > Please let me know if the attached patch works for you. __builtin_cpu_supports() looks to have sufficient support in Arch + compiler versions for our needs, so that's good. Paul you removed the "avx" check from cksum.c. Was that intended? > PS. Does the attached cksum.c / pclmul change fix any user-visible > misbehavior? If so, what should we put into the NEWS file? We have an illegal instruction issue with cksum under Xen DomU which may be related, as discussed at: https://bugs.debian.org/1037264 Axel does the attached patch change anything for you? thanks, Pádraig --------------MNLfjbdh00h0nyH3W8j1aseL Content-Type: text/x-patch; charset=UTF-8; name="cksum-xsave.patch" Content-Disposition: attachment; filename="cksum-xsave.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9ja3N1bS5jIGIvc3JjL2Nrc3VtLmMKaW5kZXggODVhZmFiMGFj Li44ODFkOTA0MTMgMTAwNjQ0Ci0tLSBhL3NyYy9ja3N1bS5jCisrKyBiL3NyYy9ja3N1bS5j CkBAIC0xNjAsMjkgKzE2MCwxNiBAQCBzdGF0aWMgYm9vbAogcGNsbXVsX3N1cHBvcnRlZCAo dm9pZCkKIHsKICMgaWYgVVNFX1BDTE1VTF9DUkMzMgotICB1bnNpZ25lZCBpbnQgZWF4ID0g MDsKLSAgdW5zaWduZWQgaW50IGVieCA9IDA7Ci0gIHVuc2lnbmVkIGludCBlY3ggPSAwOwot ICB1bnNpZ25lZCBpbnQgZWR4ID0gMDsKLQotICBpZiAoISBfX2dldF9jcHVpZCAoMSwgJmVh eCwgJmVieCwgJmVjeCwgJmVkeCkpCi0gICAgewotICAgICAgaWYgKGNrc3VtX2RlYnVnKQot ICAgICAgICBlcnJvciAoMCwgMCwgIiVzIiwgXygiZmFpbGVkIHRvIGdldCBjcHVpZCIpKTsK LSAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9Ci0KLSAgaWYgKCEgKGVjeCAmIGJpdF9QQ0xN VUwpIHx8ICEgKGVjeCAmIGJpdF9BVlgpKQotICAgIHsKLSAgICAgIGlmIChja3N1bV9kZWJ1 ZykKLSAgICAgICAgZXJyb3IgKDAsIDAsICIlcyIsIF8oInBjbG11bCBzdXBwb3J0IG5vdCBk ZXRlY3RlZCIpKTsKLSAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9CisgIGJvb2wgcGNsbXVs X2VuYWJsZWQgPSAwIDwgX19idWlsdGluX2NwdV9zdXBwb3J0cyAoInBjbG11bCIpCisgICAg ICAgICAgICAgICAgICAgICAgICAmJiAwIDwgX19idWlsdGluX2NwdV9zdXBwb3J0cyAoImF2 eCIpOwogCiAgIGlmIChja3N1bV9kZWJ1ZykKLSAgICBlcnJvciAoMCwgMCwgIiVzIiwgXygi dXNpbmcgcGNsbXVsIGhhcmR3YXJlIHN1cHBvcnQiKSk7CisgICAgZXJyb3IgKDAsIDAsICIl cyIsCisgICAgICAgICAgIChwY2xtdWxfZW5hYmxlZAorICAgICAgICAgICAgPyBfKCJ1c2lu ZyBwY2xtdWwgaGFyZHdhcmUgc3VwcG9ydCIpCisgICAgICAgICAgICA6IF8oInBjbG11bCBz dXBwb3J0IG5vdCBkZXRlY3RlZCIpKSk7CiAKLSAgcmV0dXJuIHRydWU7CisgIHJldHVybiBw Y2xtdWxfZW5hYmxlZDsKICMgZWxzZQogICBpZiAoY2tzdW1fZGVidWcpCiAgICAgZXJyb3Ig KDAsIDAsICIlcyIsIF8oInVzaW5nIGdlbmVyaWMgaGFyZHdhcmUgc3VwcG9ydCIpKTsK --------------MNLfjbdh00h0nyH3W8j1aseL-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 14 12:44:48 2023 Received: (at 64058) by debbugs.gnu.org; 14 Jun 2023 16:44:48 +0000 Received: from localhost ([127.0.0.1]:45358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Tbz-0003dm-Qn for submit@debbugs.gnu.org; Wed, 14 Jun 2023 12:44:48 -0400 Received: from sym.noone.org ([178.63.92.236]:50622 helo=sym2.noone.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Q2L-0003Lh-7L for 64058@debbugs.gnu.org; Wed, 14 Jun 2023 08:55:45 -0400 Received: by sym2.noone.org (Postfix, from userid 1000) id 4Qh54v4j9Dzvjfm; Wed, 14 Jun 2023 14:55:43 +0200 (CEST) Date: Wed, 14 Jun 2023 14:55:43 +0200 From: Axel Beckert To: =?iso-8859-1?Q?P=E1draig?= Brady Subject: Re: bug#64058: [PATCH] wc: Fix crashes due to incomplete AVX2 enumeration Message-ID: <20230614125541.z3ohdqwlzpbjd2el@sym.noone.org> References: <20230613172610.3429200-1-dave.hansen@linux.intel.com> <878f503d-da58-8f8a-35df-b5288a5cc282@cs.ucla.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux 4.9.0-18-amd64 X-Machine: sym2 x86_64 X-Editor: GNU Emacs 25.1.1 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAALVBMVEVEREQiIiL///9VVVUzMzNm ZmYRERF3d3eIiIju7u6ZmZnd3d27u7uqqqrMzMx6FhjdAAACUklEQVQ4y3XUMYvUQBQH8BcnnDZC xosRhRPZ47hbdllG3g5YWGTYYRsVjhuHoF2aqRck5ECURYtdBJs0tnIIp9htZ3cINoKNWPkFLPwS vuyRZLN7plryy755M/Ofgc5/Hqh/db8Und7fYgMGM5vMsuRtsQaDUwOATOYv2tCbZchIpLWfWvAt MQIRJVp7r1iBd9YKwPNHnjTQNWgEo5eCCRRPGtgHuayEAiCGqw2cMYNojUGhQ63ZooZDBtLmBgE0 51yfVDAAzWyeofB9zdMovFTBgQ6QQAjQikc8fVDBHT6SCQH4BDxNdyrY41Rplhvhl0Ok0fV6DC7z fJ5b9LhzkXNBBV2V5PlxnhmfRy6NHC+qdkVmrUGbiXWY0lIozdAoKuQcX1Qw4bFP/YRaRfSHBrpD FT5WoRcyMXYubUohfR74YQgMhy7i47qr36/VNhp6TbvCld7arqA/F1em1FZynBmtgq0b9er+ME9P bZLP55kBP/Bu1dDL3nzEZDlH2sIV6Nv5bELLklnBZDZuYGAtGpbYMhLSuJVSBlQgpCk3Xd51O01K Dj0+oqQgbW48drebXBmPx+cpiXWU3mzgmR/GsEyPhsitwHtaQj5C2luNXnqtgTNaWR2XKYkJjhrY BUqoD5pUDu8XDewzGoFAhSM5/LqS9n55NmgAHjIrW+eDsijKBmK0D1sw0RRbx0NAcdSCX1QmSjlN xl+0YF9R1rgGEI/WTu33D5R/Av/V+jnfo6YILm9cALvl9AB/bsCBLuH55l3SnRK8vOiS6fyRny+8 fdaef/SP2dCp/isOAAAAAElFTkSuQmCC Organization: The Debian Project User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 64058 X-Mailman-Approved-At: Wed, 14 Jun 2023 12:44:46 -0400 Cc: Kristoffer =?iso-8859-1?Q?Br=E5nemyr?= , Paul Eggert , Dave Hansen , 1037264@bugs.debian.org, 64058@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Control: tag 1037264 + patch Hi Pádraig, On Wed, Jun 14, 2023 at 11:46:58AM +0100, Pádraig Brady wrote: > On 14/06/2023 05:14, Paul Eggert wrote: > > Thanks for the bug report. I installed the attached patch into coreutils > > on Savannah. It builds on your idea with several other changes: > > > > * There's a similar issue with cksum.c and pclmul. > > > > * configure.ac can be simplified, since it seems there's no point > > compiling these instructions if __builtin_cpu_supports doesn't work. > > > > * This lets us simplify the source code a bit more. > > > > Please let me know if the attached patch works for you. > > __builtin_cpu_supports() looks to have sufficient support in > Arch + compiler versions for our needs, so that's good. > > Paul you removed the "avx" check from cksum.c. Was that intended? > > > PS. Does the attached cksum.c / pclmul change fix any user-visible > > misbehavior? If so, what should we put into the NEWS file? > > We have an illegal instruction issue with cksum under Xen DomU > which may be related, as discussed at: https://bugs.debian.org/1037264 > > Axel does the attached patch change anything for you? Yes! This patch helps! Thanks a lot! :-) Cc'ing the Debian bug report again (and doing a nearly fullquote for that) and tagging Debian's bug report as containing a patch. (Given it's high bug report number it should do any harm in GNU's BTS even if it uses the same control syntax…) > diff --git a/src/cksum.c b/src/cksum.c > index 85afab0ac..881d90413 100644 > --- a/src/cksum.c > +++ b/src/cksum.c > @@ -160,29 +160,16 @@ static bool > pclmul_supported (void) > { > # if USE_PCLMUL_CRC32 > - unsigned int eax = 0; > - unsigned int ebx = 0; > - unsigned int ecx = 0; > - unsigned int edx = 0; > - > - if (! __get_cpuid (1, &eax, &ebx, &ecx, &edx)) > - { > - if (cksum_debug) > - error (0, 0, "%s", _("failed to get cpuid")); > - return false; > - } > - > - if (! (ecx & bit_PCLMUL) || ! (ecx & bit_AVX)) > - { > - if (cksum_debug) > - error (0, 0, "%s", _("pclmul support not detected")); > - return false; > - } > + bool pclmul_enabled = 0 < __builtin_cpu_supports ("pclmul") > + && 0 < __builtin_cpu_supports ("avx"); > > if (cksum_debug) > - error (0, 0, "%s", _("using pclmul hardware support")); > + error (0, 0, "%s", > + (pclmul_enabled > + ? _("using pclmul hardware support") > + : _("pclmul support not detected"))); > > - return true; > + return pclmul_enabled; > # else > if (cksum_debug) > error (0, 0, "%s", _("using generic hardware support")); Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 14 18:05:08 2023 Received: (at 64058) by debbugs.gnu.org; 14 Jun 2023 22:05:08 +0000 Received: from localhost ([127.0.0.1]:45680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Ybz-0002xu-Dj for submit@debbugs.gnu.org; Wed, 14 Jun 2023 18:05:07 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:49586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Ybw-0002xB-Mq for 64058@debbugs.gnu.org; Wed, 14 Jun 2023 18:05:06 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 85F573C020F7C; Wed, 14 Jun 2023 15:04:58 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id juubFrHyJoVi; Wed, 14 Jun 2023 15:04:58 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 0179E3C09FA2C; Wed, 14 Jun 2023 15:04:58 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 0179E3C09FA2C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1686780298; bh=GZiPCxY/WeOrye9wW8Lk7sU6yeQ4ZWxLIaUYcHO+Hk0=; h=Message-ID:Date:MIME-Version:To:From; b=SYlFgBSsVp/iVCfxsPiadb+MeeVgHYqLdtDeSkPCaf2Wfj4IlyW8LiUla9DvMnFZR GtKpNqcDfeNzcbRQKDjvXrlSiV+h0ZoafAEK9Aelvv31iNQBYwEpAhCmogrdyx7QMX 7msr2h51XZ8u4dASRSZnDuQ8KISlbk/whLwc2K0tOgNX2Gk14wGH4ixlpUFUJJzBaz uZhqodTvzC1cgDkwVeyzu//zSco4+dYuVUehAIvqNd4URANGHowOxE7B2h2e1KYsCl QIR6wkUeWijozRNndWWiv0LLSBb1zDjcNzSdQErkk39WyzK6KFO39nno9Nu2lVN2Ry mQASXAzK1I8dw== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id smPdn0vKCRHL; Wed, 14 Jun 2023 15:04:57 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id C55513C020F7C; Wed, 14 Jun 2023 15:04:57 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------8KnPJjlT29LbnBN36jFdG5Li" Message-ID: Date: Wed, 14 Jun 2023 15:04:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: bug#64058: [PATCH] wc: Fix crashes due to incomplete AVX2 enumeration Content-Language: en-US To: =?UTF-8?Q?P=c3=a1draig_Brady?= , Dave Hansen , Axel Beckert References: <20230613172610.3429200-1-dave.hansen@linux.intel.com> <878f503d-da58-8f8a-35df-b5288a5cc282@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 64058 Cc: =?UTF-8?Q?Kristoffer_Br=c3=a5nemyr?= , 64058@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This is a multi-part message in MIME format. --------------8KnPJjlT29LbnBN36jFdG5Li Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 6/14/23 03:46, P=C3=A1draig Brady wrote: > Paul you removed the "avx" check from cksum.c. Was that intended? No, it's a typo I introduced. Thanks for catching that. Fixed in the=20 first attached patch. While looking into this I noticed a couple of other cleanups, fixed in=20 the other attached patches. I installed these into coreutils on Savannah. --------------8KnPJjlT29LbnBN36jFdG5Li Content-Type: text/x-patch; charset=UTF-8; name="0001-cksum-fix-bug-in-check-for-cksum_pclmul.patch" Content-Disposition: attachment; filename="0001-cksum-fix-bug-in-check-for-cksum_pclmul.patch" Content-Transfer-Encoding: base64 RnJvbSA3ODE0NTk2ZmE5MWEwN2ZiMmYxZDA5NzJmOTNmMjZkZThhNGFkNTQ3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDE0IEp1biAyMDIzIDE0OjEzOjM1IC0wNzAwClN1YmplY3Q6IFtQQVRD SCAxLzNdIGNrc3VtOiBmaXggYnVnIGluIGNoZWNrIGZvciBja3N1bV9wY2xtdWwKTUlNRS1W ZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNv bnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKClRoaXMgZml4ZXMgYSB0eXBvIGluIHRo ZSBwcmV2aW91cyBwYXRjaC4KUHJvYmxlbSByZXBvcnRlZCBieSBQw6FkcmFpZyBCcmFkeSA8 aHR0cHM6Ly9idWdzLmdudS5vcmcvNjQwNTgjMTE+LgoqIHNyYy9ja3N1bS5jIChwY2xtdWxf c3VwcG9ydGVkKTogQWxzbyByZXF1aXJlIEFWWCBzdXBwb3J0CnRvIHVzZSBja3N1bV9wY2xt dWwuCi0tLQogc3JjL2Nrc3VtLmMgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9ja3N1bS5jIGIvc3Jj L2Nrc3VtLmMKaW5kZXggNjMxYWMzNDQ5Li5lOTM1YmE3NWMgMTAwNjQ0Ci0tLSBhL3NyYy9j a3N1bS5jCisrKyBiL3NyYy9ja3N1bS5jCkBAIC0xNjAsNyArMTYwLDggQEAgc3RhdGljIGJv b2wKIHBjbG11bF9zdXBwb3J0ZWQgKHZvaWQpCiB7CiAjIGlmIFVTRV9QQ0xNVUxfQ1JDMzIK LSAgYm9vbCBwY2xtdWxfZW5hYmxlZCA9IDAgPCBfX2J1aWx0aW5fY3B1X3N1cHBvcnRzICgi cGNsbXVsIik7CisgIGJvb2wgcGNsbXVsX2VuYWJsZWQgPSAoMCA8IF9fYnVpbHRpbl9jcHVf c3VwcG9ydHMgKCJwY2xtdWwiKQorICAgICAgICAgICAgICAgICAgICAgICAgICYmIDAgPCBf X2J1aWx0aW5fY3B1X3N1cHBvcnRzICgiYXZ4IikpOwogCiAgIGlmIChja3N1bV9kZWJ1ZykK ICAgICBlcnJvciAoMCwgMCwgIiVzIiwKLS0gCjIuNDAuMQoK --------------8KnPJjlT29LbnBN36jFdG5Li Content-Type: text/x-patch; charset=UTF-8; name="0002-cksum-wc-don-t-include-cpuid.h.patch" Content-Disposition: attachment; filename="0002-cksum-wc-don-t-include-cpuid.h.patch" Content-Transfer-Encoding: base64 RnJvbSA0YWM5NDE1NjVmYzFmN2MxZWI3OTU0MzAyZjJlYzIwNDM1ZmRmMzRjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDE0IEp1biAyMDIzIDE0OjE4OjQyIC0wNzAwClN1YmplY3Q6IFtQQVRD SCAyLzNdID0/VVRGLTg/cT9ja3N1bSx3Yzo9MjBkb249RTI9ODA9OTl0PTIwaW5jbHVkZT0y MDxjcHVpPz0KID0/VVRGLTg/cT9kLmg+Pz0KTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1U eXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rp bmc6IDhiaXQKCiogc3JjL2Nrc3VtLmMgWyFDUkNUQUIgJiYgVVNFX1BDTE1VTF9DUkMzMl06 Ciogc3JjL3djLmMgW1VTRV9BVlgyX1dDX0xJTkVDT1VOVF06CkRvbuKAmXQgaW5jbHVkZSA8 Y3B1aWQuaD47IG5vIGxvbmdlciBuZWVkZWQuCi0tLQogc3JjL2Nrc3VtLmMgfCA0ICstLS0K IHNyYy93Yy5jICAgIHwgMyAtLS0KIDIgZmlsZXMgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks IDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2Nrc3VtLmMgYi9zcmMvY2tzdW0u YwppbmRleCBlOTM1YmE3NWMuLjM1MmEwYmEzYSAxMDA2NDQKLS0tIGEvc3JjL2Nrc3VtLmMK KysrIGIvc3JjL2Nrc3VtLmMKQEAgLTE0MSw5ICsxNDEsNyBAQCBtYWluICh2b2lkKQogIyBp bmNsdWRlICJlcnJvci5oIgogCiAjIGluY2x1ZGUgImNrc3VtLmgiCi0jIGlmIFVTRV9QQ0xN VUxfQ1JDMzIKLSMgIGluY2x1ZGUgImNwdWlkLmgiCi0jIGVsc2UKKyMgaWYgIVVTRV9QQ0xN VUxfQ1JDMzIKICMgIGRlZmluZSBja3N1bV9wY2xtdWwgY2tzdW1fc2xpY2U4CiAjIGVuZGlm IC8qIFVTRV9QQ0xNVUxfQ1JDMzIgKi8KIApkaWZmIC0tZ2l0IGEvc3JjL3djLmMgYi9zcmMv d2MuYwppbmRleCAzNzA4ZDBiOGYuLmViZTgzYWY0ZCAxMDA2NDQKLS0tIGEvc3JjL3djLmMK KysrIGIvc3JjL3djLmMKQEAgLTM4LDkgKzM4LDYgQEAKICNpbmNsdWRlICJzYWZlLXJlYWQu aCIKICNpbmNsdWRlICJzdGF0LXNpemUuaCIKICNpbmNsdWRlICJ4YmluYXJ5LWlvLmgiCi0j aWZkZWYgVVNFX0FWWDJfV0NfTElORUNPVU5UCi0jIGluY2x1ZGUgPGNwdWlkLmg+Ci0jZW5k aWYKIAogI2lmICFkZWZpbmVkIGlzd3NwYWNlICYmICFIQVZFX0lTV1NQQUNFCiAjIGRlZmlu ZSBpc3dzcGFjZSh3YykgXAotLSAKMi40MC4xCgo= --------------8KnPJjlT29LbnBN36jFdG5Li Content-Type: text/x-patch; charset=UTF-8; name="0003-cksum-wc-clean-up-hw-capability-checking.patch" Content-Disposition: attachment; filename="0003-cksum-wc-clean-up-hw-capability-checking.patch" Content-Transfer-Encoding: base64 RnJvbSBmNzgwYTg1OTg1ZjViMDY5YmE4NTk3YWFlYWM0OWViNzQ4NjQ5MjZhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDE0IEp1biAyMDIzIDE0OjUyOjM3IC0wNzAwClN1YmplY3Q6IFtQQVRD SCAzLzNdIGNrc3VtLHdjOiBjbGVhbiB1cCBodyBjYXBhYmlsaXR5IGNoZWNraW5nCk1JTUUt VmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApD b250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgoqIHNyYy9ja3N1bS5jIChja3N1bV9w Y2xtdWwpIFshQ1JDVEFCICYmICFVU0VfUENMTVVMX0NSQzMyXToKUmVtb3ZlIG1hY3JvLgoo Y2tzdW1fZnApOiBObyBsb25nZXIgZmlsZS1zY29wZS4KKHBjbG11bF9zdXBwb3J0ZWQpOiBE ZWZpbmUgb25seSBpZiBVU0VfUENMTVVMX0NSQzMyLgpUaGlzIG9taXRzIHRoZSBkZWJ1ZyBv dXRwdXQgInVzaW5nIGdlbmVyaWMgaGFyZHdhcmUgc3VwcG9ydCIKZm9yIHNpbXBsaWNpdHkg YW5kIGNvbnNpc3RlbmN5IHdpdGggd2PigJlzIG91dHB1dC4KKGNyY19zdW1fc3RyZWFtKSBb IVVTRV9QQ0xNVUxfMzJdOiBObyBuZWVkIGZvciBzdGF0aWMgZnVuY3Rpb24gcG9pbnRlci4K KiBzcmMvd2MuYyAod2NfbGluZXNfcCkgW1VTRV9BVlgyX1dDX0xJTkVDT1VOVF06IE5vIGxv bmdlciBmaWxlLXNjb3BlLgood2MpIFtVU0VfQVZYMl9XQ19MSU5FQ09VTlRdOiBDaGVjayBm b3IgYXZ4MiBzdXBwb3J0IGF0IG1vc3Qgb25jZSwKd2hpY2ggd2FzIHN1cmVseSB0aGUgY29k ZeKAmXMgb3JpZ2luYWwgaW50ZW50Lgood2MpIFshVVNFX0FWWDJfV0NfTElORUNPVU5UXTog Tm8gbmVlZCBmb3Igc3RhdGljIGZ1bmN0aW9uIHBvaW50ZXIuCi0tLQogc3JjL2Nrc3VtLmMg fCAyOSArKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQogc3JjL3djLmMgICAgfCAxNCAr KysrKystLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAyOSBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvY2tzdW0uYyBiL3NyYy9ja3N1bS5jCmlu ZGV4IDM1MmEwYmEzYS4uMjZiYjI5YmRiIDEwMDY0NAotLS0gYS9zcmMvY2tzdW0uYworKysg Yi9zcmMvY2tzdW0uYwpAQCAtMTQxLDIzICsxNDEsMTQgQEAgbWFpbiAodm9pZCkKICMgaW5j bHVkZSAiZXJyb3IuaCIKIAogIyBpbmNsdWRlICJja3N1bS5oIgotIyBpZiAhVVNFX1BDTE1V TF9DUkMzMgotIyAgZGVmaW5lIGNrc3VtX3BjbG11bCBja3N1bV9zbGljZTgKLSMgZW5kaWYg LyogVVNFX1BDTE1VTF9DUkMzMiAqLwogCiAvKiBOdW1iZXIgb2YgYnl0ZXMgdG8gcmVhZCBh dCBvbmNlLiAgKi8KICMgZGVmaW5lIEJVRkxFTiAoMSA8PCAxNikKIAotCi1zdGF0aWMgYm9v bAotY2tzdW1fc2xpY2U4IChGSUxFICpmcCwgdWludF9mYXN0MzJfdCAqY3JjX291dCwgdWlu dG1heF90ICpsZW5ndGhfb3V0KTsKLXN0YXRpYyBib29sCi0gICgqY2tzdW1fZnApKEZJTEUg KiwgdWludF9mYXN0MzJfdCAqLCB1aW50bWF4X3QgKik7Ci0KKyMgaWYgVVNFX1BDTE1VTF9D UkMzMgogc3RhdGljIGJvb2wKIHBjbG11bF9zdXBwb3J0ZWQgKHZvaWQpCiB7Ci0jIGlmIFVT RV9QQ0xNVUxfQ1JDMzIKICAgYm9vbCBwY2xtdWxfZW5hYmxlZCA9ICgwIDwgX19idWlsdGlu X2NwdV9zdXBwb3J0cyAoInBjbG11bCIpCiAgICAgICAgICAgICAgICAgICAgICAgICAgJiYg MCA8IF9fYnVpbHRpbl9jcHVfc3VwcG9ydHMgKCJhdngiKSk7CiAKQEAgLTE2OCwxMiArMTU5 LDggQEAgcGNsbXVsX3N1cHBvcnRlZCAodm9pZCkKICAgICAgICAgICAgIDogXygicGNsbXVs IHN1cHBvcnQgbm90IGRldGVjdGVkIikpKTsKIAogICByZXR1cm4gcGNsbXVsX2VuYWJsZWQ7 Ci0jIGVsc2UKLSAgaWYgKGNrc3VtX2RlYnVnKQotICAgIGVycm9yICgwLCAwLCAiJXMiLCBf KCJ1c2luZyBnZW5lcmljIGhhcmR3YXJlIHN1cHBvcnQiKSk7Ci0gIHJldHVybiBmYWxzZTsK LSMgZW5kaWYgLyogVVNFX1BDTE1VTF9DUkMzMiAqLwogfQorIyBlbmRpZiAvKiBVU0VfUENM TVVMX0NSQzMyICovCiAKIHN0YXRpYyBib29sCiBja3N1bV9zbGljZTggKEZJTEUgKmZwLCB1 aW50X2Zhc3QzMl90ICpjcmNfb3V0LCB1aW50bWF4X3QgKmxlbmd0aF9vdXQpCkBAIC0yMzgs MTMgKzIyNSwxMyBAQCBjcmNfc3VtX3N0cmVhbSAoRklMRSAqc3RyZWFtLCB2b2lkICpyZXNz dHJlYW0sIHVpbnRtYXhfdCAqbGVuZ3RoKQogICB1aW50bWF4X3QgdG90YWxfYnl0ZXMgPSAw OwogICB1aW50X2Zhc3QzMl90IGNyYyA9IDA7CiAKKyMgaWYgVVNFX1BDTE1VTF9DUkMzMgor ICBzdGF0aWMgYm9vbCAoKmNrc3VtX2ZwKSAoRklMRSAqLCB1aW50X2Zhc3QzMl90ICosIHVp bnRtYXhfdCAqKTsKICAgaWYgKCEgY2tzdW1fZnApCi0gICAgewotICAgICAgIGlmIChwY2xt dWxfc3VwcG9ydGVkICgpKQotICAgICAgICAgY2tzdW1fZnAgPSBja3N1bV9wY2xtdWw7Ci0g ICAgICAgZWxzZQotICAgICAgICAgY2tzdW1fZnAgPSBja3N1bV9zbGljZTg7Ci0gICAgfQor ICAgIGNrc3VtX2ZwID0gcGNsbXVsX3N1cHBvcnRlZCAoKSA/IGNrc3VtX3BjbG11bCA6IGNr c3VtX3NsaWNlODsKKyNlbHNlCisgIGJvb2wgKCpja3N1bV9mcCkgKEZJTEUgKiwgdWludF9m YXN0MzJfdCAqLCB1aW50bWF4X3QgKikgPSBja3N1bV9zbGljZTg7CisjZW5kaWYKIAogICBp ZiAoISBja3N1bV9mcCAoc3RyZWFtLCAmY3JjLCAmdG90YWxfYnl0ZXMpKQogICAgIHJldHVy biAtMTsKZGlmZiAtLWdpdCBhL3NyYy93Yy5jIGIvc3JjL3djLmMKaW5kZXggZWJlODNhZjRk Li4zMDIxNDY1NWMgMTAwNjQ0Ci0tLSBhL3NyYy93Yy5jCisrKyBiL3NyYy93Yy5jCkBAIC01 NCwxOCArNTQsMTIgQEAKIC8qIFNpemUgb2YgYXRvbWljIHJlYWRzLiAqLwogI2RlZmluZSBC VUZGRVJfU0laRSAoMTYgKiAxMDI0KQogCi1zdGF0aWMgYm9vbAotd2NfbGluZXMgKGNoYXIg Y29uc3QgKmZpbGUsIGludCBmZCwgdWludG1heF90ICpsaW5lc19vdXQsCi0gICAgICAgICAg dWludG1heF90ICpieXRlc19vdXQpOwogI2lmZGVmIFVTRV9BVlgyX1dDX0xJTkVDT1VOVAog LyogRnJvbSB3Y19hdngyLmMgKi8KIGV4dGVybiBib29sCiB3Y19saW5lc19hdngyIChjaGFy IGNvbnN0ICpmaWxlLCBpbnQgZmQsIHVpbnRtYXhfdCAqbGluZXNfb3V0LAogICAgICAgICAg ICAgICAgdWludG1heF90ICpieXRlc19vdXQpOwogI2VuZGlmCi1zdGF0aWMgYm9vbAotKCp3 Y19saW5lc19wKSAoY2hhciBjb25zdCAqZmlsZSwgaW50IGZkLCB1aW50bWF4X3QgKmxpbmVz X291dCwKLSAgICAgICAgICAgICAgICB1aW50bWF4X3QgKmJ5dGVzX291dCkgPSB3Y19saW5l czsKIAogc3RhdGljIGJvb2wgZGVidWc7CiAKQEAgLTQ0MSw4ICs0MzUsMTIgQEAgd2MgKGlu dCBmZCwgY2hhciBjb25zdCAqZmlsZV94LCBzdHJ1Y3QgZnN0YXR1cyAqZnN0YXR1cywgb2Zm X3QgY3VycmVudF9wb3MpCiAgIGVsc2UgaWYgKCFjb3VudF9jaGFycyAmJiAhY291bnRfY29t cGxpY2F0ZWQpCiAgICAgewogI2lmZGVmIFVTRV9BVlgyX1dDX0xJTkVDT1VOVAotICAgICAg aWYgKGF2eDJfc3VwcG9ydGVkICgpKQotICAgICAgICB3Y19saW5lc19wID0gd2NfbGluZXNf YXZ4MjsKKyAgICAgIHN0YXRpYyBib29sICgqd2NfbGluZXNfcCkgKGNoYXIgY29uc3QgKiwg aW50LCB1aW50bWF4X3QgKiwgdWludG1heF90ICopOworICAgICAgaWYgKCF3Y19saW5lc19w KQorICAgICAgICB3Y19saW5lc19wID0gYXZ4Ml9zdXBwb3J0ZWQgKCkgPyB3Y19saW5lc19h dngyIDogd2NfbGluZXM7CisjZWxzZQorICAgICAgYm9vbCAoKndjX2xpbmVzX3ApIChjaGFy IGNvbnN0ICosIGludCwgdWludG1heF90ICosIHVpbnRtYXhfdCAqKQorICAgICAgICA9IHdj X2xpbmVzOwogI2VuZGlmCiAKICAgICAgIC8qIFVzZSBhIHNlcGFyYXRlIGxvb3Agd2hlbiBj b3VudGluZyBvbmx5IGxpbmVzIG9yIGxpbmVzIGFuZCBieXRlcyAtLQotLSAKMi40MC4xCgo= --------------8KnPJjlT29LbnBN36jFdG5Li-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 14 20:22:17 2023 Received: (at 64058-done) by debbugs.gnu.org; 15 Jun 2023 00:22:18 +0000 Received: from localhost ([127.0.0.1]:45803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9akj-0006WA-HA for submit@debbugs.gnu.org; Wed, 14 Jun 2023 20:22:17 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:56437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9akg-0006Vs-UQ for 64058-done@debbugs.gnu.org; Wed, 14 Jun 2023 20:22:15 -0400 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-311099fac92so1303764f8f.0 for <64058-done@debbugs.gnu.org>; Wed, 14 Jun 2023 17:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686788529; x=1689380529; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=p/6Fng5K2XPS1CR2R/1+1t0bsVZ9CwgTtFFBSONBM6E=; b=GlA1fxw6UyJJ4Hv8+xrXKbSMyLDBw5B3WcNSI5GE1XYaxELN0kHTuYSnbUg+wSfZyZ 21p51qempxT2MPSK8xEeTqqprcaGCyJTb7f+ak4IOvUfQiDDbbRCZugmM8mTVIBkpn9k irzwDXI29n/Ar6qEtdHifPApMZGBRJriRy9Gz8CmnQ6ZW9O7p561iI8C3gN51Ib7v3yy JkGZ3iigEeBIk+rzFNtVsDghTRx12aqKcZx/63scxAvJMzG0Xja9ogz+JEPAtBiRxYEW UFOPQ3kiHNm+h5iNcinGR1HNvpZP/yYDUZMPWAnZLCIRKBm0RpW9Tx9ilJ2xkaSV1Dcs RobA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686788529; x=1689380529; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=p/6Fng5K2XPS1CR2R/1+1t0bsVZ9CwgTtFFBSONBM6E=; b=NGILgiF42wkNuc4OHcSB95F6mJziFI4U5hS5vVqrFRu55Q37gQfO2fRDHnYOwjUP3n sa96yTs0qcvhA5VI1GTyeF+GTwO00dXKe+eFJ0ICxE0GyESRpODHhKET9jQpBX9Zh0dD YAXvns0s+8IF/AA8iLVURFufpoxK4hJHPYjbDX5fw7C0x31JbgeXD2lu8hXdFsrSjSgG X/z3AgM9fudDVKoC2DLulLFjorhvWix9Omd2xKe6A9Lpe6zTtGf+PGjCSA4Zhh8RSg62 LT3WuvUjivXE0/v/P9eVupPwEc3uu3FAmMIaJOAK1suYLvSONPUi91mfwc/HqO5hQacm ICwg== X-Gm-Message-State: AC+VfDySlQ7EwGjQsY+4ZGpZW9EZTiZPwFqDIXfVki7kS+Qj1Ltis9js 7MdQY+CM92V/oXRlEJvZaQQ= X-Google-Smtp-Source: ACHHUZ4qRqDPsQEEDDTjBOlXoi9pvYVaGoI2p5gDMJP8+CcTag5c9M8KFA5f+aJNIWcYNykzfXg3xA== X-Received: by 2002:adf:ee0a:0:b0:309:38af:d300 with SMTP id y10-20020adfee0a000000b0030938afd300mr10784388wrn.33.1686788528901; Wed, 14 Jun 2023 17:22:08 -0700 (PDT) Received: from [192.168.1.19] (95-44-90-175-dynamic.agg2.lod.rsl-rtd.eircom.net. [95.44.90.175]) by smtp.googlemail.com with ESMTPSA id y3-20020a5d6203000000b003062c0ef959sm19490809wru.69.2023.06.14.17.22.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 17:22:08 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------kgB9CSbHaPKbRYhzTn9X04IE" Message-ID: Date: Thu, 15 Jun 2023 01:22:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#64058: [PATCH] wc: Fix crashes due to incomplete AVX2 enumeration Content-Language: en-US To: Paul Eggert References: <20230613172610.3429200-1-dave.hansen@linux.intel.com> <878f503d-da58-8f8a-35df-b5288a5cc282@cs.ucla.edu> From: =?UTF-8?Q?P=C3=A1draig_Brady?= In-Reply-To: X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 64058-done Cc: 64058-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) This is a multi-part message in MIME format. --------------kgB9CSbHaPKbRYhzTn9X04IE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/06/2023 23:04, Paul Eggert wrote: > On 6/14/23 03:46, Pádraig Brady wrote: > >> Paul you removed the "avx" check from cksum.c. Was that intended? > > No, it's a typo I introduced. Thanks for catching that. Fixed in the > first attached patch. > > While looking into this I noticed a couple of other cleanups, fixed in > the other attached patches. > > I installed these into coreutils on Savannah. Changes look good. I pushed the attached to explicitly document the cksum fix, and cleanup a syntax-check failure. Marking this as done. thanks, Pádraig --------------kgB9CSbHaPKbRYhzTn9X04IE Content-Type: text/x-patch; charset=UTF-8; name="cksum-sigill-news.patch" Content-Disposition: attachment; filename="cksum-sigill-news.patch" Content-Transfer-Encoding: base64 RnJvbSBkNTMxOTBlZDQ2YTU1ZjU5OTgwMGViYjJkOGRkZmUzODIwNWRiZDI0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/UD1DMz1BMWRyYWlnPTIwQnJhZHk/ PSA8UEBkcmFpZ0JyYWR5LmNvbT4KRGF0ZTogVGh1LCAxNSBKdW4gMjAyMyAwMDo1Mzo1NCAr MDEwMApTdWJqZWN0OiBbUEFUQ0hdIGRvYzogbWVudGlvbiBja3N1bSBlcnJvciBmaXggd2l0 aCBjcHUgZmVhdHVyZSBjaGVja3MgY2hhbmdlcwoKKiBORVdTOiBNZW50aW9uIHRoZSBlcnJv ciBtZXNzYWdlIHRvIGFpZCB0aG9zZSBzZWFyY2hpbmcKZm9yIHNvbHV0aW9ucyB0byB0aGUg aXNzdWUsIGFuZCBtZW50aW9uIGNrc3VtIGFsc28KYXMgdGhhdCB3YXMgY29uZmlybWVkIHRv IGZpeCB0aGUgZXJyb3Igd2l0aCB0aGUgYWRqdXN0ZWQKY3B1IGZlYXR1cmUgZGV0ZWN0aW9u LCBhcyBkaXNjdXNzZWQgYXQgaHR0cHM6Ly9idWdzLmRlYmlhbi5vcmcvMTAzNzI2NAoqIHNy Yy9ja3N1bS5jOiBDbGVhbnVwIHN5bnRheC1jaGVjayBmYWlsdXJlIGZyb20gcHJldmlvdXMg Y29tbWl0LgotLS0KIE5FV1MgICAgICAgIHwgMyArKy0KIHNyYy9ja3N1bS5jIHwgNCArKy0t CiAyIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9ORVdTIGIvTkVXUwppbmRleCAzMzUwZjk4NzEuLjUzNTg1MDU0OSAxMDA2 NDQKLS0tIGEvTkVXUworKysgYi9ORVdTCkBAIC0yOSw3ICsyOSw4IEBAIEdOVSBjb3JldXRp bHMgTkVXUyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0qLSBvdXRsaW5l IC0qLQogICAncHIgLS1sZW5ndGg9MSAtLWRvdWJsZS1zcGFjZScgbm8gbG9uZ2VyIGVudGVy cyBhbiBpbmZpbml0ZSBsb29wLgogICBbVGhpcyBidWcgd2FzIHByZXNlbnQgaW4gInRoZSBi ZWdpbm5pbmciLl0KIAotICAnd2MgLWwnIG5vIGxvbmdlciBjcmFzaGVzIG9uIHg4NiBMaW51 eCBrZXJuZWxzIHRoYXQgZGlzYWJsZSBYU0FWRSBZTU0uCisgICd3YyAtbCcgYW5kICdja3N1 bScgbm8gbG9uZ2VyIGNyYXNoIHdpdGggYW4gIklsbGVnYWwgaW5zdHJ1Y3Rpb24iIGVycm9y CisgIG9uIHg4NiBMaW51eCBrZXJuZWxzIHRoYXQgZGlzYWJsZSBYU0FWRSBZTU0uICBUaGlz IHdhcyBzZWVuIG9uIFhlbiBWTXMuCiAgIFtidWcgaW50cm9kdWNlZCBpbiBjb3JldXRpbHMt OS4wXQogCiAqKiBDaGFuZ2VzIGluIGJlaGF2aW9yCmRpZmYgLS1naXQgYS9zcmMvY2tzdW0u YyBiL3NyYy9ja3N1bS5jCmluZGV4IDI2YmIyOWJkYi4uNWI2YTU5YzE2IDEwMDY0NAotLS0g YS9zcmMvY2tzdW0uYworKysgYi9zcmMvY2tzdW0uYwpAQCAtMjI5LDkgKzIyOSw5IEBAIGNy Y19zdW1fc3RyZWFtIChGSUxFICpzdHJlYW0sIHZvaWQgKnJlc3N0cmVhbSwgdWludG1heF90 ICpsZW5ndGgpCiAgIHN0YXRpYyBib29sICgqY2tzdW1fZnApIChGSUxFICosIHVpbnRfZmFz dDMyX3QgKiwgdWludG1heF90ICopOwogICBpZiAoISBja3N1bV9mcCkKICAgICBja3N1bV9m cCA9IHBjbG11bF9zdXBwb3J0ZWQgKCkgPyBja3N1bV9wY2xtdWwgOiBja3N1bV9zbGljZTg7 Ci0jZWxzZQorIyBlbHNlCiAgIGJvb2wgKCpja3N1bV9mcCkgKEZJTEUgKiwgdWludF9mYXN0 MzJfdCAqLCB1aW50bWF4X3QgKikgPSBja3N1bV9zbGljZTg7Ci0jZW5kaWYKKyMgZW5kaWYK IAogICBpZiAoISBja3N1bV9mcCAoc3RyZWFtLCAmY3JjLCAmdG90YWxfYnl0ZXMpKQogICAg IHJldHVybiAtMTsKLS0gCjIuNDAuMQoK --------------kgB9CSbHaPKbRYhzTn9X04IE-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 16 01:56:49 2023 Received: (at 64058) by debbugs.gnu.org; 16 Jun 2023 05:56:49 +0000 Received: from localhost ([127.0.0.1]:48471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qA2S0-0006mu-O6 for submit@debbugs.gnu.org; Fri, 16 Jun 2023 01:56:49 -0400 Received: from mga12.intel.com ([192.55.52.136]:49787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9pVP-0000gV-26 for 64058@debbugs.gnu.org; Thu, 15 Jun 2023 12:07:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686845247; x=1718381247; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=jioLJLpC4v+8d07Wwp8HVlEwL+BS/58zXxnkH3fyv8k=; b=XoewY3hZEfOBu0MoGl5ZZ7QDcOETSfzZpmxmhJ71uCyeU6FsVXVh+/S3 1zsJVYpSIyBk1Zvb9NCPg1l1Ien0xjKGiaoSHfJf4EGRvxe3OcQQ6wlU6 AMjOZAHeQLHQsS3t9+YAeQEaaxKpyND5p2ybgeahIRXQgX6/sZdfJIZw+ jl8r9Y1zpRnF+utL/Nx0timp8x1IlwRG6rdqtDfxlHthwXExSD4wjDD+S gRJC43niQFks4yDlsa4Z4lkFxl98i6Xiy95Pqb9Y8ewB33sW0d5n6d/pZ mZE/cg5dDHtva6k/p9oZpKIdTd0l5OChX7hunCO4kQQKGuRMZiNxMm+Gg w==; X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="338587053" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208";a="338587053" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 09:05:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="836666144" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208";a="836666144" Received: from dmoore1-mobl1.amr.corp.intel.com (HELO [10.212.169.34]) ([10.212.169.34]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 09:05:08 -0700 Message-ID: Date: Thu, 15 Jun 2023 09:05:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: bug#64058: [PATCH] wc: Fix crashes due to incomplete AVX2 enumeration Content-Language: en-US To: Paul Eggert , Dave Hansen References: <20230613172610.3429200-1-dave.hansen@linux.intel.com> <878f503d-da58-8f8a-35df-b5288a5cc282@cs.ucla.edu> From: Dave Hansen In-Reply-To: <878f503d-da58-8f8a-35df-b5288a5cc282@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 64058 X-Mailman-Approved-At: Fri, 16 Jun 2023 01:56:47 -0400 Cc: =?UTF-8?Q?Kristoffer_Br=c3=a5nemyr?= , 64058@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) On 6/13/23 21:14, Paul Eggert wrote: > PS. Does the attached cksum.c / pclmul change fix any user-visible > misbehavior? If so, what should we put into the NEWS file? Yes, this patch also works for me. Thanks! Your news blurb from that patch looks fine to me. The only tweak I would suggest is adding some text that a user might actually see if they hit this issue, like: 'wc -l' no longer crashes with "Illegal instruction" messages on x86 Linux kernels that disable XSAVE YMM. [bug introduced in coreutils-9.0] From unknown Sat Jun 21 10:36:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 14 Jul 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 09 18:46:47 2023 Received: (at control) by debbugs.gnu.org; 9 Aug 2023 22:46:47 +0000 Received: from localhost ([127.0.0.1]:40652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTrx1-0002rT-II for submit@debbugs.gnu.org; Wed, 09 Aug 2023 18:46:47 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:60858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTrwz-0002rD-1e for control@debbugs.gnu.org; Wed, 09 Aug 2023 18:46:46 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 06DB53C011BD8 for ; Wed, 9 Aug 2023 15:46:39 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id BVxvY_b07wFZ for ; Wed, 9 Aug 2023 15:46:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id B3BC23C011BD9 for ; Wed, 9 Aug 2023 15:46:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu B3BC23C011BD9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1691621198; bh=lCU/aiw5UbmA6Rg0K5WA0EPrmX95Tp1df/XSPNnEMB4=; h=Message-ID:Date:MIME-Version:To:From; b=NcJyvNNbd0xFCBy1w8dJ9sbk8QmY/jj0M5XzqKTb1Ncvea6DsZl9U+bc2r6+b8NQx Aoo2gZrTxQiItAaaPVMhD1/5xz1UPb+kA8b2S50YEScyPul3iq55xdI9KWgijJ1sN+ sFQUBrpwTSIIHoHLuEWdY8kMezHj6GpEraXrD8gDmxzBWznPNzwJoOPZvoyteAo8e+ DmkM1iMjUYGzmLtDOgGnoZfJFaDJgYxGI0pare5CRSYOH3scWWk1gvYZsh1+N/1Wtl QDg0Ibu0ZnvknyE3ZH07Pj+vaPSLCGw8kA5b+MJUtHrm+oJIO6hxlZGppgHhuzhHb2 4rILhET7BPlWA== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id dzWun1eFKNTI for ; Wed, 9 Aug 2023 15:46:38 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 98F9F3C011BD8 for ; Wed, 9 Aug 2023 15:46:38 -0700 (PDT) Message-ID: <8542dfd4-e056-171e-3f92-bf9d271189e0@cs.ucla.edu> Date: Wed, 9 Aug 2023 15:46:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: control@debbugs.gnu.org From: Paul Eggert Subject: bugs related to 64058 Organization: UCLA Computer Science Department Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unarchive 64058 close 65164 close 65165 close 65166 close 65167 close 65168 close 65169 close 65170 merge 64058 65164 65165 65166 65167 65168 65169 65170 From unknown Sat Jun 21 10:36:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 07 Sep 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator