GNU bug report logs - #64055
31.0.50; log-view-modify-change-comment support for Git and Hg

Previous Next

Full log

Message #205 received at 64055 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Morgan.J.Smith <at> outlook.com, Eli Zaretskii <eliz <at> gnu.org>,
 64055 <at> debbugs.gnu.org
Subject: Re: bug#64055: Implementation of modifying VC change comments for Git
Date: Tue, 22 Oct 2024 16:30:30 +0800

Hello,

On Mon 21 Oct 2024 at 09:08pm +01, Dmitry Gutov wrote:

> On 20/10/2024 08:19, Sean Whitton wrote:
>> +         (nothing-staged
>> +          (zerop
>> +           (vc-git-command nil t nil "diff" "--cached" "--quiet"))))
>
> Testing it a little more, this seems insufficient because rebase aborts on
> non-staged changes too. This seems to cover both cases:
>
>          (no-changes
>           (zerop
>            (vc-git-command nil t nil "diff" "HEAD" "--quiet"))))

Thanks.  I forgot that --autostash covers that case already.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.