GNU bug report logs - #64055
31.0.50; log-view-modify-change-comment support for Git and Hg

Previous Next

Full log

Message #196 received at 64055 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Sean Whitton <spwhitton <at> spwhitton.name>, Eli Zaretskii <eliz <at> gnu.org>
Cc: Morgan.J.Smith <at> outlook.com, 64055 <at> debbugs.gnu.org
Subject: Re: bug#64055: Implementation of modifying VC change comments for Git
Date: Mon, 21 Oct 2024 21:08:37 +0100

On 20/10/2024 08:19, Sean Whitton wrote:
> +         (nothing-staged
> +          (zerop
> +           (vc-git-command nil t nil "diff" "--cached" "--quiet"))))

Testing it a little more, this seems insufficient because rebase aborts 
on non-staged changes too. This seems to cover both cases:

         (no-changes
          (zerop
           (vc-git-command nil t nil "diff" "HEAD" "--quiet"))))

Regarding the command's latency it seems to be distributed like this in 
my current example:

allowed rewrite?
Elapsed time: 0.028043s
stash push maybe
Elapsed time: 0.072001s
rebase autosquash
Elapsed time: 0.047211s
stash pop
Elapsed time: 0.032561s

So all steps are somewhat expensive, but stashing is #1 in that. Overall 
it seems fine, not a problem for the interactive command.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.