GNU bug report logs - #64052
30.0.50; Minor treesit cleanups

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64052 in the body.
You can then email your comments to 64052 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Basil Contovounesios <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Minor treesit cleanups
Date: Tue, 13 Jun 2023 19:02:26 +0100

[Message part 1 (text/plain, inline)]

Severity: minor
Tags: patch

I noticed tree-sitter query predicates are using Flength where I believe
list_length can be used directly, and the corresponding error messages
say 'only got N arguments' even when N exceeds the expected number.
Are these changes welcome/okay?

Thanks,

-- 
Basil

[0001-Minor-tree-sitter-cleanups.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw3d scroll bars) of 2023-06-13 built on blc
Repository revision: 81932ebcfa56a33fcb1c7d9f91094e2b1f6e9b77
Repository branch: blc/treesit/master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.2 LTS

Configured using:
 'configure CC=gcc-12 'CFLAGS=-Og -ggdb3' --prefix=/home/bic/.local
 --with-file-notification=yes --with-x --with-x-toolkit=lucid'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM
LUCID ZLIB

Important settings:
  value of $LC_MONETARY: en_IE.UTF-8
  value of $LC_NUMERIC: en_IE.UTF-8
  value of $LC_TIME: en_IE.UTF-8
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo x-toolkit
xinput2 x multi-tty make-network-process emacs)

Memory information:
((conses 16 36740 9186)
 (symbols 48 5178 0)
 (strings 32 13887 1303)
 (string-bytes 1 379577)
 (vectors 16 9299)
 (vector-slots 8 148629 8492)
 (floats 8 23 25)
 (intervals 56 245 0)
 (buffers 984 10))

Message #10 received at 64052-done <at> debbugs.gnu.org (full text, mbox):

From: Basil Contovounesios <contovob <at> tcd.ie>
To: 64052-done <at> debbugs.gnu.org
Cc: Yuan Fu <casouri <at> gmail.com>
Subject: Re: bug#64052: 30.0.50; Minor treesit cleanups
Date: Sat, 08 Jul 2023 17:11:20 +0100

close 64052 30.1
quit

Basil Contovounesios [2023-06-13 19:02 +0100] wrote:

> I noticed tree-sitter query predicates are using Flength where I believe
> list_length can be used directly, and the corresponding error messages
> say 'only got N arguments' even when N exceeds the expected number.

Now pushed:

Minor tree-sitter cleanups
8ffe8422c53 2023-07-08 17:05:05 +0100
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=8ffe8422c53

-- 
Basil

Message #13 received at 64052-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Basil Contovounesios <contovob <at> tcd.ie>
Cc: 64052-done <at> debbugs.gnu.org
Subject: Re: bug#64052: 30.0.50; Minor treesit cleanups
Date: Sun, 16 Jul 2023 18:36:16 -0700

> On Jul 8, 2023, at 9:11 AM, Basil Contovounesios <contovob <at> tcd.ie> wrote:
> 
> close 64052 30.1
> quit
> 
> Basil Contovounesios [2023-06-13 19:02 +0100] wrote:
> 
>> I noticed tree-sitter query predicates are using Flength where I believe
>> list_length can be used directly, and the corresponding error messages
>> say 'only got N arguments' even when N exceeds the expected number.
> 
> Now pushed:

Thanks!

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.