From unknown Wed Jun 18 00:27:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64049 <64049@debbugs.gnu.org> To: bug#64049 <64049@debbugs.gnu.org> Subject: Status: 30.0.50; Minor search_buffer cleanup Reply-To: bug#64049 <64049@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:27:59 +0000 retitle 64049 30.0.50; Minor search_buffer cleanup reassign 64049 emacs submitter 64049 Basil Contovounesios severity 64049 minor tag 64049 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 13 13:30:57 2023 Received: (at submit) by debbugs.gnu.org; 13 Jun 2023 17:30:57 +0000 Received: from localhost ([127.0.0.1]:42999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q97r6-0008IM-Tu for submit@debbugs.gnu.org; Tue, 13 Jun 2023 13:30:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:56936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q97r4-0008IC-BK for submit@debbugs.gnu.org; Tue, 13 Jun 2023 13:30:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q97r1-0004S7-IK for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2023 13:30:52 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q97qx-0007YP-RI for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2023 13:30:50 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f8d65ecdbbso4528625e9.0 for ; Tue, 13 Jun 2023 10:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1686677445; x=1689269445; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=M6e3VM/NCUIn5zKsL17kln1gQ/LWREOyM23db3iGGHk=; b=BVlxua38vwHtkbxX4cUgfjUEF5TpvdhyqbPQhTbZ4uacx0hrLswpdICHZUydj5NDWr wg08z+O5JHpoRlpnemo9NahqDKfsrWUx/MhQdm58Rqg6HBMD4qx9hgZSCITmxndGfogx nh+qeZwZlUgJzBNyL/+TZZY+E/twaQpICcF7cW7WMum4CNKOqB3UT+3cPto8AA6uretM scOsYwywY1ZxvpSTaUn0o1fJMIwsp3Dft3rwXr6TTLa1OWWlemzhc0JsabuKTo9Uw9Ff fvFF92g7D4nm9yY58GpE159F5+hwie2jBLmPuBL7eihpbBn4n4hRq+7+mQRmQcAslEhe 7SyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686677445; x=1689269445; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M6e3VM/NCUIn5zKsL17kln1gQ/LWREOyM23db3iGGHk=; b=Vy02GUERgFsss4aRAl/pvz+n48ooE7TU7X22uHZnH08yc0HFKdy3aa9t0R54IGAvqj 3J6/b+e5AsDC16gQ+GxsImDkJ1y3hnerTBkg8mLmPGx7IqmqKGKFpfcoV94bx46kGjuv v4cE4jh5EguqSLx3eYn/8MzZSO//DJ3c72VZ07Rzt7zcYzKrX2nNmyXp8LyyIpAi09or cmrkwcW5DtA4ZXdyHARnU+c6TcJriw5nJZA8aF9iPDAWXEYHyF5AfpuMt9rroFR8E66W YEMxndnv8Ijnbzsv6u6W2ipMxvtqzNO2HDiSFoPDwAw3qDLZ9aGpClhdSBH80COmYrYa ICjQ== X-Gm-Message-State: AC+VfDxx3Yy7sw4lFdily/x5sBJd0TMzKcoVM/GgDmRsg0Acf942edWD LCsQHLoxoUsr9oQehT+gpOSZ8+El9HFt8UwxZ4E= X-Google-Smtp-Source: ACHHUZ5If1SDoVqRdj50W0qdbSwYHpicWMvvh3Ftd0QN9dL/31xESB3hQqH+AECJ//nqc88qw8RM+A== X-Received: by 2002:a7b:c8d7:0:b0:3f4:2cb2:a6cf with SMTP id f23-20020a7bc8d7000000b003f42cb2a6cfmr8052254wml.10.1686677445230; Tue, 13 Jun 2023 10:30:45 -0700 (PDT) Received: from localhost ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id o6-20020a05600c378600b003f7cb42fa20sm15042815wmr.42.2023.06.13.10.30.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 10:30:44 -0700 (PDT) From: Basil Contovounesios To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Minor search_buffer cleanup Date: Tue, 13 Jun 2023 18:30:43 +0100 Message-ID: <87wn07clrw.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=contovob@tcd.ie; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Severity: minor Tags: patch I noticed what used to be commentary for search_buffer slowly drifted away from the function it was describing. I brought the two together again, updating the commentary to reflect the function's current interface. In the process I noticed the RE argument to search_buffer and search_command was always used as a boolean flag, so changed its type accordingly. WDYT? Thanks, -- Basil --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Minor-search_buffer-cleanup.patch >From 8801c3179139eac8049427fbf10971aef57ba11f Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sat, 3 Jun 2023 14:46:19 +0100 Subject: [PATCH] Minor search_buffer cleanup * src/search.c: Move commentary that used to precede search_buffer to that location once more. Update it for the current arglist. (search_command, search_buffer_non_re, search_buffer): * src/lisp.h (search_buffer): Turn RE flag/argument from an int into a bool. All callers updated. --- src/lisp.h | 2 +- src/search.c | 50 ++++++++++++++++++++++++++------------------------ src/treesit.c | 2 +- 3 files changed, 28 insertions(+), 26 deletions(-) diff --git a/src/lisp.h b/src/lisp.h index 2978de962d9..44af2ef8a2a 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -4809,7 +4809,7 @@ fast_c_string_match_ignore_case (Lisp_Object regexp, ptrdiff_t, ptrdiff_t *); extern EMACS_INT search_buffer (Lisp_Object, ptrdiff_t, ptrdiff_t, ptrdiff_t, ptrdiff_t, EMACS_INT, - int, Lisp_Object, Lisp_Object, bool); + bool, Lisp_Object, Lisp_Object, bool); extern void syms_of_search (void); extern void clear_regexp_cache (void); diff --git a/src/search.c b/src/search.c index 0bb52c03eef..a3b6fa8bb85 100644 --- a/src/search.c +++ b/src/search.c @@ -1027,7 +1027,7 @@ find_before_next_newline (ptrdiff_t from, ptrdiff_t to, static Lisp_Object search_command (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, - Lisp_Object count, int direction, int RE, bool posix) + Lisp_Object count, int direction, bool RE, bool posix) { EMACS_INT np; EMACS_INT lim; @@ -1130,21 +1130,6 @@ trivial_regexp_p (Lisp_Object regexp) return 1; } -/* Search for the n'th occurrence of STRING in the current buffer, - starting at position POS and stopping at position LIM, - treating STRING as a literal string if RE is false or as - a regular expression if RE is true. - - If N is positive, searching is forward and LIM must be greater than POS. - If N is negative, searching is backward and LIM must be less than POS. - - Returns -x if x occurrences remain to be found (x > 0), - or else the position at the beginning of the Nth occurrence - (if searching backward) or the end (if searching forward). - - POSIX is nonzero if we want full backtracking (POSIX style) - for this pattern. 0 means backtrack only enough to get a valid match. */ - #define TRANSLATE(out, trt, d) \ do \ { \ @@ -1308,7 +1293,7 @@ search_buffer_re (Lisp_Object string, ptrdiff_t pos, ptrdiff_t pos_byte, static EMACS_INT search_buffer_non_re (Lisp_Object string, ptrdiff_t pos, ptrdiff_t pos_byte, ptrdiff_t lim, ptrdiff_t lim_byte, - EMACS_INT n, int RE, Lisp_Object trt, Lisp_Object inverse_trt, + EMACS_INT n, bool RE, Lisp_Object trt, Lisp_Object inverse_trt, bool posix) { unsigned char *raw_pattern, *pat; @@ -1507,10 +1492,27 @@ search_buffer_non_re (Lisp_Object string, ptrdiff_t pos, return result; } +/* Search for the Nth occurrence of STRING in the current buffer, + from buffer position POS/POS_BYTE until LIM/LIM_BYTE, + treating STRING as a literal string if RE is false + or as a regular expression if RE is true. + + If N is positive, searching is forward and LIM must be greater than POS. + If N is negative, searching is backward and LIM must be less than POS. + + Returns -x if x occurrences remain to be found (x > 0), + or else the position at the beginning of the Nth occurrence + (if searching backward) or the end (if searching forward). + + TRT and INVERSE_TRT are translation tables. + + POSIX is true if we want full backtracking (POSIX style) for this pattern. + False means backtrack only enough to get a valid match. */ + EMACS_INT search_buffer (Lisp_Object string, ptrdiff_t pos, ptrdiff_t pos_byte, ptrdiff_t lim, ptrdiff_t lim_byte, EMACS_INT n, - int RE, Lisp_Object trt, Lisp_Object inverse_trt, bool posix) + bool RE, Lisp_Object trt, Lisp_Object inverse_trt, bool posix) { if (running_asynch_code) save_search_regs (); @@ -2219,7 +2221,7 @@ DEFUN ("search-backward", Fsearch_backward, Ssearch_backward, 1, 4, See also the functions `match-beginning', `match-end' and `replace-match'. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (string, bound, noerror, count, -1, 0, 0); + return search_command (string, bound, noerror, count, -1, false, false); } DEFUN ("search-forward", Fsearch_forward, Ssearch_forward, 1, 4, "MSearch: ", @@ -2244,7 +2246,7 @@ DEFUN ("search-forward", Fsearch_forward, Ssearch_forward, 1, 4, "MSearch: ", See also the functions `match-beginning', `match-end' and `replace-match'. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (string, bound, noerror, count, 1, 0, 0); + return search_command (string, bound, noerror, count, 1, false, false); } DEFUN ("re-search-backward", Fre_search_backward, Sre_search_backward, 1, 4, @@ -2260,7 +2262,7 @@ DEFUN ("re-search-backward", Fre_search_backward, Sre_search_backward, 1, 4, anchor `(elisp) re-search-backward' for details. */) (Lisp_Object regexp, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (regexp, bound, noerror, count, -1, 1, 0); + return search_command (regexp, bound, noerror, count, -1, true, false); } DEFUN ("re-search-forward", Fre_search_forward, Sre_search_forward, 1, 4, @@ -2291,7 +2293,7 @@ DEFUN ("re-search-forward", Fre_search_forward, Sre_search_forward, 1, 4, and `replace-match'. */) (Lisp_Object regexp, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (regexp, bound, noerror, count, 1, 1, 0); + return search_command (regexp, bound, noerror, count, 1, true, false); } DEFUN ("posix-search-backward", Fposix_search_backward, Sposix_search_backward, 1, 4, @@ -2319,7 +2321,7 @@ DEFUN ("posix-search-backward", Fposix_search_backward, Sposix_search_backward, and `replace-match'. */) (Lisp_Object regexp, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (regexp, bound, noerror, count, -1, 1, 1); + return search_command (regexp, bound, noerror, count, -1, true, true); } DEFUN ("posix-search-forward", Fposix_search_forward, Sposix_search_forward, 1, 4, @@ -2347,7 +2349,7 @@ DEFUN ("posix-search-forward", Fposix_search_forward, Sposix_search_forward, 1, and `replace-match'. */) (Lisp_Object regexp, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (regexp, bound, noerror, count, 1, 1, 1); + return search_command (regexp, bound, noerror, count, 1, true, true); } DEFUN ("replace-match", Freplace_match, Sreplace_match, 1, 5, 0, diff --git a/src/treesit.c b/src/treesit.c index 0af0e347694..e69cb872a9a 100644 --- a/src/treesit.c +++ b/src/treesit.c @@ -2582,7 +2582,7 @@ treesit_predicate_match (Lisp_Object args, struct capture_range captures, ZV_BYTE = end_byte; ptrdiff_t val = search_buffer (regexp, start_pos, start_byte, - end_pos, end_byte, 1, 1, Qnil, Qnil, false); + end_pos, end_byte, 1, true, Qnil, Qnil, false); BEGV = old_begv; BEGV_BYTE = old_begv_byte; -- 2.34.1 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2023-06-13 built on blc Repository revision: 81932ebcfa56a33fcb1c7d9f91094e2b1f6e9b77 Repository branch: blc/treesit/master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.2 LTS Configured using: 'configure CC=gcc-12 'CFLAGS=-Og -ggdb3' --prefix=/home/bic/.local --with-file-notification=yes --with-x --with-x-toolkit=lucid' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LC_MONETARY: en_IE.UTF-8 value of $LC_NUMERIC: en_IE.UTF-8 value of $LC_TIME: en_IE.UTF-8 value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 36787 10186) (symbols 48 5178 0) (strings 32 13887 2078) (string-bytes 1 379585) (vectors 16 9301) (vector-slots 8 148642 11545) (floats 8 23 25) (intervals 56 241 0) (buffers 984 10)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 13 20:25:23 2023 Received: (at 64049) by debbugs.gnu.org; 14 Jun 2023 00:25:24 +0000 Received: from localhost ([127.0.0.1]:43291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9EKB-0002k8-K0 for submit@debbugs.gnu.org; Tue, 13 Jun 2023 20:25:23 -0400 Received: from sonic314-21.consmr.mail.ne1.yahoo.com ([66.163.189.147]:45133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9EK8-0002jp-2S for 64049@debbugs.gnu.org; Tue, 13 Jun 2023 20:25:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1686702313; bh=ai8hxD3DTLw+mcCRiD1BZ8xf2kDsw2tLotIadQw0+ew=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=mDqd6DAOC7D3O9cDrkhMi0AeaTdBoBQg1nQzAoLBw46niJqBH+VXAmb4PODCSZY96p6CKjArZlHFiqoNy0oAWD6ZHwZhqRv9begYhA6FCbhvACOG76xwecA+NRLFU3lxOAPRwVKAw2+d10SLuT5tURdZiFUYUuI3vbCykpw7IXh5s3Ur0KM1bruTk3ExgYvu8aC/EWsIFgmpB/w0sITPsdCafOTOC0nNKJ841O2WIbKMQ2oOus4Ja1l79sMn9YmTMAjb20jYuR7RAbBL4gDrZiTkkcmVPqp20YZPMzD2W25j7FHhoEv7c0E/YoZidtZw8PUxMPjts0C8rUSfMdq6kA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1686702313; bh=QFm8nZy/iBobev2cn/P7fA/sypR+/XkwkYVr45Lo+jp=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=U+chQj3zNoaFZKRbO1gKQclANr/yJ91W+eeAICB3pFjsa9P1HGpAO9wPun2PVbE33PQrL0clKoB0XXP/3OSuOLkiYeiWSqz9KhJfi5D8oc5gnZGJLsDMT/qGv0kgqac7gqo8fhKrC8wjprJ90Iumh60DSQgPKx1Q3XYNYon6uUURCIkzQN4b46cnCFzlDvdfkoSnVr3KcD4s3xg2YvyMLXOIA2gSQyBgprmwg30S4qDSVZg2XoLQRYD4HzFT0vau4H9SFIBmZmmWHGOKIwtbtgBpuRU3bQvFKGvO1t4T6xnk51Q5GNrTd3kEj3MBNgYB1sWG32LQbjToN1AlpnNxHg== X-YMail-OSG: Dk.YibMVM1kdnWCwYvV3KvPfsZ4zUpiGIqW2.DLi.4uJXTW9fTu4lWXKGh5.6KW gtzjP5GyWpbUjQ_o4yDCvmIIHdTrlr6NLiWLNwVFhGyq0dv8iWrDyjpLgSQAVJwl.qacoSB8uHfG lGjAD1vCb3Dl11_lKw.8fcm20jcIlMHSyYLf2RvQkHY84poIqHZjIdmRXKhZbT11M2uN0pMNLzNA mlEDIANe6I6cfIbA.GZ4hkn9FktXUzBWKYR7mKmXpXy5wuFhlR29n.zmJ4jAy3pzriEb9wn_O8Cv ByaaoMeEWPQVZ7_qZjiX7sAdriPifLowXYeadZGXH9hKw1mYzRHXmTkoJbNZ6qOOQY_IO2rrGvft vm3C5E.xhlAQtBF2sRU.r4giQZHYJKVo7p65i_M0sJ5vVDXkGUYz5H7WlXbhFvBkPWY89M6j23US mntiYxjcxrmDaokXAmdlOC3N5p5EiZx7eT4e7faus7NIOL40KvTvsOXiXnEZIz.B6w6h_4LvWmMn XcO..rfDw3LC016wfQFdk3NkmCp2KkVzoqUjO_K_W9KAXrejF7elR0N5SDZ0_l7TcOiC9EHGn7RJ AqwEDMdRTmgMXXDqUP0T0LTS4OpVgXpxBFDw.rajIl.AREhfycydTDdifIcIhkQzjaBPckli2K8u XF32.7ACTZK4pmBdRFQqXyreI4RTysgtympP65jj0BW4xYqZmUVo.Bw4kSbYaXOs_UiG89NQ0pRv lz906DikzIXOfhv7vjQ2L6HW7doGZnBKKzKQKEfccOqxexzcCBFVBHMuG1W3xsFFmNrQFFPaTaR. cegVpOKrHqCi0mOTyN0f13IX4OHokf5epXWej9ztvuiUaHWTAFh_s0IGJdnQryoEm7HR9jOxvSXQ II1ZzNKuH4V4iuFIgYGyZ.U_0YRnn2fSTHWZ0TMsncqN0PWXQRNVYoKYw3Fh6KfZIrYbdUl2NKK4 EAdc4q5_VdEATcUbhHjNxlrFcILjEmtm7JVRHTnTRxLn3B.oZTXukXnZC7g5d9sNYyZIXX0OUsDd 2HeJOZ.9z_O_bKAFGLwgSKOMuJpj8wAhKbvHuSTqPtx0SHHVIUxDPNpH6vs5K8c_Fp_nFbpa2uqT L_hlWUbD_M1RJ5TO3LzmDhOZHCLZlTZJzBtKp3wM_Vezu1bz5CR8_HwovcWOCqoTQlXBrFEfZ1kS Zhh2k4lbZKMu9qvyUPAP7lqD5xAnC9iOoSzj_kPEpcKy9nQx2iasxRrPtOW90bP5dcJX_WiI4UAU 70Yf.tG9Nm0eWZfFoyOPnvCs2lgj_n66nPM.E7nTtK_WFyHU9na1Y0Hc1WytXCfDRm6Z0WtShIO3 zXkXGtivugSm5uPxX8j6dzwXF0vxb0UX_Yahk8eRdW1toaK4AYCkNjB.6Ehx_e4oDmcbnI3KMTQO MYE007C_k8dSaiVyvES8QoPBtObUw.8tmGJgYwYfBF_oQftNd0yG_A0E0Q19OrMqvOeAUj1enleI fvQ07XNtSgL1Ht06TOb_HQCaWISic8QlHPF9Oal0k0ZNB5lnXsRUjEbB1doBrdaPgMcgw7e2q8mt VgMim2Q_jS39LJKcKB1tn2SReukrFv9i9xW5DRcH95jzdqDSD3pEhVzm3CNQ90dc0gvAX4pGXIeT pkFNHgOGKrlbHqMwGJW.Cv2zZcy1Kt0491YOhK4RcL1RlX5pO52db8h97Es8swanfIH5JNkyCo41 4.ZpZvbMlE9.WPG1koCRGzWNJJq.GWOaXR8iNy_LqASMO61aL.BtV816QSxDp7R12RMSGcMA76Sf P24MbXVC.2UFt.uadOR4WxZrMdy.eJrZyzDTCa92THKPCBtkOskhXhbMiZNZ1jZhqrUdOB0uB5ZN JH6LEBn2J_Bsv_3ZEcSRr0H3br.zjSt5u6JpGcdCYLWbeOfTd.7Y2jCfio2Rhd.Nqi5VPLLL7k3H VpHU5mk4Ew0ButyyzYBJV_POX6KG76pmfWkj6tmOefm_onVfjdhapudPBP3xrHKUJVVbspGcVs7I XgHFpRI5BfqgrjVd6xGdPS8YsZ4DFHlUqSA4RG2D2i5sL4w2VaM.xchCHfQN8fUMAPlYkUNIqafU 2agEB0jPuBtQOLKiFouBjnBAdIfept.aNGcnlJWxNc7yKVzx.HgMb8OhitA4koOGc8zbGJaJHt7d CN1gibqKV0.ipMDBxOeuGLHUUHqg6c.yWubKrQutr7F5a3Y8nK9fmCllg8El4GHxpKRaU3CsYyup 8Z_lkvreeux5E6RZlcWS3F3I_FHc_nLwhVT_7vm_mPJLIj5Y9E_oE3wEuiOsD X-Sonic-MF: X-Sonic-ID: 455b9e8e-4ffe-4eaa-bcd2-3b0b20c3d646 Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Wed, 14 Jun 2023 00:25:13 +0000 Received: by hermes--production-sg3-748897c457-524hn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 9774f99618c262664eb72520d0baf544; Wed, 14 Jun 2023 00:25:07 +0000 (UTC) From: Po Lu To: Basil Contovounesios Subject: Re: bug#64049: 30.0.50; Minor search_buffer cleanup In-Reply-To: <87wn07clrw.fsf@epfl.ch> (Basil Contovounesios's message of "Tue, 13 Jun 2023 18:30:43 +0100") References: <87wn07clrw.fsf@epfl.ch> Date: Wed, 14 Jun 2023 08:25:02 +0800 Message-ID: <87cz1yhov5.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21516 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1709 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64049 Cc: 64049@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Basil Contovounesios writes: > * src/lisp.h (search_buffer): Turn RE flag/argument from an int into > a bool. All callers updated. We typically write ``All callers changed'' in ChangeLog, I think. > +/* Search for the Nth occurrence of STRING in the current buffer, > + from buffer position POS/POS_BYTE until LIM/LIM_BYTE, > + treating STRING as a literal string if RE is false > + or as a regular expression if RE is true. > + > + If N is positive, searching is forward and LIM must be greater than POS. > + If N is negative, searching is backward and LIM must be less than POS. > + > + Returns -x if x occurrences remain to be found (x > 0), > + or else the position at the beginning of the Nth occurrence > + (if searching backward) or the end (if searching forward). > + > + TRT and INVERSE_TRT are translation tables. > + > + POSIX is true if we want full backtracking (POSIX style) for this pattern. > + False means backtrack only enough to get a valid match. */ How about: Search for the Nth occurence of STRING in the current buffer, from buffer position POS/POS_BYTE until LIM/LIM_BYTE. If RE, look for matches against the regular expression STRING instead; if POSIX, enable POSIX style backtracking within that regular expression. If N is positive, search forward; in this case, LIM must be greater than POS. If N is negative, search backwards; LIM must be less than POS. Return -X if there are X remaining occurrences or matches, or else the position at the beginning (if N is negative) or the end (if N is positive) of the Nth occurrence or match against STRING. Use TRT and INVERSE_TRT as character translation tables. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 14 09:26:36 2023 Received: (at 64049) by debbugs.gnu.org; 14 Jun 2023 13:26:36 +0000 Received: from localhost ([127.0.0.1]:44112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9QWB-00044f-Uf for submit@debbugs.gnu.org; Wed, 14 Jun 2023 09:26:36 -0400 Received: from mail-pf1-f176.google.com ([209.85.210.176]:46105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9QW7-00044P-VH for 64049@debbugs.gnu.org; Wed, 14 Jun 2023 09:26:34 -0400 Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-666683eb028so317699b3a.0 for <64049@debbugs.gnu.org>; Wed, 14 Jun 2023 06:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1686749186; x=1689341186; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EU9C96NHFGqsbwjlocIlm3+UxrOOrkn+IMNja3fLb4U=; b=DPf99ve8GA+KMnq2+++/FpFN8weUSKler+Oc5XVdcFDDefyok8QkVtZ1DoCTtJsmsl ufLBoGkGnR7iH1dT9NKlZvxCVSPkP4p+36BG8HKe06nlAjXkU7vATL5QWOT49hhGa05Z uK25wyYK5rLlFLp+cOgKRYcP6pr/SDMoM2pJmj/VxEUNqdzhIM56R3izRNyeZx7NDFwT l2IPF/1FQr6nOBj+886VlRbTa13jNhn18adpTY+h5meOgIXym2DJ6KiMFejnVgPrEzp/ wKvmDv6Slb+ufHMfAkzpHKz9SQG9g6IIG2I8NsuZb8haF3XoLqWyJjpAnIKZmrah8V/g RYQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686749186; x=1689341186; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EU9C96NHFGqsbwjlocIlm3+UxrOOrkn+IMNja3fLb4U=; b=kOA37PALEIYB4QaGjXX3MYjw/7UYV76xZPG67nANekYGGISCDPm332ANG54Aou/3eh 2hKB0b3YcxwYqA0pxUZ2b2HTu+S8LG11/UST/LYwYBLOnFB2laFV8qTLrEYj5p6x6zNX 1oDLQBCJK+l+6PjbWB8NZyecYxsr8M5oM0t+3WTL5ZrfhoRn/4d/tvoYLfglX8BTf+wB lMAdXIBUfof5VGwRI2AaCXWJJXyBR0D0YTHFiVFApcc/PAxLktQ2yyKMLVXcMtmHzszE cwndJ+boGHYuDWikW9qRBEhCy/NlOHC7u6vVbWihpjp+2OC5OkiWgw04KEWTXPFdYW5m 8cjw== X-Gm-Message-State: AC+VfDyh/zRlZiosVc0l7MYYUARQFBZ5/aSRIZqDpvFEcTHyn0z7Ckqa a81ggt8wR/mxoNsIARWco8TLvg== X-Google-Smtp-Source: ACHHUZ4RzshElp5BpsHfBPD8d3APTm5p0JDS+b5FejfyeRK5OfMwvFYHj9mVHpxFcn+v7vK8/mXFXA== X-Received: by 2002:a05:6a00:10d2:b0:643:96e:666b with SMTP id d18-20020a056a0010d200b00643096e666bmr1460290pfu.34.1686749185873; Wed, 14 Jun 2023 06:26:25 -0700 (PDT) Received: from localhost ([64.43.152.143]) by smtp.gmail.com with ESMTPSA id n2-20020a62e502000000b006634d0fe2c6sm10333595pff.203.2023.06.14.06.26.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 06:26:25 -0700 (PDT) From: Basil Contovounesios To: Po Lu Subject: Re: bug#64049: 30.0.50; Minor search_buffer cleanup In-Reply-To: <87cz1yhov5.fsf@yahoo.com> (Po Lu's message of "Wed, 14 Jun 2023 08:25:02 +0800") References: <87wn07clrw.fsf@epfl.ch> <87cz1yhov5.fsf@yahoo.com> Date: Wed, 14 Jun 2023 14:26:22 +0100 Message-ID: <87a5x29nup.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64049 Cc: 64049@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Po Lu [2023-06-14 08:25 +0800] wrote: > We typically write ``All callers changed'' in ChangeLog, I think. [...] > How about: Thanks, done: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Minor-search_buffer-cleanup.patch >From 2cf5bbafef58aa7d8c5ea6d1b43a349d9dabe273 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sat, 3 Jun 2023 14:46:19 +0100 Subject: [PATCH] Minor search_buffer cleanup * src/search.c: Move commentary that used to precede search_buffer to that location once more. Update it for the current arglist. (search_command, search_buffer_non_re, search_buffer): * src/lisp.h (search_buffer): Turn RE flag/argument from an int into a bool. All callers changed (bug#64049). --- src/lisp.h | 2 +- src/search.c | 51 +++++++++++++++++++++++++++------------------------ src/treesit.c | 2 +- 3 files changed, 29 insertions(+), 26 deletions(-) diff --git a/src/lisp.h b/src/lisp.h index 2978de962d9..44af2ef8a2a 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -4809,7 +4809,7 @@ fast_c_string_match_ignore_case (Lisp_Object regexp, ptrdiff_t, ptrdiff_t *); extern EMACS_INT search_buffer (Lisp_Object, ptrdiff_t, ptrdiff_t, ptrdiff_t, ptrdiff_t, EMACS_INT, - int, Lisp_Object, Lisp_Object, bool); + bool, Lisp_Object, Lisp_Object, bool); extern void syms_of_search (void); extern void clear_regexp_cache (void); diff --git a/src/search.c b/src/search.c index 0bb52c03eef..122d6166637 100644 --- a/src/search.c +++ b/src/search.c @@ -1027,7 +1027,7 @@ find_before_next_newline (ptrdiff_t from, ptrdiff_t to, static Lisp_Object search_command (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, - Lisp_Object count, int direction, int RE, bool posix) + Lisp_Object count, int direction, bool RE, bool posix) { EMACS_INT np; EMACS_INT lim; @@ -1130,21 +1130,6 @@ trivial_regexp_p (Lisp_Object regexp) return 1; } -/* Search for the n'th occurrence of STRING in the current buffer, - starting at position POS and stopping at position LIM, - treating STRING as a literal string if RE is false or as - a regular expression if RE is true. - - If N is positive, searching is forward and LIM must be greater than POS. - If N is negative, searching is backward and LIM must be less than POS. - - Returns -x if x occurrences remain to be found (x > 0), - or else the position at the beginning of the Nth occurrence - (if searching backward) or the end (if searching forward). - - POSIX is nonzero if we want full backtracking (POSIX style) - for this pattern. 0 means backtrack only enough to get a valid match. */ - #define TRANSLATE(out, trt, d) \ do \ { \ @@ -1308,7 +1293,7 @@ search_buffer_re (Lisp_Object string, ptrdiff_t pos, ptrdiff_t pos_byte, static EMACS_INT search_buffer_non_re (Lisp_Object string, ptrdiff_t pos, ptrdiff_t pos_byte, ptrdiff_t lim, ptrdiff_t lim_byte, - EMACS_INT n, int RE, Lisp_Object trt, Lisp_Object inverse_trt, + EMACS_INT n, bool RE, Lisp_Object trt, Lisp_Object inverse_trt, bool posix) { unsigned char *raw_pattern, *pat; @@ -1507,10 +1492,28 @@ search_buffer_non_re (Lisp_Object string, ptrdiff_t pos, return result; } +/* Search for the Nth occurrence of STRING in the current buffer, + from buffer position POS/POS_BYTE until LIM/LIM_BYTE. + + If RE, look for matches against the regular expression STRING instead; + if POSIX, enable POSIX style backtracking within that regular + expression. + + If N is positive, search forward; in this case, LIM must be greater + than POS. + + If N is negative, search backward; LIM must be less than POS. + + Return -X if there are X remaining occurrences or matches, + or else the position at the beginning (if N is negative) or the end + (if N is positive) of the Nth occurrence or match against STRING. + + Use TRT and INVERSE_TRT as character translation tables. */ + EMACS_INT search_buffer (Lisp_Object string, ptrdiff_t pos, ptrdiff_t pos_byte, ptrdiff_t lim, ptrdiff_t lim_byte, EMACS_INT n, - int RE, Lisp_Object trt, Lisp_Object inverse_trt, bool posix) + bool RE, Lisp_Object trt, Lisp_Object inverse_trt, bool posix) { if (running_asynch_code) save_search_regs (); @@ -2219,7 +2222,7 @@ DEFUN ("search-backward", Fsearch_backward, Ssearch_backward, 1, 4, See also the functions `match-beginning', `match-end' and `replace-match'. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (string, bound, noerror, count, -1, 0, 0); + return search_command (string, bound, noerror, count, -1, false, false); } DEFUN ("search-forward", Fsearch_forward, Ssearch_forward, 1, 4, "MSearch: ", @@ -2244,7 +2247,7 @@ DEFUN ("search-forward", Fsearch_forward, Ssearch_forward, 1, 4, "MSearch: ", See also the functions `match-beginning', `match-end' and `replace-match'. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (string, bound, noerror, count, 1, 0, 0); + return search_command (string, bound, noerror, count, 1, false, false); } DEFUN ("re-search-backward", Fre_search_backward, Sre_search_backward, 1, 4, @@ -2260,7 +2263,7 @@ DEFUN ("re-search-backward", Fre_search_backward, Sre_search_backward, 1, 4, anchor `(elisp) re-search-backward' for details. */) (Lisp_Object regexp, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (regexp, bound, noerror, count, -1, 1, 0); + return search_command (regexp, bound, noerror, count, -1, true, false); } DEFUN ("re-search-forward", Fre_search_forward, Sre_search_forward, 1, 4, @@ -2291,7 +2294,7 @@ DEFUN ("re-search-forward", Fre_search_forward, Sre_search_forward, 1, 4, and `replace-match'. */) (Lisp_Object regexp, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (regexp, bound, noerror, count, 1, 1, 0); + return search_command (regexp, bound, noerror, count, 1, true, false); } DEFUN ("posix-search-backward", Fposix_search_backward, Sposix_search_backward, 1, 4, @@ -2319,7 +2322,7 @@ DEFUN ("posix-search-backward", Fposix_search_backward, Sposix_search_backward, and `replace-match'. */) (Lisp_Object regexp, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (regexp, bound, noerror, count, -1, 1, 1); + return search_command (regexp, bound, noerror, count, -1, true, true); } DEFUN ("posix-search-forward", Fposix_search_forward, Sposix_search_forward, 1, 4, @@ -2347,7 +2350,7 @@ DEFUN ("posix-search-forward", Fposix_search_forward, Sposix_search_forward, 1, and `replace-match'. */) (Lisp_Object regexp, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (regexp, bound, noerror, count, 1, 1, 1); + return search_command (regexp, bound, noerror, count, 1, true, true); } DEFUN ("replace-match", Freplace_match, Sreplace_match, 1, 5, 0, diff --git a/src/treesit.c b/src/treesit.c index 0af0e347694..e69cb872a9a 100644 --- a/src/treesit.c +++ b/src/treesit.c @@ -2582,7 +2582,7 @@ treesit_predicate_match (Lisp_Object args, struct capture_range captures, ZV_BYTE = end_byte; ptrdiff_t val = search_buffer (regexp, start_pos, start_byte, - end_pos, end_byte, 1, 1, Qnil, Qnil, false); + end_pos, end_byte, 1, true, Qnil, Qnil, false); BEGV = old_begv; BEGV_BYTE = old_begv_byte; -- 2.34.1 --=-=-= Content-Type: text/plain -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 08 11:46:41 2023 Received: (at control) by debbugs.gnu.org; 8 Jul 2023 15:46:42 +0000 Received: from localhost ([127.0.0.1]:45055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIA8v-0007A6-MJ for submit@debbugs.gnu.org; Sat, 08 Jul 2023 11:46:41 -0400 Received: from mail-lf1-f49.google.com ([209.85.167.49]:57728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIA8s-00079i-Jt for control@debbugs.gnu.org; Sat, 08 Jul 2023 11:46:40 -0400 Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-4fa16c6a85cso4503073e87.3 for ; Sat, 08 Jul 2023 08:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1688831192; x=1691423192; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NKTWr05UEhBxJAFywEIbDCJ/ORbW6M7JXqi/IgS/nLM=; b=YOOMjLFBBGRDUW4jGWgtAjAeTLf3yihSLe3ayoAYBk1QdSeFFA4YF5/YN8FNdfR0tf 2A9JnuRRzRXEXoD6P0IJ4wH4hTtkZNLm0h+8ZvMfsiEd7Dliu2CSEBBj0OwTosy0DCJx M0T7ZApum/lZ3Pj9lIxbY1h4bxdXiXUIuPWuLfaoOvdSEjZ7cjm1h/dYr0iJ12iZceP/ yon6492Xa/hOvqZnEDUY4qVUjjP2/wjFHQOBpCT0jObWaUOLlQly+cWOFR4XG4IjcRJM 5G+iHUl6jgzNJp5N4fGzEfOGfynnGuIXwkbtrvWNsa667gJ9j7Xq02RORh/dzBG3xEPA /ZJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688831192; x=1691423192; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NKTWr05UEhBxJAFywEIbDCJ/ORbW6M7JXqi/IgS/nLM=; b=bnm95o1j3InNUHoaEzXtj/VzDTJUFlX3YN2ZpWO1mTQVFUbuqiQhyCDkTDyEHR3C6b TtgmeTZzjGL92uX8lqlsswukZRtmpDXUPkOEsQkyhS2L5UaLSz8z4rVfFyDyE0dkaC42 PPt11yCx4sFKJKVivDOuWR9vIjSV8U1qJLFoc7jdAb6cKTVJzvYLXQD47SdtWh6VPR5T UAU1OIEE90t5QF3k0QxjZnbWlK53YQNOXJT+uZuH2ya45DOsEPL/NaXHS585yrClJwy4 X6ZO82afToa4yeBjg7TYKvONldqJijfOzsSifbFeHmFTbLsgs+JzK/Wb6MVoIFh8wj4V STXg== X-Gm-Message-State: ABy/qLbKieeQFmc4gZSGbhcz2ibP8lAldKTblwBWXSIiNHp/pTJrCDZT oWh9ADXue8siDR2RCEc0eBKiOg== X-Google-Smtp-Source: APBJJlGbBdZE8oZfMlGsL1FUjK+o2fZBdOYEzHC9YfxHh6SvfU+0fRgCkryHzTRrCFB6xarNq53YsA== X-Received: by 2002:a05:6512:1108:b0:4f4:dbcc:54da with SMTP id l8-20020a056512110800b004f4dbcc54damr7049138lfg.27.1688831192342; Sat, 08 Jul 2023 08:46:32 -0700 (PDT) Received: from localhost (vpn-253-209.epfl.ch. [128.179.253.209]) by smtp.gmail.com with ESMTPSA id s15-20020aa7cb0f000000b0051e3cda6d49sm2092286edt.90.2023.07.08.08.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jul 2023 08:46:31 -0700 (PDT) From: Basil Contovounesios To: Po Lu Subject: Re: bug#64049: 30.0.50; Minor search_buffer cleanup In-Reply-To: <87a5x29nup.fsf@epfl.ch> (Basil Contovounesios's message of "Wed, 14 Jun 2023 14:26:22 +0100") References: <87wn07clrw.fsf@epfl.ch> <87cz1yhov5.fsf@yahoo.com> <87a5x29nup.fsf@epfl.ch> Date: Sat, 08 Jul 2023 16:46:30 +0100 Message-ID: <87351yqucp.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: 64049-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 64049 30.1 quit Basil Contovounesios [2023-06-14 14:26 +0100] wrote: > Po Lu [2023-06-14 08:25 +0800] wrote: >> We typically write ``All callers changed'' in ChangeLog, I think. > [...] >> How about: > Thanks, done: No further comments, so pushed and closing. Minor search_buffer cleanup ac57358762b 2023-07-08 16:35:09 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=ac57358762b Thanks, -- Basil From unknown Wed Jun 18 00:27:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 06 Aug 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator