From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 14:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 64048@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16866665983327 (code B ref -1); Tue, 13 Jun 2023 14:30:03 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jun 2023 14:29:58 +0000 Received: from localhost ([127.0.0.1]:42648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q951x-0000rb-Ka for submit@debbugs.gnu.org; Tue, 13 Jun 2023 10:29:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:56302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q951v-0000rT-RG for submit@debbugs.gnu.org; Tue, 13 Jun 2023 10:29:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q951v-0006sn-Ih for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2023 10:29:55 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q951t-0000oi-U9 for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2023 10:29:55 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D72EE24002A for ; Tue, 13 Jun 2023 16:29:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686666591; bh=Pt8KMid8wot+j8qr63dRKeOL7ysePa8BvzuzMYYphm4=; h=From:To:Subject:Date:Message-ID:MIME-Version:From; b=KPwerjJthObzWIoWvU7ke3Lk6zzqnTeFTAreAZsXE5F5wY7TO0lfvxigvAa/Z9KE9 2f5w4eNeQtUMnYQ+wbd3Zlze9slkXM3ufyu0pm9FEibXgQPZeEQJFk6I/eYdO3vfqP df2xXp0Kho9zDHzWXwEVqUTJ4C1rVak6He6iG02vqHHNo3al4VGuqjnMmI2UyAwjWX 3bYvpIMVglAFUn8Oy+2XyL6x42T0krGYwsBssjqUYI7u51UIUyqUV7A0ihUXd0dn2G 0j765ImwdRCiSviZVpPJlLmdrW26YjJsnluUxnFk0f1xuSpCGAfMN7YzbfGFkz7SyN 8DyNNJFU54vmg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QgWBj2VhSz9rxK for ; Tue, 13 Jun 2023 16:28:45 +0200 (CEST) From: Ihor Radchenko Date: Tue, 13 Jun 2023 14:33:39 +0000 Message-ID: <87a5x3sa7w.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, global-display-line-numbers-mode is defined as (define-globalized-minor-mode global-display-line-numbers-mode display-line-numbers-mode display-line-numbers--turn-on) Which unconditionally enables it when `display-line-numbers--turn-on' returns t. Wouldn't it be nicer to have something like (define-globalized-minor-mode global-display-line-numbers-mode display-line-numbers-mode display-line-numbers--turn-on :predicate #'display-line-numbers--turn-on) that will also define `display-line-numbers-modes' variable that controls where the global mode is enabled/disabled? Maybe it should even be the default in `define-globalized-minor-mode' when :predicate is not defined. WDYT? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ihor Radchenko Cc: 64048@debbugs.gnu.org Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168667143911758 (code B ref 64048); Tue, 13 Jun 2023 15:51:02 +0000 Received: (at 64048) by debbugs.gnu.org; 13 Jun 2023 15:50:39 +0000 Received: from localhost ([127.0.0.1]:42808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q96I2-00033Z-Lu for submit@debbugs.gnu.org; Tue, 13 Jun 2023 11:50:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q96Hz-00033J-C8 for 64048@debbugs.gnu.org; Tue, 13 Jun 2023 11:50:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q96Ht-00025K-I6; Tue, 13 Jun 2023 11:50:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UTGKCJrYSkxeUJ6vSQM+8OaSsMVTEBxY6nYtw8hRIDs=; b=q1nuwv0Q00sw YQPEMCmB5x1hxx8cE2+UJwYIG0JVQpOWcyJieC8OG/49FvNR2YXcNY9OmgDnsCaCjx8VQ//yG9bdR YfVOb+xCnkgo3fjhFbua21muDlWngdWCXDR7mOJOqkxqs3KlTkk4fpS0PJhEpGkIkAd7mgZGVQJvl 5QqGqXozDaD7laT94185EYF1K9lFWU1jEMtkGa3an+l32LL9tzZi04qrLlS+DEk9JZWzncYBuJ8N7 ZTliW9aqCAtTLwTTKJ0Vg081gwa27gICToh00V2HFHjFk+UOj2h2yxfiKSmtsBDCJf+IIUCXe96mI eO++jEKidA+wLsDj0XHsHA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q96Ht-0007Ld-26; Tue, 13 Jun 2023 11:50:29 -0400 Date: Tue, 13 Jun 2023 18:50:47 +0300 Message-Id: <83bkhjweco.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87a5x3sa7w.fsf@localhost> (message from Ihor Radchenko on Tue, 13 Jun 2023 14:33:39 +0000) References: <87a5x3sa7w.fsf@localhost> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ihor Radchenko > Date: Tue, 13 Jun 2023 14:33:39 +0000 > > global-display-line-numbers-mode is defined as > > (define-globalized-minor-mode global-display-line-numbers-mode > display-line-numbers-mode display-line-numbers--turn-on) > > Which unconditionally enables it when `display-line-numbers--turn-on' > returns t. > > Wouldn't it be nicer to have something like > > (define-globalized-minor-mode global-display-line-numbers-mode > display-line-numbers-mode display-line-numbers--turn-on > :predicate #'display-line-numbers--turn-on) > > that will also define `display-line-numbers-modes' variable that > controls where the global mode is enabled/disabled? > > Maybe it should even be the default in `define-globalized-minor-mode' > when :predicate is not defined. > > WDYT? I think it's too late for such changes, because it will definitely break someone's setup. From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 64048@debbugs.gnu.org Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168667228913184 (code B ref 64048); Tue, 13 Jun 2023 16:05:02 +0000 Received: (at 64048) by debbugs.gnu.org; 13 Jun 2023 16:04:49 +0000 Received: from localhost ([127.0.0.1]:42836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q96Vk-0003Qa-Mg for submit@debbugs.gnu.org; Tue, 13 Jun 2023 12:04:48 -0400 Received: from mout01.posteo.de ([185.67.36.65]:59655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q96Vi-0003QK-JZ for 64048@debbugs.gnu.org; Tue, 13 Jun 2023 12:04:47 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9E3F6240028 for <64048@debbugs.gnu.org>; Tue, 13 Jun 2023 18:04:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686672280; bh=DtyefXGAPlpkRXkHwetUaLXrP6W4ntGIJwW9kdkWkQ0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=MiIR8o+V2v1/L3ZUAtKbuIa3OJIrdS5+OJ5/kirYH861W5WNUu0IdoYsWtxwKSt89 gUnu15vZxt87tf91QeqKU6ZBk9ea5YNW6PO+a3ikeuMzeB8vlGGXX/QRG0Rdysv2n/ zPCqfOg/x8HnTWoUA+gg4xpIkXp87SCvV2pCRWy6WCX6Xp727V7PNUuHHiofB+UVLW BHCbrlrPkxRtBEJfSYUPgxAwV1vYdgQXFdjUu0aW6iWmVrb5DXAsrpBeGIQUgtvbJO 6naoY5SOwCil2ChtyTLgs+7+F5Rjksqs7wrAdBOpOE0opo2/njqi0cBOCOFD7oVAl9 SxsMDJVFsvCRQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QgYKN0nC3z9rxB; Tue, 13 Jun 2023 18:04:39 +0200 (CEST) From: Ihor Radchenko In-Reply-To: <83bkhjweco.fsf@gnu.org> References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> Date: Tue, 13 Jun 2023 16:09:30 +0000 Message-ID: <875y7rs5s5.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> that will also define `display-line-numbers-modes' variable that >> controls where the global mode is enabled/disabled? >> >> Maybe it should even be the default in `define-globalized-minor-mode' >> when :predicate is not defined. > > I think it's too late for such changes, because it will definitely > break someone's setup. May you please elaborate? IMHO, the only way honouring `global-foo-modes' variable will break someone's setup is when somebody sets `global-foo-modes' (which has no effect now) and expects that there will be no effect in future as well. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 16:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ihor Radchenko Cc: 64048@debbugs.gnu.org Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168667498027613 (code B ref 64048); Tue, 13 Jun 2023 16:50:01 +0000 Received: (at 64048) by debbugs.gnu.org; 13 Jun 2023 16:49:40 +0000 Received: from localhost ([127.0.0.1]:42921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q97D9-0007BI-V9 for submit@debbugs.gnu.org; Tue, 13 Jun 2023 12:49:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q97D7-0007B4-3E for 64048@debbugs.gnu.org; Tue, 13 Jun 2023 12:49:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q97D1-0005is-F1; Tue, 13 Jun 2023 12:49:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7QeDLICaRars/pKfG/CSABAu9ZkQq810td3jEAemV/M=; b=O5sq7wfYpyB6 Q27Q1T0wBVkYvj2Wkk+n7qW8m5mbkZl1d4L2kYp9YuP84kiaLXUoVHH3xLZemqkHepTjj8TeBs75D zIWDAM5Soh31RbavghlZi8PLz/MErTEy7PgHqrTrG7iEDz4LXRWDsGVsuzovMKDk5D3z7VnERqksR Z4U0mdoaTMNvEkaFdc8W2Va2yLeuGCSHuHN+cL+UZ5EAICN2+u6Oz03tAwAa3GozI39eGbCKmjypp McMGWUO7xtuwaGJCByEo8X5C72Z9ogUMa3QMdoEosQ9EplwWKIFqKK1Xima8tBBqGlkR01Jt1g5tU K+0xfi2Qxmu8VG0lfNo8Jg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q97D0-000674-WC; Tue, 13 Jun 2023 12:49:31 -0400 Date: Tue, 13 Jun 2023 19:49:48 +0300 Message-Id: <835y7rwbmb.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <875y7rs5s5.fsf@localhost> (message from Ihor Radchenko on Tue, 13 Jun 2023 16:09:30 +0000) References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ihor Radchenko > Cc: 64048@debbugs.gnu.org > Date: Tue, 13 Jun 2023 16:09:30 +0000 > > Eli Zaretskii writes: > > >> that will also define `display-line-numbers-modes' variable that > >> controls where the global mode is enabled/disabled? > >> > >> Maybe it should even be the default in `define-globalized-minor-mode' > >> when :predicate is not defined. > > > > I think it's too late for such changes, because it will definitely > > break someone's setup. > > May you please elaborate? > > IMHO, the only way honouring `global-foo-modes' variable will break > someone's setup is when somebody sets `global-foo-modes' (which has no > effect now) and expects that there will be no effect in future as well. I have enough gray hair to know that any such changes break something. This mode has been with us since Emacs 26, so we cannot make such changes after so much time. Especially since the problem, if there is a problem, is minor at best. Sorry. From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 17:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 64048@debbugs.gnu.org Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168667661230370 (code B ref 64048); Tue, 13 Jun 2023 17:17:02 +0000 Received: (at 64048) by debbugs.gnu.org; 13 Jun 2023 17:16:52 +0000 Received: from localhost ([127.0.0.1]:42975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q97dT-0007tl-Ux for submit@debbugs.gnu.org; Tue, 13 Jun 2023 13:16:52 -0400 Received: from mout01.posteo.de ([185.67.36.65]:53599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q97dP-0007tP-6S for 64048@debbugs.gnu.org; Tue, 13 Jun 2023 13:16:50 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 05A1F24002B for <64048@debbugs.gnu.org>; Tue, 13 Jun 2023 19:16:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686676601; bh=QuCxtkfR9TDVwQEfr45IxXiH039fs+lbcttQZvSPiUA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=K2NjR4ZJox39kqetrFPvOI0OjRRSq4mFkW4eKOhqT1OCKOoHRj9YEfB5dIyLt3qcC y7I2WbE7RfSGb2kSycBO48KnqbbcrUT2ZKcRBo8LwwD9NaMc6hKfB6PsaXwCkSo/xo 0B7eOU5SwlN0IzPJleLKs0ECAlpD8RB6jhjzQJlHnue1dObrr5Lu9C1Loik/RYjqsh wKctaI2osHegaCISErNhQYiDu6xriesLSRG2pPuPDJmoga0RkxtcBUudzsC35Xw1xs pPSh1UBY6njg2t37dGrtQJYp5jAJCKcXSTGDRgwFN14eYFTaMULXViEDEnJcQ9XADw 8dFQtDI0s09Ow== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QgZwS20k9z6txf; Tue, 13 Jun 2023 19:16:40 +0200 (CEST) From: Ihor Radchenko In-Reply-To: <835y7rwbmb.fsf@gnu.org> References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> <835y7rwbmb.fsf@gnu.org> Date: Tue, 13 Jun 2023 17:21:30 +0000 Message-ID: <87352vs2g5.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> May you please elaborate? >> >> IMHO, the only way honouring `global-foo-modes' variable will break >> someone's setup is when somebody sets `global-foo-modes' (which has no >> effect now) and expects that there will be no effect in future as well. > > I have enough gray hair to know that any such changes break something. > > This mode has been with us since Emacs 26, so we cannot make such > changes after so much time. May I rephrase is as a feature request then? Like, please add `global-*-modes' customization for modes defined via `define-globalized-minor-mode'? Or, at least, add `global-display-line-numbers-modes' customization? I see not how adding a new feature can break anything here. If a normal minor mode is made into global, it is a given that it can be activated independently in arbitrary number of buffers. So, extra predicate (in addition to the mode's own) should not create any problem. > ... Especially since the problem, if there is > a problem, is minor at best. I recall multiple occasions when I tried hard to disable a global mode in some buffers, remembered that there is some special variable for it; just to find out that a specific global minor mode does not support it. And then we have non-standard variables like `dabbrev-ignored-buffer-modes', `hi-lock-exclude-modes', `which-func-modes' - all with different conventions. I can also tell you that a question about disabling global minor modes in some buffers re-surfaces regularly in reddit discussions and IRC. We even have FAQ entries like https://www.emacswiki.org/emacs/LineNumbers#h5o-10 And the suggested solution is re-defunning "turn-on" function - do we really want to say that it is the way to go? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 18:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ihor Radchenko Cc: 64048@debbugs.gnu.org Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.16866803315390 (code B ref 64048); Tue, 13 Jun 2023 18:19:02 +0000 Received: (at 64048) by debbugs.gnu.org; 13 Jun 2023 18:18:51 +0000 Received: from localhost ([127.0.0.1]:43046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q98bT-0001Os-Aj for submit@debbugs.gnu.org; Tue, 13 Jun 2023 14:18:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q98bQ-0001Oc-JO for 64048@debbugs.gnu.org; Tue, 13 Jun 2023 14:18:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q98bK-0007hf-EO; Tue, 13 Jun 2023 14:18:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=25MbE4fRhMHop/cdERJNH0rHj/q8eRuIuwfHpbV9gaY=; b=QY0CHjKKqqW/ nyN0V5t03qm3kejSOUQpTeFVvkeGvPeTAWluHDp9IbyFndnWZlpOdazpLRIMVGBmwgXuUikwmflz6 pFdtUVXo/IeYA62K/mdzrieE9wMo3xcPHWBF5ET4bgk1rhnGePTfOTtTzqsydYHTwRPkrGBpMJTGd GypFv3mT3DWSC6p9HDQbZL5LOcNhjqsEJID+jZ7+marZ4QEPGTQPW57RtDpAENj0SejPhSvrxPPJQ mTYDeVmukGz09lbhaWCYVzMiy7OUnUNsz1TCL0Tg3vmzJ/jlUv0+Oj1trmnd4bOG9j2kziNxm+bkQ fp8CWk1grl6rS0HopJ5Hww==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q98bJ-0003w9-LE; Tue, 13 Jun 2023 14:18:42 -0400 Date: Tue, 13 Jun 2023 21:19:00 +0300 Message-Id: <83wn07usx7.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87352vs2g5.fsf@localhost> (message from Ihor Radchenko on Tue, 13 Jun 2023 17:21:30 +0000) References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> <835y7rwbmb.fsf@gnu.org> <87352vs2g5.fsf@localhost> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ihor Radchenko > Cc: 64048@debbugs.gnu.org > Date: Tue, 13 Jun 2023 17:21:30 +0000 > > May I rephrase is as a feature request then? > Like, please add `global-*-modes' customization for modes defined via `define-globalized-minor-mode'? > Or, at least, add `global-display-line-numbers-modes' customization? I'm not against such a feature, not at all. My objection was only to the particular implementation that you suggested: we cannot suddenly add a :predicate to a global mode where previously there wasn't one. People who activate this global mode expect it to be active everywhere, no questions asked. > I recall multiple occasions when I tried hard to disable a global mode > in some buffers, remembered that there is some special variable for it; > just to find out that a specific global minor mode does not support it. The usual way of enabling a mode selectively is to enable the non-global variant of the mode in a mode hook. I'm sure you know it. > And then we have non-standard variables like > `dabbrev-ignored-buffer-modes', `hi-lock-exclude-modes', > `which-func-modes' - all with different conventions. > > I can also tell you that a question about disabling global minor modes > in some buffers re-surfaces regularly in reddit discussions and IRC. > > We even have FAQ entries like https://www.emacswiki.org/emacs/LineNumbers#h5o-10 > And the suggested solution is re-defunning "turn-on" function - do we > really want to say that it is the way to go? You are preaching to the choir, really. There's nothing wrong with using :predicate when introducing a new globalized minor mode. I only objected to doing that in a mode that exists for such a long time without any conditions. (Btw, I don't think I understand the use of :predicate which you proposed: it isn't documented as accepting a function, only nil, t, or a list of modes.) From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 19:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 64048@debbugs.gnu.org Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168668469412773 (code B ref 64048); Tue, 13 Jun 2023 19:32:02 +0000 Received: (at 64048) by debbugs.gnu.org; 13 Jun 2023 19:31:34 +0000 Received: from localhost ([127.0.0.1]:43085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q99jp-0003Jw-Nc for submit@debbugs.gnu.org; Tue, 13 Jun 2023 15:31:34 -0400 Received: from mout01.posteo.de ([185.67.36.65]:46613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q99jm-0003Je-RV for 64048@debbugs.gnu.org; Tue, 13 Jun 2023 15:31:32 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5A4A924002E for <64048@debbugs.gnu.org>; Tue, 13 Jun 2023 21:31:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686684684; bh=ZvTsJO8fkt7crSxKNZx92aO7qqgY0me55LNyZooslGU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=kaHW4ZwGCsChvy+wxVQpD+pam9tEMD/rb97pnopSQ7J/KD+GCeGYedFBRZGm5JncC LpiYXutpPatyuce9tsTa6wPfzZPYFazTiICfDdGpMxWJR3R7nx4vggwJWopoNdt692 bp44TnEPWFlAlxuWE7Ynd3RGTqDvqvsqgTcUrUm0YGKH9A+JvWLCG4lcEcoaDY70Bs 4GI1p1NVD/Z6PQts7q9BczCCZXX/1y5hHC8WmA4kU/Cg6/BUGHa/JC+CULGYhq6Hqg ElmYTxkksVuxwYBuBxlAIa/ouA/A8fTF/1oWraOs4rUo62MqYMkTsqmPUaKTZQONSk FGTSYMatBX1Dw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qgdvv2W3Sz6tvk; Tue, 13 Jun 2023 21:31:23 +0200 (CEST) From: Ihor Radchenko In-Reply-To: <83wn07usx7.fsf@gnu.org> References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> <835y7rwbmb.fsf@gnu.org> <87352vs2g5.fsf@localhost> <83wn07usx7.fsf@gnu.org> Date: Tue, 13 Jun 2023 19:36:14 +0000 Message-ID: <87sfavqhn5.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> May I rephrase is as a feature request then? >> Like, please add `global-*-modes' customization for modes defined via `define-globalized-minor-mode'? >> Or, at least, add `global-display-line-numbers-modes' customization? > > I'm not against such a feature, not at all. My objection was only to > the particular implementation that you suggested: we cannot suddenly > add a :predicate to a global mode where previously there wasn't one. > People who activate this global mode expect it to be active > everywhere, no questions asked. > (Btw, I don't think I understand the use of :predicate which you > proposed: it isn't documented as accepting a function, only nil, t, or > a list of modes.) Hmm. You are right, I did not look far enough into the code. Let me correct my initial suggestion: (define-globalized-minor-mode global-display-line-numbers-mode display-line-numbers-mode display-line-numbers--turn-on :predicate t) :predicate defines the default value of `global-display-line-numbers-modes' variable. The above code will not change the existing behaviour, except that `global-display-line-numbers-modes' will be accounted for, iff customized by the user. >> I recall multiple occasions when I tried hard to disable a global mode >> in some buffers, remembered that there is some special variable for it; >> just to find out that a specific global minor mode does not support it. > > The usual way of enabling a mode selectively is to enable the > non-global variant of the mode in a mode hook. I'm sure you know it. The use case I am talking about is enabling minor mode everywhere, except certain major modes. It is more tricky. One can, of course, disable the minor mode selectively in some major modes from that major mode hooks, but it is surprisingly non-obvious approach. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jun 2023 11:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ihor Radchenko , Stefan Monnier Cc: 64048@debbugs.gnu.org Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.16867439176675 (code B ref 64048); Wed, 14 Jun 2023 11:59:01 +0000 Received: (at 64048) by debbugs.gnu.org; 14 Jun 2023 11:58:37 +0000 Received: from localhost ([127.0.0.1]:43905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9P92-0001ja-ER for submit@debbugs.gnu.org; Wed, 14 Jun 2023 07:58:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9P8q-0001jF-Ay for 64048@debbugs.gnu.org; Wed, 14 Jun 2023 07:58:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9P8j-00015r-00; Wed, 14 Jun 2023 07:58:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IMwAJxNtad8lctcYmbI/zRNr/Uq1s0RBitkHBohSNUI=; b=Zajx8EEkoVqZ h/RlSpVjj53rC8jQ+iQseMcrukfxoJX9XBnHK0bgce4pQvyfx5QJGploep7k1vKlSLF0XGbftBhyo qKi9eYG4RrzqyVKjIh4zQ32H17HmMpi59GkN2qxsxb/z98dRB4ZjhZJk2M51Y3wWIoK65i1IUP2rw 57V5BlUO/8Ri1YuVXtiPJp5HR5uaU0gpYltOngBNPonHpzIxAc+YCpNwTmEP3zXqLInX4BTYJ1M4D SQJdAa3+cKLf4pWQlqjpUHZ75+iYM2Y3vAMnG8Pf/W/s2YQPpyd/uU43d1Nealalz4Iog5yJAOMVT r/PE491TjEgOjq/1RFc2Hw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9P8i-0000LD-F8; Wed, 14 Jun 2023 07:58:16 -0400 Date: Wed, 14 Jun 2023 14:58:36 +0300 Message-Id: <83mt12uufn.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87sfavqhn5.fsf@localhost> (message from Ihor Radchenko on Tue, 13 Jun 2023 19:36:14 +0000) References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> <835y7rwbmb.fsf@gnu.org> <87352vs2g5.fsf@localhost> <83wn07usx7.fsf@gnu.org> <87sfavqhn5.fsf@localhost> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ihor Radchenko > Cc: 64048@debbugs.gnu.org > Date: Tue, 13 Jun 2023 19:36:14 +0000 > > Eli Zaretskii writes: > > > (Btw, I don't think I understand the use of :predicate which you > > proposed: it isn't documented as accepting a function, only nil, t, or > > a list of modes.) > > Hmm. You are right, I did not look far enough into the code. > > Let me correct my initial suggestion: > > (define-globalized-minor-mode global-display-line-numbers-mode > display-line-numbers-mode display-line-numbers--turn-on > :predicate t) This change is probably harmless, but OTOH what does it give you that the current code doesn't? AFAIU, you still cannot customize the modes where line numbers will be off. IOW, :predicate is not a means for user customizations of the modes where the minor mode will be turned on. Or am I missing something? > :predicate defines the default value of > `global-display-line-numbers-modes' variable. It does? Where is this documented? > The above code will not change the existing behaviour, except that > `global-display-line-numbers-modes' will be accounted for, iff > customized by the user. Is this behavior documented anywhere? What I see in the docs (both the doc string and the ELisp manual) is that the argument of :predicate determines _statically_ which modes will activate the minor mode. The variable created by :predicate can be used to query Emacs which modes are those, but cannot be used to change which modes do and which don't. If this is not what happens, we have a major mis-documentation on our hands. > >> I recall multiple occasions when I tried hard to disable a global mode > >> in some buffers, remembered that there is some special variable for it; > >> just to find out that a specific global minor mode does not support it. > > > > The usual way of enabling a mode selectively is to enable the > > non-global variant of the mode in a mode hook. I'm sure you know it. > > The use case I am talking about is enabling minor mode everywhere, > except certain major modes. It is more tricky. > > One can, of course, disable the minor mode selectively in some major > modes from that major mode hooks, but it is surprisingly non-obvious > approach. You can either disable it selectively (which is very obvious to me, FWIW), or you can selectively enable it. Both approaches are not rocket science, IMO. From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jun 2023 12:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 64048@debbugs.gnu.org, Stefan Monnier Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168674665011112 (code B ref 64048); Wed, 14 Jun 2023 12:45:01 +0000 Received: (at 64048) by debbugs.gnu.org; 14 Jun 2023 12:44:10 +0000 Received: from localhost ([127.0.0.1]:43984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Pr8-0002t9-7m for submit@debbugs.gnu.org; Wed, 14 Jun 2023 08:44:10 -0400 Received: from mout02.posteo.de ([185.67.36.66]:54155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9Pr5-0002su-Pd for 64048@debbugs.gnu.org; Wed, 14 Jun 2023 08:44:08 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D9A9D240101 for <64048@debbugs.gnu.org>; Wed, 14 Jun 2023 14:44:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686746641; bh=tuICx/6eUTyhM7bKmxU9LhMBIsWYYxzIn9OxgV7kbQA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=q7gubrMobyj8o7fb+rV6zMGyx6jhleO2yoc93bvDV8JJq+GRRNrRuybynC1QWasgz SvMYJAmqpZta21Ui2tjSC50BaTSTDS+3ECxtjssEEfjN5Z41G1HeSbkJjnVKyMlx6X +H7XJH1+r3DbnfaDcJJfKG90rUXcYrr1DvR1v1b4nqyd+F0np/j+j0fSuOl3GVW7LC i6YMrVxs6fxi3ik7JZVqKJuPsB4nu47GlKXR3IwQ49JxnL3NEvfLcs/D7gRX1+tOY4 OhOLiL5Pk43tLu7Maank61DgyPwmKFfFd8LWokCNCduDkfPSth/WEJkAjYeUVXdOqR fwgr7BGHtlbFA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qh4qN3zWWz9rxG; Wed, 14 Jun 2023 14:44:00 +0200 (CEST) From: Ihor Radchenko In-Reply-To: <83mt12uufn.fsf@gnu.org> References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> <835y7rwbmb.fsf@gnu.org> <87352vs2g5.fsf@localhost> <83wn07usx7.fsf@gnu.org> <87sfavqhn5.fsf@localhost> <83mt12uufn.fsf@gnu.org> Date: Wed, 14 Jun 2023 12:48:54 +0000 Message-ID: <87fs6u8b0p.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> Let me correct my initial suggestion: >> >> (define-globalized-minor-mode global-display-line-numbers-mode >> display-line-numbers-mode display-line-numbers--turn-on >> :predicate t) > > This change is probably harmless, but OTOH what does it give you that > the current code doesn't? AFAIU, you still cannot customize the modes > where line numbers will be off. > > IOW, :predicate is not a means for user customizations of the modes > where the minor mode will be turned on. Or am I missing something? >> :predicate defines the default value of >> `global-display-line-numbers-modes' variable. > > It does? Where is this documented? Yup. It is not documented on API level, but when :predicate is non-nil, `define-globalized-minor-mode' does the following: (setq turn-on-function `(lambda () (require 'easy-mmode) (when (easy-mmode--globalized-predicate-p ,MODE-predicate) (funcall ,turn-on-function)))) ;; Minor mode docstring: (if predicate (concat "\n\n" (internal--format-docstring-line "`%s' is used to control which modes this minor mode is used in." MODE-predicate)) ;; -modes "") ,(when predicate `(defcustom ,MODE-predicate ,(car predicate) ,(format "Which major modes `%s' is switched on in. This variable can be either t (all major modes), nil (no major modes), or a list of modes and (not modes) to switch use this minor mode or not. For instance (c-mode (not message-mode mail-mode) text-mode) means \"use this mode in all modes derived from `c-mode', don't use in modes derived from `message-mode' or `mail-mode', but do use in other modes derived from `text-mode'\". An element with value t means \"use\" and nil means \"don't use\". There's an implicit nil at the end of the list." mode) :type '(repeat sexp) ,@group)) >> One can, of course, disable the minor mode selectively in some major >> modes from that major mode hooks, but it is surprisingly non-obvious >> approach. > > You can either disable it selectively (which is very obvious to me, > FWIW), or you can selectively enable it. Both approaches are not > rocket science, IMO. I partially agree, and I also find the approach obvious once I see it. But the variable is easier (requires less Elisp knowledge) and is already used in _some_ global minor modes. IMHO, controlling global minor modes is one of the basic features that should be better exposed to newbie users who use customize interface and do not know Elisp. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 07:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ihor Radchenko , Stefan Monnier Cc: 64048@debbugs.gnu.org Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168698797429969 (code B ref 64048); Sat, 17 Jun 2023 07:47:02 +0000 Received: (at 64048) by debbugs.gnu.org; 17 Jun 2023 07:46:14 +0000 Received: from localhost ([127.0.0.1]:50795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAQdS-0007nH-B3 for submit@debbugs.gnu.org; Sat, 17 Jun 2023 03:46:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAQdQ-0007n4-5r for 64048@debbugs.gnu.org; Sat, 17 Jun 2023 03:46:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAQdK-0001tF-JI; Sat, 17 Jun 2023 03:46:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0Q3BfWQ26eX3FxtWymJbdXx56jWwOh5sXzMR93DHm0I=; b=fbsynI6xVroU /eYk+a3LT0ugF0zpBtd0qVAdD9j3I7mIFav/OY2vTGhSCf5laKT6F/GlHvKNt2fPuPriMAsAJR2fk gmjSMBeCOPWIwnlD8V85zD/6jnOYcQ0/ZPP8ussVban3IVtB+u/0JvmxUZEGhA9OvhcqUiKruA8Zq vFpbt+3eUT3HpriSRcamP3Mq9vXr5S6ozD1U74X6veHDDDeCiKMDpAz1HagINNHJFLhF78KQagRzF 60MV/zSd5HoIPO2AgTXwB/NVxWYikJV+64KaBmu+3uFyBLtZO3bSKm7Q04SlLgHJ/v1K+kSsJDb2h /cTI3a9dglguggtS/yMo/A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAQdK-0005fj-3L; Sat, 17 Jun 2023 03:46:06 -0400 Date: Sat, 17 Jun 2023 10:46:05 +0300 Message-Id: <83ttv6r0oy.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87fs6u8b0p.fsf@localhost> (message from Ihor Radchenko on Wed, 14 Jun 2023 12:48:54 +0000) References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> <835y7rwbmb.fsf@gnu.org> <87352vs2g5.fsf@localhost> <83wn07usx7.fsf@gnu.org> <87sfavqhn5.fsf@localhost> <83mt12uufn.fsf@gnu.org> <87fs6u8b0p.fsf@localhost> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ihor Radchenko > Cc: Stefan Monnier , 64048@debbugs.gnu.org > Date: Wed, 14 Jun 2023 12:48:54 +0000 > > Eli Zaretskii writes: > > >> Let me correct my initial suggestion: > >> > >> (define-globalized-minor-mode global-display-line-numbers-mode > >> display-line-numbers-mode display-line-numbers--turn-on > >> :predicate t) > > > > This change is probably harmless, but OTOH what does it give you that > > the current code doesn't? AFAIU, you still cannot customize the modes > > where line numbers will be off. > > > > IOW, :predicate is not a means for user customizations of the modes > > where the minor mode will be turned on. Or am I missing something? > > >> :predicate defines the default value of > >> `global-display-line-numbers-modes' variable. > > > > It does? Where is this documented? > > Yup. It is not documented on API level, but when :predicate is non-nil, > `define-globalized-minor-mode' does the following: > > (setq turn-on-function > `(lambda () > (require 'easy-mmode) > (when (easy-mmode--globalized-predicate-p ,MODE-predicate) > (funcall ,turn-on-function)))) > > ;; Minor mode docstring: > (if predicate > (concat > "\n\n" > (internal--format-docstring-line > "`%s' is used to control which modes this minor mode is used in." > MODE-predicate)) ;; -modes > "") > > ,(when predicate > `(defcustom ,MODE-predicate ,(car predicate) > ,(format "Which major modes `%s' is switched on in. > This variable can be either t (all major modes), nil (no major modes), > or a list of modes and (not modes) to switch use this minor mode or > not. For instance > > (c-mode (not message-mode mail-mode) text-mode) > > means \"use this mode in all modes derived from `c-mode', don't use in > modes derived from `message-mode' or `mail-mode', but do use in other > modes derived from `text-mode'\". An element with value t means \"use\" > and nil means \"don't use\". There's an implicit nil at the end of the > list." > mode) > :type '(repeat sexp) > ,@group)) Stefan, is our current documentation of :predicate incomplete? From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 18:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 64048@debbugs.gnu.org, Ihor Radchenko Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168702664518430 (code B ref 64048); Sat, 17 Jun 2023 18:31:02 +0000 Received: (at 64048) by debbugs.gnu.org; 17 Jun 2023 18:30:45 +0000 Received: from localhost ([127.0.0.1]:52601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAahB-0004nC-Kh for submit@debbugs.gnu.org; Sat, 17 Jun 2023 14:30:45 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAah5-0004mv-VF for 64048@debbugs.gnu.org; Sat, 17 Jun 2023 14:30:43 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6CCE244131E; Sat, 17 Jun 2023 14:30:34 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D04C94412DD; Sat, 17 Jun 2023 14:30:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687026631; bh=HDrckfphW/IjDxy16LyoQXo+g9io83bL6UwK0MACxMA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FFwLnDDuLnYhEuNlCk/KAdRoTGmPEZHvrjh21/azYYLmgGymQYYyZQkZKBQqdA6Qq 544rMACzkGikddevLaz6xEQSGwH4VP4GQscU400O6yFDmfLzgQviC1B6rXQg4Jn5zN RDK+7Ysnvt/9QetmMbF7QoQTnnLrurysxNqulXnre7iATn/DzK4mw0Fw1We+ecvcLp 88X1beHhB0u/G+tXjWWMUNJr6Yg85sd8b0QOBS4fJfPOWY4ZWVUfk4Fhzt8cLiiKEF Wdf3hebpC7aYT+Oqb9erXY9k19lYUCGkst60rj9rS6uP+Su6nOwRKKwoOQimjT+xf5 4WxsNvQqZqV7A== Received: from pastel (unknown [45.72.207.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A61DF12082E; Sat, 17 Jun 2023 14:30:31 -0400 (EDT) From: Stefan Monnier In-Reply-To: <83ttv6r0oy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Jun 2023 10:46:05 +0300") Message-ID: References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> <835y7rwbmb.fsf@gnu.org> <87352vs2g5.fsf@localhost> <83wn07usx7.fsf@gnu.org> <87sfavqhn5.fsf@localhost> <83mt12uufn.fsf@gnu.org> <87fs6u8b0p.fsf@localhost> <83ttv6r0oy.fsf@gnu.org> Date: Sat, 17 Jun 2023 14:30:30 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Stefan, is our current documentation of :predicate incomplete? I'm not really familiar with that argument (AFAICT it was implemented by Lars in commit b8b18cf34a04a). The whole feature puts me off a bit because of its name: in my world a "predicate" is a kind of function, so I think it's a poor name for a variable containing some list-based description of a set of modes. But indeed, it seems the docstring forgets to mention that the `:predicate MODES` argument causes the introduction of a new variable called `MINOR-MODE-predicate` and whose default value is MODES. Stefan "who'd rename the `:predicate` arg to something like `:modes` and the `MODE-predicate` variable to something like `MODE-modes`." From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 18:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 64048@debbugs.gnu.org, yantar92@posteo.net Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168702829721304 (code B ref 64048); Sat, 17 Jun 2023 18:59:01 +0000 Received: (at 64048) by debbugs.gnu.org; 17 Jun 2023 18:58:17 +0000 Received: from localhost ([127.0.0.1]:52634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAb7n-0005XU-R4 for submit@debbugs.gnu.org; Sat, 17 Jun 2023 14:58:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAb7j-0005XG-TC for 64048@debbugs.gnu.org; Sat, 17 Jun 2023 14:58:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAb7e-0003yn-D5; Sat, 17 Jun 2023 14:58:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sfafDe8j+flwdikeZIZsh3wn1fDsrKDiNN/ySi2tTCM=; b=lX7qfgeRVjh+ Ec0/oKeRql7+jRq+p5qVB1fB5DmQZ9Sl5bT42Ww3LdcIlDRb2k/+uVjBpmqdymCPILOU5tN2+CUUD NlJjpqwF7/kCmWZocx83VQWIwLI0GdkQuWHZdNS+xe2IVnjWqzbO2aW2SpN3TTA8Im+Lo0QFGEtY/ YkWXqQO0Wao2UFBDF3bREdAC+LTn9G4ZAP7BJaNkAK/waB74cKw3LDs2Uw8URBkP4flgn+xns6Bgp OPopHV+AHl9CwJEtduidLr/euMU1O4l+w1p2HYwFXD0gPyH4gGF+n+/Zya9Zku+ZOvSFR6ddUxwN6 tQzm1PClvminAUX5zCNkDw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAb7c-0006NF-0U; Sat, 17 Jun 2023 14:58:06 -0400 Date: Sat, 17 Jun 2023 21:58:04 +0300 Message-Id: <83r0q9q5kz.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Monnier on Sat, 17 Jun 2023 14:30:30 -0400) References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> <835y7rwbmb.fsf@gnu.org> <87352vs2g5.fsf@localhost> <83wn07usx7.fsf@gnu.org> <87sfavqhn5.fsf@localhost> <83mt12uufn.fsf@gnu.org> <87fs6u8b0p.fsf@localhost> <83ttv6r0oy.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Ihor Radchenko , 64048@debbugs.gnu.org > Date: Sat, 17 Jun 2023 14:30:30 -0400 > > > Stefan, is our current documentation of :predicate incomplete? > > I'm not really familiar with that argument (AFAICT it was implemented > by Lars in commit b8b18cf34a04a). The whole feature puts me off a bit > because of its name: in my world a "predicate" is a kind of function, > so I think it's a poor name for a variable containing some list-based > description of a set of modes. > > But indeed, it seems the docstring forgets to mention that the > `:predicate MODES` argument causes the introduction of a new variable > called `MINOR-MODE-predicate` and whose default value is MODES. That's mostly already documented. What is NOT documented is that by giving that variable a non-default value one can affect in which modes this minor mode will be turned on and in which it will be turned off. IOW, the fact that this variable can be used for user customizations is not documented at all. And your answer just hints on whether the above is true. > Stefan "who'd rename the `:predicate` arg to something like > `:modes` and the `MODE-predicate` variable to something > like `MODE-modes`." I guess it's too late for renaming this? From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 64048@debbugs.gnu.org, Eli Zaretskii Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168702836621411 (code B ref 64048); Sat, 17 Jun 2023 19:00:02 +0000 Received: (at 64048) by debbugs.gnu.org; 17 Jun 2023 18:59:26 +0000 Received: from localhost ([127.0.0.1]:52638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAb8v-0005ZH-TJ for submit@debbugs.gnu.org; Sat, 17 Jun 2023 14:59:26 -0400 Received: from mout02.posteo.de ([185.67.36.66]:41167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAb8r-0005Z0-Qc for 64048@debbugs.gnu.org; Sat, 17 Jun 2023 14:59:24 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DE8A124010E for <64048@debbugs.gnu.org>; Sat, 17 Jun 2023 20:59:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1687028355; bh=Hwj2uHhzrWSqw3Z3e8Ct3OQf49oKjXLBXOwVrLAYheg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=iXl44JpJ4UHsIjOXyEDIvNXcGSZ0nUeVeSfwcsVfPP5WaIk/Ak3G20KcgbvInM0ff wQ5qNyN4X4kXnE1eMWkc69I/FkEnLZ1liiUlZesZ4e2cXQLHOHIYFPOfMCLK/kxZH6 cLidftEa3Rp1mwTbRM/Bv3Gxpf8874te1Mu4FZbrGvGOgEwmKbgpvIeR7FgTgPH7R8 xt9qSyt8PsJl//DhGfJQe9JWUqV95xZaADYtCRRsNxIjLwF9c2xjPV7tqHGsfiOs50 vUk1/SCeZg7twHYvR3T6ar65n4B3Ejl0RhcqYGcT0iKRnv7qItq+FT3am42eU3qCIo xNa70Ui7EBFcA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qk50z22PHz9rxF; Sat, 17 Jun 2023 20:59:14 +0200 (CEST) From: Ihor Radchenko In-Reply-To: References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> <835y7rwbmb.fsf@gnu.org> <87352vs2g5.fsf@localhost> <83wn07usx7.fsf@gnu.org> <87sfavqhn5.fsf@localhost> <83mt12uufn.fsf@gnu.org> <87fs6u8b0p.fsf@localhost> <83ttv6r0oy.fsf@gnu.org> Date: Sat, 17 Jun 2023 19:04:07 +0000 Message-ID: <87mt0xap20.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > But indeed, it seems the docstring forgets to mention that the > `:predicate MODES` argument causes the introduction of a new variable > called `MINOR-MODE-predicate` and whose default value is MODES. Not `MINOR-MODE-predicate', `MINOR-MODE-modes': (MODE-predicate (intern (concat (replace-regexp-in-string "-mode\\'" "" global-mode-name) "-modes"))) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 19:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 64048@debbugs.gnu.org, Stefan Monnier Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168702851221734 (code B ref 64048); Sat, 17 Jun 2023 19:02:02 +0000 Received: (at 64048) by debbugs.gnu.org; 17 Jun 2023 19:01:52 +0000 Received: from localhost ([127.0.0.1]:52642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAbBI-0005eU-E7 for submit@debbugs.gnu.org; Sat, 17 Jun 2023 15:01:52 -0400 Received: from mout01.posteo.de ([185.67.36.65]:57757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAbBF-0005eG-RS for 64048@debbugs.gnu.org; Sat, 17 Jun 2023 15:01:51 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5931A240028 for <64048@debbugs.gnu.org>; Sat, 17 Jun 2023 21:01:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1687028504; bh=d+gAOJqvEOubnd4o/HF8ebAJAHUym2kXcvVDK7Q/euU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=J0KwQvGkl9N3LJL7rTOYCRuLft0apyzS3CXWiarAES7uIuZhQ5krt7IbhzjcuHsWp D16rxmQqSnOsI8jcho+4Fru9+wPk42mT1GcvYuS8KS17+mRQxdmgnFBAbZzxwUZqPx 6ry34a2JRo7oYO/A64QPnXw9C0LfLOAb+RSSsCum7RuIidVu0i66Kqt4C5MhJ2BPZu KYi41FR2jNID2zAU7loXiDrU4G3gNRuW4r1P9fPTskQmrHlCY/kLkYaB5CbjHXuIWI 13aox6XvCrsJvS081m3ZbEW3jVpEcbVHyIP5eKgIhXLuri4yJq88e+T6ppxS3Za3KU iq9K4clUY0gxQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qk53q44yWz6twy; Sat, 17 Jun 2023 21:01:43 +0200 (CEST) From: Ihor Radchenko In-Reply-To: <83r0q9q5kz.fsf@gnu.org> References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> <835y7rwbmb.fsf@gnu.org> <87352vs2g5.fsf@localhost> <83wn07usx7.fsf@gnu.org> <87sfavqhn5.fsf@localhost> <83mt12uufn.fsf@gnu.org> <87fs6u8b0p.fsf@localhost> <83ttv6r0oy.fsf@gnu.org> <83r0q9q5kz.fsf@gnu.org> Date: Sat, 17 Jun 2023 19:06:39 +0000 Message-ID: <87jzw1aoxs.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> Stefan "who'd rename the `:predicate` arg to something like >> `:modes` and the `MODE-predicate` variable to something >> like `MODE-modes`." > > I guess it's too late for renaming this? It can be done in backwards-compatible way, so why not? Just keep :predicate in the code as internal compatibility alias. This is for the argument. The defined customization does not need to be renamed. It already has MODE-modes symbol name. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From unknown Sun Jun 15 08:45:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Jun 2023 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ihor Radchenko Cc: 64048@debbugs.gnu.org, Eli Zaretskii Received: via spool by 64048-submit@debbugs.gnu.org id=B64048.168702953223344 (code B ref 64048); Sat, 17 Jun 2023 19:19:02 +0000 Received: (at 64048) by debbugs.gnu.org; 17 Jun 2023 19:18:52 +0000 Received: from localhost ([127.0.0.1]:52664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAbRk-00064S-9u for submit@debbugs.gnu.org; Sat, 17 Jun 2023 15:18:52 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAbRh-00064C-JC for 64048@debbugs.gnu.org; Sat, 17 Jun 2023 15:18:51 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 590AF1001FC; Sat, 17 Jun 2023 15:18:44 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7CA09100083; Sat, 17 Jun 2023 15:18:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1687029523; bh=aaFGi+3wBKJfzBQI1UWA64S3xWf62kUhV8MpZnSOQVM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ctDBqxFaV/X75Kzzw1CkZtc245CQfc0Pj4zRAcHIcnFfAjj0GOInZzGlAHjJ20BeX g1JHbEEeA0GURhtLG7DFaR6Nm4iNwoY5I9ToF/0Hc6CVSd6PE6bdnEEP22dZGItJ9A TGnjqu1KGlglVGynhhH8QpJ5DozMYbfNib3FpRC4zfBhPMEJGKnqQiIDWxe1OkqBA+ c+bKUQTQfonqm5mQKuWc0Vs+3KyA9kUK6CJhf+7Gug18RjEGErSIyXIx8GnUbAP4KC rugSsAEjcpARLcsTdBgCnLeWBZjJogLCNF6pBerEPj+JqTKpFnzI+Z7pYgsWKaAg/4 qQkxHJm5S+kcg== Received: from pastel (unknown [45.72.207.87]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 513E11201CA; Sat, 17 Jun 2023 15:18:43 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87mt0xap20.fsf@localhost> (Ihor Radchenko's message of "Sat, 17 Jun 2023 19:04:07 +0000") Message-ID: References: <87a5x3sa7w.fsf@localhost> <83bkhjweco.fsf@gnu.org> <875y7rs5s5.fsf@localhost> <835y7rwbmb.fsf@gnu.org> <87352vs2g5.fsf@localhost> <83wn07usx7.fsf@gnu.org> <87sfavqhn5.fsf@localhost> <83mt12uufn.fsf@gnu.org> <87fs6u8b0p.fsf@localhost> <83ttv6r0oy.fsf@gnu.org> <87mt0xap20.fsf@localhost> Date: Sat, 17 Jun 2023 15:18:42 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.170 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> But indeed, it seems the docstring forgets to mention that the >> `:predicate MODES` argument causes the introduction of a new variable >> called `MINOR-MODE-predicate` and whose default value is MODES. > > Not `MINOR-MODE-predicate', `MINOR-MODE-modes': > > (MODE-predicate (intern (concat (replace-regexp-in-string > "-mode\\'" "" global-mode-name) > "-modes"))) Ha! Great minds do think alike after all! Stefan