From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 13 10:29:46 2023 Received: (at submit) by debbugs.gnu.org; 13 Jun 2023 14:29:46 +0000 Received: from localhost ([127.0.0.1]:42644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q951m-0000r7-90 for submit@debbugs.gnu.org; Tue, 13 Jun 2023 10:29:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:59164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q951k-0000qz-GJ for submit@debbugs.gnu.org; Tue, 13 Jun 2023 10:29:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q951k-0006ry-78 for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2023 10:29:44 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q951h-0000jf-SH for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2023 10:29:43 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 926EF240103 for ; Tue, 13 Jun 2023 16:29:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686666579; bh=Pt8KMid8wot+j8qr63dRKeOL7ysePa8BvzuzMYYphm4=; h=From:To:Subject:Date:Message-ID:MIME-Version:From; b=HZKi9ElYDoFgkPOh8Ldw3Ml1Hx99vQtzEvQiC2/Jg5DwEMWl2Gtp2XkMSBd1zkx23 jf19ZHEsj67aGVCGJNlQT+JTBDguYTAKWXqIzN5sOKk8tA5jGi2ESHafPZy/O4Uxsy Kx3tRMioimaAgHYwmfDHJ/HnnYRLqqxWyZ/JgPZanyNWIzz2tLEEf1cud86vv/o4IH 8fO2IdPIKnD3mti4G4IFIjZ4OUgx9Msf2MTyplBl97sY9kqSbKjW3iXYqOdm+6gaxA fp1BAHbfMbItpbyoWn1NvAAvgR+V/VcYgOD79A3ssDVabFLCQQnP1U3ZxB3I13lF5E f8TftYawxESlA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QgWCl0CzRz6tsf for ; Tue, 13 Jun 2023 16:29:38 +0200 (CEST) From: Ihor Radchenko To: bug-gnu-emacs@gnu.org Subject: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Date: Tue, 13 Jun 2023 14:34:33 +0000 Message-ID: <878rcnsa6e.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, global-display-line-numbers-mode is defined as (define-globalized-minor-mode global-display-line-numbers-mode display-line-numbers-mode display-line-numbers--turn-on) Which unconditionally enables it when `display-line-numbers--turn-on' returns t. Wouldn't it be nicer to have something like (define-globalized-minor-mode global-display-line-numbers-mode display-line-numbers-mode display-line-numbers--turn-on :predicate #'display-line-numbers--turn-on) that will also define `display-line-numbers-modes' variable that controls where the global mode is enabled/disabled? Maybe it should even be the default in `define-globalized-minor-mode' when :predicate is not defined. WDYT? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at