GNU bug report logs -
#64046
30.0.50; Quoting in customize choice tags
Previous Next
Reported by: Stephen Berman <stephen.berman <at> gmx.net>
Date: Tue, 13 Jun 2023 14:04:02 UTC
Severity: normal
Found in version 30.0.50
Done: Stephen Berman <stephen.berman <at> gmx.net>
Bug is archived. No further changes may be made.
Full log
Message #65 received at 64046 <at> debbugs.gnu.org (full text, mbox):
Stephen Berman <stephen.berman <at> gmx.net> writes:
> Right after sending, I found an obvious problem: only one of the car or
> the cdr might be a string. The following patch accounts for this:
>
> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
> index a70598bb6c9..891e98b6de5 100644
> --- a/lisp/wid-edit.el
> +++ b/lisp/wid-edit.el
> @@ -285,12 +285,18 @@ widget-choose
> ;; Apply quote substitution to customize choice menu item text,
> ;; whether it occurs in a widget buffer or in a popup menu.
> (let ((items (mapc (lambda (x)
> - (when (consp x)
> - (dotimes (i (1- (length x)))
> - (when (stringp (nth i x))
> - (setcar (nthcdr i x)
> - (substitute-command-keys
> - (car (nthcdr i x))))))))
> + (if (proper-list-p x)
> + (dotimes (i (1- (length x)))
> + (when (stringp (nth i x))
> + (setcar (nthcdr i x)
> + (substitute-command-keys
> + (car (nthcdr i x))))))
> + ;; ITEMS has simple item definitions.
> + (when (consp x)
> + (when (stringp (car x))
> + (setcar x (substitute-command-keys (car
x))))
> + (when (stringp (cdr x))
> + (setcdr x (substitute-command-keys (cdr
x)))))))
Thinking about it, why do we need to call substitute-command-keys on the
VALUE part (i.e., the cdr of the cons cell), in case of simple item
definitions?
I re-read the bug report, but I didn't find any reference to why that is
a need. Did I miss something?
(I'll be going on a trip for the weekend, so apologies if I can't
see your response soon enough)
This bug report was last modified 1 year and 312 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.