GNU bug report logs - #64046
30.0.50; Quoting in customize choice tags

Previous Next

Full log

Message #46 received at 64046 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 64046 <at> debbugs.gnu.org
Subject: Re: bug#64046: 30.0.50; Quoting in customize choice tags
Date: Thu, 20 Jul 2023 21:53:54 +0200

On Thu, 20 Jul 2023 16:11:33 -0300 Mauro Aranda <maurooaranda <at> gmail.com> wrote:

> Stephen Berman <stephen.berman <at> gmx.net> writes:
>
>> On Sat, 15 Jul 2023 10:20:17 -0300 Mauro Aranda <maurooaranda <at> gmail.com>
>  wrote:
>>
>>> Turns out this code introduces regressions when customizing faces.
>>>
>>> With emacs -Q:
>>> M-x customize-face RET default
>>> Action the State button and choose: "For All Kinds of Displays"
>>> Action the Display menu and select "specific display"
>>> Wrong type argument: number-or-marker-p, "        "
>>>
>>> The substitute-command-keys operation is too destructive, and messes
>>> with things it shouldn't be modifying, like the :offset property of
>>> widgets in this case.
>
>> Sorry for not responding sooner; I was travelling and only now had time
>> to look into this.  If I debugged it correctly, the problem is that the
>> value of :extra-offset, 9, satisfies char-or-string-p, so then due to my
>> patch substitute-command-keys turns it into a string containing a TAB.
>
> No trouble at all.  And yes, that sounds correct to me.
>
>> The cases intended to be fixed by my patch are where strings with grave
>> quoting occur, which should be turned into strings with curve quoting.
>> If so, then testing for stringp suffices, and the attached patch avoids
>> the regression you found and gives the desired results for the other
>> cases discussed in this bug.  I don't know why I used char-or-string-p
>> instead of stringp in my original patch, and don't see a reason for it
>> now.  Or do you know of cases where testing for stringp is insufficient?
>
> I don't know, but I feel like stringp should suffice.  So please install
> your fix, and I will be alert if something else breaks.

Thanks, pushed to master as commit c55e67081e9.

Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.