From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 64046@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1686664987607 (code B ref -1); Tue, 13 Jun 2023 14:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jun 2023 14:03:07 +0000 Received: from localhost ([127.0.0.1]:42600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q94by-00009i-HS for submit@debbugs.gnu.org; Tue, 13 Jun 2023 10:03:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:53092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q94bw-00009a-0v for submit@debbugs.gnu.org; Tue, 13 Jun 2023 10:03:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q94bv-0007re-RS for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2023 10:03:03 -0400 Received: from mout.gmx.net ([212.227.17.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q94bt-0008PC-GO for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2023 10:03:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1686664978; x=1687269778; i=stephen.berman@gmx.net; bh=n1zxSOkPLjFIWDEi+i7IiQcpM5HAEXo300oxlkXwtMs=; h=X-UI-Sender-Class:From:To:Subject:Date; b=NcOMWHOyitYfmqzf4vnmqDVem0NpbKUqClDSx1/f8+6zae1P47dYN8VgIu98zYOVZ6H++vO 4zZMF05KbspmCF2UK1L/iCeJ5CGDRV02ZDJ1AESdvHKzF3haiNUElZEiNOJH/7EX6yztRkWUt tL2WRNeA2xu2YqKAzK8VfNqCfREvgW66DN5k26ZmeNkDN+4ok+tZOzgLV5jUFsHvpal1E/c4j O7MR4IcwXMigNcPRx5Zjnd9i9Il03qXToDmR4m7U1lNgaVEe51cNNxnfBIgDadsydV0bwjz2H 4FQD/36EcbIy+RT9d68yUv8xuQDCmZZPtmtlQIRxrRGbRTi8dN0A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.37.154]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfpSb-1pcTkJ2aPB-00gD9D for ; Tue, 13 Jun 2023 16:02:58 +0200 From: Stephen Berman Date: Tue, 13 Jun 2023 16:02:57 +0200 Message-ID: <87v8frihny.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:4MpQi8JI+bvd0YZQcczEdqxstOedutLch3MHRV0G6WWzL8Q6CZa dWiGFZOo+gupuKKtLii/9Ywc6c2+zL1ROMSJXVfz7tK4nieWxOpC+TbA/cHaH4fIB3jW838 Wgsf4ArbQpTiyCkTwXcijVGLdSCReREgprMENa8cjn52w+YZ1h7L5dB7vrMfVM1Ma+I3v97 8DdpW7ZZtVBwLuAuPeL6Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:t6Ngau6LwHs=;NrEvJXtg2R+fEgX20rcUJZehnU4 nN9N/55i3pmHCp2t6Awvph+ZC4NbDOjuuSWhYO//03oLBmAN24Q6EHc28lV7/3aqCL6TFRFad kOMbP70ob3iJb9l1f7Yogm3wbwWlClbJy7c9wuP51fa14hD0cy5PB7R4F77TLZLcT4pgLtFZx YtpPosSa/0Lfl/EGRVp2FmwZfWuqcUCdqtoT79AD0hq9oWGT7bZ6Q58bpFtmMQaAAqAbllQoP n9KFn7VeQdO7AoSVFTHUGQNdNMZ/DQdX/c1Wrpg58Xocr6HlIR4Abibpj290Hri+oK6Mr+Xoc LYv8tf+uYHKVSNSVbeU5HBD3BMghqGFxad/BF8CXMVAYDbrVdB1FUu4CUAqvk2oSOkTH7sg4W 20W7adqrdfawDvuIUX8DqUGT4nQgxVOhsQrcl79WNxlWhlnEgTaSmDnP4LQ5QhxIdH2fHWUKq 536mU7LJuCyxpwHojOyt4eLznpWVaQyicpggnxjnZyjk8re2A7svb8YDk8zIKKzqpzqiyXvYB RNY78rK//SI9skLELoUWKLNA92T9BDDO2ma9P18F7rJdlOrDI/wvCJOmlKy/ph2Fo4dLweG29 I2CzBM/somxmKfFV8qOdyklkzbNr31RJk6JdanAPBnWBFWlgGnD9reXMMM2XhR/6lR3elepJP r9eMhkqsjiE+Q/rCz2SmuOeD806r24R7IzKADTkouUiewhGwiiFWYR1tDz9knGTW3W8Kcv5+F 1E4m5UBjm0iyl2B3o4D4TTN64sGwnG9n4NPLx68Pr/thzR9fBzqe0qn+y8N5wZflCkS+GX3cE r1yDnqPhIhroMfznxPDh9qZAKcWToXA7zFwnJ7RO9Hmlt4YytoW1BVYs4SEw62SuVo1ofLPgs tiPPZt1C7uuyW5w2l/uWGjBgIo9fxqNb2rg5VhfpYb5MTIIYuqdFmWoFKGZ/ZcjqTdrHxVLsG 6jtGK+wb79tDf6u7i36gH2bpUok= Received-SPF: pass client-ip=212.227.17.20; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable 0. emacs -Q 1. Evaluate the following defcustom: (defcustom my-test "a" "Test." :type '(choice (string :tag "Use `a'" "a") (string :tag "Use `b'" "b"))) 2. M-x customize-option RET my-test RET 3. In the buffer *Customize Option: My Test* note that in the string "Use =E2=80=98a=E2=80=99" following the "Value Menu" button the quote ma= rks are in the "curve" style (=E2=80=98=E2=80=99). 4. Put point on the "Value Menu" button and type RET. 5. The buffer " widget-choose" contains these lines: 0 =3D Use =E2=80=98a=E2=80=99 1 =3D Use =E2=80=98b=E2=80=99 Note that the quote marks in this buffer are also in the "curve" style. 6. With the mouse pointer over the "Value Menu" button press mouse-1, popping up a menu titled "Choice" containing these items: Use `a' Use `b' Note that the quote marks in this menu are in the "grave" style (`') instead of the "curve" style. The use of the "curve" style in the " widget-choose" buffer is due to commit bd3b426ebb7a60045839e97c9da9bfd249fab1f1, but that commit did not take popup menus into account. The attached patch does so. Since the status quo ante long predates emacs-29 and this is just a stylistic bug, I made the patch against master. In this patch I chose to apply substitute-command-keys just once at the beginning of the function `widget-choose', rather than several times within the function, but I restricted its application to item tags, so other uses of the ITEMS argument should not be affected (and my brief testing hasn't found any problem with the patch). The patch also takes the opportunity to replace two unnecessary uses of `let*' in `widget-choose', in one case by `let' and in the other by foregoing let-bound variables altogether and just using the values in place, since they occur only once each in the lines immediately following the eliminated `let*'. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.6) of 2023-06-13 built on strobelfssd Repository revision: ba349aa32e98a53146794197c316f4765598ddbd Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Linux From Scratch r11.3-100-systemd Configured using: 'configure -C --with-xwidgets 'CFLAGS=3D-Og -g3' PKG_CONFIG_PATH=3D/opt/qt5/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM XWIDGETS GTK3 ZLIB --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: widget-choose patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index cafd0ad0a4d..bc070c9933f 100644 =2D-- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -281,71 +281,75 @@ widget-choose If ITEMS has simple item definitions, then this function returns the VALU= E of the chosen element. If ITEMS is a keymap, then the return value is the s= ymbol in the key vector, as in the argument of `define-key'." - (cond ((and (< (length items) widget-menu-max-size) - event (display-popup-menus-p)) - ;; Mouse click. - (if (keymapp items) - ;; Modify the keymap prompt, and then restore the old one, i= f any. - (let ((prompt (keymap-prompt items))) - (unwind-protect - (progn - (setq items (delete prompt items)) - (push title (cdr items)) - ;; Return just the first element of the list of even= ts. - (car (x-popup-menu event items))) - (setq items (delete title items)) - (when prompt - (push prompt (cdr items))))) - (x-popup-menu event (list title (cons "" items))))) - ((or widget-menu-minibuffer-flag - (> (length items) widget-menu-max-shortcuts)) - (when (keymapp items) - (setq items (widget--simplify-menu items))) - ;; Read the choice of name from the minibuffer. - (setq items (cl-remove-if 'stringp items)) - (let ((val (completing-read (concat title ": ") items nil t))) - (if (stringp val) - (let ((try (try-completion val items))) - (when (stringp try) - (setq val try)) - (cdr (assoc val items)))))) - (t - (when (keymapp items) - (setq items (widget--simplify-menu items))) - ;; Construct a menu of the choices - ;; and then use it for prompting for a single character. - (let* ((next-digit ?0) - alist choice some-choice-enabled value) - (with-current-buffer (get-buffer-create " widget-choose") - (erase-buffer) - (insert "Available choices:\n\n") - (while items - (setq choice (pop items)) - (when (consp choice) - (let* ((name (substitute-command-keys (car choice))) - (function (cdr choice))) - (insert (format "%c =3D %s\n" next-digit name)) - (push (cons next-digit function) alist) - (setq some-choice-enabled t))) - ;; Allocate digits to disabled alternatives - ;; so that the digit of a given alternative never varies. - (setq next-digit (1+ next-digit))) - (insert "\nC-g =3D Quit") - (goto-char (point-min)) - (forward-line)) - (or some-choice-enabled - (error "None of the choices is currently meaningful")) - (save-window-excursion - ;; Select window to be able to scroll it from minibuffer - (with-selected-window - (display-buffer (get-buffer " widget-choose") - '(display-buffer-in-direction - (direction . bottom) - (window-height . fit-window-to-buffer)= )) - (setq value (read-char-choice - (format "%s: " title) - (mapcar #'car alist))))) - (cdr (assoc value alist)))))) + ;; Apply quote substitution to all customize choice tags, whether + ;; they occur in a widget buffer or in a popup menu. + (let ((items (mapc (lambda (x) + (when (and (consp x) (char-or-string-p (car x))) + (setcar x (substitute-command-keys (car x))))) + items))) + (cond ((and (< (length items) widget-menu-max-size) + event (display-popup-menus-p)) + ;; Mouse click. + (if (keymapp items) + ;; Modify the keymap prompt, and then restore the old one,= if any. + (let ((prompt (keymap-prompt items))) + (unwind-protect + (progn + (setq items (delete prompt items)) + (push title (cdr items)) + ;; Return just the first element of the list of ev= ents. + (car (x-popup-menu event items))) + (setq items (delete title items)) + (when prompt + (push prompt (cdr items))))) + (x-popup-menu event (list title (cons "" items))))) + ((or widget-menu-minibuffer-flag + (> (length items) widget-menu-max-shortcuts)) + (when (keymapp items) + (setq items (widget--simplify-menu items))) + ;; Read the choice of name from the minibuffer. + (setq items (cl-remove-if 'stringp items)) + (let ((val (completing-read (concat title ": ") items nil t))) + (if (stringp val) + (let ((try (try-completion val items))) + (when (stringp try) + (setq val try)) + (cdr (assoc val items)))))) + (t + (when (keymapp items) + (setq items (widget--simplify-menu items))) + ;; Construct a menu of the choices + ;; and then use it for prompting for a single character. + (let ((next-digit ?0) + alist choice some-choice-enabled value) + (with-current-buffer (get-buffer-create " widget-choose") + (erase-buffer) + (insert "Available choices:\n\n") + (while items + (setq choice (pop items)) + (when (consp choice) + (insert (format "%c =3D %s\n" next-digit (car choice))= ) + (push (cons next-digit (cdr choice)) alist) + (setq some-choice-enabled t)) + ;; Allocate digits to disabled alternatives + ;; so that the digit of a given alternative never varies. + (setq next-digit (1+ next-digit))) + (insert "\nC-g =3D Quit") + (goto-char (point-min)) + (forward-line)) + (or some-choice-enabled + (error "None of the choices is currently meaningful")) + (save-window-excursion + ;; Select window to be able to scroll it from minibuffer + (with-selected-window + (display-buffer (get-buffer " widget-choose") + '(display-buffer-in-direction + (direction . bottom) + (window-height . fit-window-to-buffe= r))) + (setq value (read-char-choice + (format "%s: " title) + (mapcar #'car alist))))) + (cdr (assoc value alist))))))) ;;; Widget text specifications. ;; --=-=-=-- From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman , Mauro Aranda , Stefan Monnier Cc: 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168667178612296 (code B ref 64046); Tue, 13 Jun 2023 15:57:02 +0000 Received: (at 64046) by debbugs.gnu.org; 13 Jun 2023 15:56:26 +0000 Received: from localhost ([127.0.0.1]:42823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q96Ne-0003CF-5l for submit@debbugs.gnu.org; Tue, 13 Jun 2023 11:56:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q96Nc-0003C3-CI for 64046@debbugs.gnu.org; Tue, 13 Jun 2023 11:56:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q96NW-0002xK-FN; Tue, 13 Jun 2023 11:56:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ocQ2vxtlTmPx57K6kGnDAspWwGTet4YlelE0ThvWLbE=; b=hhVoP9PaOX1LesZRzqBT ujzdiZ5QGG2V84Jedd9QzdcgtJiDb5qdRItg8V8Ou2Hbi/OSdekQAF4PDK7SFQkrAebcgFx8GIglE /4h2bk9ZO14fiwQaus6RfBUjBKA9X7UdQqWmQC50pjB7+eB7UHkHZPK1hDNkpIXDHq+4ILYqMbewg SIqU+pk5lej1+gEjM59e7pRL2HJgXyM2SGzbYs7Da0+kIam/ySHl9krE8rLeW+cmff6FPYC5OJlDB qHg2hPU4DhLZylteL4bMnP2JLQN0RSf/ebOidzrguJWguaKkaS3BQaFtydZ61BZ8uKcxaKe6tBqTf kzsRZxJyAGItkQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q96NV-00086n-VM; Tue, 13 Jun 2023 11:56:18 -0400 Date: Tue, 13 Jun 2023 18:56:36 +0300 Message-Id: <837cs7we2z.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87v8frihny.fsf@gmx.net> (message from Stephen Berman on Tue, 13 Jun 2023 16:02:57 +0200) References: <87v8frihny.fsf@gmx.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stephen Berman > Date: Tue, 13 Jun 2023 16:02:57 +0200 > > 0. emacs -Q > 1. Evaluate the following defcustom: > (defcustom my-test "a" > "Test." > :type '(choice (string :tag "Use `a'" "a") > (string :tag "Use `b'" "b"))) > 2. M-x customize-option RET my-test RET > 3. In the buffer *Customize Option: My Test* note that in the string > "Use ‘a’" following the "Value Menu" button the quote marks are in > the "curve" style (‘’). > 4. Put point on the "Value Menu" button and type RET. > 5. The buffer " widget-choose" contains these lines: > 0 = Use ‘a’ > 1 = Use ‘b’ > Note that the quote marks in this buffer are also in the "curve" > style. > 6. With the mouse pointer over the "Value Menu" button press mouse-1, > popping up a menu titled "Choice" containing these items: > Use `a' > Use `b' > Note that the quote marks in this menu are in the "grave" style (`') > instead of the "curve" style. > > The use of the "curve" style in the " widget-choose" buffer is due to > commit bd3b426ebb7a60045839e97c9da9bfd249fab1f1, but that commit did not > take popup menus into account. The attached patch does so. Since the > status quo ante long predates emacs-29 and this is just a stylistic bug, > I made the patch against master. > > In this patch I chose to apply substitute-command-keys just once at the > beginning of the function `widget-choose', rather than several times > within the function, but I restricted its application to item tags, so > other uses of the ITEMS argument should not be affected (and my brief > testing hasn't found any problem with the patch). > > The patch also takes the opportunity to replace two unnecessary uses of > `let*' in `widget-choose', in one case by `let' and in the other by > foregoing let-bound variables altogether and just using the values in > place, since they occur only once each in the lines immediately > following the eliminated `let*'. Thanks. I'm not familiar very well with widgets code, so I added Mauro and Stefan to the discussion, in the hope that they will have useful comments. From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jun 2023 19:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Stephen Berman , Stefan Monnier , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168677227411122 (code B ref 64046); Wed, 14 Jun 2023 19:52:02 +0000 Received: (at 64046) by debbugs.gnu.org; 14 Jun 2023 19:51:14 +0000 Received: from localhost ([127.0.0.1]:45508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9WWQ-0002tK-4e for submit@debbugs.gnu.org; Wed, 14 Jun 2023 15:51:14 -0400 Received: from mail-oo1-f44.google.com ([209.85.161.44]:51393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9WWO-0002t5-EE for 64046@debbugs.gnu.org; Wed, 14 Jun 2023 15:51:13 -0400 Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-558cb7f201cso886527eaf.2 for <64046@debbugs.gnu.org>; Wed, 14 Jun 2023 12:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686772267; x=1689364267; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ggrwhRhyGFNa2ZfuD0OnVEUv66zZ6cXbM8vMwPKFnXw=; b=Mx4dOSNqg4H7/iWerEsCuGheIzYVXX69x9f5wAtvfAc32YVNv+UezM6st6csG8/Wc/ 8FpLM/peunfXmn7t/whXG2w2D3hRpRcChJ7nIrWE9CK/Arz6H/IPXZUYLrp06Z8ma6Lx wtjn1KzWRfe6o0b1glJCtEU5G2NizKjw4hDU9Y/zRtljmn2J3zqcFHkq9a1JALgbK4yF OE+20O/pEcoPY7ArAzylpNGmRIeBS7AJ2J1qy7YQkbETlduZXNJST7FM/V/zyQfCWQaP 4YXRkrFNZKOyn070SbIiFwJtI4ZNOyFrIXpuF3sg83wx24nzOwbQA90Y0ZnwTT4utlIo jFdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686772267; x=1689364267; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ggrwhRhyGFNa2ZfuD0OnVEUv66zZ6cXbM8vMwPKFnXw=; b=gpMfkxJSnDITbILThzLM0sIrLTGqI9tBhwUZYMf0wxv1/bjR5ybufCReIcrFsFGak3 bvBKnKI7aAOxro+DBrEROoMSgWwlpfAZ6kJKCHaFI86hF/senFaIhT/lwQX3SjZVrl1S qUsOmK73tYrs48tFVP5FYWckDjzE3lDvMXqGo3TDGpKg3ZdfaMwEN2oGjaKxTGKjLhyU 9OUpOXZW2K6f6B3QIV5/MyWamWwWcjVpExLYvQ3Zx/f2wHQGx9dgsSWbd6ejbN3pN98G VZfln8z2LlYkkysnNTaGEPmlbHG0qSL3rVfqi+o9Y49PxCO6HX8LqRfxiaRZupiSE1uX MpHw== X-Gm-Message-State: AC+VfDyveDWWLvQGzRTCfyofP84e4dRtOV25NsuHre4LboEJtR779DM0 Fa0kZAKOqztRa77yhWW7Nng= X-Google-Smtp-Source: ACHHUZ4OClroSH8zZx1FdQpa1IAshrcm/Pb4XKXsb2S+N0CSYG4zyQtz1Vhuj6A1XXgkffNzlDvZkQ== X-Received: by 2002:a4a:dccc:0:b0:54b:ce85:490a with SMTP id h12-20020a4adccc000000b0054bce85490amr10435397oou.0.1686772266605; Wed, 14 Jun 2023 12:51:06 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id q8-20020a4a3308000000b0055c35007b65sm2121346ooq.12.2023.06.14.12.51.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 12:51:06 -0700 (PDT) Message-ID: Date: Wed, 14 Jun 2023 16:51:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 References: <87v8frihny.fsf@gmx.net> <837cs7we2z.fsf@gnu.org> Content-Language: en-US From: Mauro Aranda In-Reply-To: <837cs7we2z.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Eli Zaretskii writes: > Thanks.  I'm not familiar very well with widgets code, so I added > Mauro and Stefan to the discussion, in the hope that they will have > useful comments. Thanks for CCing me Eli.  I'll take a look. From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jun 2023 20:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: Eli Zaretskii , Stefan Monnier , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168677314312604 (code B ref 64046); Wed, 14 Jun 2023 20:06:01 +0000 Received: (at 64046) by debbugs.gnu.org; 14 Jun 2023 20:05:43 +0000 Received: from localhost ([127.0.0.1]:45520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9WkQ-0003HE-S8 for submit@debbugs.gnu.org; Wed, 14 Jun 2023 16:05:43 -0400 Received: from mail-oa1-f46.google.com ([209.85.160.46]:49511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9WkP-0003H1-E5 for 64046@debbugs.gnu.org; Wed, 14 Jun 2023 16:05:41 -0400 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1a994308bc6so232222fac.3 for <64046@debbugs.gnu.org>; Wed, 14 Jun 2023 13:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686773136; x=1689365136; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XwWrQyUE3VspgjU286ziWRZhBuVJ8mTbQDrH6Eyi5+w=; b=Z/W3ZHMRl5PsyYTC2EpB07OzlICeifFiS0p2LcV16irpk+qSzhW2YGXzn6tWseZ3aY XgHlHfLy1XEbIcQRAdPiETSOZeXYUzPJa0rEb8DEYXGvY98LQ8MGIsgWI6FnMgWs0dO5 KapYVTI7JnJjXoVShuVvkxoGTqoLYQljcblReba8rsZap0EAmn54aBgQIN+qNp0vE2jD nXJtxyGQI4s8o1D7SbQ8P6JTe7VbwJyyKyoPFN0TVlxa1JkhVB4+FcZuhpCI+hiSTSQr IHgUskhAC3iiYS1Ul5Mm64R7HVBFgnUTOfMLxk9Ed53VTTrTYKKkSFgTlQoM+EHKLLCL pEEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686773136; x=1689365136; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XwWrQyUE3VspgjU286ziWRZhBuVJ8mTbQDrH6Eyi5+w=; b=R+ZHTaxLgvvR8WZLqJd8gNXfbBY1k2MV3LANtLm/q2R7f5P7dx7e8KULiCZahXDoeZ hEZauIgxZcHzagEFBaT0Ij6PdPrgemmFpY+iXyCqObmt7nSiLDcr8YtWbNTPgb0IcZxt FEyjM2FuLiGRTyi2rRN8r/Cztf7qBjo1ADqrkkQ3PspqwDUU1IE9qiKpqnjGDeUi436W gmGHDlOHICtrAnkzy4Rc2zh1sbLvf1CcXBLn//vIslbA8YVMmJnpC1glPLuvnsLPVHo1 lmHLWFrk/or95JtdDpEVy7SPMq8U4ZOYLi3ymHoC0CTrXs6XRvl+3+fyaMpnX1KXPxKQ EK2A== X-Gm-Message-State: AC+VfDyc5jwrsKBzCKZpJENkCcEqM3K4Seb2d2HXhHSnuNzEFYn8caHe 3ehjK/7s0vHYs260ESeKxX8= X-Google-Smtp-Source: ACHHUZ5KInMXOKl7NqOeNdcHswszb9/jWPRz3D46jItM93n0scMLMewoF8lt00gT97ASFEPgNc2DYA== X-Received: by 2002:a05:6870:c788:b0:1a7:5726:a52b with SMTP id dy8-20020a056870c78800b001a75726a52bmr1945458oab.52.1686773135840; Wed, 14 Jun 2023 13:05:35 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id ne16-20020a056871449000b0019f4f5c8298sm9127546oab.56.2023.06.14.13.05.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 13:05:35 -0700 (PDT) Message-ID: <47e13491-1654-db22-2f8b-f12195953232@gmail.com> Date: Wed, 14 Jun 2023 17:05:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US References: <87v8frihny.fsf@gmx.net> <837cs7we2z.fsf@gnu.org> From: Mauro Aranda In-Reply-To: <837cs7we2z.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Stephen Berman writes: > 0. emacs -Q > 1. Evaluate the following defcustom: >    (defcustom my-test "a" >      "Test." >      :type '(choice (string :tag "Use `a'" "a") >                (string :tag "Use `b'" "b"))) > 2. M-x customize-option RET my-test RET > 3. In the buffer *Customize Option: My Test* note that in the string >    "Use ‘a’" following the "Value Menu" button the quote marks are in >    the "curve" style (‘’). > 4. Put point on the "Value Menu" button and type RET. > 5. The buffer " widget-choose" contains these lines: >    0 = Use ‘a’ >    1 = Use ‘b’ >    Note that the quote marks in this buffer are also in the "curve" >    style. > 6. With the mouse pointer over the "Value Menu" button press mouse-1, >    popping up a menu titled "Choice" containing these items: >    Use `a' >    Use `b' >    Note that the quote marks in this menu are in the "grave" style (`') >    instead of the "curve" style. > > The use of the "curve" style in the " widget-choose" buffer is due to > commit bd3b426ebb7a60045839e97c9da9bfd249fab1f1, but that commit did not > take popup menus into account.  The attached patch does so. Since the > status quo ante long predates emacs-29 and this is just a stylistic bug, > I made the patch against master. > > In this patch I chose to apply substitute-command-keys just once at the > beginning of the function `widget-choose', rather than several times > within the function, but I restricted its application to item tags, so > other uses of the ITEMS argument should not be affected (and my brief > testing hasn't found any problem with the patch). By moving the call to substitute-command-keys to the beginning, extended menus simplified with widget--simplify-menu don't benefit anymore from it.  Perhaps that won't ever show up as a problem, but I think we should guard against that. To do that, maybe widget--simplify-menu can call substitute-command-keys when it builds the simplified menu. From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jun 2023 11:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: Eli Zaretskii , Stefan Monnier , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.16868291897252 (code B ref 64046); Thu, 15 Jun 2023 11:40:01 +0000 Received: (at 64046) by debbugs.gnu.org; 15 Jun 2023 11:39:49 +0000 Received: from localhost ([127.0.0.1]:46306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9lKO-0001su-An for submit@debbugs.gnu.org; Thu, 15 Jun 2023 07:39:48 -0400 Received: from mout.gmx.net ([212.227.17.21]:38245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9lKL-0001sg-OA for 64046@debbugs.gnu.org; Thu, 15 Jun 2023 07:39:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1686829176; x=1687433976; i=stephen.berman@gmx.net; bh=Hy+5JGTqKC7MavSzSfTQy2C28xWdvWj6MALpBFS36o8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=a+z5FE4WJUOOdOqFTWTKW6+gf93KBkaEQPbNLxpEySR9YDAs8vFzMXykSdd2imS1pdBA6Bx ffQFpzjaqYqUF2JuCZEmOPyMwAKJJ6tN3Yt1fB6mfLPo2eWCLQ6fOwtliTL7V4hoNcfEXZfAo /2RVNenHtLaf6YNUrlinadzUksfr7J76ag749n91KJpAU2ZrJoLwzU/7kVyavpy2s+4cSB9li mJm4i2pVXJm+ptJAiKTbu7trsgx2EDPKiSsrUj+0jTJgbjK9GICYwWqJT4snRUtkem4drEPC6 9UFmBUmE8TaQa5dyX8Rx2dEfi553gIQJg9XnXG0hSP5z/+/6lbHg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([94.134.196.158]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N1wll-1pyn2X12nB-012LJN; Thu, 15 Jun 2023 13:39:36 +0200 From: Stephen Berman In-Reply-To: <47e13491-1654-db22-2f8b-f12195953232@gmail.com> (Mauro Aranda's message of "Wed, 14 Jun 2023 17:05:32 -0300") References: <87v8frihny.fsf@gmx.net> <837cs7we2z.fsf@gnu.org> <47e13491-1654-db22-2f8b-f12195953232@gmail.com> Date: Thu, 15 Jun 2023 13:39:34 +0200 Message-ID: <87o7lhrm2x.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:urEoVPL8rz+Jd+W5mrnvA+Sn5J8ha/2/0ryfAzVrrROt/nNXy/K CmJtQhSG9Tklyx21FnzfrVpd4mWGmu1dr3AY1lEWizdyqHE+Fwj61uvnkmcSft3kIaEXrWs AHvIiTr3cty6C+1AdCvbZIG19pBqO9dfBOxfMSSpne0Qo6wwMCj6DfrZWzkMcPUAvYebaHY VhS2Z7OYLr7qYI9IpJu7Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:7xLDO7gVsqw=;zY2UnOxTNLrWyxD0LgLDi+2iQ+M v9GdDzuMkzJL2STrdVDBnN3YJEaXfySmNUJHbtUP2D5eE0/2JN8kHBCOqyNeH1O7RwXrxErFN hxP3ksqTLSpPMVhAD8k0/b/XdQDKbHDJ/N5psCp3Q8DmtPYv4Qso8f0EGWCVUCK8DaBzHji9z z8GUSYwGLCprimFuDmjwHx7q782yZOabGjpaeTKB2RnIrQ4FOn5ji2kGIuPF8KTSEfctmT8YP 0TY5555Z5PbpTiylPT3xNNWr7QiRQcShx8hNb/1e3f3xbpsAiSNF8vx+DQenTX7ORiXzup50A EAmXT7PRHQnB78vPimA8SFl9q9McccWlYmofNUz7jM9OVccvaM4H0X9E+M48/LAoVMkHzfkg5 /9s99EYdD+KWb6yEDTf5areIlYZlvT+Hr7knKwNsxDKSptXMmDE5HwaEYeRYMvxwgy1/VWQ1r JiL4loyPBQOpkMlYlbvOmQOF2VaH2G+nwhd+74GFoyTb9hDwGvTSqDNMQuoTlHJPlF2KUdjs6 qOj4ZlO6JMzTT/4p4axWsbPpEoJ1w628GJL7+9JEe15TuD+3slGW974iQG3bvpK88pF6t+e0j y8/0QbpL/1EbEbqR1dchnKOVJvvig0qBmajq9QTHLaf3lEU1QM8Z3YBSY/XvX/Wx6ol6HjAxj ZLstAazUToJWDX+r5/DVH8tERfi8EpLREZFAEOP5terBZVHWcbynx2tiXvgv1cVznqwoOs/3w ER/SxxCJ+2GvWxBAYRfGY7F1z6xgFzWF4VBfiNHQGSA5aqSS6oYbo8UI+fpK7vMH7lks9AnZj MgO8K2pxIiJ3mz6byWIDWHYEvVkNGMv5heCc6rtFjSwc8XSE+drUJAzQIttGyqDSKGGjTvwGP R2EKbu9YAqVneYBVkEV8xy0OnwTNMkacqTyXFH7qL+IaKDD1MO8PyQNkk5NvXLePyijwdbMj8 jp4GaIQ4HdFAmRliV03VUXTHVu4= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, 14 Jun 2023 17:05:32 -0300 Mauro Aranda wr= ote: > Stephen Berman writes: > >> 0. emacs -Q >> 1. Evaluate the following defcustom: >>=C2=A0=C2=A0=C2=A0 (defcustom my-test "a" >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Test." >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 :type '(choice (string :tag "Use `a'" "a") >>=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2= =A0 (string :tag "Use `b'" "b"))) >> 2. M-x customize-option RET my-test RET >> 3. In the buffer *Customize Option: My Test* note that in the string >>=C2=A0=C2=A0=C2=A0 "Use =E2=80=98a=E2=80=99" following the "Value Menu" b= utton the quote marks are in >>=C2=A0=C2=A0=C2=A0 the "curve" style (=E2=80=98=E2=80=99). >> 4. Put point on the "Value Menu" button and type RET. >> 5. The buffer " widget-choose" contains these lines: >>=C2=A0=C2=A0=C2=A0 0 =3D Use =E2=80=98a=E2=80=99 >>=C2=A0=C2=A0=C2=A0 1 =3D Use =E2=80=98b=E2=80=99 >>=C2=A0=C2=A0=C2=A0 Note that the quote marks in this buffer are also in t= he "curve" >>=C2=A0=C2=A0=C2=A0 style. >> 6. With the mouse pointer over the "Value Menu" button press mouse-1, >>=C2=A0=C2=A0=C2=A0 popping up a menu titled "Choice" containing these ite= ms: >>=C2=A0=C2=A0=C2=A0 Use `a' >>=C2=A0=C2=A0=C2=A0 Use `b' >>=C2=A0=C2=A0=C2=A0 Note that the quote marks in this menu are in the "gra= ve" style (`') >>=C2=A0=C2=A0=C2=A0 instead of the "curve" style. >> >> The use of the "curve" style in the " widget-choose" buffer is due to >> commit bd3b426ebb7a60045839e97c9da9bfd249fab1f1, but that commit did not >> take popup menus into account.=C2=A0 The attached patch does so. Since t= he >> status quo ante long predates emacs-29 and this is just a stylistic bug, >> I made the patch against master. >> >> In this patch I chose to apply substitute-command-keys just once at the >> beginning of the function `widget-choose', rather than several times >> within the function, but I restricted its application to item tags, so >> other uses of the ITEMS argument should not be affected (and my brief >> testing hasn't found any problem with the patch). > > By moving the call to substitute-command-keys to the beginning, extended > menus simplified with widget--simplify-menu don't benefit anymore from > it.=C2=A0 Perhaps that won't ever show up as a problem, but I think we sh= ould > guard against that. > > To do that, maybe widget--simplify-menu can call substitute-command-keys > when it builds the simplified menu. Thanks for the feedback. You're right, that patch is too superficial; it also fails to do substitution in popup extended menus like the one produced by clicking the "State" button, with the result that in the item "Revert This Session's Customization" the apostrophe is not displayed in the "curve" style. So I revised the patch, attached below, to iterate over the elements of each item in ITEMS, and it now appears to handle substitution with the "State" button display correctly, both as popup menu and as text menu buffer. The latter is the result of applying widget--simplify-menu, if I debugged correctly, so I think this answers your concerns (though the text menu buffer already shows the substitution independently of my patch, due to commit bd3b426ebb). Or have I misunderstood your concerns about widget--simplify-menu? If so, can you give an example where the new patch fails? Steve Berman --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: widget-choose patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index cafd0ad0a4d..234f3d9b74d 100644 =2D-- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -281,71 +281,79 @@ widget-choose If ITEMS has simple item definitions, then this function returns the VALU= E of the chosen element. If ITEMS is a keymap, then the return value is the s= ymbol in the key vector, as in the argument of `define-key'." - (cond ((and (< (length items) widget-menu-max-size) - event (display-popup-menus-p)) - ;; Mouse click. - (if (keymapp items) - ;; Modify the keymap prompt, and then restore the old one, i= f any. - (let ((prompt (keymap-prompt items))) - (unwind-protect - (progn - (setq items (delete prompt items)) - (push title (cdr items)) - ;; Return just the first element of the list of even= ts. - (car (x-popup-menu event items))) - (setq items (delete title items)) - (when prompt - (push prompt (cdr items))))) - (x-popup-menu event (list title (cons "" items))))) - ((or widget-menu-minibuffer-flag - (> (length items) widget-menu-max-shortcuts)) - (when (keymapp items) - (setq items (widget--simplify-menu items))) - ;; Read the choice of name from the minibuffer. - (setq items (cl-remove-if 'stringp items)) - (let ((val (completing-read (concat title ": ") items nil t))) - (if (stringp val) - (let ((try (try-completion val items))) - (when (stringp try) - (setq val try)) - (cdr (assoc val items)))))) - (t - (when (keymapp items) - (setq items (widget--simplify-menu items))) - ;; Construct a menu of the choices - ;; and then use it for prompting for a single character. - (let* ((next-digit ?0) - alist choice some-choice-enabled value) - (with-current-buffer (get-buffer-create " widget-choose") - (erase-buffer) - (insert "Available choices:\n\n") - (while items - (setq choice (pop items)) - (when (consp choice) - (let* ((name (substitute-command-keys (car choice))) - (function (cdr choice))) - (insert (format "%c =3D %s\n" next-digit name)) - (push (cons next-digit function) alist) - (setq some-choice-enabled t))) - ;; Allocate digits to disabled alternatives - ;; so that the digit of a given alternative never varies. - (setq next-digit (1+ next-digit))) - (insert "\nC-g =3D Quit") - (goto-char (point-min)) - (forward-line)) - (or some-choice-enabled - (error "None of the choices is currently meaningful")) - (save-window-excursion - ;; Select window to be able to scroll it from minibuffer - (with-selected-window - (display-buffer (get-buffer " widget-choose") - '(display-buffer-in-direction - (direction . bottom) - (window-height . fit-window-to-buffer)= )) - (setq value (read-char-choice - (format "%s: " title) - (mapcar #'car alist))))) - (cdr (assoc value alist)))))) + ;; Apply quote substitution to customize choice menu item text, + ;; whether it occurs in a widget buffer or in a popup menu. + (let ((items (mapc (lambda (x) + (when (consp x) + (dotimes (i (1- (length x))) + (when (char-or-string-p (nth i x)) + (setcar (nthcdr i x) + (substitute-command-keys + (car (nthcdr i x)))))))) + items))) + (cond ((and (< (length items) widget-menu-max-size) + event (display-popup-menus-p)) + ;; Mouse click. + (if (keymapp items) + ;; Modify the keymap prompt, and then restore the old one,= if any. + (let ((prompt (keymap-prompt items))) + (unwind-protect + (progn + (setq items (delete prompt items)) + (push title (cdr items)) + ;; Return just the first element of the list of ev= ents. + (car (x-popup-menu event items))) + (setq items (delete title items)) + (when prompt + (push prompt (cdr items))))) + (x-popup-menu event (list title (cons "" items))))) + ((or widget-menu-minibuffer-flag + (> (length items) widget-menu-max-shortcuts)) + (when (keymapp items) + (setq items (widget--simplify-menu items))) + ;; Read the choice of name from the minibuffer. + (setq items (cl-remove-if 'stringp items)) + (let ((val (completing-read (concat title ": ") items nil t))) + (if (stringp val) + (let ((try (try-completion val items))) + (when (stringp try) + (setq val try)) + (cdr (assoc val items)))))) + (t + (when (keymapp items) + (setq items (widget--simplify-menu items))) + ;; Construct a menu of the choices + ;; and then use it for prompting for a single character. + (let ((next-digit ?0) + alist choice some-choice-enabled value) + (with-current-buffer (get-buffer-create " widget-choose") + (erase-buffer) + (insert "Available choices:\n\n") + (while items + (setq choice (pop items)) + (when (consp choice) + (insert (format "%c =3D %s\n" next-digit (car choice))= ) + (push (cons next-digit (cdr choice)) alist) + (setq some-choice-enabled t)) + ;; Allocate digits to disabled alternatives + ;; so that the digit of a given alternative never varies. + (setq next-digit (1+ next-digit))) + (insert "\nC-g =3D Quit") + (goto-char (point-min)) + (forward-line)) + (or some-choice-enabled + (error "None of the choices is currently meaningful")) + (save-window-excursion + ;; Select window to be able to scroll it from minibuffer + (with-selected-window + (display-buffer (get-buffer " widget-choose") + '(display-buffer-in-direction + (direction . bottom) + (window-height . fit-window-to-buffe= r))) + (setq value (read-char-choice + (format "%s: " title) + (mapcar #'car alist))))) + (cdr (assoc value alist))))))) ;;; Widget text specifications. ;; --=-=-=-- From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Jun 2023 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: Eli Zaretskii , Stefan Monnier , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168746449727119 (code B ref 64046); Thu, 22 Jun 2023 20:09:02 +0000 Received: (at 64046) by debbugs.gnu.org; 22 Jun 2023 20:08:17 +0000 Received: from localhost ([127.0.0.1]:36848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCQbI-00073K-NJ for submit@debbugs.gnu.org; Thu, 22 Jun 2023 16:08:17 -0400 Received: from mout.gmx.net ([212.227.17.20]:54061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCQbH-000738-Ct for 64046@debbugs.gnu.org; Thu, 22 Jun 2023 16:08:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1687464486; x=1688069286; i=stephen.berman@gmx.net; bh=SF3jwiQdqfY+yb01XbjPBBNe9xRLWdSOqLPF3C8zz38=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=R+n9kv0WuMx8p75fUsBzGfv0CGYg/zIYDHMYyR/SwHIF4UhHUUKmwAEBzDHTcWh+wPKYXYh He3Lhvy/Ad6WLmb1HMdfQeCGB3FKn1+bTGpnNuNsW9ZdsbL+lmxSfkI1bt+IaF8zcMLz9AdfD MU6AP3oA4H34D7w9Z3x8/v4DE8Mb+jXCP9eiVg/BmstflrQ38Fj/0Fbs0LT+pncZ7nAg9DE3a icGuoGTJe/yr1BJkROl7ykc1nGQ0QgdVn13gsgRwf085CQ9NZaaFH4hU5Ceca8svZmlS5UaWc 5yjS/qCRrhWd6dYhU1vR8QNIt4vcl5ApptAWE8dIlUzivZh5jByg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([89.246.37.91]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mi2Jt-1pYzFU43hx-00e3EY; Thu, 22 Jun 2023 22:08:06 +0200 From: Stephen Berman In-Reply-To: <87o7lhrm2x.fsf@gmx.net> (Stephen Berman's message of "Thu, 15 Jun 2023 13:39:34 +0200") References: <87v8frihny.fsf@gmx.net> <837cs7we2z.fsf@gnu.org> <47e13491-1654-db22-2f8b-f12195953232@gmail.com> <87o7lhrm2x.fsf@gmx.net> Date: Thu, 22 Jun 2023 22:07:32 +0200 Message-ID: <87edm3tg57.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:kJwJiwBGTCKnV9Ck2Ux3afkUZM/NeJ58RhotWl3n10BMcaYFzWM SjDP9wmbKiXC67FfFWS/QgGNtbcGLMlme8IokIEm7ff+YRZ/rnRBQzxKgHieRaNL3WdtpZd 3IHX0vhNcknt+fQLRm4LkjAIpBrZvrD15tr1BEeLPNflklWkmJZ5Aj27T/OM2Ra+HNPG1Pv UFj4RwQabC8hz0JQviHQg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:HMTLWvTdgfg=;eDp6xnhbfqaeuaIEagFyvRMzKuv fRje13g2ECac1Oy9qGx7sNVKbhkGb6BhHydHl3f6SaNLHNUa5KWY1wJpMeEEC7lAjFRIHvuAl ZtOmoqWxgmePu+9BXmdLrLkMDKYGR2viQ77H9R3cnPrUNmNy/dSGkgEzlcX/iV2HfLwPb4bhs 279OgEPO6ithAH6lXOJiS2FDjGUTV2uf43Hueok1GgL7xAo2gbyWn4HZOrRb9xeK4+kt/NRK5 iLMPodYtzb3DFOPcgif7TQsB14LYt/y8TqVyuo0Y4a1IFDyUQg3uzjqaoDYwiOyWF5YqKI5eF AmmfLxu/9+Nq/Ulp0Y6Uy2n58YgQIf/ja5PNRtFS72vQJnWeCRT43p9bqEtNbQYM0C9coAVmO 5qEG9eLwsM+uCa0R9e6cz1w5ALH6MyzIsLsnRkPxEDk9AFuojK+U4D3mxzBIMmY6wdIYraKsK Dmho1hoa+t7pCO4/Qid/OX4lZIp3OEZX1+dcfiZu9yqv+LWhLYdPIEjVmKtJaa657g2yVkWxS vNAbsk5l3JvKks5A0UKFvlebUDPiX+eRjoZv9Y6GojgTQl/289+3q2SmkyohRe/9++FthFC+a NeEVRC9JWFEe2oq1eqzCS6vLVxHJh40Cd02x5GRiZ3a9DZTq6eCYCjtqu9Xa2xpXm9NscEzmR WeKE04+WS0UlQAEe46fd7D1P0bTsJrrGfu4ay4fWH5ve6k3J6WBfLg1dhdGEG1K+qu5cIjZNN ESE41TxjrNoWlP6J8H3ojRfsKQJ4AeZuPIlxYxS+vEgKZOtWGnZgFjPsKsIy1ISgEHqB9r9lJ 8b+H+XV51iTklkxGS2xNY2aL8oXjzij65MX2yPQm+NnqG5nwBIc4FDEPC/4Qrd8U5KF8iRt7Q MWSnNHkICIzztOWYRn9bRJ8PoUDgwfXVWQTdW6HxZ1dhPHCmLDOD+QfSzlebJPoVXEXszZydb 00SL3bNaWrBkYVkqasJh3L7AmEg= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, 15 Jun 2023 13:39:34 +0200 Stephen Berman = wrote: > On Wed, 14 Jun 2023 17:05:32 -0300 Mauro Aranda = wrote: > >> Stephen Berman writes: >> >>> 0. emacs -Q >>> 1. Evaluate the following defcustom: >>>=C2=A0=C2=A0=C2=A0 (defcustom my-test "a" >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Test." >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 :type '(choice (string :tag "Use `a'" "a") >>>=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2= =A0 (string :tag "Use `b'" "b"))) >>> 2. M-x customize-option RET my-test RET >>> 3. In the buffer *Customize Option: My Test* note that in the string >>>=C2=A0=C2=A0=C2=A0 "Use =E2=80=98a=E2=80=99" following the "Value Menu" = button the quote marks are in >>>=C2=A0=C2=A0=C2=A0 the "curve" style (=E2=80=98=E2=80=99). >>> 4. Put point on the "Value Menu" button and type RET. >>> 5. The buffer " widget-choose" contains these lines: >>>=C2=A0=C2=A0=C2=A0 0 =3D Use =E2=80=98a=E2=80=99 >>>=C2=A0=C2=A0=C2=A0 1 =3D Use =E2=80=98b=E2=80=99 >>>=C2=A0=C2=A0=C2=A0 Note that the quote marks in this buffer are also in = the "curve" >>>=C2=A0=C2=A0=C2=A0 style. >>> 6. With the mouse pointer over the "Value Menu" button press mouse-1, >>>=C2=A0=C2=A0=C2=A0 popping up a menu titled "Choice" containing these it= ems: >>>=C2=A0=C2=A0=C2=A0 Use `a' >>>=C2=A0=C2=A0=C2=A0 Use `b' >>>=C2=A0=C2=A0=C2=A0 Note that the quote marks in this menu are in the "gr= ave" style (`') >>>=C2=A0=C2=A0=C2=A0 instead of the "curve" style. >>> >>> The use of the "curve" style in the " widget-choose" buffer is due to >>> commit bd3b426ebb7a60045839e97c9da9bfd249fab1f1, but that commit did not >>> take popup menus into account.=C2=A0 The attached patch does so. Since = the >>> status quo ante long predates emacs-29 and this is just a stylistic bug, >>> I made the patch against master. >>> >>> In this patch I chose to apply substitute-command-keys just once at the >>> beginning of the function `widget-choose', rather than several times >>> within the function, but I restricted its application to item tags, so >>> other uses of the ITEMS argument should not be affected (and my brief >>> testing hasn't found any problem with the patch). >> >> By moving the call to substitute-command-keys to the beginning, extended >> menus simplified with widget--simplify-menu don't benefit anymore from >> it.=C2=A0 Perhaps that won't ever show up as a problem, but I think we s= hould >> guard against that. >> >> To do that, maybe widget--simplify-menu can call substitute-command-keys >> when it builds the simplified menu. > > Thanks for the feedback. You're right, that patch is too superficial; > it also fails to do substitution in popup extended menus like the one > produced by clicking the "State" button, with the result that in the > item "Revert This Session's Customization" the apostrophe is not > displayed in the "curve" style. So I revised the patch, attached below, > to iterate over the elements of each item in ITEMS, and it now appears > to handle substitution with the "State" button display correctly, both > as popup menu and as text menu buffer. The latter is the result of > applying widget--simplify-menu, if I debugged correctly, so I think this > answers your concerns (though the text menu buffer already shows the > substitution independently of my patch, due to commit bd3b426ebb). Or > have I misunderstood your concerns about widget--simplify-menu? If so, > can you give an example where the new patch fails? Just pinging in case this fell under the radar. If there's no response, what's the next step forward? Steve Berman From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Jun 2023 23:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: Eli Zaretskii , Stefan Monnier , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168747477911925 (code B ref 64046); Thu, 22 Jun 2023 23:00:02 +0000 Received: (at 64046) by debbugs.gnu.org; 22 Jun 2023 22:59:39 +0000 Received: from localhost ([127.0.0.1]:36957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCTH8-00036H-M3 for submit@debbugs.gnu.org; Thu, 22 Jun 2023 18:59:38 -0400 Received: from mail-oo1-f41.google.com ([209.85.161.41]:51313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCTH6-000364-Un for 64046@debbugs.gnu.org; Thu, 22 Jun 2023 18:59:37 -0400 Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-560a7ce5823so39941eaf.2 for <64046@debbugs.gnu.org>; Thu, 22 Jun 2023 15:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687474771; x=1690066771; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xC8L0j8XyLle2uZRmWguOsVmYVWf5jK1ScYtXsNreRc=; b=eB6NA170uUH99j4BynwDjQ2hwuVmFi9MqU/3XxcRTK0S3PJbfav0VxWTJ4ICg2C6jP sS9zqKs0JZf0yUI6Yafyxdgycfucn5t76lwdyPRdrJyclYeAL53qyM617Vq94rwOw8OO lh10W3QWyCUqegxEK9KO+W+g4Xni8V9pk7Ut0GDZUfnloo65HdsxNp215rJ5zEt7lZDX QPUSJKM/OKQH1C3Qi18jnIC6/kT5cuw0S43p2w1IhSG8F9sq8HaDweOYwCC12YdpCsUz kKzLm4Ylp+YFkXa/WPzCTEvGhuOrTdPw+SylU+yBTdBjY56PGgwD50Qh/cO91QRr1ISj gitQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687474771; x=1690066771; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xC8L0j8XyLle2uZRmWguOsVmYVWf5jK1ScYtXsNreRc=; b=IIi1jFT3DCFmPgbnbGCarrXRrDk2xVrKUQQj65/dEpi0hRT3C7eI4WlvpFFq1BWZmm Jn5j5BHQaa0RvScbh9fEh/h76yQtnts2rEPQuCpTPdDsBrqnQiM6QZGhrEgMF5pVcUna YmNeprcyia7pymyKGRcd+hk/Mt/3lZP4N6sN31QwR1OHEGSAyMwf2tJthUnMlDcfSY2y 0JxGjJYrPlhnmEDgBpRlFKPG+zxN26Oxmg+T9p/DdTrxUbZ7cK8/jS0Sv0dPIIa6tISy 7sHSBfv73rHMcOB+pPn2VmoIucpsr17Ky/9B+UqL8GmfrBeHDv0rSYbIhV8HpkN4xR0E nnjw== X-Gm-Message-State: AC+VfDw5F5QR5upT0e8TINZRAcSNtEin26dacsxK6Uo3kC+8ORO7b6Pk nZjSFvZrgOEIGZQuvvHrFFU= X-Google-Smtp-Source: ACHHUZ4VgUcl6/Y4Y52Dd/nlbuYYREB4PV+STOze18Y789chGb2NqoE6OJyYvHTaJPa12TzSLJR9IQ== X-Received: by 2002:a4a:d387:0:b0:558:aadb:a81 with SMTP id i7-20020a4ad387000000b00558aadb0a81mr14635996oos.4.1687474770995; Thu, 22 Jun 2023 15:59:30 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id bi5-20020a05682008c500b0055891855e28sm3154885oob.37.2023.06.22.15.59.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jun 2023 15:59:30 -0700 (PDT) Message-ID: <613827fd-46e8-b8e8-dd91-1539f007a099@gmail.com> Date: Thu, 22 Jun 2023 19:59:26 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 References: <87v8frihny.fsf@gmx.net> <837cs7we2z.fsf@gnu.org> <47e13491-1654-db22-2f8b-f12195953232@gmail.com> <87o7lhrm2x.fsf@gmx.net> <87edm3tg57.fsf@gmx.net> Content-Language: en-US From: Mauro Aranda In-Reply-To: <87edm3tg57.fsf@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Stephen Berman writes: >> Thanks for the feedback.  You're right, that patch is too superficial; >> it also fails to do substitution in popup extended menus like the one >> produced by clicking the "State" button, with the result that in the >> item "Revert This Session's Customization" the apostrophe is not >> displayed in the "curve" style.  So I revised the patch, attached below, >> to iterate over the elements of each item in ITEMS, and it now appears >> to handle substitution with the "State" button display correctly, both >> as popup menu and as text menu buffer.  The latter is the result of >> applying widget--simplify-menu, if I debugged correctly, so I think this >> answers your concerns (though the text menu buffer already shows the >> substitution independently of my patch, due to commit bd3b426ebb).  Or >> have I misunderstood your concerns about widget--simplify-menu?  If so, >> can you give an example where the new patch fails? > > Just pinging in case this fell under the radar.  If there's no response, > what's the next step forward? > > Steve Berman It did, thanks for the ping. Since there's no problem with widget--simplify-menu, the patch looks good to me. From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jun 2023 22:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: Eli Zaretskii , Stefan Monnier , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168755874620954 (code B ref 64046); Fri, 23 Jun 2023 22:20:02 +0000 Received: (at 64046) by debbugs.gnu.org; 23 Jun 2023 22:19:06 +0000 Received: from localhost ([127.0.0.1]:39672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCp7S-0005Rt-1N for submit@debbugs.gnu.org; Fri, 23 Jun 2023 18:19:06 -0400 Received: from mout.gmx.net ([212.227.15.18]:48481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCp7P-0005RO-Cs for 64046@debbugs.gnu.org; Fri, 23 Jun 2023 18:19:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1687558733; x=1688163533; i=stephen.berman@gmx.net; bh=p2E7iJ0wUo8W1NHct1DNAsfsNETVtHRQr2263n634p4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=asQVaS8m+6L5hY3U4Rcive8llgeKULZcJSZztiCc1OUCR+AICv1a0GAZD2n1L7eX//zYBbR RlbHwvHz7p8CadaK4piv0sGeBaTwT62c8vZfraZqfeleie/UYsLNkzDqmUkmASBFUrN8dwAkU YM1rUVJVuJ+/6ZuagLghPlaXgkmOjxVjbuJg4dGmZRcuJfcpz4kmy885z9ZuUsrY/jjOfIADb ppxgpfPKWhHkvUMNGiTgMUwvn/unQgghSg6yViBXPpj7S0+kiLuELLBwjm0hgT2aE0rLQ4OQK tDhQCiBV+x2WGaEvve0ODFjtQ7UFOy/QzZzkVuc0FuOsXcorAsSg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.37.248]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MTiPv-1qehEm3AQH-00U3rF; Sat, 24 Jun 2023 00:18:53 +0200 From: Stephen Berman In-Reply-To: <613827fd-46e8-b8e8-dd91-1539f007a099@gmail.com> (Mauro Aranda's message of "Thu, 22 Jun 2023 19:59:26 -0300") References: <87v8frihny.fsf@gmx.net> <837cs7we2z.fsf@gnu.org> <47e13491-1654-db22-2f8b-f12195953232@gmail.com> <87o7lhrm2x.fsf@gmx.net> <87edm3tg57.fsf@gmx.net> <613827fd-46e8-b8e8-dd91-1539f007a099@gmail.com> Date: Sat, 24 Jun 2023 00:18:48 +0200 Message-ID: <878rc9rfef.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:yW39zx2JonSJ0oMEfWf8Xg1LaXhvGoKkB4TZQpDOUaZSEAgKpV9 HFOeSH1mgXRQEufCS/D1XGUqEmT31qCiRf5SlcR2HVy1Fd67vpn3iLfC6pehtZANhWs/lAq aDLwacYjYBFeSwEusT1D56VVCDzSbZ5gAnIKO/+vIaYsuGkIIbxHUZgM0X/BfpF1o+L2R4a wh+efEdy74hyNwlAjy7sQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:XlgTJ/J3ZHQ=;ZKcleRHEaD61DQD98oR9CQgAv2L xti2NQTOko2/Wc5d6JoQXZF/dH0u8C9UaS7iz+NbK0HRQHjgQ/Jg8WFdi80e69nTbUpPc11T8 Nn3kTe5rvKwO0sS2UdXxet1YQ7On2LuxR91LKPpytcd6fd5oJYu8lbxrfiqyCby/JS+FhLMK2 a9IvNxU4D9Ai+d4Eqnstvb4AA1sij/Y8nzM9jnnjjUQL8PeqVooDyk7P7olQEvM5AJ+i/hI5G R2I4NcygAr/7C3cXT10SfA7VoCfA2Y0o2ud0rkw2DKQ64q8UbAFuwWoKB/sriQSQn3uv/nwQh TyM04L52aM8YS7ksQaY5+77aCCxCbjTcCgh1STced+nrPzhmvUHxYdAHZr26M4YkJd2FFjalD wYHkIKeMzG2VRzp7mLc2YNwciBTPVSquDxuHZDeoJIyC/viceabCZfGQr+pzE1FLuWkhN4LPw UltGYQInzKK56zpvX4/WG9OsnGwqVg+rnw4r0zZ31AxGIalhwYPBtks6x55zoXe4tis9iaqB/ MvaMZFQL9BOe2MuL4CfbucTfU8wt9faStw9LAc3oVVuhjprwoSDUPe7AZixOMpGRhXWiSz6/V Dv34TH8KPX3ZX6SOz0/lAXBUqU2SLYd8omXW9QOYdUGscGF3rt6mjNuwKv4MmzvmWyXSlQxaG 9xDEGsjKP2moDdL6WTW4kSZwWuYwiJ8gmlXq+dQ17StMhdJlNtczbfRwsT4PGTcHJMPImTFfS knZN+BC6xzk48/xnaZmbPdf5M8nOYqwSYMxu4xejjqHQ79J5xTszdmcGKrvP3mAO/3ArhV2sQ LWvbm7fc+jtGbB7aOC3fwhdL5TcDvTkR6H9HRdDbtrt36UfxgZVRNtEXWNBjNDxxU56qh8U3f Tca0aYPH+oVdDkY+nwCbUq/mTiXB/gLF0OodLecxsEKAu2xsaZc+rjUm+MYLC5JhS1wLmIFZt Fa6ZGDd/5ehngQGJE79yKvUxpL4= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, 22 Jun 2023 19:59:26 -0300 Mauro Aranda wr= ote: > Stephen Berman writes: > >>> Thanks for the feedback.=C2=A0 You're right, that patch is too superfic= ial; >>> it also fails to do substitution in popup extended menus like the one >>> produced by clicking the "State" button, with the result that in the >>> item "Revert This Session's Customization" the apostrophe is not >>> displayed in the "curve" style.=C2=A0 So I revised the patch, attached = below, >>> to iterate over the elements of each item in ITEMS, and it now appears >>> to handle substitution with the "State" button display correctly, both >>> as popup menu and as text menu buffer.=C2=A0 The latter is the result of >>> applying widget--simplify-menu, if I debugged correctly, so I think this >>> answers your concerns (though the text menu buffer already shows the >>> substitution independently of my patch, due to commit bd3b426ebb).=C2= =A0 Or >>> have I misunderstood your concerns about widget--simplify-menu?=C2=A0 I= f so, >>> can you give an example where the new patch fails? >> >> Just pinging in case this fell under the radar.=C2=A0 If there's no resp= onse, >> what's the next step forward? >> >> Steve Berman > > It did, thanks for the ping. > > Since there's no problem with widget--simplify-menu, the patch looks > good to me. Thanks. So Eli, should this go into master, since it's not a regression, or is it ok to install this to the release branch? It does seem pretty safe, since it's only applying substitute-command-keys in a few more places in widget-choose. Steve Berman From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jun 2023 06:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: maurooaranda@gmail.com, monnier@iro.umontreal.ca, 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.16875886508312 (code B ref 64046); Sat, 24 Jun 2023 06:38:02 +0000 Received: (at 64046) by debbugs.gnu.org; 24 Jun 2023 06:37:30 +0000 Received: from localhost ([127.0.0.1]:39869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCwtm-0002A0-9E for submit@debbugs.gnu.org; Sat, 24 Jun 2023 02:37:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCwth-00029k-Ki for 64046@debbugs.gnu.org; Sat, 24 Jun 2023 02:37:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCwtb-00082x-Dc; Sat, 24 Jun 2023 02:37:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=u4NK6EOiA91gfieGgrZF2MCLguhp7tmTzPsGqBkBamA=; b=ZoEKdqKCyNofK/tIlEYy PFSNioZnS9toKokdB3fpgK0Np3tHyfwiI3kwuWr9b2sz3sGX7ZjsA0MbU4YO8j6LT2dIqxLsGVLrd 3x+5YY51pUm4weBle1Q75vA6sJQriZzAXScbYc+DIZ5FXmMcac7wQwNMgaLUX5mWEVPTNGQihNdSU JCxe25qp/U+7IKHoz47W0o85LozjOAmOR9Yw97xXmyVEaHhIEgIbBdokm7qW4jPZ8Fud5ZGFX3pYz EsW2MLXofGIzbl1OQDwX5qY2a9zHhErwQkVBI+MXaWPkBn+5oWB1lQIbBq+lswMoQqOhEpuryfqiB tAZ+Ll2V8ehd/Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCwta-00069M-6Q; Sat, 24 Jun 2023 02:37:19 -0400 Date: Sat, 24 Jun 2023 09:37:34 +0300 Message-Id: <83352h1i35.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <878rc9rfef.fsf@gmx.net> (message from Stephen Berman on Sat, 24 Jun 2023 00:18:48 +0200) References: <87v8frihny.fsf@gmx.net> <837cs7we2z.fsf@gnu.org> <47e13491-1654-db22-2f8b-f12195953232@gmail.com> <87o7lhrm2x.fsf@gmx.net> <87edm3tg57.fsf@gmx.net> <613827fd-46e8-b8e8-dd91-1539f007a099@gmail.com> <878rc9rfef.fsf@gmx.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stephen Berman > Cc: 64046@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier > > Date: Sat, 24 Jun 2023 00:18:48 +0200 > > On Thu, 22 Jun 2023 19:59:26 -0300 Mauro Aranda wrote: > > > Stephen Berman writes: > > > >>> Thanks for the feedback.  You're right, that patch is too superficial; > >>> it also fails to do substitution in popup extended menus like the one > >>> produced by clicking the "State" button, with the result that in the > >>> item "Revert This Session's Customization" the apostrophe is not > >>> displayed in the "curve" style.  So I revised the patch, attached below, > >>> to iterate over the elements of each item in ITEMS, and it now appears > >>> to handle substitution with the "State" button display correctly, both > >>> as popup menu and as text menu buffer.  The latter is the result of > >>> applying widget--simplify-menu, if I debugged correctly, so I think this > >>> answers your concerns (though the text menu buffer already shows the > >>> substitution independently of my patch, due to commit bd3b426ebb).  Or > >>> have I misunderstood your concerns about widget--simplify-menu?  If so, > >>> can you give an example where the new patch fails? > >> > >> Just pinging in case this fell under the radar.  If there's no response, > >> what's the next step forward? > >> > >> Steve Berman > > > > It did, thanks for the ping. > > > > Since there's no problem with widget--simplify-menu, the patch looks > > good to me. > > Thanks. So Eli, should this go into master, since it's not a > regression, or is it ok to install this to the release branch? It does > seem pretty safe, since it's only applying substitute-command-keys in a > few more places in widget-choose. Pleased install on master. The problem is very minor and we have lived with it for many years, so it can wait a bit more. Thanks. From unknown Fri Aug 08 15:18:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stephen Berman Subject: bug#64046: closed (Re: bug#64046: 30.0.50; Quoting in customize choice tags) Message-ID: References: <87a5wpfdmk.fsf@gmx.net> <87v8frihny.fsf@gmx.net> X-Gnu-PR-Message: they-closed 64046 X-Gnu-PR-Package: emacs Reply-To: 64046@debbugs.gnu.org Date: Sat, 24 Jun 2023 08:51:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1687596661-24861-1" This is a multi-part message in MIME format... ------------=_1687596661-24861-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64046: 30.0.50; Quoting in customize choice tags which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64046@debbugs.gnu.org. --=20 64046: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64046 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1687596661-24861-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64046-done) by debbugs.gnu.org; 24 Jun 2023 08:50:27 +0000 Received: from localhost ([127.0.0.1]:39904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCyyR-0006Rx-Ca for submit@debbugs.gnu.org; Sat, 24 Jun 2023 04:50:27 -0400 Received: from mout.gmx.net ([212.227.15.18]:40027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCyyM-0006RY-51 for 64046-done@debbugs.gnu.org; Sat, 24 Jun 2023 04:50:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1687596612; x=1688201412; i=stephen.berman@gmx.net; bh=/RHjQbJttf7ImyPAK/TWtnzDkAez/NRJsv6DF1D+ScU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=FT+pZWGtFmrVTNb8nuqDuTmLibl8wXDjSWx+dPPImzszbazcP0xcPmKvRysAMLahvSvn6je OAXdZiNzErbvK8HIXB0B/l4w3D29l+zQOd3oQWODoeiZR9ocDbbLx97wYbrdJ0sFZwRAe5Tsb TlWTpixghSL3VEDnFO6NxGKq3AQGH+akGiJaaKkV31OF+ku/ibZg6tFQP9xu7N5U1U/nyTVoW nZy718BYXcr5tgcQjWI8P11gMGzLgkTgCjW8v4NvsNQTQFXIocKFUDlfr7KotWnzkD7u6MQ6R Sk0lfVeOvy4Ts0kyOB1tG3wbBezSBLqxtus1yy86ZxW+usKVP/fA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([94.134.196.23]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MPog5-1qPzWB2zA3-00MwM6; Sat, 24 Jun 2023 10:50:12 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#64046: 30.0.50; Quoting in customize choice tags In-Reply-To: <83352h1i35.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Jun 2023 09:37:34 +0300") References: <87v8frihny.fsf@gmx.net> <837cs7we2z.fsf@gnu.org> <47e13491-1654-db22-2f8b-f12195953232@gmail.com> <87o7lhrm2x.fsf@gmx.net> <87edm3tg57.fsf@gmx.net> <613827fd-46e8-b8e8-dd91-1539f007a099@gmail.com> <878rc9rfef.fsf@gmx.net> <83352h1i35.fsf@gnu.org> Date: Sat, 24 Jun 2023 10:50:11 +0200 Message-ID: <87a5wpfdmk.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ceG8kHJnGPvZ5QQK8Xzbi3ny7z534oDiAcX4FeMD000WLlDpxe5 5imrmaE31J/lUbRIp5kXvLHR2rznO2B8Qj1csX8KidSzh1YRDUMcdtk2g+sw8t/3i27vmcO y5BvJ8MOAF1B8dtw9EjROa8H0nhvcSI+aWg8xLSsEtQpwgm3T0EU5+pQZcd7Og4VGymX83s NNFwtDWnHFByeVKXL5gnw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:UkCv1w76Xeo=;rJziX16toTT89ByK8yY8gd65mgy zsFg7hfOVO2gHOVeu1x1/GjJqELbQNwI6oqswS4IpwfFkxdFcNd9Bcntg2FEShPNJSSLPV4gq f99i1YLzRDxGxSIrLvT0eW2vtahD0r/IMEiFvC9dO9RUuXTMtbsQjmSrrFiAv8JcN485rUn/A KHDpjPe33pKz6Mn/JI1HaskMtJLdDvLu3p61RHJ3fKM2bI8WicIU4vEm4BA3lLJxLrePcy3Db RsIIAqMz5E/5w1Yq0Bv97RU/eeS85lBFnuCGjHGlCxydP/N8G/iQcBjMl9jRe69XTN5RPr/It 3YIPcZWQ8X1nNk223kmEwiCIjGDmB8qJ3RxVaxAGG3Kc/RhZq6PXUZq32FCrB76TjhW0BGQBO juQrkdjBK9FzjDt5g/j9jMRKalrjjDzMF4V8ZeYdjyhx7eo/+Bj4qM90UXtfsjicUA8lMHO/i SwvmP2AWTd/5ieNQODmjbPGDLxQ+1L2KRrm+sadvpUkeWwjcQJw8xtvoVrPwHodkqTo2hDWri Rl4FQ4n1E+BCerndXTTn7mDVMWY3z0poLvPDGEwiZdO7RIRvZB9hjIT+XrtR8rQBYnnKMRfmc Qj3052/Ud+m2Ols4HKP4mTH98nEh6bIWJiHbGmZA2179RAuOJZNDGYZgUxFkhU8v62PxQN34t cJOlGl701uTndhUBqbutY8c82OHy3fILbjr98UxkxqFfFWSw+ulSmcNb0fHCISkW5TRDRmE+J FV6zsvMjQj/OuafgM+b7W8eDVYP/HsbADjxu+HeCOeiDCVpm9FHtYs8OAjVdxm7YBWxq2m6to vPhRT1lURVK/DzpzsYEsWl6mRr/lBY14i0YkqxVQeM79j9b+APgdSrtS/aYt+Cdms8AfZ1QCB K4CvPr19LPBt/23kyoWIkyEoWECBADT9GW5x/pJ8jtBTWyrMLuxtaEASMmzoRWRmK/6iAubpP jO5mBOzsBMIcwApRcBugK9bqhdM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 64046-done Cc: 64046-done@debbugs.gnu.org, maurooaranda@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, 24 Jun 2023 09:37:34 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: 64046@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier >> >> Date: Sat, 24 Jun 2023 00:18:48 +0200 >>=20 >> On Thu, 22 Jun 2023 19:59:26 -0300 Mauro Aranda = wrote: >>=20 >> > Stephen Berman writes: >> > >> >>> Thanks for the feedback.=C2=A0 You're right, that patch is too super= ficial; >> >>> it also fails to do substitution in popup extended menus like the one >> >>> produced by clicking the "State" button, with the result that in the >> >>> item "Revert This Session's Customization" the apostrophe is not >> >>> displayed in the "curve" style.=C2=A0 So I revised the patch, attach= ed below, >> >>> to iterate over the elements of each item in ITEMS, and it now appea= rs >> >>> to handle substitution with the "State" button display correctly, bo= th >> >>> as popup menu and as text menu buffer.=C2=A0 The latter is the resul= t of >> >>> applying widget--simplify-menu, if I debugged correctly, so I think = this >> >>> answers your concerns (though the text menu buffer already shows the >> >>> substitution independently of my patch, due to commit bd3b426ebb).= =C2=A0 Or >> >>> have I misunderstood your concerns about widget--simplify-menu?=C2= =A0 If so, >> >>> can you give an example where the new patch fails? >> >> >> >> Just pinging in case this fell under the radar.=C2=A0 If there's no r= esponse, >> >> what's the next step forward? >> >> >> >> Steve Berman >> > >> > It did, thanks for the ping. >> > >> > Since there's no problem with widget--simplify-menu, the patch looks >> > good to me. >>=20 >> Thanks. So Eli, should this go into master, since it's not a >> regression, or is it ok to install this to the release branch? It does >> seem pretty safe, since it's only applying substitute-command-keys in a >> few more places in widget-choose. > > Pleased install on master. The problem is very minor and we have > lived with it for many years, so it can wait a bit more. Done with commit 6d55d93379f, closing the bug. Thanks. Steve Berman ------------=_1687596661-24861-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Jun 2023 14:03:07 +0000 Received: from localhost ([127.0.0.1]:42600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q94by-00009i-HS for submit@debbugs.gnu.org; Tue, 13 Jun 2023 10:03:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:53092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q94bw-00009a-0v for submit@debbugs.gnu.org; Tue, 13 Jun 2023 10:03:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q94bv-0007re-RS for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2023 10:03:03 -0400 Received: from mout.gmx.net ([212.227.17.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q94bt-0008PC-GO for bug-gnu-emacs@gnu.org; Tue, 13 Jun 2023 10:03:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1686664978; x=1687269778; i=stephen.berman@gmx.net; bh=n1zxSOkPLjFIWDEi+i7IiQcpM5HAEXo300oxlkXwtMs=; h=X-UI-Sender-Class:From:To:Subject:Date; b=NcOMWHOyitYfmqzf4vnmqDVem0NpbKUqClDSx1/f8+6zae1P47dYN8VgIu98zYOVZ6H++vO 4zZMF05KbspmCF2UK1L/iCeJ5CGDRV02ZDJ1AESdvHKzF3haiNUElZEiNOJH/7EX6yztRkWUt tL2WRNeA2xu2YqKAzK8VfNqCfREvgW66DN5k26ZmeNkDN+4ok+tZOzgLV5jUFsHvpal1E/c4j O7MR4IcwXMigNcPRx5Zjnd9i9Il03qXToDmR4m7U1lNgaVEe51cNNxnfBIgDadsydV0bwjz2H 4FQD/36EcbIy+RT9d68yUv8xuQDCmZZPtmtlQIRxrRGbRTi8dN0A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.37.154]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfpSb-1pcTkJ2aPB-00gD9D for ; Tue, 13 Jun 2023 16:02:58 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Quoting in customize choice tags Date: Tue, 13 Jun 2023 16:02:57 +0200 Message-ID: <87v8frihny.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:4MpQi8JI+bvd0YZQcczEdqxstOedutLch3MHRV0G6WWzL8Q6CZa dWiGFZOo+gupuKKtLii/9Ywc6c2+zL1ROMSJXVfz7tK4nieWxOpC+TbA/cHaH4fIB3jW838 Wgsf4ArbQpTiyCkTwXcijVGLdSCReREgprMENa8cjn52w+YZ1h7L5dB7vrMfVM1Ma+I3v97 8DdpW7ZZtVBwLuAuPeL6Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:t6Ngau6LwHs=;NrEvJXtg2R+fEgX20rcUJZehnU4 nN9N/55i3pmHCp2t6Awvph+ZC4NbDOjuuSWhYO//03oLBmAN24Q6EHc28lV7/3aqCL6TFRFad kOMbP70ob3iJb9l1f7Yogm3wbwWlClbJy7c9wuP51fa14hD0cy5PB7R4F77TLZLcT4pgLtFZx YtpPosSa/0Lfl/EGRVp2FmwZfWuqcUCdqtoT79AD0hq9oWGT7bZ6Q58bpFtmMQaAAqAbllQoP n9KFn7VeQdO7AoSVFTHUGQNdNMZ/DQdX/c1Wrpg58Xocr6HlIR4Abibpj290Hri+oK6Mr+Xoc LYv8tf+uYHKVSNSVbeU5HBD3BMghqGFxad/BF8CXMVAYDbrVdB1FUu4CUAqvk2oSOkTH7sg4W 20W7adqrdfawDvuIUX8DqUGT4nQgxVOhsQrcl79WNxlWhlnEgTaSmDnP4LQ5QhxIdH2fHWUKq 536mU7LJuCyxpwHojOyt4eLznpWVaQyicpggnxjnZyjk8re2A7svb8YDk8zIKKzqpzqiyXvYB RNY78rK//SI9skLELoUWKLNA92T9BDDO2ma9P18F7rJdlOrDI/wvCJOmlKy/ph2Fo4dLweG29 I2CzBM/somxmKfFV8qOdyklkzbNr31RJk6JdanAPBnWBFWlgGnD9reXMMM2XhR/6lR3elepJP r9eMhkqsjiE+Q/rCz2SmuOeD806r24R7IzKADTkouUiewhGwiiFWYR1tDz9knGTW3W8Kcv5+F 1E4m5UBjm0iyl2B3o4D4TTN64sGwnG9n4NPLx68Pr/thzR9fBzqe0qn+y8N5wZflCkS+GX3cE r1yDnqPhIhroMfznxPDh9qZAKcWToXA7zFwnJ7RO9Hmlt4YytoW1BVYs4SEw62SuVo1ofLPgs tiPPZt1C7uuyW5w2l/uWGjBgIo9fxqNb2rg5VhfpYb5MTIIYuqdFmWoFKGZ/ZcjqTdrHxVLsG 6jtGK+wb79tDf6u7i36gH2bpUok= Received-SPF: pass client-ip=212.227.17.20; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable 0. emacs -Q 1. Evaluate the following defcustom: (defcustom my-test "a" "Test." :type '(choice (string :tag "Use `a'" "a") (string :tag "Use `b'" "b"))) 2. M-x customize-option RET my-test RET 3. In the buffer *Customize Option: My Test* note that in the string "Use =E2=80=98a=E2=80=99" following the "Value Menu" button the quote ma= rks are in the "curve" style (=E2=80=98=E2=80=99). 4. Put point on the "Value Menu" button and type RET. 5. The buffer " widget-choose" contains these lines: 0 =3D Use =E2=80=98a=E2=80=99 1 =3D Use =E2=80=98b=E2=80=99 Note that the quote marks in this buffer are also in the "curve" style. 6. With the mouse pointer over the "Value Menu" button press mouse-1, popping up a menu titled "Choice" containing these items: Use `a' Use `b' Note that the quote marks in this menu are in the "grave" style (`') instead of the "curve" style. The use of the "curve" style in the " widget-choose" buffer is due to commit bd3b426ebb7a60045839e97c9da9bfd249fab1f1, but that commit did not take popup menus into account. The attached patch does so. Since the status quo ante long predates emacs-29 and this is just a stylistic bug, I made the patch against master. In this patch I chose to apply substitute-command-keys just once at the beginning of the function `widget-choose', rather than several times within the function, but I restricted its application to item tags, so other uses of the ITEMS argument should not be affected (and my brief testing hasn't found any problem with the patch). The patch also takes the opportunity to replace two unnecessary uses of `let*' in `widget-choose', in one case by `let' and in the other by foregoing let-bound variables altogether and just using the values in place, since they occur only once each in the lines immediately following the eliminated `let*'. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.6) of 2023-06-13 built on strobelfssd Repository revision: ba349aa32e98a53146794197c316f4765598ddbd Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Linux From Scratch r11.3-100-systemd Configured using: 'configure -C --with-xwidgets 'CFLAGS=3D-Og -g3' PKG_CONFIG_PATH=3D/opt/qt5/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM XWIDGETS GTK3 ZLIB --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: widget-choose patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index cafd0ad0a4d..bc070c9933f 100644 =2D-- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -281,71 +281,75 @@ widget-choose If ITEMS has simple item definitions, then this function returns the VALU= E of the chosen element. If ITEMS is a keymap, then the return value is the s= ymbol in the key vector, as in the argument of `define-key'." - (cond ((and (< (length items) widget-menu-max-size) - event (display-popup-menus-p)) - ;; Mouse click. - (if (keymapp items) - ;; Modify the keymap prompt, and then restore the old one, i= f any. - (let ((prompt (keymap-prompt items))) - (unwind-protect - (progn - (setq items (delete prompt items)) - (push title (cdr items)) - ;; Return just the first element of the list of even= ts. - (car (x-popup-menu event items))) - (setq items (delete title items)) - (when prompt - (push prompt (cdr items))))) - (x-popup-menu event (list title (cons "" items))))) - ((or widget-menu-minibuffer-flag - (> (length items) widget-menu-max-shortcuts)) - (when (keymapp items) - (setq items (widget--simplify-menu items))) - ;; Read the choice of name from the minibuffer. - (setq items (cl-remove-if 'stringp items)) - (let ((val (completing-read (concat title ": ") items nil t))) - (if (stringp val) - (let ((try (try-completion val items))) - (when (stringp try) - (setq val try)) - (cdr (assoc val items)))))) - (t - (when (keymapp items) - (setq items (widget--simplify-menu items))) - ;; Construct a menu of the choices - ;; and then use it for prompting for a single character. - (let* ((next-digit ?0) - alist choice some-choice-enabled value) - (with-current-buffer (get-buffer-create " widget-choose") - (erase-buffer) - (insert "Available choices:\n\n") - (while items - (setq choice (pop items)) - (when (consp choice) - (let* ((name (substitute-command-keys (car choice))) - (function (cdr choice))) - (insert (format "%c =3D %s\n" next-digit name)) - (push (cons next-digit function) alist) - (setq some-choice-enabled t))) - ;; Allocate digits to disabled alternatives - ;; so that the digit of a given alternative never varies. - (setq next-digit (1+ next-digit))) - (insert "\nC-g =3D Quit") - (goto-char (point-min)) - (forward-line)) - (or some-choice-enabled - (error "None of the choices is currently meaningful")) - (save-window-excursion - ;; Select window to be able to scroll it from minibuffer - (with-selected-window - (display-buffer (get-buffer " widget-choose") - '(display-buffer-in-direction - (direction . bottom) - (window-height . fit-window-to-buffer)= )) - (setq value (read-char-choice - (format "%s: " title) - (mapcar #'car alist))))) - (cdr (assoc value alist)))))) + ;; Apply quote substitution to all customize choice tags, whether + ;; they occur in a widget buffer or in a popup menu. + (let ((items (mapc (lambda (x) + (when (and (consp x) (char-or-string-p (car x))) + (setcar x (substitute-command-keys (car x))))) + items))) + (cond ((and (< (length items) widget-menu-max-size) + event (display-popup-menus-p)) + ;; Mouse click. + (if (keymapp items) + ;; Modify the keymap prompt, and then restore the old one,= if any. + (let ((prompt (keymap-prompt items))) + (unwind-protect + (progn + (setq items (delete prompt items)) + (push title (cdr items)) + ;; Return just the first element of the list of ev= ents. + (car (x-popup-menu event items))) + (setq items (delete title items)) + (when prompt + (push prompt (cdr items))))) + (x-popup-menu event (list title (cons "" items))))) + ((or widget-menu-minibuffer-flag + (> (length items) widget-menu-max-shortcuts)) + (when (keymapp items) + (setq items (widget--simplify-menu items))) + ;; Read the choice of name from the minibuffer. + (setq items (cl-remove-if 'stringp items)) + (let ((val (completing-read (concat title ": ") items nil t))) + (if (stringp val) + (let ((try (try-completion val items))) + (when (stringp try) + (setq val try)) + (cdr (assoc val items)))))) + (t + (when (keymapp items) + (setq items (widget--simplify-menu items))) + ;; Construct a menu of the choices + ;; and then use it for prompting for a single character. + (let ((next-digit ?0) + alist choice some-choice-enabled value) + (with-current-buffer (get-buffer-create " widget-choose") + (erase-buffer) + (insert "Available choices:\n\n") + (while items + (setq choice (pop items)) + (when (consp choice) + (insert (format "%c =3D %s\n" next-digit (car choice))= ) + (push (cons next-digit (cdr choice)) alist) + (setq some-choice-enabled t)) + ;; Allocate digits to disabled alternatives + ;; so that the digit of a given alternative never varies. + (setq next-digit (1+ next-digit))) + (insert "\nC-g =3D Quit") + (goto-char (point-min)) + (forward-line)) + (or some-choice-enabled + (error "None of the choices is currently meaningful")) + (save-window-excursion + ;; Select window to be able to scroll it from minibuffer + (with-selected-window + (display-buffer (get-buffer " widget-choose") + '(display-buffer-in-direction + (direction . bottom) + (window-height . fit-window-to-buffe= r))) + (setq value (read-char-choice + (format "%s: " title) + (mapcar #'car alist))))) + (cdr (assoc value alist))))))) ;;; Widget text specifications. ;; --=-=-=-- ------------=_1687596661-24861-1-- From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags References: <87v8frihny.fsf@gmx.net> In-Reply-To: <87v8frihny.fsf@gmx.net> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 64046@debbugs.gnu.org, Stephen Berman Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168942723320452 (code B ref 64046); Sat, 15 Jul 2023 13:21:02 +0000 Received: (at 64046) by debbugs.gnu.org; 15 Jul 2023 13:20:33 +0000 Received: from localhost ([127.0.0.1]:44363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKfCK-0005Jo-PC for submit@debbugs.gnu.org; Sat, 15 Jul 2023 09:20:33 -0400 Received: from mail-oo1-xc29.google.com ([2607:f8b0:4864:20::c29]:56422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKfCF-0005JU-LI for 64046@debbugs.gnu.org; Sat, 15 Jul 2023 09:20:31 -0400 Received: by mail-oo1-xc29.google.com with SMTP id 006d021491bc7-563439ea4a2so1960192eaf.0 for <64046@debbugs.gnu.org>; Sat, 15 Jul 2023 06:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689427221; x=1692019221; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=JuqBNbrts/SH3bcXdOdqf9IAodWhfGqFkU7T5PhQQuA=; b=HuSk7jZS6oOk8NEGwY6JWZIIlrpKF8K0xtu/24h2E6W6iM79mSU//SoNG2TQmBGBMa aUUZQEG46WMkF75hBypGj4ATr9uRN3Zgj5gqfuATfOd2UyZYkNd7aBOulkHkkjWS7rOf 5yRIkKsNFWl0ilLod5nw6PPypZ9roNFucmYvIWxiBsn0s7sJT3shgL4O9uUxFs6UrVf3 /BCazKlPvPmYMc0dB+4oFOMmd28YnNPXehSm6bo5As21PUmjTfjKaOqnrLLMySfGVXtO hRcH5z/Q9HoO2Ofma047WIBzo8XixppFU97DxilXHMOiZ/TXWGGd9CDfdrPjY73uUhYj OiCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689427221; x=1692019221; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JuqBNbrts/SH3bcXdOdqf9IAodWhfGqFkU7T5PhQQuA=; b=S+yVLUIc6EEzzpyrepFp1Z0v/8xrGcNTH4ebnzDz1izRYe94Kv0TcJ/U7B6CPUaQeF 66Y6CrHrLCWCy5hfVCKCABxjBgbSe5ijd/UBw2NsHadT9vEZnJYzoYj87M46I204RdT7 NkNRLbJ+rl+IUohob4Qwkm/4vVVkgZ0BRhzo5YybfpcGF4AnFlnrh6ZC4J9BlhCmaXDo i8qq44ATfhaIvpHFWr6cNqUgmDlT71dO6boh4UB8rkt5R1cxLtFOic7R/q+gjEJlx71I ewvzuFNzON/bKGHKgWYX7zvjzEBJsvbI8305cu2t28FjIMPcdggHAPrT9rN1bSnrOWj1 elbw== X-Gm-Message-State: ABy/qLaFuDCGI0P4XeGbywhYi7avoCD8nwvrvp/f4y23gMKKy6tc1m4w aq/nMJIuKDpqeMav6mNV7zLkRpFhsXCD9g== X-Google-Smtp-Source: APBJJlExlKromFyddLyIwuYWU4tEW7ijf6YftaXMKNGnuQjFVVwxsPrwVHvo+ffyPtIWmGMYb6ROQg== X-Received: by 2002:a05:6808:2027:b0:398:9ee4:1dac with SMTP id q39-20020a056808202700b003989ee41dacmr9873915oiw.32.1689427221133; Sat, 15 Jul 2023 06:20:21 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id dz25-20020a056808439900b003a3600182f8sm4903047oib.57.2023.07.15.06.20.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jul 2023 06:20:20 -0700 (PDT) Message-ID: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> Date: Sat, 15 Jul 2023 10:20:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US From: Mauro Aranda Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > On Thu, 22 Jun 2023 19:59:26 -0300 Mauro Aranda wrote: > >> Stephen Berman writes: >> >>>> Thanks for the feedback.  You're right, that patch is too superficial; >>>> it also fails to do substitution in popup extended menus like the one >>>> produced by clicking the "State" button, with the result that in the >>>> item "Revert This Session's Customization" the apostrophe is not >>>> displayed in the "curve" style.  So I revised the patch, attached below, >>>> to iterate over the elements of each item in ITEMS, and it now appears >>>> to handle substitution with the "State" button display correctly, both >>>> as popup menu and as text menu buffer.  The latter is the result of >>>> applying widget--simplify-menu, if I debugged correctly, so I think this >>>> answers your concerns (though the text menu buffer already shows the >>>> substitution independently of my patch, due to commit bd3b426ebb).  Or >>>> have I misunderstood your concerns about widget--simplify-menu?  If so, >>>> can you give an example where the new patch fails? >>> >>> Just pinging in case this fell under the radar.  If there's no response, >>> what's the next step forward? >>> >>> Steve Berman >> >> It did, thanks for the ping. >> >> Since there's no problem with widget--simplify-menu, the patch looks >> good to me. > > Thanks.  So Eli, should this go into master, since it's not a > regression, or is it ok to install this to the release branch?  It does > seem pretty safe, since it's only applying substitute-command-keys in a > few more places in widget-choose. > > Steve Berman Turns out this code introduces regressions when customizing faces. With emacs -Q: M-x customize-face RET default Action the State button and choose: "For All Kinds of Displays" Action the Display menu and select "specific display" Wrong type argument: number-or-marker-p, "        " The substitute-command-keys operation is too destructive, and messes with things it shouldn't be modifying, like the :offset property of widgets in this case. From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jul 2023 15:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168986811922570 (code B ref 64046); Thu, 20 Jul 2023 15:49:02 +0000 Received: (at 64046) by debbugs.gnu.org; 20 Jul 2023 15:48:39 +0000 Received: from localhost ([127.0.0.1]:59498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMVtP-0005rx-63 for submit@debbugs.gnu.org; Thu, 20 Jul 2023 11:48:39 -0400 Received: from mout.gmx.net ([212.227.15.15]:38931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMVtM-0005rC-Bc for 64046@debbugs.gnu.org; Thu, 20 Jul 2023 11:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1689868109; x=1690472909; i=stephen.berman@gmx.net; bh=IpK7PAsLE6eaYe5Qj8wokoukXYuXpwmU0wiHNdzYYeU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=mIKpuU8j9CyJnHHm5PnHSLLmidxdxnbvPCmuVpbV1zcDDNfBu4zUJd6BMaTJ/HS5QrybWhB w/RWQuNfpYruxikbRAOi8zJSQA78xDlZB/hWTIAvlX/wKkXgjkHh87fThV4OTYJA+9oIze/Mf iNY3yYMCaj305RtxO9DrW3/4TAthtgxC09eyD46bcy0X0QV+j0MOny4mtGIPbbVIE1Sns6/pY 6fz2jACoaZE94ArooI3MLbCuBaIGT22ehqQvs2p4NaRoW5yLPgAMm9QAHib/sbMUhx6tVGt3u iqRuxwsg8LYX1V1ODDJThOZnpoJA5Z8BLjmP2Q+COYZyNIoAE7wg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.37.91]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M72sP-1qHGxm0scJ-008Yuo; Thu, 20 Jul 2023 17:48:29 +0200 From: Stephen Berman In-Reply-To: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> (Mauro Aranda's message of "Sat, 15 Jul 2023 10:20:17 -0300") References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> Date: Thu, 20 Jul 2023 17:48:27 +0200 Message-ID: <87v8eelh2s.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:/VCMTmOnN2GLJ1TJk0YWLKa+JvVtMROobfh+/rXkES55YidTsPY 1OpYwFcOuUh8g59ARQ3M1BvtKZC4T1ZTwCx4Pnsq3UNFnq9yElvy1JGAhU3vgvBiRR+lg88 iI6ZyqBmiKmFwczw3qtJMuntdMV9gGF770f7O1I8ilCk6+i1LJ/ymr1cVLQycNuN5YunFaD 2JvghNQFIa81goACCjvGw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:fQTwR0SZGBc=;fSicFhf04psBS4NBOycIpMrQRET Q6awhtHeZ8o7dEuaUnxflKaSP1f+OMFqxQwAG1GL1wlhcPkSd8SoedKzl5ALFOuCXb2A7+LK4 nCxkIHY4CGzxzmGZEzuuT4EMmcr7r28ZqX6Hg3Dv6sFy6iaf81sl6QLq366zyIgW+St77AOPy 4PriIdbKh6TFITbuaY2OARl9s5qM296uS3Ao1jwNNP8+DhBroFrV4QUrxHPKu3uoXgTO0Hq/M R3KdCHhadaUN+dgER+Sh5XXAxe5+NgdKZFddYSuYAaPeLc979f4jMwqStEsf4SmldMq+IT8Vs Ae3b6bjYIWoEWBZDrWC8tKd92+vvg6p6fT3/eqFqv4khuidxZXLPUbqwmIqGTpV1ibrsUI4il OmrcMlFI+kWojK/L/UAW7Ly4ge8D02YQC5AYJ89CG5pv89peKD/sYQIdyzEH3yLkTxXydI2Cq UQ92XWIRNj1gFgvt5PLovp86DXFZP0gky4AiGwyuDsvjoDwq5lDKkQ8K+b2fUKAyobi4s0m9I Bjd2NGTmScxYimlwo5/zT5r6XVK2zqG9IDahaXWxJu+v7slsGNIvyP4IWpWQblIgFAlD+TINg icSaOtKpet6+UtqBrL/k7AAtb8lhZWWBNRSj5qgE8k/HrB+RHDxfveIQGKueDUe/aussiB+hn WuSl14vW67XpNJRvIniJze0+iCHrmya8pvmWA9a+2/fIeBfGyeIPw4Qmb6g9rAp+X0w/So1fj QKmpYhe3J4w+Yjv41h+lhtuUWsCpOseMTOwKSVYOgFJbVv4qPdzHUudWVStPWNhyyYKD9H+dp e4Khw8pTmqjIY4VZpnTrICiyV161dHzP98+Td30lxb/lbZcUWzYTExPWyYXZtGWeXleixCt3n hQxeCp0t2FerXQjouJPWrmaUFvx372fYmq6RO2Cx0RonkWY+0L8gd5A/tBK6gL3m9PPFUsF0s Y6c1jA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, 15 Jul 2023 10:20:17 -0300 Mauro Aranda wr= ote: > Stephen Berman writes: > >> On Thu, 22 Jun 2023 19:59:26 -0300 Mauro Aranda > wrote: [...] >>> Since there's no problem with widget--simplify-menu, the patch looks >>> good to me. >> >> Thanks.=C2=A0 So Eli, should this go into master, since it's not a >> regression, or is it ok to install this to the release branch?=C2=A0 It = does >> seem pretty safe, since it's only applying substitute-command-keys in a >> few more places in widget-choose. >> >> Steve Berman > > Turns out this code introduces regressions when customizing faces. > > With emacs -Q: > M-x customize-face RET default > Action the State button and choose: "For All Kinds of Displays" > Action the Display menu and select "specific display" > Wrong type argument: number-or-marker-p, "=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 " > > The substitute-command-keys operation is too destructive, and messes > with things it shouldn't be modifying, like the :offset property of > widgets in this case. Sorry for not responding sooner; I was travelling and only now had time to look into this. If I debugged it correctly, the problem is that the value of :extra-offset, 9, satisfies char-or-string-p, so then due to my patch substitute-command-keys turns it into a string containing a TAB. The cases intended to be fixed by my patch are where strings with grave quoting occur, which should be turned into strings with curve quoting. If so, then testing for stringp suffices, and the attached patch avoids the regression you found and gives the desired results for the other cases discussed in this bug. I don't know why I used char-or-string-p instead of stringp in my original patch, and don't see a reason for it now. Or do you know of cases where testing for stringp is insufficient? Steve Berman --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: widget-choose patch diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index 234f3d9b74d..606093fd293 100644 --- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -286,7 +286,7 @@ widget-choose (let ((items (mapc (lambda (x) (when (consp x) (dotimes (i (1- (length x))) - (when (char-or-string-p (nth i x)) + (when (stringp (nth i x)) (setcar (nthcdr i x) (substitute-command-keys (car (nthcdr i x)))))))) --=-=-=-- From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jul 2023 19:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168988030723221 (code B ref 64046); Thu, 20 Jul 2023 19:12:01 +0000 Received: (at 64046) by debbugs.gnu.org; 20 Jul 2023 19:11:47 +0000 Received: from localhost ([127.0.0.1]:59916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMZ3z-00062S-Bs for submit@debbugs.gnu.org; Thu, 20 Jul 2023 15:11:47 -0400 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]:42405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMZ3u-000625-JH for 64046@debbugs.gnu.org; Thu, 20 Jul 2023 15:11:46 -0400 Received: by mail-ot1-x32c.google.com with SMTP id 46e09a7af769-6b9f46ec07aso762384a34.1 for <64046@debbugs.gnu.org>; Thu, 20 Jul 2023 12:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689880297; x=1690485097; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/8znv7rzQ3wMcDAO1j4zSeqOZPB1vja/yly87ttlBEM=; b=pN+8DY7LA9DAVBADuLA1WRJ1SCqOBAbuzmsLCaJCcu6wyAdyecgrYkPm8eo7KRU3Re YlNgeyS6pQWQqkLyYcqIR969vFESwVtEL/Lg1nuHJeVNtN2wMANAJgkPwhautEzsZs3F hGp360PWJaCJ6dxGiHXSjz+VLD10XI56Cd81fA+x+ZL9bSPklLAXbXm2PBnTGfqyLIk+ yet/niN7C7/1p0WsK09zodJYkJK/4KQ1XvIQKa0PxuzsSh9pvnkwgzfVEvzwvEKsOhRt e7rxuNCgKuOS6wViu39z6jzrSXW4fwR8x6QqVngGevhe0gQK6mX9YeqrMyTQz7Uo1XWL aU5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689880297; x=1690485097; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/8znv7rzQ3wMcDAO1j4zSeqOZPB1vja/yly87ttlBEM=; b=lKlu+4jYwqLDByihLayqOp5rtoT1R6C1Jy9RRwzClSjalWSnnLQqaWoQOkhuS7LOh6 5HJz5EGOgktGjbHSg6yKKrF8tiwRSBJJOSJcQ7FnyU4xQpkMzALtruZTSkVxO0Um805/ ynACoEimy9QOEVxkiuXic+3aXwtclnIXfBpxYmGLd1Kb9KP1y8dayWB4xlPcMtBmUin0 Xb7Fg/D11wIGP4yEJ/P3Fs5h61HffCowtwvY1S0WqG0O9MOKn/8zn9/PDliXWV9CjJyC QsL37MDgUuiFX1aPfC6WMPyXkVG5ciAjZLN+YmKjtOljNNTYQJxXRBFrZ59EzM0S3mkW 2QLw== X-Gm-Message-State: ABy/qLY5zerkvRXOzKxwGw3mu4LYwx017WDpejBnaM3VUOXQFBT0Z1Vf mxEzT0fqMCfhG7tayTphnxQ= X-Google-Smtp-Source: APBJJlHScn7G99Bst8Ue9NuhK+qaYtaJ+URk2xJ6zHezceoJEQDU1qVo1pAW2c99kj1HQlpytNn3HA== X-Received: by 2002:a05:6830:78b:b0:6b9:57d2:8ec1 with SMTP id w11-20020a056830078b00b006b957d28ec1mr2718438ots.2.1689880296965; Thu, 20 Jul 2023 12:11:36 -0700 (PDT) Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id q2-20020a9d7c82000000b006b73c264e30sm725452otn.17.2023.07.20.12.11.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jul 2023 12:11:36 -0700 (PDT) Message-ID: Date: Thu, 20 Jul 2023 16:11:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> From: Mauro Aranda In-Reply-To: <87v8eelh2s.fsf@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) Stephen Berman writes: > On Sat, 15 Jul 2023 10:20:17 -0300 Mauro Aranda wrote: > >> Turns out this code introduces regressions when customizing faces. >> >> With emacs -Q: >> M-x customize-face RET default >> Action the State button and choose: "For All Kinds of Displays" >> Action the Display menu and select "specific display" >> Wrong type argument: number-or-marker-p, "        " >> >> The substitute-command-keys operation is too destructive, and messes >> with things it shouldn't be modifying, like the :offset property of >> widgets in this case. > Sorry for not responding sooner; I was travelling and only now had time > to look into this.  If I debugged it correctly, the problem is that the > value of :extra-offset, 9, satisfies char-or-string-p, so then due to my > patch substitute-command-keys turns it into a string containing a TAB. No trouble at all.  And yes, that sounds correct to me. > The cases intended to be fixed by my patch are where strings with grave > quoting occur, which should be turned into strings with curve quoting. > If so, then testing for stringp suffices, and the attached patch avoids > the regression you found and gives the desired results for the other > cases discussed in this bug.  I don't know why I used char-or-string-p > instead of stringp in my original patch, and don't see a reason for it > now.  Or do you know of cases where testing for stringp is insufficient? I don't know, but I feel like stringp should suffice.  So please install your fix, and I will be alert if something else breaks. From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jul 2023 19:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.168988284628631 (code B ref 64046); Thu, 20 Jul 2023 19:55:01 +0000 Received: (at 64046) by debbugs.gnu.org; 20 Jul 2023 19:54:06 +0000 Received: from localhost ([127.0.0.1]:59987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMZiv-0007Ri-W2 for submit@debbugs.gnu.org; Thu, 20 Jul 2023 15:54:06 -0400 Received: from mout.gmx.net ([212.227.17.21]:59547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMZit-0007R8-Gp for 64046@debbugs.gnu.org; Thu, 20 Jul 2023 15:54:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1689882836; x=1690487636; i=stephen.berman@gmx.net; bh=vPv4AYAnQk3rJdQz/uc9azifHvssDXePfNtntIC7diw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=qYK3FNkTJMTPUsMqbSFJ0pTXKc5TUmDBEchIBpQFOMZHh/27CJzXhGTQ/0+f4Kfj23OnRe/ vd2Q/CkIu3YlBUBSbM1XtEQ6VZVh/rqkowYtwYCdQaFYjXMF+io3z4TbzkNG2Plys58IorZig n7an3MGeeBX9P1KDTOqFsWFHGwBWFpRGVn3YIe2p68YV9gZSbNCUZ4odWn2zqHOiCxAAXL8+w qHBPAXkoedQaO7PY05fi/cfgHkJ/pgMxZwAJjlgIO6zS0S15TtmCiJwd/Kiabor0qJ2gLlWsT yNU0/64sxdDvMCiSLRnNkrVW6LejraPqW9+QKV+L/OEunUIS/9qA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.37.91]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N6KUT-1ppGA90TIf-016hk8; Thu, 20 Jul 2023 21:53:56 +0200 From: Stephen Berman In-Reply-To: (Mauro Aranda's message of "Thu, 20 Jul 2023 16:11:33 -0300") References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> Date: Thu, 20 Jul 2023 21:53:54 +0200 Message-ID: <87r0p2l5pp.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:oHzbcqGhlV37hpziS731plzfkYmt5R6GlkBgQhS4xXNyB6zN3iw iZIyfgqOegGxdudPacmn9Uitmnkv0MPiY7BG9lZYenRh0rX2T4BfMIUcoVjFRJuOdiw8xM9 mQGcPlLBpvf6g3tsTs8L/7LtXzjA5k7+ozH1rxG2hNYpPZXWke/c2ppnmMCcJ7oBphMdRsk eayD5DSiry+8gQxliLAIQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:q4PBYZBKuQA=;EMa2tGFGvvpzE1wvnitmrcBXqoY 8R2F6b1Iy7ISkiKrktlHE3CY3y0gNywc+LWkvm5Vr05N+jTRpZVrcxRUrDgJgYJH3EJYTMt9i XOW/lVdL0LF/rRMUzRmZQXmfY3VD4Dh5pM+A0y3SfB2nMuVJpNH+y7q/jurM1JhmSj7TLQMwU jHo7QyYVTZeZU95R3oC3NM/eJ4Rx+2zQpwNZeS0kU82pHZOKtTz3yKGLWLl1JhFR17xpYY0ix 43kVGSeBGU/zYZRrWevaJPud5IQVxRlctD5FUTfJ1FCYlnEm0022G0NMqYKvbHQMri1mJ+8kK lBStz5lhtdfjL4pJqVzv5hW7GhGV7Xo2LLI5BBGFW83HKJ5mS5NR7Lbi3tN5fnmum+ijkdHpX HHkqhwUW5H9/8brVotkISffmnom3yjl9YZot6ssREhcSR9K4pmMaroS5wA42a8Acazstnjh/R /XR/2wqNH2zNq8dFbs8uHryLQkeIIzMC8q2LSS2U4vqjAB2G/PDnIDBq2DDnWOEEJeuKoTERA CLV7Yd9wxR8DQtDBCsZFWCwCsE82SSjqkakykVr7MU7OfD8Mxm96GPgWgq0FudtTI+Z+fSQ2+ UC8Hif+dMPbJGV2UUDfUOH0FFP0aUIgapV1mvtCOa9Cz7hNEKO0oQLII0FeMgVrY3hWAPLbmv iC96ZLVQbUJq8rAxDttNAqbrx3V16x8z5wQBL3L3IjN38aoZhpM6Jm5qJwZd+hu2xB16olpSn lqGLdLJJE6a65vH0nI5usYNVThswMPa9I6woH5n1rv0nv0pCHwW6HHepWckdOi3KqjDkGk8IF N9tcGaF3iCXWbmNcYjfn5L5fDodePFs82NIJXdqULbUTLli18KKDJR/xPlgh8lYKQP7N4IdQF Q+5hXaT5OyQS88MmVZwWufwGqe1KCTjdhdS8ArKFtO3wmTdoLBeaJi5PVQ7+ZlDgsy7APvDCV DvI+ow== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, 20 Jul 2023 16:11:33 -0300 Mauro Aranda wr= ote: > Stephen Berman writes: > >> On Sat, 15 Jul 2023 10:20:17 -0300 Mauro Aranda > wrote: >> >>> Turns out this code introduces regressions when customizing faces. >>> >>> With emacs -Q: >>> M-x customize-face RET default >>> Action the State button and choose: "For All Kinds of Displays" >>> Action the Display menu and select "specific display" >>> Wrong type argument: number-or-marker-p, "=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 " >>> >>> The substitute-command-keys operation is too destructive, and messes >>> with things it shouldn't be modifying, like the :offset property of >>> widgets in this case. > >> Sorry for not responding sooner; I was travelling and only now had time >> to look into this.=C2=A0 If I debugged it correctly, the problem is that= the >> value of :extra-offset, 9, satisfies char-or-string-p, so then due to my >> patch substitute-command-keys turns it into a string containing a TAB. > > No trouble at all.=C2=A0 And yes, that sounds correct to me. > >> The cases intended to be fixed by my patch are where strings with grave >> quoting occur, which should be turned into strings with curve quoting. >> If so, then testing for stringp suffices, and the attached patch avoids >> the regression you found and gives the desired results for the other >> cases discussed in this bug.=C2=A0 I don't know why I used char-or-strin= g-p >> instead of stringp in my original patch, and don't see a reason for it >> now.=C2=A0 Or do you know of cases where testing for stringp is insuffic= ient? > > I don't know, but I feel like stringp should suffice.=C2=A0 So please ins= tall > your fix, and I will be alert if something else breaks. Thanks, pushed to master as commit c55e67081e9. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 08:02:01 2023 Received: (at control) by debbugs.gnu.org; 21 Aug 2023 12:02:01 +0000 Received: from localhost ([127.0.0.1]:55738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY3bd-0008ET-0Z for submit@debbugs.gnu.org; Mon, 21 Aug 2023 08:02:01 -0400 Received: from smtp1.axis.com ([195.60.68.17]:34674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY3bb-0008EG-Bp for control@debbugs.gnu.org; Mon, 21 Aug 2023 08:02:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1692619317; x=1724155317; h=from:to:subject:date:message-id:mime-version; bh=4TfiYjEc0tUT1J5MXw1O1Y7EhfLS35TZnheRW5KlNmo=; b=QfOqoHZ+kIYzAjPpwOnFA3xc1K3UtNY7WmtEZqPS17S0zuqRUklD5s/n oWA2svmr4ezbQf88Fa/qfi6SQfCNHt1B03pVELH9zlalBWvrLcbo6CWMy yq/azIS1ESvhHugP97lvwmUdGy6P2TzHq5Gl9kK0cAuNR0OB44TECpxtd P2AyM2TPfXRtak93tpXJnG245FKashqe/E7CGZRvqxcOWCCtRv3+w4HyP D+0tEwifSvSg6PovKcipeAA55vLiy5pxjh/ICEfv2piynmTzixbHMQA20 N4MKpcEQHWERgL7kLCNmsgHmj+59W8gCbXxj0+CqHmLMBGvcqiHFnztW0 g==; User-agent: mu4e 1.8.14; emacs 30.0.50 From: Ola x Nilsson To: Subject: unarchive 64046 Date: Mon, 21 Aug 2023 14:01:01 +0200 Organization: Axis Communications AB Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) unarchive 64046 From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Ola x Nilsson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2023 12:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: Mauro Aranda , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169261951731991 (code B ref 64046); Mon, 21 Aug 2023 12:06:02 +0000 Received: (at 64046) by debbugs.gnu.org; 21 Aug 2023 12:05:17 +0000 Received: from localhost ([127.0.0.1]:55745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY3em-0008Jv-JE for submit@debbugs.gnu.org; Mon, 21 Aug 2023 08:05:16 -0400 Received: from smtp2.axis.com ([195.60.68.18]:32815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY3el-0008Jc-2c for 64046@debbugs.gnu.org; Mon, 21 Aug 2023 08:05:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1692619513; x=1724155513; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=gqRZXge0t5FzBPEUW/Llw33dwa31MjGrfCEakoSdmRo=; b=Zt2MQ64klZqfDi+ZBYY//9bC1FwtO/IOId4tU4rsZwjOa6aQmP98bBuB 5PpXvuNhtve8XmNSiY+RxzNjeyldrJ896BsnXOAiPCB8q1u3Q3XWpBKe6 PNhrVuAu0J3Pgo0Y2l0vJvPuMFr7ITRl2TMpHP62hSiWWx7DLcquUtENH JBEZsoN0Nzjtvoye/xfycKF6N7G6K+n2PEKHhJgCtd3IseivZDMw8D/UU AfXG5WNx6ci18CZJUT0Rcsbz29GaJ/zUycnG/P2i63hBqfBN8swPKcr1y yZ1PUtpcLBvA/p/2cdrjBU1Au1ES5PmyItGKvhgazxT/wVfVsn7YSbZWi w==; From: Ola x Nilsson In-Reply-To: <87r0p2l5pp.fsf@gmx.net> (Stephen Berman's message of "Thu, 20 Jul 2023 21:53:54 +0200") References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> Date: Mon, 21 Aug 2023 14:04:46 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Thu, Jul 20 2023, Stephen Berman wrote: > On Thu, 20 Jul 2023 16:11:33 -0300 Mauro Aranda = wrote: > >> Stephen Berman writes: >> >>> On Sat, 15 Jul 2023 10:20:17 -0300 Mauro Aranda >> wrote: >>> >>>> Turns out this code introduces regressions when customizing faces. >>>> >>>> With emacs -Q: >>>> M-x customize-face RET default >>>> Action the State button and choose: "For All Kinds of Displays" >>>> Action the Display menu and select "specific display" >>>> Wrong type argument: number-or-marker-p, "=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 " >>>> >>>> The substitute-command-keys operation is too destructive, and messes >>>> with things it shouldn't be modifying, like the :offset property of >>>> widgets in this case. >> >>> Sorry for not responding sooner; I was travelling and only now had time >>> to look into this.=C2=A0 If I debugged it correctly, the problem is tha= t the >>> value of :extra-offset, 9, satisfies char-or-string-p, so then due to my >>> patch substitute-command-keys turns it into a string containing a TAB. >> >> No trouble at all.=C2=A0 And yes, that sounds correct to me. >> >>> The cases intended to be fixed by my patch are where strings with grave >>> quoting occur, which should be turned into strings with curve quoting. >>> If so, then testing for stringp suffices, and the attached patch avoids >>> the regression you found and gives the desired results for the other >>> cases discussed in this bug.=C2=A0 I don't know why I used char-or-stri= ng-p >>> instead of stringp in my original patch, and don't see a reason for it >>> now.=C2=A0 Or do you know of cases where testing for stringp is insuffi= cient? >> >> I don't know, but I feel like stringp should suffice.=C2=A0 So please in= stall >> your fix, and I will be alert if something else breaks. > > Thanks, pushed to master as commit c55e67081e9. > > Steve Berman [Resending as the bug was archived]=20 I think I ran into another problem with the change. Using the simple item definitions (described in the docstring), this call=20 (widget-choose "Title" '(("Option1" . "Foo") ("Option 2" . "Bar"))) will fail with (wrong-type-argument (listp "Foo")) Or did I misunderstand how that mode works? /Ola From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2023 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ola x Nilsson , Stephen Berman Cc: 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.16926295096230 (code B ref 64046); Mon, 21 Aug 2023 14:52:02 +0000 Received: (at 64046) by debbugs.gnu.org; 21 Aug 2023 14:51:49 +0000 Received: from localhost ([127.0.0.1]:57471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY6Fw-0001cQ-Op for submit@debbugs.gnu.org; Mon, 21 Aug 2023 10:51:49 -0400 Received: from mail-oo1-xc33.google.com ([2607:f8b0:4864:20::c33]:53563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY6Fv-0001c4-01 for 64046@debbugs.gnu.org; Mon, 21 Aug 2023 10:51:47 -0400 Received: by mail-oo1-xc33.google.com with SMTP id 006d021491bc7-56d8bc0d909so2218853eaf.3 for <64046@debbugs.gnu.org>; Mon, 21 Aug 2023 07:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692629499; x=1693234299; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Dwpx7GYUU60sOSkdV3+JcPbUYHgbcWOuQwfAfFXw1w=; b=TlYOuzViRf5fWh254YdavPoyUrJOc04jEV79d8ptrAysyANzZjfAKEsRptEY6PTYUY gsKw2L5O2h1B6JYlho3AodRzIzjDLdK8EwcL++2rUUb+hswg1gvzDeLKWI5Qv2M6k267 o/o27GnluX1uTDT37EEgiKV6T9Def5iyiFSBdKZkMefOZA+K/Nk8IJfPbwZm3/cG0m+Y UvZHfi6VMM5JPqjazhN7vU4Ys+ZrZzndsAQf/8sGz90cCPIumS7ar9TKDpIWaAPyWldZ oV9pAka7FkLc6fAVgn5C55v4DiaJrQ9uGoeZ0BFt0d3Rk7cJR6i8aXqTAxfPB58x3Uwl c1Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692629499; x=1693234299; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Dwpx7GYUU60sOSkdV3+JcPbUYHgbcWOuQwfAfFXw1w=; b=h7p7b52EK23hU2MWS+aol/wjfnJB36IP7naHEQPxAIn8d7ZybJywqBfmHExu4dabHw lWhQYKgfDVmO4M44vEenYrHCch0W1s9m96wrCVX4UcLq2LZkVJZMPOV8KpLPYBXDud7y kIKKc4ncZXMV7UasG5sLGlb85tX2KSmw2WqjSHovTQQyyy6Xuo5I56Yj7bpHZuFDooZf O3im1RMcssRVsLlEeuiozluSZBK0WaRPcDjz3CSgGNXMd8pH0zZmLRMAULGcsx3YzVYx bTUKiUcGn4POLSTLD/MacsqKTMWIadHdeGWwRBLMleqrwOtm49Lh68JNnStWSm31AJG7 5r0A== X-Gm-Message-State: AOJu0YxtghzGoHZ++83m44VmcaJvi37k72rr6LQXbbc7KmXA60qQf4TM e2S+OT5Ok2dUb7vIZBFAGpo= X-Google-Smtp-Source: AGHT+IHSsH0QBQ40QfCDIsQK6S+cS9Hr1BzA/tq2PbY90eJ/8d0Lsnt8b7NfWlZhmU1ealAgtHDLsA== X-Received: by 2002:a4a:2a43:0:b0:56e:a164:bfad with SMTP id x3-20020a4a2a43000000b0056ea164bfadmr6741749oox.7.1692629499002; Mon, 21 Aug 2023 07:51:39 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id b10-20020a4a98ca000000b0056d2dde4cb7sm3849293ooj.0.2023.08.21.07.51.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 07:51:38 -0700 (PDT) Message-ID: <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> Date: Mon, 21 Aug 2023 11:51:36 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Ola x Nilsson writes: > On Thu, Jul 20 2023, Stephen Berman wrote: > >> On Thu, 20 Jul 2023 16:11:33 -0300 Mauro Aranda >> wrote: >> >>> Stephen Berman writes: >>> >>>> On Sat, 15 Jul 2023 10:20:17 -0300 Mauro Aranda >>>  wrote: >>>> >>>>> Turns out this code introduces regressions when customizing faces. >>>>> >>>>> With emacs -Q: >>>>> M-x customize-face RET default >>>>> Action the State button and choose: "For All Kinds of Displays" >>>>> Action the Display menu and select "specific display" >>>>> Wrong type argument: number-or-marker-p, "        " >>>>> >>>>> The substitute-command-keys operation is too destructive, and messes >>>>> with things it shouldn't be modifying, like the :offset property of >>>>> widgets in this case. >>> >>>> Sorry for not responding sooner; I was travelling and only now had time >>>> to look into this.  If I debugged it correctly, the problem is that the >>>> value of :extra-offset, 9, satisfies char-or-string-p, so then due to my >>>> patch substitute-command-keys turns it into a string containing a TAB. >>> >>> No trouble at all.  And yes, that sounds correct to me. >>> >>>> The cases intended to be fixed by my patch are where strings with grave >>>> quoting occur, which should be turned into strings with curve quoting. >>>> If so, then testing for stringp suffices, and the attached patch avoids >>>> the regression you found and gives the desired results for the other >>>> cases discussed in this bug.  I don't know why I used char-or-string-p >>>> instead of stringp in my original patch, and don't see a reason for it >>>> now.  Or do you know of cases where testing for stringp is insufficient? >>> >>> I don't know, but I feel like stringp should suffice.  So please install >>> your fix, and I will be alert if something else breaks. >> >> Thanks, pushed to master as commit c55e67081e9. >> >> Steve Berman > > [Resending as the bug was archived] > > I think I ran into another problem with the change. > Using the simple item definitions (described in the docstring), this > call > > (widget-choose "Title" '(("Option1" . "Foo") ("Option 2" . "Bar"))) > > will fail with > > (wrong-type-argument (listp "Foo")) Thanks for reporting this. > Or did I misunderstand how that mode works? I think your recipe should work, and it worked before. Hopefully Stephen can take a look at it. From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 12:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: Ola x Nilsson , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169288151518709 (code B ref 64046); Thu, 24 Aug 2023 12:52:02 +0000 Received: (at 64046) by debbugs.gnu.org; 24 Aug 2023 12:51:55 +0000 Received: from localhost ([127.0.0.1]:36342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ9oZ-0004rg-2P for submit@debbugs.gnu.org; Thu, 24 Aug 2023 08:51:55 -0400 Received: from mout.gmx.net ([212.227.15.15]:41015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ9oW-0004rQ-7o for 64046@debbugs.gnu.org; Thu, 24 Aug 2023 08:51:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1692881500; x=1693486300; i=stephen.berman@gmx.net; bh=1YXggXsBKozXdoSd3wKzZ5M2xaypFmjA9k6VqIKKAmo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=p8cVzMRaX4b4OTLwllI0I+l+WyYwK7N4xwtfl8bf5vZl9DkG4nT6rToTUUGa+R3VKWXT6A9 d2poZfqxC+93d3zXgkPGM4OhGwm1VhhUdx6rNwcgTZ2OCG9kYctbJWbiCTcwCVUO7+BpmoKMM 5ughVVeuxVvfdvcqGe+las25h9NT56FdMI5mdUsfYncQ2mHFHa0rY5zJHLFs+ZQ+MKiP/8goL Bn53zOx6y7qSrR4tF0hgKCgoYAZGQSKE1m8Qt2Sab1gVDKeUJI+EH5cq3//Y90peOsulZCfWS FMU6luDARh2b25hwzVuw9KxUQmsiVay0kka1e8Q7XlDhHf7OhAag== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.37.172]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MAONd-1qRm5v1Erb-00BvxS; Thu, 24 Aug 2023 14:51:40 +0200 From: Stephen Berman In-Reply-To: <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> (Mauro Aranda's message of "Mon, 21 Aug 2023 11:51:36 -0300") References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> Date: Thu, 24 Aug 2023 14:51:39 +0200 Message-ID: <87fs48ppr8.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:15OFGuQi3mSja7TKZe70XHiVpu1w+BMv1paaXGyyae1o5Fr0HHb GR55D+0/7D74Las61tmSP249weVamXl72x7P6wMSpE44aWJwSeRtIQCjYoAiOlq4N4QpfHN jZ3gr3viT7liYjDYTp2w5Xldbgn9wwwGtqCz5nPE9jOVmRjFDZ3Sq1+yqe9WtUZ4UNDUVqA 17BtLqaV5fJj9HuOSYxNw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:W6dU7+brJck=;xkrADlvimqZ8izqgt0+ENS9pK3N OnkDlJx3VjbQOZE4UoeBlzt+lsHRacXrNA/iE7JzAbxZ0j1BX9sCICDyKYBKUUBXrfW6lM3i/ VUREj7xZo6TQYLuq/8o8/V/lcfdzzEgBnJSKxeCAUUnEybBEGrEh9vJdGzs/DtQ3UsZ2rTs1r fKcFJ/KdB5z4p+hiZVffjUUO2eZQ5DBmTAMkUvyhnRKxBxLynMmf+wYPS4Sm28sV5VSuA36Em ehw47ZlzawEP9D+qHJ8WlQhwd6HHcCB2c4BMiFoq/XIKdp7IqHDWwshV9EY9aDeCB71lX6UKs WcNoIv96SSC7g16nGGzouxlUZs5zDRSErFo44oKFYPqRnrWEBuVtLhi7OrbiZ9fm2meAgrDBo 4I2SrPJzxm1cWWC56mDZvKx4L0cLGo2QNhRAKjW6KKJMb6v+ouNgWDUaAD8ogB4x2CpWbkIIv w1pBdOUydOXA7lB9Zz0kA9Mcecl5huhsowUcU5HrF6z0M3aXWaL0xgJQLynuo4jSfKkXvWcu3 pc9gpSSkzfK9vfZ2s1haOLX9rV2z9dIc4k6DKcxi+wC3DoN2ZkE6pi1ALvPr3QDaNZ4Wuy9TE aNKwCloNNHeJvDPtK2oUTqVt9Xv0PO4DT207nV7SWGA6Z7Fk5Is9tclmowO6qBRFTk5KmnWvy mMpPi4caxfhv33CBDWR0+ipHwFvWfDf/Eeto2pkPXTuuQoLyOT1nUSVGMAuHEEDEywF/SQuCt 024kDj1StgYxVTuTh5gteN6SUPwDMMaXFpWaiXAI8b0xgtbd8FsBn1bWENuPyvq6oxu8Pc7ld 8gUnwc8YGABd9zoukfTOtrGJooOR91JLmuJuKCR731mUg/aCM8W3fWcbVucacN9eUJicXKhXA aXDxCUk21qE95OQxLp1RSAs+YjyVHGkZ3YWV6PjQo5Mg6g4jkdUj7ef3l22MPyIBAXuOTSKWW 2GTiGA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain On Mon, 21 Aug 2023 11:51:36 -0300 Mauro Aranda wrote: > Ola x Nilsson writes: [...] >> I think I ran into another problem with the change. >> Using the simple item definitions (described in the docstring), this >> call >> >> (widget-choose "Title" '(("Option1" . "Foo") ("Option 2" . "Bar"))) >> >> will fail with >> >> (wrong-type-argument (listp "Foo")) > > Thanks for reporting this. > >> Or did I misunderstand how that mode works? > > I think your recipe should work, and it worked before. > > Hopefully Stephen can take a look at it. Thanks for reporting this regression. The following patch, which tests for proper-list-p instead of consp, fixes the above case and still applies substitute-command-keys correctly in the other cases brought up in this bug: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: widget-choose patch #1 diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index a70598bb6c9..6b4446a0be8 100644 --- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -285,7 +285,7 @@ widget-choose ;; Apply quote substitution to customize choice menu item text, ;; whether it occurs in a widget buffer or in a popup menu. (let ((items (mapc (lambda (x) - (when (consp x) + (when (proper-list-p x) (dotimes (i (1- (length x))) (when (stringp (nth i x)) (setcar (nthcdr i x) --=-=-= Content-Type: text/plain However, if the car and cdr of the simple items are strings containing grave-style quoting, e.g. as in the following: (widget-choose "Title" '(("Use `a'" . "Use `a'") ("Use `b'" . "Use `b'"))) and this quoting is supposed to appear on evaluation as curve-style, then something like the following patch seems to be required: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: widget-choose patch #2 diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index a70598bb6c9..40d7b5b902c 100644 --- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -285,12 +285,17 @@ widget-choose ;; Apply quote substitution to customize choice menu item text, ;; whether it occurs in a widget buffer or in a popup menu. (let ((items (mapc (lambda (x) - (when (consp x) - (dotimes (i (1- (length x))) - (when (stringp (nth i x)) - (setcar (nthcdr i x) - (substitute-command-keys - (car (nthcdr i x)))))))) + (if (proper-list-p x) + (dotimes (i (1- (length x))) + (when (stringp (nth i x)) + (setcar (nthcdr i x) + (substitute-command-keys + (car (nthcdr i x)))))) + ;; ITEMS has simple item definitions. + (when (and (consp x) (stringp (car x)) + (stringp (cdr x))) + (setcar x (substitute-command-keys (car x))) + (setcdr x (substitute-command-keys (cdr x)))))) items))) (cond ((and (< (length items) widget-menu-max-size) event (display-popup-menus-p)) --=-=-= Content-Type: text/plain I don't see any obvious problem with this, but I'm not sure. Steve Berman --=-=-=-- From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 13:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: Ola x Nilsson , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169288318821328 (code B ref 64046); Thu, 24 Aug 2023 13:20:02 +0000 Received: (at 64046) by debbugs.gnu.org; 24 Aug 2023 13:19:48 +0000 Received: from localhost ([127.0.0.1]:36360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZAFX-0005Xw-U0 for submit@debbugs.gnu.org; Thu, 24 Aug 2023 09:19:48 -0400 Received: from mout.gmx.net ([212.227.17.21]:58057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZAFW-0005Xi-6F for 64046@debbugs.gnu.org; Thu, 24 Aug 2023 09:19:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1692883173; x=1693487973; i=stephen.berman@gmx.net; bh=s/geuYW01SBf0uQvjcyaIvq7Jg3Z31AAWaUDAtMEFv0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=bGGf79U2FAtqsYyIkblkwS0NMDeh8oy2Kzsn9xJififTGAG9y0TGlGnSqLeo0+8xZ1bvrNn 2d7CsFlrMHK4F4oiBcyHPFnK4zJ5tIj+FxMYE9hCp3XpG48PSJwUdPVDy9NRKmXQDjRAilV9b BsRtSuPEo9EX2BG3J5F4EPniUdRb6iZ+F1dPJtbY2N83RMEKqRQOXZALrjKt6RcZqCqmI7LK9 2955wHth+1/vcDyl+kveM9ExRpURnn7Yzd8ad5M7erv5GQXltNTl0TVvTP91tN4H1KxXKkmgo 0V6pZcwDiSjqEv1ABPeHhEwjy7JYUQLiWct1vaIGPY3lKB3Kklmg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.37.172]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MCbIx-1qPZrC0yoN-009k81; Thu, 24 Aug 2023 15:19:33 +0200 From: Stephen Berman In-Reply-To: <87fs48ppr8.fsf@gmx.net> (Stephen Berman's message of "Thu, 24 Aug 2023 14:51:39 +0200") References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> Date: Thu, 24 Aug 2023 15:19:32 +0200 Message-ID: <87bkewpogr.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:FviFTcOpyu9NZfQN8FNhHR6kLTqo3amKU6aycrTt6+qdaDpPEZd YmnoDMloo7ntxmx4ovQjDv4+GsDeBsGCqgg9YeFOI6rnw+iTZdSLSG/7y4a7UrcokK5diHx jFgYpeeVN7qkxOtLBKoDXAUvKE/dANm3hbDc0dBqlJUd3xKgXkkgoO9A+v5NUsZtReRpQXS MX3UasqPsHS4klrDx6dCg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:kmbWAGZFOn0=;4FwjOnI5MxqSzE4ZX46wksGciCl DCalz6UNCo0KLLWzvXM3pY5vmkYYxSrDe8SNFDojjxekqFe6REZhaag3mLahN+SUoVICOgvJu 9E7dOZ7F9pfcGH0YuCiUq+K9OqjS7PjJEP0U4XIm1mLUr5fDCdy+lA8NdnLIGx1vySZuxUk7j QhkvtpLWtxPR8Ie5Ud7GcNBfEbX1yOc7EAEl/i/3hySZily+rVmMC42EXt1P4jDai4pDYFzok Ghh+c8ia6ilMr/VFKMjvduwSQcLBYh38KLiSfsNn+inm4POx5/hzPa3AfogqTmmj+ht6kkJP8 Evmy1S2KACaDGaNFayHxBlGeqMrWwRSnWCvw9zkdnRCbXA56x7chdk8ff/kuydnbIg5+FgjtJ xkw/rFVHUJebJf/deCTqYwFneyE/XiLmu+H0jG4xZNeimkgyK+f+A9NBsbFUPD90Pn91XRBQ5 NfMt64YWIxIHTq4NAgZI0rDb3sBfKlo3IjMYoQKf6YF6lVUhU1k2mFpaR20bLbWKEf3/K0mFS tSmk2HKmSn94fPfzjWh9dOEG+e4Dz0z5kiooKVhnpIAp9ZHbyaiZJghYanV++mi/1LfVSvzG+ 2YOi+bRxw6NgB9FFZ3wtDStZDO8dQ82rF3RplpWhnppVzycBdrUaXENlWvtb004otYr89QT+s Nc/7+CbALtTXahfmvp+mpo2v3MIyL34ai/HonzLnDiuqJ+clSh3pho2MrpAaS8WxKPjlRauit FEJFUaZaEsz2LalB2LOZfC2Xg5RSJL7XlnJEQiHlq4HOJOHB/+xY4ByfULg+7lF2tVoDsJhKU EvHcsY0wIAz3Vrn+UzT0IcR5Y0ZPloAR03PuMqMa/1xuedoVJ2EnuT+t0GeALwpJJ0SGjm4B9 8NBIDvjBwNJxK5QrP3LGO+MkJ7MtfmUM1OfYJL75cfo6g76XV4EXyX4yIfrZcNIn9eh8EG2t6 QnY86IaeBvsshu+RDNUu5KwUTNg= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain On Thu, 24 Aug 2023 14:51:39 +0200 Stephen Berman wrote: > On Mon, 21 Aug 2023 11:51:36 -0300 Mauro Aranda wrote: > >> Ola x Nilsson writes: > [...] >>> I think I ran into another problem with the change. >>> Using the simple item definitions (described in the docstring), this >>> call >>> >>> (widget-choose "Title" '(("Option1" . "Foo") ("Option 2" . "Bar"))) >>> >>> will fail with >>> >>> (wrong-type-argument (listp "Foo")) >> >> Thanks for reporting this. >> >>> Or did I misunderstand how that mode works? >> >> I think your recipe should work, and it worked before. >> >> Hopefully Stephen can take a look at it. > > Thanks for reporting this regression. The following patch, which tests > for proper-list-p instead of consp, fixes the above case and still > applies substitute-command-keys correctly in the other cases brought up > in this bug: > > diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el > index a70598bb6c9..6b4446a0be8 100644 > --- a/lisp/wid-edit.el > +++ b/lisp/wid-edit.el > @@ -285,7 +285,7 @@ widget-choose > ;; Apply quote substitution to customize choice menu item text, > ;; whether it occurs in a widget buffer or in a popup menu. > (let ((items (mapc (lambda (x) > - (when (consp x) > + (when (proper-list-p x) > (dotimes (i (1- (length x))) > (when (stringp (nth i x)) > (setcar (nthcdr i x) > > > However, if the car and cdr of the simple items are strings containing > grave-style quoting, e.g. as in the following: > > (widget-choose "Title" '(("Use `a'" . "Use `a'") ("Use `b'" . "Use `b'"))) > > and this quoting is supposed to appear on evaluation as curve-style, > then something like the following patch seems to be required: > > diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el > index a70598bb6c9..40d7b5b902c 100644 > --- a/lisp/wid-edit.el > +++ b/lisp/wid-edit.el > @@ -285,12 +285,17 @@ widget-choose > ;; Apply quote substitution to customize choice menu item text, > ;; whether it occurs in a widget buffer or in a popup menu. > (let ((items (mapc (lambda (x) > - (when (consp x) > - (dotimes (i (1- (length x))) > - (when (stringp (nth i x)) > - (setcar (nthcdr i x) > - (substitute-command-keys > - (car (nthcdr i x)))))))) > + (if (proper-list-p x) > + (dotimes (i (1- (length x))) > + (when (stringp (nth i x)) > + (setcar (nthcdr i x) > + (substitute-command-keys > + (car (nthcdr i x)))))) > + ;; ITEMS has simple item definitions. > + (when (and (consp x) (stringp (car x)) > + (stringp (cdr x))) > + (setcar x (substitute-command-keys (car x))) > + (setcdr x (substitute-command-keys (cdr x)))))) > items))) > (cond ((and (< (length items) widget-menu-max-size) > event (display-popup-menus-p)) > > > I don't see any obvious problem with this, but I'm not sure. Right after sending, I found an obvious problem: only one of the car or the cdr might be a string. The following patch accounts for this: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: widget-choose patch #2 diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index a70598bb6c9..891e98b6de5 100644 --- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -285,12 +285,18 @@ widget-choose ;; Apply quote substitution to customize choice menu item text, ;; whether it occurs in a widget buffer or in a popup menu. (let ((items (mapc (lambda (x) - (when (consp x) - (dotimes (i (1- (length x))) - (when (stringp (nth i x)) - (setcar (nthcdr i x) - (substitute-command-keys - (car (nthcdr i x)))))))) + (if (proper-list-p x) + (dotimes (i (1- (length x))) + (when (stringp (nth i x)) + (setcar (nthcdr i x) + (substitute-command-keys + (car (nthcdr i x)))))) + ;; ITEMS has simple item definitions. + (when (consp x) + (when (stringp (car x)) + (setcar x (substitute-command-keys (car x)))) + (when (stringp (cdr x)) + (setcdr x (substitute-command-keys (cdr x))))))) items))) (cond ((and (< (length items) widget-menu-max-size) event (display-popup-menus-p)) --=-=-= Content-Type: text/plain Steve Berman --=-=-=-- From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 20:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: Ola x Nilsson , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.16929081102096 (code B ref 64046); Thu, 24 Aug 2023 20:16:02 +0000 Received: (at 64046) by debbugs.gnu.org; 24 Aug 2023 20:15:10 +0000 Received: from localhost ([127.0.0.1]:38674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZGjV-0000Xk-MB for submit@debbugs.gnu.org; Thu, 24 Aug 2023 16:15:09 -0400 Received: from mail-oo1-xc31.google.com ([2607:f8b0:4864:20::c31]:52566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZGjT-0000X7-35 for 64046@debbugs.gnu.org; Thu, 24 Aug 2023 16:15:08 -0400 Received: by mail-oo1-xc31.google.com with SMTP id 006d021491bc7-570e88ee36aso180894eaf.1 for <64046@debbugs.gnu.org>; Thu, 24 Aug 2023 13:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692908097; x=1693512897; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8FFh/RHN4kPw0t9cKbsexI7yyffpR+lm3WLkny6jQFU=; b=KjZrk+qk0ZBaXRtxy0od7RFMWAsRi93TRsQl8nOK+/AsC7KIvNbrYgrB4GCTsuqfib AkbJYoVpk1hr1BSZzNVNgC7lVqBmUdRNmDY/45mOYrYq4JzO5YUP2lF/d3qP40mCgxDY IdHFbHLP/kmEruhAQiI2Ge7WCTuJZOqTc5eZiayV/iEZUE4ytE4pXsnWiqheQwvsSuJK Hh/InCUG60lIrtgJOURC9QWh6nSu2W42qsHhKjKBabJdRjcdSTMi28GvM72CWhUtoMh4 WkB9dR/PuaYKL2EqtLe7/KolunLlStMvwNhH8TtYzcs5wuKu7AReaGHaqKW0MvF/9zro G4sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692908097; x=1693512897; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8FFh/RHN4kPw0t9cKbsexI7yyffpR+lm3WLkny6jQFU=; b=JMwm/ZdU7TaXI0KUptDlOxYoEeYpY8ldPiJIbNbWUhZv6KWBtrVTiLB7kdMTqLPik+ rlK6BXGD4UcJyyRIAh/0Lpfig2iGf4T1Pcbp5QTKO7NJpDm+0GGZhRjahfmPl5YpIilw 2BhPqzFFwr66Fn+KPX1JN41hN3gojcAX6oo+7fRR4RfQHaN9XDAqdfDTk2ZH00l80nI0 xe7DOkaOqLF0K4zcAif7R3XA70X5Obuf4Gl/u2v0BBT+GXoaULpx4jFUaYlNcA4P7y+P lNKTJ4X9YOhVfzeNj2ptaQIqKiAJJF0eix4yHYDcpyoZw+fcISdwt0o02dGng4yZWL+c zRiw== X-Gm-Message-State: AOJu0YykLMfWaAas5jWzlo87FWTx7fEI75CM8etyGPERawLRCWehRY43 VoIZMrqYpssy3t8O50u8duk= X-Google-Smtp-Source: AGHT+IFu0kPAyMgeXEB2jyb426jDI5cwVKJTI0lK9SyAme7NkRn2eT6KmaV/O6DviNbeoRXMHwoizg== X-Received: by 2002:a4a:2443:0:b0:571:aceb:26ce with SMTP id v3-20020a4a2443000000b00571aceb26cemr3577007oov.1.1692908096907; Thu, 24 Aug 2023 13:14:56 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id t186-20020a4a54c3000000b00567829a4991sm144807ooa.36.2023.08.24.13.14.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 13:14:56 -0700 (PDT) Message-ID: Date: Thu, 24 Aug 2023 17:14:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> Content-Language: en-US From: Mauro Aranda In-Reply-To: <87bkewpogr.fsf@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Stephen Berman writes: > Right after sending, I found an obvious problem: only one of the car or > the cdr might be a string.  The following patch accounts for this: > > diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el > index a70598bb6c9..891e98b6de5 100644 > --- a/lisp/wid-edit.el > +++ b/lisp/wid-edit.el > @@ -285,12 +285,18 @@ widget-choose >    ;; Apply quote substitution to customize choice menu item text, >    ;; whether it occurs in a widget buffer or in a popup menu. >    (let ((items (mapc (lambda (x) > -                       (when (consp x) > -                         (dotimes (i (1- (length x))) > -                           (when (stringp (nth i x)) > -                             (setcar (nthcdr i x) > - (substitute-command-keys > -                                      (car (nthcdr i x)))))))) > +                       (if (proper-list-p x) > +                           (dotimes (i (1- (length x))) > +                             (when (stringp (nth i x)) > +                               (setcar (nthcdr i x) > + (substitute-command-keys > +                                        (car (nthcdr i x)))))) > +                         ;; ITEMS has simple item definitions. > +                         (when (consp x) > +                           (when (stringp (car x)) > +                             (setcar x (substitute-command-keys (car x)))) > +                           (when (stringp (cdr x)) > +                             (setcdr x (substitute-command-keys (cdr x))))))) Thinking about it, why do we need to call substitute-command-keys on the VALUE part (i.e., the cdr of the cons cell), in case of simple item definitions? I re-read the bug report, but I didn't find any reference to why that is a need.  Did I miss something? (I'll be going on a trip for the weekend, so apologies if I can't see your response soon enough) From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: Ola x Nilsson , Mauro Aranda , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.16929104056307 (code B ref 64046); Thu, 24 Aug 2023 20:54:02 +0000 Received: (at 64046) by debbugs.gnu.org; 24 Aug 2023 20:53:25 +0000 Received: from localhost ([127.0.0.1]:38724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZHKX-0001df-Eb for submit@debbugs.gnu.org; Thu, 24 Aug 2023 16:53:25 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:57584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZHKV-0001dS-Uy for 64046@debbugs.gnu.org; Thu, 24 Aug 2023 16:53:24 -0400 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-52a1ce52ef4so395172a12.2 for <64046@debbugs.gnu.org>; Thu, 24 Aug 2023 13:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692910394; x=1693515194; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Ly+JApOqF0o14l8KWxDVC61vhZ2C6zk5Tn1NoKhAt6E=; b=nmnboE+W74qnCemxARTLPiOUA+ISQTzGGaiWf/m01lxl4lsj/qkjWoUrEnxecMyUSj WXqFckhTEyqjqgYP7kUoW8H6ulJG7VnCima82O8AwyzT5z5ajx0tKvLfkSo75kLIHdld sWBIRff2KbfEG8ciGMDemx/84GMTjxaA+skftfxTMa/2HJEaldjUEqHgoHuCDhR50Rbs AVbuhB62ueeRUMqTMO+kps7MC8X1forB43h2TiKozCIROrZ/Onem6KbTXbhPGgpTkIr/ s4fZFAHEVHxKn0z3yygX6dUjgMWCOpF1hDs7WLfwMGukIUiYPdBTftWNrQSqKDnuECUb nWDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692910394; x=1693515194; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ly+JApOqF0o14l8KWxDVC61vhZ2C6zk5Tn1NoKhAt6E=; b=bx9h1yDvbMXhZToUVswBubwQ7YvVh1ntV/lrsRXMOv56wrvzpwRgig5ebYVWJrWKjm bfDWpGB6OV9dx2GcaZS0E9ExHSjzUl6I7SOUNbntN8z3w3M99aJp+6z92isFjhNR4Poy cQiE+ibBhKhygMmt7Us6ecFqIv6RANYbrihFotTC18buCF65ivDN8t8sXaf5hNWlE8ok zKJn2nmTM02NFNsc4vWfRSL4i2RQlT7EiXZwkRvBzSw2wkqeIOqe3ZeXcg7G2nGgu0W5 N+rqV5ujmCXkrkVy389Mei2hQmCQOTdd3XmzUNNUXxSGIuewilGM6MDOgtlmmDYMA2WA h/sQ== X-Gm-Message-State: AOJu0YxAfoU/ra4zVeRRw/3H2rkA/VwEHr6shLZDH6G/ZbiI/JYs82IP QigKFTZyr8y+nLJv3+GigTHDfImOHW1gYqWm4tM= X-Google-Smtp-Source: AGHT+IFzsjnE66xRTbPEU5oqTXXZ2afP9mroEsVc1QjY1fZeXHTOhVJ2CyL7rudrq8lAVERdg6w6uFcmdeLmlBdeQnk= X-Received: by 2002:aa7:c508:0:b0:522:38cb:d8cb with SMTP id o8-20020aa7c508000000b0052238cbd8cbmr13518931edq.20.1692910393824; Thu, 24 Aug 2023 13:53:13 -0700 (PDT) MIME-Version: 1.0 References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> In-Reply-To: <87bkewpogr.fsf@gmx.net> From: Stefan Kangas Date: Thu, 24 Aug 2023 22:53:02 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el > > index a70598bb6c9..40d7b5b902c 100644 > > --- a/lisp/wid-edit.el > > +++ b/lisp/wid-edit.el > > @@ -285,12 +285,17 @@ widget-choose > > ;; Apply quote substitution to customize choice menu item text, > > ;; whether it occurs in a widget buffer or in a popup menu. Could `substitute-quotes' replace `substitute-command-keys' here? From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: Ola x Nilsson , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.16929105006453 (code B ref 64046); Thu, 24 Aug 2023 20:55:02 +0000 Received: (at 64046) by debbugs.gnu.org; 24 Aug 2023 20:55:00 +0000 Received: from localhost ([127.0.0.1]:38728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZHM3-0001g0-UJ for submit@debbugs.gnu.org; Thu, 24 Aug 2023 16:55:00 -0400 Received: from mout.gmx.net ([212.227.15.18]:55987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZHM2-0001fo-JP for 64046@debbugs.gnu.org; Thu, 24 Aug 2023 16:54:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1692910486; x=1693515286; i=stephen.berman@gmx.net; bh=OMml8JVeOz9XOSSGjSNdXx8uKGBF4RkkYR9svM8OiOo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=XtkwXnsPF+KJY0P3KilZTP66TpoJ/827kzg8ldgk4UIlxRQ1AqxObfQ7xkimcx1UFValk2B BhxU18Cm77GZeDtDAcufndQiPnGJI4voYROcK+untrZiyoYrv3nVku15XHo8syujQujtOXthb jehvy5kLRoFlVJwVfjVlkWKsV+UAlDtW4KjL8jTZ9Q/QEqS34/OXEQvgr42qbcj5Gi/X5BJfu /5FOWydwfUm/pOa2lJolblzffnzGusW2m64Iju5kB6biOjwLBTnQ7kIp4zvmoDJuaaulpUTWH V/HFj8T1oNclym/MOAnsPbLBpfLS7bb7YaP8Aor7BwyB+XC87uYg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.37.172]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mirna-1q3GRm2niu-00eso9; Thu, 24 Aug 2023 22:54:46 +0200 From: Stephen Berman In-Reply-To: (Mauro Aranda's message of "Thu, 24 Aug 2023 17:14:53 -0300") References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> Date: Thu, 24 Aug 2023 22:54:45 +0200 Message-ID: <87h6oo2may.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-Provags-ID: V03:K1:wgWK25A205fopsh+cnIFrwmzGv+D3jhRTGZbca5dJ7g0LMTnbXo 7ttq5PtZ/X6IynmOxDFZ9XwjH8vqFmFHBkuMgH9m3oaGUGnNKFaxvaFrcezksGPzejNE2B6 DtKvRVlcPTUlwkHfs9Nzi4lYfU0UUzxBKNLyleniIxaapceJGYSC6dDwZq+70Zk9S+V68Tq FvP1vUTsz7pEBs58n1hSw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:7dadQPK/JMc=;o2RQxr8XqisIIoYfMGkAjDsGUIX Yzbch5MeuqEWR5fV+tK/iX/VDWDbhVq9MNcWPnwfCzatobH3MsmC2TFpjYMkN/ylUY5B+Skh+ 9WZ/jJr0Jn6ZvG/d2YzOxOurM5EPnKPlo2kDD1lE0QxV7jKS98mPOwDeKeXYk+SuB/pCXVuX9 VN0ES4yOnmj5nItPXVMaWP7NS9rXzxq+hiR06ikMv2o5KFxrRlGiTGyiqE6yZrQgkuwepyznW K5AF8ztEOqSrH9b/NaQPI6MKWxKBocztxY92YuPIK23uzrlRl3znqKk5DfmJwbjkaxJSo5VnS suguzYZnCbnBTpLXpuHEPvbb/pz2vP8iO3987Hbjj4/nB+vuFSPa+as8iTClYK8Rq1u72mNd+ sL4g120OVyiJokvjzkwiY7P33+jathOyVOFjPmojSem/ogNG4uDOY3GO3aLVb5Cx2X2uTlRsk sxGEXH1mb5Tb2Ff/3Ydo0KnxRQM2NwHWObJXh5bmz/nS0EA2lOdvmFHrDIKT/UyWTTgx0vEKt dG5NQ6LMo/toF6BwslGYk2vOBY3zQdiBghJdDnEbSwknk6/NySMQ/ezOtj06TgYoWSotkeHDv Fl6NXbmLk7PMzTEQdemVQeX1YQ47sbW5vI/TTDJC+2yXo+uzv4KJtLKWkosPNGZDo2eQcSRVE pw4SAvdON3Zet0X2jDy+j7hJJMkSXNbGOWr0Y20WQSq6c3+L6XzpsA3oJ8XaRLquhnCEXTuJd 8ftaNSo4yfzIjKlIREnYcYwzZoEs68C6RoJQ3udLaxNuL+nbwSFlsrLDvtAL7mChxlKzGfZY5 6WGf9rE2CmlOWMgtnGspE37Hb0UnwQE7IvtPp7tuSjcPUYLvmEEik/M+KFZfq5j9ybJq5/p7o TZy2AXtuPKmuvEoWGo3RDnl+WsIhBIuCAUZs7JMF4gAHU6kc5fYBFhXVOSkykbSFwjYjIEouv sLaeTUjRnkytMjB0UKQr7QcEZsk= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) T24gVGh1LCAyNCBBdWcgMjAyMyAxNzoxNDo1MyAtMDMwMCBNYXVybyBBcmFuZGEgPG1hdXJvb2Fy YW5kYUBnbWFpbC5jb20+IHdyb3RlOg0KDQo+IFN0ZXBoZW4gQmVybWFuIDxzdGVwaGVuLmJlcm1h bkBnbXgubmV0PiB3cml0ZXM6DQo+DQo+PiBSaWdodCBhZnRlciBzZW5kaW5nLCBJIGZvdW5kIGFu IG9idmlvdXMgcHJvYmxlbTogb25seSBvbmUgb2YgdGhlIGNhciBvcg0KPj4gdGhlIGNkciBtaWdo dCBiZSBhIHN0cmluZy7CoCBUaGUgZm9sbG93aW5nIHBhdGNoIGFjY291bnRzIGZvciB0aGlzOg0K Pj4NCj4+IGRpZmYgLS1naXQgYS9saXNwL3dpZC1lZGl0LmVsIGIvbGlzcC93aWQtZWRpdC5lbA0K Pj4gaW5kZXggYTcwNTk4YmI2YzkuLjg5MWU5OGI2ZGU1IDEwMDY0NA0KPj4gLS0tIGEvbGlzcC93 aWQtZWRpdC5lbA0KPj4gKysrIGIvbGlzcC93aWQtZWRpdC5lbA0KPj4gQEAgLTI4NSwxMiArMjg1 LDE4IEBAIHdpZGdldC1jaG9vc2UNCj4+wqDCoMKgIDs7IEFwcGx5IHF1b3RlIHN1YnN0aXR1dGlv biB0byBjdXN0b21pemUgY2hvaWNlIG1lbnUgaXRlbSB0ZXh0LA0KPj7CoMKgwqAgOzsgd2hldGhl ciBpdCBvY2N1cnMgaW4gYSB3aWRnZXQgYnVmZmVyIG9yIGluIGEgcG9wdXAgbWVudS4NCj4+wqDC oMKgIChsZXQgKChpdGVtcyAobWFwYyAobGFtYmRhICh4KQ0KPj4gLcKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICh3aGVuIChjb25zcCB4KQ0KPj4gLcKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoZG90aW1lcyAoaSAoMS0g KGxlbmd0aCB4KSkpDQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCAod2hlbiAoc3RyaW5ncCAobnRoIGkgeCkpDQo+PiAtwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHNldGNhciAobnRo Y2RyIGkgeCkNCj4+IC0gKHN1YnN0aXR1dGUtY29tbWFuZC1rZXlzDQo+PiAtwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgKGNhciAobnRoY2RyIGkgeCkpKSkpKSkpDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGlmIChwcm9wZXItbGlzdC1wIHgpDQo+PiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoZG90aW1lcyAo aSAoMS0gKGxlbmd0aCB4KSkpDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHdoZW4gKHN0cmluZ3AgKG50aCBpIHgpKQ0KPj4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAoc2V0Y2FyIChudGhjZHIgaSB4KQ0KPj4gKyAoc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMNCj4+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGNhciAobnRoY2RyIGkgeCkpKSkpKQ0KPj4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA7OyBJVEVNUyBoYXMg c2ltcGxlIGl0ZW0gZGVmaW5pdGlvbnMuDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgICh3aGVuIChjb25zcCB4KQ0KPj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHdoZW4gKHN0cmluZ3AgKGNh ciB4KSkNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAoc2V0Y2FyIHggKHN1YnN0aXR1dGUtY29tbWFuZC1rZXlzIChjYXIgeCkpKSkN Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg ICh3aGVuIChzdHJpbmdwIChjZHIgeCkpDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHNldGNkciB4IChzdWJzdGl0dXRlLWNvbW1h bmQta2V5cyAoY2RyDQo+ICAgeCkpKSkpKSkNCj4NCj4gVGhpbmtpbmcgYWJvdXQgaXQsIHdoeSBk byB3ZSBuZWVkIHRvIGNhbGwgc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMgb24gdGhlDQo+IFZBTFVF IHBhcnQgKGkuZS4sIHRoZSBjZHIgb2YgdGhlIGNvbnMgY2VsbCksIGluIGNhc2Ugb2Ygc2ltcGxl IGl0ZW0NCj4gZGVmaW5pdGlvbnM/DQo+DQo+IEkgcmUtcmVhZCB0aGUgYnVnIHJlcG9ydCwgYnV0 IEkgZGlkbid0IGZpbmQgYW55IHJlZmVyZW5jZSB0byB3aHkgdGhhdCBpcw0KPiBhIG5lZWQuwqAg RGlkIEkgbWlzcyBzb21ldGhpbmc/DQoNCldlbGwsIHRoZSBWQUxVRSBpcyBkaXNwbGF5ZWQgb24g ZW50ZXJpbmcgYSBjaG9pY2UuICBUaGF0IGlzLCB3aGVuIEkgZG8NCg0KTS06ICh3aWRnZXQtY2hv b3NlICJUaXRsZSIgJygoIlVzZSBgYSciIC4gIlVzZSBgMSciKSAoIlVzZSBgYiciIC4gIlVzZSBg MiciKSkpDQoNCkkgc2VlIGN1cnZlLXF1b3RpbmcgaW4gdGhlIHdpZGdldC1jaG9vc2UgYnVmZmVy Og0KDQogICBBdmFpbGFibGUgY2hvaWNlczoNCiAgIA0KICAgMCA9IFVzZSDigJhh4oCZDQogICAx ID0gVXNlIOKAmGLigJkNCiAgIA0KICAgQy1nID0gUXVpdA0KDQphbmQgd2hlbiBJIGVudGVyIGUu Zy4gYDAnIGF0IHRoZSAiVGl0bGU6ICIgcHJvbXB0IGluIHRoZSBtaW5pYnVmZmVyLCBpdA0KZGlz cGxheXMgIlVzZSDigJgx4oCZIiwgaS5lLiwgd2l0aCBjdXJ2ZS1xdW90aW5nLiAgQnV0IGlmIEkg b21pdCB0aGUgY2FsbCB0bw0Kc3Vic3RpdHV0ZS1jb21tYW5kLWtleXMgb24gdGhlIGNkciBpbiB3 aWRnZXQtY2hvb3NlLCB0aGVuIHR5cGluZyBgMCcgYXQNCnRoZSAiVGl0bGU6ICIgcHJvbXB0IGRp c3BsYXlzICJVc2UgYDEnIiwgaS5lLiB3aXRoIGdyYXZlLXF1b3RpbmcuICBCdXQgSQ0KZG9uJ3Qg a25vdyB3aGljaCBvbmUgaXMgdGhlIGludGVuZGVkIHJlc3VsdC4NCg0KU3RldmUgQmVybWFuDQo= From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 21:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: Ola x Nilsson , Mauro Aranda , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169291145718232 (code B ref 64046); Thu, 24 Aug 2023 21:11:02 +0000 Received: (at 64046) by debbugs.gnu.org; 24 Aug 2023 21:10:57 +0000 Received: from localhost ([127.0.0.1]:38756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZHbV-0004k0-E9 for submit@debbugs.gnu.org; Thu, 24 Aug 2023 17:10:57 -0400 Received: from mout.gmx.net ([212.227.17.22]:40117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZHbS-0004jm-KZ for 64046@debbugs.gnu.org; Thu, 24 Aug 2023 17:10:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1692911443; x=1693516243; i=stephen.berman@gmx.net; bh=o1y1NSPG/Vt9a+QOemFUp82VOVhyAx3+Ng2reuxv3Ng=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=QTPynw0v687xmj4oNMnpLSGnDbpmnk00gqBXHTNgm0JPv4zW2VVfGr+ZN+d5QpqKjMC6fmg OuDjheWDAvnSjl7U+6otpbJJBkXTUsfcyWqqFPKJ7zOytsWZSFgYn9Vom2JqpxcengWKVLYir hcSykVk8TlmW/I6Bn3Yf/2npsVzrg92L2GKza4/y3EWnXYQ8MteIngcPIYHRYnSO9yzrBn5wC 5uA2i4sF/H7SRa7ZDuCZw+SSlqdGZrg17y0I2MYuGEG+eMdTw5JFfs95b4O5Yw2XS7f02EdTy +z/48xvvezFkkqpxKjt3RcwIl1vYYZf1JHDf6ZcVW37v/w6pzLCQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.37.172]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4Qwg-1pXrK03PEs-011P6G; Thu, 24 Aug 2023 23:10:42 +0200 From: Stephen Berman In-Reply-To: (Stefan Kangas's message of "Thu, 24 Aug 2023 22:53:02 +0200") References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> Date: Thu, 24 Aug 2023 23:10:41 +0200 Message-ID: <87cyzc2lke.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ur7hdNkvT6sHs3CIYRFZlqZSpoBiXASetCgaAEnLJF3cJHIFP/J uD3dDNeAfFFPSBm4BkUE59fv1AT/4pl4kHCRCP3+7+VeTxRbmBiFrqjYQ53S0XEJmbogVEZ Sr5q/d3LdFUxWgGyatf7wTbcO5+dZCOXRcwpx+vBHESB9r6Z+X/qfQ8Odwd4raZ7ujZIixc /ZgmUz+EFR3JVwF4vho5g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:AfFgYkhj6Yg=;Y0Csu//R+C4Ld+wG2O9lUIGQpfM eBkXCbQSdLXJqHEYP2DPQhfYI7Icp7NsdaG+MLKxF91zKn7cQV2H19YZNZBpSM1ouOqWC+lpK Bvyz4NtwcMbFROS2xR3W8w0N+sSUybfhoRMwppAcCmOhKHINO+ejmVAoeV1zQ6UM8jjGMeUV3 rNj+WfqVqmibogfCEdfp2rD/sgyCBzArzd6rU5ANNRszjhtlFzMOaIJyicub9JbRKaMtI+2ci zQXl694AmX977S3+Xfuu3zbYW1fUy9NyEFCN6VaugMlP7pjho/V6mHQYqLZQH1Gqs1RWgbomB mh3kQW29VadtTITL5cBpaljCh2+sC/HYKAFs+Vr9HDem4rMDkDh+BLCjEM4zEKgnZmNG8PvIO ZRQzg6YHleTjhsP0+YNcnfAA5rn5PGYrS3kw7q6K9QyvZnqaSSW2nLHY+qBYcd3KJIvWV0w5u aJRJYQiUemyuHvoFd1/E0rZDoB22ASbWc+/O2+0EtEZlS6cIS+7NqLXyt9i+bGF7CHjagHmMI djrYueR8xFTCDsD/ozDhvVybh3xbru0m/l/wsoqGEwNffhqxk4bENMtuGutZVySRmw00/bedu y/uOSX7Yhgr9lUWuZt4c4kvaEegQACBETcI1GHs3VsNldNCmenyjfO54B5qpgydWd+NFOiTgB IbjFe2leaqtpnnI3233un8369dFysqxqoXy8M4oglgshR12L0oS2m9W0Owwvpp49F61jjdTwj LseAt5k9iXS6avtuplx5ughs/LstJYw62ff54WFWBd32/iZJKMuSRVQKoU9GpuiSOR6uW5EKH JLjwFoddPXBstWsgqmBREYu/vqnI/Kw9LUFNqdi7lmz/NYNlAO4cwEXrwKPBXtqQkY4GGwxcJ PJFBTSoY4ubWnzZcFiXhoB8GGTFP4HzupdKvv4HmgQGpqhrS0e/oeTOtDbK33BD+OyJAbw5c7 WJZDkBWAg+Iqf9A9E3tkVvHCkaU= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, 24 Aug 2023 22:53:02 +0200 Stefan Kangas wrote: >> > diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el >> > index a70598bb6c9..40d7b5b902c 100644 >> > --- a/lisp/wid-edit.el >> > +++ b/lisp/wid-edit.el >> > @@ -285,12 +285,17 @@ widget-choose >> > ;; Apply quote substitution to customize choice menu item text, >> > ;; whether it occurs in a widget buffer or in a popup menu. > > Could `substitute-quotes' replace `substitute-command-keys' here? That indeed gives the same results for the cases discussed in this bug. I used substitute-command-keys because it was already being used in widget-choose before I installed my first change, which expanded its use there. I don't know if there are cases covered by substitute-command-keys and not but substitute-quotes that are relevant for widget-choose; are there? Steve Berman From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 21:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: Ola x Nilsson , Mauro Aranda , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169291166918670 (code B ref 64046); Thu, 24 Aug 2023 21:15:01 +0000 Received: (at 64046) by debbugs.gnu.org; 24 Aug 2023 21:14:29 +0000 Received: from localhost ([127.0.0.1]:38760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZHeu-0004r4-Vr for submit@debbugs.gnu.org; Thu, 24 Aug 2023 17:14:29 -0400 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:44053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZHeu-0004qq-7N for 64046@debbugs.gnu.org; Thu, 24 Aug 2023 17:14:28 -0400 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-52889bc61b6so501287a12.0 for <64046@debbugs.gnu.org>; Thu, 24 Aug 2023 14:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692911657; x=1693516457; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jKWkA+CjeA9NJecY2ovHEvBnI7iPkaP8IUgdYfBlUQY=; b=JBuAjSTI/qpy/abp5/GZ6Nu0BSMRgbsWMCNU2bPANIDh6pk4fXP4td4J+PxbiODTPr I77ARD+0pDcw4G/bWCExCdKUML8GfgnmvBoJJvPgVb7a4vUx0wjKx2GtWIDQa6YMaOsd +8eQai80BKNfyOup23djDia+pys3Pc33t5Ndc1gU9Co91NLQskYBemULkO1BhLiG3L9/ CCfpudNn25mj382taqUMGXy6VXLnki5tcvKq+Nf6JDG9z9MtVf18KpzRnR2BTB6BWxUb GB8JIjHJa62iOZe9KBr+4BF/3DoKc9KiilrYhxmYX6zaiPVv0he1+4W52RGPvbpS4rTj cZig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692911657; x=1693516457; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jKWkA+CjeA9NJecY2ovHEvBnI7iPkaP8IUgdYfBlUQY=; b=B39FTem+s51IphchEXHBG9fjh4+UIdgB4TT3dm7yqkJefD8KlOWMgC+jHQK31MNJCf YvE1myjnIZrc+nIlR7h+t+WK0leM4gXI/2bpw6h/Vq5LGwVdBjhUnuimz7X0EXIMwlyY ClxRc7CApt6s94l9BQ1foQ3bQzdf+L6+wZv503eJmquF3LiqJ0fOywQt3iJ2uwzIamiC y0N+cnneinoBwPdMX8OMSnPgflweQJOGfE/+Kl4VUvGQ7Yg1/xc2b/whUD1fUzPOnskK yagseP02hK7YqWUFEVZnInvhm0BEBzkuFf5gS5LvnK8LeVGPOhAmzf2mx9hFCUmVgLUS mBAA== X-Gm-Message-State: AOJu0YxQX4ui5ZM5dV1MH5PzgBV8UUyaKmqGUTN3p68akzi8JAqrhNmT a843bMfAvKu34iW2snMMj1QuO787Wf9aW3VuENc= X-Google-Smtp-Source: AGHT+IEGVJLloU1GQVdMoIT55QqpRYfPxebCHXntmQoXvP6JAlX9WTY7I/IIZR9cCpfrepKKQbPUeLwxJrcyWWg8VGo= X-Received: by 2002:aa7:da53:0:b0:523:4996:a4f9 with SMTP id w19-20020aa7da53000000b005234996a4f9mr14314977eds.34.1692911657313; Thu, 24 Aug 2023 14:14:17 -0700 (PDT) MIME-Version: 1.0 References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> <87cyzc2lke.fsf@gmx.net> In-Reply-To: <87cyzc2lke.fsf@gmx.net> From: Stefan Kangas Date: Thu, 24 Aug 2023 23:14:06 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > That indeed gives the same results for the cases discussed in this bug. > I used substitute-command-keys because it was already being used in > widget-choose before I installed my first change, which expanded its use > there. I don't know if there are cases covered by > substitute-command-keys and not but substitute-quotes that are relevant > for widget-choose; are there? s-q only handles ` and ', while s-c-k handles full docstring syntax. Does that help answer the question? If we're not sure, the simplification is probably not worth it. From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 21:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: Ola x Nilsson , Mauro Aranda , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169291328421393 (code B ref 64046); Thu, 24 Aug 2023 21:42:02 +0000 Received: (at 64046) by debbugs.gnu.org; 24 Aug 2023 21:41:24 +0000 Received: from localhost ([127.0.0.1]:38771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZI4x-0005Yz-Re for submit@debbugs.gnu.org; Thu, 24 Aug 2023 17:41:24 -0400 Received: from mout.gmx.net ([212.227.17.21]:50965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZI4v-0005Yl-Gm for 64046@debbugs.gnu.org; Thu, 24 Aug 2023 17:41:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1692913270; x=1693518070; i=stephen.berman@gmx.net; bh=cJ7+XZNtEcssTjHk48i4tj2dUs1VbGzHyJM9qBc8Coc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=ByW9LfOCr4eoLCcVPFZMaJIKoDiRk2sb9Sv41hXrfuJi8Ck0R3j+N/bDgfWEWSHE+dze6R4 yWT6nb+ljWi77JJM8BvMiivu+7WOaa2WzfeknGeQHFkMq2Q3Fiuo1e+zUTvHs1ycVXHn4TbHP RNAr2G7h0SzI5BqGdOiZYVbYP6OF4vrPM/rbCED4h/6JufDxozuapPg7gHxJ0C5emQN/q3Ui7 qwtT9pX2mEpaGZOR1WnDyIEBOTf+0yVhl1K0/79AqUGtpwT59VJPz5XO4LA61ghE2tzpFb09c F7usEMcab7FPAnUe/fKaePKlm4vuhyAPyDlsq+gXNw2LuUMJmSPQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.37.172]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MwQXN-1pguTA3IN3-00sJlk; Thu, 24 Aug 2023 23:41:09 +0200 From: Stephen Berman In-Reply-To: (Stefan Kangas's message of "Thu, 24 Aug 2023 23:14:06 +0200") References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> <87cyzc2lke.fsf@gmx.net> Date: Thu, 24 Aug 2023 23:41:08 +0200 Message-ID: <878ra02k5n.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:RrqxYeIPE5EebQfExeQUT+tIa4OxiDcqUnMo1ImOjFVlKoIbQzS vJuGgT2pqywbSRFMwtL4atw6p5+Iyfev2pGNeQyP2vfmBza+qxbRXY8BJB87cyTTDv97UFk t7m6urrTE9v3HYmpK33q9FUREWIuTsoOcGFq3aH5j8rINgA9fNh+m6af4M/0hCg7IUe5qCN /KedC0SIGyjqG+/zFAwWg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ZeKB9B4TrsU=;MrmDiVnre0gLe/OOL34D+xD9bp1 NVtKVPHNq9BaqdRX7aJHtGZmjTDb3C9ETXf1i9OZPHsrfrpFRen943IgPPhmmJNvvStwflWOh EPKc8CpiibDWg//Y35reAe2tFWDDYjZ+W7dIC6QRbUH0gREzgCYKOO8qSsS/Cdp1ZDCZ8MStA /zQxRVgHcmh/iGCqAoDs/JVl2jQU1daEaP5COrMOADRGPtPwVhdHjR4MJf9O8RYQBQ6g19054 UgrC0Np+ovuQ2Oin3PvyFvhpDnRjS/TNe956iknHPUkbJwsv8D9lk14RQWbBYhT6FtX4I1XYM sRdGXQ8qa/6UonSHXnpIKLqtU92heeo71L/7jzBwuLYHfUUD0VUbHYQmQBFHsiIL3tvtXRpDy Pfxjw+PNyDSYyOYEChuBa8TOxnOa4iakhwuX0aNqdLh/TtuVg8DodcEx9jqPzbkW8l9FcoBtM 773vwrE81V4t5m74yDxfJUKI4niM9be2mYqcKcS3AOZo2aqMh/ijjx4cEOE5FdQ4z6ysWdUHT 3YAcXXvdOqWObAlQ58rzDbotJX+kCcEZi1OIHJT692AlOVpHUXqLB0Xr3r0s8btakXCJUdCLg Uo5uGsILsKlQu8jTtRwxr9hE0y3AzJMsvHhVgZy2GB1RGJqAO9bu9jkPUbH295S8a2a/oir/W zLvE3NEpGhUyEJ32Isp3vGLyWEKy/JegwafJKdMnxPVZZiMP1KcdJCZdSwLeBaTh0/xLM6Kcy vz61amph6nkCgRKCkePu1awL6pL8EWqZTaWBMqMrA+24lnkduOOlk26DP2gxm3ovgijJ08dGS aPh8Vgpm29/jX1kHq+eHAgbEegUDb4ArARGl4bjHoH54DwxgWpXykBr2YCs2BQb4TQ9swsAcz ssUz9N2Ql5O1wvQqqvKm6ZNuYnEDjEQZbgCWTmMn16Y5KFUD/keMNLplDKjZBs0xovE17nMZg hJFRQi9XfkYsokJXzlPabndaTbQ= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, 24 Aug 2023 23:14:06 +0200 Stefan Kangas wrote: >> That indeed gives the same results for the cases discussed in this bug. >> I used substitute-command-keys because it was already being used in >> widget-choose before I installed my first change, which expanded its use >> there. I don't know if there are cases covered by >> substitute-command-keys and not but substitute-quotes that are relevant >> for widget-choose; are there? > > s-q only handles ` and ', while s-c-k handles full docstring syntax. > > Does that help answer the question? I had already looked at the code so I saw the difference. But I don't know if there are any uses of widget-choose that include more docstring syntax than quoting, or if anyone might want to use widget-choose in such a way (if it's possible, which I also don't know). > If we're not sure, the simplification is probably not worth it. We could just make the simplification and see if gives rise to complaints. On the other hand, I suspect the overhead of s-c-k would not be very noticeable, unless perhaps someone has a gigantic user option with lots of quoting. Steve Berman From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 22:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: Ola x Nilsson , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169291434823531 (code B ref 64046); Thu, 24 Aug 2023 22:00:02 +0000 Received: (at 64046) by debbugs.gnu.org; 24 Aug 2023 21:59:08 +0000 Received: from localhost ([127.0.0.1]:38797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZIM8-00067T-5N for submit@debbugs.gnu.org; Thu, 24 Aug 2023 17:59:08 -0400 Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]:50260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZIM6-000672-Hr for 64046@debbugs.gnu.org; Thu, 24 Aug 2023 17:59:07 -0400 Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6bca3311b4fso261882a34.0 for <64046@debbugs.gnu.org>; Thu, 24 Aug 2023 14:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692914336; x=1693519136; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l/XeKwSTuBmhqfrYFX4gwuTjmCyU/fERonidfUJFBjc=; b=hURpkHAJ5Y3t34Uv5dn5VcCaXYVkibIFoiP91/7ZJpzDTqr843YFciOGtmQljxZwgU UWCpSfz8wJhCyELeDN7FJZj4kgW3NK+8GzWcEKmmCuhKW5o6F5//zP9F78mfBe1o8kXA AtJp8HDdxJXFsRi6tRSlILMNmh1IhEcc3vPornJ/VuZZzYeL5bkwxjZYuIEYrkiJ+/WO 1XbCMee1PWlTupQ3M4mqNR1BW9X/JZrvUDoN6RuaJLqGo2Y6DRfryjlHpcgdFs/YSk39 mbhr6oJ8RBKw5l7M3gwXtdCaFTzVw6nigzOyCEoInk5ZOZoPF+CdzRaWdbVcG0Cqy1x5 hTRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692914336; x=1693519136; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l/XeKwSTuBmhqfrYFX4gwuTjmCyU/fERonidfUJFBjc=; b=Wzc09IzaT+AjG9RfpdsiW4NBbhlYS+0UNdk10a+fWiSVdvhjIiL4DQPivRtiOeL2y1 RsygLuaWOTyAGrmtrs6YN00oa3mkd4+WiRwg2xXQpr9kOUi7QXwe1jUuZY8IcM1bWKPn ZXJFT93K4gx87J/LCBA44Cl/MBj+p5hHu2u3tXjk/XJs244zjL4vBHJobpkYMYwG1G4g Ml1fwC0+I0PdWztNED5ms6NY50N8sK8vGkvzHj96V9j61FNZSUexKP6a3q6JIZV/c+BS 9len2OqpIEq4+S4q37aK4cfM2VAb57eNSDEq2zbwbOXsI1dUtG8SD45yzUyXF3MlXd90 hhRg== X-Gm-Message-State: AOJu0Yw2s/zWlYN8LORzZcn40eFM3mtBHIeu9Y5qxcMxdUHbsXp3COmi 3vlPuMS/ysjf/0B/QW/ggzM= X-Google-Smtp-Source: AGHT+IE1uqM4hOGM4VzQllMVFoQ2WHnLFnnmg5pY7P+Iegw4wxC+smD013Zm6hcI20ctYG8/ZhDyYQ== X-Received: by 2002:a05:6870:4289:b0:1c7:ebf5:b6cb with SMTP id y9-20020a056870428900b001c7ebf5b6cbmr1154240oah.25.1692914336376; Thu, 24 Aug 2023 14:58:56 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id eg29-20020a056870989d00b001c4d922b4fasm298537oab.8.2023.08.24.14.58.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 14:58:55 -0700 (PDT) Message-ID: <65eb4677-5ae3-5170-1b37-2e02f974c972@gmail.com> Date: Thu, 24 Aug 2023 18:58:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> <87h6oo2may.fsf@gmx.net> From: Mauro Aranda In-Reply-To: <87h6oo2may.fsf@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Stephen Berman writes: > On Thu, 24 Aug 2023 17:14:53 -0300 Mauro Aranda wrote: > >> Stephen Berman writes: >> >>> Right after sending, I found an obvious problem: only one of the car or >>> the cdr might be a string.  The following patch accounts for this: >>> >>> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el >>> index a70598bb6c9..891e98b6de5 100644 >>> --- a/lisp/wid-edit.el >>> +++ b/lisp/wid-edit.el >>> @@ -285,12 +285,18 @@ widget-choose >>>    ;; Apply quote substitution to customize choice menu item text, >>>    ;; whether it occurs in a widget buffer or in a popup menu. >>>    (let ((items (mapc (lambda (x) >>> -                       (when (consp x) >>> -                         (dotimes (i (1- (length x))) >>> -                           (when (stringp (nth i x)) >>> -                             (setcar (nthcdr i x) >>> - (substitute-command-keys >>> -                                      (car (nthcdr i x)))))))) >>> +                       (if (proper-list-p x) >>> +                           (dotimes (i (1- (length x))) >>> +                             (when (stringp (nth i x)) >>> +                               (setcar (nthcdr i x) >>> + (substitute-command-keys >>> +                                        (car (nthcdr i x)))))) >>> +                         ;; ITEMS has simple item definitions. >>> +                         (when (consp x) >>> +                           (when (stringp (car x)) >>> +                             (setcar x (substitute-command-keys (car x)))) >>> +                           (when (stringp (cdr x)) >>> +                             (setcdr x (substitute-command-keys (cdr >>   x))))))) >> >> Thinking about it, why do we need to call substitute-command-keys on the >> VALUE part (i.e., the cdr of the cons cell), in case of simple item >> definitions? >> >> I re-read the bug report, but I didn't find any reference to why that is >> a need.  Did I miss something? > > Well, the VALUE is displayed on entering a choice.  That is, when I do > > M-: (widget-choose "Title" '(("Use `a'" . "Use `1'") ("Use `b'" . "Use `2'"))) > > I see curve-quoting in the widget-choose buffer: > >    Available choices: > >    0 = Use ‘a’ >    1 = Use ‘b’ > >    C-g = Quit > > and when I enter e.g. `0' at the "Title: " prompt in the minibuffer, it > displays "Use ‘1’", i.e., with curve-quoting.  But if I omit the call to > substitute-command-keys on the cdr in widget-choose, then typing `0' at > the "Title: " prompt displays "Use `1'", i.e. with grave-quoting.  But I > don't know which one is the intended result. I see, thank you.  Your last patch looks good to me, then. From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Ola x Nilsson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Aug 2023 08:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mauro Aranda Cc: Stephen Berman , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.16929506761377 (code B ref 64046); Fri, 25 Aug 2023 08:05:02 +0000 Received: (at 64046) by debbugs.gnu.org; 25 Aug 2023 08:04:36 +0000 Received: from localhost ([127.0.0.1]:39195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZRo4-0000M9-3j for submit@debbugs.gnu.org; Fri, 25 Aug 2023 04:04:36 -0400 Received: from smtp1.axis.com ([195.60.68.17]:19713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZRo0-0000Ls-Tf for 64046@debbugs.gnu.org; Fri, 25 Aug 2023 04:04:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1692950668; x=1724486668; h=references:from:to:cc:subject:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=UTSZGzB5eVQWujKrq5h3zSrT4NUhQo3nF3V/iIs/lk4=; b=ASVolFjlmrgVMQYtrWu+v/uAHhA6HWKPumVyIFnxuiq9oB3ophrdaY0p XGW8GqxVp4pHfwlFHnhFXQtjc5zaZUxeEDVCdTLwwrUdPqI2ZMAZrlQAj 7IyvsQyzyEy1E+e8S+ABYKTeQkOaS7BtMzwYdCJcseCL+I6MwUSAwXo8z I5Ko3Uw88bb0Bt35WMxPoHQPRe7lzwnMEvzTN3JnRMC1TOwac3JJz43L0 2ZysHO7JD1QSwKo4ymrMR57oVBw/rIOxCRrmPJ6VSwXFsnKnOi4SMMa0X 5YTxhyYScxmpO2W0ZkOJI44ZRB1CFQ4sMjle3eP23kQ7/VRfetkSGAIbC w==; References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> <87h6oo2may.fsf@gmx.net> <65eb4677-5ae3-5170-1b37-2e02f974c972@gmail.com> User-agent: mu4e 1.8.14; emacs 29.1.50 From: Ola x Nilsson Date: Fri, 25 Aug 2023 10:02:35 +0200 Organization: Axis Communications AB In-Reply-To: <65eb4677-5ae3-5170-1b37-2e02f974c972@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) DQpPbiBUaHUsIEF1ZyAyNCAyMDIzLCBNYXVybyBBcmFuZGEgd3JvdGU6DQoNCj4gU3RlcGhlbiBC ZXJtYW4gPHN0ZXBoZW4uYmVybWFuQGdteC5uZXQ+IHdyaXRlczoNCj4NCj4+IE9uIFRodSwgMjQg QXVnIDIwMjMgMTc6MTQ6NTMgLTAzMDAgTWF1cm8gQXJhbmRhDQo+ICAgPG1hdXJvb2FyYW5kYUBn bWFpbC5jb20+IHdyb3RlOg0KPj4NCj4+PiBTdGVwaGVuIEJlcm1hbiA8c3RlcGhlbi5iZXJtYW5A Z214Lm5ldD4gd3JpdGVzOg0KPj4+DQo+Pj4+IFJpZ2h0IGFmdGVyIHNlbmRpbmcsIEkgZm91bmQg YW4gb2J2aW91cyBwcm9ibGVtOiBvbmx5IG9uZSBvZiB0aGUgY2FyIG9yDQo+Pj4+IHRoZSBjZHIg bWlnaHQgYmUgYSBzdHJpbmcuwqAgVGhlIGZvbGxvd2luZyBwYXRjaCBhY2NvdW50cyBmb3IgdGhp czoNCj4+Pj4NCj4+Pj4gZGlmZiAtLWdpdCBhL2xpc3Avd2lkLWVkaXQuZWwgYi9saXNwL3dpZC1l ZGl0LmVsDQo+Pj4+IGluZGV4IGE3MDU5OGJiNmM5Li44OTFlOThiNmRlNSAxMDA2NDQNCj4+Pj4g LS0tIGEvbGlzcC93aWQtZWRpdC5lbA0KPj4+PiArKysgYi9saXNwL3dpZC1lZGl0LmVsDQo+Pj4+ IEBAIC0yODUsMTIgKzI4NSwxOCBAQCB3aWRnZXQtY2hvb3NlDQo+Pj4+wqDCoMKgIDs7IEFwcGx5 IHF1b3RlIHN1YnN0aXR1dGlvbiB0byBjdXN0b21pemUgY2hvaWNlIG1lbnUgaXRlbSB0ZXh0LA0K Pj4+PsKgwqDCoCA7OyB3aGV0aGVyIGl0IG9jY3VycyBpbiBhIHdpZGdldCBidWZmZXIgb3IgaW4g YSBwb3B1cCBtZW51Lg0KPj4+PsKgwqDCoCAobGV0ICgoaXRlbXMgKG1hcGMgKGxhbWJkYSAoeCkN Cj4+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICh3aGVu IChjb25zcCB4KQ0KPj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIChkb3RpbWVzIChpICgxLSAobGVuZ3RoIHgpKSkNCj4+Pj4gLcKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHdoZW4gKHN0cmluZ3Ag KG50aCBpIHgpKQ0KPj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgKHNldGNhciAobnRoY2RyIGkgeCkNCj4+Pj4gLSAoc3Vic3RpdHV0 ZS1jb21tYW5kLWtleXMNCj4+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChjYXIgKG50aGNkciBpIHgp KSkpKSkpKQ0KPj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgKGlmIChwcm9wZXItbGlzdC1wIHgpDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChkb3RpbWVzIChpICgxLSAobGVuZ3RoIHgpKSkN Cj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgICh3aGVuIChzdHJpbmdwIChudGggaSB4KSkNCj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc2V0Y2FyIChudGhj ZHIgaSB4KQ0KPj4+PiArIChzdWJzdGl0dXRlLWNvbW1hbmQta2V5cw0KPj4+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIChjYXIgKG50aGNkciBpIHgpKSkpKSkNCj4+Pj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA7OyBJVEVNUyBoYXMgc2ltcGxlIGl0 ZW0gZGVmaW5pdGlvbnMuDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKHdoZW4gKGNvbnNwIHgpDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICh3aGVuIChzdHJpbmdwIChjYXIgeCkp DQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCAoc2V0Y2FyIHggKHN1YnN0aXR1dGUtY29tbWFuZC1rZXlzDQo+ICAgICAoY2FyIHgp KSkpDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgICh3aGVuIChzdHJpbmdwIChjZHIgeCkpDQo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc2V0Y2RyIHggKHN1YnN0aXR1 dGUtY29tbWFuZC1rZXlzIChjZHINCj4+PsKgwqAgeCkpKSkpKSkNCj4+Pg0KPj4+IFRoaW5raW5n IGFib3V0IGl0LCB3aHkgZG8gd2UgbmVlZCB0byBjYWxsIHN1YnN0aXR1dGUtY29tbWFuZC1rZXlz IG9uIHRoZQ0KPj4+IFZBTFVFIHBhcnQgKGkuZS4sIHRoZSBjZHIgb2YgdGhlIGNvbnMgY2VsbCks IGluIGNhc2Ugb2Ygc2ltcGxlIGl0ZW0NCj4+PiBkZWZpbml0aW9ucz8NCj4+Pg0KPj4+IEkgcmUt cmVhZCB0aGUgYnVnIHJlcG9ydCwgYnV0IEkgZGlkbid0IGZpbmQgYW55IHJlZmVyZW5jZSB0byB3 aHkgdGhhdCBpcw0KPj4+IGEgbmVlZC7CoCBEaWQgSSBtaXNzIHNvbWV0aGluZz8NCj4+DQo+PiBX ZWxsLCB0aGUgVkFMVUUgaXMgZGlzcGxheWVkIG9uIGVudGVyaW5nIGEgY2hvaWNlLsKgIFRoYXQg aXMsIHdoZW4gSSBkbw0KPj4NCj4+IE0tOiAod2lkZ2V0LWNob29zZSAiVGl0bGUiICcoKCJVc2Ug YGEnIiAuICJVc2UgYDEnIikgKCJVc2UgYGInIg0KPiAgIC4gIlVzZSBgMiciKSkpDQo+Pg0KPj4g SSBzZWUgY3VydmUtcXVvdGluZyBpbiB0aGUgd2lkZ2V0LWNob29zZSBidWZmZXI6DQo+Pg0KPj7C oMKgwqAgQXZhaWxhYmxlIGNob2ljZXM6DQo+Pg0KPj7CoMKgwqAgMCA9IFVzZSDigJhh4oCZDQo+ PsKgwqDCoCAxID0gVXNlIOKAmGLigJkNCj4+DQo+PsKgwqDCoCBDLWcgPSBRdWl0DQo+Pg0KPj4g YW5kIHdoZW4gSSBlbnRlciBlLmcuIGAwJyBhdCB0aGUgIlRpdGxlOiAiIHByb21wdCBpbiB0aGUg bWluaWJ1ZmZlciwgaXQNCj4+IGRpc3BsYXlzICJVc2Ug4oCYMeKAmSIsIGkuZS4sIHdpdGggY3Vy dmUtcXVvdGluZy7CoCBCdXQgaWYgSSBvbWl0IHRoZSBjYWxsIHRvDQo+PiBzdWJzdGl0dXRlLWNv bW1hbmQta2V5cyBvbiB0aGUgY2RyIGluIHdpZGdldC1jaG9vc2UsIHRoZW4gdHlwaW5nIGAwJyBh dA0KPj4gdGhlICJUaXRsZTogIiBwcm9tcHQgZGlzcGxheXMgIlVzZSBgMSciLCBpLmUuIHdpdGgg Z3JhdmUtcXVvdGluZy7CoCBCdXQgSQ0KPj4gZG9uJ3Qga25vdyB3aGljaCBvbmUgaXMgdGhlIGlu dGVuZGVkIHJlc3VsdC4NCj4NCj4gSSBzZWUsIHRoYW5rIHlvdS7CoCBZb3VyIGxhc3QgcGF0Y2gg bG9va3MgZ29vZCB0byBtZSwgdGhlbi4NCg0KVGhlIGNkciBpcyB0aGUgcmV0dXJuIHZhbHVlLCBJ IHdvdWxkIGV4cGVjdCB3aWRnZXQtY2hvb3NlIHRvIG5vdA0KbW9kaWZ5IHRoYXQuIA0KDQotLSAN Ck9sYSB4IE5pbHNzb24NCg== From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Aug 2023 21:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ola x Nilsson Cc: Mauro Aranda , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169300022213164 (code B ref 64046); Fri, 25 Aug 2023 21:51:01 +0000 Received: (at 64046) by debbugs.gnu.org; 25 Aug 2023 21:50:22 +0000 Received: from localhost ([127.0.0.1]:41231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZehB-0003QF-Hy for submit@debbugs.gnu.org; Fri, 25 Aug 2023 17:50:21 -0400 Received: from mout.gmx.net ([212.227.15.15]:36499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZeh4-0003Pp-QV for 64046@debbugs.gnu.org; Fri, 25 Aug 2023 17:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1693000201; x=1693605001; i=stephen.berman@gmx.net; bh=fCTTKTp3uSTQ/NnQjpfdKLLkz6AOLKRafIY103IfRDc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=AU87I5cMpurfIBxde3d59mRUMrLq0RPHjjkTZoPpGkrgGlMyDvy49Tovxw0vRVUjIeTjpck KPXT7Pv0ezvl02KdyPlaRNJpsiEimcRr4fpcQr5ksmMjNUccZCeVxfKwVLfkoCki5kURp4B8P SkQjr/+ZcovrnDQT6LS5iezbt2+DvgBIsZsokSOq6Lfs+AAXP1UhwR6v+iVzjYfY427wL1Al2 nSdfFkRlqUGX2ZUfzsghacyUK3Mw8Kt5zLLrU4Q9XNuVVveWXLR9/7aSqmd0IIdMLKdCY+MY/ 7if2fU93SWEih+iCHj3vB2BdXMDaszF/8k38/VBdgqz6S0+5/E7Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.36.101]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MTRMs-1q8Ckn33AC-00Tjnf; Fri, 25 Aug 2023 23:50:01 +0200 From: Stephen Berman In-Reply-To: (Ola x. Nilsson's message of "Fri, 25 Aug 2023 10:02:35 +0200") References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> <87h6oo2may.fsf@gmx.net> <65eb4677-5ae3-5170-1b37-2e02f974c972@gmail.com> Date: Fri, 25 Aug 2023 23:50:00 +0200 Message-ID: <871qfqiygn.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Cd6o4+O90/LM2SBxhDBQroAqQKbpXR8fUlD+b/poPILMHkYbG4t 2ewHVDf82otdjsgMbJwA5Jt7NOb5WCKwi7zRpMz2jwGEDLGnF9zIrersHOb3aHjiETo27EB 2yhNdZlfpb9u2XhhgvaMnLZVRYBeVcJJ6H63mtIJLegLpTUa8AO7F1gByWBPbe+Rn5rykzo t9aZFh4G46SFWkh3yOPDQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:2d5XsllOb+4=;ysRsnw41Q6e2i1bDzJx22+/+dQX bdbAg/itHNMGveCaygxxQ1yiJpltfo53WbcwAjUeYZaPNSQS/pRxmhpVlC/Mry4D8NT10sR7I 6bURPoVubfphkGwd3oVql84vDZfmJDGfKpemj3hkUf0kS0kTbW2InJzf4pZllvcwtzMfpuSpG q0iZ15HdOlzx74PVjT1RJ+Dv4losKt95ZcSWGI4ZwgIsjjPpvdU1dsnxEmLjYMXYdZQIRI+cV tDa92nMkNz5qvAfSSK1Yfmq+ZGghbYAWxuInrEMrT11Aa2YeJA/lCIP8zQO2p2+Cd+QXR7AEz dJ5g68XA18KbJqOJ3htNKHd42lxEDxt6L1EL9O3gEN2g1egLcnmH+AkXEvLgiAIRrdAnx3pta XKAwT7JOwHTtF/0926W2Q3GuEuJTQJAgSTLsRJ3oxSYT+NO0T0p2DSXeoy15+DZjuk9kobKfX dGr4AI+jNJhNfHf3dceaKawFuq4aUNr7jwCccJaEnrwqcasklpfT4CoH8ZmLWlVoJJdIkaUZb 63HJzRgmFWIZ/sRE3Kb88RWjsALU9Q4Wr7vnLz5Um7PtnVlol84KJXtKHI+oGdfSiz9vjK5zZ /rgdLelo9bNeb/m2IjqiE0S8b2jESjZh3KO24EgJcCRWXValVAPGbm7AoaborfWg1xSlLoIA+ DQdHgR3YmpwB9mktxvxf1ltrShAo5rVPLSAlEVRcrVCqQ4pR1Iq3qYiILOGga/McW5ctgu6rS G7KnB4fFYtWgRvkrCKtH5p7oZkSfeq4E3Y/+RbKq8rxLnkj6gLmhxA7a5BBd4/RgA5f+6XsiB H5Mw3asg5v0t5Ff72DbM8h0+4e0QifRvlcfHPCGzypkg42PdU0RGeoOJ50VJYglooMWtl+N+3 iC/HxA8sul6OiotEu56q0oUYTyMpdtP6f+EQy/71obpQZg90XtSOatSfZ3QVe8vbabL7+N2Oi ESJSQw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, 25 Aug 2023 10:02:35 +0200 Ola x Nilsson w= rote: > On Thu, Aug 24 2023, Mauro Aranda wrote: > >> Stephen Berman writes: >> >>> On Thu, 24 Aug 2023 17:14:53 -0300 Mauro Aranda >> wrote: [...] >>>> Thinking about it, why do we need to call substitute-command-keys on t= he >>>> VALUE part (i.e., the cdr of the cons cell), in case of simple item >>>> definitions? >>>> >>>> I re-read the bug report, but I didn't find any reference to why that = is >>>> a need.=C2=A0 Did I miss something? >>> >>> Well, the VALUE is displayed on entering a choice.=C2=A0 That is, when = I do >>> >>> M-: (widget-choose "Title" '(("Use `a'" . "Use `1'") ("Use `b'" >> . "Use `2'"))) >>> >>> I see curve-quoting in the widget-choose buffer: >>> >>>=C2=A0=C2=A0=C2=A0 Available choices: >>> >>>=C2=A0=C2=A0=C2=A0 0 =3D Use =E2=80=98a=E2=80=99 >>>=C2=A0=C2=A0=C2=A0 1 =3D Use =E2=80=98b=E2=80=99 >>> >>>=C2=A0=C2=A0=C2=A0 C-g =3D Quit >>> >>> and when I enter e.g. `0' at the "Title: " prompt in the minibuffer, it >>> displays "Use =E2=80=981=E2=80=99", i.e., with curve-quoting.=C2=A0 But= if I omit the call to >>> substitute-command-keys on the cdr in widget-choose, then typing `0' at >>> the "Title: " prompt displays "Use `1'", i.e. with grave-quoting.=C2=A0= But I >>> don't know which one is the intended result. >> >> I see, thank you.=C2=A0 Your last patch looks good to me, then. > > The cdr is the return value, I would expect widget-choose to not > modify that.=20 I think this is indeed the correct expectation and I should have recognized it instead of looking only at appearances. But do you agree that applying (at least) quote substitution to the car of the simple item definition is appropriate here? If so, there is still the question of whether to use substitute-command-keys or just substitute-quotes. I'm inclined to stick with the former but would be fine with going with the latter. Steve Berman From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Ola x Nilsson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Aug 2023 09:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: Mauro Aranda , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169321560818008 (code B ref 64046); Mon, 28 Aug 2023 09:41:02 +0000 Received: (at 64046) by debbugs.gnu.org; 28 Aug 2023 09:40:08 +0000 Received: from localhost ([127.0.0.1]:47009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaYj9-0004gO-La for submit@debbugs.gnu.org; Mon, 28 Aug 2023 05:40:08 -0400 Received: from smtp2.axis.com ([195.60.68.18]:12855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaYj7-0004fo-Ae for 64046@debbugs.gnu.org; Mon, 28 Aug 2023 05:40:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1693215599; x=1724751599; h=references:from:to:cc:subject:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=aAPsTF87Q6jO++E78DU2bmyHts9S//QVpCZ3wFolfi8=; b=H5PXAK1hDrV8d4xBtRquXFo66rszpiBTnD8F8Dz8/0q6rOpG9gNsxKej TbrFvgB22jqxRJDJ6ilLAk39KYaA24dN32tHOODFWjeKM8NQl5sThjtTr OyfmVs6KFb7t15pPwcNJngAO3eMRBHer0JPADZ6P18M+g5UDLgXB5zPrs cT2dglmqBm5SjYM4UzKuXM7FClcxaf6qw/Af3h5CogBSQLV/MS6SVn2G1 Nvb5N7lJM1syuE3P460x2+hRx3ik9o6Fp/dOWXsiUnhqsOmAWIWK4odIm yQXd6+kqbZgjGvBgW+79+0vk9tKpCrBuMbSumT//Gge01nmjqo+Az9ZIp w==; References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> <87h6oo2may.fsf@gmx.net> <65eb4677-5ae3-5170-1b37-2e02f974c972@gmail.com> <871qfqiygn.fsf@gmx.net> User-agent: mu4e 1.8.14; emacs 30.0.50 From: Ola x Nilsson Date: Mon, 28 Aug 2023 11:33:09 +0200 Organization: Axis Communications AB In-Reply-To: <871qfqiygn.fsf@gmx.net> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Fri, Aug 25 2023, Stephen Berman wrote: > On Fri, 25 Aug 2023 10:02:35 +0200 Ola x Nilsson = wrote: > >> On Thu, Aug 24 2023, Mauro Aranda wrote: >> >>> Stephen Berman writes: >>> >>>> On Thu, 24 Aug 2023 17:14:53 -0300 Mauro Aranda >>> wrote: > [...] >>>>> Thinking about it, why do we need to call substitute-command-keys on = the >>>>> VALUE part (i.e., the cdr of the cons cell), in case of simple item >>>>> definitions? >>>>> >>>>> I re-read the bug report, but I didn't find any reference to why that= is >>>>> a need.=C2=A0 Did I miss something? >>>> >>>> Well, the VALUE is displayed on entering a choice.=C2=A0 That is, when= I do >>>> >>>> M-: (widget-choose "Title" '(("Use `a'" . "Use `1'") ("Use `b'" >>> . "Use `2'"))) >>>> >>>> I see curve-quoting in the widget-choose buffer: >>>> >>>>=C2=A0=C2=A0=C2=A0 Available choices: >>>> >>>>=C2=A0=C2=A0=C2=A0 0 =3D Use =E2=80=98a=E2=80=99 >>>>=C2=A0=C2=A0=C2=A0 1 =3D Use =E2=80=98b=E2=80=99 >>>> >>>>=C2=A0=C2=A0=C2=A0 C-g =3D Quit >>>> >>>> and when I enter e.g. `0' at the "Title: " prompt in the minibuffer, it >>>> displays "Use =E2=80=981=E2=80=99", i.e., with curve-quoting.=C2=A0 Bu= t if I omit the call to >>>> substitute-command-keys on the cdr in widget-choose, then typing `0' at >>>> the "Title: " prompt displays "Use `1'", i.e. with grave-quoting.=C2= =A0 But I >>>> don't know which one is the intended result. >>> >>> I see, thank you.=C2=A0 Your last patch looks good to me, then. >> >> The cdr is the return value, I would expect widget-choose to not >> modify that.=20 > > I think this is indeed the correct expectation and I should have > recognized it instead of looking only at appearances. But do you agree > that applying (at least) quote substitution to the car of the simple > item definition is appropriate here? If so, there is still the question > of whether to use substitute-command-keys or just substitute-quotes. > I'm inclined to stick with the former but would be fine with going with > the latter. I agree that quote substition should be done on the car of simple item definitions. I have no opinion on susbstitute-command-keys vs substitute-quotes. But I came to think about the TITLE argument, shouldn't quote substition be performed on it as well? /Ola From unknown Fri Aug 08 15:18:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64046: 30.0.50; Quoting in customize choice tags Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Aug 2023 13:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ola x Nilsson Cc: Mauro Aranda , 64046@debbugs.gnu.org Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.169323063022867 (code B ref 64046); Mon, 28 Aug 2023 13:51:01 +0000 Received: (at 64046) by debbugs.gnu.org; 28 Aug 2023 13:50:30 +0000 Received: from localhost ([127.0.0.1]:47438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qacdS-0005wl-17 for submit@debbugs.gnu.org; Mon, 28 Aug 2023 09:50:30 -0400 Received: from mout.gmx.net ([212.227.17.21]:45797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qacdP-0005wU-Sc for 64046@debbugs.gnu.org; Mon, 28 Aug 2023 09:50:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1693230612; x=1693835412; i=stephen.berman@gmx.net; bh=/35x9Ya+NzeRGHtGobeRDejNtlUW9/cycJ8eVO43IwQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Vp1lSlAIli38XibJKiGavQjPQxc9ngDCFUjU3tlx2Jcf5ySIM0noX+TH32iCyq1uAQVt6FF y8GW0J97e81xsUtEgg0HQ6QWdRzv7HsdkKasCmke47E1b7JPU/FiZJYWrou4z/mgC9lvTvRm9 JUNEK+ltUBwgMVjcrBXvTrD3lmaiDwM28q/y70BEbwjmQP94gKxK7LQlhxGJ0L2YIBmdZEuvE UWsxUKmaEOb6CC0OaFYt+8azaejs9CqTb+Q1a2LI5VcJE1CYXeWGwhYBFTlKfYxYlq0ChwUvN U6CR5XVvCVNlPd0F1MabNdmaEv285JrP/+PdTvHXDaoTq8ffFbgw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfssd ([89.246.36.68]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJE6F-1qHj0C3Is7-00KcwQ; Mon, 28 Aug 2023 15:50:11 +0200 From: Stephen Berman In-Reply-To: (Ola x. Nilsson's message of "Mon, 28 Aug 2023 11:33:09 +0200") References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> <87fs48ppr8.fsf@gmx.net> <87bkewpogr.fsf@gmx.net> <87h6oo2may.fsf@gmx.net> <65eb4677-5ae3-5170-1b37-2e02f974c972@gmail.com> <871qfqiygn.fsf@gmx.net> Date: Mon, 28 Aug 2023 15:50:10 +0200 Message-ID: <87r0nnmg31.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:tr30QfEJ/G3BfX62WLdAaPA/Ei0yhympUWTl3a5dMCFEgQChD/6 NEUuoRMdcKVjL55VWx7d7KaqVcxl7zzicD6QEG4DwJJ5a2E+OU5wiog5TOdF4ZbS5vZKWv3 hCQzlQW6C+dFZtzki6o5KhNU/WlUPG30lyyUFTD9zyq5IQjvPkAbnQ++2Eqg3s+omXx5syZ HdR8ZVzEscEKcmosqw/RQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:FCVxjgYYXqY=;MWbdaPQpxrf1Xhuv1xu47hbfYkm VssqYH9j2ZXjlZWNCCsuyiPvRdjHggQpZNgQGRhWYn7nJjs6aq+NlQ23ZBA0r98npq216V7iM yaVkri/9bomALl+e26jl2rar6UxM8PTxXu8LJ6IOwS8BFlhFmeA+VQQDpBU7Oo7GpRwWngpJu tovUybAttFV5Ekc/tFNyNourdbl9gqWxNdaYv7n0/c65EHXMIJKdsNs2rgwr95rRoCh3T0Fio lhDjwmlDIXxJI7XcQwacWHBZvn9DLOgFO+InxtSmmj4RK70/6jimYE9MIOEXbG3/3Wr02tDX0 W+Je/E9ZtFeY3l8tasGfkzVQZCtG0Mj1kET4ZFZsS+CapraeTYMR+TcMKjPZmt+UVnWSCQEku 5dF6zcvxEv/aYQEDRlSo0yGeXFojgYaPm51wyd9xB8vYCoHbssQDgQLkLWB7vvEUXvp/qW7TE rtyF9/xH5b0apQh/1Vmruddh4dqJuy7kCzDeQD9xxskHtpwr5O+NrGK0tjyEgC+bp9sX5Mc1Y U/jCXernpqjq55634ky2fUB4g2+PmWJtjtKh3wAst0lUmLXhCNAIJWvgZ5vrD7kOE+0Oi46CD R40NSkshPxI9HaoF18hc0yua5YHkD1rR4g9StQ84+yMca1QNFoU0WV7tX5rqnq4DC9XXefixN AM79UX9H4HvuS+K77CZqJ9imi85qG/5vRGp2liM8YigAKCAzfKTTpMuMpUg0CMiwSVCx1EAYU v2oDuPCQ6jD/NqPZhb/zao4gO2xdH7i2jQ9YFxUlP9JGzARsL94F1UeWQZbpTlkQjSq+p5gRS 6ImG4lYK5E3mWNN5yNfOI8OuwscP0XenoLhVLzUljdvNaTXZIumkdSAspQh2huj7xB/F6E85F B243EndrXtnTWNjcHpjIGyX7DV55dkKztoyQi2XILf7GEsscWGPm4FqfO/FA6sWkA2Dx+oZfH XUDNoJlwpD+NMChOILBL/A6qXCM= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, 28 Aug 2023 11:33:09 +0200 Ola x Nilsson w= rote: > On Fri, Aug 25 2023, Stephen Berman wrote: > >> On Fri, 25 Aug 2023 10:02:35 +0200 Ola x Nilsson wrote: >> >>> On Thu, Aug 24 2023, Mauro Aranda wrote: >>> >>>> Stephen Berman writes: >>>> >>>>> On Thu, 24 Aug 2023 17:14:53 -0300 Mauro Aranda >>>> wrote: >> [...] >>>>>> Thinking about it, why do we need to call substitute-command-keys on= the >>>>>> VALUE part (i.e., the cdr of the cons cell), in case of simple item >>>>>> definitions? >>>>>> >>>>>> I re-read the bug report, but I didn't find any reference to why tha= t is >>>>>> a need.=C2=A0 Did I miss something? >>>>> >>>>> Well, the VALUE is displayed on entering a choice.=C2=A0 That is, whe= n I do >>>>> >>>>> M-: (widget-choose "Title" '(("Use `a'" . "Use `1'") ("Use `b'" >>>> . "Use `2'"))) >>>>> >>>>> I see curve-quoting in the widget-choose buffer: >>>>> >>>>>=C2=A0=C2=A0=C2=A0 Available choices: >>>>> >>>>>=C2=A0=C2=A0=C2=A0 0 =3D Use =E2=80=98a=E2=80=99 >>>>>=C2=A0=C2=A0=C2=A0 1 =3D Use =E2=80=98b=E2=80=99 >>>>> >>>>>=C2=A0=C2=A0=C2=A0 C-g =3D Quit >>>>> >>>>> and when I enter e.g. `0' at the "Title: " prompt in the minibuffer, = it >>>>> displays "Use =E2=80=981=E2=80=99", i.e., with curve-quoting.=C2=A0 B= ut if I omit the call to >>>>> substitute-command-keys on the cdr in widget-choose, then typing `0' = at >>>>> the "Title: " prompt displays "Use `1'", i.e. with grave-quoting.=C2= =A0 But I >>>>> don't know which one is the intended result. >>>> >>>> I see, thank you.=C2=A0 Your last patch looks good to me, then. >>> >>> The cdr is the return value, I would expect widget-choose to not >>> modify that.=20 >> >> I think this is indeed the correct expectation and I should have >> recognized it instead of looking only at appearances. But do you agree >> that applying (at least) quote substitution to the car of the simple >> item definition is appropriate here? If so, there is still the question >> of whether to use substitute-command-keys or just substitute-quotes. >> I'm inclined to stick with the former but would be fine with going with >> the latter. > > I agree that quote substition should be done on the car of simple item > definitions. I have no opinion on susbstitute-command-keys vs > substitute-quotes. But I came to think about the TITLE argument, > shouldn't quote substition be performed on it as well? I think you're right about that as well, since the title is simply a display feature. AFAIK it wouldn't make a noticeable difference for existing uses of widget-choose in the Customize UI (in the Value menu the title is simply "Choice" and in the State menu it's "Operation on