GNU bug report logs - #64042
[PATCH] gnu: image: Build partitions with only necessary inputs.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64042 in the body.
You can then email your comments to 64042 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH] gnu: image: Build partitions with only necessary inputs.
Date: Tue, 13 Jun 2023 13:53:20 +0300

* gnu/system/image.scm (system-disk-image)[partition-image]: Adjust the
inputs used by the image-builder to only use the packages necessary to
build that partition.
---
 gnu/system/image.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/system/image.scm b/gnu/system/image.scm
index 958ba5cbb2..81346495c2 100644
--- a/gnu/system/image.scm
+++ b/gnu/system/image.scm
@@ -418,7 +418,14 @@ (define* (system-disk-image image
               (with-imported-modules*
                (let ((initializer (or #$(partition-initializer partition)
                                       initialize-root-partition))
-                     (inputs '#+(list e2fsprogs fakeroot dosfstools mtools))
+                     (inputs '#+(cond
+                                  ((string-prefix? "ext" type)
+                                   (list e2fsprogs fakeroot))
+                                  ((or (string=? type "vfat")
+                                       (string-prefix? "fat" type))
+                                   (list dosfstools fakeroot mtools))
+                                  (else
+                                    '())))
                      (image-root "tmp-root"))
                  (sql-schema #$schema)
 

base-commit: b188c41d930dbe8142c1f377d3c8f2580ff1277c
prerequisite-patch-id: 2ed36a7d0b049eb3bad8e16c2c167735bc8fbee1
prerequisite-patch-id: 68db7897e7d9cdcb940175892e8f5b0637a27cb1
prerequisite-patch-id: 830b043d4bee7ea66530e11972e65ad390b89ece
prerequisite-patch-id: 55858a370c68c4b64ccadd34a3e03e22bfb3cc7d
prerequisite-patch-id: bc9f36d509bee03fcbc238acb6ba722c32e5f7aa
prerequisite-patch-id: b8b557edd1da6a6347928d5b6fe9728f71e69d58
-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Message #8 received at 64042 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 64042 <at> debbugs.gnu.org
Subject: Re: bug#64042: [PATCH] gnu: image: Build partitions with only
 necessary inputs.
Date: Sun, 18 Jun 2023 23:30:36 +0200

Hi,

Efraim Flashner <efraim <at> flashner.co.il> skribis:

> * gnu/system/image.scm (system-disk-image)[partition-image]: Adjust the
> inputs used by the image-builder to only use the packages necessary to
> build that partition.

LGTM!

Ludo’.

Message #13 received at 64042-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 64042-done <at> debbugs.gnu.org
Subject: Re: bug#64042: [PATCH] gnu: image: Build partitions with only
 necessary inputs.
Date: Mon, 19 Jun 2023 16:33:22 +0300

[Message part 1 (text/plain, inline)]

Patch pushed!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.