GNU bug report logs - #64034
[PATCH] libparted: link libparted-fs-resize.so to libuuid

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64034 in the body.
You can then email your comments to 64034 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Khem Raj <raj.khem <at> gmail.com>
To: bug-parted <at> gnu.org
Cc: Khem Raj <raj.khem <at> gmail.com>
Subject: [PATCH] libparted: link libparted-fs-resize.so to libuuid
Date: Mon, 12 Jun 2023 10:55:19 -0700

uuid_generate() is used in this library
Hence, add UUID_LIBS to libparted_fs_resize_la_LIBADD to avoid

"ld.lld: error: undefined reference due to --no-allow-shlib-undefined: uuid_generate"

This is uncovered by lld linker linking fatresize package
due to this linker defaulting to --no-allow-shlib-undefined.

Signed-off-by: Khem Raj <raj.khem <at> gmail.com>
---
 libparted/fs/Makefile.am | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libparted/fs/Makefile.am b/libparted/fs/Makefile.am
index 41a60d9..7fa8d14 100644
--- a/libparted/fs/Makefile.am
+++ b/libparted/fs/Makefile.am
@@ -75,6 +75,7 @@ libparted_fs_resize_la_LDFLAGS =		\
 EXTRA_DIST += fsresize.sym
 libparted_fs_resize_la_DEPENDENCIES = $(sym_file)
 
+libparted_fs_resize_la_LIBADD  = $(UUID_LIBS)
 libparted_fs_resize_la_SOURCES = \
   r/filesys.c			\
   r/fat/bootsector.c		\
-- 
2.41.0

Message #10 received at 64034-done <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: Khem Raj <raj.khem <at> gmail.com>
Cc: 64034-done <at> debbugs.gnu.org
Subject: Re: bug#64034: [PATCH] libparted: link libparted-fs-resize.so to
 libuuid
Date: Tue, 13 Jun 2023 13:00:08 -0700

On Mon, Jun 12, 2023 at 10:55:19AM -0700, Khem Raj wrote:
> uuid_generate() is used in this library
> Hence, add UUID_LIBS to libparted_fs_resize_la_LIBADD to avoid
> 
> "ld.lld: error: undefined reference due to --no-allow-shlib-undefined: uuid_generate"
> 
> This is uncovered by lld linker linking fatresize package
> due to this linker defaulting to --no-allow-shlib-undefined.

Thanks! Merged into master.

Brian

-- 
Brian C. Lane (PST8PDT) - weldr.io - lorax - parted - pykickstart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.