Subject: [bug#64012] [PATCH v2] gnu: libxml2: Update to 2.11.4

From: Liliana Marie Prikler <[email-masked]>
Date: Mon, 12 Jun 2023 20:40:16 +0200

Hi Andy,

Am Montag, dem 12.06.2023 um 01:47 -0700 schrieb Andy Tai:
> * gnu/packages/xml.scm (libxml2): Update to 2.11.4
That's a world rebuild.  Use a graft instead.

>   (python-libxml2) [arguments] phase: (configure): Invoke
>   autoge.sh explicitly first as now setup.py is generated
>   from autotools configure step
Use a pre-configure bootstrap phase instead to invoke autogen.sh.
Proper ChangeLog would be (python-libxml2)[#:phases]: Add ‘bootstrap’
or (python-libxml2)[arguments]<#:phases>: Add ‘bootstrap’.

>   [inputs]: Add autotools so autotools configure step can run
You don't need to justify the obvious.  When something about the patch
is not obvious, it ought to be explained before the ChangeLog.

> * gnu/packages/patches/python-libxml2-utf8.patch: Remove as
>   patch no longer necessary; original issue fixed upstream
>   (see
> https://gitlab.gnome.org/GNOME/libxml2/-/commit/76c6da420923f2721a2e16adfcef8707a2454a1b
> )
Removed file is enough.

> * gnu/local.mk: Remove reference to deleted patch
It's always nice to mention dist_patch_DATA :)

Cheers