From unknown Tue Jun 17 01:48:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6400: I want to stay with a sibling window Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jun 2010 08:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6400 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6400@debbugs.gnu.org Cc: martin rudalics X-Debbugs-Original-To: Emacs Bugs Received: via spool by submit@debbugs.gnu.org id=B.127624486917092 (code B ref -1); Fri, 11 Jun 2010 08:28:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jun 2010 08:27:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMzad-0004Rd-Uf for submit@debbugs.gnu.org; Fri, 11 Jun 2010 04:27:48 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMzac-0004RV-Fa for submit@debbugs.gnu.org; Fri, 11 Jun 2010 04:27:47 -0400 Received: from lists.gnu.org ([199.232.76.165]:42840) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMzaZ-0004o1-Lv for submit@debbugs.gnu.org; Fri, 11 Jun 2010 04:27:43 -0400 Received: from [140.186.70.92] (port=35218 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMzaY-0006zN-9q for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 04:27:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMzaT-0002jF-U7 for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 04:27:42 -0400 Received: from mail-gw0-f41.google.com ([74.125.83.41]:35134) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMzaT-0002j2-RP for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 04:27:37 -0400 Received: by gwaa18 with SMTP id a18so55851gwa.0 for ; Fri, 11 Jun 2010 01:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:cc:content-type; bh=EdosDGjGVpeTM9CocZfUvtzaM+YlSlGJ06uWyH1yB7E=; b=ArVinEn7p08vke3TAQGpCda/++DSdK9/nxDF8x9DJeCi5pL/745hu4lQtVN6ezLdxx Ow2JLdA6UOjTlkZ2aH2A7mfGbF7KqI+HYJDlGdffhUUd8oBA9/5B1O+Pcd7Lm5kJ/lHz KcOf/m0o6PqsPIwxB8dAxrSb3S91/tWEvWYi4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:cc:content-type; b=g+TlBHCVPvZxDlaS07/HhZCAXM4w0bl5LBTSf4hvZfN5Si5e1ATPpy0cpi0TZUYrVQ z5VB6WUPDBHYf7KbvQnuQ21ofb/XgS05Hbk8jb+wV22Ozd+LXVHyx88dVzN3/f1T6HjI vGiYqyaNVJkepogceIQcf+4LXivn4kTnwzDio= Received: by 10.101.105.22 with SMTP id h22mr1325695anm.35.1276244854254; Fri, 11 Jun 2010 01:27:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.15 with HTTP; Fri, 11 Jun 2010 01:27:14 -0700 (PDT) From: Lennart Borgman Date: Fri, 11 Jun 2010 10:27:14 +0200 Message-ID: Content-Type: multipart/mixed; boundary=001636c925882f2c9c0488bce979 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) --001636c925882f2c9c0488bce979 Content-Type: text/plain; charset=UTF-8 A small patch to make the selected window one of the siblings when the selected window is deleted. I do not understand the code so I am not sure this is correct. Martin? --001636c925882f2c9c0488bce979 Content-Type: text/x-patch; charset=US-ASCII; name="window-del-sel-sibling-1.diff" Content-Disposition: attachment; filename="window-del-sel-sibling-1.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gaar7hzg0 PT09IG1vZGlmaWVkIGZpbGUgJ3NyYy93aW5kb3cuYycNCi0tLSB0cnVuay9zcmMvd2luZG93LmMJ MjAxMC0wNi0wNyAxODoyODowMiArMDAwMA0KKysrIHBhdGNoZWQvc3JjL3dpbmRvdy5jCTIwMTAt MDYtMTEgMDg6MTc6NDMgKzAwMDANCkBAIC0xNTYzLDYgKzE1NjMsNyBAQA0KICAgcmVnaXN0ZXIg c3RydWN0IHdpbmRvdyAqcDsNCiAgIHJlZ2lzdGVyIHN0cnVjdCB3aW5kb3cgKnBhcjsNCiAgIHN0 cnVjdCBmcmFtZSAqZjsNCisgIGludCBkaWRfc2VsZWN0ID0gMDsNCiANCiAgIC8qIEJlY2F1c2Ug dGhpcyBmdW5jdGlvbiBpcyBjYWxsZWQgYnkgb3RoZXIgQyBjb2RlIG9uIG5vbi1sZWFmDQogICAg ICB3aW5kb3dzLCB0aGUgQ0hFQ0tfTElWRV9XSU5ET1cgbWFjcm8gd291bGQgY2hva2UgaW5hcHBy b3ByaWF0ZWx5LA0KQEAgLTE2MjgsNyArMTYyOSwxMCBAQA0KIAkgICBkZWxldGUgdGhlIHNlbGVj dGVkIHdpbmRvdyBvbiBhbnkgb3RoZXIgZnJhbWUsIHdlIHNob3VsZG4ndCBkbw0KIAkgICBhbnl0 aGluZyBidXQgc2V0IHRoZSBmcmFtZSdzIHNlbGVjdGVkX3dpbmRvdyBzbG90LiAgKi8NCiAJaWYg KEVRIChGUkFNRV9TRUxFQ1RFRF9XSU5ET1cgKGYpLCBzZWxlY3RlZF93aW5kb3cpKQ0KLQkgIEZz ZWxlY3Rfd2luZG93IChzd2luZG93LCBRbmlsKTsNCisgICAgICAgICAgew0KKyAgICAgICAgICAg IEZzZWxlY3Rfd2luZG93IChzd2luZG93LCBRbmlsKTsNCisgICAgICAgICAgICBkaWRfc2VsZWN0 ID0gMTsNCisgICAgICAgICAgfQ0KIAllbHNlDQogCSAgRlJBTUVfU0VMRUNURURfV0lORE9XIChm KSA9IHN3aW5kb3c7DQogICAgICAgfQ0KQEAgLTE3NTgsNiArMTc2MiwxMCBAQA0KICAgLyogQWRq dXN0IGdseXBoIG1hdHJpY2VzLiAqLw0KICAgYWRqdXN0X2dseXBocyAoZik7DQogICBVTkJMT0NL X0lOUFVUOw0KKw0KKyAgaWYgKGRpZF9zZWxlY3QpDQorICAgIGlmICghTklMUCAoc2liKSkNCisg ICAgICBGc2VsZWN0X3dpbmRvdyAoc2liLCBRbmlsKTsNCiB9DQogDQogDQpAQCAtMzc2NSw3ICsz NzczLDcgQEANCiAgICAgICB3aW5kb3cgPSBkaXNwbGF5X2J1ZmZlciAoYnVmLCBRbmlsLCBRbmls KTsNCiANCiAgICAgICBpZiAoIUVRIChYV0lORE9XICh3aW5kb3cpLT5mcmFtZSwgc2VsZWN0ZWRf ZnJhbWUpKQ0KLQlGbWFrZV9mcmFtZV92aXNpYmxlIChXSU5ET1dfRlJBTUUgKFhXSU5ET1cgKHdp bmRvdykpKTsNCisJRm1ha2VfZnJhbWVfdmlzaWJsZSAoV0lORE9XX0ZSQU1FIChYV0lORE9XICh3 aW5kb3cpKSwgUW5pbCk7DQogICAgICAgVm1pbmlidWZfc2Nyb2xsX3dpbmRvdyA9IHdpbmRvdzsN CiAgICAgICB3ID0gWFdJTkRPVyAod2luZG93KTsNCiAgICAgICBYU0VURkFTVElOVCAody0+aHNj cm9sbCwgMCk7DQoNCg== --001636c925882f2c9c0488bce979-- From unknown Tue Jun 17 01:48:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6400: I want to stay with a sibling window Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jun 2010 13:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6400 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lennart Borgman Cc: Emacs Bugs Received: via spool by submit@debbugs.gnu.org id=B.127626254528273 (code B ref -1); Fri, 11 Jun 2010 13:23:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jun 2010 13:22:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ON4Bk-0007Ly-Ps for submit@debbugs.gnu.org; Fri, 11 Jun 2010 09:22:25 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ON4Bi-0007Lt-La for submit@debbugs.gnu.org; Fri, 11 Jun 2010 09:22:23 -0400 Received: from lists.gnu.org ([199.232.76.165]:37233) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ON4Bd-0002Kk-Ll for submit@debbugs.gnu.org; Fri, 11 Jun 2010 09:22:17 -0400 Received: from [140.186.70.92] (port=49432 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ON4BY-00064m-KK for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 09:22:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ON4BW-000831-Kp for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 09:22:12 -0400 Received: from mail.gmx.net ([213.165.64.20]:54994) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1ON4BW-00082a-82 for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 09:22:10 -0400 Received: (qmail invoked by alias); 11 Jun 2010 13:22:08 -0000 Received: from 62-47-33-63.adsl.highway.telekom.at (EHLO [62.47.33.63]) [62.47.33.63] by mail.gmx.net (mp001) with SMTP; 11 Jun 2010 15:22:08 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/kS5k/XxrkZ4MnApF4N1B9+uwG3l4++g+rygn3R8 EsyQjTPilSAOWb Message-ID: <4C12387F.1000706@gmx.at> Date: Fri, 11 Jun 2010 15:22:07 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) > A small patch to make the selected window one of the siblings when the > selected window is deleted. > > I do not understand the code so I am not sure this is correct. Martin? if (EQ (FRAME_SELECTED_WINDOW (f), selected_window)) This conditional checks only whether f is the selected frame. You probably want to make sib the frame's selected window whenever you delete the frame's selected window. if (!EQ (XWINDOW (window)->frame, selected_frame)) - Fmake_frame_visible (WINDOW_FRAME (XWINDOW (window))); + Fmake_frame_visible (WINDOW_FRAME (XWINDOW (window)), Qnil); And you almost certainly want to tell us what this is meant for ;-) martin From unknown Tue Jun 17 01:48:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6400: I want to stay with a sibling window Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jun 2010 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6400 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Emacs Bugs Received: via spool by submit@debbugs.gnu.org id=B.12762759132371 (code B ref -1); Fri, 11 Jun 2010 17:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jun 2010 17:05:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ON7fN-0000cC-6O for submit@debbugs.gnu.org; Fri, 11 Jun 2010 13:05:13 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ON7fK-0000c7-Qn for submit@debbugs.gnu.org; Fri, 11 Jun 2010 13:05:11 -0400 Received: from lists.gnu.org ([199.232.76.165]:46909) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ON7fG-0007Jk-8o for submit@debbugs.gnu.org; Fri, 11 Jun 2010 13:05:06 -0400 Received: from [140.186.70.92] (port=49455 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ON7fE-00059E-Hj for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 13:05:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ON7fD-0000OS-Cp for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 13:05:04 -0400 Received: from mail-gy0-f169.google.com ([209.85.160.169]:47959) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ON7fD-0000OJ-9i for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 13:05:03 -0400 Received: by gyg4 with SMTP id 4so1068737gyg.0 for ; Fri, 11 Jun 2010 10:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=v6O8Z/9+rUKD5veJ9NgktWS5WMCvYtLp1QaYWdq4yOY=; b=YAnCYH94RZQHZVzolQk5SvJzIxmBfR7fz4wmvLbWrQQ9euealkWMziSyATU3kSHHo4 SDgZ4rdWREdjSSq9pE/WzJniaUljtLvSuUXwd3+3hcNaosQqG5rAyYtEz6flfaZoPpUJ jQs+fBGDI6rHUoPAx5Jb8ESFBlFJSYZN9nKEs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=cs3XlykgdgQA7pn1wDjHRBuIeDohXB70rikMdEA48wv+jTuXfQAxbIyHFenBUoSQZ9 2sqDf32tgDxNZhr48lf4a9GtUva6UIjxttI2BL7Xprs+Ip0gaBIXX3U5WJzno7wKdnkO QtMUXl6i6pNc0YzN+g9/ogLLBxLvZ0LBzu430= Received: by 10.101.113.6 with SMTP id q6mr1906972anm.254.1276275902525; Fri, 11 Jun 2010 10:05:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.15 with HTTP; Fri, 11 Jun 2010 10:04:42 -0700 (PDT) In-Reply-To: <4C12387F.1000706@gmx.at> References: <4C12387F.1000706@gmx.at> From: Lennart Borgman Date: Fri, 11 Jun 2010 19:04:42 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On Fri, Jun 11, 2010 at 3:22 PM, martin rudalics wrote: >> A small patch to make the selected window one of the siblings when the >> selected window is deleted. >> >> I do not understand the code so I am not sure this is correct. Martin? > > =C2=A0 =C2=A0 =C2=A0 =C2=A0if (EQ (FRAME_SELECTED_WINDOW (f), selected_wi= ndow)) > > This conditional checks only whether f is the selected frame. =C2=A0You > probably want to make sib the frame's selected window whenever you > delete the frame's selected window. Yes, that is what I want. There is a bug in the patch. I assumed that if "sib" was non-nil then it would be a buffer window. That is not the case so a check of that must be made. The most simple is to add another check with WINDOW_LIVE_P. > =C2=A0 =C2=A0 =C2=A0 if (!EQ (XWINDOW (window)->frame, selected_frame)) > - =C2=A0 =C2=A0 =C2=A0 Fmake_frame_visible (WINDOW_FRAME (XWINDOW (window= ))); > + =C2=A0 =C2=A0 =C2=A0 Fmake_frame_visible (WINDOW_FRAME (XWINDOW (window= )), Qnil); > > And you almost certainly want to tell us what this is meant for ;-) Eh, forgot I had this little patch there... ;-) I have added a second optional arg to make-frame-visible: dont-activate. This is for use with top-most windows etc. I will come back to that when I have time. From unknown Tue Jun 17 01:48:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6400: I want to stay with a sibling window Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Jun 2010 17:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6400 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lennart Borgman Cc: Emacs Bugs Received: via spool by submit@debbugs.gnu.org id=B.12762764182576 (code B ref -1); Fri, 11 Jun 2010 17:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jun 2010 17:13:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ON7nW-0000fV-HT for submit@debbugs.gnu.org; Fri, 11 Jun 2010 13:13:38 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ON7nU-0000fO-68 for submit@debbugs.gnu.org; Fri, 11 Jun 2010 13:13:37 -0400 Received: from lists.gnu.org ([199.232.76.165]:48977) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ON7nP-0007T2-FZ for submit@debbugs.gnu.org; Fri, 11 Jun 2010 13:13:31 -0400 Received: from [140.186.70.92] (port=33299 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ON7nO-0000w0-0x for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 13:13:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ON7nM-00026m-DP for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 13:13:29 -0400 Received: from mail.gmx.net ([213.165.64.20]:50452) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1ON7nM-00026X-02 for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 13:13:28 -0400 Received: (qmail invoked by alias); 11 Jun 2010 17:13:26 -0000 Received: from 62-47-33-63.adsl.highway.telekom.at (EHLO [62.47.33.63]) [62.47.33.63] by mail.gmx.net (mp048) with SMTP; 11 Jun 2010 19:13:26 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX184wIQFjRY4CH1h/KisNsiymDXjxuxldE8N+OWn+o oAHx17FF2MOx7B Message-ID: <4C126EB5.6010309@gmx.at> Date: Fri, 11 Jun 2010 19:13:25 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 References: <4C12387F.1000706@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) > There is a bug in the patch. I assumed that if "sib" was non-nil then > it would be a buffer window. That is not the case so a check of that > must be made. The most simple is to add another check with > WINDOW_LIVE_P. Indeed. BTW note that the entire job of finding swindow was already geared towards making the deletion of internal windows possible. martin From unknown Tue Jun 17 01:48:00 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Lennart Borgman Subject: bug#6400: closed (Re: I want to stay with a sibling window) Message-ID: References: <4E940CE4.1020303@gmx.at> X-Gnu-PR-Message: they-closed 6400 X-Gnu-PR-Package: emacs Reply-To: 6400@debbugs.gnu.org Date: Tue, 11 Oct 2011 09:32:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1318325523-32266-1" This is a multi-part message in MIME format... ------------=_1318325523-32266-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #6400: I want to stay with a sibling window which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 6400@debbugs.gnu.org. --=20 6400: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6400 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1318325523-32266-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 6400-done) by debbugs.gnu.org; 11 Oct 2011 09:31:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDYgY-0008Nk-NH for submit@debbugs.gnu.org; Tue, 11 Oct 2011 05:31:42 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1RDYgV-0008NY-QN for 6400-done@debbugs.gnu.org; Tue, 11 Oct 2011 05:31:41 -0400 Received: (qmail invoked by alias); 11 Oct 2011 09:31:17 -0000 Received: from 62-47-40-241.adsl.highway.telekom.at (EHLO [62.47.40.241]) [62.47.40.241] by mail.gmx.net (mp007) with SMTP; 11 Oct 2011 11:31:17 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/6BlVxyHH6uj6UP/9uqATuvRjNXJo0fGfTxrfRwB +FRJmL0UQw1IMf Message-ID: <4E940CE4.1020303@gmx.at> Date: Tue, 11 Oct 2011 11:31:16 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: 6400-done@debbugs.gnu.org Subject: Re: I want to stay with a sibling window Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 6400-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) > A small patch to make the selected window one of the siblings when the > selected window is deleted. When the selected window is deleted emacs now selects the most recently selected live window on that frame instead. martin ------------=_1318325523-32266-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Jun 2010 08:27:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMzad-0004Rd-Uf for submit@debbugs.gnu.org; Fri, 11 Jun 2010 04:27:48 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMzac-0004RV-Fa for submit@debbugs.gnu.org; Fri, 11 Jun 2010 04:27:47 -0400 Received: from lists.gnu.org ([199.232.76.165]:42840) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMzaZ-0004o1-Lv for submit@debbugs.gnu.org; Fri, 11 Jun 2010 04:27:43 -0400 Received: from [140.186.70.92] (port=35218 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMzaY-0006zN-9q for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 04:27:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMzaT-0002jF-U7 for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 04:27:42 -0400 Received: from mail-gw0-f41.google.com ([74.125.83.41]:35134) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMzaT-0002j2-RP for bug-gnu-emacs@gnu.org; Fri, 11 Jun 2010 04:27:37 -0400 Received: by gwaa18 with SMTP id a18so55851gwa.0 for ; Fri, 11 Jun 2010 01:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:cc:content-type; bh=EdosDGjGVpeTM9CocZfUvtzaM+YlSlGJ06uWyH1yB7E=; b=ArVinEn7p08vke3TAQGpCda/++DSdK9/nxDF8x9DJeCi5pL/745hu4lQtVN6ezLdxx Ow2JLdA6UOjTlkZ2aH2A7mfGbF7KqI+HYJDlGdffhUUd8oBA9/5B1O+Pcd7Lm5kJ/lHz KcOf/m0o6PqsPIwxB8dAxrSb3S91/tWEvWYi4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:cc:content-type; b=g+TlBHCVPvZxDlaS07/HhZCAXM4w0bl5LBTSf4hvZfN5Si5e1ATPpy0cpi0TZUYrVQ z5VB6WUPDBHYf7KbvQnuQ21ofb/XgS05Hbk8jb+wV22Ozd+LXVHyx88dVzN3/f1T6HjI vGiYqyaNVJkepogceIQcf+4LXivn4kTnwzDio= Received: by 10.101.105.22 with SMTP id h22mr1325695anm.35.1276244854254; Fri, 11 Jun 2010 01:27:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.15 with HTTP; Fri, 11 Jun 2010 01:27:14 -0700 (PDT) From: Lennart Borgman Date: Fri, 11 Jun 2010 10:27:14 +0200 Message-ID: Subject: I want to stay with a sibling window To: Emacs Bugs Content-Type: multipart/mixed; boundary=001636c925882f2c9c0488bce979 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit Cc: martin rudalics X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) --001636c925882f2c9c0488bce979 Content-Type: text/plain; charset=UTF-8 A small patch to make the selected window one of the siblings when the selected window is deleted. I do not understand the code so I am not sure this is correct. Martin? --001636c925882f2c9c0488bce979 Content-Type: text/x-patch; charset=US-ASCII; name="window-del-sel-sibling-1.diff" Content-Disposition: attachment; filename="window-del-sel-sibling-1.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gaar7hzg0 PT09IG1vZGlmaWVkIGZpbGUgJ3NyYy93aW5kb3cuYycNCi0tLSB0cnVuay9zcmMvd2luZG93LmMJ MjAxMC0wNi0wNyAxODoyODowMiArMDAwMA0KKysrIHBhdGNoZWQvc3JjL3dpbmRvdy5jCTIwMTAt MDYtMTEgMDg6MTc6NDMgKzAwMDANCkBAIC0xNTYzLDYgKzE1NjMsNyBAQA0KICAgcmVnaXN0ZXIg c3RydWN0IHdpbmRvdyAqcDsNCiAgIHJlZ2lzdGVyIHN0cnVjdCB3aW5kb3cgKnBhcjsNCiAgIHN0 cnVjdCBmcmFtZSAqZjsNCisgIGludCBkaWRfc2VsZWN0ID0gMDsNCiANCiAgIC8qIEJlY2F1c2Ug dGhpcyBmdW5jdGlvbiBpcyBjYWxsZWQgYnkgb3RoZXIgQyBjb2RlIG9uIG5vbi1sZWFmDQogICAg ICB3aW5kb3dzLCB0aGUgQ0hFQ0tfTElWRV9XSU5ET1cgbWFjcm8gd291bGQgY2hva2UgaW5hcHBy b3ByaWF0ZWx5LA0KQEAgLTE2MjgsNyArMTYyOSwxMCBAQA0KIAkgICBkZWxldGUgdGhlIHNlbGVj dGVkIHdpbmRvdyBvbiBhbnkgb3RoZXIgZnJhbWUsIHdlIHNob3VsZG4ndCBkbw0KIAkgICBhbnl0 aGluZyBidXQgc2V0IHRoZSBmcmFtZSdzIHNlbGVjdGVkX3dpbmRvdyBzbG90LiAgKi8NCiAJaWYg KEVRIChGUkFNRV9TRUxFQ1RFRF9XSU5ET1cgKGYpLCBzZWxlY3RlZF93aW5kb3cpKQ0KLQkgIEZz ZWxlY3Rfd2luZG93IChzd2luZG93LCBRbmlsKTsNCisgICAgICAgICAgew0KKyAgICAgICAgICAg IEZzZWxlY3Rfd2luZG93IChzd2luZG93LCBRbmlsKTsNCisgICAgICAgICAgICBkaWRfc2VsZWN0 ID0gMTsNCisgICAgICAgICAgfQ0KIAllbHNlDQogCSAgRlJBTUVfU0VMRUNURURfV0lORE9XIChm KSA9IHN3aW5kb3c7DQogICAgICAgfQ0KQEAgLTE3NTgsNiArMTc2MiwxMCBAQA0KICAgLyogQWRq dXN0IGdseXBoIG1hdHJpY2VzLiAqLw0KICAgYWRqdXN0X2dseXBocyAoZik7DQogICBVTkJMT0NL X0lOUFVUOw0KKw0KKyAgaWYgKGRpZF9zZWxlY3QpDQorICAgIGlmICghTklMUCAoc2liKSkNCisg ICAgICBGc2VsZWN0X3dpbmRvdyAoc2liLCBRbmlsKTsNCiB9DQogDQogDQpAQCAtMzc2NSw3ICsz NzczLDcgQEANCiAgICAgICB3aW5kb3cgPSBkaXNwbGF5X2J1ZmZlciAoYnVmLCBRbmlsLCBRbmls KTsNCiANCiAgICAgICBpZiAoIUVRIChYV0lORE9XICh3aW5kb3cpLT5mcmFtZSwgc2VsZWN0ZWRf ZnJhbWUpKQ0KLQlGbWFrZV9mcmFtZV92aXNpYmxlIChXSU5ET1dfRlJBTUUgKFhXSU5ET1cgKHdp bmRvdykpKTsNCisJRm1ha2VfZnJhbWVfdmlzaWJsZSAoV0lORE9XX0ZSQU1FIChYV0lORE9XICh3 aW5kb3cpKSwgUW5pbCk7DQogICAgICAgVm1pbmlidWZfc2Nyb2xsX3dpbmRvdyA9IHdpbmRvdzsN CiAgICAgICB3ID0gWFdJTkRPVyAod2luZG93KTsNCiAgICAgICBYU0VURkFTVElOVCAody0+aHNj cm9sbCwgMCk7DQoNCg== --001636c925882f2c9c0488bce979-- ------------=_1318325523-32266-1--