GNU bug report logs - #6400
I want to stay with a sibling window

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6400 in the body.
You can then email your comments to 6400 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Cc: martin rudalics <rudalics <at> gmx.at>
Subject: I want to stay with a sibling window
Date: Fri, 11 Jun 2010 10:27:14 +0200

[Message part 1 (text/plain, inline)]

A small patch to make the selected window one of the siblings when the
selected window is deleted.

I do not understand the code so I am not sure this is correct. Martin?

[window-del-sel-sibling-1.diff (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: Re: I want to stay with a sibling window
Date: Fri, 11 Jun 2010 15:22:07 +0200

> A small patch to make the selected window one of the siblings when the
> selected window is deleted.
>
> I do not understand the code so I am not sure this is correct. Martin?

 	if (EQ (FRAME_SELECTED_WINDOW (f), selected_window))

This conditional checks only whether f is the selected frame.  You
probably want to make sib the frame's selected window whenever you
delete the frame's selected window.

       if (!EQ (XWINDOW (window)->frame, selected_frame))
-	Fmake_frame_visible (WINDOW_FRAME (XWINDOW (window)));
+	Fmake_frame_visible (WINDOW_FRAME (XWINDOW (window)), Qnil);

And you almost certainly want to tell us what this is meant for ;-)

martin

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: Re: I want to stay with a sibling window
Date: Fri, 11 Jun 2010 19:04:42 +0200

On Fri, Jun 11, 2010 at 3:22 PM, martin rudalics <rudalics <at> gmx.at> wrote:
>> A small patch to make the selected window one of the siblings when the
>> selected window is deleted.
>>
>> I do not understand the code so I am not sure this is correct. Martin?
>
>        if (EQ (FRAME_SELECTED_WINDOW (f), selected_window))
>
> This conditional checks only whether f is the selected frame.  You
> probably want to make sib the frame's selected window whenever you
> delete the frame's selected window.


Yes, that is what I want.

There is a bug in the patch. I assumed that if "sib" was non-nil then
it would be a buffer window. That is not the case so a check of that
must be made. The most simple is to add another check with
WINDOW_LIVE_P.


>       if (!EQ (XWINDOW (window)->frame, selected_frame))
> -       Fmake_frame_visible (WINDOW_FRAME (XWINDOW (window)));
> +       Fmake_frame_visible (WINDOW_FRAME (XWINDOW (window)), Qnil);
>
> And you almost certainly want to tell us what this is meant for ;-)


Eh, forgot I had this little patch there... ;-)

I have added a second optional arg to make-frame-visible:
dont-activate. This is for use with top-most windows etc. I will come
back to that when I have time.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: Re: I want to stay with a sibling window
Date: Fri, 11 Jun 2010 19:13:25 +0200

> There is a bug in the patch. I assumed that if "sib" was non-nil then
> it would be a buffer window. That is not the case so a check of that
> must be made. The most simple is to add another check with
> WINDOW_LIVE_P.

Indeed.  BTW note that the entire job of finding swindow was already
geared towards making the deletion of internal windows possible.

martin

Message #19 received at 6400-done <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 6400-done <at> debbugs.gnu.org
Subject: Re: I want to stay with a sibling window
Date: Tue, 11 Oct 2011 11:31:16 +0200

> A small patch to make the selected window one of the siblings when the
> selected window is deleted.

When the selected window is deleted emacs now selects the most recently
selected live window on that frame instead.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.