GNU bug report logs - #63979
SHEPHERD-SERVICE-CANONICAL-NAME assumes a non-empty PROVISION, but such instantiation is allowed

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Attila Lendvai <attila <at> lendvai.name>
Subject: bug#63979: closed (Re: bug#64119: [PATCH] services: shepherd:
 Sanitize 'provision' field.)
Date: Sun, 25 Jun 2023 21:46:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#63979: SHEPHERD-SERVICE-CANONICAL-NAME assumes a non-empty PROVISION, but such instantiation is allowed

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 63979 <at> debbugs.gnu.org.

-- 
63979: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63979
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: attila <at> lendvai.name, 64119 <at> debbugs.gnu.org, 63979-done <at> debbugs.gnu.org
Subject: Re: bug#64119: [PATCH] services: shepherd: Sanitize 'provision' field.
Date: Sun, 25 Jun 2023 23:44:53 +0200

Bruno Victal <mirai <at> makinata.eu> skribis:

> +(define (sanitize-shepherd-service-provision expr)
> +  (match expr
> +    (((? symbol?) ..1) expr)
> +    (_
> +     (raise
> +      (formatted-message
> +       (G_ "'provision' must be a non-empty list of symbols"))))))

Actually I figured we could do as in other areas of the code in a way
that reports error location, so I came up with a different patch.

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Attila Lendvai <attila <at> lendvai.name>
To: "bug-guix <at> gnu.org" <bug-guix <at> gnu.org>
Subject: SHEPHERD-SERVICE-CANONICAL-NAME assumes a non-empty PROVISION,
 but such instantiation is allowed
Date: Fri, 09 Jun 2023 15:18:47 +0000

it's possible to instantiate a SHEPHERD-SERVICE with an empty list as PROVISION, but then much later in time and space SHEPHERD-SERVICE-CANONICAL-NAME dies on it.

-- 
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“You live within a framework of perception that's determined by your values. […] We never think of the world as something that reveals itself through our values, but of course it does! Because you look at what you want. […] Whatever you're focusing on is directed by what you value.”
	— Jordan Peterson (1962–)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.