From unknown Sun Aug 17 22:00:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#63979 <63979@debbugs.gnu.org> To: bug#63979 <63979@debbugs.gnu.org> Subject: Status: SHEPHERD-SERVICE-CANONICAL-NAME assumes a non-empty PROVISION, but such instantiation is allowed Reply-To: bug#63979 <63979@debbugs.gnu.org> Date: Mon, 18 Aug 2025 05:00:20 +0000 retitle 63979 SHEPHERD-SERVICE-CANONICAL-NAME assumes a non-empty PROVISION= , but such instantiation is allowed reassign 63979 guix submitter 63979 Attila Lendvai severity 63979 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 09 11:19:10 2023 Received: (at submit) by debbugs.gnu.org; 9 Jun 2023 15:19:10 +0000 Received: from localhost ([127.0.0.1]:60114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7dtO-0005CU-2N for submit@debbugs.gnu.org; Fri, 09 Jun 2023 11:19:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:52162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7dtM-0005CI-B6 for submit@debbugs.gnu.org; Fri, 09 Jun 2023 11:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7dtG-0005U8-Hs for bug-guix@gnu.org; Fri, 09 Jun 2023 11:19:08 -0400 Received: from mail-4018.proton.ch ([185.70.40.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7dtD-0005va-FO for bug-guix@gnu.org; Fri, 09 Jun 2023 11:19:02 -0400 Date: Fri, 09 Jun 2023 15:18:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail3; t=1686323936; x=1686583136; bh=WiTbV5ofVkAZM1OygsosxE4YN2IFnVqmsHojpRwcaxA=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=p3mm+SyVuzGlSPu2Ivbyq1+YHBhDNaeahuuTKesg6Qaig6KS/LJJ91Bo9kRfvyTtN C4i0SikGjWODzhOC7U43XPDNUVFpo1r+8OjEMqBmfi9cjbMIIiaHH3dxkg2ElUE/9f u7rJUtSiXSBfOzUYwAzOluQGds7D2UeqTWaEffRsfememKk89DL2gL2IgAQGps/cFC 2lUIRVAVjHtaALgOOfvASmpaJwPyYHuskDAZOgMs3c1IeFf/asFdGM1XsWh7YEiTF2 LL8fk5DgnMiYfIRnGHkfFlMwS6C/5Kk3jI9twUumL2BzJGG9FZ0Sktm18xeRVRmvKu b9JuWhXeDT7Kg== To: "bug-guix@gnu.org" From: Attila Lendvai Subject: SHEPHERD-SERVICE-CANONICAL-NAME assumes a non-empty PROVISION, but such instantiation is allowed Message-ID: Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.18; envelope-from=attila@lendvai.name; helo=mail-4018.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) it's possible to instantiate a SHEPHERD-SERVICE with an empty list as PROVI= SION, but then much later in time and space SHEPHERD-SERVICE-CANONICAL-NAME= dies on it. --=20 =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CYou live within a framework of perception that's determined by you= r values. [=E2=80=A6] We never think of the world as something that reveals= itself through our values, but of course it does! Because you look at what= you want. [=E2=80=A6] Whatever you're focusing on is directed by what you = value.=E2=80=9D =09=E2=80=94 Jordan Peterson (1962=E2=80=93) From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 17 10:04:56 2023 Received: (at 63979) by debbugs.gnu.org; 17 Jun 2023 14:04:56 +0000 Received: from localhost ([127.0.0.1]:52198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAWXw-0004FG-Df for submit@debbugs.gnu.org; Sat, 17 Jun 2023 10:04:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAWXt-0004F3-7p for 63979@debbugs.gnu.org; Sat, 17 Jun 2023 10:04:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAWXm-0002Fd-KM; Sat, 17 Jun 2023 10:04:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=aAoNSQacNaC/m259gfb0AGbnCjV/yd9hwQwiD2c2pLk=; b=nDiv100y+T2C4Jln92/Q N2vReQZL/OoanAic5egHABvxJSPBsTgg/CyNuS2u9Rub7cQG+QCqy7OeimwTbTDuFWeLQ9PseYTGr L7QyGhk66TgoswIZyGlKvRQyww+m2Mi11/OoV2TAlqwGzXWFu/A1BQZsUDHpo+8Vhv+dfQ8OlNJhJ gEaAFZ0uwpLQjcSIj1AJ0GporpUA84ir91ok1MOtnsO7esAP5QJ16ZXrEftIlOjChwm1fnCuRBe43 eMOZlLIWSxxdwA7p2z0j1AmwxarooaJsRVtsIpv54K9wF8xWP49VOcoM+XKySkP+b+0egxrbJ8nYN G3o0ggXBQgIKsg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAWXm-0003fp-7i; Sat, 17 Jun 2023 10:04:46 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Attila Lendvai Subject: Re: bug#63979: SHEPHERD-SERVICE-CANONICAL-NAME assumes a non-empty PROVISION, but such instantiation is allowed References: Date: Sat, 17 Jun 2023 16:04:43 +0200 In-Reply-To: (Attila Lendvai's message of "Fri, 09 Jun 2023 15:18:47 +0000") Message-ID: <87r0qaqj5w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63979 Cc: 63979@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Attila Lendvai skribis: > it's possible to instantiate a SHEPHERD-SERVICE with an empty list as PRO= VISION, but then much later in time and space SHEPHERD-SERVICE-CANONICAL-NA= ME dies on it. Hi! At the level of Shepherd, this is now mitigated by Shepherd commit ad62ce37fe3a69e83672f0817ac2b67e05d0dd87. We should add similar checks in (gnu services shepherd). Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 25 17:45:13 2023 Received: (at 63979-done) by debbugs.gnu.org; 25 Jun 2023 21:45:13 +0000 Received: from localhost ([127.0.0.1]:43906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDXXl-0005wj-CQ for submit@debbugs.gnu.org; Sun, 25 Jun 2023 17:45:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDXXj-0005YE-36; Sun, 25 Jun 2023 17:45:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDXXc-0007z9-Pf; Sun, 25 Jun 2023 17:45:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=4ZF/uLy7I7/o5ecYjRfh7C4edyJ0UuKr4gA0UYpjzCo=; b=DrBVksNcVqKnxS6IjAeh VpCzCN78pgduXI/wD/51J08KEK0Pqs9Fl3RpKdJ7c5fDy6IUPK3eADXR8aDtQmGi8QnsOOYzII3vf rzjdJNtjcCDLKE//nYVq6O84pGtPwsFYQPYsxA9gNQSKWGXs4JuVRQIPU+Nnlj0BV9Vhn3n0bChPb G5BAe7yHrSw5R2r5xsJwXNMiUAwZD/ejDW/vNllew7lqFc03m0imKgkTb3DGSlxpEncD6YBd/rpif hAOe21HaBZqLKAtkPK4Lp118n+gx8uzQ3GvrGwTrIhxPyZ2KmQBRq+XWBrX8k+Mrrpk9Yhq6AtMLB 4r2qofWn+r3hfg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDXXY-00018w-5k; Sun, 25 Jun 2023 17:45:03 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Bruno Victal Subject: Re: bug#64119: [PATCH] services: shepherd: Sanitize 'provision' field. References: <9770a88a008fd1d087e829a6ad57b556346be9c0.1686947093.git.mirai@makinata.eu> Date: Sun, 25 Jun 2023 23:44:53 +0200 In-Reply-To: <9770a88a008fd1d087e829a6ad57b556346be9c0.1686947093.git.mirai@makinata.eu> (Bruno Victal's message of "Fri, 16 Jun 2023 21:25:24 +0100") Message-ID: <87o7l3w71m.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63979-done Cc: attila@lendvai.name, 64119@debbugs.gnu.org, 63979-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Bruno Victal skribis: > +(define (sanitize-shepherd-service-provision expr) > + (match expr > + (((? symbol?) ..1) expr) > + (_ > + (raise > + (formatted-message > + (G_ "'provision' must be a non-empty list of symbols")))))) Actually I figured we could do as in other areas of the code in a way that reports error location, so I came up with a different patch. Ludo=E2=80=99. From unknown Sun Aug 17 22:00:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 24 Jul 2023 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator