Subject: bug#63979: closed (Re: bug#64119: [PATCH] services: shepherd: Sanitize 'provision' field.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 25 Jun 2023 21:46:02 +0000

Your bug report

#63979: SHEPHERD-SERVICE-CANONICAL-NAME assumes a non-empty PROVISION, but such instantiation is allowed

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
63979: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63979
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#64119: [PATCH] services: shepherd: Sanitize 'provision' field.
From: Ludovic Courtès <[email-masked]>
To: Bruno Victal <[email-masked]>
Cc: [email-masked], [email-masked], [email-masked]
Date: Sun, 25 Jun 2023 23:44:53 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Bruno Victal <[email-masked]> skribis:

> +(define (sanitize-shepherd-service-provision expr)
> +  (match expr
> +    (((? symbol?) ..1) expr)
> +    (_
> +     (raise
> +      (formatted-message
> +       (G_ "'provision' must be a non-empty list of symbols"))))))

Actually I figured we could do as in other areas of the code in a way
that reports error location, so I came up with a different patch.

Ludo’.

Subject: SHEPHERD-SERVICE-CANONICAL-NAME assumes a non-empty PROVISION, but such instantiation is allowed
From: Attila Lendvai <[email-masked]>
To: "[email-masked]" <[email-masked]>
Date: Fri, 09 Jun 2023 15:18:47 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

it's possible to instantiate a SHEPHERD-SERVICE with an empty list as PROVISION, but then much later in time and space SHEPHERD-SERVICE-CANONICAL-NAME dies on it.

-- 
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“You live within a framework of perception that's determined by your values. […] We never think of the world as something that reveals itself through our values, but of course it does! Because you look at what you want. […] Whatever you're focusing on is directed by what you value.”
	— Jordan Peterson (1962–)