From unknown Thu Jun 19 16:20:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6397 <6397@debbugs.gnu.org> To: bug#6397 <6397@debbugs.gnu.org> Subject: Status: 24.0.50; `make-directory' return value Reply-To: bug#6397 <6397@debbugs.gnu.org> Date: Thu, 19 Jun 2025 23:20:18 +0000 retitle 6397 24.0.50; `make-directory' return value reassign 6397 emacs submitter 6397 "Drew Adams" severity 6397 minor tag 6397 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 10 16:51:22 2010 Received: (at submit) by debbugs.gnu.org; 10 Jun 2010 20:51:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMoif-0006ec-Jy for submit@debbugs.gnu.org; Thu, 10 Jun 2010 16:51:21 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMoid-0006eX-0f for submit@debbugs.gnu.org; Thu, 10 Jun 2010 16:51:19 -0400 Received: from lists.gnu.org ([199.232.76.165]:40506) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMoiY-0001RZ-E4 for submit@debbugs.gnu.org; Thu, 10 Jun 2010 16:51:14 -0400 Received: from [140.186.70.92] (port=35061 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMoiX-0001nw-30 for bug-gnu-emacs@gnu.org; Thu, 10 Jun 2010 16:51:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMoiV-0005Kw-QH for bug-gnu-emacs@gnu.org; Thu, 10 Jun 2010 16:51:12 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:63501) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMoiV-0005Ke-Jq for bug-gnu-emacs@gnu.org; Thu, 10 Jun 2010 16:51:11 -0400 Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o5AKp6mE015189 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Jun 2010 20:51:08 GMT Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o5AIunhV011122 for ; Thu, 10 Jun 2010 20:51:05 GMT Received: from abhmt007.oracle.com by acsmt355.oracle.com with ESMTP id 315244581276202961; Thu, 10 Jun 2010 13:49:21 -0700 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 10 Jun 2010 13:49:21 -0700 From: "Drew Adams" To: Subject: 24.0.50; `make-directory' return value Date: Thu, 10 Jun 2010 13:49:23 -0700 Message-ID: <3F4EAEC98DA7485299F2D80D33002278@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 Thread-Index: AcsI3mhCmJ1hPvUAT8uZe5uq+QBb5g== X-Auth-Type: Internal IP X-Source-IP: rcsinet15.oracle.com [148.87.113.117] X-CT-RefId: str=0001.0A090202.4C11503D.001D:SCFMA4539811,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) The doc for `make-directory' doesn't mention its return value, and the code doesn't seem to do anything special about it. I think it should return non-nil (e.g. the directory name) if the creation succeeds and nil if it fails without error. And that should be documented. Or if it always raises an error when it does not create a directory, that's OK too, but that should then be documented. Yes, you can always determine whether it succeeded by checking `file-accessible-directory-p' or `file-exists-p' afterward (and beforehand, and comparing), but reasonable creation functions let you know whether they succeed. In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-06-07 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include' From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 11 04:18:52 2010 Received: (at 6397) by debbugs.gnu.org; 11 Jun 2010 08:18:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMzRz-0004Ld-Uw for submit@debbugs.gnu.org; Fri, 11 Jun 2010 04:18:52 -0400 Received: from smtp-out2.starman.ee ([85.253.0.4] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMzRx-0004LW-SW for 6397@debbugs.gnu.org; Fri, 11 Jun 2010 04:18:50 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.28.166.cable.starman.ee [82.131.28.166]) by mx2.starman.ee (Postfix) with ESMTP id 529D33F40B9; Fri, 11 Jun 2010 11:18:44 +0300 (EEST) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#6397: 24.0.50; `make-directory' return value Organization: JURTA References: <3F4EAEC98DA7485299F2D80D33002278@us.oracle.com> Date: Fri, 11 Jun 2010 11:12:51 +0300 In-Reply-To: <3F4EAEC98DA7485299F2D80D33002278@us.oracle.com> (Drew Adams's message of "Thu, 10 Jun 2010 13:49:23 -0700") Message-ID: <87r5keuhrk.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 6397 Cc: 6397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) > The doc for `make-directory' doesn't mention its return value, and the > code doesn't seem to do anything special about it. There is also a related bug#6363. > I think it should return non-nil (e.g. the directory name) if the > creation succeeds and nil if it fails without error. And that should be > documented. Or if it always raises an error when it does not create a > directory, that's OK too, but that should then be documented. What should it return when the creation of some parents succeeds, and fails for the rest? -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 11 09:34:21 2010 Received: (at 6397) by debbugs.gnu.org; 11 Jun 2010 13:34:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ON4NI-0007Rf-9f for submit@debbugs.gnu.org; Fri, 11 Jun 2010 09:34:20 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ON4NG-0007Ra-Fx for 6397@debbugs.gnu.org; Fri, 11 Jun 2010 09:34:19 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o5BDY9X9005665 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 11 Jun 2010 13:34:11 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o5BDOGIw008858; Fri, 11 Jun 2010 13:34:08 GMT Received: from abhmt019.oracle.com by acsmt354.oracle.com with ESMTP id 317413781276263199; Fri, 11 Jun 2010 06:33:19 -0700 Received: from dradamslap1 (/141.144.224.37) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 11 Jun 2010 06:33:19 -0700 From: "Drew Adams" To: "'Juri Linkov'" References: <3F4EAEC98DA7485299F2D80D33002278@us.oracle.com> <87r5keuhrk.fsf@mail.jurta.org> Subject: RE: bug#6397: 24.0.50; `make-directory' return value Date: Fri, 11 Jun 2010 06:33:17 -0700 Message-ID: <148DE0D4282044199ACF3A1E4433FDED@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87r5keuhrk.fsf@mail.jurta.org> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 Thread-Index: AcsJPribRWtmFrjtTqGrsGGaYZIbnAAKtPkg X-Auth-Type: Internal IP X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-CT-RefId: str=0001.0A090206.4C123B53.01C7:SCFMA922111,ss=1,fgs=0 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 6397 Cc: 6397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) > > The doc for `make-directory' doesn't mention its return > > value, and the code doesn't seem to do anything special > > about it. > > There is also a related bug#6363. > > > I think it should return non-nil (e.g. the directory name) if the > > creation succeeds and nil if it fails without error. And > > should be documented. Or if it always raises an error when it > > does not create a directory, that's OK too, but that should then > > be documented. > > What should it return when the creation of some parents succeeds, > and fails for the rest? Why do we let that happen? That seems like a bug. Is there some use case for that? If not, can we fix it, to make the creation all-or-nothing (e.g. delete any created unless all are)? If the aim of the function is to create directory /a/lot/of/parents/foo, then what sense does it make to create only some of the parents? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 18:23:25 2011 Received: (at 6397) by debbugs.gnu.org; 13 Jul 2011 22:23:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7q1-00043t-1u for submit@debbugs.gnu.org; Wed, 13 Jul 2011 18:23:25 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7pu-00043H-NQ for 6397@debbugs.gnu.org; Wed, 13 Jul 2011 18:23:19 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh7ph-0006Hx-IA; Thu, 14 Jul 2011 00:23:05 +0200 From: Lars Magne Ingebrigtsen To: "Drew Adams" Subject: Re: 24.0.50; `make-directory' return value In-Reply-To: <3F4EAEC98DA7485299F2D80D33002278@us.oracle.com> (Drew Adams's message of "Thu, 10 Jun 2010 13:49:23 -0700") Date: Thu, 14 Jul 2011 00:22:54 +0200 Message-ID: References: <3F4EAEC98DA7485299F2D80D33002278@us.oracle.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: David Byrne and Brian Eno's _My Life In The Bush Of Ghosts_: "The Jezebel Spirit" X-Hashcash: 1:23:110713:6397@debbugs.gnu.org::wFO0hDXjIyzNSqtz:000000000000000000000000000000000000000004Q5J X-Hashcash: 1:23:110713:drew.adams@oracle.com::v495mdfLH+OWVFsQ:0000000000000000000000000000000000000000II4z MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qh7ph-0006Hx-IA X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311200585.66236@ABzWajGCy/L5d0xxzZxd5Q X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 6397 Cc: 6397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) "Drew Adams" writes: > I think it should return non-nil (e.g. the directory name) if the > creation succeeds and nil if it fails without error. And that should be > documented. Or if it always raises an error when it does not create a > directory, that's OK too, but that should then be documented. So you want the doc string to say that it will raise an error if there's an error? Ok, I've now done that. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 18:23:12 2011 Received: (at control) by debbugs.gnu.org; 13 Jul 2011 22:23:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7pn-000439-P6 for submit@debbugs.gnu.org; Wed, 13 Jul 2011 18:23:11 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7pl-00042v-Fj for control@debbugs.gnu.org; Wed, 13 Jul 2011 18:23:09 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh7pa-0006HP-7k for control@debbugs.gnu.org; Thu, 14 Jul 2011 00:22:58 +0200 Date: Thu, 14 Jul 2011 00:22:57 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #6397 X-MailScanner-ID: 1Qh7pa-0006HP-7k X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311200578.33762@x+j4/O0CsAl1rQMIieKN7Q X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 6397 fixed close 6397 24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 18:48:01 2011 Received: (at 6397) by debbugs.gnu.org; 13 Jul 2011 22:48:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh8Do-0006NY-Sa for submit@debbugs.gnu.org; Wed, 13 Jul 2011 18:48:01 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh8Dn-0006NL-ER for 6397@debbugs.gnu.org; Wed, 13 Jul 2011 18:47:59 -0400 Received: from rtcsinet22.oracle.com (rtcsinet22.oracle.com [66.248.204.30]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p6DMlo00018835 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jul 2011 22:47:53 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by rtcsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p6DMlnlp003947 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Jul 2011 22:47:50 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p6DMliHY026742; Wed, 13 Jul 2011 17:47:44 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 13 Jul 2011 15:47:44 -0700 From: "Drew Adams" To: "'Lars Magne Ingebrigtsen'" References: <3F4EAEC98DA7485299F2D80D33002278@us.oracle.com> Subject: RE: 24.0.50; `make-directory' return value Date: Wed, 13 Jul 2011 15:47:46 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcxBq3oQe7mbucNcSPew3kzVXeldtwAAzxNQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: rtcsinet22.oracle.com [66.248.204.30] X-CT-RefId: str=0001.0A090205.4E1E2099.002F:SCFSTAT5015188, ss=1, re=-4.000, fgs=0 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 6397 Cc: 6397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) > So you want the doc string to say that it will raise an error > if there's an error? Ok, I've now done that. Thanks. But it sounds like there might still be a bug if the creation of the directory and any missing parents is not an atomic transaction. See the rest of the thread. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 19:20:19 2011 Received: (at 6397) by debbugs.gnu.org; 13 Jul 2011 23:20:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh8j1-00077R-P6 for submit@debbugs.gnu.org; Wed, 13 Jul 2011 19:20:19 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh8is-00076d-SB for 6397@debbugs.gnu.org; Wed, 13 Jul 2011 19:20:11 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh8if-0006zQ-VB; Thu, 14 Jul 2011 01:19:53 +0200 From: Lars Magne Ingebrigtsen To: "Drew Adams" Subject: Re: 24.0.50; `make-directory' return value In-Reply-To: (Drew Adams's message of "Wed, 13 Jul 2011 15:47:46 -0700") Date: Thu, 14 Jul 2011 01:19:50 +0200 Message-ID: References: <3F4EAEC98DA7485299F2D80D33002278@us.oracle.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEXEW125HTPSJztFChO+ P0TLMT3aIjrbk5wl8N22AAACXUlEQVQ4jXWUPXPbMAyG0TMtrkFku7N5cWbpqEtWKmKStXYjdZXV mlnZi1L8/QKS/JH0ykHm4fELgNBLQWqHhbjcrVN0ANUYgBHkiDuDuAA6AcwxFYExa0RHpPsJbNEw wevQcVwzmCRwGwLyWoU9LjgOvppACIFz4C0rfki8tFOqRsD2mvkmUvQ+vQRLwwnD6yx34BWmOIAE gqlNEGC/EmjwvpQ2ASh0O4kn7TPXoPnLY81dCkjCsHRPvCLUu03KRwBN8wn8FgBQh03JUwCIcQTt AIi7qevbdXoB3vl8URLXdSfgVCQupEYIB0gEtHpSBNgz4T+1icwNAkyC0M7TjP7wbwidMRDOC/ZW H//VXYJwsFfH7VnB41l+t3fhs+LnONN/wD79D5gE9u6Y4VgDJ/D0WbGVaFGUzWcwvGnv1MWhxucI TkM4gW++srmHD2Pg2bRzNgErFlzBNOcaLYBSAlaHBZSro4Id1UYtitwvvMPDIDE11LghUuC4iC1K j16s1PE7D1Ys61Q5nDEvvJPWzAbCjVi857Z4XIUvQCVjcS5I1EcGxTM7w4E6tluJaZT3mi3tCL64 xxGsOcLmKJSONtNAvY7JkMo0rdhMEqmMvcSJYRz7spW9tZpAsYIGwO3i1XsgktLcsxYiPusQVr8o 6lja6r7PgLfE1ur4BkN45b3imT+/VZmeWb46zaBoXgnkFPZ+Zm3GV8374W5D00Z6k/eqMsdPvmk4 fCm4A+qrTAjZ3CncNRu59wJgNlx5rXyVo3+Q0abyAUhu7GkV+uVpch/Uyf4MrNs+yAeBd38B2xIy 4jo/qKcAAAAASUVORK5CYII= X-Now-Playing: Depeche Mode's _Speak & Spell_: "Photographic" X-Hashcash: 1:23:110713:drew.adams@oracle.com::r+OVkyVEXfIJqwGW:00000000000000000000000000000000000000009zf8 X-Hashcash: 1:23:110713:6397@debbugs.gnu.org::gw0scDHa9m65yT8/:00000000000000000000000000000000000000001CUJ2 MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qh8if-0006zQ-VB X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311203994.0654@Mo2ZSWALGaCrTGcbDUoJXg X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 6397 Cc: 6397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) "Drew Adams" writes: > But it sounds like there might still be a bug if the creation of the directory > and any missing parents is not an atomic transaction. See the rest of the > thread. I don't think there's anything that can be done about that. Creating a full path isn't atomic, and deleting the directories we've already made is bad, too. Some other process may have wanted the directories at the same time, and would bug out if we started deleting them. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 19:46:14 2011 Received: (at 6397) by debbugs.gnu.org; 13 Jul 2011 23:46:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh98A-0000zy-EW for submit@debbugs.gnu.org; Wed, 13 Jul 2011 19:46:14 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh989-0000zl-0X for 6397@debbugs.gnu.org; Wed, 13 Jul 2011 19:46:13 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p6DNk41H030984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jul 2011 23:46:06 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p6DNk35O020845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Jul 2011 23:46:03 GMT Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p6DNjwgF015188; Wed, 13 Jul 2011 18:45:58 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 13 Jul 2011 16:45:58 -0700 From: "Drew Adams" To: "'Lars Magne Ingebrigtsen'" References: <3F4EAEC98DA7485299F2D80D33002278@us.oracle.com> Subject: RE: 24.0.50; `make-directory' return value Date: Wed, 13 Jul 2011 16:45:56 -0700 Message-ID: <9D1FDD7C623F4C0BB2CAB12AB5B2EF30@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcxBs2ljLSa/ZhXzQkaIVbX7UqUhAAAAvG5g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4E1E2E3F.0030:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 6397 Cc: 6397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) > I don't think there's anything that can be done about that. > Creating a full path isn't atomic, We know we're trying to create a hierachy of directories, and we know that it must be an all-or-nothing transaction. Why can't we make this atomic in this particular case? There's nothing magic about transactions. In this case the rollback would be simple: delete any directories created if for some reason we cannot create them all. > and deleting the directories we've already made > is bad, too. Why? That's a normal rollback for this. There's not a lot going on here: just directory creation. > Some other process may have wanted the directories at the > same time, and would bug out if we started deleting them. I suppose that's a legitimate point in the abstract, but highly unlikely in practice. And there is probably some way (file attributes? permissions?) of making any created directories invisible/inaccessible during the transaction. I don't see why Emacs Dev wouldn't try to fix this correctly. Unless I'm missing something. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 19:56:05 2011 Received: (at 6397) by debbugs.gnu.org; 13 Jul 2011 23:56:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh9Hd-0001Eo-5J for submit@debbugs.gnu.org; Wed, 13 Jul 2011 19:56:05 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh9HX-0001EV-Uo for 6397@debbugs.gnu.org; Wed, 13 Jul 2011 19:56:00 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh9HM-0007Wc-RC; Thu, 14 Jul 2011 01:55:44 +0200 From: Lars Magne Ingebrigtsen To: "Drew Adams" Subject: Re: 24.0.50; `make-directory' return value In-Reply-To: <9D1FDD7C623F4C0BB2CAB12AB5B2EF30@us.oracle.com> (Drew Adams's message of "Wed, 13 Jul 2011 16:45:56 -0700") Date: Thu, 14 Jul 2011 01:54:17 +0200 Message-ID: References: <3F4EAEC98DA7485299F2D80D33002278@us.oracle.com> <9D1FDD7C623F4C0BB2CAB12AB5B2EF30@us.oracle.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Depeche Mode's _A Broken Frame_: "Satellite" X-Hashcash: 1:23:110713:drew.adams@oracle.com::naQgdqlP/P4GzZVH:0000000000000000000000000000000000000000Z1Aa X-Hashcash: 1:23:110713:6397@debbugs.gnu.org::2wEkXV/rdhqhRGLq:00000000000000000000000000000000000000001hLH/ MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qh9HM-0007Wc-RC X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311206144.92041@+b5CUqOPB5dlwRqrs8U9hg X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 6397 Cc: 6397@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) "Drew Adams" writes: > I suppose that's a legitimate point in the abstract, but highly unlikely in > practice. And there is probably some way (file attributes? permissions?) of > making any created directories invisible/inaccessible during the transaction. Nope. There isn't. You often see this sort of problem in web server caches, where you have a gazillion processes all trying to create variants on the same directory structures. This may fail because two processes tries to create /var/tmp/cache/foo/bar/zot at the same time, for instance. Trying to unwind this in a general fashion is impossible, and must be left to a higher level to determine what to do. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Thu Jun 19 16:20:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Aug 2011 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator